Commit Graph

23983 Commits

Author SHA1 Message Date
Martin Brennan 7c92402e15
UX: Lots of wizard canvas rendering improvements
* Make sure bold body font loads before rendering otherwise
  the 1/20 post count on the timeline will use wrong font
* Fix pill button rendering on homepage preview, now all
  the widths resize based on the font size/width and all
  buttons depend on the X position of the button beforehand
* Fix the table header labels overlapping by giving them more
  room based on col position
* Moving hardcoded label text into I18n
2024-12-06 16:58:54 +10:00
Martin Brennan 9c6e5440d8
FIX: Homepage preview font colors 2024-12-05 17:30:46 +10:00
Martin Brennan af5eed5005
UX: Wizard style preview improvements
* Render date on timeline
* Render timeline handle thicker and with a small gap at top
* Make sure body text does not overflow over timeline with
  bounding box calculation and dymanic font resizing
* Other minor improvements to spacing/sizing
2024-12-05 17:15:13 +10:00
Martin Brennan 2ac2c42b06
UX: Rearrange wizard steps
Reorder steps:
* “Your site is ready” from 3 → 4
* “Logos” from 4 → 5
* “Look and feel” from 5 → 3

So the new order goes “Look and feel”, “Your site is ready”, “Logos”, “Boring legal stuff”
2024-12-05 13:43:08 +10:00
Martin Brennan 641099e720
FEATURE: Bring back branded blob background to wizard 2024-12-05 13:12:49 +10:00
Martin Brennan 8533290a9c
Merge branch 'main' into feature/wizard-look-and-feel-improvements 2024-12-05 09:35:48 +10:00
Gary Pendergast bb2e9645f2
FIX: Move granted badges to the end of the post header. (#30095) 2024-12-05 09:22:03 +11:00
dependabot[bot] 3b27ef9bbd
Build(deps-dev): Bump @swc/core from 1.9.3 to 1.10.0 (#30113)
Bumps [@swc/core](https://github.com/swc-project/swc) from 1.9.3 to 1.10.0.
- [Release notes](https://github.com/swc-project/swc/releases)
- [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md)
- [Commits](https://github.com/swc-project/swc/compare/v1.9.3...v1.10.0)

---
updated-dependencies:
- dependency-name: "@swc/core"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-05 06:18:46 +08:00
Kris 19f530a827
UX: refactor title editing CSS to improve layout (#30109) 2024-12-04 16:30:48 -05:00
Kris 5c2e05cf5d
UX: fix topic map padding in low-content situations (#30101) 2024-12-04 09:39:14 -05:00
Joffrey JAFFEUX 3ddb1cfbad
FIX: ensures tabbing from trigger focus content (#30064)
`DMenu` is using in-element, which means the content is detached from the trigger, and pressing tab from the trigger is not going to jump into the content. This commit catches the tab event and attempts to focus the first focusable element of the content.
2024-12-04 12:46:02 +01:00
Régis Hanol d2d8fbcf3b
FIX: properly quote videos (#30099)
Follow up to f294f984cf

All that was needed was a little fix to our markdown engine to use the
"image src" as the "video src" when the "data video src" was not
defined.

That way we can use the regular image markdown with the "|video" option
(?).
2024-12-04 12:39:38 +01:00
Régis Hanol f294f984cf
FIX: unable to quote video (#30077)
This replaces the video container / thumbnail with a proper "<video>" element when quoting a video.

It's not the best UX, especially when "morphing" is disabled.

Needs more work.

Internal ref - t/143321
2024-12-04 11:56:28 +01:00
Martin Brennan 01f3161a73
FIX: Accurate sizing for Reply and Share buttons
We can use `ctx.measureText` when rendering the canvas
to get accurate text widths taking into account fonts etc.
so we can better size the rectangles around these buttons.
2024-12-04 14:41:21 +10:00
dependabot[bot] 545cafe657
Build(deps): Bump @faker-js/faker from 9.2.0 to 9.3.0 (#30078) 2024-12-04 01:30:39 +01:00
dependabot[bot] 313eddec7f
Build(deps-dev): Bump qunit from 2.22.0 to 2.23.0 (#30079) 2024-12-04 01:30:03 +01:00
dependabot[bot] cb82d798ef
Build(deps-dev): Bump webpack from 5.96.1 to 5.97.0 (#30082) 2024-12-04 00:45:25 +01:00
Jarek Radosz 94697467af
DEV: Add `topic-list-item-class` transformer (#30008) 2024-12-03 14:22:13 +01:00
Jarek Radosz 48323230a4
FIX: Stick to then/finally in history-store (#30061)
async/await doesn't play well with transitions (to be investigated… later)
2024-12-03 14:13:26 +01:00
David Taylor c3e87b5036
UX: Only add `user-badge-buttons` wrapper when badges exist (#30060)
Followup to 2513339955
2024-12-03 13:12:44 +00:00
Jarek Radosz 9389bf295c
DEV: Make history-store work in non-accceptance tests (#30059) 2024-12-03 13:32:37 +01:00
Régis Hanol 806e37aaec
FIX: better edit conflict handling (#29789)
* FIX: better edit conflict handling

Properly keep track of the original title and tags when dealing with edit conflicts.

Internal ref - t/141218
2024-12-03 10:12:04 +01:00
Ella E. ef9d7579df
UX: Add admin filter row styling (#30057)
* DEV: add scss file for admin filter

* UX: apply styling for the filter row
2024-12-03 18:22:13 +11:00
Martin Brennan 8d6fa99c29
UX: Do not use Lorem Ipsum for wizard preview text
Lipsum looks ugly and techy, let's use some actual
category names and topic titles instead.
2024-12-03 15:52:58 +10:00
Martin Brennan 377380a2f4
DEV: Minor improvements to code and adding specs 2024-12-03 14:17:33 +10:00
Martin Brennan c03d6919be
FIX: Homepage preview category names were broken 2024-12-03 14:17:02 +10:00
Martin Brennan 11fb5ac5d3
FEATURE: Improve font selector in wizard
Changes the wizard font selector dropdown to show
a preview of all fonts with a CSS class so you don't
have to choose the font to get a preview.

Also makes the fonts appear in alphabetical order.
2024-12-03 14:13:23 +10:00
Gary Pendergast 2513339955
FEATURE: Show when a badge has been granted for a post (#29696)
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
2024-12-03 13:43:27 +11:00
Kelv 435fbb7408
DEV: unsilence deprecation warning for old Font Awesome icons (#30028)
* DEV: unsilence deprecation warnings for old Font Awesome icon names

* update fa-user to user font awesome icon name
* update pencil-alt to pencil font awesome 6 icon name
2024-12-03 10:28:39 +08:00
Gabriel Grubba 98ba5f2dfa
FEATURE: Add plugin outlets to parent category row for desktop (#30002)
* FEATURE: Add plugin outlets to parent category row

Added 3 plugin outlets:

- `category-list-above-category-section` (above `td.category`)
- `category-list-above-topics-section` (above `td.topics`)
- `category-list-below-topics-section` (below `td.topics`)

* DEV: Add value transformer for changing classes in parent category row.

renamed connectors and added connector for mobile view

* DEV: order transformers by name
2024-12-02 18:27:30 -03:00
Renato Atilio 85691a7f31
DEV: refactor composer-editor/d-editor, a little more (#29973)
Adds setupEditor to ComposerEditor so it can setup/destroy events when the underlying editorComponent is switched.

Moves putCursorAtEnd uses (which implementation is textarea-specific) to TextareaTextManipulation.

Moves insertCurrentTime and a corresponding test, which is discourse-local-dates specific, to the plugin.

Moves applyList and formatCode from DEditor to the TextareaTextManipulation.

Moves DEditor._applySurround to TextareaTextManipulation.applySurroundSelection

Avoids resetting the textarea value on applyList and formatCode, keeping the undo history.
2024-12-02 18:24:14 -03:00
David Taylor 7750441c43
DEV: Correct ember-template-lint commands (again) (#30038)
This was fixed in 5563e9dc03, but then regressed again by an unintentional change in 6f7c581a80
2024-12-02 18:13:40 +00:00
Juan David Martínez Cubillos 31dadc8373
DEV: Add plugin wrappers required to fix template overrides (#29825)
* DEV: Add plugin wrappers required to fix tempalte overrides

* updated search-result-entry file

* activity file unintended changes fixed
2024-12-02 13:07:27 -05:00
Jordan Vidrine 3b334f54fc
FIX: adjust codeblock link styling (#30036) 2024-12-02 09:49:54 -06:00
Jan Cernik cb663b89cc
FIX: Virtual keyboard for fullpage login/signup (#29543)
This change allows the form to resize when the virtual keyboard is shown on Chrome/Android
2024-12-02 12:33:51 -03:00
Jarek Radosz 72f3cd252f
DEV: Use new qunit-dom's includesValue/doesNotIncludeValue (#30034) 2024-12-02 16:30:56 +01:00
Régis Hanol 9bdd97db42
FIX: editing post while replying (#29985)
BEFORE: if you click the "reply" button on a post and then decided that you want to "edit" the same post, clicking the "edit" button would do nothing. Clicking "edit" on another post works, but editing the same post would appear broken.

AFTER: if you click the "edit" button, it will properly load the content of the post you're trying to edit. No matter which one it is.

This was somewhat tricky to track down as the system specs seemed to contradict the qunit tests until I realized that the qunit tests were only testing the edit on the 1st post and the system specs were testing on replies.

I improved the qunit tests to test both editing OP and a reply and (hopefully) made the system specs a little bit clearer.

This is a follow up to bbe62d88d2.
2024-12-02 16:06:36 +01:00
Régis Hanol ab32623c07
UX: disable scrolling when modal is open on desktop (#30035)
Uses the `htmlClass` to automagically set the `modal-open` class to
`<html>` so that we can do `overflow: hidden` and prevent the
"background" behind the modal from scrolling while the modal is open.

Internal ref - t/142760
2024-12-02 15:08:43 +01:00
dependabot[bot] 62fc2a383a
Build(deps): Bump @glimmer/syntax from 0.92.3 to 0.93.1 (#30032)
Bumps [@glimmer/syntax](https://github.com/glimmerjs/glimmer-vm) from 0.92.3 to 0.93.1.
- [Release notes](https://github.com/glimmerjs/glimmer-vm/releases)
- [Changelog](https://github.com/glimmerjs/glimmer-vm/blob/main/CHANGELOG.md)
- [Commits](https://github.com/glimmerjs/glimmer-vm/commits)

---
updated-dependencies:
- dependency-name: "@glimmer/syntax"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 12:19:33 +00:00
dependabot[bot] 08542400ad
Build(deps-dev): Bump jsuites from 5.7.2 to 5.8.0 (#30033)
Bumps [jsuites](https://github.com/jsuites/jsuites) from 5.7.2 to 5.8.0.
- [Release notes](https://github.com/jsuites/jsuites/releases)
- [Changelog](https://github.com/jsuites/jsuites/blob/master/changelog.md)
- [Commits](https://github.com/jsuites/jsuites/commits)

---
updated-dependencies:
- dependency-name: jsuites
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-12-02 12:18:52 +00:00
dependabot[bot] 7d5d1dcc51
Build(deps-dev): Bump qunit-dom from 3.3.0 to 3.4.0 (#30030) 2024-12-02 13:18:28 +01:00
Arpit Jalan 746d145258
FEATURE: pass faqOverridden to about-wrapper plugin outlet (#29994)
Ref: https://github.com/discourse/discourse-woot-theme/pull/29
2024-12-02 12:55:06 +05:30
Jarek Radosz c4d86635d1
DEV: Update decorator-transforms to 2.3.0 (#30020)
1. the patch is no longer needed
2. this unblocks dependabot (it's been erroring out for a bit)
2024-12-02 01:04:20 +01:00
Jarek Radosz b3423c40b0
DEV: Fix random typos (#30023)
(late) Nov 2024 edition
2024-12-02 07:34:05 +08:00
Krzysztof Kotlarek 6d4c6ee154
UX: admins users page follows admin ux guideline (#29873)
Conversion of `/admin/users` page to follow admin UX guidelines.

In addition, add the username to the title on the user admin page.
2024-12-02 10:11:23 +11:00
Jarek Radosz 6e4baaf092
DEV: Use qunit-dom's `hasValue` wherever possible (#30018) 2024-12-01 20:37:24 +01:00
Jarek Radosz efa2589204
DEV: Finish qunit-dom hasText migration (#30017) 2024-12-01 14:00:48 +01:00
Jarek Radosz 1396aef99f
DEV: Make the `logIn` helper replace current-user service (#30010) 2024-11-30 17:23:51 +01:00
Jarek Radosz dfb74d90c3
DEV: Extensively use qunit-dom's hasText (#30012) 2024-11-30 16:44:51 +01:00
Jarek Radosz bf3e75ca70
DEV: Reduce async/indirection in site-header (#30011) 2024-11-30 15:33:38 +01:00