8981ca41f0
correct acceptance test
2016-02-17 18:38:57 +11:00
482a65821b
FIX: Latest eslint doesn't recognize TypedArray
2016-02-15 11:12:57 +01:00
878ced8920
FIX: Latest eslint doesn't recognize TypedArray
2016-02-12 13:31:26 -05:00
960f9ed132
FIX: Broken test
2016-02-11 16:51:50 -05:00
d1e85bdd8b
FEATURE: Use virtual dom framework for faster post rendering
2016-02-11 11:00:40 -05:00
c0feea4629
Add tests for category hashtag.
2016-02-04 15:52:40 +08:00
4cd07fbb29
Fix broken tests.
2016-02-04 15:24:49 +08:00
2c19e7f73d
Fix the build.
2016-01-29 17:52:30 +08:00
07b244741c
FIX: the build.
2016-01-21 16:21:54 +08:00
bd86e88b05
UX: Remove category hashtag decoration.
2016-01-21 12:27:52 +08:00
fa794ef59d
FIX: Deleting characters on category hashtag was not triggering autocomplete.
2016-01-20 17:18:04 +08:00
9652c3df4f
FIX: Don't track category-badges links.
2016-01-20 12:48:00 +08:00
4a7f560a35
FEATURE: Decorate category hashtag links.
2016-01-19 10:58:15 +08:00
57c3d65777
Change `d-editor` to use `_` instead of `*` for italics.
2016-01-18 14:54:54 -05:00
f519834824
FIX: Don't include child categories when term is black.
2016-01-08 11:26:06 +08:00
c947c75de3
FIX: Make eslint happy.
2016-01-05 15:22:29 +08:00
0fa9a50378
FIX: Ignore case when comparing category name and search term.
2016-01-05 15:15:04 +08:00
d6b5b9436c
UX: Prioritize categories autocomplete with new rules.
2016-01-05 14:59:18 +08:00
a549229a0d
Remove unused code.
2016-01-05 09:37:46 +08:00
c1dbf5c1c4
FEATURE: Autolinking to category using hashtags.
2016-01-05 00:12:24 +08:00
bebeeffc30
FIX: ico are images too
2015-12-31 11:40:23 +01:00
fd6bbc69e2
FIX: On chrome, focusing on a recently changed textarea would scroll
2015-12-29 14:59:12 -05:00
e03861da7e
change all emoji image tests to use ?v=1
2015-12-22 14:36:21 -08:00
67c08e8aae
FIX: Broken tests for slightly_smiling
2015-12-22 16:07:28 -05:00
33df5372f6
comment out some tests for now
2015-12-20 17:49:35 +11:00
d20f6e0cb0
fix test and comment out js test for now
2015-12-20 17:34:15 +11:00
f97a754b30
Revert "Try adding an ALT tag for avatars"
2015-12-15 19:57:54 +11:00
dd6e38133a
correct tests and implemenation
2015-12-15 19:46:00 +11:00
b7f6df7d0c
fix specs and tests
2015-12-15 18:18:20 +11:00
4e80323567
FIX: Remove useless stub tests
2015-12-07 14:27:43 -05:00
255a5be015
Revert "Cleaner implementation of `postsWithPlaceholders` and more tests."
...
This reverts commit 4c0670a109
2015-12-04 15:59:46 -05:00
a51c91ac05
Revert "FIX: Errors with summary views and placeholders"
...
This reverts commit 5be3bf80eb
2015-12-04 15:59:39 -05:00
5be3bf80eb
FIX: Errors with summary views and placeholders
2015-12-04 15:10:13 -05:00
4c0670a109
Cleaner implementation of `postsWithPlaceholders` and more tests.
2015-12-04 15:10:13 -05:00
40c8d39137
FEATURE: Reply Placeholders in Stream
2015-12-04 10:02:58 -05:00
949f51ffe0
Remove ajax stubbing from post-stream tests
2015-12-04 10:02:37 -05:00
2006be41cf
Split up pretender a bit. It was getting unwieldly.
2015-12-01 15:31:15 -05:00
de88be2fbc
Support for "Only show overridden" in site text customization
2015-11-30 15:25:08 -05:00
ad3dd161e7
FEATURE: first class group mentions built in
...
If you allow a group to be mentioned it can be mentioned with the @ symbol.
Keep in mind as a safety mechanism max_users_notified_per_group_mention is set to 100
2015-11-30 17:08:43 +11:00
5e93140f85
FEATURE: Can override any translation via an admin interface
2015-11-27 11:35:19 -05:00
0844350308
correct production mode due to ember loading changes
2015-11-25 13:57:10 +11:00
49bda0b17d
FIX: Improve windows double clicking on words in editor
2015-11-24 13:42:22 -05:00
c76caca109
FIX: Perform the same operation on multilines in d-editor
2015-11-24 13:03:37 -05:00
5c899c765b
Revert "Revert "REFACTOR: support booting discourse with DISCOURSE_NO_CONSTANTS""
...
This reverts commit c21457d6a7
2015-11-21 12:27:06 +11:00
e25ee74209
FIX: handle topic/post creation when the language highlighting is turned off
2015-11-21 02:10:54 +05:30
c21457d6a7
Revert "REFACTOR: support booting discourse with DISCOURSE_NO_CONSTANTS"
...
This reverts commit c0b277d273
2015-11-20 10:00:12 -05:00
c0b277d273
REFACTOR: support booting discourse with DISCOURSE_NO_CONSTANTS
...
This change is discussed here: https://meta.discourse.org/t/deprecating-es6-compatibility-layer/35821
Prior to this change we were not booting correctly with DISCOURSE_NO_CONSTANTS
2015-11-21 00:14:50 +11:00
4aab904ff6
FIX: Test in phantom environment with different selection defaults
2015-11-18 13:35:36 -05:00
84a50a1260
FIX: Keyboard handling regression
2015-11-18 12:35:17 -05:00
8dc0fa97d4
Better behavior When inserting a link with no description
2015-11-17 13:26:55 -05:00
896c23fadc
fix build
2015-11-12 18:02:13 +01:00
a7d87d1530
Merge pull request #3891 from cpradio/fix-selected-link-text
...
FIX: Use selected text in the link if text is already selected, otherwise, put the URL
2015-11-09 16:24:07 -05:00
8f39f25cad
FIX: Use selected text in the link if text is already selected, otherwise, put the URL
2015-11-09 15:29:19 -05:00
6dd4bc7d57
FEATURE: support group owner, capable of controlling group membership
...
Group owners are regular users that can add or remove users to a group
The Admin UX allows admins to appoint group owners
The public group UX will display group owners first and unlock UI to
add and remove members
Group owners can only be appointed on non automatic groups
Group owners may not appoint another group owner
2015-11-10 00:56:57 +11:00
52579179bd
FIX: Broken tests in phantom, not in browser
2015-11-06 16:44:38 -05:00
15931fce1e
FIX: Allow us to insert things between words.
2015-11-06 15:40:52 -05:00
8ba7c06b7d
Merge pull request #3735 from riking/patch-4
...
FIX: Discourse.BaseUri should not default to /
2015-11-06 14:52:19 -05:00
47495a5713
FEATURE: Replace composer editor with ember version
2015-11-06 09:49:16 -05:00
04856dac10
structure changed ...
2015-11-05 21:21:52 +11:00
5cd6308850
API for adding buttons to the new composer
2015-11-02 16:18:09 -05:00
85da9c6ff8
Digital Ocean should be DigitalOcean https://www.digitalocean.com/legal/terms/
2015-10-30 13:31:48 -04:00
ca98f66f7e
FIX: wrong root path on subfolder installs
2015-10-21 13:13:19 -04:00
0428bacfa9
SECURITY: A user could XSS themselves on their preference page
2015-10-20 12:09:59 -04:00
94b60e62a2
FEATURE: New markdown editor re-written in Ember
...
Note this commit leaves out the biggest occurrence of the editor
which is the post/topic composer.
To avoid major breakage, this replaces it everywhere else it was
used:
* User preferences (About Me)
* Admin Customizations > Text Content
* Category Templates
* Editing Queued Posts
A future commit will replace the main composer with this editor
and will remove the unused pagedown code.
2015-10-19 11:01:20 -04:00
44b04e4521
Make @mentions following a slash link to usercards
...
A slash preceding an @mention was causing the markup for the usercard
link to not be generated. For example, the markdown
Pinging @bob/@joe
Would generate a usercard for @bob, but not @joe.
2015-10-16 19:18:46 -04:00
85f1cf7d1b
correct test
2015-10-05 16:45:53 +11:00
bfd08ca649
correct invalid tests
2015-09-28 17:18:46 +10:00
7d5e2d46c5
FIX: Only enabled badges can be granted
...
FIX: Sort badges by displayName
2015-09-24 02:06:04 +02:00
b49e9fb174
FIX: Load order of `TopicTrackingState` was off
2015-09-21 14:15:25 -04:00
f74c21d2e7
FIX: tracking of new/unread/latest in category/subcategory was broken
2015-09-21 10:36:20 +10:00
975edceff4
Add semi colon linting to Javascript
2015-09-15 17:08:50 -04:00
721b282d3c
Merge pull request #3701 from xfalcox/patch-1
...
Fix same domains links on subfolder installs
2015-09-15 11:49:09 -04:00
230bc8bb6e
Add tests to isInternal on subfolder installs
2015-09-14 18:39:54 -03:00
0c58f08207
FIX: profile picture selector
2015-09-11 15:10:56 +02:00
aca70805f1
FIX: Discourse.BaseUri should not default to /
2015-09-10 17:34:08 -07:00
b34b3293a3
FIX: Broken test
2015-09-09 17:00:07 -04:00
3ceadbd5b8
FIX: Allow qunit tests to run in browser by stubbing new functionality
2015-09-09 16:20:36 -04:00
1c90f77d09
Merge pull request #3715 from gwwar/quote_newline_code
...
workaround for code block being parsed before quote block.
2015-09-08 16:52:46 -04:00
e06d407153
Merge pull request #3718 from tgxworld/allow_emojis_to_be_copy_and_pasted
...
FIX: Allow user to quote Emojis.
2015-09-07 08:48:34 +10:00
8e776d0fd7
Move `TopicTrackingState` to injected object
2015-09-04 13:00:24 -04:00
286738c712
FIX: Include dummy capabilities object in component tests
2015-09-02 16:18:14 -04:00
c36fdccab2
Add `d-link` component to simplify menu markup
2015-09-01 16:14:34 -04:00
bf2c18fddb
Migrate `KeyValueStore` to ES6 modules
2015-09-01 14:45:24 -04:00
cb9c603b6b
workaround for code block being parsed before quote block.
2015-09-01 09:13:51 -07:00
9909c715dc
FIX: Emoji can't be copy and pasted.
2015-09-01 15:45:46 +08:00
ddf0db0338
Refactor notifications `localStorage` cache into adapter pattern.
...
Sometimes you want stale data right away, then refresh it async.
This adds `findStale` to the store for that case. If it returns
an object with `hasResults` you can get the `results` and display
them.
It also returns a `refresh()` method to freshen up the stale data.
To enable `localStorage` support for stale data, just include the
mixin `StaleLocalStorage` into an adapter for that model. This
commit includes a sample of doing that for `Notifications`.
2015-08-31 14:12:27 -04:00
d3fea106fc
FIX: Update relativeAgeMedium to be consistent with relativeAgeTiny.
2015-08-31 00:14:57 +08:00
50ce95b37d
FIX: Post age time not being translated correctly.
2015-08-31 00:11:52 +08:00
6fc2300279
fix test
2015-08-30 09:54:13 +10:00
5336677be7
missed a few spots where close-panel was used
2015-08-29 04:04:04 -07:00
3ae5a0a2df
UX: Merge notifications and user dropdown
2015-08-28 16:11:40 -04:00
d4b987ff32
Migrate search drop down to `menu-panel` component.
2015-08-28 15:44:24 -04:00
42e510753d
Support for Acceptance tests in plugins
2015-08-27 17:07:11 -04:00
fd3dd3bdeb
Merge pull request #3691 from tgxworld/toggle_edits
...
FIX: Dirty edit can toggle to another edit.
2015-08-27 14:26:51 +02:00
5bd1d52de2
FIX: emoji unescape
2015-08-26 21:37:57 -07:00
5457684975
Split `hamburger-menu` out into `menu-panel`
2015-08-26 16:29:10 -04:00
e66f111348
UX: Use dropdown for hamburger on wide screens, full height on smaller
2015-08-26 14:43:08 -04:00
9760369e4c
Clean up clicking outside the hamburger, add test
2015-08-26 14:43:08 -04:00
b5b099d372
FIX: Remove broken test, add descriptions
2015-08-25 17:34:26 -04:00
c5460b7d3f
FEATURE: Full height hamburger menu
...
- Rename `site-map` to `hamburger-menu`
- Includes acceptance tests
2015-08-25 16:48:43 -04:00
294669c856
FIX qunit test runner for phantomjs 2.0
2015-08-25 10:42:19 +02:00
f98eddb675
FIX: Dirty edit can toggle to another edit.
2015-08-24 22:55:56 +08:00
07d6bb8d31
FIX: remove client side maximum filesize check
2015-08-21 12:19:35 +02:00
5658119a36
Merge pull request #3649 from tgxworld/click_reply_should_clear_edit
...
Click reply should clear edit
2015-08-21 10:36:21 +10:00
d1c69189f3
FEATURE: Can edit category/host relationships for embedding
2015-08-20 15:56:04 -04:00
c002845b1a
Merge pull request #3668 from gwwar/image_and_text_spoiler
...
spoiler tag uses replaceBBCode
2015-08-20 16:28:54 +02:00
ee804f608f
spoiler tag uses replaceBBCode instead of rawBBCode for emoji and text formatting support.
2015-08-19 15:52:06 -07:00
abd9b26642
Convert Badges / User Badges to ES6.
2015-08-19 12:09:10 -04:00
b0541500b4
FIX: eslint deprecations
2015-08-13 15:14:08 -04:00
5e215a87c2
Add more acceptance tests for composer.
2015-08-14 00:49:13 +08:00
22844b9e46
Ember 1.12 support
2015-08-13 11:14:16 -04:00
02a968bd27
Remove ObjectController, Discouse Controllers + Presence
2015-08-13 10:49:08 -04:00
e2e3e7c0e0
Add ES6 support to more files
2015-08-13 10:49:08 -04:00
2f6788342e
fix build
2015-08-12 19:23:41 +02:00
d37accb5bc
FIX: broken debounce in search terms.
2015-08-10 16:33:24 -04:00
b7e6eaa961
ES6ify some of the remaining files
2015-08-10 10:21:05 -04:00
0932e82508
Refactor Customizations to have deeper URLs
2015-08-10 10:21:04 -04:00
0889f71268
comment out tests till Discourse.ajax is stubbed correctly
2015-08-10 18:25:44 +10:00
7ef83913b6
FIX: Couldn't select values of 0 in the combo-box
2015-08-05 16:19:44 -04:00
b8c8348e5b
FIX: remove bookmark from user stream
2015-08-05 12:40:43 +02:00
64dd28d885
FIX: time to first response metric
2015-08-04 18:23:56 +02:00
aa6f792ce1
FEATURE: Custom orders for user fields
2015-07-30 14:53:13 -04:00
33b03c1503
FIX: Broken js tests
2015-07-28 17:23:24 -04:00
7518918b8f
FEATURE: add quarterly period to Top page
2015-07-28 12:31:42 -04:00
dc8a68fd29
FEATURE: New "Dropdown" user field type
2015-07-28 12:30:21 -04:00
1eb8f710f1
commented search acceptance tests out
2015-07-27 10:32:02 +02:00
3c25ca2f9f
FIX: Encode percent character in search terms.
2015-07-21 10:54:39 +08:00
f647174c95
Add acceptance test for full page search
2015-07-15 11:17:04 -04:00
cc2a33617f
Refactor likes/flags to simplify things a lot
2015-07-14 15:50:27 -04:00
fcfcda099f
Component tests for like button
2015-07-14 14:46:46 -04:00
7a58d64f37
Upgrade ember qunit, create new interface for testing components
2015-07-14 13:56:59 -04:00
20a338362f
FIX: Allow multiple pagedown editors at once.
2015-07-13 16:36:38 -04:00
f533276507
FIX: do not publish all categories when a category changes.
...
minor fixes to UI, still needs more work for live refresh of category listing
2015-07-10 12:09:43 +10:00
db75774440
UX: Move likes into drop down instead of its own status line
2015-07-03 17:15:20 -04:00
7676c5dfe7
Can add topic templates to categories, prepopulated on compose
2015-07-03 10:01:46 -04:00
23daa9d8ce
Refactor and add tests for category editing
2015-07-03 10:01:46 -04:00
c4b685469e
Merge pull request #3569 from gschlager/i18n
...
FEATURE: Make abbreviated numbers (k, M) localizable
2015-07-01 15:27:17 -04:00
e026dc16d8
FIX: Broken tests :fired:
2015-06-29 15:38:28 -04:00
d08693edce
FEATURE: Make abbreviated numbers (k, M) localizable
...
- Make the decimal separator and thousands delimiter localizable
- Add translations for all languages, otherwise this will look very ugly
2015-06-26 00:51:12 +02:00
7ed309666b
Refactor search results to be components instead of views for reuse
2015-06-22 15:08:51 -04:00
6dfef49392
fix the build...
2015-06-22 19:57:02 +02:00
00572c4f11
FIX: The time gap would disappear after a post was comitted
2015-06-19 10:32:58 -04:00
42bd9b6199
FEATURE: Show time gap between posts if more than a few days
2015-06-18 17:06:25 -04:00
01a23203c7
FIX: slightly improve emoji support in titles (no need for spaces between emojis)
2015-06-16 10:15:42 +02:00
50e705a078
fix the build
2015-06-15 16:02:30 +02:00
2d03163be0
FEATURE: add support for emojis in title
2015-06-15 15:27:22 +02:00
34a0389ff3
FIX: time read column was empty in user directory
2015-06-12 12:40:07 +02:00
e54125b5dc
FIX: Endless spinner when anonymous users navigated to 404s
2015-06-10 13:12:37 -04:00
7b6d6b76eb
FEATURE: Multiple embeddable hosts
...
- Also refactors two site settings components into one, with tests
2015-06-09 13:25:43 -04:00
7942b28780
FIX: Emoji aliases not autocompleted
2015-06-01 12:33:42 +10:00
e101396ea1
FEATURE: add support for device pixel ratio = 3
2015-05-28 01:48:07 +02:00
23eadc3fb1
The entire qunit suite runs without any deprecations
2015-05-27 15:07:09 -04:00
5890dae64c
FIX: Inappropriate error message when you couldn't access a topic
2015-05-27 13:54:11 -04:00
85d4d3223c
FIX: crop avatars on the server instead of the client
...
FIX: support for dots in S3 bucket names
2015-05-26 15:54:25 +02:00
566b267981
FIX: cropAvatar
2015-05-20 16:45:48 +02:00
4685d833b5
FIX: Broken acceptance test
2015-05-19 13:00:50 -04:00
0362c50698
Remove deprecations from edit-category and add skeleton acceptance test
2015-05-15 11:12:41 -04:00
8e395a94d4
FIX: Modal asking where to post was missing
2015-05-14 18:18:28 -04:00
d90063fc59
FIX: Error with ace editor and new ember.
...
Fix upgrades ace editor, which was a huge headache due to AMD.
2015-05-13 16:25:33 -04:00
01d4085125
Removed bad JS tests, upgrade QUnit + ember-qunit
2015-05-13 14:13:37 -04:00
ea51095ef9
Adds acceptance test for user preferences
2015-05-13 11:15:41 -04:00
9460ed1b60
Plain text files do not need to be executable
...
Found with rpmlint.
2015-05-12 13:21:22 +02:00
ff227eabe6
FIX: select posts
2015-05-12 12:54:28 +02:00
d337da532a
FIX: jsHINT issues with recent broken build
2015-05-11 13:36:28 -04:00
b6357e4d48
FIX: Return promises from async tests.
2015-05-11 11:30:14 -04:00
fa69d4cec5
FIX: Missing `colspan` on raw topic list
2015-05-11 11:20:46 -04:00
0b65c88003
Upgrade Notifications to fix deprecations and use store
2015-05-11 11:20:45 -04:00
aab9706b7a
Fixes deprecations on user routes
2015-05-11 11:20:45 -04:00
c6d99bd141
Fixes routing in tests
2015-05-11 11:18:38 -04:00
ed398e65e0
Fixes issues with composer
2015-05-11 11:18:38 -04:00
8294205f7c
Ember 1.11 broken WIP
2015-05-11 11:18:37 -04:00
b3b4fd21ed
Broken WIP
2015-05-11 11:18:37 -04:00
b772ff6e13
FEATURE: add slug geneartion options
2015-05-05 18:08:30 +08:00
ecafbb0a63
Can delete users via the moderation queue
2015-04-27 15:06:20 -04:00
3cb4554bbb
Can refresh queued posts via button
2015-04-27 13:52:54 -04:00
5bf8c31af4
Users can see their pending posts
2015-04-21 16:44:47 -04:00
b2ab95f9c2
Fix an issue with the store hydrating embedded objects
2015-04-21 13:15:40 -04:00
e912b698ac
FIX: Updating the category was not updating the UI
2015-04-16 13:56:27 -04:00
c216b3affe
FIX: Don't cloak in test mode. Should help with intermittant failures
2015-04-16 11:47:37 -04:00
295eebddc3
less noise in JS specs
2015-04-16 10:15:06 +02:00
08b4b7b7ff
Moderators can edit posts that are queued before they approve/reject
2015-04-15 17:20:34 -04:00
2303b1dcd0
FIX: Broken Qunit specs
2015-04-15 17:16:44 -04:00
0c233e4e25
Interface is wired up for Approving/Rejecting posts
2015-04-15 14:54:37 -04:00
96d2c5069b
Interface for reviewing queued posts
2015-04-15 14:54:37 -04:00
7f501a0c41
When a post returns `enqueued` don't insert it in the stream and notify
...
- Includes removal of a lot of modal boilerplate
2015-04-15 14:54:37 -04:00
76f7786d0d
Support saving posts via Store
2015-04-15 14:54:36 -04:00
d4a05825da
Convert `Composer` to use Store
...
- Uses store for `PostStream`, `TopicList` too
2015-04-15 14:54:36 -04:00
a83a19f6ce
ES6 module migrations
2015-04-15 14:54:36 -04:00
22ffcba8e6
Convert `Discourse.Post` to ES6 and use Store model
...
- Includes acceptance tests for composer (post, edit)
- Supports acceptance testing of bootbox
2015-04-15 14:54:36 -04:00
c3b461f58d
Add blank alt attribute to avatars.
...
This was giving an ugly border to avatars in the user card as the full size version loaded in Firefox.
2015-04-14 14:39:40 +01:00
ee3442e562
Also rename the `integration` directory to be `acceptance`
2015-04-06 15:47:39 -04:00
7aa68eaeab
Rename "Integration" tests to "Acceptance" tests.
...
The term "Acceptance" seems to have won out everywhere and I don't want
our codebase to be confusing.
2015-04-06 14:14:00 -04:00
da9e2792eb
FIX: Bugs with autocomplete
...
It wasn't tearing itself down properly. It was swallowing events.
2015-04-06 14:04:42 -04:00
e11802f5c5
bypass test while @eviltrout helps me to fix it
2015-04-02 17:39:41 +11:00
0f4a4651a9
FIX: youtube preview video title link doesn't work
2015-04-01 18:23:27 +02:00
b277e71c15
FIX: login-required tests
2015-03-26 12:09:30 +01:00
512ad4dae3
not sure why this is failing
2015-03-26 17:24:35 +11:00
3954f69514
FIX: hoisting issue with regexp replacement patterns
2015-03-23 16:33:41 +01:00
38fbbb28e3
Fix Discourse.Utilities.avatarImg test on Fx.
...
This qUnit test was failing in Firefox 36 with "setting a property that has only a getter" because devicePixelRatio was being changed directly. The fix uses defineProperty to redefine devicePixelRatio instead.
2015-03-20 12:53:56 +00:00
11bf7da63c
FIX: profile picture wasn't properly updating
2015-03-19 19:57:07 +01:00
5084e2bdf1
Merge pull request #3284 from techAPJ/patch-1
...
FEATURE: new site setting min_first_post_length
2015-03-19 19:55:27 +01:00
b706307ac7
FEATURE: new site setting min_first_post_length
2015-03-20 00:20:38 +05:30
7ef306cd3b
A bunch of tweaks to the Users directory
...
- Move user directory from `/directory` to `/users/`
- Defaults to 'weekly' time period
- Don't include deleted topics/posts in the results
- Move heart icon to header instead of on each row
- "Users" instead of "Users found"
2015-03-19 12:29:38 -04:00
df3b1f6968
FIX: editing a post wasn't showing error messages from the server
2015-03-19 12:25:15 +01:00
3d2d224312
FEATURE: User Directory, with sorting and time period filter
2015-03-18 15:20:34 -04:00
aa41a9ce70
FIX: remove empty lines but keep whitespace on first line in code blocks
2015-03-17 17:27:16 +01:00
8b4469a3f0
improve tests, ensure stream grows if all posts are loaded on commit
2015-03-16 17:40:49 +11:00
424a3b042a
FEATURE: unified UI for pinning/banner topics
...
REFACTOR: ES6ified all the modals
2015-03-14 01:18:05 +01:00
77f9d1e223
Use pretender's passthrough for dynamically loaded scripts
2015-03-13 12:14:22 -04:00
01fcc7503a
big hacks to get tests to pass
2015-03-13 17:45:55 +11:00
a82530012a
FEATURE: Allow selection of highlight js languages
...
PERF: stop loading highlight js on load
To get latest highlight js run bin/rake highlightjs:update
2015-03-13 16:18:59 +11:00
69851bc6cf
Deprecates global use of `Discourse.MessageBus`
...
We can use DI for this, which makes it easier for plugins to subscribe
to the message bus.
2015-03-12 12:27:30 -04:00
9395bbbbea
add test for fix in 9061c26e52
2015-03-12 16:20:14 +01:00
7c9fb5d3fc
Refactored SiteMap/Header to support more dynamic flag counts
...
Also fixes deprecation in `plugin-outlet`
2015-03-11 16:12:53 -04:00
70f00e31df
FIX: pre-hoist code blocks & spans
2015-03-09 12:32:37 +01:00
9b9bd9c0a1
fix my git foo
2015-03-07 02:36:35 +01:00
f95c86ac72
FIX: hoist code blocks content before doing any kind of processing
2015-03-07 02:16:27 +01:00
7c25efc095
Move identity map into the store, shouldn't have been in the adapter
2015-03-06 13:23:38 -05:00
ecb553af3f
Add tests for our store
2015-03-06 12:37:24 -05:00
db7a225df7
correct specs
2015-03-06 14:36:00 +11:00
809edd4da3
FIX: user-card tests
2015-03-04 13:02:36 +01:00
9974a26c47
FEATURE: Can specify a list of `default_avatars` urls.
...
These new avatars will be used by new users until they upload their own
avatars. If left blank, letter avatars are used.
2015-03-03 16:19:29 -05:00
8ebab581ad
temporarily disable test
2015-03-02 20:02:20 +01:00
c04b214910
FEATURE: don't allow username and email to be the same
2015-02-27 13:47:43 -05:00
be9feeb918
Replace `CurrentUserMixin` with an injected `currentUser`
...
This is a lot simpler and removes the need for stubbing singletons
in unit tests.
2015-02-27 10:33:39 -05:00
cf81b3f86d
FEATURE: don't allow username and password to be the same
2015-02-25 12:00:13 -05:00
9264a7914f
Removed a bunch of `Discourse.Site` globals
2015-02-23 12:36:04 -05:00
c50205725f
FIX: Default sort grantable badges by name
...
Currently has no default sort and was stated as a bug here:
https://meta.discourse.org/t/badges-not-sorted-in-grant-badge-dropdown/23739
(Post was recently deleted or made private?)
2015-02-15 17:37:11 -08:00
a519fd5bcf
FIX: Highlighting was not being applied after some rendering.
...
Also includes a bunch of ES6 stuff.
2015-02-12 15:37:02 -05:00
cf3582bedb
FIX: JSHint wasn't validating ES6 files, this fixes a bunch of errors.
2015-02-10 17:21:16 -05:00
b809e02c6c
FIX: clicking an attachment link works only once
2015-02-09 17:49:59 +01:00
a65e0a80ba
Add support for more ES6 features
2015-02-06 13:26:33 -05:00
42ab39ce18
fix the build (cc @riking)
2015-02-05 12:57:33 +01:00
0a252d7785
FIX: quote whote post should insert at cursor position
2015-02-02 19:08:28 +01:00
a591c019d4
correct tests
2015-01-29 17:57:34 +11:00
b003c2b4f3
let's try category class again
2015-01-27 23:44:47 +01:00
d52b0a2458
temporarily disable category class on body while debugging issue with missing docking header
2015-01-27 13:43:40 +11:00
40da065930
fix the build (:fired:)
2015-01-26 23:49:15 +01:00
e6f849f873
FIX: make sure pasting an image in the composer is considered as an image instead of an attachment
2015-01-23 19:17:33 +01:00
2ea4c1c9de
FIX: Groups post page was broken.
...
Also added integration tests so we don't miss this breaking in the
future.
2015-01-23 11:13:27 -05:00
03eb4752d1
Add `categories-list` css class to body for customization purposes
2015-01-21 14:34:01 -05:00
649dfd8d23
Revert "Convert html.js to ES6 module format"
...
This reverts commit 60523d8e02
2015-01-20 16:13:42 -05:00
60523d8e02
Convert html.js to ES6 module format
2015-01-20 16:07:29 -05:00
350554e198
UX: Change category badge style to use stripes
2015-01-20 14:56:06 -05:00
1e6dea46dd
FIX: Jump to post was not respecting gaps
2015-01-12 18:10:30 -05:00
38e4defaee
Support adding items to the site map via plugin outlet.
2015-01-09 16:15:16 -05:00
6953923a03
remove |starred| from topnav default options
2015-01-06 16:03:45 -08:00
7182767349
Refactor topic title/category saving to support easier changing of
...
attributes via plugins.
2015-01-02 14:25:41 -05:00
36f53790f4
Added test for markdown bug with linking `[ul]` and `[poll]`
2014-12-31 11:45:23 -05:00
386b0a2587
fix the build
2014-12-29 22:36:25 +01:00
13bf8e1e46
FIX: Markdown bug when a heading preceeded a code block.
2014-12-29 15:59:39 -05:00
ae16186100
FEATURE: post chunk size should not be configurable
...
If people need to configure post chunk size use a plugin
Core only supports out of the box settings, if changed can lead to
severe performance issues.
2014-12-15 10:57:34 +11:00
f42a5c1ba3
Convert a lot of Globals to ES6 modules
2014-12-17 09:31:42 -05:00
331bba4b6d
Correct the last few test failures in the 1.9.0 branch
2014-12-17 09:31:42 -05:00
1948b41875
Fix resolve errors
2014-12-17 09:31:41 -05:00
7aaf2fcb65
Fix broken qunit tests in 1.9.0
2014-12-17 09:31:41 -05:00
2d6b15a34d
Load fewer posts when the android platform is detected
2014-12-12 11:47:39 -05:00
5fd3f2547c
FIX: Fix rerendering issues on some components.
2014-12-08 14:47:49 -05:00
e035b07e92
Put Ember 1.8.1 + fixes back.
2014-12-04 08:51:35 -05:00
8977d5917b
revert
2014-12-04 09:35:11 +11:00
39fde5b9fb
Upgrade to 1.8.1: So long, metamorphs!
2014-12-03 10:49:18 -05:00
a06bf0b7be
fix the build
2014-11-17 15:47:07 +01:00
9dccd975d9
UX: whitelist OpenStreetMap iframes
2014-11-17 14:30:25 +01:00
564e7a988c
Merge pull request #2848 from riking/whitelist-api
...
Improve Markdown.whiteListTag, code dialect
2014-11-07 11:33:37 -05:00
d4224a64e8
correct spec
2014-10-22 15:50:04 +11:00
1cf4a0d604
Rename "User Expansion" to the much clearer "User Card"
2014-10-20 12:11:59 -04:00
a0f74daf6b
correct dodgy test
2014-10-18 20:16:19 +11:00
92b615b503
reorganize site settings a bit
2014-10-19 23:14:50 -07:00
c2614543b1
Correct minor spelling mistakes
...
@sam highlighted I made a spelling mistake in a commit - thought I would throw a few more in.
2014-10-19 23:55:19 +01:00
0cbdf6f5bb
FIX: Many bugs with admin badges interface
...
* Editing a badge's title would show it as changed in the side even if
you didn't hit save
* Clicking a badge would not scroll to the top
* If there was an error saving a badge there was a missing i18n key
* URLs were using queryParams instead of paths
* User `label` tags for checkboxes for larger click targets
* Saved! text would persist when viewing another badge
* After creating a new badge it would show nothing
* Validation errors were not being properly released to the client
* Query errors were surrounded by an extra array
2014-10-17 16:14:49 -04:00
b023e81078
FIX: Censored word match fail if earlier partial match
...
Previously a list containing `one|two|three|four|twoagain` would fail to censor the word `twoagain` in the text `test1 twoagain test2`.
2014-10-17 03:10:30 +01:00
d2ac5a9ac6
Rename `/category/xyz` paths to `/c/xyz` -- @SamSaffron did most of the
...
work even though I'm merging the patch!
2014-10-16 12:15:31 -04:00
27e68518df
FIX: BBCode was trimming leading space in `[code]` blocks
2014-10-10 15:11:30 -04:00
3b38667274
FIX: Check for word boundaries with censored words.
2014-10-09 16:35:27 -04:00
285c66b899
FIX: Say the file uploaded is too large, not "image" as you can upload
...
other kinds of files.
2014-10-09 16:03:04 -04:00
f9a8f6d6ce
FEATURE: Support for a `required` setting on user fields.
2014-10-08 15:10:19 -04:00
11b52d1334
More deprecations to allow us to work on future versions of Ember
2014-10-07 16:04:19 -04:00
ef36a619c3
Update Markdown tests
2014-10-05 17:30:29 -07:00
9564ecde76
FEATURE: Site setting for words to censor in posts
2014-10-02 13:58:58 -04:00
edb34c178a
FEATURE: Show user fields when the user is signing up
2014-09-30 10:45:18 -04:00
8371837b21
Merge pull request #2808 from gschlager/i18n_fix07
...
FIX: Category creation failed when translation was missing
2014-09-29 16:20:02 +10:00
1d2c7206e6
Merge pull request #2820 from Elberet/fix-url-bbcode
...
FIX: reworked handling URL bbcode tags
2014-09-25 09:36:55 +10:00
98d21ed21f
Remove deprecated `Ember.Deferred`
2014-09-24 14:17:29 -04:00
dcd7a149e2
FIX: reworked handling URL bbcode tags
2014-09-24 20:02:02 +02:00
d1d3e5dd8c
Remove broken `debouncePromise` and clean up some deprecations
2014-09-23 16:16:44 -04:00
b3838c2c1c
Trigger browser password manager after sigining up
2014-09-24 01:04:36 +05:30
537e6b193d
FIX: Allow proper escaping of bold and italics markdown, even when
...
nested.
2014-09-22 16:52:14 -04:00
914217f78a
FIX: Allow BBCode images within BBCode links
2014-09-22 14:42:24 -04:00
9cca64cf69
FIX: BBCode blocks parser no longer mangles JsonML arrays
2014-09-22 03:27:39 +02:00
a6714e252e
FIX: Category creation failed when translation was missing
2014-09-20 22:06:00 +02:00
5646ebf4c7
fix tests expecting "name said:" to "name:"
2014-09-18 20:39:27 -07:00
543bc53598
FIX: double-escaped single quotes in URLs
2014-09-18 22:07:42 +02:00
33c6a2d341
correct tests
2014-09-18 15:26:45 +10:00
c16b8364ab
FIX: Support ember app routing to topics with only slugs
2014-09-17 11:18:59 -04:00
306d31b92e
fix test
2014-09-11 11:15:49 +10:00
30dbb570e5
FIX: fix dialect block ordering
2014-09-10 13:29:40 +02:00
69bc552054
FEATURE: Actually show more notifications
...
The "Show more notifications..." link in the notifications dropdown now
links to /my/notifications, which is a historical view of all
notifications you have recieved.
Notification history is loaded in blocks of 60 at a time.
Admins can see others' notification history. (This was requested for
'debugging purposes', though that's what impersonation is for, IMO.)
2014-09-09 16:29:08 -07:00
504d61de94
FIX: Clicking on expanded user actions uses user expansion. Also added
...
integration test.
2014-09-09 15:18:04 -04:00
2f04b53c9f
FIX: Clicking outside of modal wasn't closing it
2014-09-08 16:53:05 -04:00
4bec839d9d
Using `Discourse.XYZ` in templates is deprecated. This fixes that, plus
...
adds some more integration tests to make sure login required is working.
2014-09-05 13:09:01 -04:00
fad0394a40
more renaming of trust level settings
2014-09-04 13:32:00 -07:00
fcca64c0cf
rename site settings for trust levels as numbers
2014-09-04 13:16:51 -07:00
dac4ed5a1e
Prune dead code for search keyboard navigation in search, remove bad
...
tests.
2014-09-03 15:05:22 -04:00
40b1558f83
Merge pull request #2747 from cpradio/remove-additional-search-code
...
FIX: Remove additional search code related to the up/down navigation
2014-09-03 14:46:09 -04:00
a71640c15f
Add the integration test for search back using a fixture.
2014-09-03 13:43:26 -04:00
44a25271f1
FIX: Remove additional search code related to the up/down navigation
...
Removed additional search code that was related to the up/down navigation and their related tests.
https://meta.discourse.org/t/magic-search-code-for-keyboard-shortcuts/19563
2014-09-03 06:51:52 -04:00
921dd75dd9
FIX: anonymous had <a> items for pin/unpin
...
FEATURE: display category in search results
FEATURE: display topic state (locked/pinned/etc) in search results
UI cleanup for search results, clearing floats and so on.
2014-09-03 12:13:26 +10:00
9be5c98c8c
FIX: Markdown parser: empty links and bbcode parsed as link refs
2014-08-31 02:55:43 +02:00
289d9e4fe1
FIX: use short date format for topic summary
2014-08-30 12:07:43 +05:30
2e200ffbf0
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
...
Conflicts:
config/locales/client.en.yml
2014-08-29 20:05:59 -04:00
875b39fb5f
Merge remote-tracking branch 'origin/master' into keyboard-binding-incoming-updated-topics
2014-08-29 19:56:39 -04:00
8a8552019a
Fixed qunit test assertion
2014-08-29 18:03:27 -04:00
80cb8f3a96
Fixed qunit test assertion
2014-08-29 17:54:50 -04:00
1291e94c78
Merge pull request #2715 from cpradio/master
...
UX: Add focus to menu only if it comes from a keyboard shortcut and improve keyboard functionality for search
2014-08-29 17:04:52 -04:00
096bc0c0ae
Merge branch 'keyboard-binding-new-topics-banner' into dismiss-keyboard-bindings
...
Conflicts:
app/assets/javascripts/discourse/lib/keyboard_shortcuts.js
2014-08-29 09:36:34 -04:00
723798cc30
Correct Perform Search Test
2014-08-28 23:32:56 -04:00
185769c07b
Correct Perform Search Test
2014-08-28 23:21:43 -04:00
69cb5bc425
FIX: Centralize Top rendering, remove old code paths. Fix some bugs.
2014-08-28 14:34:31 -04:00
53e60030bc
FIX: broken tests
2014-08-27 14:47:23 +10:00
c58565d09f
Fix: dialect block parser should not eat next block's whitespace
2014-08-26 14:11:23 +02:00
b8f5c21df0
Workaround markdown-js links parser bug
2014-08-24 01:56:14 +02:00
2ae46b4742
REMOVE: Auto quoting confused more people than it helped.
2014-08-22 14:51:31 -04:00
300dbdc88b
FIX: BBCode contents can span multiple lines
2014-08-22 14:32:29 -04:00
104b39540a
FIX: BBCode with params couldn't span lines
2014-08-22 12:14:10 -04:00
5b1785157d
TRIVIAL: fix deprecations due to momentjs upgrade
2014-08-20 22:22:58 +02:00
49f0eaea13
Merge pull request #2650 from Elberet/fix-parser
...
Fix: block parser uses regexes for stop tags, allows stricter matching
2014-08-18 11:06:08 -04:00
a0d0f859ba
Add login buttons to create account template.
2014-08-14 12:51:16 -04:00
23002ae01c
Fix: block parser now uses regexes for end tags. solves code block case, where end tag must be on a line of its own.
2014-08-14 01:58:01 +02:00
0adfeb1cff
ES6: Mega update of controllers
2014-08-13 10:22:47 -04:00
233305e96f
FIX: On devices with a weird pixel ratio, tests were failing.
2014-08-12 17:29:18 -04:00
11e43bd434
FIX: Don't show Sign Up button in cases where users can't sign up
2014-08-12 16:55:23 -04:00
1684ff3015
UX: Add a separate "Sign Up" button
2014-08-12 13:47:23 -04:00
d1f6c31382
TESTS: Adds integration test for new about route
2014-08-12 11:15:32 -04:00
37a9747f53
ES6: Convert Discourse.Resolver to ES6
2014-08-07 11:48:02 -04:00
b323c86302
TESTS: Remove home logo tests, they are written in the incorrect way and
...
don't test much of value.
2014-08-07 11:48:02 -04:00
8279752d3c
REFACTOR: Don't use `Discourse.Capabilities`, instead use injection.
...
Also fix broken test. /cc @Sam
2014-08-06 18:28:02 -04:00
f977843391
ES6: Convert all test files over
2014-08-06 17:51:03 -04:00
417d287813
FIX: Don't link to notifications without URLs
2014-08-06 15:24:20 -04:00
3330f5907c
FEATURE: restructure notification HTML layout
2014-08-05 23:36:37 +02:00
d29822e4cb
TWEAK: Sum new and unread in the site map category list
2014-08-05 16:01:49 -04:00
3c66e48573
TESTS: Remove `URL_FIXTURES` constant for pretender
2014-08-01 17:27:01 -04:00
443caaa8f7
FIX: don't let admins skip post validations, unless it's faq, tos, or privacy
2014-08-01 14:53:35 -04:00
d7ad3bb2b6
TESTS: Integration tests for badge pages
2014-07-31 18:44:47 -04:00
77332e8b57
TESTS: Add integration test for /top
2014-07-31 18:44:47 -04:00
adea5b36a0
TESTS: Integration tests for `login_required`
2014-07-31 17:59:52 -04:00
e63cdc50bb
TESTS: Add `JSON.stringify` step to `prepareBody` where it should be.
2014-07-31 17:26:44 -04:00
c30ab6d428
Return a CSRF in case it's requested
2014-07-31 17:06:16 -04:00
d3cc85c784
TESTS: Use Pretender in test mode for more flexible server responses
2014-07-31 16:49:30 -04:00
bf16ff275a
TESTS: Sign in tests
2014-07-31 14:17:18 -04:00
c5b5db48cf
TESTS: Reset the preload store for testing
2014-07-31 13:25:40 -04:00
c3e1dd4707
TESTS: Remove non-idiomatic tests. Too much pain to maintain or convert.
2014-07-31 13:25:40 -04:00
b8bfbcb3cb
ES6: Tests
2014-07-31 13:25:39 -04:00
6f36d5996d
Lots of work on tests
2014-07-30 20:09:45 -04:00
b6684e7168
Upgrade to ember-qunit
2014-07-30 20:09:44 -04:00
d29157dab9
TESTS: Refactored integration tests
2014-07-30 20:09:44 -04:00
aeb0ea1f25
FIX: Broken test
2014-07-30 12:08:07 -04:00
b196de0821
TRIVIAL: use class instead of id for the 'topic-list'
2014-07-29 23:38:36 +02:00
b00b5609e6
Merge pull request #2599 from riking/disable-logster
...
Disable logster error reporting during tests
2014-07-29 12:29:23 +10:00
f80502ea0e
Disable logster error reporting during tests
2014-07-28 13:41:45 -07:00
e1be478ef4
FIX: admins bypass some post validations. This allows them to edit legal docs even if those docs are longer than max post length, for example.
2014-07-28 16:40:14 -04:00
717f57c968
Revert "FIX: You couldn't span multiple lines with bold or italics"
...
This reverts commit 423d37a2b6
2014-07-28 13:17:39 -04:00
8866141ba2
Merge pull request #2592 from Elberet/fix-parser
...
Fixes for quirky markdown parser behaviours
2014-07-28 13:12:22 -04:00
f7c7d38a30
FIX: broken tests
2014-07-28 12:05:27 +10:00
479eb64a76
FIX: rewrite replaceBlock logic to better handle mismatched nested quotes.
2014-07-27 16:07:47 +02:00
9124cf0eaf
FIX: auto-quote should not trigger when the first " is preceded by bbcode-like garbage.
2014-07-27 16:05:29 +02:00
5841e10b59
Extra test for spanning italics
2014-07-25 13:15:14 -07:00
423d37a2b6
FIX: You couldn't span multiple lines with bold or italics
2014-07-25 16:08:00 -04:00
b2f2e7b1d2
REFACTOR: Move Markdown tests to Javascript land
2014-07-25 16:08:00 -04:00
e242368266
Convert admin section controllers to ES6 modules
2014-07-25 14:17:58 -04:00
f3bb8902c1
Make a mocked test that broke pending for now. The logic works, will
...
replace with a new test later.
2014-07-24 15:14:36 -04:00
b19ad15086
FIX: improve list bbcodes: ignore newlines resulting in unnecessary blank lines
2014-07-24 19:39:16 +02:00
79dc68512f
FIX: dialects accept nested inline markup
2014-07-24 17:34:13 +02:00
ec03d135fa
FEATURE: allow advanced badge options in admin screen
...
clean up serializer, allow simplistic preview
2014-07-24 18:28:23 +10:00
0a0d32efb4
TRIVIAL: Rename `map` to `idMap` because `map` means something for
...
enumerables.
2014-07-23 11:11:13 -04:00
f63e6e6dab
Optimize Category find-by-id by using a hash.
2014-07-22 23:49:49 -04:00
7c0e723464
TWEAK: If `show_subcategory_list` is enabled, hide subcategories from
...
the site map.
2014-07-22 16:27:33 -04:00
4c51258526
PERF: Speed up JSHint tests by using local buffers instead of AJAX
...
requests.
2014-07-22 14:13:37 -04:00
386b6213a5
FEATURE: warn when caps lock is on during password input
2014-07-22 13:53:58 -04:00
d9e5c2317f
FIX: If a topic title edit fails, revert to previous title.
2014-07-21 13:39:23 -04:00
7ebfe86100
TEST: allows data images
2014-07-18 20:38:01 +02:00
75f6b43e62
ES6: Discourse.ContainerView
2014-07-18 12:20:07 -04:00
de3633235b
Add JS tests for deleted post hiding (fix the build)
2014-07-17 11:13:42 -07:00
fecb9ddb43
FIX: invalid test
2014-07-17 16:11:10 +10:00
d6589d4c53
FIX: Cooking issue with paragraphs in a list
2014-07-15 16:42:14 -04:00
a9342dbf92
SECURITY: fix XSS in link's href
2014-07-15 16:11:37 +02:00
1886ffaff2
FIX: Work with phpBB import style links with ellipsis
2014-07-14 14:27:17 -04:00
186ce78cb5
FIX: BBCode sanitization and tests
2014-07-14 11:24:25 -04:00
e565ae2528
FEATURE: /guidelines route will always show our FAQ, ignoring the faq_url site setting
2014-07-10 12:58:41 -04:00
6b45b635f8
FIX: properly whitelist <code> classes needed for syntax highlighting
2014-07-09 16:27:47 +02:00
7ab98bb0e7
FIX: Missing formatting for oneboxes in preview
2014-07-04 14:15:07 -04:00
fc1ce96dbb
FIX: Change the approach to sanitization. Includes a more detailed API
...
for allowing classes and attributes for only certain tag names.
2014-07-03 16:55:36 -04:00
9c48f8f154
FIX: Don't surround `<aside>` with `<p>` as that is malformed HTML.
2014-06-30 18:11:22 -04:00
a7ad7f6a45
Remove some obscure HTML tags from sanitization
2014-06-24 11:03:45 -04:00
ff55a30dd7
FIX: `<pre>` blocks were adding too many new lines.
2014-06-23 15:21:07 -04:00
42d1fcbbc2
`[code]` should work just like other kinda of code formatting.
2014-06-23 13:19:27 -04:00
7e946a718e
Make bookmarks menu appear all the time
2014-06-23 10:21:33 +05:30
9d82111813
TRIVIAL: Remove some output from qunit test suite.
2014-06-19 16:00:01 -04:00
806ddb4ccb
FEATURE: Quote reply at cursor
2014-06-18 15:17:55 +10:00
a288ff331d
BUGFIX/FEATURE: call out context for search.
2014-06-17 17:53:45 +10:00
5db621c5fe
normalize to search.title for search help
2014-06-16 16:20:57 -07:00
Sam
Robin Ward
Guo Xiang Tan
Régis Hanol
Jeff Atwood
Arpit Jalan
cpradio
Seth Reeser
Neil Lalonde
James D
Gerhard Schlager
Rafael dos Santos Silva
Kane York
kerryliu
Marcus Rückert
Erick Guan
Ben Hadley-Evans
Ed Gibbs
Marcin Rataj
Dean Taylor
Jens Maier
Joshua Gorner
Peter Le Bek
Jeff Atwood