dee451605b
FEATURE: add user opt to select bookmarks as home ( #10597 )
...
Admins can currently add the bookmarks discovery route link
to the homepage interface, but users can't presently select
that as their default home view. This change facilitates that,
adding the option to the existing Default Home Page dropdown on
the User Preferences Interface page.
2020-09-10 11:13:12 -04:00
5a34c7cc9e
FIX: Adds important declaration to `.hidden` utility/helper class
...
This commit adds the `!important` declaration to `.hidden` utility/helper class. Without the `!important` declaration, it is not applied correctly across the site.
2020-09-10 11:06:50 -04:00
53ffbc8d6e
DEV: add plugin outlet below the categories-only component
2020-09-10 10:39:04 -04:00
86764f3aac
Revert "PERF: Use 1 query to load group and tag notification default."
...
This reverts commit 5ef9d4d537https://meta.discourse.org/t/there-are-no-visible-groups/163604 . Reverting until further fixes can be put in place.
2020-09-10 08:52:53 -04:00
f27de87bf3
FIX: Update first_pm_unread_at of user's groups without unread.
...
If a user always read all group messages, we will never update the
`first_pm_unread_at` column since the previous query will not return the
group_user. Instead, we should update `first_pm_unread_at` to the
current timestamp if the user has read everything.
Follow-up to 9b75d95fc6
2020-09-10 17:19:38 +08:00
81d3c4a7a1
DEV: Remove unused function.
2020-09-10 15:11:35 +08:00
5ef9d4d537
PERF: Use 1 query to load group and tag notification default.
2020-09-10 13:19:43 +08:00
40d5739a80
DEV: Review fixes for bookmark-list ( #10642 )
...
Make removeBookmark return a promise and do not use setProperties for no reason.
More context at https://review.discourse.org/t/fix-add-bookmark-list-component-10451/14450/3
2020-09-10 15:01:53 +10:00
521782fc9c
FIX: Search checkboxes incorrectly being checked on similar prefix.
...
Incorrect search filters like `in:personalasd` will end up checking the
checkbox for `in:personal` because the regexp used was only doing prefix
matching.
2020-09-10 11:49:52 +08:00
7f2f87bf59
DEV: Review fixes ( #10641 )
...
See comments in https://review.discourse.org/t/dev-imap-log-to-database-10435/14337/6 for context.
2020-09-10 13:41:46 +10:00
dede942007
FEATURE: Allow email image embed with secure media ( #10563 )
...
This PR introduces a few important changes to secure media redaction in emails. First of all, two new site settings have been introduced:
* `secure_media_allow_embed_images_in_emails`: If enabled we will embed secure images in emails instead of redacting them.
* `secure_media_max_email_embed_image_size_kb`: The cap to the size of the secure image we will embed, defaulting to 1mb, so the email does not become too big. Max is 10mb. Works in tandem with `email_total_attachment_size_limit_kb`.
`Email::Sender` will now attach images to the email based on these settings. The sender will also call `inline_secure_images` in `Email::Styles` after secure media is redacted and attachments are added to replace redaction messages with attached images. I went with attachment and `cid` URLs because base64 image support is _still_ flaky in email clients.
All redaction of secure media is now handled in `Email::Styles` and calls out to `PrettyText.strip_secure_media` to do the actual stripping and replacing with placeholders. `app/mailers/group_smtp_mailer.rb` and `app/mailers/user_notifications.rb` no longer do any stripping because they are earlier in the pipeline than `Email::Styles`.
Finally the redaction notice has been restyled and includes a link to the media that the user can click, which will show it to them if they have the necessary permissions.
2020-09-10 09:50:16 +10:00
097f06b4fa
DEV: Add plugin api for adding to search-advanced-options dropdowns ( #10606 )
2020-09-09 15:17:39 +01:00
38c934e1e1
UX: prevents auto capitalize/correct in the emoji picker ( #10636 )
2020-09-09 15:43:18 +02:00
4994b0ed34
PERF: Remove an unncessary query when check for dark mode.
2020-09-09 15:18:52 +08:00
fb7bbae3f4
PERF: Memoize calls to `ApplicationHelper#scheme_id`.
...
The same query was executed 4 times per full page load.
2020-09-09 15:15:15 +08:00
9b75d95fc6
PERF: Keep track of first unread PM and first unread group PM for user.
...
This optimization helps to filter away topics so that the joins on
related tables when querying for unread messages is not expensive.
2020-09-09 14:05:41 +08:00
4dd07843c6
FIX: We have changed the way `__widget_helpers` are resolved
2020-09-08 12:10:59 -04:00
8413d27cf2
FIX: handles different cases of canInvite/canRemove states in PM ( #10607 )
2020-09-08 16:35:59 +02:00
d21119ee4f
Build(deps): Bump lodash in /app/assets/javascripts/pretty-text
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 10:25:45 -04:00
00e2339e82
Build(deps): Bump lodash in /app/assets/javascripts/discourse-common
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 10:25:31 -04:00
02495510e8
FIX: workaround constructor name not available after transpilation ( #10623 )
...
This is only reproducible en production build. In this case, constructor.name could be any value like "i" for example.
2020-09-08 10:14:41 +02:00
b0f22f2523
SECURITY: Remove indication that a group exists if user can't see it.
...
Minor security fix but we should not leak any hints that a group exists
even if a user does not have access to the group.
2020-09-08 10:53:48 +08:00
5ed84d9885
SECURITY: Don't allow moderators to list PMs of all groups.
...
* Also return 404 when a user is trying to list PMs of a group that
cannot be accessed by the user.
2020-09-08 10:37:00 +08:00
0b8e7d88fe
FIX: wraps popper call in afterRender and uses createPopper ( #10621 )
...
Before this fix, popper was sometimes not applied.
2020-09-07 13:33:52 +02:00
27751ca69f
Build(deps): Bump websocket-extensions ( #10617 )
...
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node ) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/faye/websocket-extensions-node/releases )
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md )
- [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:02:38 +02:00
b191ea4f59
Build(deps): Bump websocket-extensions ( #10615 )
...
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node ) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/faye/websocket-extensions-node/releases )
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md )
- [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:02:27 +02:00
2cb0f013cc
Build(deps): Bump elliptic in /app/assets/javascripts/pretty-text ( #10611 )
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:02:09 +02:00
6bff8636e2
Build(deps): Bump elliptic in /app/assets/javascripts/discourse-common ( #10612 )
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:01:37 +02:00
9b187b7e11
Build(deps): Bump http-proxy in /app/assets/javascripts/discourse-common ( #10613 )
...
Bumps [http-proxy](https://github.com/http-party/node-http-proxy ) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases )
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md )
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:00:25 +02:00
c119c07fa4
Build(deps): Bump http-proxy in /app/assets/javascripts/pretty-text ( #10614 )
...
Bumps [http-proxy](https://github.com/http-party/node-http-proxy ) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases )
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md )
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:00:10 +02:00
13c9d7e704
UX: Add missing labels to mobile composer buttons
2020-09-04 22:18:29 -04:00
da918ac43e
FIX: Allow us to call `script_asset_url` in controllers
...
Without this patch fingerprinting was not applied in production.
2020-09-04 15:23:01 -04:00
0f9a58e06f
FEATURE: Add stylesheets to bootstrap.json endpoint
...
This allows API consumers (such as Ember CLI) to dynamically get a list
of styles to embed.
2020-09-04 14:12:49 -04:00
c5b8a47901
FIX: ensures we don't attempt to concat an empty list ( #10600 )
2020-09-04 19:08:07 +02:00
d4471e0316
FIX: Preload bold fonts in wizard
...
The bold fonts are used in previews for topic title.
2020-09-04 19:23:46 +03:00
ed05839dfc
FIX: prevents error when opening a composer from a tag page ( #10596 )
2020-09-04 15:47:22 +02:00
58b97ace23
DEV: Use a special import to declare font faces ( #10583 )
...
Update discourse-fonts to v0.0.3.
Follow-up to 7b7357147e
2020-09-04 16:25:50 +03:00
52672b9eab
DEV: apply new coding standards ( #10592 )
2020-09-04 13:42:47 +02:00
e4ebc303bb
FEATURE: Add below-static plugin outlet
2020-09-03 22:58:58 -04:00
ea423b471a
FIX: make crawler linkback list compatible with google schema guidelines.
2020-09-04 04:35:32 +05:30
8c0f18794e
FEATURE: Deprecate lodash so we can remove it.
...
It's currently 240k of Javascript we don't need anymore. It's been
replaced by ES6 and a couple helper functions.
2020-09-03 10:03:33 -04:00
3a46e44ed8
Rename `merge` to `deepMerge` so it's more clear what it's doing
2020-09-03 10:03:33 -04:00
f365d4639a
REFACTOR: Remove `_.isEqual`
2020-09-03 10:03:33 -04:00
c4079780be
REFACTOR: Remove `_.merge`
2020-09-03 10:03:33 -04:00
720cd57fb5
FIX: Convert jQuery array to JS array
2020-09-03 10:03:33 -04:00
5e5d5b4f35
REFACTOR: Remove `_.last`
2020-09-03 10:03:33 -04:00
0da953b40e
REFACTOR: Remove `_.compact`
2020-09-03 10:03:33 -04:00
c2cfa62000
REFACTOR: Remove `_.intersection`
2020-09-03 10:03:33 -04:00
0b098566ff
REFACTOR: Remove `_.union`
2020-09-03 10:03:33 -04:00
e60d06d880
REFACTOR: Remove `_.isString`
2020-09-03 10:03:33 -04:00
b4444070b3
REFACTOR: Remove `_.groupBy`
2020-09-03 10:03:33 -04:00
1265a5f7c0
REFACTOR: Remove `_.max`
2020-09-03 10:03:33 -04:00
d06deb0c4f
REFACTOR: Remove `_.chain`
2020-09-03 10:03:33 -04:00
71ddcefffa
REFACTOR: Remove `_.filter`
2020-09-03 10:03:33 -04:00
87b3caf927
REFACTOR: Remove `_.reject`
2020-09-03 10:03:33 -04:00
2a4dfa83b0
REFACTOR: Remove `_.omit`
2020-09-03 10:03:33 -04:00
17bca14c4b
REFACTOR: Remove `_.sortBy`
2020-09-03 10:03:33 -04:00
2353794a30
REFACTOR: Remove `_.findIndex`
2020-09-03 10:03:33 -04:00
e3ec7b72d0
REFACTOR: Remove `_.uniq` and use ember version
2020-09-03 10:03:33 -04:00
66021abe41
REFACTOR: Remove `_.first` from codebase
2020-09-03 10:03:33 -04:00
55c9c54b8b
REFACTOR: Remove `_.range` and use ES6 instead
2020-09-03 10:03:33 -04:00
115b3b6921
REFACTOR: Remove `_.isEmpty` in favor of the existing version
2020-09-03 10:03:33 -04:00
65f6a92129
REFACTOR: Replace `_.extend` with `Object.assign`
2020-09-03 10:03:33 -04:00
2f11457263
REFACTOR: Use `Array.isArray` instead of `_.isArray`
2020-09-03 10:03:33 -04:00
67dec38f31
FIX: Gravatar download attempt if user is missing their email
...
It is possible that a user could exist without an email, if so we should
not enqueue a job to download their gravatar.
This commit resolves this error that can occur:
```
Job exception: undefined method `email' for nil:NilClass
/var/www/discourse/app/models/user.rb:1204:in `email'
/var/www/discourse/app/jobs/regular/update_gravatar.rb:12:in `execute'
```
This commit also fixes the original spec which actually was wrong. The
job never enqueued in the original spec and so the gravatar was never
actually updated and the test was checking if the two values were the
same, but they were both null and never updated, so of course they were
the same!
A new test has also been added to make sure the gravatar job isn't
enqueued when a user's email is missing.
2020-09-02 20:19:46 -06:00
9954a677ab
FIX: don't send mailing list for post with empty content ( #10577 )
...
discourse-assign is creating posts with empty content to show that a specific user was assign/unassigned for a specific topic.
It is causing confusing emails with empty content
The bug was mentioned here: https://meta.discourse.org/t/again-on-empty-emails-and-notifications-generated-on-topic-assignment/162213
2020-09-03 08:58:25 +10:00
de038c0eab
FIX: highlightjs 10 requires some languages to be loaded before others ( #10584 )
...
cs is also not present in 10 and relies only on csharp file, but for cs alias to work csharp has to be loaded.
2020-09-02 21:32:57 +02:00
6a837c32e4
DEV: Add class to wizard HTML element
2020-09-02 14:53:38 -04:00
50827684d5
UX: Hide category settings badges checkbox when enable_badges is off
2020-09-02 11:23:59 -04:00
0a492829ea
Add category id to webhook post serializer
2020-09-02 10:42:51 -04:00
c6e336b519
REFACTOR: simplifies connectors code ( #10579 )
...
- directly uses factoryFor to avoid having to set owner later
- drops jquery usage
- renames view into component as I find it more explicit
2020-09-02 15:53:42 +02:00
879e274dc7
UX: wrap extra long links in GitHub oneboxes instead of overflowing
2020-09-02 21:50:57 +08:00
31c1d57228
FIX: System message wasn't fully translatable
2020-09-02 15:24:25 +02:00
ef68e11137
FIX: Check if invite has expired before showing it ( #10581 )
2020-09-02 13:24:49 +03:00
01600492de
FIX: Don't raise error in update username job if user has been deleted.
2020-09-02 11:17:17 +08:00
ec0b4b2acc
FIX: wait for groups before showing empty message
2020-09-01 22:36:00 -04:00
d49e96c6a3
DEV: add plugin hooks for silence message parameters ( #10538 )
...
DEV: add plugin hooks for silence message parameters
Allows plugins to add, and update extra silence message params for custom
i18n vars
Allows plugins to override system messages via `message_title` and
`message_raw` parameters. We can later expose these params where necessary via event
hooks. Expose the parameter for the on user_silenced trigger.
2020-09-01 17:25:24 -07:00
26ec4fd25b
FIX: User export category preferences on a deleted category. ( #10573 )
...
Tests from a1dd761bd9
2020-09-01 13:22:59 -07:00
b14098ce28
removed REGEXP_IN_MATCH regex to make it flexible to use with plugins ( #10476 )
...
* dynamic regex generation for 'STATUS' and 'IN' ddropdown
2020-09-01 14:33:05 +02:00
34478760b2
Update annotations.
2020-09-01 13:41:04 +05:30
f8062300da
DEV: removes jquery usage from highlight-syntax ( #10564 )
2020-09-01 09:50:49 +02:00
bb2e830010
Remove out-of-date / non-core annotations.
2020-09-01 12:40:57 +05:30
e66eefe179
Annotate models.
2020-09-01 10:22:32 +05:30
084e15b447
FIX: modify notification after remove auto_watch_category ( #10568 )
...
When a category is removed from `auto_watch_category` we are removing
CategoryUser. However, there are still TopicUser with notification level
set to `watching` which was inherited from Category.
We should move them back to `regular` unless they were modified by a user.
2020-09-01 13:07:41 +10:00
e824385e64
only remove edit button margin when text is hidden
2020-08-31 22:45:43 -04:00
069a109cbb
DEV: Require scheduled job in development to avoid loading file twice.
...
This removes the need to memoize constant in order to avoid the "warning: already initialized constant".
2020-09-01 10:14:40 +08:00
a1dd761bd9
FIX: Handle deleted categories in post export ( #10567 )
...
Fixes a crash when exporting my own archive on Meta.
2020-08-31 17:33:28 -07:00
594d919d22
FIX: Focus first button in topic admin menu ( #10562 )
...
When using Shift+A to toggle the admin menu for a topic the first button was not focused, so the menu could not be navigated with tab.
2020-09-01 10:29:35 +10:00
5ec5fbd7ba
User export improvements 2 ( #10560 )
...
* FEATURE: Use predictable filenames inside the user archive export
* FEATURE: Include badges in user archive export
* FEATURE: Add user_visits table to the user archive export
2020-08-31 15:26:51 -07:00
c3560a66f3
DEV: CSS truncation followup
...
After merging this
58fe78bf28 (diff-fed21847d651f6eb2cc76abbd770f5f8)
2020-09-01 02:01:17 +08:00
2550c5bd03
FIX: Ensure disabling 2FA works as expected ( #10485 )
2020-08-31 09:56:57 -07:00
2a3a173e8e
FIX: Disable insert link button when editing a category ( #10549 )
2020-08-31 13:50:40 -03:00
58fe78bf28
UX: don't wrap topic status icons in the header if there's more than one
...
Context: https://meta.discourse.org/t/when-a-topic-is-closed-and-pinned-the-pin-icon-in-header-not-in-correct-place/162473
Flex is causing a bit of a problem here since it makes the `topic-statuses` div in the header wrap when it has more than one icon. Given that we already use grid on the parent and that the icons are aligned properly, I think it's safe to remove it here.
2020-09-01 00:40:42 +08:00
f2e14a3946
FEATURE: Add site setting and wizard step to set base font ( #10250 )
...
Co-authored-by: Neil Lalonde <neillalonde@gmail.com>
2020-08-31 13:14:09 +03:00
5270cd97ef
DEV: Leaking state in `PostActionNotifier` in tests take 2.
...
Follow-up to a3b48826
2020-08-31 12:55:42 +08:00
a3b4882665
DEV: Leaking state in `PostActionNotifier` in tests.
...
Follow-up to 8a0478b97d
2020-08-31 12:04:17 +08:00
b31da92ede
DEV: clear last seen cache consistently
...
Previously in some cases the test suite could fail due to a bad entry in
redis from previous tests
This ensures the correct cache is expired when needed
Additionally improves performance of the redis check
2020-08-31 08:54:42 +10:00
8ca8a7edba
DEV: Lint file
...
Ruby in warning mode complains about `foo *[]` instead `foo(*[])` is
preferred
2020-08-31 08:52:01 +10:00
b4c5f6631f
FIX: Do not set color_scheme_id in user options when no schemes are marked as selectable
2020-08-30 09:32:40 -04:00
7bba65b6f5
UX: Restyle user menu so user links are findable ( #10554 )
2020-08-28 20:20:59 -04:00
Robert
Jordan Vidrine
Neil Lalonde
Joshua Rosenfeld
Guo Xiang Tan
Martin Brennan
Ahmed Gagan
Joffrey JAFFEUX
Robin Ward
dependabot[bot]
awesomerobot
Bianca Nenciu
Bianca Nenciu
Vinoth Kannan
Blake Erickson
Krzysztof Kotlarek
Penar Musaraj
Joe
Gerhard Schlager
Dan Ungureanu
Jeff Wong
Kane York
Arpit Jalan
tshenry
Roman Rizzi
Sam Saffron
