2 Commits

Author	SHA1	Message	Date
Alan Guo Xiang Tan	41f8bff2c3	DEV: Remove superfluous `js: true` metadata (#21960) ... Why this change? It is very unlikely that we need to ever JS for system tests considering that we rely on a JS framework on the frontend.	2023-06-07 09:26:58 +08:00
Alan Guo Xiang Tan	e3977f84a3	FIX: Incorrect topic tracking state count when a new category is created (#20506) ... What is the problem? We have a hidden site setting `show_category_definitions_in_topic_lists` which is set to false by default. What this means is that category definition topics are not shown in the topic list by default. Only the category definition topic for the category being viewed will be shown. However, we have a bug where we would show that a category has new topics when a new child category along with its category definition topic is created even though the topic list does not list the child category's category definition topic. What is the fix here? This commit fixes the problem by shipping down an additional `is_category_topic` attribute in `TopicTrackingStateItemSerializer` when the `show_category_definitions_in_topic_lists` site setting has been set to false. With the new attribute, we can then exclude counting child categories' category definition topics when counting new and unread counts for a category.	2023-03-06 10:13:10 +08:00