7f69362d9d
FIX: external links in whisper ended up in a white page
...
FIX: clicking a link in a onebox wasn't properly extracting the post_id
2017-12-20 17:55:15 +01:00
86c86a1ddb
FIX: prevent loading of invalid locales from plugins
2017-12-20 12:14:39 +01:00
6a2bce1931
FIX: Data loss on update of single user_field.
...
https://meta.discourse.org/t/api-data-loss-caused-by-changed-behaviour-of-custom-user-field-update/74990
2017-12-20 16:33:23 +08:00
7aa56fc9d9
refinement and test for batch mode on feature_topics
2017-12-20 13:58:05 +11:00
f5a3be750c
PERF: add option to limit how many categories are processed in one call to CategoryFeaturedTopic.feature_topics ( #5446 )
2017-12-20 13:42:29 +11:00
eab66065d1
FEATURE: search log term details page ( #5445 )
2017-12-20 13:41:31 +11:00
24e89b6b38
FIX: validates 'ThemeField' name when used in a SCSS variable
2017-12-19 16:10:44 +01:00
30ddc1f222
Don't swallow errors when failing to create message for post action.
2017-12-19 10:58:26 +08:00
b39d3a863d
FIX: `moderators` group wasn't being updated to be messagable by everyone.
...
https://meta.discourse.org/t/custom-flag-not-showing-text/76244
2017-12-19 10:14:56 +08:00
1abc276451
FIX: properly omit inactive and silenced users from directory
2017-12-19 12:53:59 +11:00
b91f83eb7d
Ignore auto-quote/reply when counting replies
2017-12-15 00:38:14 +01:00
f18dda2adc
FEATURE: full rebake of all old posts
...
This limits to 100 post per 15 minutes, so it will take a while.
This will pick up CommonMark and a large amount of onebox fixes.
2017-12-15 10:28:25 +11:00
092c976d7c
FIX: prevent 💥 when selecting replies to posts quoting themselves
2017-12-15 00:23:51 +01:00
4fcf9ece3a
Allow plugins to customize the columns returned by user_actions
...
This is useful if they have a different mechanism for rendering an
avatar and want to include custom columns via the `custom_avatar_column`
plugin function.
2017-12-14 16:52:54 -05:00
f2565f6c7e
SECURITY: Any group can be invited into a PM.
2017-12-14 14:57:48 +08:00
5db3d39b05
FIX: Post.reply_ids should also handle quotes
2017-12-14 00:43:48 +01:00
0f4ed2e070
display language name in user locale selector - make it consistent with admin ( #5424 )
2017-12-14 08:17:36 +11:00
1b4483c942
FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts
2017-12-13 22:12:06 +01:00
712c9fca1b
sorry rubocop
2017-12-13 15:47:42 -05:00
3f1d6a302e
FIX: links with query params to external sites fail to load if ga universal auto link domains is used
2017-12-13 13:58:44 -05:00
d5293aeae2
Clean `Topic#slug` when `SiteSetting.slug_generation_method` changes.
...
https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld
2017-12-13 16:11:07 +08:00
a7c1b0c81f
FIX: path whitelist for embedded comments didn't work with non-ASCII chars
2017-12-12 20:17:46 +01:00
e30851e45a
Move escape_uri method to a more suitable place
2017-12-12 20:17:46 +01:00
af3c153687
make robocop 🤖 happy
2017-12-12 11:33:35 +01:00
62a5b174e1
FIX: wasn't able to use the same username when taking over a staged account
2017-12-12 11:26:00 +01:00
4bd5acec47
FIX: `Topic#featured_link` may contain more than a URL.
2017-12-11 16:36:19 +08:00
3c56c9b637
FIX: strip webhook payload_url
2017-12-11 13:48:11 +05:30
74b9828731
FIX: Remove mentions filters from user and groups
...
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
4ae1bbaeba
FIX: Only show the full suspension reason on the admin side
2017-12-07 13:27:02 -05:00
f0ef307d2d
FIX: topic timer offset applied two times
...
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.
This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1 hour to your timezone offset.
2017-12-07 14:42:58 +01:00
daeb7694bc
update annotations
2017-12-05 21:03:20 +05:30
e73fbfe265
FIX: `Topic#featured_link_root_domain` extracts URL before parsing.
2017-12-04 10:00:07 +08:00
496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
...
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
e3925278e2
FEATURE: support search click through tracking for user, category and tags
...
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj
This commit adds following features:
- support for tracking click through to user, tag and category
- new filter for search type (header, full page)
This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
7f2eeaf767
FIX: Password required flag should be cleared whenever clearing the raw password ( #5384 )
2017-12-01 15:19:24 +11:00
1ee48966ca
REVERT: FIX: Password required flag should be cleared whenever clearing the raw password
2017-11-30 16:17:14 +05:30
1776649b4d
FIX: Password required flag should be cleared whenever clearing the raw password
2017-11-30 13:40:18 +05:30
853b51b519
Add uniqueness validation for `SingleSignOnRecord#external_id`.
2017-11-30 15:15:52 +08:00
1c2d1682ae
Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check
...
FIX: Re-enable invalid interpolation keys check and allow default key…
2017-11-30 13:04:54 +08:00
9fbe1436b6
UX: Replace heuristic solution root domain extraction for topic featured link.
2017-11-29 21:52:41 +08:00
bb0b7b61d7
FIX: Don't fail silently when updating a record.
2017-11-29 08:01:13 +08:00
23ee3047bf
FIX: Future date input selector was not respecting timezone
2017-11-28 13:44:24 -05:00
77f90876d3
REFACTOR: Track manual locked user levels separately from groups
2017-11-27 11:23:44 -05:00
5805979e88
FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
...
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
b3094e9954
FIX: incoming and outgoing emails got lost when post was moved
2017-11-24 11:45:36 +01:00
406ad1a1f2
Merge pull request #5357 from techAPJ/invite-trust-level
...
FIX: invited users were not granted trust level based on their group
2017-11-23 23:42:20 +05:30
ad07e6e172
FEATURE: `group_removes_trust_level` setting
...
By default in Discourse, if a group grants a user a particular trust
level that is locked even if they are removed from the group.
With this new setting, when a user is removed from a group their
trust level is set to either the next highest trust level based on group
membership, or they are unlocked and promoted based on the default
mechanisms.
2017-11-23 13:03:24 -05:00
3508046e33
FIX: invited users were not granted trust level based on their group
...
https://meta.discourse.org/t/bulk-invites-and-trust-level/73535
If the user enters password when accepting invite they were not granted
trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.
2017-11-23 22:19:28 +05:30
39810e4425
FIX: do not move small post actions
2017-11-23 17:25:53 +01:00
6c86e0c94a
FEATURE: remove the featured link by editing the topic
2017-11-22 14:53:35 -05:00
f7642e076d
REFACTOR: Avoid duplicated logic on server and client.
2017-11-21 17:10:04 +08:00
2d48caffdf
FIX: be more lenient when deleting a custom emoji
2017-11-20 23:50:23 +01:00
7e841a0495
FIX: stop counting PMs, deleted topics and whispers in directory and user stats
2017-11-20 16:44:09 +11:00
92a831bae6
FEATURE: user directory returns staged users during search
2017-11-19 01:17:31 +01:00
6dda87c49b
FEATURE: show topics viewed on user summary
2017-11-17 17:53:30 -05:00
87ec11e298
FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats.
2017-11-17 16:08:46 -05:00
8f6d35aa59
FEATURE: category setting for mailinglist mirror
2017-11-17 15:29:14 +01:00
b37e40eea9
FEATURE: show read time in last 60 days
2017-11-16 15:46:51 -05:00
678e28794a
FIX: properly handle too large & broken images in posts
2017-11-16 15:45:07 +01:00
174ab2d93a
minor, ensure ordering of custom fields is consistent
2017-11-16 15:14:10 +11:00
20fbf81505
FEATURE: Allow plugins to easily add defaults to GlobalSetting
...
usage:
GlobalSetting.add_default("plugin_setting_name", "value")
2017-11-16 08:39:29 +11:00
9207dee69a
FEATURE: escape HTML when cooking plaintext emails
2017-11-15 20:22:11 +01:00
9e03b5c69a
FIX: Don't load other locales in test mode
2017-11-15 12:50:20 -05:00
fc73de9578
Support for finding new locales in plugins
2017-11-15 11:20:04 -05:00
cbc0afb399
REFACTOR: Instance methods added to 'PluginStore' model for easy access ( #5315 )
2017-11-15 10:10:20 -05:00
2e7c61681e
PERF: n+1 query when fetching search_logs
2017-11-15 16:23:57 +05:30
9ed16343fc
Remove email column from schema information
2017-11-15 15:45:19 +05:30
ee1f68438e
UX: sort search logs results by unique searches
2017-11-15 12:58:40 +05:30
3831663fea
FEATURE: search logs page ( #5313 )
2017-11-15 11:13:50 +11:00
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
4be8f17e66
FIX: counting invites didn't work
...
PostgreSQL reported the following error:
"for SELECT DISTINCT, ORDER BY expressions must appear in select list"
2017-11-14 11:40:07 +01:00
075a458489
FIX: child theme component vars not resolved in parent
2017-11-14 15:22:59 +11:00
d3baae5365
removes whitespaces and uses scope
2017-11-13 15:23:24 +01:00
1f14350220
Rename "Blocked" to "Silenced"
2017-11-10 14:10:27 -05:00
ec3d800492
add option to force DirectoryItem.refresh_period! to run even if user directory is disabled
2017-11-10 12:30:22 -05:00
16ff2a4715
FIX: topic counts after converting topic to/from public and private
2017-11-09 15:33:44 -05:00
38b8d68c68
FEATURE: Allow the user to select a custom home page ( #5268 )
...
* Add user_home configuration option
* Use the new user_home preference to actually show the right home page
* Fix trailing whitespace
* Update user_option_serializer.rb
* Fix JavaScript default homepage tests
* Use an object instead of a giant switch
* Remove trailing whitespace
* Make the default `user_home` set to `null` instead of `0`
* Rename user_home to homepage_id
2017-11-10 06:45:19 +11:00
b21d5d3633
FIX: SSO email match should be case insensitive
2017-11-08 20:37:41 +05:30
6090994cdf
FEATURE: Retain the latest 30 days of WebHookEvent records by default.
2017-11-08 14:11:01 +08:00
9abeaa4719
Revert "Validates presence of `UserEmail#user_id` in AR."
...
This reverts commit 0dec3269d8
2017-11-08 11:54:18 +08:00
0dec3269d8
Validates presence of `UserEmail#user_id` in AR.
2017-11-08 11:43:41 +08:00
4bb454d889
FIX: JSON custom fields incorrectly being converted to an array.
...
https://meta.discourse.org/t/custom-fields-simultaneous-save-with-json-becomes-an-array/73647
2017-11-08 11:17:37 +08:00
9355f92f78
Add more verbose SSO logging.
2017-11-07 19:38:36 +08:00
95c891cf11
Raise error if sso record fails to create.
2017-11-07 18:38:38 +08:00
b3237d37f0
Drop unused email column from users table.
2017-11-07 10:12:33 +08:00
d320f4840d
FIX: Unable to invite groups that are not public visible into pms.
...
https://meta.discourse.org/t/inviting-groups-broken-in-head/73346/6
2017-11-03 21:40:33 +08:00
c7d7cb940c
FIX: dashboard posts report was including posts in daily data, but not in totals
2017-11-02 18:46:28 -04:00
24af9b7d97
FIX: when a topic is deleted, update the post count stats of all user who replied
2017-11-02 18:05:23 -04:00
edf4af608e
FIX: Better match when searching for groups.
2017-11-02 10:20:14 +08:00
076df104dc
FEATURE: Support filtering of groups page by category if in url
2017-10-31 17:50:06 -04:00
d753adab84
FIX: badge description links broken on subfolder
2017-10-31 15:18:52 -04:00
e02ad4249e
FIX: In case that `category` is `nil` it should not throw an error
2017-10-30 11:59:13 -04:00
00bc79439a
FIX: Couldn't disagree with "notify moderator" flags
2017-10-30 10:52:00 -04:00
fab3e25101
FIX: badge selector showing up for anon
2017-10-30 16:21:31 +11:00
530624d438
FIX: Couldn't agree with a custom flag type
2017-10-26 14:41:11 -04:00
f1615c2148
Merge pull request #5263 from tgxworld/improve_pattern
...
REFACTOR: Always validate email by default.
2017-10-26 14:34:09 +08:00
defea6245c
REFACTOR: Always validate email by default.
2017-10-25 13:48:34 +08:00
0d816302e2
Explicitly avoid all readonly protection and scoping
2017-10-25 13:31:44 +11:00
877b7be579
FIX: in readonly mode don't double count pages
2017-10-25 13:19:43 +11:00
19f3b81161
Revert "FIX: always trigger the ':user_updated' event"
...
This reverts commit 519b70ea46https://meta.discourse.org/t/creating-a-topic-or-a-post-sends-the-user-updated-webhook/71643
2017-10-23 11:44:22 +08:00
e00d330579
FIX: Defer wasn't working on all flag types
2017-10-20 10:04:55 -04:00
4205c1ad2b
FIX: postprocessing ignored cook method
2017-10-20 10:26:45 +02:00
aad5118aa9
FIX: Post Action Type 6 is not a notify type
2017-10-19 17:13:55 -04:00
7cfb8ed5c1
FIX: You can't notify a user on a flag topic
2017-10-19 14:11:31 -04:00
838568cbc3
Refactor flag types for more customization
2017-10-19 13:55:23 -04:00
1cae875146
FIX: topic link extraction shouldn't fail when the parsed URL has no path
2017-10-19 15:26:37 +02:00
3cd73cdf18
FIX: fancy topic title must fit into column
2017-10-19 14:34:30 +02:00
22ba70fb01
Merge pull request #5226 from tgxworld/allow_user_to_disable_private_messages
...
FEATURE: Allow users to disable new PMs.
2017-10-19 16:46:18 +08:00
5b9ddaf972
FIX: `Topic#fancy_title` should not write in readonly mode.
2017-10-19 16:07:03 +08:00
25c25ae423
FEATURE: Allow user to leave a PM.
2017-10-19 12:32:55 +08:00
79de10b212
FEATURE: Allow users to disable new PMs.
...
https://meta.discourse.org/t/is-it-possible-to-disable-private-messaging-for-a-specific-user/46391
2017-10-19 12:32:55 +08:00
b54eb8f53c
FIX: Set PG `connect_timeout` to 5 seconds.
...
* 30 seconds is alittle too long.
2017-10-17 12:32:41 +08:00
f73a3cc0d4
Don't include suspended_at or suspended_till unless suspended
2017-10-13 12:17:54 -04:00
4e89d3f778
Only refresh site settings once on initialization.
2017-10-12 14:12:18 +08:00
a2183c3f1d
SECURITY: verify that inviter can invite new user to a topic
2017-10-09 15:59:41 +05:30
4ea87b5ab8
Merge branch 's3_refactor'
2017-10-09 10:27:52 +11:00
8d14d55fc5
make rubocop happy
2017-10-06 16:48:11 +02:00
3bdd8f57c1
FIX: invited staged users would sometimes not get notified of replies
2017-10-06 16:37:28 +02:00
70bb2aa426
FEATURE: allow specifying s3 config via globals
...
This refactors handling of s3 so it can be specified via GlobalSetting
This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3
It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
d67f0b39ae
Update annotations.
2017-10-06 11:13:01 +08:00
5dc4b469be
Remove unused code for Redis Sentinel.
2017-10-05 14:53:03 +08:00
b0557c6692
UX: Allow users to remove a remind me topic timer.
2017-10-05 11:50:08 +08:00
f5a2ed99b0
FIX: deleting category background images sometimes has no effect
2017-10-04 17:04:37 -04:00
e212435545
FIX: redirect to top wasn't working
2017-10-04 22:08:41 +02:00
1310181664
FIX: Adding a public topic timer deletes a private topic timer.
2017-10-04 16:31:40 +08:00
0342324b47
FEATURE: support regex in rake post:remap ( #5201 )
2017-10-04 11:47:53 +11:00
4fbe4218c4
FIX: Header primary color was too dark in dark mode
2017-10-03 13:01:05 -04:00
00b190af75
Revert "A safe way to create class variables in a multisite environment."
...
The approach taken by this interface was flawed. We need a better
solution.
2017-09-29 11:06:12 -04:00
d64853dfa0
FIX: update group.has_messages field weekly
2017-09-29 08:23:07 +05:30
30fa5379ce
Merge pull request #5195 from henrik/patch-1
...
100.years.ago -> Time.at(0)
2017-09-28 15:47:06 +08:00
8ecf313a81
FIX: correctly raise errors when downloads fail
...
This corrects an issue where we are hitting Gravatar for 404 over and over
Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
b80320da5e
no verbose logging for failed downloads of gravatars
2017-09-28 11:32:26 +10:00
3e13becf33
A safe way to create class variables in a multisite environment.
...
This should allow plugins to set class variables that will not
stomp on other plugins.
2017-09-27 13:00:47 -04:00
367fb1c524
FIX: Onebox fails on encoded URL.
...
https://meta.discourse.org/t/onebox-breaks-if-theres-chinese-text-in-url/67364
2017-09-26 18:34:54 +08:00
69e170efe8
Require right dependency.
2017-09-26 17:28:53 +08:00
c37598ddbc
Merge pull request #5200 from gschlager/embed
...
FIX: do not escape already escaped chars in URL
2017-09-26 09:07:57 +08:00
09ed2ed749
Add Suspend User to flags page
2017-09-25 12:28:00 -04:00
d7c37d9369
Add front end service for staff controls
2017-09-25 12:25:14 -04:00
40eba8cd93
FEATURE: View flags grouped by topic
2017-09-25 12:25:14 -04:00
88555f32cf
Improve specs.
2017-09-25 13:49:00 +08:00
e542884b00
FIX: Incorrect notification state being published.
2017-09-25 13:48:59 +08:00
23b787e0a6
Require dependency otherwise it causes Sidekiq to lock up in development.
2017-09-25 13:48:59 +08:00
77d4c4d8dc
Fix all the errors to get our tests green on Rails 5.1.
2017-09-25 13:48:58 +08:00
6f6b47f096
FIX: do not escape already escaped chars in URL
2017-09-22 17:36:44 +02:00
1a435414d5
FIX: handle URL encoded email addresses
2017-09-22 14:26:06 +02:00
77cc33b231
100.years.ago -> Time.at(0)
...
A bit more robust ;)
2017-09-19 08:48:50 +01:00
8ed318c4fe
display 'similar to' earlier when composing a post
2017-09-16 01:03:29 +02:00
797936d2c5
FIX: don't leak whisper count in user card
2017-09-14 20:08:16 +02:00
f3d3129113
FIX: Use default locale for edit reason when owner of post gets changed
2017-09-14 17:17:37 +02:00
efef422416
FIX: Use default locale for moderator post when posts are moved
2017-09-14 17:17:37 +02:00
Régis Hanol
Gerhard Schlager
Philipp Daniels
Sam
Neil Lalonde
Arpit Jalan
Guo Xiang Tan
Robin Ward
Maja Komel
Joffrey JAFFEUX
Vinoth Kannan
Guo Xiang Tan
Vinoth Kanan
Michael Howell
Kyle Zhao
Henrik Nyh