Commit Graph

15292 Commits

Author SHA1 Message Date
Guo Xiang Tan 853b51b519 Add uniqueness validation for `SingleSignOnRecord#external_id`. 2017-11-30 15:15:52 +08:00
Guo Xiang Tan f7f743970b Just use space to prettify SSO verbose error logging. 2017-11-30 15:10:00 +08:00
Guo Xiang Tan 1c2d1682ae
Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check
FIX: Re-enable invalid interpolation keys check and allow default key…
2017-11-30 13:04:54 +08:00
Sam 05f5df69b1 UX: Add tooltips for messages and notifications in header 2017-11-30 12:56:54 +11:00
Sam 772301bc65 woops 2017-11-30 12:32:50 +11:00
Sam bf1f6c7fe4 UX: better help text for composer collapse / discard
also: warn on collapsed close if you are to discard content
2017-11-30 12:28:00 +11:00
Régis Hanol 0d34caff85 UX: show error message when no gravatar is associated 2017-11-29 18:09:44 +01:00
Régis Hanol 1218ead355 UX: preloaded gravatar was appearing on the right instead of the left 2017-11-29 18:07:09 +01:00
Guo Xiang Tan 9fbe1436b6 UX: Replace heuristic solution root domain extraction for topic featured link. 2017-11-29 21:52:41 +08:00
Guo Xiang Tan 8491c5fba5 UX: Replace heuristic solution for extracting root domain. 2017-11-29 16:26:46 +08:00
Guo Xiang Tan 3e9c3f6f13 Fix JS test.
* `new Array` doesn't seem to be available in phantomJS yet.
2017-11-29 16:03:00 +08:00
Guo Xiang Tan 5b965ab5d0 Sync editor and preview when preview is updated. 2017-11-29 11:19:04 +08:00
Kris 03eb278034
FIX: Increased composer width to match preview, border width fix (#5379) 2017-11-28 21:57:27 -05:00
Guo Xiang Tan ebc31975e8 `Ember.run.schedule` -> `Ember.run.scheduleOnce`. 2017-11-29 10:43:59 +08:00
Guo Xiang Tan de17a8e856 UX: Sync input and preview when user is typing. 2017-11-29 09:56:15 +08:00
Guo Xiang Tan 4816619ba3 FIX: Editor and preview does not sync when scrolled to the bottom. 2017-11-29 08:38:57 +08:00
Guo Xiang Tan bb0b7b61d7 FIX: Don't fail silently when updating a record. 2017-11-29 08:01:13 +08:00
Gerhard Schlager 44ee388070 FEATURE: omit images from og and twitter description tags 2017-11-28 21:34:02 +01:00
Robin Ward 04e8b7dffb UX: Remove another plugin outlet container we don't need 2017-11-28 14:46:17 -05:00
Robin Ward 86df5846c8 Don't use a tag for a couple of topic outlets 2017-11-28 14:42:24 -05:00
Robin Ward 823896d698 FIX: Use parseable date format 2017-11-28 14:16:33 -05:00
Kris fbc4191195 moving inputs outside of label tag 2017-11-28 14:12:01 -05:00
Robin Ward 23ee3047bf FIX: Future date input selector was not respecting timezone 2017-11-28 13:44:24 -05:00
Robin Ward f4b3306bf4 FIX: Link from flagged topics to user was broken 2017-11-28 13:10:30 -05:00
Gerhard Schlager 41e70c410c
FEATURE: replace GUID in image name uploaded from iOS (#5370) 2017-11-28 11:05:34 +01:00
Arpit Jalan f37a1d5976 UX: add tooltip to unique on search logs page 2017-11-28 15:29:35 +05:30
Guo Xiang Tan 1d8b834301
Merge pull request #5369 from vinothkannans/queued
FIX: Error if queued post not found while updating
2017-11-28 17:51:05 +08:00
Angus McLeod 8a0d7bb922 Update wizard import to new select-kit style path (#5375) 2017-11-28 10:06:05 +01:00
Guo Xiang Tan 110dfbf42f Uglify doesn't support ES6 yet. 2017-11-28 16:07:27 +08:00
Guo Xiang Tan 7b8699f3be FIX: Can't load `service-worker.js` in production. 2017-11-28 15:40:57 +08:00
Jeff Wong b094894c94 Feature: Add service worker registration method to plugin API 2017-11-28 14:01:41 +08:00
Sam b3b55e18d1 UX: stop warping tiny onebox images 2017-11-28 12:32:35 +11:00
Sam ceaadf6246 UX: adjustments for topic title editing 2017-11-28 12:00:18 +11:00
Kris 87c83f102d small color fix 2017-11-27 18:30:12 -05:00
Kris d31c8ffa87
small color adjustment (#5374) 2017-11-27 18:20:07 -05:00
Sam 5a715b7d55 lint it up 2017-11-28 07:39:24 +11:00
Kris ada1d6b987
Composer restyle
* composer restyle, some input normalization

* style adjustments: spacing, preview background, colors

* small spacing adjustments, removing default iOS input appearance, fixing merge

* small width adjustment

* fixing mobile link modal for small devices

* FIX: more resilient allowInitiatlValueMutation implementation

* Build scrollMap only on scroll.

* FIX: pick date and time was not reseting state

* FIX: removes auto sizing and touchstart support for now

* Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"

This reverts commit b5ed980235.

* tweak icon-library generation

* FIX: regression preventing to set number of hours before closing

This commit also adds a full test suite for editing topic timer.

* FIX: makes allowInitialValueMutation more restrictive

* FIX: invite-list expects initial value mutation

* fixing tag input spacing

* minor input cleanup

* bump onebox version

* FIX: avoids test failing at some times of the day

* FIX: various issues when editing category permissions

This commit also adds multiple tests
2017-11-27 15:23:18 -05:00
Joffrey JAFFEUX 49b1df40fc
FIX: various issues when editing category permissions
This commit also adds multiple tests
2017-11-27 19:50:04 +01:00
Neil Lalonde c22f202e10 FIX: missing likes count on top topics in user summary 2017-11-27 13:42:16 -05:00
Robin Ward 36d46df8dc New setting to show the reply title on the post menu on mobile 2017-11-27 13:21:53 -05:00
Arpit Jalan 2c16240b60 fix the build 2017-11-27 23:18:08 +05:30
Arpit Jalan bf415f2d40 FIX: youtube playlist videos were not functioning properly in fullscreen 2017-11-27 22:56:44 +05:30
Robin Ward 77f90876d3 REFACTOR: Track manual locked user levels separately from groups 2017-11-27 11:23:44 -05:00
Vinoth Kannan 31aa21b5a4 FIX: Error if queued post not found while updating 2017-11-27 19:25:51 +05:30
Sam 608207b2e5 FEATURE: avatar proxy happens in background
This ensures that even if it is slow to download avatars site will
continue to work

Also simplifies hijack pattern
2017-11-27 17:43:24 +11:00
Sam d5e7691ae9 favicon proxy now uses hijack 2017-11-27 14:51:14 +11:00
Guo Xiang Tan 5805979e88 FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
Sam eb428ef54d FEATURE: uploads are processed a faster
Also cleans up API to always return 422 on upload error. (previously returned 200)

Uploads are processed using new hijack pattern
2017-11-27 12:43:35 +11:00
Sam a74ac90bf5 FIX: quote dropped when replying as new topic 2017-11-27 10:08:55 +11:00
Angus McLeod 4b919cd735 Move queuedForTyping assignment (#5366) 2017-11-27 09:43:41 +11:00
Joffrey JAFFEUX 329343be06
FIX: various sizing issues on select-kit 2017-11-26 17:21:39 +01:00
Arpit Jalan abbb2b28eb bump onebox version 2017-11-25 15:53:18 +05:30
Neil Lalonde 39d7745dc5 UX: show staged users' email addresses to staff without requiring a button press 2017-11-24 16:11:34 -05:00
Neil Lalonde 510a2a1e0f remove ancient unused css 2017-11-24 15:42:50 -05:00
Neil Lalonde 6f8f2c494d FIX: admin strings in plugins should fallback to english when untranslated 2017-11-24 14:11:01 -05:00
Kris c2da25dd5c
Cleaning up the 404 page (#5363) 2017-11-24 12:41:31 -05:00
Guo Xiang Tan f3f051a344 UX: Composer textarea should always start at the top. 2017-11-24 23:24:37 +08:00
Joffrey JAFFEUX f2c7f39066
FIX: invite-list expects initial value mutation 2017-11-24 13:32:24 +01:00
Joffrey JAFFEUX 96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive 2017-11-24 13:15:02 +01:00
Gerhard Schlager b3094e9954 FIX: incoming and outgoing emails got lost when post was moved 2017-11-24 11:45:36 +01:00
Guo Xiang Tan 44333c5de3 REFACTORY: Dry up some composer syncing code. 2017-11-24 14:57:36 +08:00
Sam e0e99d4bbd PERF: hijack onebox requests so they do not use up a unicorn worker 2017-11-24 15:31:40 +11:00
Joffrey JAFFEUX 63307c303a
FIX: regression preventing to set number of hours before closing
This commit also adds a full test suite for editing topic timer.
2017-11-24 02:48:45 +01:00
Neil Lalonde 3f58b18dab FEATURE: user card shows staff if a user is staged and lets them check the email address 2017-11-23 16:38:11 -05:00
Arpit Jalan 406ad1a1f2
Merge pull request #5357 from techAPJ/invite-trust-level
FIX: invited users were not granted trust level based on their group
2017-11-23 23:42:20 +05:30
Robin Ward ad07e6e172 FEATURE: `group_removes_trust_level` setting
By default in Discourse, if a group grants a user a particular trust
level that is locked even if they are removed from the group.

With this new setting, when a user is removed from a group their
trust level is set to either the next highest trust level based on group
membership, or they are unlocked and promoted based on the default
mechanisms.
2017-11-23 13:03:24 -05:00
Joffrey JAFFEUX 9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX dd5562322b Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"
This reverts commit b5ed980235.
2017-11-23 18:24:26 +01:00
Arpit Jalan 3508046e33 FIX: invited users were not granted trust level based on their group
https://meta.discourse.org/t/bulk-invites-and-trust-level/73535

If the user enters password when accepting invite they were not granted
trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.
2017-11-23 22:19:28 +05:30
Gerhard Schlager 39810e4425 FIX: do not move small post actions 2017-11-23 17:25:53 +01:00
Joffrey JAFFEUX 616a0dae4e
FIX: removes auto sizing and touchstart support for now 2017-11-23 15:34:52 +01:00
Gerhard Schlager eaa54a5a64 FIX: don't store state of composer's preview in mobile view 2017-11-23 15:22:00 +01:00
Joffrey JAFFEUX 5b3ecffbb2
FIX: pick date and time was not reseting state 2017-11-23 15:18:27 +01:00
Guo Xiang Tan c5745feac6 Build scrollMap only on scroll. 2017-11-23 21:44:09 +08:00
Joffrey JAFFEUX fe94e7c453
FIX: more resilient allowInitiatlValueMutation implementation 2017-11-23 14:39:26 +01:00
Guo Xiang Tan ab839d134b Fix scrollmap included NaN values. 2017-11-23 18:08:43 +08:00
Joffrey JAFFEUX 9f0798682e
FIX: tweak alignment of select-kit in navigation bar 2017-11-23 10:42:39 +01:00
Guo Xiang Tan 486016acea UX: Improve editor and preview scroll syncing. 2017-11-23 17:02:02 +08:00
Sam 49f97d75b7 FIX: make uploads safe for block that can run later 2017-11-23 17:28:18 +11:00
Sam d43a54e83a FIX: use current_user.id in onebox instead of param 2017-11-23 15:32:19 +11:00
Sam 2fe131db9f UX: handle super tall images in onebox respectfully.
Tall images got distorted previously
2017-11-23 14:45:46 +11:00
Neil Lalonde 6c86e0c94a FEATURE: remove the featured link by editing the topic 2017-11-22 14:53:35 -05:00
Joffrey JAFFEUX d32c95b6e8
FIX: avoid touch on select-kit causing instant closing of it 2017-11-22 16:36:50 +01:00
Régis Hanol 8a7cbeef00 UX: hide 'dismiss' in notifications dropdown when there are no unread notifications 2017-11-22 15:56:01 +01:00
Régis Hanol 4addc5e329 Add missing contexts when destroying users 2017-11-22 15:43:54 +01:00
Joffrey JAFFEUX acdfb3ed03
FIX: don’t convert an object using EachProxy to an array 2017-11-22 14:33:04 +01:00
Joffrey JAFFEUX b14d9529b8
FIX: adds support for name changes tracking 2017-11-22 13:49:45 +01:00
Joffrey JAFFEUX 86b8f6b238
FIX: cast integer on truthy value and not only true
allows castInteger="true" to work
2017-11-22 13:40:22 +01:00
Joffrey JAFFEUX 5a992fe5e7
FIX: makes sure keyboard is disabled on mobile 2017-11-22 12:33:07 +01:00
Joffrey JAFFEUX a3b511f4f5
FIX: simplify keyboard handling 2017-11-22 11:29:30 +01:00
Joffrey JAFFEUX b2b565c2fb
select-kit initial plugin api implementation (0.8.13)
```
api.modifySelectKit("identifier-of-the-select-targeted")
  .modifyContent((context, existingContent) => {})
  .appendContent(() => {})
  .prependContent(() => {})
  .onSelect((context, val) => {});
```
2017-11-22 10:34:12 +01:00
Joffrey JAFFEUX f3db3c7e0b
FIX: future-date-input-row lost datetimes 2017-11-22 08:52:00 +01:00
Sam a92f61e926 FIX: allow login required sites access to attachements 2017-11-22 10:50:55 +11:00
Joffrey JAFFEUX 761f4afd85
FIX: tab should select and focus next tabindex 2017-11-21 23:28:48 +01:00
Robin Ward 8d98752b57 Allow sites to bootstrap the error page.
This will display working dropdowns and such even if the page is a 404.
2017-11-21 16:13:09 -05:00
Robin Ward be34b796ea UX: Add targetable class 2017-11-21 14:55:55 -05:00
Neil Lalonde 33feb62673 FIX: times showing as < 1m instead of blank 2017-11-21 14:33:49 -05:00
Neil Lalonde 66e53f449a UX: Auth complete page/modal has a link to continue to the site to accomodate auth methods that can't automatically redirect to Discourse 2017-11-21 13:56:19 -05:00
Joffrey JAFFEUX 12beb77afa
FIX: make sure the element exists before calling `off`
This commit fixes an issue happening only when running tests under `/qunit` and not with `rake qunit:test`
2017-11-21 19:08:59 +01:00
Robin Ward 7533e5b541 UX: Use date picker on full page search 2017-11-21 12:52:23 -05:00