7f14e185cc
Bump onebox version.
...
- prevent double escaping of URL
2019-06-27 23:35:35 +05:30
168a38dc29
Bump onebox version.
...
- better Twitch placeholder
- CSS for said placeholder
2019-06-26 23:22:29 +05:30
2af4002817
Bump onebox version.
...
- Add a placeholder icon for Twitch onebox preview
- Add CSS for showing fontawesome play icon for placeholder class
2019-06-26 13:40:14 +05:30
c3381b845b
DEV: Install diffy in production for `rake posts:inline_uploads` task.
2019-06-14 14:42:53 +08:00
29259b46ae
DEV: Verbose mode for `posts:inline_uploads` rake task.
2019-06-10 08:59:11 +08:00
1991af2abb
DEV: Switch `InlineUploads` to a regexp based implementation.
2019-06-04 15:54:25 +08:00
d93e5fb00d
DEV: Class that converts MD with old attachment links to new MD.
2019-06-04 15:54:25 +08:00
8511bfe583
Bump omniauth-google-oauth2 gem version
...
Pinning to an old version is no longer required following 8b4d6dafea
2019-06-03 19:17:00 +01:00
ee43b36b64
Bump onebox version. ( #7666 )
...
Fixes multiple possible sources of exceptions due to frozen strings. Wikipedia onebox was definitely failing before this patch.
2019-05-31 17:04:34 +02:00
75d413ad11
Bump onebox version. ( #7665 )
...
Fixes a regression with soundclound onebox due to frozen string literal.
2019-05-31 16:41:33 +02:00
bf3c781f26
Bump onebox version.
...
- add frozen string literal to all the files
2019-05-28 17:39:42 +05:30
ce89f19250
Bump onebox version.
...
- use Vimeo engine for private links only
- if og:video_url is missing, make one using Vimeo ID
2019-05-20 12:24:43 +05:30
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
d679c4e0eb
Bump onebox version.
...
- FIX: encode the URL per RFC 3986 spec
2019-05-06 18:17:42 +05:30
2ebe9e3a8b
Bump onebox version
2019-04-30 10:07:48 -03:00
09b3d0c2a0
DEV: Only install danger on Travis. ( #7452 )
2019-04-29 14:45:24 +08:00
09638fcd27
DEV: add note explaining why omniauth-google-oauth2 is pinned
2019-04-29 15:47:05 +10:00
4b455e741e
DEV: Ember 3.8.0
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-04-26 12:16:21 +02:00
e8f51815e5
Bump onebox version.
...
- Update github_blob engine to support displaying stl files
- FEATURE: add `data-original-href` attribute to Vimeo iframes
- Add poster image for video oneboxes
2019-04-24 13:59:14 +05:30
b3dcaacdf4
Update Rails to 5.2.3.
2019-04-20 10:49:54 +09:00
7e3628d11f
Added test-prof as a dependency ( #7395 )
...
test-prof is a collection of tools for analyzing test-suite performance.
2019-04-19 10:52:31 +02:00
2b8487b0ea
Removed "shoulda" gem in favor of "shoulda-matchers" and update ( #7387 )
...
* Update shoulda gem
* Remove shoulda gem in favor of shoulda-matchers only
2019-04-18 07:41:37 +10:00
76e76140e1
Bump onebox version
2019-04-12 10:28:36 -03:00
9c1d1777db
Bump onebox version
...
- adds support for oneboxing google drive files
- add styling for google drive onebox favicon
2019-04-10 13:37:24 +05:30
b0053f3a1c
FEATURE: bump onebox version, add styling for new reddit image onebox
2019-04-04 11:24:30 +02:00
b375dcb14a
DEV: Introduce parallel rspec testing
...
Adds the parallel_tests gem, and redis/postgres configuration for running rspec tests in parallel. To use:
```
rake parallel:rake[db:create]
rake parallel:rake[db:migrate]
rake parallel:spec
```
This brings the test suite from 12m20s to 3m11s on my macOS machine
2019-04-01 11:06:47 -04:00
cadd1d670f
DEV: Add simplecov as test dependency ( #7271 )
2019-04-01 16:00:11 +11:00
59491f3047
FIX: Add `sassc-rails` for plugins using sprockets to compile scss
...
This did not affect core because we have a custom stylesheet pipeline
2019-03-21 23:23:29 +00:00
f3d0d8fe7d
Upgrade to Ember 3.7.0
2019-03-20 14:43:25 +01:00
bd8e46a9c1
SECURITY: Upgrading Rails version to 5.2.2.1
2019-03-13 16:24:54 -03:00
77931b70c3
Revert "DEV: Upgrade to Ember 3.7.0 ( #6977 )" ( #7165 )
...
This reverts commit 3eebf8be73
2019-03-13 15:49:47 -03:00
3eebf8be73
DEV: Upgrade to Ember 3.7.0 ( #6977 )
...
* Upgrade to Ember 3.7.0
* use ember source 3.7.0.2
* fix mobile header
* fix navigation
2019-03-13 12:16:06 +01:00
a9648e8fd1
onebox version bump
...
- FIX: respect code indentation
2019-03-07 17:55:47 +05:30
1b1f9831b0
Bump onebox version
...
discourse/onebox@4dd5a62
2019-03-06 11:58:41 +05:30
33129efdb5
Revert "Bump onebox version"
...
This reverts commit 345f6237cb
2019-03-05 22:51:02 +01:00
345f6237cb
Bump onebox version
...
f2b361fc28
2019-03-05 22:18:49 +01:00
c36c9c2ee5
FEATURE: Import script for AnswerBase
...
Improves the generic database used by some import scripts:
* Adds additional columns for users
* Adds support for attachments
* Allows setting the data type for keys (numeric or string) to ensure correct sorting
2019-02-28 22:08:12 +01:00
2d247cc4e9
Bump onebox version
...
- deafult to dedicated vimeo and gfycat engine
2019-02-26 10:50:27 +05:30
83f13ecf82
FEATURE: bump onebox dependency
...
- Adds support of kaltura oneboxes
- Adds support for typeform oneboxes
2019-02-19 15:22:43 +11:00
4d674acc25
FEATURE: AWS SNS bounce notifications webhooks
2019-02-13 21:26:40 +01:00
36ff971c9c
FIX: Bump onebox version to include imgur security fix
2019-02-13 01:11:24 +05:30
fe7c10b409
DEV: fix seed-fu require for rails 6
2019-02-06 17:33:36 +11:00
448ea663c3
DEV: remove seed-fu pinning from rails master
...
This pinning should no longer be needed
2019-02-06 16:54:06 +11:00
635bc72ec5
DEV: pin redis to version 4.0.1
...
Version 4.1.0 returns frozen hashes which conflict with our monkey patch
We will follow up unpinning this later
2019-02-05 09:08:44 +11:00
9f5bbd663d
DEV: update mini_racer and message_bus
...
Two very low risk updates, message_bus has been released no need to depend
on pre-release.
mini_racer update is for a very minor change (shared isolates are not used
in discourse so it is not a fix we technically need)
2019-02-04 17:46:38 +11:00
1d2c4b0eee
DEV: we are waiting on an annotate gem release
...
Once version 2.7.5 is released per: https://github.com/ctran/annotate_models/pull/595
we can drop this conditional.
2019-02-04 16:11:19 +11:00
1816bdf46e
DEV: upgrade mail gem from pre-release
...
2.7.1 version of the mail gem was released! We no longer need to depend on
the pre-release.
2019-02-04 16:10:13 +11:00
377f3efb60
DEV: remove foreman gem and unsupported Procfile
...
Launching Discourse no longer should require foreman in dev. We can simply
use `bin/unicorn` which automatically launches a sidekiq worker.
The foreman gem depends on thor ~> 0.19.1 which is no longer supported in
rails 6. So this pre-emptively prepares us for it.
2019-02-04 15:05:54 +11:00
53c0ad9388
Revert "DEV: Only install danger on Travis."
...
This reverts commit 792dd033e6
2019-01-21 11:31:16 +08:00
792dd033e6
DEV: Only install danger on Travis.
2019-01-21 09:46:32 +08:00
f9648de897
DEV: upgrades from Ember 2.13 to Ember 3.5.1 ( #6808 )
...
Co-Authored-By: Bianca Nenciu <nbianca@users.noreply.github.com>
Co-Authored-By: David Taylor <david@taylorhq.com>
2019-01-10 11:06:01 +01:00
1f0708981f
FIX: Bump onebox version for gfycat aspect ratio fix
2019-01-09 18:00:28 +00:00
286cc72c8b
FIX: Gyfcat onebox should have fixed aspect ratio videos
...
(Fixed upstream in the onebox gem)
2019-01-09 17:15:15 +00:00
fe20cb4b56
FIX: Enforce a fixed height on generic oneboxed videos
...
This prevents 'jumping' as the video loads. This change will require posts to be rebaked before it takes effect.
2019-01-08 16:22:03 +00:00
c76c44bc66
bump onebox version
...
- FEATURE: Add support for Twitter cards.
- FIX: add more https hosts
2019-01-08 09:20:08 +05:30
a8a0f97157
bump onebox version
...
- FEATURE: support YouTube `rel` parameter
2018-12-25 06:36:51 +05:30
7b253dbe4a
FIX: gfycat oneboxing
2018-12-22 11:16:18 +01:00
59cb907f25
Bump onebox version
...
- update Twitter status icons
2018-12-13 06:25:50 +05:30
fcb3f1e219
DEV: upgrade Rails to version 5.2.2
2018-12-10 11:29:28 +11:00
8868cfd2e4
FIX: redis leak when visiting large amounts of topics
...
Message bus uses a key to keep track of the last id for each channel
this key was never expired even if channel data expired
This change ensures we also expire the tracking key, it means a lot to us
cause each topic has a channel, so if you have 1 million topics that is
1 million keys that may persist forever
2018-11-30 14:41:15 +11:00
597f170995
bump onebox version
...
- FIX: show Google video preview on iOS devices
- FIX: convert relative image url to absolute url
2018-11-17 13:45:55 +05:30
cf0acad1e4
bump onebox version (again)
...
- Improve google photos album title
2018-11-09 18:31:25 +05:30
1151c093ad
bump onebox version
...
- Better Google Photos oneboxing
2018-11-09 15:44:06 +05:30
7fe3491bc0
bump onebox version
...
- UX: make title on Instagram less redundant
2018-10-25 12:18:16 +05:30
3d5085c045
Prevent warning when bundling for imports
2018-10-19 16:03:22 +02:00
d20fd66286
bump onebox to 1.8.64
2018-10-16 11:10:11 -04:00
1d26a473e7
FEATURE: Show "Recently used devices" in user preferences ( #6335 )
...
* FEATURE: Added MaxMindDb to resolve IP information.
* FEATURE: Added browser detection based on user agent.
* FEATURE: Added recently used devices in user preferences.
* DEV: Added acceptance test for recently used devices.
* UX: Do not show 'Show more' button if there aren't more tokens.
* DEV: Fix unit tests.
* DEV: Make changes after code review.
* Add more detailed unit tests.
* Improve logging messages.
* Minor coding style fixes.
* DEV: Use DropdownSelectBoxComponent and run Prettier.
* DEV: Fix unit tests.
2018-10-09 22:21:41 +08:00
420e7bccca
bump onebox version (take 2)
...
- better detection of zero dollar amazon price
2018-10-03 17:54:56 +05:30
b56d0026b9
bump onebox version
...
- do not display zero dollar price on Amazon onebox
- fix google play store onebox
2018-10-03 17:05:51 +05:30
80229668f9
bump onebox version
...
- FIX: user correct steam placeholder image url
- catch up Ruby 2.6
2018-09-19 10:06:43 +05:30
0d8c72d8c4
DEV: Add rake task to check locale files for errors
2018-09-05 00:47:39 +02:00
8ce8edaf40
bump onebox version
2018-08-31 15:10:11 +05:30
6b9aeeea73
bump onebox version
2018-08-31 08:40:36 +05:30
2872b100dc
bump onebox version
2018-08-29 16:55:06 +05:30
6acba44ed9
Revert "Install `mailcatcher` in development."
...
This reverts commit 914ce34e5b
2018-08-21 15:40:50 +08:00
914ce34e5b
Install `mailcatcher` in development.
2018-08-21 15:28:02 +08:00
b829452c75
Merge pull request #6209 from discourse/mini_scheduler
...
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
a115aae45f
Use rchardet instead of charlock_holmes gem
2018-08-01 10:41:20 +02:00
ff942ed2f3
FIX: Try detecting encoding of RSS feed
2018-08-01 10:41:20 +02:00
4ad7ce70ce
REFACTOR: extract scheduler to the mini_scheduler gem
2018-07-31 17:12:55 -04:00
458d9cd17a
bump onebox version
2018-07-31 22:52:03 +05:30
b4a2f3fe2f
DEV: implementing danger for travis
2018-07-24 10:12:15 -04:00
22dad7f0e8
bump onebox version
2018-07-17 13:55:00 +05:30
39299fdd8c
bump onebox version
2018-07-16 11:43:32 +05:30
2a5a57a87e
bump onebox version
2018-07-12 21:29:34 +05:30
72a3457379
Bump `discourse_image_optim` which uses a global timeout.
...
Our previous solution has the timeout set at the worker level
which means the total timeout would be X timeout secs * N number of
workers.
2018-07-09 10:30:18 +08:00
3d2f3ef8ae
Update discourse_image_optim gem.
2018-07-03 15:22:54 +08:00
55a963252d
bump onebox version
2018-07-02 10:36:26 +05:30
ebd2be9e02
DEV: lower highline requirement
2018-06-27 22:50:00 +02:00
2f5b7beace
bump onebox version
2018-06-25 11:22:06 +05:30
a171464a55
bump onebox version
2018-06-20 16:47:55 +05:30
bb959e85e6
Pin exifr to 1.2.5.
2018-06-20 17:27:46 +08:00
ccb57e609f
bump onebox version
2018-06-20 11:06:56 +05:30
5f64fd0a21
DEV: remove exec_sql and replace with mini_sql
...
Introduce new patterns for direct sql that are safe and fast.
MiniSql is not prone to memory bloat that can happen with direct PG usage.
It also has an extremely fast materializer and very a convenient API
- DB.exec(sql, *params) => runs sql returns row count
- DB.query(sql, *params) => runs sql returns usable objects (not a hash)
- DB.query_hash(sql, *params) => runs sql returns an array of hashes
- DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array
- DB.build(sql) => returns a sql builder
See more at: https://github.com/discourse/mini_sql
2018-06-19 16:13:36 +10:00
f4fdcda502
Upgrade to Rails 5.2 take 2.
2018-06-08 09:33:50 +08:00
1834417e2f
downgrade rails properly
2018-06-07 20:38:22 +10:00
d3b8ee761c
revert to rails 5.1 for now
2018-06-07 19:47:53 +10:00
89ad2b5900
DEV: Rails 5.2 upgrade and global gem upgrade
...
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated
Performance testing shows that performance has not regressed
if anything it is marginally faster now.
2018-06-07 14:21:33 +10:00
685083491e
FEATURE: StackOverflow importer
2018-06-04 16:57:12 +02:00
2bafd2a355
Don't pin version of `Fabrication` gem.
2018-05-28 15:09:02 +08:00
1c61117cbc
bump onebox version
2018-05-23 17:44:01 +05:30
8238097d0f
bump email_reply_trimmer
2018-05-17 10:22:53 +02:00
5993a3ae3a
Don't pin version for the webpush gem.
2018-05-07 15:45:20 +08:00
91b31860a1
Feature: Push notifications for Android ( #5792 )
...
* Feature: Push notifications for Android
Notification config for desktop and mobile are merged.
Desktop notifications stay as they are for desktop views.
If mobile mode, push notifications are enabled.
Added push notification subscriptions in their own table, rather than through
custom fields.
Notification banner prompts appear for both mobile and desktop when enabled.
2018-05-04 15:31:48 -07:00
c718c59b5d
bump onebox version
2018-05-03 16:14:16 +05:30
ddb092f397
FIX: update mail gem to fix UTF-8 parsing issue
2018-04-25 21:53:37 +02:00
256545ca2c
bump onebox version
2018-04-23 15:18:19 +05:30
54d153068a
DEV: remove qunit rails fork and add a couple of async tests
2018-04-23 16:42:40 +10:00
689144b2bf
Upgrade Mail gem.
2018-04-04 18:35:40 +08:00
2c1ede6e5f
update email_reply_trimmer
2018-03-28 13:12:50 +02:00
3a62eba299
bump onebox version
2018-03-22 11:38:01 +05:30
3e32ab1523
UX: css for Instagram onebox
2018-03-19 13:32:36 +05:30
8027096c09
Partially revert "Upgrade mail gem to remove dependency on mime-types."
...
Still seeing heap_live_count spikes.
This reverts commit 58b8ea4f41
2018-03-14 20:21:45 +08:00
58b8ea4f41
Upgrade mail gem to remove dependency on mime-types.
...
* Use a EmailValidator.email_regexp for `Email.is_valid?`
check as we're seeing an increase in allocation when
parsing email addresses wih `Mail::Address`.
2018-03-14 14:37:55 +08:00
39e679d3cb
FEATURE: allow themes to live in private git repos
...
This feature allows themes sourced from git to live on private
servers, it automatically generates key pairs.
2018-03-09 16:14:38 +11:00
ae9b1e8554
FEATURE: IP.Board 3 importer
2018-03-01 09:43:32 +01:00
56bacb1c2f
Bump onebox
2018-02-27 12:07:16 +01:00
c234a14f0d
Make bootsnap MRI only for now
2018-02-26 10:29:25 +11:00
b301c9f6c1
more prep work for jRuby
2018-02-26 10:25:58 +11:00
79e0cd7f52
update onebox
2018-02-26 10:15:14 +11:00
f4f8a293e7
FEATURE: Implement 2factor login TOTP
...
implemented review items.
Blocking previous codes - valid 2-factor auth tokens can only be authenticated once/30 seconds.
I played with updating the “last used” any time the token was attempted but that seemed to be overkill, and frustrating as to why a token would fail.
Translatable texts.
Move second factor logic to a helper class.
Move second factor specific controller endpoints to its own controller.
Move serialization logic for 2-factor details in admin user views.
Add a login ember component for de-duplication
Fix up code formatting
Change verbiage of google authenticator
add controller tests:
second factor controller tests
change email tests
change password tests
admin login tests
add qunit tests - password reset, preferences
fix: check for 2factor on change email controller
fix: email controller - only show second factor errors on attempt
fix: check against 'true' to enable second factor.
Add modal for explaining what 2fa with links to Google Authenticator/FreeOTP
add two factor to email signin link
rate limit if second factor token present
add rate limiter test for second factor attempts
2018-02-21 09:04:07 +08:00
80ec6ce4fd
bump onebox
2018-02-21 10:06:17 +11:00
9bb7c3dcf0
bump onebox version
2018-02-16 21:32:25 +05:30
e456ae1b6c
Revert "Upgrade mail gem to drop dependency on `mime-types`."
...
This reverts commit 498cc15aa9
2018-02-16 07:04:22 +11:00
498cc15aa9
Upgrade mail gem to drop dependency on `mime-types`.
...
Boot Memory Usage
```
Total allocated: 225695379 bytes (1990663 objects)
Total retained: 32795116 bytes (291607 objects)
```
```
Total allocated: 218342892 bytes (1897350 objects)
Total retained: 30123426 bytes (261198 objects)
```
2018-02-15 16:24:26 +08:00
94b2c70c0d
PERF: remove oga gem
...
oga gem is automatically required by the aws gem
the oga gem retains about 1mb of memory, aws now uses nokogiri
This also removes the html normalize from the pretty text specs that was
a fair bit buggy as the polls test shows.
2018-02-15 14:36:40 +11:00
c3606fdef6
Update onebox
2018-02-14 17:43:13 -02:00
508a8e29ab
update email_reply_trimmer to latest version
2018-02-06 01:04:45 +01:00
b2b85dc694
Lock down gem versions so bundle update can be run ( #5531 )
2018-01-29 18:13:39 +11:00
5d7a33cd6d
Update email_reply_trimmer to improve performance
2018-01-17 12:04:56 +01:00
a0f0ed576a
bump onebox version
2018-01-11 23:15:25 +05:30
afb18a5c41
bump onebox version
2018-01-11 14:30:35 +05:30
e3f8182125
FIX: Google Calendar oneboxes weren't working
2018-01-07 19:15:11 +01:00
05ec1be101
Drop the fork usage of fastimage ( #5461 )
...
Fork is not needed anymore since fastimage 2.1.1 has been released with the needed PR merged in.
2018-01-04 09:53:53 +01:00
030a0cd698
bump onebox for vimeo private link support
2017-12-29 09:38:25 +11:00
b74e933cfb
bump onebox version
2017-12-23 01:17:30 +05:30
16076f9ab8
bump onebox version
2017-12-21 14:49:59 +05:30
f9990eeb13
bump onebox version
2017-12-07 12:05:19 +05:30
5f318a5241
FEATURE: Replace SimpleRSS with Ruby RSS module ( #5311 )
...
* SPEC: PollFeedJob parsing atom feed
* add FeedItemAccessor
It is to provide a consistent interface to access a feed item's tag
content.
* add FeedElementInstaller
to install non-standard and non-namespaced feed elements
* FEATURE: replace SimpleRSS with Ruby RSS module
* get FinalDestination and download with Excon
* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
7bbf137238
bump onebox version
2017-12-05 07:28:45 +05:30
8491c5fba5
UX: Replace heuristic solution for extracting root domain.
2017-11-29 16:26:46 +08:00
64cdb4f7e8
bump onebox version
2017-11-27 12:21:47 +05:30
c8157f6b07
Update seed-fu with PG10 support.
...
https://meta.discourse.org/t/discourse-appears-to-be-broken-with-postgres-10/71723
2017-11-27 10:26:59 +08:00
abbb2b28eb
bump onebox version
2017-11-25 15:53:18 +05:30
961a09ff14
bump onebox version
2017-11-23 17:45:08 +05:30
211dac6f71
bump onebox version
2017-11-22 14:55:47 +05:30
b8c9975429
bump onebox version
2017-11-21 11:10:44 +05:30
89d9ffa884
EXPERIMENTAL: Allow logs to be shipped via different methods.
...
See https://github.com/dwbutler/logstash-logger#uri-configuration for
a list of available methods.
2017-11-15 09:11:33 +08:00
86e6732f78
FEATURE: update rails multisite
...
always allow /srv/status through even if host does not match
2017-11-09 15:40:56 +11:00
fc7dca58fe
UX: oneboxes with avatars now display consistently
...
Onebox avatar size is reduced to 60px
Also fixes regression with some oneboxes not cooking after post
2017-11-08 11:50:01 +11:00
Arpit Jalan
Guo Xiang Tan
David Taylor
Joffrey JAFFEUX
Sam Saffron
romanrizzi
Maja Komel
Daniel Waterworth
Nicolas Sebastian Vidal
Gerhard Schlager
Vinoth Kannan
Régis Hanol
Penar Musaraj
Bianca Nenciu
Neil Lalonde
Jeff Wong
Rafael dos Santos Silva
Ori Pekelman
Jano Suchal
Kyle Zhao