f7c57fbc19
DEV: Enable `unless` cops
...
We discussed the use of `unless` internally and decided to enforce
available rules from rubocop to restrict its most problematic uses.
2023-02-21 10:30:48 +01:00
63fdb6dd65
FIX: Do not add empty use/svg tags in ExcerptParser ( #19969 )
...
There was an issue where if hashtag-cooked HTML was sent
to the ExcerptParser without the keep_svg option, we would
end up with empty </use> and </svg> tags on the parts of the
excerpt where the hashtag was, in this case when a post
push notification was sent.
Fixed this, and also added a way to only display a plaintext
version of the hashtag for cases like this via PrettyText#excerpt.
2023-01-24 14:40:24 +10:00
6417173082
DEV: Apply syntax_tree formatting to `lib/*`
2023-01-09 12:10:19 +00:00
d516c575fd
FIX: Handle null svg class for excerpt parsing ( #19276 )
...
Follow-up to 9d50790530
2022-12-01 10:56:16 +10:00
9d50790530
FIX: Allow svg in oneboxer in certain cases ( #19253 )
...
When doing local oneboxes we sometimes want to allow
SVGs in the final preview HTML. The main case currently
is for the new cooked hashtags, which include an SVG
icon.
SVGs will be included in local oneboxes via `ExcerptParser` _only_
if they have the d-icon class, and if the caller for `post.excerpt`
specifies the `keep_svg: true` option.
2022-11-30 12:42:15 +10:00
bbcd70e8b5
DEV: Remove dead code
...
There's no such thing as `@in_spoiler` anymore.
2021-05-31 10:22:50 +08:00
c62efc0f0f
FIX: Ignore max excerpt length for div excerpts too ( #13058 )
...
We support two types of custom excerpts. It can be <div class="excerpt"> or <span class="excerpt">: b21f74060e/lib/excerpt_parser.rb (L120)
2021-05-24 13:05:24 +04:00
efaa63bd1d
FIX: always truncate uncomplete emojis in excerpts ( #11678 )
...
Additional fix after https://github.com/discourse/discourse/pull/11667
Always truncate "broken" emojis from excerpts.
2021-01-11 13:43:11 +11:00
7f78b6ec10
FIX: broken emojis in topic excerpt ( #11667 )
...
When a post is truncated into the excerpt, sometimes we are breaking code of emoji
2021-01-11 10:40:41 +11:00
5ff24b6891
FIX: do not raise error if 'class' attribute is not found.
2020-05-01 10:03:40 +05:30
9207c370d9
FIX: Spoiler logic should live inside of spoiler plugin
...
This commit removes logic about spoilers because it should live inside
of the discourse-spoiler-alert plugin.
This PR:
https://github.com/discourse/discourse-spoiler-alert/pull/38
also completely removes spoilers from excerpts in order to keep them
from leaking in topic previews and notifications.
2020-02-06 07:46:46 -07:00
79f5d24571
FIX: Do not error in excerpts when aside tag has no class attribute
2020-01-20 16:09:23 -05:00
9a6606dd30
DEV: Add option to keep quoted content in post excerpt.
2020-01-04 18:56:52 +05:30
2cb805a683
DEV: Add option to keep onebox body content in post excerpt.
2019-11-02 17:14:04 +05:30
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
24fd710f04
Revert "FIX: strip spoilers in notification excerpts"
...
This reverts commit 55942224ed
2019-04-15 10:15:17 -04:00
55942224ed
FIX: strip spoilers in notification excerpts
2019-04-12 12:00:49 -04:00
d243b82fb3
FIX: Calculation of text length for <details> in excerpt was wrong
2018-03-12 16:55:23 +01:00
cbb321658f
FIX: support for generating excerpt when nesting <details> blocks
2018-01-22 19:17:35 +01:00
21e1b05c7e
FIX: Don't disable details when below truncate limit
2017-12-20 15:45:00 -05:00
b3fda0ea86
FIX: details tags broke excerpts
2017-12-19 17:28:55 -05:00
44ee388070
FEATURE: omit images from og and twitter description tags
2017-11-28 21:34:02 +01:00
a83bd537f4
FIX: exception in excerpt parser for null nodes
2017-08-17 16:13:30 -04:00
506572bf04
FIX: display emojis (set, custom and native) in bio excerpt
2017-08-15 10:05:09 +02:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
3861bd2793
FIX: Quotes should be ignored when parsing for onebox source.
2017-04-11 15:22:21 +08:00
0a4c30bce3
FIX: Handle cases where `alt` and `title` tag is blank when parsing excerpt.
2017-04-11 14:18:27 +08:00
e49f3a408e
FEATURE: Add option for `ExcerptParser` to keep onebox source.
2017-04-10 16:11:58 +08:00
89daa43754
FEATURE: remap emojis back for push notifications and desktop alerts
2016-10-11 13:03:48 +11:00
e01dc54f2a
UX: we should always simply use emoji codes as opposed to treating as image
2016-06-02 12:29:25 +10:00
a362ad9407
FIX: Emoji in Discourse onebox is wrapped in square brackets.
2016-01-13 19:00:11 +08:00
7c1e16da54
FEATURE: Display emojis in user stream.
2015-07-23 23:50:01 +08:00
8013b6a511
FIX: clean html before sending it to jquery for collapsing
2015-05-20 14:42:54 +10:00
22d580fe76
allow to translate image's exceprt
2015-01-23 17:58:14 +08:00
6027073547
FIX: properly unescape HTML entities in excerpts
2014-12-10 12:52:51 +01:00
dba1616762
FIX: blank page on user page in rare cases
2014-10-07 11:43:17 +11:00
d567093756
FEATURE: Allow manual excerpt to be specified anywhere in the post and override max excerpt length
2014-09-03 22:06:53 -07:00
0513d02e23
FEATURE: Allow manual excerpt to be defined past the beginning of the post
...
There is still a limitation that the span excerpt must begin before the post_excerpt_max_length.
2014-09-03 00:29:49 -07:00
6e9f5f5584
SECURITY: fix XSS in excerpt parser
2014-07-25 12:16:00 +10:00
de7e6a9545
Feature: allow mods to cut pinned topic excerpts
2014-07-17 21:32:37 +10:00
e781a758ad
Preserve spoiler tags in post excerpts.
2014-02-20 15:01:44 +05:30
6384518599
Allow images in the daily digest for top scoring posts
2013-06-05 18:55:27 -04:00
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
4392a17b54
Strip out links when displaying a new user's bio
2013-06-04 12:06:25 -04:00
88972b99a5
refactor
2013-05-28 09:48:47 +10:00
Loïc Guitaut
Martin Brennan
David Taylor
Jarek Radosz
Andrei Prigorshnev
Krzysztof Kotlarek
Vinoth Kannan
Blake Erickson
Penar Musaraj
Vinoth Kannan
Sam Saffron
Gerhard Schlager
Régis Hanol
Robin Ward
Joffrey JAFFEUX
Guo Xiang Tan
Guo Xiang Tan
Erick Guan
David McClure
Vikhyat Korrapati