Jeff Wong
9de906ddab
FIX: Register pan events for touch only
...
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
2019-02-04 08:27:40 -08:00
Bianca Nenciu
e0e91fad87
FIX: Fix delete button for Tag Groups. ( #6965 )
2019-02-04 12:46:39 +01:00
Kris
2a2be093ca
UX: checkboxes were too close to other inputs
2019-02-01 21:07:57 -05:00
Robin Ward
e75b240390
FIX: Some brittle tests with hardcoded ids
...
If we're going to use hardcoded ids, we should make sure the records are
not saved, or that the ID will not come up during normal use.
2019-02-01 11:44:37 -05:00
Kris
37c28cf0b7
UX: Header icon color fix
2019-02-01 09:51:12 -05:00
David Taylor
eb617dea4b
DEV: Run prettier on `report.js.es6`
...
The prettier version I was running was different to the CI pipeline
2019-02-01 13:22:31 +00:00
David Taylor
5c9426be48
SECURITY: Escape HTML in dashboard report tables
2019-02-01 13:10:59 +00:00
David Taylor
925606f8b1
FIX: Login button icons should be white
2019-02-01 11:01:59 +00:00
Vinoth Kannan
b4f713ca52
FEATURE: Use amazon s3 inventory to manage upload stats ( #6867 )
2019-02-01 10:10:48 +05:30
Kris
bbaa3e9166
Header icon focus color fix
2019-01-31 19:31:09 -05:00
Kris
95e16ab0a6
UX: Badge checkmarks should be round
2019-01-31 15:27:46 -05:00
Kris
6141290399
FIX: Mobile button colors
2019-01-31 15:13:54 -05:00
Gerhard Schlager
ec7f418a22
REFACTOR: Simplify finding the opengraph image
...
* removes deprecation warnings for "logo url"
* adds the "large icon" as fallback before the "apple touch icon"
2019-01-31 20:46:15 +01:00
Penar Musaraj
3500acf2f6
FIX: refresh admin/customize/themes route after import
...
Fixes an issue where the imported color schemes of a theme were not available immediately in the UI.
2019-01-31 14:29:09 -05:00
Kris
0dfcbdeb54
ok/cancel button fix
2019-01-31 14:20:27 -05:00
Kris
3d394a6144
prettier
2019-01-31 14:06:32 -05:00
Kris
3eb000a968
UX: Overflow hidden was causing some icons to be cropped
2019-01-31 14:03:11 -05:00
Kris
94f16ba931
UX: Make button icons use lighter color instead of opacity
2019-01-31 13:59:49 -05:00
David Taylor
43f3bf71ba
FIX: Imported themes should set their color scheme automatically
2019-01-31 17:45:11 +00:00
Régis Hanol
1021a42b22
FIX: new mailgun webhooks
2019-01-31 17:52:33 +01:00
Arpit Jalan
4786b7ff81
FEATURE: when only option is "existing topic", autofocus input field
2019-01-31 11:23:04 +05:30
Arpit Jalan
f83533e1cb
FIX: use absolute url for `/images/example.png` links
...
FEATURE: fallback to logo_url as last resort for opengraph image url
2019-01-31 10:20:15 +05:30
Jeff Wong
4763d6c9d7
FEATURE: add the show user action to the user-card-after-username plugin outlet
2019-01-30 14:56:14 -08:00
Robin Ward
bb8808985a
REFACTOR: Remove a couple more `self` uses
2019-01-30 14:41:49 -05:00
Robin Ward
dca5486b78
REFACTOR: Prefer `this` over `self`
2019-01-30 14:29:45 -05:00
Penar Musaraj
c02e81fe01
FIX: regression with composer warnings
...
Fixes composer warnings when: a) mentioning groups ("By mentioning @group, you are about to notify x people...") and b) mentioning users in a PM ("You mentioned @user but they won`t be notified...")
2019-01-30 11:37:16 -05:00
David Taylor
d8bd3c32ca
DEV: Allow theme CLI to specify which theme to synchronize ( #6963 )
...
Currently the theme is matched by name, which can be fragile when there are many themes with the same name. This functionality will be used by the next version of theme CLI.
2019-01-30 14:17:04 +00:00
Gerhard Schlager
1e98929501
FIX: Email domain whitelist prevented user anonymizing
...
FIX: Secondary email addresses were not deleted during anonymizing
2019-01-30 15:14:36 +01:00
Vinoth Kannan
096974d178
FIX: user_id attribute not found in posters array
2019-01-30 15:28:03 +05:30
Guo Xiang Tan
60c1cd9f81
FIX: Return 400 when username params is invalid.
2019-01-30 16:06:55 +08:00
Guo Xiang Tan
0e5c7f5da7
DEV: Update annotations.
2019-01-30 09:34:51 +08:00
Guo Xiang Tan
ac004297fa
PERF: Add index on `user_id` to `single_sign_on_records`.
2019-01-30 09:34:19 +08:00
Jeff Wong
fc5b2de85d
FEATURE: add topic list before status plugin outlet for mobile
2019-01-29 17:15:31 -08:00
Robin Ward
6f656f6e7d
FIX: Better error handling if a file cannot be sent
...
If for some reason `Discourse.store.path_for` returns `nil`, the
forum would throw an error rather than returning 404.
Why would it be `nil`? One cause could be changing the type of
file store and having the `url` field no longer be relative.
2019-01-29 16:47:25 -05:00
Joffrey JAFFEUX
0d0303e7ea
FIX: more resilient lookup in plugin-api ( #6961 )
...
Ember3 is more picky about having a container being destroyed and it's easier to cause exceptions, especially in tests.
This fix has been initially created for an exception occuring in tests when running discourse-code-review and discourse-polls tests at the same time. `getCurrentUser` method body was failing as the container was destroyed.
Original stacktrace:
```
"Error: Assertion Failed: expected container not to be destroyed
at new EmberError (ember:2929:31)
at assert (ember:1793:23)
at Container.lookup (ember:17736:64)
at PluginApi.getCurrentUser (discourse/lib/plugin-api:56:31)
at allowUser (javascripts/discourse/initializers/init-code-review:38:29)
at eval (javascripts/discourse/initializers/init-code-review:78:11)
at eval (select-kit/mixins/plugin-api:86:19)
at Array.forEach (<anonymous>)
at eval (select-kit/mixins/plugin-api:85:44)
at Array.forEach (<anonymous>)"
```
2019-01-29 16:54:04 +01:00
Sam Saffron
32f9fd1e51
FIX: add autocomplete=off to composer textarea
...
Somehow a plugin or some new Chrome bug is causing its heuristic to detect
our textarea for the composer as a target for address autocomplete
This is likely a chrome bug but this change is very safe regardless.
2019-01-29 15:05:29 +02:00
Kris
f7deb52c90
FIX: Class name for external-link on customize page
2019-01-28 17:15:36 -05:00
Vinoth Kannan
62a0f88e97
FIX: More link in topic page search shouldn't navigate to full page result
2019-01-29 02:26:55 +05:30
Vinoth Kannan
3d52f690b3
UX: Add post action text in non-JS topic view
2019-01-28 22:51:06 +05:30
David Taylor
fb5c94246c
DEV: Remove underscore from `learn_more` key in theme export
...
Follow up from 033cd4f3
2019-01-28 16:00:33 +00:00
David Taylor
0d0ca4f070
DEV: Automatically remove placeholder 'URL' metadata values from themes
2019-01-28 11:55:58 +00:00
David Taylor
77d26b9df6
FIX: Support application/gzip theme imports, and improve error message
2019-01-28 11:51:14 +00:00
David Taylor
033cd4f31d
DEV: Include "_learn_more" key in theme `about.json`
...
This does not serve any technical purpose. It is there to provide a signpost for any user/developer that wants to know what to do with a theme archive.
2019-01-28 11:34:11 +00:00
David Taylor
aca0b32fda
FEATURE: Allow overriding text size from a different device ( #6955 )
...
This brings the feature in line with the theme selection system
2019-01-28 11:19:50 +00:00
Vinoth Kannan
7e4edcfae8
FIX: Convert lightbox html into proper image markdown
2019-01-27 01:21:56 +05:30
Neil Lalonde
cd3a167c63
FIX: javascript error when opening rename tag modal
2019-01-25 17:34:05 -05:00
Kris
94e2b77c5f
Fix theme component name's color when theme is selected
2019-01-25 17:25:12 -05:00
Penar Musaraj
84a3da4b18
FIX: match drafts using key when deleting
...
Using "sequence" when removing drafts was buggy, it would remove more than one draft from the stream sometimes.
2019-01-25 13:55:40 -05:00
Joffrey JAFFEUX
0e1862013a
FIX: prevents race condition where the same report is loaded multiple times ( #6953 )
2019-01-25 19:29:45 +01:00
David Taylor
2e48c43546
FIX: Fix safe mode regression
...
Follow up from a48731e
2019-01-25 17:00:30 +00:00
Robin Ward
78ddc82952
FIX: Respect min_flags_staff_visibility for new flags too
...
There was a situation where if:
* There were new flags to review that met the visibility threshold
AND
* There were old flags that *didn't* meet the threshold
THEN
a pending flags notification would be sent out. This fixes that case.
Staff should not be notified of flags if they do not meet the threshold
and are old.
2019-01-25 11:27:43 -05:00
Joffrey JAFFEUX
7caa28cf45
FIX: ensures ordering set in tags-show queryString works at first load ( #6951 )
2019-01-25 16:48:20 +01:00
David Taylor
d338e54f59
FEATURE: Allow setting font size per-device using a cookie ( #6947 )
2019-01-25 15:06:06 +00:00
Vinoth Kannan
65caf04ddc
clean up unused code
...
Unused PM topic list column 'Users' is removed
2019-01-25 20:13:54 +05:30
David Taylor
a48731e359
FEATURE: Support additional metadata in theme about.json ( #6944 )
...
New `about.json` fields (all optional):
- `authors`: An arbitrary string describing the theme authors
- `theme_version`: An arbitrary string describing the theme version
- `minimum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
- `maximum_discourse_version`: Theme will be auto-disabled for lower versions. Must be a valid version descriptor.
A localized description for a theme can be provided in the language files under the `theme_metadata.description` key
The admin UI has been re-arranged to display this new information, and give more prominence to the remote theme options.
2019-01-25 14:19:01 +00:00
Vinoth Kannan
2d6aa2aea2
FEATURE: Add recipient avatars in PM topic list even if they not yet replied
2019-01-25 19:41:49 +05:30
Joffrey JAFFEUX
f461a9971f
FIX: makes staff_logins show only admins ( #6948 )
2019-01-25 11:28:52 +01:00
Blake Erickson
de47b35b2d
FIX: user_id handling on remove user from group
...
Under some conditions it was possible to pass in a user_id as an
integer, but we would try and parse it as a comma delimited string
resulting in an error. This has been fixed so that we are no longer
mapping the user_id param to user_ids.
2019-01-24 17:40:48 -07:00
Kris
868528f862
Slight shadow adjustment to hide overflow
2019-01-24 14:49:39 -05:00
Robin Ward
96b2585a91
REFACTOR: Remove unncessary stubs from pending flags reminder
...
They seem to be calculated fine by the application, and stubbing
makes the tests more brittle and prone to regression.
2019-01-24 13:45:58 -05:00
Robin Ward
a518950e52
FIX: Use context sensitive "create topic" via keyboard if possible
2019-01-24 13:20:33 -05:00
Kris
8e795d82f9
UX: Bump up notification panel width to accommodate larger text
2019-01-24 12:48:48 -05:00
Penar Musaraj
755b47b4bc
UX: change topic reminder notification icon
2019-01-24 10:07:24 -05:00
Joffrey JAFFEUX
e5765fe1f5
FIX: ensures correct scroll position of textarea after autocomplete ( #6942 )
2019-01-24 15:19:19 +01:00
Joffrey JAFFEUX
49193ca3bf
FIX: includes staff in staff_logins report ( #6945 )
2019-01-24 14:46:56 +01:00
Vinoth Kannan
c88fd49591
DEV: refactor user preferences path method
2019-01-24 18:39:13 +05:30
Vinoth Kannan
b9bf751b88
FIX: link to the user preferences page is incorrect in user admin page
2019-01-24 18:31:00 +05:30
Joe
dda918f862
UX: removes width constraint in user-card badge section
2019-01-24 20:53:14 +08:00
Angus McLeod
b1297a5f5a
FIX: replaces inline button message with d-button
2019-01-24 13:19:52 +01:00
Joffrey JAFFEUX
1f8ff85ff9
FIX: displays user-card when clicking on avatar of post small action ( #6941 )
2019-01-24 10:46:06 +01:00
Joe
22f43abb0e
UX: protection for very wide category-logo images on narrow screens
2019-01-24 17:16:18 +08:00
Kris
12df8c5c82
General style cleanup, removing unused styles
2019-01-23 21:37:39 -05:00
Kris
7d92fa3a5e
Mobile SCSS cleanup and removing unused styles
2019-01-23 14:36:53 -05:00
Daniel
48c9234545
FIX: Lazy Loading: copy only present srcset
...
When showing a lazy-loaded image, copy the `srcset` property only when
it is actually set. `copyImg.srcset = copyImg.srcset` is not actually a
noop but creates an empty `srcset`, changing content security rules on
the image.
2019-01-23 14:04:43 -05:00
Joe
a9734eef81
UX: removes margins from categories in suggested topics message
2019-01-24 02:12:16 +08:00
Joffrey JAFFEUX
bd31423137
DEV: refactoring admin-logs-screened-ip-addresses ( #6932 )
2019-01-23 17:40:37 +01:00
Joffrey JAFFEUX
0aa049791e
DEV: refactoring admin-backups-index ( #6933 )
2019-01-23 17:40:24 +01:00
Joffrey JAFFEUX
60974932c4
DEV: refactoring api-keys ( #6931 )
2019-01-23 17:40:05 +01:00
Kris
9a594fed01
Removing unused bootstrap.scss file
2019-01-23 11:22:23 -05:00
Kris
5feeac221e
Groups on user profile missing margin
2019-01-23 10:10:17 -05:00
Joffrey JAFFEUX
096a81158a
FIX: siteNavigationElement was reversed ( #6934 )
2019-01-23 15:47:39 +01:00
David Taylor
afd449089f
FEATURE: Import and export themes in a .tar.gz format ( #6916 )
2019-01-23 14:40:21 +00:00
Joffrey JAFFEUX
d0129b85f4
FIX: stop propagating keyboard event when replying to topic/post ( #6930 )
2019-01-23 14:38:20 +01:00
Joe
d720215183
UX: admin badge page improvements
2019-01-23 11:29:51 +01:00
David Taylor
2e59a37687
FEATURE: List unused theme components ( #6924 )
2019-01-23 09:20:13 +00:00
Joe
b21266ed6f
FIX: corrects selector for move-to modal styles
2019-01-23 16:18:38 +08:00
Vinoth Kannan
70b56c8332
FIX: 'anon' css class is missing for anonymous users
2019-01-23 10:13:36 +05:30
Penar Musaraj
9886934ef5
DEV: fix some deprecated SVG icon refs
2019-01-22 14:42:00 -05:00
Kris
62adc2eb98
User admin page button height fix
2019-01-22 14:00:38 -05:00
Kris
66f6382090
FIX: Icon missing due to typo
2019-01-22 13:01:21 -05:00
Kris
f0fd875918
UX: Improving aligment within topic timer modal
2019-01-22 12:33:46 -05:00
Robin Ward
a834245683
FIX: Keep tags when switching to shared draft
2019-01-22 11:26:52 -05:00
Robin Ward
f32de88dfc
FIX: Don't notify of pending flags if min_flags_staff_visibility not met
2019-01-22 11:01:18 -05:00
Joffrey JAFFEUX
fc710de3ab
DEV: refactoring admin user index ( #6927 )
2019-01-22 16:44:55 +01:00
Joffrey JAFFEUX
31a700daf8
DEV: refactoring emoji-uploader ( #6926 )
2019-01-22 16:44:40 +01:00
Joffrey JAFFEUX
bce9c37f15
DEV: refactoring permalink-form ( #6925 )
2019-01-22 15:09:21 +01:00
Joffrey JAFFEUX
ea8373351b
DEV: refactoring ip-lookup ( #6923 )
2019-01-22 15:09:04 +01:00
Joffrey JAFFEUX
80d42b4ea2
icons deprecations fixes ( #6920 )
2019-01-22 12:02:02 +01:00
Joffrey JAFFEUX
ea0e188c8f
FIX: improves stacked-chart layout on ie11 ( #6922 )
2019-01-22 11:47:54 +01:00
Joffrey JAFFEUX
9148f7675b
FIX: better handling of resizing in stacked charts ( #6921 )
2019-01-22 11:20:50 +01:00