5eb65ad612
FIX: Do not try to recover invalid `Upload#short_url` in `UploadRecovery`.
2018-09-13 13:59:17 +08:00
d99dd840e4
Add basic test case for `UploadRecovery`.
2018-09-13 13:26:23 +08:00
a3b3b0810d
Rescue errors when running dry run for `UploadRecovery`.
2018-09-13 11:57:51 +08:00
4dc25ad201
Fix s3 recovery from tombstone in `UploadRecovery`.
2018-09-13 09:19:45 +08:00
9461c99210
DEV: Add travis_fold to termination stage
2018-09-12 18:59:48 +01:00
26bd67a865
DEV: Add travis_fold statements to docker_test
2018-09-12 17:52:58 +01:00
24c55bd613
Add dry run option to `UploadRecovery`.
2018-09-12 21:53:01 +08:00
2cc48cfd06
Fix incorrect variable.
2018-09-12 02:06:14 -07:00
c053f8ccf6
New rake task `uploads:recover`.
2018-09-12 01:52:30 -07:00
6d01e0aa04
DEV: Print the error class in `uploads:list_posts_with_broken_images`.
2018-09-12 01:06:51 -07:00
71185c13b5
Merge pull request #6377 from tgxworld/remove_tif_tiff
...
Drop `tif`, `tiff`, `webp` and `bmp` from supported images.
2018-09-12 09:32:32 +08:00
71caf7521d
Drop `tif`, `tiff`, `webp` and `bmp` from supported images.
...
https://meta.discourse.org/t/cr2-raw-files-are-being-treated-as-tiff-files/96775/3?u=tgxworld
2018-09-12 09:29:54 +08:00
e1b16e445e
Rename `FileHelper.is_image?` -> `FileHelper.is_supported_image?`.
2018-09-12 09:22:28 +08:00
d59e635a77
Rename `FileHelper.images` to `FileHelper.supported_images`.
2018-09-12 09:22:28 +08:00
f1cb431968
FIX: rescue ActiveRecord::RecordInvalid in find_or_create_by_safe! ( #6385 )
...
AR uniqueness validation could raise ActiveRecord::RecordInvalid
2018-09-12 11:03:12 +10:00
1a01385e88
FIX: "false" didn't work as locale_default
2018-09-11 13:42:10 +02:00
b3b9ac3b19
Version bump to v2.2.0.beta1
2018-09-10 19:43:15 -04:00
80eace4268
Merge pull request #6383 from discourse/fix_username_suggester
...
FIX: don't raise an error on integer usernames in user_name_suggester
2018-09-11 00:30:29 +05:30
81c87df18a
FIX: don't raise an error on integer usernames
2018-09-10 22:17:56 +05:30
1d41f3c3fb
Merge pull request #6380 from discourse/rake-destroy-sub-category
...
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 10:26:04 -06:00
94ff428571
Pass the right value to rake task.
2018-09-10 20:07:28 +08:00
84fc7abb73
FIX: Allow `rake destroy:topics` to delete topics in sub-categories
2018-09-10 12:52:14 +01:00
4a966c639d
DEV: Update `uploads:list_posts_with_broken_images` to recover from tombstone.
2018-09-10 17:01:41 +08:00
df04e69cde
FIX: `S3Helper#list` creates incorrect prefix.
2018-09-10 16:34:40 +08:00
68572b8afc
Print error messages on why upload fails to save.
2018-09-10 16:02:13 +08:00
0aca80e92a
Fixes to `uploads:list_posts_with_broken_images`.
2018-09-10 15:16:29 +08:00
8496537590
Add `RECOVER_FROM_S3` to `uploads:list_posts_with_broken_images` rake task.
2018-09-10 15:14:30 +08:00
afaa722c32
sort official plugin list, remove duplicate entry
...
`discourse-sitemap` was listed twice, sorted list to help avoid duplication
2018-09-09 13:41:26 -04:00
879067d000
FIX: check admin theme cookie against user selectable
...
previously admin got a free pass and could set theme via cookie to anything
including themes that are not selectable
this refactor ensures that only "preview" gets a free pass, all the rest
goes through the same pipeline
2018-09-07 10:47:28 +10:00
3dea48f1d9
Resetting miniracer context results in segfault
2018-09-07 00:19:23 +02:00
f13c34aaed
Adds a check for invalid message formats to rake i18n:check
2018-09-06 17:27:17 +02:00
3c09026fe4
Minor improvements to rake i18n:check
2018-09-06 16:54:30 +02:00
d4b05d7bc5
Always link post to uploads in post process.
...
The operation is cheap anyway so no point skipping.
2018-09-06 14:08:03 +08:00
434035f167
FIX: Link post to uploads in `PostCreator`.
...
* This ensures that uploads are linked to their post on creation
instead of a background job which may be delayed if Sidekiq
is facing difficulties.
2018-09-06 11:18:11 +08:00
26082688d1
FIX: Zero is a valid value for the page parameter
2018-09-05 20:43:05 +02:00
f3aef2cc83
FIX: Incorrect/missing extension in short_url fails to map to upload.
...
`Hash#invert` causes us to lose keys if the hash contains similar
values.
2018-09-05 21:48:58 +08:00
72834f19ff
DEV: Add rake tasks to list posts with broken images.
2018-09-05 16:54:15 +08:00
f4956f79a5
Make Rubocop happy
2018-09-05 01:04:43 +02:00
6658a6601c
Remove unused rake task
2018-09-05 00:47:39 +02:00
0d8c72d8c4
DEV: Add rake task to check locale files for errors
2018-09-05 00:47:39 +02:00
b8fc699164
FIX: Detect {{foo}} as interpolation key
2018-09-05 00:47:39 +02:00
d8b543bb67
FIX: redirect to original URL after social signup
2018-09-05 01:44:23 +05:30
4382fb5fac
DEV: Allow plugins to whitelist specific user custom_fields for editing ( #6358 )
2018-09-04 20:45:36 +10:00
d1af89e3b3
DEV: Extract global admin api rate limiting into a dedicated method.
...
* We have a use case for overriding the rate limiting logic in a
plugin.
2018-09-04 16:37:54 +08:00
3b337bfc6b
Revert "FIX: Don't rate limit admin and staff constraints when matching routes."
...
This reverts commit 651b50b1a1
2018-09-04 14:27:21 +08:00
651b50b1a1
FIX: Don't rate limit admin and staff constraints when matching routes.
...
* When an error is raised when checking route constraints, we
can only return true/false which either lets the request
through or return a 404 error. Therefore, we just skip
rate limiting here and let the controller handle the
rate limiting.
2018-09-04 13:52:58 +08:00
08b268c5bc
Be more forceful in disconnecting connections during failover.
2018-09-04 10:32:43 +08:00
8dc1463ab3
Enable `Lint/ShadowingOuterLocalVariable` for Rubocop.
2018-09-04 10:16:42 +08:00
eeedc3901e
FIX: Replying to deleted post via email should create new reply to topic
2018-09-03 23:06:40 +02:00
24a14af15a
FIX: Respect invalidate_oneboxes option for inline oneboxes
2018-09-03 22:33:43 +05:30
f33433bf9e
Validation of params should restrict to max int ( #6331 )
...
* FIX: Validation of params should restrict to max int
* FIX: Send status 400 when "page" param isn't between 1 and max int
2018-09-03 14:45:32 +10:00
747c9bb47f
Merge pull request #6317 from nbianca/ignore_blacklisted_domains
...
FIX: Ignore OneBox blacklisted domains.
2018-09-03 11:10:52 +08:00
45f092a49d
Extract `badge_posts` view management logic into a service object.
...
* Avoid defininig a global constant and method.
Fixes https://github.com/discourse/discourse/pull/6318
2018-09-03 09:51:35 +08:00
182d9a4666
FIX: escape regex chars when searching site texts
2018-09-02 17:25:57 +10:00
60eff9421a
FIX: precompile `desktop_theme` and `mobile_theme` stylesheets
...
required for environments that pre stage docker images and keep old image running during the deploy
2018-08-31 21:23:55 +10:00
9b7cab589a
FIX: revert diacritic stripping
...
See more details in test case and at: https://meta.discourse.org/t/discourse-should-ignore-if-a-character-is-accented-when-doing-a-search/90198/16?u=sam
2018-08-31 11:46:55 +10:00
297e8aaf2e
FIX: Escape regex pattern variable before using it
2018-08-31 03:02:24 +05:30
4b6381367e
add support for Excon connection options in hub requests
2018-08-30 15:57:11 -04:00
415201e1b4
Version bump to v2.1.0.beta6
2018-08-30 10:53:20 -04:00
2dfb097dd9
DEV: plugin generator support for spec/test/controller/routes ( #6344 )
2018-08-30 16:38:25 +02:00
90e67b671b
DEV: support for settings/locales in plugin generator ( #6341 )
2018-08-30 14:12:06 +02:00
9efbf2c49f
FIX: changing component settings should trigger refresh for parent theme CSS ( #6340 )
2018-08-30 20:53:03 +10:00
d40d241e72
DEV: adds --help --no-help options to plugin generator ( #6338 )
...
help will add helpful comments in the various generated files
2018-08-30 12:16:37 +02:00
acc96abe1a
DEV: plugin generator will now ask for github username ( #6337 )
2018-08-30 12:03:30 +02:00
492b6dc306
DEV: `yarn exec` doesn't do what I think it does.
2018-08-30 15:55:36 +08:00
e6970151a6
FEATURE: allow specifying locale via SSO
...
Use:
locale
locale_force_update
To force user locale on users where SiteSetting.allow_user_locale is enabled
Note: If an invalid locale is specified no action will occur
2018-08-30 09:58:03 +10:00
06f18b0e9f
typo
2018-08-29 13:51:16 +02:00
ef36fdfb64
DEV: rails generator to create plugin skeleton ( #6332 )
...
rails g plugin --help
rails g plugin DiscourseRacoon --author joffrey
2018-08-29 13:32:41 +02:00
5f51ef27e7
Added sitemap plugin in the official list
2018-08-29 10:58:26 +02:00
720726ea68
Use `yarn exec` when running eslint and prettier.
2018-08-29 11:03:42 +08:00
44cf3cf975
FIX: queue heartbeats in readonly modes
...
If sidekiq is paused or Discourse is in readonly continue to queue
heartbeats
If we do not do that then a master process can end up reaping sidekiq
workers and causing various badness
This also impacts restore which can do weird stuff TM in cases like this
2018-08-29 12:36:59 +10:00
9ab1fb7dfc
FEATURE: correctly store width and height on uploads
...
Previously we used width and height for thumbnails, new code ensures
1. We auto correct width and height
2. We added extra columns for thumbnail_width and height, this is determined
by actual upload and no longer passed in as a side effect
3. Optimized Image now stores filesize which can be used for analysis, decisions
Also
- fixes Android image manifest as a side effect
- fixes issue where a thumbnail generated that is smaller than the upload is no longer used
2018-08-28 12:59:22 +10:00
ebe7835316
FIX: links in rss feeds are sometimes wrong on subfolder installs
2018-08-27 18:05:15 -04:00
b6963b8ffb
FIX: Ignore OneBox blacklisted domains.
2018-08-27 20:40:55 +02:00
4205c528d0
FEATURE: hide enable_personal_email_messages and min_trust_to_send_email_messages
...
These site settings are very hard to explain and only applicable for very
specific Discourse setups.
If an admin "enables staged users" which is used in support scenarios then
all staff can send "messages" directly to an "email".
The setting allows you to extend this to TL4 or any trust level.
Actual use case would be a support type setup with restricted staff. It is
quite rare so hiding this for now and re-evaluate keeping the setting in
2019
2018-08-27 11:38:22 +10:00
020eba4623
FIX: find tags with non-latin names ( #6312 )
2018-08-27 11:05:28 +10:00
47e6b8b318
discourse etiquette is an official plugin
2018-08-27 10:03:49 +10:00
ac11f8df52
correct regression searching with diacritics
2018-08-24 10:00:51 +10:00
6588a45880
Make Rubocop happy
2018-08-23 15:09:20 +02:00
409ee66839
Add optional "ignore_case" parameter to posts:remap rake task
2018-08-23 14:49:17 +02:00
7a91df3248
Merge pull request #6290 from techAPJ/latest-full-name
...
UX: show full name on /latest page
2018-08-23 17:34:54 +05:30
1a7cd6648b
UX: show full name on /latest page
2018-08-23 14:41:06 +05:30
dd810b8b05
Merge pull request #6304 from tgxworld/create_functions_in_different_schema
...
FIX: Create `BaseDropper` functions in a different schema.
2018-08-23 15:01:41 +08:00
6ee352510a
Correctly handle exception
2018-08-23 16:27:00 +10:00
cbd9045c6b
FIX: avoid race condition creating posts
...
in some cases the distributed mutex was not protecting us
and transactions would fail
2018-08-23 15:11:06 +10:00
212ee15804
FIX: Create `BaseDropper` functions in a different schema.
...
https://meta.discourse.org/t/error-when-restore-db-backup/93145/25?u=tgxworld
2018-08-23 12:52:21 +08:00
2711f173dc
FIX: don't allow inviting more than `max_allowed_message_recipients`
...
* FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows
* add specs for guardian
* user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit)
Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences
* groups take only 1 slot in PM
* just return if topic is a PM
2018-08-23 14:36:49 +10:00
36a7028f19
FEATURE: Clean up `PostReplyKey` records.
...
* Default retention of 90 days.
2018-08-23 10:40:02 +08:00
f01169d6ff
FIX: don't send email when the post was deleted
2018-08-22 13:13:58 +02:00
d3b4f24ced
DEV: correct watcher for controller specs
2018-08-22 14:35:57 +10:00
272de95175
FIX: client duplicate registration should be cleaned up
...
If for any reason we are unable to correct client id on a user api key
invalidate old keys for client/user
2018-08-22 12:56:49 +10:00
5d96809abd
FIX: improve support for subfolder S3 CDN
2018-08-22 12:31:13 +10:00
f5142861e5
Revert "Revert "FIX: upload URLs from S3 on subfolder installs""
...
This reverts commit 26c96e97e5
2018-08-22 11:31:33 +10:00
26c96e97e5
Revert "FIX: upload URLs from S3 on subfolder installs"
...
This reverts commit 357df2ff4f
2018-08-22 10:51:40 +10:00
410b0f591f
FIX: Flagged Post custom fields were not respecting type
2018-08-21 15:33:15 -04:00
357df2ff4f
FIX: upload URLs from S3 on subfolder installs
2018-08-21 14:58:55 -04:00
d1607a387a
FIX: only allow printable characters in uploads filename
2018-08-21 18:11:01 +02:00
e94b5b4d78
Version bump to v2.1.0.beta5
2018-08-21 11:54:23 -04:00
0f07494b12
Merge pull request #6259 from pfaffman/patch-2
...
FIX: disable_2fa fix method selection
2018-08-21 17:29:42 +08:00
791ddb8630
PERF: Memoize `EmailReceiver#sent_to_mailinglist_mirror?`.
2018-08-21 15:44:47 +08:00
7dcc69aef4
DEV: Refactor test to not call private method.
2018-08-21 14:29:58 +08:00
57d04200a1
Add Rails 6 note here
2018-08-21 11:09:10 +10:00
ca5a6f0a9d
FIX: handle concurrently creating post reply keys
...
In some very rare conditions this would be called concurrently and fail
2018-08-21 10:59:18 +10:00
8fa5dd4a1f
FEATURE: discourse-checklist is now an official plugin
2018-08-21 10:44:40 +10:00
860c1c3dcd
FEATURE: Automatically expire keys if not used for a configurable amount of time. ( #6264 )
2018-08-20 17:36:14 +02:00
ac40fede66
Revert "FIX: subfolder support for S3 CDN"
2018-08-20 10:30:44 -04:00
0b8f6d3637
FIX: subfolder support for S3 CDN
2018-08-20 10:22:03 -04:00
f5fe58384f
correct regression around file renaming
2018-08-20 16:08:05 +10:00
d7b1919ead
correct specs
2018-08-20 12:46:14 +10:00
8b5e42ea16
FIX: always test and coerce to image on upload
...
In the past the filename of the origin was used as the source
for the extension of the file when optimizing on upload.
We now use the actual calculated extension based on upload data.
2018-08-20 12:18:59 +10:00
a83f662492
FIX: Allow silenced users to like / bookmark, just not flag.
2018-08-17 11:06:18 -04:00
16c0ebe8a8
Fix the build.
2018-08-17 16:53:07 +08:00
a26ef7738f
FIX: `FileHelper#download` should return nil if max size is exceeded.
2018-08-17 16:19:59 +08:00
be89f593f9
DEV: Include caller in error message for `Discourse#execute_command`.
2018-08-17 16:17:07 +08:00
fae8757cd4
FIX: `Guardian#post_can_act?` shouldn't raise an error if user of post has been deleted.
2018-08-17 15:11:30 +08:00
70155f0923
DEV: decrease log level of compile failures
...
We do not need to report his in logs, our failure mode is fine here.
2018-08-17 17:10:02 +10:00
a9e502936f
FIX: Converting PNG to JPEG does not set the correct extension.
2018-08-17 13:09:48 +08:00
802ad0dc61
Add rake task for updating static pages
2018-08-16 19:51:20 +02:00
98898ff4b3
FIX: raise an exception when 'downsize'git st fails
2018-08-16 19:20:07 +02:00
3fbf7b164d
FEATURE: emoji 11.0 "recently added" update ( #6275 )
...
Adds support for emojis in the http://www.unicode.org/emoji/charts-11.0/emoji-released.html list
2018-08-16 11:59:45 +02:00
937ab3f213
FIX: Validation of min_posts and max_posts didn't work
2018-08-16 10:36:53 +02:00
8e3b685aa4
make rubocop happy
2018-08-16 14:03:46 +05:30
df55e5bac4
optimize categories:create_definition task
2018-08-16 14:00:07 +05:30
78e14abb32
new rake task to bulk tag all topics in a category
2018-08-16 13:56:57 +05:30
777055f960
new rake task to create category definition
2018-08-16 13:50:52 +05:30
796164b58c
FIX: automatically correct bad avatars on access
...
Also start relying on upload extension for optimized images
2018-08-16 16:32:56 +10:00
33f4aa2835
Fix `migrate_to_s3` rake task, `File#close!` is not a valid method.
2018-08-16 13:26:58 +08:00
ac3b0f0164
REFACTOR: move remap out of script into a class
2018-08-15 12:37:52 -04:00
7b089f7af4
FIX: Don't throw exception if welcome topic cannot be found
2018-08-15 15:50:55 +01:00
38c10a3dc2
correct the validator
2018-08-15 14:56:24 +10:00
91e0a77a60
FEATURE: silenced users should not be allowed to edit posts
2018-08-15 14:29:36 +10:00
06f82a7d72
correct exception handling, always do to_i in array
2018-08-15 11:31:42 +10:00
bc47148d35
add validation to exclude_category_ids
2018-08-15 09:53:28 +10:00
12bab65167
FIX: going from /categories to /latest on mobile might break infinite scrolling
2018-08-15 01:22:03 +02:00
ba0e322fd0
FIX: Validation of topic params broke discourse-assign
2018-08-14 18:45:46 +02:00
87fa26b6c8
FIX: Silenced users shouldn't be able to act on posts
2018-08-14 11:43:39 -04:00
2927294cc6
FIX: Bulk deleting topics should ignore already deleted topics
2018-08-14 16:37:52 +02:00
de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
ad5f502332
FIX: add a basic validator for topic params
...
This cuts down on log noise when people try out sql injection
2018-08-14 17:01:04 +10:00
6cae47aa53
collect extra environment correctly
2018-08-13 16:33:28 +10:00
168ffd8384
FEATURE: group warnings about IP level rate limiting
2018-08-13 14:38:20 +10:00
d10c9d7d75
FIX: Missing extensions for non-image uploads due to 2b57239389.
2018-08-13 10:58:55 +08:00
71a1d75d7e
FIX: disable_2fa fix method selection
...
The previous code resulted in
NameError: undefined local variable or method `totp' for main:Object
I now understand what @tgxworld meant about we should only disable totp when I submitted this before.
This is the kind of Ruby stuff that I still don't understand well,(perhaps this isn't the most Ruby way to do this?) but this does what I think is supposed to happen. And it worked just now.
2018-08-10 14:45:40 -07:00
865cb3feb9
FIX: allow selecting site's default theme from preference
2018-08-10 14:12:02 +03:00
ea8394b080
typo in error message
2018-08-10 11:34:01 +10:00
1fc2597626
better error handling for upload extension fixer
2018-08-10 11:28:22 +10:00
b9072e8292
FEATURE: Add "Reset Bump Date" action to topic admin wrench ( #6246 )
2018-08-10 10:51:03 +10:00
ef4b9f98c1
FEATURE: Allow admins to reply without topic bump
2018-08-10 10:48:30 +10:00
d77dccc636
FIX: user-deleted posts with deferred flags can be destroyed
2018-08-09 14:54:31 -04:00
6ddf7fcd1f
Fix warnings about already initialized constants
2018-08-09 17:29:02 +02:00
5895507153
FEATURE: Ability for plugins to whitelist custom fields for flags
...
You can now call `whitelist_flag_post_custom_field` from your plugins
and those custom fields will be available on the flagged posts
area of the admin section.
2018-08-09 10:49:14 -04:00
ed4c0f256e
FIX: check permalinks for deleted topics
...
- allow to specify 410 vs 404 in Discourse::NotFound exception
- remove unused `permalink_redirect_or_not_found` which
- handle JS side links to topics via Discourse-Xhr-Redirect mechanism
2018-08-09 15:05:12 +10:00
1ea23b1eae
FIX: Wrong order for `S3Helper#copy_file`.
2018-08-08 15:58:54 +08:00
0879610ffd
Add missing require in `uploads:fix_incorrect_extensions`.
2018-08-08 15:39:37 +08:00
a35f2984e9
FIX: support Arrays with Marshal dump in distributed cache
...
Theme cache uses arrays here
2018-08-08 16:44:56 +10:00
17047806b9
Add a rake task to fix uploads with wrong extension.
2018-08-08 13:15:17 +08:00
0b7ed8ffaf
FEATURE: backend support for user-selectable components
...
* FEATURE: backend support for user-selectable components
* fix problems with previewing default theme
* rename preview_key => preview_theme_id
* omit default theme from child themes dropdown and try a different fix
* cache & freeze stylesheets arrays
2018-08-08 14:46:34 +10:00
aafff740d2
Add `FileStore::S3Store#copy_file`.
2018-08-08 11:30:34 +08:00
4e6e4a83df
FIX: subfolder digest emails have incorrect URLs
2018-08-07 16:38:17 -04:00
1fcb5c1b6d
Version bump to v2.1.0.beta4
2018-08-07 12:32:57 -04:00
2b57239389
FIX: Upload's content is the only source of truth for the file type.
2018-08-07 13:15:00 +08:00
4b000f5d12
FIX: do not use `lib` for requires
...
this breaks loading the app from arbitrary dirs
2018-08-07 11:04:29 +10:00
ffc8c52bf5
FIX: store welcome topic id in custom field
2018-08-06 23:46:03 +05:30
812add18bd
REFACTOR: Serve auth provider information in the site serializer.
...
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
0cd9e2acb9
fix build
2018-08-04 01:56:26 +02:00
066010db7d
FEATURE: introduces list/compact_list components
2018-08-03 16:41:37 -04:00
ac2513b0f2
FEATURE: automatic PM when a user's email is revoked
2018-08-03 16:39:22 +02:00
c81bad3232
Merge pull request #6232 from OsamaSayegh/message-email-short-reply
...
UX: better rejection message when reply via email is too short
2018-08-02 14:25:04 -07:00
a157dfd418
UX: better rejection message when reply via email is too short
2018-08-02 22:43:53 +03:00
14bbd5d167
FIX: use the right URL when downloading the file from S3
2018-08-02 10:04:41 +02:00
4a872823e7
Improvements to user drafts ( #6226 )
...
* drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels
* use JSON when testing Draft.stream
2018-08-02 07:41:27 +10:00
0f1137dafa
FIX: 'migrate_from_s3' rake task wasn't handling short urls
2018-08-01 22:58:46 +02:00
059862ed46
Mark discord auth plugin official
2018-08-01 09:33:14 -07:00
b829452c75
Merge pull request #6209 from discourse/mini_scheduler
...
REFACTOR: extract scheduler to the mini_scheduler gem
2018-08-01 10:28:24 -04:00
0b9437cee7
FIX: more resilient/consistent dashboard caching ( #6223 )
2018-08-01 09:45:50 -04:00
a115aae45f
Use rchardet instead of charlock_holmes gem
2018-08-01 10:41:20 +02:00
ff942ed2f3
FIX: Try detecting encoding of RSS feed
2018-08-01 10:41:20 +02:00
1f45215537
FEATURE: Drafts view in user profile
...
* add drafts.json endpoint, user profile tab with drafts stream
* improve drafts stream display in user profile
* truncate excerpts in drafts list, better handling for resume draft action
* improve draft stream SQL query, add rspec tests
* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)
* cleanup
* linting fixes
* apply prettier styling to modified files
* add client tests for drafts, includes a fixture for drafts.json
* improvements to code following review
* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix
* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed
* prettier, eslint fixes
* use "username_lower" from users table, added error handling for rejected promises
* adds guardian spec for can_see_drafts, adds improvements following code review
* move DraftsController spec to its own file
* fix failing drafts qunit test, use getOwner instead of deprecated this.container
* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
6aee22b88f
FIX: Onebox images are not downloaded locally without css class
2018-08-01 02:51:02 +05:30
4ad7ce70ce
REFACTOR: extract scheduler to the mini_scheduler gem
2018-07-31 17:12:55 -04:00
afe3b00c0f
FIX: use hidden setting for max export file size
2018-07-31 11:25:28 +05:30
f0c203a5cf
clean up previous commit
2018-07-31 14:50:02 +10:00
b55d9e63a0
Rake mail test debugging ( #6171 )
...
* FEATURE: rake emails:test add debugging
* Oops! Remove safety code
* more language tweaks
2018-07-31 14:45:59 +10:00
fd29ecb91a
UX: include a flag reason in the post-deleted-by-staff-because-of-flags message
2018-07-30 16:45:46 -04:00
8f1db615db
FIX: don't break restore if function does not exist
2018-07-30 22:11:38 +02:00
17b851cf08
FEATURE: show last updated date for wiki topics
2018-07-30 20:27:49 +05:30
6566b2f11a
FEATURE: Allow revoke and connect for Instagram logins
2018-07-30 14:38:53 +01:00
dfcb2a0d42
FEATURE: include published_time in metadata
2018-07-30 17:09:56 +05:30
8d1acbd4c2
DEV: Include specific authenticator name in warning message
2018-07-30 11:33:48 +01:00
b94633e844
FIX: `FileHelper` should prioritize response content-type.
...
Request to a URL with `.png` extension may return a jpg
instead causing us to attach the wrong extension to an
upload.
2018-07-30 10:54:36 +08:00
5f1fd0019b
FEATURE: Allow revoke and connect for GitHub logins
2018-07-27 17:18:53 +01:00
6296f63804
FEATURE: Revoke and connect for Yahoo logins
2018-07-27 16:20:47 +01:00
9c72c00206
FEATURE: Revoke and reconnect for Twitter logins
2018-07-27 12:28:51 +01:00
c74dd2fa08
FIX: welcome topic should not be a private message
2018-07-27 15:15:13 +05:30
6740631fdb
TEMPFIX: Fix broken restores.
2018-07-27 12:48:16 +08:00
135c803f49
FIX: don't send PM if flagged post is deleted but flags were deferred or cleared
2018-07-26 15:12:31 -04:00
a74024b1c9
Version bump to v2.1.0.beta3
2018-07-26 14:16:06 -04:00
467c529920
FIX: Remove return statement from inside block
2018-07-26 15:52:39 +01:00
88241f57a3
FEATURE: allow auth plugins to have a site setting for full screen login
2018-07-26 11:11:16 +01:00
def2c977ce
allow auth plugins to have a site setting for if they should be full screen vs popup window
2018-07-25 19:20:11 -05:00
f94aeaf6cf
SECURITY: force IM decoder based on file extension - part 3
2018-07-25 23:55:06 +02:00
800c57c6ab
SECURITY: force IM decoder based on file extension - part 2
2018-07-25 23:08:02 +02:00
4bf3bf6786
SECURITY: force IM decoder based on file extension
2018-07-25 22:00:04 +02:00
0d0d78841b
FIX: Remove `plugin.enabled?` checks at initialization time ( #6166 )
...
Checking `plugin.enabled?` while initializing plugins causes issues in two ways:
- An application restart is required for changes to take effect. A load-balanced multi-server environment could behave very weirdly if containers restart at different times.
- In a multisite environment, it takes the `enabled?` setting from the default site. Changes on that site affect all other sites in the cluster.
Instead, `plugin.enabled?` should be checked at runtime, in the context of a request. This commit removes `plugin.enabled?` from many `instance.rb` methods.
I have added a working `plugin.enabled?` implementation for methods that actually affect security/functionality:
- `post_custom_fields_whitelist`
- `whitelist_staff_user_custom_field`
- `add_permitted_post_create_param`
2018-07-25 16:44:09 +01:00
796639a797
FIX: makes disk_space computation more resilient ( #6172 )
2018-07-25 11:04:01 -04:00
fa399ce1c5
FEATURE: Add revoke and reconnect functionality for google logins
2018-07-25 16:03:14 +01:00
578c8e861b
FIX: refreshes disk_space on backup create/destroy ( #6169 )
2018-07-25 08:26:30 -04:00
776fd0de66
FIX: Filter open-id logins by identifier
2018-07-25 11:47:09 +01:00
84d14fd8a0
FIX: Don't rely on setting data type read from database
2018-07-25 11:40:59 +02:00
417bcf7d2e
add checks for staff and system user before sending flags_agreed_and_post_deleted message
2018-07-24 19:25:11 -04:00
fe39cdc90a
FEATURE: when a post is deleted because a moderator agreed with flags, send a message to the post author
2018-07-24 17:17:56 -04:00
7058205f70
FIX: Broken specs
2018-07-24 12:00:34 -04:00
236243f38a
SECURITY: Consider `0.0.0.0` a private IP
2018-07-24 11:16:27 -04:00
7a3c541077
UX: Preview multiple color schemes in wizard ( #6151 )
...
It was a dropdown to provide choices of color schemes,
and only one scheme could be shown.
With this commit, multiple color scheme previews can be displayed on
one page at the same time, making admins choose color schemes more
easily.
Theme preview windows are shrinked.
Imported default color schemes.
Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>
2018-07-24 09:00:20 -04:00
fa19d3a53c
Merge pull request #6108 from discourse/transaction-sidekiq-fix
...
Fix notifications for topics moved between categories
2018-07-24 17:44:03 +08:00
20a21b1240
Move into MiniSQLMultisiteConnection, and add test for rollback
2018-07-24 09:41:55 +01:00
fad9c2b971
PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.
2018-07-24 13:51:53 +08:00
ae8b0a517f
PERF: Split skipped email logs into a seperate table.
2018-07-24 13:14:37 +08:00
e42038eae2
Rake task called method with wrong arguments
2018-07-24 00:10:09 +02:00
eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 ( #6099 )
...
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
b165cfdfbe
FIX: Raise a better error in `SiteSettings::TypeSupervisor`.
2018-07-19 16:41:00 +08:00
14a0879658
FIX: allow Twitter videos to go fullscreen
2018-07-19 10:22:36 +05:30
2dc3a50dac
FIX: Do not update `last seen` time for suspended users
2018-07-18 16:04:57 +01:00
6d6e026e3c
FEATURE: selectable avatars
2018-07-18 12:57:43 +02:00
379384ae1e
FIX: never block /srv/status which is used for health checks
...
This route is also very cheap so blocking it is not required
It is still rate limited and so on elsewhere
2018-07-18 12:37:01 +10:00
3874d40910
Prepare to drop `EmailLog#topic_id`.
2018-07-18 10:22:24 +08:00
1d74ccaaf8
Add compatibility for ImageMagick7.
2018-07-17 15:50:58 +08:00
a7ec949e02
make RuboCop happy
2018-07-17 13:15:44 +05:30
7c7509e1bd
FEATURE: update TwitterApi for prettifying like/retweet count
2018-07-17 12:59:40 +05:30
7b3ef4d13f
FIX: use email color settings consistently in notification emails
2018-07-16 12:30:42 -04:00
a6c589d882
FEATURE: Add custom S3 Endpoint and DigitalOcean Spaces/Minio support for Backups ( #6045 )
...
- Add custom S3 Endpoints and DigitalOcean Spaces support
- Add Minio support using 'force_path_style' option and fix uploads to custom endpoint
2018-07-16 14:44:55 +10:00
0ed2834c2d
FEATURE: Add users:disable_2factor rake task
...
https://meta.discourse.org/t/admin-locked-out-of-2fa/92156/2?u=pfaffman
2018-07-16 09:56:55 +08:00
b1082924b9
FIX: do not validate topic deletions
2018-07-13 22:53:36 +05:30
711371e8c8
FIX: Select+below will ask server for post ids on megatopics.
2018-07-13 15:10:39 +08:00
c722b07057
FIX: `/t/:topic_id/last` route did not return any posts.
2018-07-13 14:26:10 +08:00
2901691e87
FEATURE: per-category approval settings ( #5778 )
...
- disallow moving topics to a category that requires topic approval
2018-07-13 12:51:08 +10:00
81f9500f5c
FIX: Change megatopic threshold to 10,000 posts
2018-07-12 22:00:53 +01:00
258e9e35ca
PERF: Make mega topics work without a stream.
...
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld .
2018-07-12 12:46:12 +08:00
decf1f27cf
FEATURE: Groundwork for user-selectable theme components
...
* Phase 0 for user-selectable theme components
- Drops `key` column from the `themes` table
- Drops `theme_key` column from the `user_options` table
- Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column.
- Removes the `default_theme_key` site setting and adds `default_theme_id` instead.
- Replaces `theme_key` cookie with a new one called `theme_ids`
- no longer need Theme.settings_for_client
2018-07-12 14:18:21 +10:00
536cef86f4
PERF: do not carry post ids in memory when rebaking all posts
2018-07-11 14:34:33 +05:30
0942e2c795
allow adding tags as a custom subject format for emails ( #5846 )
...
allow adding tags as a custom subject format for emails
2018-07-11 12:24:07 +10:00
f69b7deb80
FIX: wizard emoji images on subfolder installs
2018-07-10 11:02:22 -04:00
b4e1388f9b
PERF: Drop support for gaps in mega topics.
...
Based on our current implementation, there isn't a
practical way to determine the gaps of large topics
cheaply. We tried to load the gaps in chunks but felt
that the code becomes too complicated. Note that
megatopics are quite rare in the wild.
2018-07-10 16:27:02 +08:00
21f333654c
REFACTOR: Reduce dependency on the post stream in `TopicView`.
...
This will allow us to drop the post stream from the payload for
mega-topics. On smaller topics, the extra query is fast because
of an existing index.
2018-07-10 15:53:00 +08:00
4163f9e61e
DEV: Better clean up for PostgreSQL failover test.
2018-07-10 09:53:25 +08:00
96aca6d7e6
Remove legacy vote post action code. ( #6009 )
2018-07-09 16:54:18 +08:00
72a3457379
Bump `discourse_image_optim` which uses a global timeout.
...
Our previous solution has the timeout set at the worker level
which means the total timeout would be X timeout secs * N number of
workers.
2018-07-09 10:30:18 +08:00
dba22bbde2
rollback changes
...
This reverts:
* 1baba84c438e "fix s3 subfolders harder"
* ea5e57938edf "fix test for absolute_base_url change"
2018-07-06 17:16:40 -05:00
52e9f49ec1
fix s3 subfolders harder
...
specifically, include the folder in absolute_base_url
2018-07-06 16:28:40 -05:00
59a2767de8
Ensure that we restore the site setting in posts:rebake rake task.
2018-07-06 16:22:54 +08:00
eabc8f7fbd
Merge pull request #6023 from misaka4e21/only-staff-can-create-tag
...
FEATURE: Support disabling tag creation for non-staff users.
2018-07-05 11:12:44 -04:00
92000bc8a0
FEATURE: add a rake task to recalculate user stats post_count and topic_count
2018-07-05 10:38:46 -04:00
28dd7fb562
FEATURE: Create hidden posts for received spam emails ( #6010 )
...
* Add possibility to add hidden posts with PostCreator
* FEATURE: Create hidden posts for received spam emails
Spamchecker usually have 3 results: HAM, SPAM and PROBABLY_SPAM
SPAM gets usually directly rejected and needs no further handling.
HAM is good message and usually gets passed unmodified.
PROBABLY_SPAM gets an additional header to allow further processing.
This change addes processing capabilities for such headers and marks
new posts created as hidden when received via email.
2018-07-05 11:07:46 +02:00
7b26f5086b
PERF: we have no use for topic percent rank
...
Prepare to remove this column
2018-07-05 15:10:19 +10:00
272646c1df
FIX: only show the sequential replies warning for regular posts
2018-07-04 22:51:19 +02:00
8a53941fe0
FIX: less aggressive gmail eliding
2018-07-04 20:04:46 +02:00
448e2fe1a2
FIX: properly delete files in the download cache
2018-07-04 18:18:39 +02:00
f134701c7b
FIX: user topic and post counts can become negative when staff deletes posts in personal messages
2018-07-04 09:31:16 -04:00
7590128d38
fix typo
2018-07-04 12:01:15 +05:30
0af159546a
FIX: `BackupRestore::Backuper#remove_tar_leftovers` not cleaning up files.
...
Wildcard is sanitized when passed to `system()`.
2018-07-04 13:58:39 +08:00
e72fd7ae4e
FIX: move crawler blocking into anon cache
...
This refinement of previous fix moves the crawler blocking into
anonymous cache
This ensures we never poison the cache incorrectly when blocking crawlers
2018-07-04 11:14:43 +10:00
7f98ed69cd
FIX: move crawler blocking to app controller
...
We need access to site settings in multisite, we do not have access
yet if we attempt to get them in request tracker middleware
2018-07-04 10:30:50 +10:00
d1b21aa73b
add timings to asset precompile
2018-07-04 09:42:38 +10:00
b6e9c734f2
replace error with message
...
So Discourse continues to work on Ruby trunk
2018-07-04 09:42:38 +10:00
e8a6323bea
remove crawler blocking until multisite support
2018-07-03 17:54:45 -04:00
b71cf6d422
FEATURE: Add search not operator for tags.
2018-07-03 15:57:34 +08:00
212f518cd1
Add invite tokens to official plugins list
2018-06-30 17:24:45 -04:00
252e5574cc
FIX: Prevent ambigous column errors when joining `TopicView` queries.
2018-06-29 10:33:08 +08:00
db14e10943
SECURITY: category badges should HTML escape names
2018-06-28 18:15:07 +10:00
ec3e6a81a4
FEATURE: Second factor backup
2018-06-28 10:12:32 +02:00
23acddc9fa
Add descriptions for rake tasks
2018-06-27 20:24:46 +02:00
eb427f7cf4
PERF: Update `TopicView#participant_count` to use `Topic#posts_count`.
...
Use the counter cache instead of hitting the DB and plucking
every single id.
2018-06-27 17:18:47 +08:00
cfa7898c2d
Rename `TopicView#last_read_post_id` to `TopicView#filtered_post_id`.
2018-06-27 12:33:57 +08:00
cb69888758
PERF: Don't pluck all the columns just to retrieve a single value.
2018-06-27 11:41:35 +08:00
47cb46671a
FEATURE: Support disabling tag creation for non-staff users.
2018-06-27 07:15:02 +08:00
6bcdc3ba4b
FEATURE: allow author to delete posts irrespective of post_edit_time_limit
2018-06-26 21:43:06 +05:30
49ffc1eb61
Revert "PERF: Send down gaps as the relevant posts load instead of front loading."
...
This reverts commit 4c3352528e
2018-06-26 12:54:14 +08:00
4c3352528e
PERF: Send down gaps as the relevant posts load instead of front loading.
2018-06-26 12:49:06 +08:00
0b6a2e9d1f
Remove force summary mode for megatopics for now.
...
The logic is too hairy and we can't reliably determine
when to force summary mode. Work is underway to improve
perf for megatopics so this will not be required
eventually.
2018-06-26 12:49:06 +08:00
5100a62fc0
FIX: Megatopics forced into summary mode when loading posts.
2018-06-25 22:11:56 +08:00
4644d777bd
FEATURE: add website field to SSO
2018-06-25 16:09:39 +10:00
41f76a74f8
FEATURE: send message when a user reaches tl1
2018-06-22 13:20:00 -07:00
6901e0e043
FIX: Rails.logger isn't always available when loading plugin locales
2018-06-22 10:20:20 -04:00
50f14c6e61
Prefer `update!` -> `update!`.
2018-06-22 15:13:04 +08:00
f69356e628
FIX: Users can't "show all posts" in forced summary topics.
2018-06-22 11:32:45 +08:00
544254f7a8
Version bump to v2.1.0.beta2
2018-06-21 10:41:52 -04:00
97d8cd820e
No need to expire readonly mode key immediately.
2018-06-21 17:52:42 +08:00
9a7a079f4d
Force summary mode when user enters at the top of megalodoon topics.
2018-06-21 15:18:52 +08:00
f7d22bad90
FEATURE: Forced summary mode for megalodon topics.
...
This is mainly done for performance reasons and megalodon
topics are usually a byproduct of imports where site setting
limits are not respected.
2018-06-21 14:00:20 +08:00
5cef4e281b
PERF: Memoize `TopicView#gaps` results.
2018-06-21 12:37:24 +08:00
2d59d06916
PERF: mega_topics get no post counts per user
2018-06-21 11:09:45 +10:00
f66efc601d
FIX: cubot android devices were detected as crawlers
2018-06-21 10:56:46 +10:00
2f7960bd2a
DEV: updates prettier and displays linters/prettifiers version in CI
2018-06-20 18:34:49 +02:00
8126b603e4
fix prettier
2018-06-20 18:26:43 +02:00
c5c1b45d19
higher loglevel for prettier
2018-06-20 16:51:48 +02:00
0365806b93
FIX: Properly display error when post action fails to create.
2018-06-20 21:20:23 +08:00
ff5fc3cb08
Use a fixed limit for mega topic posts count.
2018-06-20 16:58:52 +08:00
9c925a66ff
PERF: Don't display days ago on timeline for megatopics.
...
Analysis using `pg_stat_statements` showed this query
to be eating up a significant portion of CPU.
2018-06-20 16:25:54 +08:00
cbdab71179
PERF: stop counting participants on very large topics
...
This query gets very expensive and can be bypassed on large topics
2018-06-20 18:11:39 +10:00
2f0e73f2d6
DEV: fast pluck to use type_map in mini_sql
2018-06-20 17:53:49 +10:00
44091f20c6
DEV: allow for method deprecation using Discourse.deprecate
...
New method deprecator will ensure one log message an hour happens
for all deprecated method calls per call site
Also removes unused monkey patches to ActiveRecord::Base
2018-06-20 17:53:49 +10:00
cb824a6b33
DEV: remove all calls to SqlBuilder use DB.build instead
...
This is part of the migration to mini_sql, SqlBuilder.new is being
deprecated and replaced with DB.build
2018-06-20 17:53:49 +10:00
806f0ca19d
FIX: URL with params for svg images should not be light boxed.
2018-06-20 10:47:14 +08:00
aedc61a3b4
FEATURE: allow large icon to be uploaded in wizard
2018-06-19 21:08:02 +05:30
24c27b5321
FEATURE: adds a add_report method accessible in plugin.rb
2018-06-19 15:00:11 +02:00
7eff64773c
Revert "FIX: Don't clear active connections in defer queue."
...
This reverts commit c9feadf9ec
2018-06-19 17:58:21 +08:00
df24c51c6f
Revert "FIX: Don't try to dequeue an empty queue."
...
This reverts commit 1af7d4a894
2018-06-19 15:49:45 +08:00
41c1e1b302
FIX: `Discourse.keep_readonly_mode` does not work for multisite.
2018-06-19 15:44:08 +08:00
1af7d4a894
FIX: Don't try to dequeue an empty queue.
2018-06-19 15:25:44 +08:00
b8e5989201
correct rake db:create, which needs a defer DB object
2018-06-19 16:43:50 +10:00
5f64fd0a21
DEV: remove exec_sql and replace with mini_sql
...
Introduce new patterns for direct sql that are safe and fast.
MiniSql is not prone to memory bloat that can happen with direct PG usage.
It also has an extremely fast materializer and very a convenient API
- DB.exec(sql, *params) => runs sql returns row count
- DB.query(sql, *params) => runs sql returns usable objects (not a hash)
- DB.query_hash(sql, *params) => runs sql returns an array of hashes
- DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array
- DB.build(sql) => returns a sql builder
See more at: https://github.com/discourse/mini_sql
2018-06-19 16:13:36 +10:00
cc3fc87dd7
DEV: handle termination cleanly in autospec
2018-06-19 16:13:36 +10:00
c9feadf9ec
FIX: Don't clear active connections in defer queue.
2018-06-19 12:45:16 +08:00
34e4c8f573
FIX: `Discourse.keep_readonly_mode` spins a new thread each time it is called.
2018-06-19 10:24:08 +08:00
6e97242bb9
Monkey patch in 7830a950ef
2018-06-19 09:45:48 +08:00
68e4e6a575
FIX: staged users are still tl0 but do not trigger spam if 1 week old.
2018-06-18 17:20:04 -07:00
630b4570ef
Add specs for `RateLimiter::LimitExceeded#description`.
2018-06-19 07:48:03 +08:00
3725fd8345
Merge pull request #6002 from featheredtoast/trust-previously-staged-users
...
FIX: don't punish a user for being previously staged for spam flags.
2018-06-18 15:14:31 -04:00
320cd9a19e
UX: rate limiter message will say to wait "a few seconds" instead of 0 to 3 seconds
2018-06-18 14:14:47 -04:00
913d97e780
fix prettier
2018-06-18 20:10:48 +02:00
6f2c5ea1f2
increases loglevel to debug CI only failure
2018-06-18 19:25:54 +02:00
9963078dd1
Add to offical plugins list
2018-06-18 10:20:49 -06:00
e5c156b226
Add `characters-required` to official plugins list
2018-06-18 10:30:46 -04:00
c18b86d9b2
UX: Don't add light box for SVG images.
2018-06-18 17:11:06 +08:00
9e55767f6a
FIX: don't punish a user for being previously staged for spam flags.
2018-06-15 12:25:25 -07:00
03a7d532cf
DEV: introduces prettier for es6 files
2018-06-15 17:03:24 +02:00
c7ee70941e
FEATURE: show category page options on wizard 'homepage' step
2018-06-15 19:11:41 +05:30
2427c0a17c
FIX: theme CSS should recompile when theme uploads change
2018-06-15 13:12:09 +10:00
c34100d1e7
Remove unused variable.
2018-06-15 07:45:51 +08:00
6123f61f5f
seconds is not needed here
2018-06-14 20:53:24 +10:00
87fabdc2f3
FIX: correct pool reaper
...
This removes a freedom patch and replaces with a custom reaper thread
it also captures an issue where reaper would fail when connections where
empty
2018-06-14 18:22:02 +10:00
71aa20bd30
FIX: pool drainer to use Rails 5.2 implementation
...
old implementation did not reap abandoned connections
2018-06-14 15:54:48 +10:00
66982c7800
FIX: stop using Rails connection reaper in multisite
...
The Rails 5.2 connection reaper appears to be leaking threads
this is a quick fix to stop it, though we need to make sure we
never leak connection pools as well.
2018-06-14 12:49:30 +10:00
fd54c92a52
FEATURE: New site setting, whitelisted_link_domains
...
If provided, users who normally couldn't post links (say, due to a
low trust level), can post links to those specific hosts.
2018-06-13 16:11:22 -04:00
ae728702a6
Revert "Revert "Preload custom user fields when viewing flag queue""
...
This reverts commit 1bb12ee1b6
2018-06-13 11:44:13 -04:00
139d0813b4
Re-enable fast_pluck freedom patch.
2018-06-13 09:25:23 +08:00
1bb12ee1b6
Revert "Preload custom user fields when viewing flag queue"
...
This reverts commit 5bd1c5cc95
2018-06-12 16:46:31 -04:00
5bd1c5cc95
Preload custom user fields when viewing flag queue
2018-06-12 16:17:22 -04:00
e0096b0d1c
Safety in case translations are missing root keys
2018-06-12 10:09:57 -04:00
7c173265d5
FIX: Don't clear connections on the same process.
2018-06-12 13:06:25 +08:00
646ed87aba
Clear all connections once master recovers.
2018-06-12 12:13:59 +08:00
fd75e54793
Disconnect the pool during failover and fallback.
2018-06-12 11:09:19 +08:00
a7be68500d
Better error reporting in PostgreSQL fallover thread.
2018-06-12 09:39:11 +08:00
0dee603ffc
Merge pull request #5985 from featheredtoast/pm-participants-two-lines
...
FIX: PM participants listed inline
2018-06-11 18:33:15 -07:00
805fd17b23
ActiveRecord in Rails 5.2 discards connection pools after fork.
2018-06-12 09:30:52 +08:00
4599cc8435
FIX: PM participants listed inline
2018-06-11 18:14:25 -07:00
8d92c73aad
Merge pull request #5952 from Supermathie/remap_enhance
...
DbHelper.remap/find: add option to anchor at left/right of the column value
2018-06-11 15:15:17 -04:00
bfa0f71e2b
FIX: `Discouse.keep_readonly_mode` incorrect extends expiry.
2018-06-12 00:21:29 +08:00
2adae2a0b6
FIX: Be more aggressive in checking master when trying to fallback.
2018-06-12 00:09:15 +08:00
4d75535f9e
Revert "Revert "Revert "Add discourse-group-tracker to official plugin list."""
...
This reverts commit d1dc8e4226
2018-06-11 15:52:20 +02:00
d1dc8e4226
Revert "Revert "Add discourse-group-tracker to official plugin list.""
...
This reverts commit 1a00aaa825
2018-06-11 14:30:16 +02:00
c0b0c66a9e
FIX: PostgreSQL fallback thread doesn't run server starts in readonly.
2018-06-11 15:23:58 +08:00
d06af14c26
FIX: Notify all processes to fallback when PostgreSQL recovers.
2018-06-11 15:10:28 +08:00
d192924876
FIX: Can't boot Discourse app with read-only PG connection take 2.
2018-06-11 13:25:51 +08:00
93b1386fb2
REFACTOR: admin site settings controller specs to requests ( #5966 )
2018-06-11 12:48:09 +08:00
5656e8f366
FIX: Can't boot Discourse with a read-only PG connection.
2018-06-11 12:29:23 +08:00
b91a3c12a5
Revert "Smoke test should wait up to 5 minutes before it fails"
...
This reverts commit 34d4712133
2018-06-11 08:47:57 +08:00
e82d45b009
FIX: Ensure we have proper timeout for MiniRacer.
2018-06-11 08:41:04 +08:00
4b2e42757d
fix indent
2018-06-08 13:56:20 -04:00
b8cf0788c6
FIX: broken mailto href's in emails
2018-06-08 13:11:58 -04:00
d96c775833
enforces prettier
2018-06-08 17:38:29 +02:00
4ba910ac54
Update username only after successful user anonymization
2018-06-08 15:50:07 +02:00
22c186a792
disables prettier enforcing for now
2018-06-08 15:44:00 +02:00
eedf7ffc4f
force install with sudo
2018-06-08 13:25:33 +02:00
bc7f16a406
forces install of prettier using npm
2018-06-08 13:22:36 +02:00
3869a9d027
forces global install of prettier
2018-06-08 12:40:05 +02:00
ddade9c145
better log of yarn setup
2018-06-08 12:12:17 +02:00
bb920e9bb1
DEV: makes sure yarn is ran before docker:test
2018-06-08 12:04:53 +02:00
174d392e5a
DEV: adds prettier ( #5956 )
...
Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn`
It's recommended to configure your editor to run prettier on file save.
2018-06-08 11:49:31 +02:00
29c1f01494
Fix broken pool drainer after the upgrade.
...
See 6cd5cc375a/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb (L467)
2018-06-08 13:19:07 +08:00
42847252a4
remove conditional code
2018-06-08 13:38:25 +10:00
1a00aaa825
Revert "Add discourse-group-tracker to official plugin list."
...
This reverts commit e262cb07d4
2018-06-08 10:51:16 +08:00
e262cb07d4
Add discourse-group-tracker to official plugin list.
2018-06-08 09:55:26 +08:00
eba50f4591
DbHelper.remap: add options to anchor at left and right of the column value
2018-06-07 13:16:03 -04:00
beef0d9dd2
fix my lint errors
2018-06-07 11:10:54 -04:00
7e5f5a0b6b
DbHelper.find: column.table? strike that, reverse it
2018-06-07 10:59:34 -04:00
8d57c712c3
Add DbHelper.find(needle)
...
* searches the entire database for a text string (such as an old CDN name)
2018-06-07 10:51:16 -04:00
f9ab3848ed
FEATURE: support disabling emails for non-staff users
2018-06-07 18:31:08 +05:30
1834417e2f
downgrade rails properly
2018-06-07 20:38:22 +10:00
322b66bcee
attempt to shuffle order of operation for test
2018-06-07 18:16:45 +10:00
3533bdb83f
Remove line that is no longer required.
2018-06-07 15:56:16 +08:00
1d5c176ea5
DEV: `docker:test` rake task should install plugins first before migrating.
2018-06-07 15:20:06 +08:00
ad5082d969
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
54c0aa788c
FIX: db:create was failing due to site settings
2018-06-07 14:51:14 +10:00
f331d2603d
DEV: improve design of site setting default provider
...
This refactors it so "Defaults provider" is only responsible for "defaults"
Locale handling and management of locale settings is moved back into
SiteSettingExtension
This eliminates complex state management using DistributedCache and makes
it way easier to test SiteSettingExtension
2018-06-07 14:33:41 +10:00
89ad2b5900
DEV: Rails 5.2 upgrade and global gem upgrade
...
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated
Performance testing shows that performance has not regressed
if anything it is marginally faster now.
2018-06-07 14:21:33 +10:00
cb9596e196
Remove invalid `hosted-site` plugin.
2018-06-07 08:49:19 +08:00
aa5805e8b0
Revert "Initialize the v8 context after forking."
...
This reverts commit 41c4e32e64
2018-06-06 14:33:20 +08:00
dc61eaad37
FEATURE: new 'min ratio to crop' site setting
2018-06-05 17:13:00 +02:00
32c0ff4831
DEV: Install dependencies before running smoke test.
2018-06-05 18:46:41 +08:00
41c4e32e64
Initialize the v8 context after forking.
2018-06-05 11:36:38 +08:00
46fc57222f
FEATURE: improve handling of site setting secrets
2018-06-04 21:31:34 +05:30
313ff264f2
use generic example domain
2018-06-01 14:20:41 +05:30
7750b30016
FIX: Allow a user to remove their title
...
Somewhere there was a regression and a user couldn't remove their own
title. If they selected '(none)' in the UI it would say it was saved,
but it would not actually be updated in the db.
2018-05-31 17:16:52 -06:00
1a55948525
Version bump to v2.1.0.beta1
2018-05-31 18:29:10 -04:00
5086fdc76d
FIX: add protection for scss removal during upgrade
...
In some cases plugins would remove scss files or change them, but CSS
was still calculated based off stale data in old instance cache
2018-05-31 17:02:48 +10:00
5a8d2b5e45
FIX: rake assets:precompile should be re-runnable
2018-05-31 16:18:01 +10:00
5bd38e3a29
Add Github Linkback plugin
2018-05-31 01:02:35 +02:00
f10af7e449
FIX: don't generate an exception when trying to cleanup unexisting tmp letter avatars
2018-05-30 15:33:58 +02:00
db4af262dc
DEV: Create smoke test screenshot directory in rake task.
2018-05-30 16:20:18 +08:00
fe5a48997c
DEV: Store smoke tests failure image in a dedicated tmp folder.
2018-05-30 15:59:07 +08:00
543b7cddfb
FIX: Extra comma resulted in Github auth email result being an array.
...
https://meta.discourse.org/t/github-2fa-flow-broken/88674
2018-05-30 12:15:12 +08:00
4ad924bcf5
Add discourse-policy as official plugin
2018-05-29 16:57:05 -04:00
1b0a3023bb
fix rake task usage
2018-05-29 16:29:12 -04:00
a7be1ddf4f
variable name typo
2018-05-28 19:21:06 +05:30
586e45edb9
FIX: Split by space to support multiple categories export
2018-05-28 19:19:26 +05:30
81b5d61fa7
FIX: `topic_destroyed` web hook couldn't find topic.
2018-05-28 17:38:02 +08:00
ef84099db1
Add rake task for updating username in posts
2018-05-28 11:25:24 +02:00
e501936405
FIX: search server side error in rare condition
2018-05-28 15:28:18 +10:00
c677877e4f
FIX: Korean needs no word segmentation
2018-05-28 09:37:57 +10:00
f988fa31aa
FIX: ensure 'notifications_state' is up to date after creating a notification
2018-05-26 02:09:48 +02:00
c91071bb2a
FIX: don't 💥 when 'FastImage.size' has trouble with SSL
2018-05-26 00:55:19 +02:00
20b94bc714
FIX: Extraction of quoted posts failed in some cases
...
* It stored only oneboxed "quotes" when [quote] and links to topics or posts were mixed.
* Revising a post didn't add or remove records from the quoted_posts table.
2018-05-25 12:00:17 +02:00
80adc1ee80
DEV: stabilize site setting spec
...
side effects could cause specs to fail in rare conditions
2018-05-25 12:16:00 +10:00
d43895e2a0
Don't log 404s for `FinalDestination`.
...
* We can't do anything about 404s
2018-05-25 10:11:16 +08:00
71f66cd679
FIX: ensure PostAlerter is always run in sidekiq
2018-05-24 17:27:43 +02:00
3bfd9698c7
PERF: Avoid running the same query twice in `TopicViewSerializer#details`.
2018-05-24 16:46:13 +08:00
4be0e31459
fix s3_cdn_url when the s3 bucket contains a folder
2018-05-23 15:51:02 -05:00
ea7ffac17e
FIX: Paths used by PrettyText were not always initialized
2018-05-23 22:16:59 +02:00
fac4bf2f85
ignore emails that are from the reply by email addresses ( #5843 )
2018-05-23 10:04:45 +02:00
6974b7d6a8
FIX: run deferred jobs inline in sidekiq
2018-05-23 12:05:37 +10:00
ff15d95983
FIX s3_helper.list for buckets with folders
...
s3_bucket_folder_path does not contain a trailing slash so it was
smashingstufftogether
2018-05-22 20:09:08 -05:00
ad9e0d6bea
Merge pull request #5848 from OsamaSayegh/fix-social-login-groups
...
FIX: apply automatic group rules when using social login providers
2018-05-23 08:17:42 +08:00
f6d412465b
FIX: apply automatic group rules when using social login providers
2018-05-23 02:26:07 +03:00
db23e10efa
DEV: watch plugin.rb in autospec
2018-05-21 15:19:10 +10:00
be01491c04
Revert "Correct BBCode plugin name"
...
This reverts commit 10dfdd7d2a
2018-05-19 20:03:49 -04:00
10dfdd7d2a
Correct BBCode plugin name
2018-05-19 19:53:39 -04:00
efe7b6dbc1
DEV: after installing official plugins, install the gems
2018-05-17 17:18:22 +10:00
0e92dfa818
bump version to beta 10
2018-05-17 12:09:19 +10:00
a9ebde5111
FEATURE: new 'staged' users list for admins
2018-05-17 01:52:49 +02:00
2a9b4e4bb5
FIX: do not replace hashtags in URLs
2018-05-17 00:34:17 +05:30
6cd0b7316a
FIX: do not replace twitter handles in URLs
2018-05-17 00:20:11 +05:30
ff90881238
DEV: fix live refresh if you have a custom theme selected in dev
2018-05-16 17:25:49 +10:00
a024e5e9ac
Retry on read timeouts while warming up for qunit tests
2018-05-15 21:26:59 +02:00
a512b181d9
FIX: automatically in/decrement topic_tags.pm_topic_count
2018-05-15 16:05:48 +02:00
34d4712133
Smoke test should wait up to 5 minutes before it fails
2018-05-15 14:40:33 +02:00
93ed8d2522
PERF: defer user notifications ( #5827 )
2018-05-15 09:51:32 +02:00
8d6a9eb511
FIX: scrub all settings that has '_secret' in name
2018-05-15 09:37:13 +05:30
abcb6af8f9
FIX: scrub secret setting values from logs
2018-05-15 09:19:26 +05:30
2cf6fb7359
FIX: always unstage users when they log in
2018-05-13 17:00:02 +02:00
f4e9d47a27
Make linter happy
2018-05-13 15:20:39 +02:00
c9f959f9cb
Add emails:test rake task ( #5816 )
2018-05-13 14:15:15 +02:00
6a006b3646
FIX: format posts for embedded comments as we do for emails
2018-05-09 19:24:44 +02:00
86eb3528ec
FEATURE: clearer error message when receiving a reply to an old notification
2018-05-09 18:51:01 +02:00
6b1ff0edd3
FIX: always update bounce score (instead of doing it once per day)
2018-05-09 16:40:52 +02:00
1ce8b7def8
Run a plugin's integration tests via autospec when anything changes
2018-05-09 12:33:12 +10:00
bbc85258c9
Rename `display_plugins` -> `visible_plugins`.
2018-05-09 07:52:45 +08:00
52db0b31c1
FIX: Automatically add user to groups after updating email address
2018-05-08 21:27:22 +02:00
8262fc5d15
Merge pull request #5807 from discourse/min-flags-by-topic
...
FEATURE: New site setting `min_flags_staff_visibility`
2018-05-08 09:17:29 -04:00
e9d92da9ee
minor optimizations to categories:move_topics rake task
2018-05-08 15:14:19 +05:30
62c266f987
add a rake task to move all topics from one category to another
2018-05-08 15:05:56 +05:30
858a266031
FIX: exact matching should also match on title
2018-05-08 15:59:03 +10:00
c6f45fcfdb
Expose an API for plugins to be hidden on the admin plugin page.
2018-05-08 13:24:58 +08:00
8cf0f51eb2
UX: Display site settings shortcut for `poll` and `discourse-nginx-performance-report`.
...
https://meta.discourse.org/t/improving-admin-plugins/84585/29?u=tgxworld
2018-05-08 10:34:32 +08:00
ac60a84329
FEATURE: New site setting `min_flags_staff_visibility`
...
When set higher than 1, flags won't show up for staff in the admin
section unless the minimum threshold of flags on a post is reached.
2018-05-07 16:05:13 -04:00
a98aae3bcd
FIX: topic search wasn't working for unlisted topics
2018-05-07 11:43:55 +02:00
ff6be3c2e3
FEATURE: add profile_background fields into SSO ( #5701 )
...
Add profile_background and card_background fields into Discourse SSO.
2018-05-07 10:03:26 +02:00
0d74c30fa7
Remove more uses of `rescue nil`.
2018-05-07 11:38:23 +08:00
738f3f5229
Load missing libraries for server-side PrettyText
2018-05-05 11:21:07 +02:00
bae7203f42
FIX: proper category > subcategory order in List-Id description header
2018-05-05 01:51:53 +02:00
4c9f6e192f
Version bump to v2.0.0.beta9
2018-05-04 15:32:22 -04:00
c81854ad14
FEATURE: Rename discourse-cronos to discourse-local-dates
2018-05-04 16:11:50 +10:00
3d6dc764be
needed to remove legacy from a few more spots
2018-05-04 11:12:01 +10:00
62a8904729
Feature: Include participants at the bottom of PM emails ( #5797 )
...
* Feature: Include participants at the bottom of PM emails
... as undecorated links.
https://meta.discourse.org/t/email-notification-recipients-unclear-when-pm-is-sent-to-multiple-users/26934/13?u=featheredtoast
Fix: missing translation for PM mentions
* display membership count as `group (count)`
2018-05-03 15:50:06 -07:00
eca7017a2b
Version bump to v2.0.0.beta8
2018-05-03 16:57:15 -04:00
78435833a5
FEATURE: discourse-cronos is now a core plugin
2018-05-03 20:15:57 +02:00
7d223c0e55
FEATURE: add description in 'List-Id' mail headers
...
https://meta.discourse.org/t/minor-feature-request-descriptions-in-list-id-headers/86681
2018-05-03 16:39:25 +02:00
980972182f
dashboard next: caching, mobile support and new charts
2018-05-03 15:41:41 +02:00
2d561a0422
FIX: don't extract divs with a 'gmail_default' class
2018-05-03 12:29:21 +02:00
b7037808bb
PERF: stop using exec which is blocking for direct sql
2018-05-03 15:50:30 +10:00
a2bc2ca08f
Set catogory text_color for box style
2018-05-02 16:57:35 +10:00
3be3c50c7e
FEATURE: Rename user in mentions and quotes
...
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2018-05-01 13:49:14 -04:00
1eee517ae2
adds moment-timezone.js to the list of vendorable libs
2018-05-01 16:00:05 +02:00
691174fa8f
FEATURE: adds emoji search aliases
2018-05-01 15:43:49 +02:00
9e7150a2ad
Revert "add a few emoji aliases"
...
This reverts commit d942bf6282
2018-05-01 11:04:26 +02:00
d942bf6282
add a few emoji aliases
2018-05-01 15:07:59 +10:00
93b40d5e59
Don't use `puts` here since it happens in tests
2018-04-30 12:26:43 -04:00
f7c4c71409
FIX: title selector needs to flag whether title comes from badge or not
2018-04-26 16:51:11 -04:00
00a0a9ac52
Merge pull request #5791 from yanokwa/patch-1
...
Correct spelling errors
2018-04-26 13:02:55 -07:00
e52d914c08
add discourse-user-card-badges to official plugins
2018-04-26 15:28:06 -04:00
02cd035164
Correct spelling errors
2018-04-26 09:46:32 -07:00
0732c69f73
updates moment.js 2.22.1 and vendor moment-timezone 0.5.14
2018-04-26 09:15:53 +02:00
88f5251415
FIX: disallow invalid top_menu and post_menu and share_links
...
In the past any text could be entered there causing big potential issues
2018-04-26 17:00:56 +10:00
c7a0ced656
FIX: remove facebook_request_extra_profile_details
...
Since this no longer works
2018-04-26 14:14:35 +10:00
98d142b1c1
also causes test failure, removing
2018-04-26 13:48:44 +10:00
0a82d739f9
unofficialize plugin
2018-04-26 13:23:14 +10:00
4ded5e18e6
add more official plugins
2018-04-26 12:33:07 +10:00
a5172a37e0
Allow staff members to enable safe mode, even if disabled
2018-04-25 11:49:57 -04:00
afe1a2793d
Mark discourse-signatures plugin as official
2018-04-25 11:58:39 +02:00
0e38481d6d
Add docker_manager to official plugin list.
2018-04-25 13:02:50 +08:00
aad7df2a1b
correct return value
2018-04-25 08:44:07 +10:00
18c27883e9
Version bump to v2.0.0.beta7
2018-04-24 11:13:52 -04:00
035312d501
FIX: specify path for dosp cookie
2018-04-24 11:07:58 -04:00
bf6e548692
Remove plugin that is internal to us.
2018-04-24 11:07:49 -04:00
42a848f88f
linting
2018-04-23 10:26:33 +02:00
69c32a2651
Refresh site settings after a remap
2018-04-23 09:57:13 +02:00
c148500d51
FIX: Deadlock when topic with auto close topic timers exceeds `auto_close_topics_post_count`.
2018-04-23 13:34:24 +08:00
6a0aeae91b
DEV: clean up JavaScript testing
...
- Unify runner for autospec and qunit:test
- Report on slowest 30 tests
- Use async await instead of promise tower
2018-04-23 14:43:04 +10:00
ded84a4b58
PERF: improve performance once logged in rate limiter hits
...
If "logged in" is being forced anonymous on certain routes, trigger
the protection for any requests that spend 50ms queueing
This means that ...
1. You need to trip it by having 3 requests take longer than 1 second in 10 second interval
2. Once tripped, if your route is still spending 50m queueuing it will continue to be protected
This means that site will continue to function with almost no delays while it is scaling up to handle the new load
2018-04-23 11:55:25 +10:00
80847d83a8
Mark `discourse-voting` and `discourse-staff-notes` as official.
2018-04-23 09:26:13 +08:00
Guo Xiang Tan
David Taylor
Guo Xiang Tan
Kyle Zhao
Gerhard Schlager
Neil Lalonde
Rishabh
Blake Erickson
Joshua Rosenfeld
Sam
Vinoth Kannan
Maja Komel
Osama Sayegh
Joffrey JAFFEUX
Dax74
Bianca Nenciu
Arpit Jalan
Régis Hanol
Robin Ward
Bianca Nenciu
Jay Pfaffman
Jeff Atwood
Penar Musaraj
Jeff Wong
Jay Pfaffman
Nick Shearer
Rishabh
Andrew Schleifer
Patrick Gansterer
Kasia Bułat
misaka4e21
David Lee
Michael Brown
Michael Brown
Ryan Mulligan
Matt Palmer
scossar
Yaw Anokwa