Commit Graph

15558 Commits

Author SHA1 Message Date
Vinoth Kannan 035f96d25f Allow linked images inside table cells in HTML to Markdown conversion 2017-12-23 22:48:39 +05:30
Kris a7a0cba45b UX: Fixing font-size issue on /categories 2017-12-22 22:02:33 -05:00
Kris e84fb9ba4d UX: Fixing an issue where category names were too large on /categories 2017-12-22 21:22:12 -05:00
Régis Hanol 779efd9235 FIX: don't set properties on destroyed components 2017-12-22 20:33:33 +01:00
Robin Ward ea9c1e5cf8 Add extensibility endpoints for clicking on topic list item rows 2017-12-22 14:01:17 -05:00
Vinoth Kannan 3ae9d91d86 UX: Use tight list by default in HTML to Markdown conversion 2017-12-22 21:34:55 +05:30
Vinoth Kannan ac1e93e82a Minor fix to correctly trim spaces in HTML to Markdown conversion 2017-12-22 19:05:40 +05:30
Joffrey JAFFEUX 315b9d796d
select-kit refactoring
* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows
2017-12-22 13:08:12 +01:00
Vinoth Kannan 4935ae4338 Remove unwanted spaces between HTML tags and support Word documents 2017-12-22 09:28:24 +05:30
Kris e667434bb3 UX: Cleaning up a few admin styles 2017-12-21 17:13:06 -05:00
Kris fc2f948a39 UX: user menu-panel icons too large 2017-12-21 16:31:45 -05:00
Robin Ward 69a90f31fb FEATURE: Allow Forums to disable the Backups feature 2017-12-21 15:22:04 -05:00
Kris 9a514e6a26 UX: Fixing mobile post action size 2017-12-21 14:47:58 -05:00
Robin Ward 2908aab0da Allow extensibility on username route format (non-english usernames) 2017-12-21 14:32:51 -05:00
Kris dea3e84f18 UX: Reducing number of font-sizes used in common 2017-12-21 12:59:19 -05:00
Gerhard Schlager 7b58afe677 FIX: ProcessPost job failed for posts that have no user 2017-12-21 14:45:59 +01:00
Gerhard Schlager 727a45185d FIX: regex should behave the same in Ruby and Postgres 2017-12-21 11:26:56 +01:00
Vinoth Kannan 129d924c0d Dont support single row or column tables in HTML to Markdown conversion 2017-12-21 12:58:57 +05:30
Guo Xiang Tan 6ecf37c482 Improve URL validation to check for a valid host.
Parsing a URL with `URI` is not sufficient as the following cases
are considered valid:

URI.parse("http://https://google.com")
=> #<URI::HTTP http://https//google.com>
2017-12-21 13:50:15 +08:00
Sam 62a27f9d57 FEATURE: warn if attempting to mention a group with too many members 2017-12-21 16:13:57 +11:00
Sam 081959227d FIX: unicode titles missing when visiting topic from topic list 2017-12-21 15:20:47 +11:00
Kris 7b0f3f4e34 FIX: only staff highlight main post, not embedded replies 2017-12-20 21:26:24 -05:00
Sam 252cbd8635 FIX: keyboard shortcut allowed you to open composer on closed topics 2017-12-21 13:09:18 +11:00
Sam 2423b18839 FIX: links inside quotes not opening in new tab 2017-12-21 13:00:20 +11:00
Sam 6bf3bee473 FIX: when leaving PM tab revert to user scoped search 2017-12-21 12:30:41 +11:00
Sam e756d02088 FIX: create topic keyboard shortcut not checking permissions 2017-12-21 11:23:57 +11:00
Sam 88a4ec5f1b FIX: stop forking regular backup jobs 2017-12-21 09:00:48 +11:00
Kris 4bf558f941 UX: Reducing number of overall font sizes 2017-12-20 15:57:49 -05:00
Gerhard Schlager ac7e6dab06 FIX: Refreshing Gravatar didn't work 2017-12-20 20:49:58 +01:00
Régis Hanol 7f69362d9d FIX: external links in whisper ended up in a white page
FIX: clicking a link in a onebox wasn't properly extracting the post_id
2017-12-20 17:55:15 +01:00
Joffrey JAFFEUX 6e1dd12390
FIX: load tracked/watched/muted categories on screen loading 2017-12-20 16:13:33 +01:00
Vinoth Kannan ac1d3a761e Support for table & ol tags for HTML pasting in composer 2017-12-20 19:24:55 +05:30
Gerhard Schlager 86c86a1ddb FIX: prevent loading of invalid locales from plugins 2017-12-20 12:14:39 +01:00
Philipp Daniels 6a2bce1931 FIX: Data loss on update of single user_field.
https://meta.discourse.org/t/api-data-loss-caused-by-changed-behaviour-of-custom-user-field-update/74990
2017-12-20 16:33:23 +08:00
Guo Xiang Tan 87c334c063 Fix randomly failing JS acceptance tests. 2017-12-20 11:04:47 +08:00
Sam 7aa56fc9d9 refinement and test for batch mode on feature_topics 2017-12-20 13:58:05 +11:00
Neil Lalonde f5a3be750c PERF: add option to limit how many categories are processed in one call to CategoryFeaturedTopic.feature_topics (#5446) 2017-12-20 13:42:29 +11:00
Arpit Jalan eab66065d1 FEATURE: search log term details page (#5445) 2017-12-20 13:41:31 +11:00
Robin Ward 2735914cf6 FIX: ESlint 2017-12-19 17:55:41 -05:00
Kris d90fc415a1 UX: Reducing number of font sizes used in mobile view 2017-12-19 17:40:08 -05:00
Robin Ward b3fda0ea86 FIX: details tags broke excerpts 2017-12-19 17:28:55 -05:00
Robin Ward c1716d41c7 Add some plugin outlets to the user card 2017-12-19 15:04:54 -05:00
Kris bb2c8b605e UX: Reducing number of different fonts used in Admin 2017-12-19 13:10:38 -05:00
Vinoth Kannan 6272f35eec blockquote tag support for HTML pasting in composer 2017-12-19 20:59:55 +05:30
Régis Hanol 24e89b6b38 FIX: validates 'ThemeField' name when used in a SCSS variable 2017-12-19 16:10:44 +01:00
Gerhard Schlager 84c975e3a5 CRLF caused problems with launch script 2017-12-19 13:55:17 +01:00
blokovi 0df1c85fd3 FEATURE: Serbian translation (#5443) 2017-12-19 12:26:06 +01:00
Sam 9472821331 Allow plugins to specify custom nav items on mobile 2017-12-19 16:50:25 +11:00
Sam 57a1190b07 FIX: correct issue with search omitting words with multiple dots
Previously we used to break up words with dots incorrectly leading to
missing search terms
2017-12-19 16:04:24 +11:00
Sam e63a2487e3 UX: allow for iPhone X in iOS Hacks 2017-12-19 15:20:06 +11:00
Guo Xiang Tan 30ddc1f222 Don't swallow errors when failing to create message for post action. 2017-12-19 10:58:26 +08:00
Guo Xiang Tan b39d3a863d FIX: `moderators` group wasn't being updated to be messagable by everyone.
https://meta.discourse.org/t/custom-flag-not-showing-text/76244
2017-12-19 10:14:56 +08:00
Sam 1abc276451 FIX: properly omit inactive and silenced users from directory 2017-12-19 12:53:59 +11:00
Kris 2d9d43ed1a UX: Removing px font defintions and replacing with em 2017-12-18 15:49:11 -05:00
Vinoth Kannan 70b6030c74 FIX: IE syntax error in regular expression 2017-12-18 23:03:35 +05:30
Vinoth Kannan ad41523895 FEATURE: Converting code tags to Markdown while pasting 2017-12-18 22:12:05 +05:30
Joffrey JAFFEUX 133d97402a
FIX: prevents global input width to impact input inside emoji picker filter 2017-12-18 10:48:33 +01:00
Vinoth Kannan b9f553d45d REFACTOR: Small improvement in code for Tag.slice method 2017-12-18 13:38:47 +05:30
Vinoth Kannan 0588edbc96 FEATURE: Keep supported HTML tags in HTML to Markdown conversion 2017-12-18 12:48:17 +05:30
Guo Xiang Tan 97ceebb570 SECURITY: Don't pass email backup token to sidekiq as a parameter.
* This exposes the token in the Sidekiq dashboard which can be
  viewed by an admin and defeats the purpose of using a token
  in the download backup email ink.
2017-12-18 11:25:22 +08:00
Sam 433ef4513b FEATURE: upload images and fonts in themes via hijack 2017-12-18 10:40:10 +11:00
Sam 5e90abfaea FIX: use hijack for emoji uploads 2017-12-18 10:31:19 +11:00
Vinoth Kannan b963307f30 FIX: IE compatability issue in clipboard files array 2017-12-17 12:04:16 +05:30
Joffrey JAFFEUX 7f89f8aa3f
FIX: reset scroll position when switching tab in edit category modal 2017-12-16 20:46:22 +01:00
Vinoth Kannan 4f2f42d710 PERF: Better handling of headings in HTML inline pasting 2017-12-17 00:45:21 +05:30
Régis Hanol 8175740e87 UX: don't shown the 'staff-counters' div when there's no counter 2017-12-16 13:16:23 +01:00
Régis Hanol 50487d6122 FIX: wasn't able to recover a post 2017-12-16 13:04:20 +01:00
Neil Lalonde e73556f48f FIX: disable New Topic button if filtered to a tag and a category that you don't have permission to post in 2017-12-15 13:42:29 -05:00
Kris 065c155f81 UX: Increasing line-height for headlines in all post content 2017-12-15 11:29:15 -05:00
Guo Xiang Tan 5489cd14c7 Skip validations when fixing `Topic#featured_link` in onceoff job. 2017-12-15 23:45:07 +08:00
Vinoth Kannan dc159d7fa6 Grab dimention of the clipboard images 2017-12-15 17:28:38 +05:30
Vinoth Kannan 9cd48207f2 make eslint happy 2017-12-15 17:08:17 +05:30
Vinoth Kannan 236ecec0b0 Skip HTML pasting if image upload available 2017-12-15 16:40:40 +05:30
Guo Xiang Tan 91e84433ff Take two at fixing JS tests. 2017-12-15 15:46:09 +08:00
Vinoth Kannan 5c3ef7875f FIX: Inline head tag html pasting 2017-12-15 12:00:17 +05:30
Vinoth Kannan bfafca42b7 fix eslint and refactor code 2017-12-15 11:07:50 +05:30
Vinoth Kannan f0497ee9c4
FEATURE: HTML to Markdown conversion using native JavaScript ES6 classes (#5425) 2017-12-15 10:28:20 +05:30
Régis Hanol b91f83eb7d Ignore auto-quote/reply when counting replies 2017-12-15 00:38:14 +01:00
Sam f18dda2adc FEATURE: full rebake of all old posts
This limits to 100 post per 15 minutes, so it will take a while.

This will pick up CommonMark and a large amount of onebox fixes.
2017-12-15 10:28:25 +11:00
Régis Hanol 092c976d7c FIX: prevent 💥 when selecting replies to posts quoting themselves 2017-12-15 00:23:51 +01:00
Régis Hanol 2f792bc59f FIX: a topic should be visited when you've read everything and there's deleted posts at the end 2017-12-15 00:00:48 +01:00
Robin Ward 4fcf9ece3a Allow plugins to customize the columns returned by user_actions
This is useful if they have a different mechanism for rendering an
avatar and want to include custom columns via the `custom_avatar_column`
plugin function.
2017-12-14 16:52:54 -05:00
Neil Lalonde 3cbaea81bd
Merge pull request #5428 from discourse/fix-pending-users-count
FIX: incorrect pending_users_reminder user count
2017-12-14 14:05:37 -05:00
Joffrey JAFFEUX 3090c016d0
FIX: do not display used categories as selectable in categories notifications preferences 2017-12-14 14:40:08 +01:00
Joffrey JAFFEUX 5e1545fb7f
FIX: make sure scrollbar don’t appear 2017-12-14 14:23:40 +01:00
Joffrey JAFFEUX 001abfc4cb Revert "FIX: not permitted theme params when importing theme"
This reverts commit 813df1a3fb.
2017-12-14 11:40:14 +01:00
Joffrey JAFFEUX 041deac67a Revert "FIX: constant lookup error when exporting theme"
This reverts commit 1eda8c50f0.
2017-12-14 11:40:08 +01:00
Joffrey JAFFEUX 813df1a3fb
FIX: not permitted theme params when importing theme 2017-12-14 11:25:58 +01:00
Joffrey JAFFEUX 1eda8c50f0
FIX: constant lookup error when exporting theme 2017-12-14 11:25:11 +01:00
Joffrey JAFFEUX 28a63135b8
FIX: set a default color scheme when creating a new one 2017-12-14 08:21:56 +01:00
Guo Xiang Tan f2565f6c7e SECURITY: Any group can be invited into a PM. 2017-12-14 14:57:48 +08:00
Sam 14cfce2827 Merge branch 'master' of github.com:discourse/discourse 2017-12-14 17:17:02 +11:00
Sam 96584403cd SECURITY: prevent staged accounts from changing email 2017-12-14 17:16:49 +11:00
Guo Xiang Tan 34342ad0d8 FIX: `User#user_avatar` may be nil. 2017-12-14 13:23:03 +08:00
scossar 11050e5d10 Don't override count value that has been set by query.count 2017-12-13 18:48:46 -08:00
Maja Komel 52e38e5527 FIX: save whisper drafts (#5417) 2017-12-14 11:35:08 +11:00
Régis Hanol 5db3d39b05 FIX: Post.reply_ids should also handle quotes 2017-12-14 00:43:48 +01:00
Régis Hanol 53bbf08ea1 FIX: wasn't redirected to group inbox 2017-12-13 23:31:20 +01:00
Régis Hanol c63ecd87f2 FIX: ensure we're always changing 1 post ownership 2017-12-13 22:45:14 +01:00
Maja Komel 0f4ed2e070 display language name in user locale selector - make it consistent with admin (#5424) 2017-12-14 08:17:36 +11:00
Régis Hanol 1b4483c942 FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts 2017-12-13 22:12:06 +01:00
Neil Lalonde 712c9fca1b sorry rubocop 2017-12-13 15:47:42 -05:00
Neil Lalonde 3f1d6a302e FIX: links with query params to external sites fail to load if ga universal auto link domains is used 2017-12-13 13:58:44 -05:00
Joffrey JAFFEUX 8001f68c32
FIX: make sure we don’t show scrollbars on toolbar-popup-menu 2017-12-13 19:01:30 +01:00
Joffrey JAFFEUX e42812fcf7
FIX: make sure new badges have a default type 2017-12-13 10:55:16 +01:00
Joffrey JAFFEUX c1c31b99ce
Replaces toolbar popup-menu with select-kit 2017-12-13 10:49:32 +01:00
Guo Xiang Tan d5293aeae2 Clean `Topic#slug` when `SiteSetting.slug_generation_method` changes.
https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld
2017-12-13 16:11:07 +08:00
Sam 9d925f6b26 FIX: correctly count participants when more than 24
Also cuts out one query for the normal case
2017-12-13 17:19:42 +11:00
Sam b998efdc94 FIX: do not send mailing list emails to unapproved users 2017-12-13 15:13:17 +11:00
Sam a393d3bcbb FIX: ensure staged accounts are always inactive
If for any reason active is stored in the user model, clear it out
prior to creating an account
2017-12-13 14:22:16 +11:00
Gerhard Schlager a7c1b0c81f FIX: path whitelist for embedded comments didn't work with non-ASCII chars 2017-12-12 20:17:46 +01:00
Gerhard Schlager e30851e45a Move escape_uri method to a more suitable place 2017-12-12 20:17:46 +01:00
Robin Ward 5fbfe34356 FIX: Moderation History wasn't working from timeline admin button 2017-12-12 12:21:10 -05:00
Kris 1be32bf4cf FIX: text indent on twitter oneboxes 2017-12-12 11:17:09 -05:00
Kris d6a18f72b6 UX: Mobile user profile button adjustment 2017-12-12 10:58:03 -05:00
Kris 55c019f776 UX: Cleaning up staff counters on user profiles 2017-12-12 10:40:16 -05:00
Arpit Jalan 492af81e67 FIX: save registration_ip_address for staged users logging in via social auth 2017-12-12 17:41:16 +05:30
Guo Xiang Tan e2b64257b3 Fix undefined method for `NilClass` error. 2017-12-12 18:54:29 +08:00
Régis Hanol af3c153687 make robocop 🤖 happy 2017-12-12 11:33:35 +01:00
Régis Hanol 62a5b174e1 FIX: wasn't able to use the same username when taking over a staged account 2017-12-12 11:26:00 +01:00
Arpit Jalan b014540fde FIX: view was getting rendered twice for rate limiting error 2017-12-12 14:48:58 +05:30
Kris 920571ae07 UX: Making button on advanced search page match input height 2017-12-11 17:15:08 -05:00
Kris 60cd28d5b9
UX: Cleaning up user profiles on mobile 2017-12-11 15:40:04 -05:00
Vinoth Kannan c17a28f875 Using const instead of var while declaring 2017-12-11 14:26:21 +05:30
Guo Xiang Tan 4bd5acec47 FIX: `Topic#featured_link` may contain more than a URL. 2017-12-11 16:36:19 +08:00
Arpit Jalan 3c56c9b637 FIX: strip webhook payload_url 2017-12-11 13:48:11 +05:30
Arpit Jalan 3c230d8f97 FIX: 'redirect_to :back' is deprecated 2017-12-11 12:18:19 +05:30
Kris edd7cb4f0d UX: Replacing some PX font definitions with EM based units 2017-12-08 17:10:49 -05:00
Robin Ward b3bdc68639 UX: Add link to "Moderation History" to flagging interface 2017-12-08 15:48:32 -05:00
Vinoth Kannan fdef4e58f0 Skip markdown table conversion from rich text feature flag setting 2017-12-08 18:30:38 +05:30
Vinoth Kannan b9c0488687 New site setting to enable or disable rich text pasting 2017-12-08 14:09:39 +05:30
Vinoth Kannan 0a47642003 FIX: Pasted text removing if server unable to parse HTML to Markdown 2017-12-08 13:38:54 +05:30
Sam cff9b8846d FIX: rendering %lt;/div noscript in header 2017-12-08 10:30:00 +11:00
Robin Ward 74b9828731 FIX: Remove mentions filters from user and groups
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX fd99e1ef56 FEATURE: site setting enable_mentions to turn on/off mentions 2017-12-07 16:27:58 -05:00
Kris 3e4f02a180 UX: Removing staff highlight from .name so it only applies to .user-title 2017-12-07 16:10:54 -05:00
Kris 6d5e5629f6 FIX: Choices input layout bug in IE11 2017-12-07 15:49:54 -05:00
Robin Ward 3cf4886d3e UX: Add a class name to target the embedded post controls 2017-12-07 15:01:34 -05:00
Kris f7c77171b9 UX: Eliminating a "sweet spot" at 870px viewport where the topic-body exceeds 690px wide 2017-12-07 14:32:31 -05:00
Robin Ward aeebcef7e2 FIX: Don't show the email from the suspension on the user profile 2017-12-07 13:27:02 -05:00
Robin Ward 4ae1bbaeba FIX: Only show the full suspension reason on the admin side 2017-12-07 13:27:02 -05:00
Kris ef0d9d631c
UX: New style for staff highlight
Moved highlight to cooked content, also highlighting primary name (with shield) and title (if applicable). 

**Before**:
![image](https://user-images.githubusercontent.com/1681963/33724323-2269e79e-db3d-11e7-8c93-75b9dc9a1ab7.png)


**After**:
<img width="809" alt="screen shot 2017-12-06 at 3 55 31 pm" src="https://user-images.githubusercontent.com/1681963/33724287-09eb66de-db3d-11e7-8e02-0062ed2b8716.png">
2017-12-07 12:40:39 -05:00
Kris 282633bc97 FIX: New topic composer layout in iOS10 2017-12-07 12:04:39 -05:00
Vinoth Kannan be848b8a5c FIX: Image pasted twice when it copied from browser 2017-12-07 21:23:31 +05:30
Vinoth Kannan 5cceb95f92 Improvement in composer HTML pasting 2017-12-07 21:13:09 +05:30
Vinoth Kannan 858cd3a589 Improvement in composer HTML pasting 2017-12-07 21:08:08 +05:30
Arpit Jalan c168c5895f
Merge pull request #5407 from techAPJ/show-inactive-accounts
FEATURE: new site setting show_inactive_accounts
2017-12-07 20:52:37 +05:30
Maja Komel cce077de56 move /tags/ topics list out of footer (#5405) 2017-12-07 15:25:04 +01:00
Arpit Jalan 5003f07b2c FEATURE: new site setting show_inactive_accounts 2017-12-07 19:22:41 +05:30
Joffrey JAFFEUX f0ef307d2d
FIX: topic timer offset applied two times
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.

This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1  hour to your timezone offset.
2017-12-07 14:42:58 +01:00