Commit Graph

33 Commits

Author SHA1 Message Date
Gerhard Schlager 0f3c3bc309 Make import scripts work with frozen strings 2019-05-30 22:22:24 +02:00
Sam Saffron 7429700389 FIX: ensure we can download maxmind without redis or db config
This also corrects FileHelper.download so it supports "follow_redirect"
correctly (it used to always follow 1 redirect) and adds a `validate_url`
param that will bypass all uri validation if set to false (default is true)
2019-05-28 10:28:57 +10:00
Sam Saffron 30990006a9 DEV: enable frozen string literal on all files
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
Gerhard Schlager 74ca49d7cd FIX: Importing of polls from phpBB3 was broken
Follow-up to 24369a81
2019-05-06 12:37:19 +02:00
Penar Musaraj 9334d2f4f7
FEATURE: add more granular user option levels for email notifications (#7143)
Migrates email user options to a new data structure, where `email_always`, `email_direct` and `email_private_messages` are replace by

* `email_messages_level`, with options: `always`, `only_when_away` and `never` (defaults to `always`)
* `email_level`, with options: `always`, `only_when_away` and `never` (defaults to `only_when_away`)
2019-03-15 10:55:11 -04:00
Gerhard Schlager 24369a8166 Improve phpBB3 importer
* Log errors when mapping of posts, messages, etc. fails
* Allow permalink normalizations for old subfolder installation
* Disable importing of polls for now. It's broken.
2019-02-17 23:20:20 +01:00
Neil Lalonde 1ba8e8948d FIX: add support for string avatar_type values in PHPBB3 importer 2018-06-07 18:14:11 -04:00
Régis Hanol dad1e4b17d don't import data only available in a plugin in phpBB 3 importer 2018-03-17 00:36:12 +01:00
Régis Hanol bb6ac51607 Update PHPBB3 importer
- Extract name from profile_fields_data table
- Use 'posts.poster_ip' to track topic views
2018-03-16 18:32:27 +01:00
Régis Hanol 07bc52dc69 import topic views in phpbb3 2018-03-07 19:27:03 +01:00
Guo Xiang Tan 5012d46cbd Add rubocop to our build. (#5004) 2017-07-28 10:20:09 +09:00
Gerhard Schlager 32ef30cff9
phpBB3 importer: Permalink for first post of each topic was missing 2017-07-25 23:29:56 +02:00
Gerhard Schlager 5be52fa821
phpBB3 importer: Use permalink normalization for category links 2017-07-25 21:14:46 +02:00
Robin Ward cdbe027c1c Refactor `FileHelper` to use keyword arguments. 2017-05-24 13:54:26 -04:00
Robin Ward 71414f7ba2 We don't need to log downloading avatars that are too large 2017-05-09 14:46:42 -04:00
Gerhard Schlager 14a0dff469
phpBB3 importer: Fix import of anonymous users 2017-02-05 15:26:50 +01:00
Gerhard Schlager 37a78752e9 phpBB3 importer: fixes for internal links and guest users (#4350)
* phpBB3 importer: ignore query parameters in internal links

* phpBB3 importer: Don't fail if guest usernames differ only by case

* phpBB3 importer: Import username as name for guest users
2016-07-27 22:57:33 +02:00
Gerhard Schlager c145e747b6 A few small changes to the phpBB3 importer (#4321)
* Reconnect to phpBB3 database on connection loss

* Map geek smiley to :nerd: emoji in phpBB3 importer

* Import PMs to yourself from phpBB3

* Allow empty table prefix in phpBB3 importer
2016-07-11 23:59:15 +02:00
Gerhard Schlager 0227658515 Make phpBB3 importer compatible with latest poll plugin changes (#4253) 2016-06-06 22:59:33 +02:00
Gerhard Schlager 2e1cc061d8
Make sure PMs imported from phpBB3 are only visible to the correct users
In addition this tries to automatically fix PMs that were migrated
from phpBB2 to phpBB3.
2016-05-26 20:27:08 +02:00
Gerhard Schlager a796289b3a
Fix import of polls from phpBB3 2016-04-23 23:03:50 +02:00
Gerhard Schlager 91b5ea4113
Make permalink import from phpBB3 configurable
There are a few changes to the original permalink import:
- adds permalinks for posts
- does not create incorrect permalinks for private messages
- adds permalink normalizations for topics and posts
2016-04-09 22:36:45 +02:00
Guo Xiang Tan 0172684719 Some fixes for phpbb importer. 2016-03-01 10:21:54 +08:00
Guo Xiang Tan 9e46690086 Add Permalink to phpbb3 import script. 2016-02-29 11:48:43 +08:00
Gerhard Schlager 1164129edc Better error handling for polls imported from phpBB3 2016-01-13 22:57:57 +01:00
Gerhard Schlager bed9135f40 Failed file upload shouldn't crash phpBB3 importer 2016-01-13 22:56:45 +01:00
Neil Lalonde 91fdfa986f Merge pull request #3823 from gschlager/phpbb3-importer
FIX: phpBB3 importer failed to import users
2015-10-07 19:08:05 -04:00
Gerhard Schlager a3afdba59e FIX: phpBB3 importer should ignore invalid birthdates 2015-10-06 21:08:54 +02:00
Gerhard Schlager a03ead9767 FIX: phpBB3 importer failed to import users
FEATURE: Skip batches if posts or messages exists
2015-09-30 17:56:37 +02:00
Kane York 821124f3fd FEATURE: Skip batches if all records exist
Update all import scripts to take advantage of all_records_exist?
2015-09-21 17:13:02 -07:00
Gerhard Schlager 8c03dd16af Adds support for importing password hashes used by "migratepassword" plugin
Adds setting to phpBB3 importer for importing passwords (default: off)
Plugin: https://github.com/discoursehosting/discourse-migratepassword
2015-08-20 22:22:47 +02:00
Gerhard Schlager cbb0fc350d Fixes some minor issues with the phpBB3 importer
FEATURE: Adds a link to the Howto on meta
FIX: Suppresses multiple warnings about invalid votes for the same topic
FIX: Adds missing table prefixes
FIX: Removes duplicate column from query
2015-07-27 23:02:45 +02:00
Gerhard Schlager 1cb45861c5 FEATURE: Lots of improvements to the phpBB3 importer
- Extensive refactoring of the existing importer
- Configuration of import with settings.yml instead of editing code
- Supports importing from phpBB 3.0.x and 3.1.x
- Imports all attachments (not just the ones embedded with [attachment])
  from posts and private messages
- Imports all existing attachments without the need to configure allowed
  file extensions or file sizes
- Imports polls
- Imports bookmarks
- Imports sticky topics and (global) announcements as pinned topics
- Imports categories in the original order and sets the content of the
  category description topic
- Sets the creation date of category description topics to the creation
  date of the first topic in each category
- Imports additional user attributes: last seen date, registration
  IP address, website, date of birth, location
- Optionally set the user's name to its username
- Users that didn't activate their account in phpBB3 are imported as
  inactive users
- All imported, active users are automatically approved
- Users that were deactivated in phpBB3 get suspended for 200 years
  during the import
- Anonymous user can be imported as suspended users instead of the
  system user
- Forums of type "link" are not imported as categories anymore
- Internal links to posts get rewritten during the import (previously
  only links to topics got rewritten)
- Ordered lists with BBCode [list=a] (which are unsupported in
  Discourse) get imported as if they would be [list=1]
- Importing of avatars, attachments, private messages, polls and
  bookmarks can be disabled via configuration file
- Optional fixing of private messages for forums that have been upgraded
  from phpBB2 prevents the import of duplicate messages and tries to
  group related messages into topics
- Table prefix (default: phpbb) is configurable
- Most of phpBB's default smilies are mapped to Emojis and all other
  smilies get uploaded and embedded as images. Smiley mappings can be
  added or overridden in the settings.yml file.
2015-07-16 15:28:43 +02:00