discourse

Commit Graph

Author	SHA1	Message	Date
Gerhard Schlager	caa0247f5c	FIX: Incorrect `currentUser` could be cached for requests with API key (#17279 ) This happened when a middleware accessed the `currentUser` before a controller had a chance to populate the `action_dispatch.request.path_parameters` env variable. In that case Discourse would always cache `nil` as `currentUser`.	2022-07-01 10:18:24 +02:00
David Taylor	1cec333f48	REFACTOR: Introduce RouteMatcher class This consolidates logic used to match routes in ApiKey, UserApiKey and DefaultCurrentUserProvider. This reduces duplicated logic, and will allow UserApiKeysScope to easily re-use the parameter matching logic from ApiKeyScope	2020-10-19 10:40:55 +01:00

Author

SHA1

Message

Date

Gerhard Schlager

caa0247f5c

FIX: Incorrect `currentUser` could be cached for requests with API key (#17279 )

This happened when a middleware accessed the `currentUser` before a controller had a chance to populate the `action_dispatch.request.path_parameters` env variable. In that case Discourse would always cache `nil` as `currentUser`.

2022-07-01 10:18:24 +02:00

David Taylor

1cec333f48

REFACTOR: Introduce RouteMatcher class

This consolidates logic used to match routes in ApiKey, UserApiKey and DefaultCurrentUserProvider. This reduces duplicated logic, and will allow UserApiKeysScope to easily re-use the parameter matching logic from ApiKeyScope

2020-10-19 10:40:55 +01:00

2 Commits