discourse

Commit Graph

Author	SHA1	Message	Date
Alan Guo Xiang Tan	41f8bff2c3	DEV: Remove superfluous `js: true` metadata (#21960 ) Why this change? It is very unlikely that we need to ever JS for system tests considering that we rely on a JS framework on the frontend.	2023-06-07 09:26:58 +08:00
Alan Guo Xiang Tan	7ef2eaa892	DEV: Fix system test assertion to avoid stale element reference error (#21944 ) What is this change required? We were seeing this error on CI ``` 1) Fast edit when editing text that has strange characters saves when paragraph contains apostrophe Failure/Error: expect(find("#{topic_page.post_by_number_selector(2)} .cooked p")).to have_content( "It ‘twas a great’ “day”!", ) Selenium::WebDriver::Error::StaleElementReferenceError: stale element reference: stale element not found (Session info: chrome=114.0.5735.90) ``` I believe this is because the element that is "found" using `find` is eventually re-rendered before the `have_content` matcher is called on it.	2023-06-06 15:43:49 +08:00
David Battersby	0a619d8c88	FIX: Fast edit doesn’t work on content with certain characters (#20410 ) Small js fix for fast edit to allow posts to save changes when the post contains apostrophes and quotation marks. Replaces unicode characters in text prior to saving the edit. Includes system tests for fast edit and introduces a new system spec component for fast edit usage.	2023-02-23 11:30:16 +08:00

Author

SHA1

Message

Date

Alan Guo Xiang Tan

41f8bff2c3

DEV: Remove superfluous `js: true` metadata (#21960 )

Why this change?

It is very unlikely that we need to ever JS for system tests considering
that we rely on a JS framework on the frontend.

2023-06-07 09:26:58 +08:00

Alan Guo Xiang Tan

7ef2eaa892

DEV: Fix system test assertion to avoid stale element reference error (#21944 )

What is this change required?

We were seeing this error on CI

```
  1) Fast edit when editing text that has strange characters saves when paragraph contains apostrophe
     Failure/Error:
       expect(find("#{topic_page.post_by_number_selector(2)} .cooked p")).to have_content(
         "It ‘twas a great’ “day”!",
       )

     Selenium::WebDriver::Error::StaleElementReferenceError:
       stale element reference: stale element not found
         (Session info: chrome=114.0.5735.90)
```

I believe this is because the element that is "found" using `find` is
eventually re-rendered before the `have_content` matcher is called on
it.

2023-06-06 15:43:49 +08:00

David Battersby

0a619d8c88

FIX: Fast edit doesn’t work on content with certain characters (#20410 )

Small js fix for fast edit to allow posts to save changes when the post contains apostrophes and quotation marks. Replaces unicode characters in text prior to saving the edit.

Includes system tests for fast edit and introduces a new system spec component for fast edit usage.

2023-02-23 11:30:16 +08:00

3 Commits