91238af6f1
correct failing specs
2013-07-08 12:25:38 +10:00
25d2cbc33f
Merge branch 'master' of github.com:discourse/discourse
2013-07-05 16:52:27 -04:00
1c0e0da683
Add rss feed for latest and hot
2013-07-05 16:49:06 -04:00
6cd6484b5e
New mode for Wordpress: Filter ONLY posts liked by moderators
2013-07-05 16:07:24 -04:00
7335f5fb7f
Merge pull request #1145 from abbat/yandex-workaround
...
Workaround solution to help Yandex crawler index discourse.
2013-07-05 10:04:40 -07:00
694a6f4970
Fix recommendations from #1145
2013-07-05 15:59:39 +04:00
07ebd20776
Merge pull request #1143 from ahx/fix-cas-email-name-and-improve-authentication-specs
...
Improve the omniauth controller specs. Fix the email provided by CAS. Get name from CAS attributes.
2013-07-04 14:48:52 -07:00
af36d32f7f
Workaround solution to help Yandex crawler index discource.
...
Yandex search engine doesn't index noscript tag content. See also
http://meta.discourse.org/t/noscript-tag-and-some-search-engines/8078
2013-07-04 22:08:23 +04:00
661f2057f7
Improve the omniauth controller specs. Fix the email provided by CAS. Get name from CAS attributes.
...
* Make omniauth controller specs more robust by using shared examples for all authentication providers in controller spec. – Still passing. Yay!
* Return "casuser", instead of "casuser@" when no cas_domainname is configured.
* If no cas_domainname is configured, the CAS authentication would return "casuser@" for the users email field, because it tried to assume the email adress of the CAS user by it's username + cas_domainname.
Now it just returns the username instead of adding an "@" if cas_domainname is not configured.
This especially makes sense on CAS setups where the username equals the users email adress.
The old behaviour, if cas_domainname is configured, was not changed.
* Fetch the email from CAS attributes if provided
If the cas:authenticationSuccess (handled via omniauth-cas) response gives us an email use that.
If not, behave as before (username or username@cas_domainname).
* Fetch the (full) name from CAS attributes if provided
If the CAS response by omniauth provides a [:info][:name] field, prefer this over the uid, because we want the name to be a "Full Name", instead of just a "shortname"
2013-07-04 12:01:39 +02:00
3da37506da
Back end - temporary boosting of trust levels
2013-07-03 10:30:40 +02:00
4d4a5735d2
logic to bypass trust level filter for high scoring posts
2013-07-03 12:37:17 +10:00
075ed1ab53
Refactor user blocking code; hide the Block button in admin
2013-07-02 14:42:53 -04:00
5770879472
Refactor: Move Topic Details into better objects, identity map, tests, query string filters
2013-07-02 10:36:46 -04:00
c3f64f99b3
fix up messed up routes
2013-07-02 15:21:26 +10:00
f6b850e7a4
allow skipping the validations on creation if its an api call AND skip_validations is specified
...
this allows wordpress plugin to post very very short titles or titles that would otherwise be disallowed
2013-07-02 12:23:19 +10:00
46c6949b6e
Merge pull request #1123 from stephankaag/rails4-new
...
Refactor routes in order to be compatible with Rails 4
2013-07-01 16:07:22 -07:00
e39cc464b1
Refactor routes in order to be compatible with Rails 4
2013-07-01 20:00:06 +02:00
b92e912ac9
add min replies, min score and min trust level params for wordpress
2013-07-01 21:29:45 +10:00
c1a39b5a30
Show date with year in message to banned users who try to log in
2013-06-30 12:49:34 -04:00
a352b70bfc
Permit changing my own username's case without an error saying it is already taken
2013-06-28 16:21:46 -04:00
2deaf8ef98
Custom Wordpress Serializer and Path, with Specs
2013-06-28 13:56:13 -04:00
1355c1e3b0
Fix links to uncategorized when SiteSetting.uncategorized_name is set
2013-06-27 16:16:06 -04:00
5d6ad8f39c
Show a useful message when a banned user tries to log in
2013-06-27 15:14:42 -04:00
9fd00cac65
work in progress, add custom faq link, ember router needs to know about this or the redirect trick will not work
2013-06-27 17:15:59 +10:00
89f182899f
Support for custom Privacy Policies
2013-06-26 10:59:36 -04:00
92562c2090
Merge pull request #1057 from house9/list-controller-1
...
refactor list_controller
2013-06-25 17:36:56 -07:00
4b56aa8183
Merge pull request #1089 from budnik/minor_refactorings
...
Some refactorings
2013-06-25 17:29:51 -07:00
b2d300fe0b
Add ability to give users a title. Show them under usernames beside posts. Needs love from a designer.
2013-06-25 18:39:20 -04:00
a86b35c873
Remove the access_password site setting
2013-06-25 15:05:25 -04:00
2e12eb2b62
refactor list_controller
...
- minor refactoring of actions 'category' and 'category_feed'
- fix defect in 'category' where check was for literal
string 'uncategorized' instead of SiteSetting.uncategorized_name
- major refactoring on defined topic actions
2013-06-25 08:29:00 -07:00
2722029d38
stylistic refactorings
...
w/ less syntactic sugar
2013-06-25 18:23:23 +03:00
06be760257
adds TopMenuItem model which encapsulates top_menu parsing logic
2013-06-24 10:04:18 -07:00
9778bfb749
Merge pull request #1059 from vipulnsward/fix_method_typo
...
`fake_success_reponse` => `fake_success_response`
2013-06-20 18:23:46 -07:00
1884dc8d3f
`fake_success_reponse` => `fake_success_response`
2013-06-21 01:17:35 +05:30
6c37a8f8fb
Merge pull request #1055 from vipulnsward/dedeuplicate_app_controller
...
Remove code duplication in ApplicationController
2013-06-20 09:55:09 -07:00
4ddc0825f5
Remove code duplication in ApplicationController
2013-06-20 21:17:33 +05:30
8e6a903f9b
Merge pull request #1046 from house9/admin-user-index-2
...
extract Admin::UsersController#index to its own query class
2013-06-20 07:52:22 -07:00
08df4c41cc
Merge branch 'master' of github.com:discourse/discourse
2013-06-20 17:42:29 +10:00
4a8a663a67
flagging workflow changes per http://meta.discourse.org/t/we-need-an-archive-flag-notification-button/7450
2013-06-20 17:42:15 +10:00
e0ff74ead0
extract Admin::UsersController#index to its own query class
...
- move query to its own class
- use postgres ILIKE case insensitive
- removed duplicated list of trust levels
2013-06-19 13:48:45 -07:00
e263bb3c0a
Anons should be able to see post history
2013-06-19 16:43:16 -04:00
5ef6714d48
New site setting: `minimum_topics_similar`, allows you to specify a minimum amount
...
of topics that need to be in the database before it will suggest similar topics as
a user creates a post.
2013-06-19 13:14:24 -04:00
799b402778
fix horribly broken invite code, could lead to inviting the wrong person to a conversation
2013-06-19 10:31:19 +10:00
eea00afb80
tos and privacy urls redirect based on site settings
2013-06-18 10:52:04 -04:00
b9a2469774
Merge pull request #1041 from vipulnsward/refactor_topics_controller
...
Refactor `TopicsController` and remove code duplication
2013-06-18 06:35:32 -07:00
80c42753e1
fix up find as you type for the invite into PM function
...
allow mods to remove users from a PM
2013-06-18 17:17:01 +10:00
531587c5ca
Refactor `TopicsController` and remove code duplication
2013-06-18 11:22:09 +05:30
7abb20928b
Merge pull request #1033 from chrishunt/move-dynamic-favicon-to-user
...
Move 'dynamic favicon' setting to User preference
2013-06-17 17:31:02 -07:00
7ca5ab3da3
allow api for restricted by global password sites
2013-06-17 16:09:59 +10:00
80c03b7b1e
case sensitive where it should not be
2013-06-17 15:47:18 +10:00
dd5cd1df4f
Merge pull request #1037 from ZogStriP/imagineering
...
Imagineering
2013-06-16 22:01:10 -07:00
0052e78bfe
render error when people attempt to save an invalid group name
...
hide controls when we showing an automatic group
2013-06-17 13:43:06 +10:00
b97d186cb5
automatic groups should not allow you to muck with the listed users in the group
2013-06-17 12:54:25 +10:00
dbfd40da84
order group member by username, bump up max count to 200 for now
2013-06-17 12:02:48 +10:00
6ea91b4416
remove useless upload topic direct association
2013-06-17 02:49:33 +02:00
09d3800701
Move 'dynamic favicon' from Server to User pref
2013-06-14 23:58:24 -07:00
8298a07fd9
`toggle_mute` doesn't require a param
2013-06-14 11:08:59 +05:30
e6e81efe85
correct information leak in page not found
2013-06-13 10:27:17 +10:00
77b218a142
FIX: Do not suggest similar topics from secure categories you can't see.
2013-06-12 13:45:11 -04:00
a362d62b42
Do not return mail password in EmailController
2013-06-11 16:00:13 -07:00
82b5f57e40
Make it possible to set a site setting to empty string
2013-06-11 14:31:38 -04:00
93bbe190c0
Moved Email components into a module
2013-06-10 15:34:10 -04:00
3b7d3aa487
FIX: Search wasn't using the lowercase username for finding the context.
2013-06-10 10:42:06 -04:00
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
5217602ec3
FIX: RSS paths render a 404 for missing topics.
2013-06-07 12:52:12 -04:00
b61e10f9ad
All parameters for #create in PostsController pass through strong_parameters.
...
We are now explicitly whitelisting all parameters for Post creation. A nice side-effect is that it cleans up the #create action in PostsController. We can now trust that all parameters entering PostCreator are of a safe scalar type.
2013-06-07 01:29:25 -07:00
41b0692543
Show 'waiting approval' and don't send email
...
When 'must approve users' in enabled, we don't want to send an
activation email to users after they sign up. Instead, we will show them
'waiting approval' and not take an action until their account is
approved by an admin.
2013-06-06 18:36:16 -07:00
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
8f32aed944
Only use HTML templates for the digest email.
2013-06-06 15:08:56 -04:00
62041da7e0
Handle /t/only-the-slug urls by trying to find the topic by slug (second try)
2013-06-06 14:41:37 -04:00
bac03a3369
Merge pull request #975 from jd-erreape/username_refactor
...
[WIP] Refactored user_name suggestion methods into a module
2013-06-06 08:12:29 -07:00
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
0d01c33482
Enabled strong_parameters across all models/controllers.
...
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that.
The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method.
It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
2013-06-06 00:30:59 -07:00
255a614142
keep /srv/status exposed
2013-06-06 14:40:10 +10:00
2ca734c118
Merge pull request #964 from chrishunt/exclusive-club
...
Add 'invite only' site setting
2013-06-05 16:38:47 -07:00
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
a523fa56ac
Don't require authentication for invites
2013-06-05 11:12:37 -07:00
acf147ef88
Disable OmniAuth account creation if 'invite only'
2013-06-05 11:11:02 -07:00
d432798ff8
Silently fail if user tries to sneak in
...
When 'invite only' is enabled, there's no way for a user to create an
account unless they try and sneak in by POSTing to /users/. We will
silently fail if this happens.
2013-06-05 11:08:21 -07:00
41528f5d11
Implemented strong_parameters for Upload/UploadsController.
...
The topic_id param is now required using strong_parameters' #require method. If the parameter is missing ActionController::ParameterMissing will be raised instead of Discourse::InvalidParameters.
2013-06-05 00:55:55 -07:00
f50b648844
Implemented strong_parameters for PostAction/PostActionsController.
...
PostActionsController now uses strong_parameters' #require to require certain parameters. ActionController::ParameterMissing is now thrown when a reqired parameter is missing, rather than Discourse::InvalidParameters.
2013-06-05 00:23:51 -07:00
3b245031a4
Implemented strong_parameters for Invite/InvitesController.
...
The email parameter is now required using strong parameters and will throw ActionController::ParameterMissing if it is missing. If the email address is incorrect or invalid, Discourse::InvalidParameters will still be thrown.
2013-06-05 00:04:03 -07:00
130d837952
Implemented strong_parameters for Category/CategoriesController.
...
Category now requires parameters to be permitted by strong_parameters using #require or #permit for mass-assignment. Missing required parameters now throw a ActionController::ParameterMissing execption instead of the Discourse::InvalidParameters execption.
2013-06-04 23:45:25 -07:00
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
913a607528
need to punch through account creation stuff
2013-06-05 14:01:24 +10:00
2dfba8d6de
we need to be able to do username checks for registration to work
2013-06-05 12:50:42 +10:00
5e305eaf0a
missing skip filter for omniauth
2013-06-05 10:30:51 +10:00
21b3359ea4
Merge pull request #957 from chrishunt/chrishunt/lock-down-the-base
...
Add 'login required' site setting
2013-06-04 17:22:08 -07:00
978785720a
Redirect to root after login if no path provided
...
If we do not do this, then people that login from /login will just be
redirected back to the login page. We'd rather have them see the root
path.
2013-06-04 16:10:10 -07:00
92a4828f72
Redirect all controllers to login if required
...
We want to skip the filter for sessions controller so that we can login
and we want to skip the filter for static pages because those should be
visible to visitors.
2013-06-04 16:10:10 -07:00
e3e55d4dad
fix image uploads on s3/imgur
2013-06-05 00:35:42 +02:00
02b1f78410
FIX: Include preloaded data even if the request type isn't explicitly text/html
2013-06-04 12:56:12 -04:00
2259e97d42
Add a count of blocked users on the dashboard
2013-06-04 11:53:19 -04:00
c4904aacc0
Automatically flag someone as a spammer if their posts get at least X spam flags from N users while their trust level is 'new user'. Staff can clear and set this status from the user record in admin.
2013-06-03 16:37:40 -04:00
545dbfc07e
New Feature: Staff can choose to "Take Action" when flagging to immediately reach hiding
...
thresholds.
2013-05-31 17:39:32 -04:00
d23ef1d090
FIX: You could update a topic to have a title that's too short if the TextCleaner
...
removed extra characters. Additionally, updating the title will not return an error
message to the client app if the operation fails (rather than failing silently.)
2013-05-31 15:24:13 -04:00
b228a7c185
Merge pull request #923 from eriko/cas_support
...
remove hardcoded value and replace with SiteSetting.cas_domainname
2013-05-30 21:39:29 -07:00
42714b424f
For 403 errors, show the same html page as 404
2013-05-30 16:39:39 -04:00
5d444be72b
Support incomplete topic urls like /t/just-a-slug; fix error when using route /t/:topic_id/:post_number
2013-05-30 10:39:15 -04:00
e93b7a3b20
more progress towards live unread and new counts, unread message implemented, still to implement delete messages
2013-05-30 16:49:57 +10:00
73834370a5
work in progress, live unread and new counts
2013-05-30 16:49:57 +10:00
364a59d344
remove hardcoded value and replace with SiteSetting.cas_domainname
2013-05-29 15:47:49 -07:00
830b93a16b
Reduced complexity of admin flags controller, split up into methods, moved reports into model.
2013-05-29 16:49:34 -04:00
b1bdebd611
url for uncategorized category topic list is always /category/uncategorized
2013-05-29 12:06:33 -04:00
92dc59fba9
Properly assign draft keys to Categories List view.
2013-05-28 21:16:24 -04:00
46389754d6
Merge pull request #892 from eriko/cas_support
...
Cas support
2013-05-28 16:13:29 -07:00
560fb15d8a
Include pinned topics in category list.
...
- removes an (n+1) query for user data
- supports the preload store for the data to avoid a second request
- fix a bug where uncategorizes was reporting (0, 0, 0) for topics by week, month, year
2013-05-28 15:36:16 -04:00
e1781240a6
Merge branch 'refactoring' of git://github.com/mattvanhorn/discourse
...
Conflicts:
lib/text_sentinel.rb
2013-05-27 10:42:20 -04:00
661ddbb158
introduce strong_parameters
2013-05-27 11:06:09 +10:00
d84ae80074
Simplify user action make it more idiomatic
2013-05-27 10:22:37 +10:00
d7817cf314
extract TopicNotifier class from topic
2013-05-24 13:36:33 -07:00
3037e9adf6
FIX: Clearing flags wasn't making topics visible again.
2013-05-24 16:03:20 -04:00
bd779834e5
Use search context for filtering search results by current category or user
2013-05-24 14:04:26 -04:00
1575ce7b10
add cas support with a few tests
2013-05-23 13:40:50 -07:00
b9a310f4b1
Search Refactor: Let's use a class to keep track of our state rather
...
than passing params everywhere. Also make the private API private.
2013-05-22 15:22:06 -04:00
0f296cd42b
Refactor + Fix: Wasn't correctly loading activity streams. Code is a lot more Ember-y now.
2013-05-22 12:06:37 -04:00
c4d8085fc5
remove moderator status posts from best feed
2013-05-22 15:04:53 +10:00
a3dce9afd7
don't error out on not posts if its a json request
2013-05-20 17:32:53 +10:00
fc57578c85
proper 404 for json request 404
2013-05-20 17:28:32 +10:00
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
80fb20816c
get rid of nonsense 404.html
...
correct 404 handling for invalid pages
2013-05-20 10:29:49 +10:00
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
a80ec535a3
Support for "Select All / Deselect All" while selecting posts to merge / delete.
2013-05-16 16:50:38 -04:00
d554a59102
Support for a new site setting: `newuser_spam_host_threshold`. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
88417725b5
we need some, albeit hacky way of clearing these old pms, make at least some way of finding them
2013-05-16 17:30:30 +10:00
21b4b8d5d5
Expire dashboard data when you upgrade to a new discourse version. Version check data was being cached and causing confusion to people who upgraded.
2013-05-14 16:17:25 -04:00
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
670b66ade3
better add some tests here tomorrow
2013-05-13 18:47:32 +10:00
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
a27046bacd
fix cache hole
2013-05-13 11:09:03 +10:00
98d9f174ae
fix spec
2013-05-13 11:07:22 +10:00
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
942f168ab6
UI still a tad rough, but we have a first pass of secure categories
2013-05-10 16:47:47 +10:00
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
f35a44aeae
Add ability for admins and mods to send another activation email to a user, to activate an account, and deactivate an account
2013-05-08 10:10:47 -04:00
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
20493106cd
fix post trashing
2013-05-07 17:56:56 +10:00
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
be1ab8b275
automatic group infrustructure
2013-05-06 14:49:56 +10:00
392b9696f4
prevent duplicate actions on a post
2013-05-04 02:52:45 +02:00
42494b5bb1
we can't trust CSRF for anon the way it is designed.
...
The page they have loaded may be cached we need a different way of delivering the CSRF potentially
2013-05-03 16:43:11 +10:00
5ec52bd2e9
:s/moderator?/staff/g ... our naming was kind of crazy, renamed moderator? to staff
2013-05-02 17:22:27 +10:00
65cd00cf25
moderators now have teeth, more at http://meta.discourse.org/t/moderator-permission-set/6307/5
...
allow pms to be targetted at groups
2013-05-02 15:15:53 +10:00
cef9a74053
route for markdown /md/topic_id/post_number
2013-04-30 16:30:41 +10:00
017ee7c2da
FIX: [security bug] XHR check bypass
2013-04-30 02:34:19 +02:00
057b4768e6
strip whitespace when changing e-mail addresses
...
Fixes #778 .
2013-04-27 23:03:06 -04:00
dca2fbcefc
add meaningful error message on upload [ fixes #773 ]
2013-04-27 20:26:17 +02:00
6063f81946
Show something on categories page when js is disabled
2013-04-26 13:10:41 -04:00
f9e33ec6b8
store ip address and current user with incoming links
...
make links long an readable in share dialog
2013-04-26 16:18:55 +10:00
Sam
Neil Lalonde
Robin Ward
Anton Batenev
Andreas Haller
Navin
Stephan Kaag
Jesse House
Dmitriy Budnik
Vipul A M
Régis Hanol
Chris Hunt
Ian Christian Myers
Juan de Dios Herrero
Erik Ordway
Matt Van Horn
Jonathan Roes