de92913bf4
FIX: store the topic links using the cooked upload url
2018-08-14 12:23:32 +02:00
93b1386fb2
REFACTOR: admin site settings controller specs to requests ( #5966 )
2018-06-11 12:48:09 +08:00
f331d2603d
DEV: improve design of site setting default provider
...
This refactors it so "Defaults provider" is only responsible for "defaults"
Locale handling and management of locale settings is moved back into
SiteSettingExtension
This eliminates complex state management using DistributedCache and makes
it way easier to test SiteSettingExtension
2018-06-07 14:33:41 +10:00
46fc57222f
FEATURE: improve handling of site setting secrets
2018-06-04 21:31:34 +05:30
80adc1ee80
DEV: stabilize site setting spec
...
side effects could cause specs to fail in rare conditions
2018-05-25 12:16:00 +10:00
8d6a9eb511
FIX: scrub all settings that has '_secret' in name
2018-05-15 09:37:13 +05:30
abcb6af8f9
FIX: scrub secret setting values from logs
2018-05-15 09:19:26 +05:30
a0a06492d8
FIX: make get_hostname more lenient to user input
2018-04-12 17:09:09 +02:00
142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
70aed105a6
FIX: bypass all site setting work for shadowed method
2017-10-27 11:12:44 +11:00
d2ac7a9476
Partially revert 4e89d3f778.
...
* SiteSetting uses DistributedCache which depends on MessageBus.
Therefore, we need to initialize MessageBus first.
2017-10-12 15:15:24 +08:00
c5850422f0
FIX: SiteSettings defaults cache leaking across multisite.
2017-08-07 15:16:57 +09:00
3f24ed2b3e
Can't revert due to incompatibility of new site setting types.
...
Revert "Revert "FEATURE: Site settings defaults per locale""
This reverts commit 439fe8ba24
2017-08-07 10:43:09 +09:00
439fe8ba24
Revert "FEATURE: Site settings defaults per locale"
...
This reverts commit 468a8fcd20
2017-08-07 10:31:50 +09:00
468a8fcd20
FEATURE: Site settings defaults per locale
...
This change-set allows setting different defaults for different locales.
It also:
- Adds extensive testing around site setting validation
- raises deprecation error if site setting has the default property based on env
- relocated site settings for dev and tests in the initializer
- deprecated client_setting in the site setting's loading process
- ensure it raises when a enum site setting being set
- default_locale is promoted to `required` category.
- fixes incorrect default setting and validation
- fixes ensure type check for site settings
- creates a benchmark for site setting
- sets reasonable defaults for Chinese
2017-08-02 12:24:19 -04:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
e82efc7b03
Fix `SiteSetingExtension` specs to coerce int to string.
2017-07-24 22:54:42 +09:00
29d529020b
UX: Allow site settings to display as textareas if they like
2017-07-17 16:38:26 -04:00
04016f0dec
Support Ruby 2.4.
2017-04-15 12:29:00 +08:00
86522a52b7
FEATURE: add censored_pattern setting to censor posts using regex
2016-11-08 16:39:26 -05:00
3841cd9a7f
FEATURE: onebox everything by default
...
FEATURE: new 'max_oneboxes_per_post' site setting
FEATURE: change onebox whitelist to a blacklist
PERF: debounce the loading of oneboxes
PERF: improve perf of mention links in preview
FIX: sort loading of custom oneboxer
2016-10-24 12:46:22 +02:00
6075debc90
Add specs to hidding settings when shadowed by a global.
2016-08-11 16:04:45 +08:00
b66fc72c18
FIX: Incorrect deprecation message.
2016-07-01 01:18:57 +08:00
918b015bdb
Move comment to the right place.
2016-06-29 15:23:29 +08:00
20359788dc
Rename `SiteSetting#use_https` to `force_https`.
2016-06-29 15:02:43 +08:00
74b3807f60
FEATURE: new bootstrap mode settings for brand new Discourse community ( #4193 )
...
* FEATURE: new bootstrap mode settings for brand new Discourse community
* new SiteSetting.set_and_log method
2016-04-26 13:08:19 -04:00
da419326be
FIX: nil and blank string should not override a site setting
2016-04-04 16:36:32 +10:00
b1e68390f4
FIX: false overrides should be permitted via ENV
2016-02-13 17:49:26 +11:00
f2c64a3580
FIX: Client settings were not being published.
2016-02-11 17:53:30 +08:00
d0dd517f27
FEATURE: blank global settings should not shadow
...
Due to https://github.com/docker/docker/issues/9298 it is a huge pain
to remove ENV vars when composing images, allow us to simply treat "blank"
as a ENV var that is not being shadowed. In general we always supply a
value to ENV vars we are shadowing.
2016-02-10 11:54:40 +11:00
97e4f7f6d3
Enums that are used in tables need to be stable
2016-01-08 20:43:11 +05:30
5e93140f85
FEATURE: Can override any translation via an admin interface
2015-11-27 11:35:19 -05:00
1061a9ed06
PERF: introduce full cache for site json when anon
2015-09-28 16:50:24 +10:00
31e8309f05
FIX: ensure we never have a string when an enum is Fixnum - Take 2
2015-09-09 14:34:44 +02:00
9a999bfe84
FIX: ensure we never have a string when an enum is Fixnum
2015-09-09 12:59:49 +02:00
da25abfcc9
Merge pull request #3714 from riking/live-settings
...
FEATURE: Live-update site settings
2015-09-01 12:03:30 -04:00
b41b176bc6
Support for `value_list` in site settings
2015-09-01 11:54:16 -04:00
d4c68f2096
FEATURE: Live-update site settings
2015-08-31 10:40:50 -07:00
4ba89eec27
FIX: removing a default category wasn't working
2015-08-26 22:40:16 +02:00
1c6250bff8
FIX: if an enum is Fixnum do not allow strings to live in it
2015-08-26 16:39:09 +10:00
bef80633b1
FEATURE: global admin override of most of the user preferences
2015-08-21 20:39:21 +02:00
2363897a25
FEATURE: Arbitrary validations for site settings
2015-08-20 18:27:19 -07:00
fd63d89753
FEATURE: simpler definition of enum types
2015-08-07 11:41:48 +10:00
e9a81064e7
Revert "FIX: fixnum type site setting can't be more than 20000"
...
This reverts commit 636cc66e1f
2015-07-13 22:53:44 +05:30
636cc66e1f
FIX: fixnum type site setting can't be more than 20000
2015-07-13 18:58:45 +05:30
7b6d6b76eb
FEATURE: Multiple embeddable hosts
...
- Also refactors two site settings components into one, with tests
2015-06-09 13:25:43 -04:00
803feefd54
MessageBus handles readonly redis now, no need to wrap it
2015-05-04 12:21:00 +10:00
5b3f99aa50
Don't blow up if Redis switches to READONLY
2015-04-24 14:37:16 -04:00
2ee033caa5
FIX: validate integer site setting
2015-04-23 18:15:14 +05:30
a82530012a
FEATURE: Allow selection of highlight js languages
...
PERF: stop loading highlight js on load
To get latest highlight js run bin/rake highlightjs:update
2015-03-13 16:18:59 +11:00
84b84a9d7c
Support for `url_list` site setting.
2015-03-03 16:19:29 -05:00
0742f340f9
FEATURE: allow for a localized error when a regex fails in site settings
...
FEATURE: apply string validation to list site settings (so we get regex)
2015-02-27 11:45:56 +11:00
5f8e604abc
remove an allocation
2015-02-12 15:07:17 +11:00
276fd702e8
missed a send which caused code to break
2015-02-12 15:01:14 +11:00
ab3d4471fe
PERF: remove eval cause it is costing lots of memory
...
see: http://tenderlovemaking.com/2013/03/03/dynamic_method_definitions.html
isolated via memory profiler gem.
2015-02-12 14:44:40 +11:00
0da022a1ba
FIX: Make sure to observe shadowed settings when refreshing
2015-02-09 17:28:55 -05:00
5d6f6c4887
Revert "FIX: `refresh` should work with shadowed globals"
...
This reverts commit 226f4b5bd9
2015-02-09 17:08:52 -05:00
226f4b5bd9
FIX: `refresh` should work with shadowed globals
2015-02-09 16:52:21 -05:00
63404b16bb
FIX: on upgrade via discourse docker client json not updating
2015-02-09 17:58:56 +11:00
f7d2fc0524
FEATURE: 'reply by email address' validator
...
Prevent infinite email loophole when the 'reply_by_email_address' site setting is the same as the 'notification_email'.
2015-02-06 12:08:37 +01:00
aacf2e6f20
Can add `shadowed_by_global` to a site setting to override
...
If a site setting has `shadowed_by_global: true` then, if
a `GlobalSetting` exists with the same name then that value
will be used instead. Additionally, the setting will be hidden.
This is useful in a multisite environment for private settings
such as API keys. You want to set it globally, yet not display
the key to customers.
2015-02-03 16:49:22 -05:00
844467015d
FEATURE: allow simple selection for category badge styles
...
clean up category badge styling
2015-01-29 17:49:14 +11:00
e6e7948617
FEATURE: support for emoji sets
...
Added following emoji sets
- Apple/International
- Emoji One (default)
- Android/Google
- Twitter
FIX: translations from plugins weren't properly merged with default translations
FEATURE: new 'site_setting_changed' event
2014-12-11 17:08:47 +01:00
c98d0a8eb6
Revert "Revert "PERF: use distributed cache for site text and category slugs""
...
This reverts commit 65e7cd1d1d
2014-11-12 10:01:41 +11:00
65e7cd1d1d
Revert "PERF: use distributed cache for site text and category slugs"
...
This reverts commit a97f2eee05
2014-11-12 10:01:07 +11:00
a97f2eee05
PERF: use distributed cache for site text and category slugs
2014-11-12 09:44:44 +11:00
4e85fc9dae
PERF: cache all site_text in memory
2014-11-11 16:28:59 +11:00
33de48dc0c
FIX: Float site settings were marked as overridden, reset didn't work.
2014-08-20 15:24:56 -04:00
8737ffb272
Merge pull request #2658 from akshaymohite/optimization-fixes
...
Not initializing variable for looping if unused in loop
2014-08-18 14:42:52 +10:00
26ca197be9
Adds Site settings to configure post:like ratio thresholds
2014-08-15 12:02:29 -04:00
6301a43d57
Not initializing variable for looping if unused in loop
2014-08-15 03:24:55 +05:30
3b2a5f6894
FIX: filter whitelist domain name
2014-07-24 22:02:10 +05:30
4c237f5bf5
In site_settings.yml, change list: true to type: list
2014-06-18 11:15:40 -04:00
3eb65885d1
Add validation of string site settings with regex, and min and max lengths
2014-06-18 11:15:40 -04:00
ba65aa3f6c
Add a way to validate min and max value of an integer site setting
2014-06-12 18:04:37 -04:00
c61462662b
Add ability to run validation on site settings. notification_email and other email address settings are now validated.
2014-06-09 16:59:20 -04:00
e114e47533
FIX: enum site settings UI was broken
2014-06-05 16:42:37 -04:00
572ee3b94d
add site_setting choices
...
- add site_setting choices lists to list entries
- allows for handy autocompletion using the new select2.js UI
- automatically merges plugin choices into existing list, allowing for easy extension
2014-06-01 16:37:51 +02:00
6779bec58c
Add UI for list site settings
2014-04-08 14:17:55 -07:00
d71f62a9f9
Merge pull request #2180 from tomciopp/master
...
More idiomatic approach to finding drafts
2014-04-08 16:46:24 +10:00
9aec32688b
BUGFIX: when RTT is short likes may not appear to work
...
BUGFIX: site settings db provider not triggering updates
at the correct point
2014-03-31 12:34:13 +11:00
8fc2549873
Stop using global vars where not needed
...
Simplify local process site setting provider
Stop setting up methods over and over
Centralize cache clearing
2014-03-31 12:34:13 +11:00
f3cc7360e0
BUGFIX: Correct after_fork semantics
...
After fork SiteSettings was not getting a new process id,
causing site settings not to refresh properly in unicorn
This code also centralizes the logic
2014-03-31 12:34:13 +11:00
38882eb1a7
Remove threequals from ruby files
2014-03-26 12:20:41 -07:00
ccd3e635d2
Refresh the site after updating certain site settings
2014-03-06 20:24:23 -08:00
74f1c553e3
FIX: 1868 Security: Dangerous Send
2014-01-27 13:05:51 -05:00
fc180ccd71
Site settings: move category into the opts hash so that it's compatibale with existing plugins
2013-11-15 14:32:33 -05:00
1e37abc310
Add site setting category support
2013-11-14 16:02:13 -05:00
666264879c
change it so all topics MUST include a category, we store a special uncategorized category to compensate
...
this cleans up a bunch of internals and removes some settings
2013-10-24 12:08:02 +11:00
ad2ed5fe51
rate limits for topics and posts on first day
...
max_topics_in_first_day and max_replies_in_first_day
2013-10-10 10:32:03 +11:00
1b9079ed20
centralize logic so mockers stop mocking me
2013-09-03 17:58:56 +10:00
46d5314ec4
Improve Rails4 performance by 20%, before the median on the page is 53ms, after it is 44ms
2013-09-03 17:58:56 +10:00
6e79197519
Enum site settings can have translatable names in dropdown. Add setting for how often users get digest emails by default: default_digest_email_frequency.
2013-08-23 17:36:25 -04:00
ea932b74e7
values is a much more consistent name than all_values ... we use {}.values not {}.all_values
...
also fixes random ordering of tests failure in site settings
2013-06-23 15:07:49 +10:00
0b94c3c456
fix all sorts of issues with random spec order
...
SiteSetting no longer persisted across tests
2013-06-23 13:35:25 +10:00
384d743e7b
refactoring of site settings
2013-06-13 12:41:27 +10:00
5ff7e570ac
Add support for enum site settings that render as a dropdown; use a dropdown for default_locale
2013-06-11 11:40:14 -04:00
72b4f41254
Can change TOS content via site content editor
2013-04-05 15:21:55 -04:00
a2cca2540e
some minimal site settings diags
...
fix issue where days_visited was totally out of sync
2013-04-05 17:47:54 +11:00
5dfb04e4b3
Convert a lot of :a => b to a: b and bring peace to the world
2013-03-25 05:07:36 +05:30
Régis Hanol
OsamaSayegh
Sam
Arpit Jalan
Guo Xiang Tan
Erick Guan
Guo Xiang Tan
Robin Ward
Neil Lalonde
Kane York
Akshay
Benjamin Kampmann
Thomas Cioppettini
Karan Misra