Commit Graph

15399 Commits

Author SHA1 Message Date
Sam a393d3bcbb FIX: ensure staged accounts are always inactive
If for any reason active is stored in the user model, clear it out
prior to creating an account
2017-12-13 14:22:16 +11:00
Gerhard Schlager a7c1b0c81f FIX: path whitelist for embedded comments didn't work with non-ASCII chars 2017-12-12 20:17:46 +01:00
Gerhard Schlager e30851e45a Move escape_uri method to a more suitable place 2017-12-12 20:17:46 +01:00
Robin Ward 5fbfe34356 FIX: Moderation History wasn't working from timeline admin button 2017-12-12 12:21:10 -05:00
Kris 1be32bf4cf FIX: text indent on twitter oneboxes 2017-12-12 11:17:09 -05:00
Kris d6a18f72b6 UX: Mobile user profile button adjustment 2017-12-12 10:58:03 -05:00
Kris 55c019f776 UX: Cleaning up staff counters on user profiles 2017-12-12 10:40:16 -05:00
Arpit Jalan 492af81e67 FIX: save registration_ip_address for staged users logging in via social auth 2017-12-12 17:41:16 +05:30
Guo Xiang Tan e2b64257b3 Fix undefined method for `NilClass` error. 2017-12-12 18:54:29 +08:00
Régis Hanol af3c153687 make robocop 🤖 happy 2017-12-12 11:33:35 +01:00
Régis Hanol 62a5b174e1 FIX: wasn't able to use the same username when taking over a staged account 2017-12-12 11:26:00 +01:00
Arpit Jalan b014540fde FIX: view was getting rendered twice for rate limiting error 2017-12-12 14:48:58 +05:30
Kris 920571ae07 UX: Making button on advanced search page match input height 2017-12-11 17:15:08 -05:00
Kris 60cd28d5b9
UX: Cleaning up user profiles on mobile 2017-12-11 15:40:04 -05:00
Vinoth Kannan c17a28f875 Using const instead of var while declaring 2017-12-11 14:26:21 +05:30
Guo Xiang Tan 4bd5acec47 FIX: `Topic#featured_link` may contain more than a URL. 2017-12-11 16:36:19 +08:00
Arpit Jalan 3c56c9b637 FIX: strip webhook payload_url 2017-12-11 13:48:11 +05:30
Arpit Jalan 3c230d8f97 FIX: 'redirect_to :back' is deprecated 2017-12-11 12:18:19 +05:30
Kris edd7cb4f0d UX: Replacing some PX font definitions with EM based units 2017-12-08 17:10:49 -05:00
Robin Ward b3bdc68639 UX: Add link to "Moderation History" to flagging interface 2017-12-08 15:48:32 -05:00
Vinoth Kannan fdef4e58f0 Skip markdown table conversion from rich text feature flag setting 2017-12-08 18:30:38 +05:30
Vinoth Kannan b9c0488687 New site setting to enable or disable rich text pasting 2017-12-08 14:09:39 +05:30
Vinoth Kannan 0a47642003 FIX: Pasted text removing if server unable to parse HTML to Markdown 2017-12-08 13:38:54 +05:30
Sam cff9b8846d FIX: rendering %lt;/div noscript in header 2017-12-08 10:30:00 +11:00
Robin Ward 74b9828731 FIX: Remove mentions filters from user and groups
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX fd99e1ef56 FEATURE: site setting enable_mentions to turn on/off mentions 2017-12-07 16:27:58 -05:00
Kris 3e4f02a180 UX: Removing staff highlight from .name so it only applies to .user-title 2017-12-07 16:10:54 -05:00
Kris 6d5e5629f6 FIX: Choices input layout bug in IE11 2017-12-07 15:49:54 -05:00
Robin Ward 3cf4886d3e UX: Add a class name to target the embedded post controls 2017-12-07 15:01:34 -05:00
Kris f7c77171b9 UX: Eliminating a "sweet spot" at 870px viewport where the topic-body exceeds 690px wide 2017-12-07 14:32:31 -05:00
Robin Ward aeebcef7e2 FIX: Don't show the email from the suspension on the user profile 2017-12-07 13:27:02 -05:00
Robin Ward 4ae1bbaeba FIX: Only show the full suspension reason on the admin side 2017-12-07 13:27:02 -05:00
Kris ef0d9d631c
UX: New style for staff highlight
Moved highlight to cooked content, also highlighting primary name (with shield) and title (if applicable). 

**Before**:
![image](https://user-images.githubusercontent.com/1681963/33724323-2269e79e-db3d-11e7-8c93-75b9dc9a1ab7.png)


**After**:
<img width="809" alt="screen shot 2017-12-06 at 3 55 31 pm" src="https://user-images.githubusercontent.com/1681963/33724287-09eb66de-db3d-11e7-8e02-0062ed2b8716.png">
2017-12-07 12:40:39 -05:00
Kris 282633bc97 FIX: New topic composer layout in iOS10 2017-12-07 12:04:39 -05:00
Vinoth Kannan be848b8a5c FIX: Image pasted twice when it copied from browser 2017-12-07 21:23:31 +05:30
Vinoth Kannan 5cceb95f92 Improvement in composer HTML pasting 2017-12-07 21:13:09 +05:30
Vinoth Kannan 858cd3a589 Improvement in composer HTML pasting 2017-12-07 21:08:08 +05:30
Arpit Jalan c168c5895f
Merge pull request #5407 from techAPJ/show-inactive-accounts
FEATURE: new site setting show_inactive_accounts
2017-12-07 20:52:37 +05:30
Maja Komel cce077de56 move /tags/ topics list out of footer (#5405) 2017-12-07 15:25:04 +01:00
Arpit Jalan 5003f07b2c FEATURE: new site setting show_inactive_accounts 2017-12-07 19:22:41 +05:30
Joffrey JAFFEUX f0ef307d2d
FIX: topic timer offset applied two times
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.

This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1  hour to your timezone offset.
2017-12-07 14:42:58 +01:00
Kyle Zhao c52f747031 FEATURE: Catalan Translations (#5404) 2017-12-07 10:36:25 +01:00
Guo Xiang Tan c64774f4f8 Remove debugging code. 2017-12-07 06:48:12 +08:00
Régis Hanol c08d53f2dd keyValueStore isn't available in test 2017-12-06 23:28:28 +01:00
Kris 4d9f26879b FIX: Composer preview-area plugin layout 2017-12-06 16:12:52 -05:00
Régis Hanol ae0acfb1df FEATURE: live reply indicators at the bottom of topic 2017-12-06 21:58:59 +01:00
Régis Hanol ea50f823cb FIX: logging in after an anon ❤️ does not count the ❤️ 2017-12-06 21:58:05 +01:00
Robin Ward cf3ea4f9bd UX: Use the same 404 page for the `unknown` route and exception handler 2017-12-06 15:20:24 -05:00
Robin Ward e8d5d34755 FIX: Don't show trust level if the API didn't return it 2017-12-06 13:13:51 -05:00
ckeboss 7a093ea5d6 Format username for desktop notifications (#5403)
FIX: Desktop notifications weren't formatting the username
2017-12-06 12:52:11 -05:00
Kris f559275b14 FIX: Adjusted the composer preview to avoid odd scroll issue 2017-12-06 11:31:36 -05:00
Vinoth Kannan 7d88cfde0e Skip paste handling if composer textarea lost focus 2017-12-06 19:36:13 +05:30
Guo Xiang Tan 4531563717 Hide new advanced editor and preview sync behind a hidden site settings. 2017-12-06 12:34:58 +08:00
Kris da78e75f6f UX: Mobile post control button color was too specific, overriding solved plugin 2017-12-05 21:07:20 -05:00
Joffrey JAFFEUX 75463e5a91
FIX: correctly print html entity when used in a locale for none 2017-12-05 19:09:12 -05:00
Kyle Zhao 5f318a5241 FEATURE: Replace SimpleRSS with Ruby RSS module (#5311)
* SPEC: PollFeedJob parsing atom feed

* add FeedItemAccessor

It is to provide a consistent interface to access a feed item's tag
content.

* add FeedElementInstaller

to install non-standard and non-namespaced feed elements

* FEATURE: replace SimpleRSS with Ruby RSS module

* get FinalDestination and download with Excon

* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
Robin Ward 410994b7f5 FEATURE: Show a button to Staff for "Moderation History" on posts/topics
When clicked, it pops up a modal showing a history of moderation actions
taken on the post or topic.
2017-12-05 15:20:20 -05:00
Vinoth Kannan 94e9be3b88 Make eslint happy 2017-12-06 01:28:22 +05:30
Vinoth Kannan 8cf7152151 FIX: IE compatability issue in clipboard data types array 2017-12-06 01:02:06 +05:30
Vinoth Kannan 6e054b2572 FEATURE: Convert HTML to Markdown while pasting in composer 2017-12-05 12:23:39 -05:00
Arpit Jalan daeb7694bc update annotations 2017-12-05 21:03:20 +05:30
Vinoth Kannan 37948838be FIX: Global event variable is not compatible with all browsers 2017-12-05 11:27:08 +05:30
Vinoth Kannan 4654f076f5 FIX: Drive spreadsheet table not converting to Markdown table 2017-12-05 11:03:33 +05:30
Kris a1d880a215 FIX: Broken variable 2017-12-04 20:22:04 -05:00
Kris 4af4081c39
UX: Updating the edit post title layout 2017-12-04 15:29:02 -05:00
Neil Lalonde b5a967ab43 lint failure 2017-12-04 14:32:01 -05:00
Neil Lalonde 23ea4b6739 FIX: don't create featured link if title includes more than a url 2017-12-04 14:21:08 -05:00
Neil Lalonde fb08441802 Revert "FIX: don't create featured link if title includes more than a url" 2017-12-04 12:53:12 -05:00
Vinoth Kannan e14281bdf6
Merge pull request #5393 from vinothkannans/clip-master
FEATURE: Paste plain text table as Markdown table
2017-12-04 22:45:07 +05:30
Neil Lalonde cde42c3f69 FIX: don't create featured link if title includes more than a url 2017-12-04 12:03:41 -05:00
Kris b55b7c5356 FIX: Removing horizontal scrollbar in category modal 2017-12-04 12:00:34 -05:00
Kris 8eb7518d2a FIX: Disappearing tag input border on hi-res devices/when scaling 2017-12-04 11:35:02 -05:00
Kris f1b5227aa6 FIX: Mobile composer layout for PMs 2017-12-04 11:15:10 -05:00
Kris 13840942b9 UX: Fixing code highlighting color issue in dark themes 2017-12-04 10:28:32 -05:00
Vinoth Kannan ab4c953d82 FEATURE: Paste plain text table as Markdown table 2017-12-04 20:53:42 +05:30
Arpit Jalan f466791a15 FIX: resolve from URL when using /new-topic route 2017-12-04 17:34:17 +05:30
Arpit Jalan 0e0794dff9 FIX: correct use of invitee vs inviter in email templates 2017-12-04 14:09:48 +05:30
Guo Xiang Tan e73fbfe265 FIX: `Topic#featured_link_root_domain` extracts URL before parsing. 2017-12-04 10:00:07 +08:00
Robin Ward 3e83c34785 FIX: Don't include `null` class when rendering the pinned dropdown 2017-12-03 16:20:35 -05:00
Robin Ward e80caab247 FIX: Reply to tab was not using the username formatter 2017-12-03 15:49:21 -05:00
Robin Ward a0da098e6b UX: Add new classes to make user creation more targetable 2017-12-03 15:03:06 -05:00
Kris c8ad89afd4 UX: Adjustments to composer uploading message 2017-12-01 22:31:40 -05:00
Kris d615a37eba UX: Hiding composer preview reduces width of composer overlay 2017-12-01 22:23:12 -05:00
Jeff Atwood bcd57d72a9
Merge pull request #5389 from vinothkannans/clip-master
FIX: Skip pasting files if plain text available in clipboard
2017-12-01 16:41:39 -08:00
Kris a43c044b1e UX: Removing an old font declaration 2017-12-01 16:17:01 -05:00
Neil Lalonde b35960fc35 FIX: export admin reports to csv would have 0 rows in the csv file 2017-12-01 15:50:36 -05:00
Vinoth Kannan e2c60ea4b2 FIX: Skip pasting files if plain text available in clipboard 2017-12-02 02:05:11 +05:30
Joffrey JAFFEUX dbadebacd1
FIX: allows select-kit to search by null value 2017-12-01 20:02:00 +01:00
Kris 29bdf35977 FIX: Composer not properly centered in IE11 2017-12-01 13:58:04 -05:00
Kris e7725e23ad FIX: Flexbox composer issue in IE11, bad flex-shrink default 2017-12-01 13:12:25 -05:00
Arpit Jalan 54f5b4d4e0 FEATURE: log clicks on full page search 2017-12-01 23:21:16 +05:30
Kris af11913314 FIX: Positining of search spinner in tablet-sized viewports 2017-12-01 11:01:03 -05:00
Joffrey JAFFEUX 966dbb9705
FIX: do not give any element focus when creating topic 2017-12-01 13:16:36 +01:00
Guo Xiang Tan 2e860eddc1 Don't sync scroll when input is not scrollable.
https://meta.discourse.org/t/composer-preview-scroll-not-syncing-with-editor/74975/14?u=tgxworld
2017-12-01 17:08:03 +08:00
Jeff Atwood 3e42dceaae "reply to which topic" needs wider buttons 2017-11-30 23:25:32 -08:00
Arpit Jalan 496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
Arpit Jalan e3925278e2 FEATURE: support search click through tracking for user, category and tags
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj

This commit adds following features:

- support for tracking click through to user, tag and category
- new filter for search type (header, full page)

This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
Vinoth Kannan 7f2eeaf767 FIX: Password required flag should be cleared whenever clearing the raw password (#5384) 2017-12-01 15:19:24 +11:00
Kris 9876f3d0ee FIX: extraneous mobile CSS, flagged badge color in dropdown 2017-11-30 17:29:29 -05:00
Neil Lalonde 3dd67e9c04 replace 'email' with envelope icon on user card for staged users 2017-11-30 16:55:27 -05:00