42b10a646d
FIX: return 404 only if upload url also not internal.
2019-05-15 02:06:54 +05:30
e0fe01925e
FIX: make frozen string mutable in incoming_domain
2019-05-14 17:44:53 +02:00
d127119549
REFACTOR: user-selector take 2 ( #7540 )
2019-05-14 09:43:29 +02:00
624184560e
PERF: improve performance of publish_notifications_state
...
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.
On some heavy notification related sites this can be a major CPU user on PG
This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
2019-05-14 16:02:55 +10:00
6f747c6b71
FIX: don't allow username to be changed to same as password
...
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
2019-05-13 16:43:40 -04:00
bbab60fa9b
FIX: Don’t try to delete inactive moderators
...
follow-up to 6d77156a
2019-05-13 21:44:03 +02:00
7707d5db2d
Revert "REFACTOR: user-selector ( #7529 )"
...
This reverts commit 9a56df89f0
2019-05-13 19:39:30 +02:00
a2b1789c3e
FIX: do not log username change if the save process was unsuccessful
2019-05-13 22:20:27 +05:30
fb1da53dff
FIX: Issue with incorrect heights when cloaking plugin content in posts
...
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.
Co-authored-by: nlalonde
Co-authored-by: pmusaraj
2019-05-13 11:29:21 -04:00
7326ddea6d
REFACTOR: tags mixin ( #7533 )
2019-05-13 17:05:21 +02:00
b8db702a02
REFACTOR: admin-user-index route ( #7534 )
2019-05-13 17:04:41 +02:00
717aa764b6
FIX: more efficient topic-footer-button-api ( #7535 )
2019-05-13 17:04:24 +02:00
750c125707
DEV: Include foreign keys in model annotations
2019-05-13 15:53:42 +01:00
607c671003
Fix string literal when switching theme in dev env
2019-05-13 10:25:51 -04:00
f1b0782624
UI: Adjust footer nav bar size in iOS app
2019-05-13 10:25:51 -04:00
1bff81419e
DEV: Update annotations
2019-05-13 15:24:24 +01:00
53d2232731
FIX: Remove trailing slash from topic URL
...
this lead to duplicate slashes in concatenated URLs
2019-05-13 14:51:45 +02:00
df18243827
FIX: prevents exception if report doest define filters ( #7532 )
2019-05-13 13:34:28 +02:00
9a56df89f0
REFACTOR: user-selector ( #7529 )
2019-05-13 13:03:12 +02:00
25b39b86ae
FIX: reload the user record instead of fetching via email
2019-05-13 15:16:53 +05:30
e64ed9dbc1
REFACTOR: edit-category controller ( #7527 )
2019-05-13 11:30:32 +02:00
64c117519e
Fix modifying frozen strings errors take 3.
2019-05-13 16:45:23 +08:00
74989783da
Fix modifying frozen strings error in `OneboxController`.
2019-05-13 16:25:52 +08:00
b584e30902
Fix modifying frozen strings error take 2.
2019-05-13 16:23:45 +08:00
9b75320d63
FIX: track mutations on topic edit category-chooser only on select ( #7528 )
2019-05-13 10:22:28 +02:00
d643294c9d
FIX: delete duplicate invites earlier in the process
...
There was a race condition when 2 invites existed for 1 user where in some
cases data from both invites would be used for the redeem. Depending on DB
ordering.
Fix is to delete duplicate invites earlier in the process prior to
`redeem_from_email` being called.
2019-05-13 17:42:39 +10:00
81c329fbb8
FIX: Customizing missing pluralized translations didn't work
2019-05-13 09:36:05 +02:00
d369b84ced
Fix modifying frozen strings error.
2019-05-13 14:31:20 +08:00
8165ceb320
Make rubocop happy.
2019-05-13 09:55:44 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
a859ddc77e
Improve theme/component delete modal warning
2019-05-10 14:14:12 -04:00
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases ( #7525 )
2019-05-10 17:12:10 +02:00
643c75c419
FIX: Don't increment version if the reviewable operation fails
...
In fact, roll back the entire operation in the database.
2019-05-10 09:53:25 -04:00
abbe812a0d
FIX: Correct CSS for instagram video play icon
2019-05-10 10:46:07 +01:00
4096d559b5
REFACTOR: user-stream model ( #7515 )
2019-05-10 10:05:43 +02:00
a85b7feef4
REFACTOR: composer controller ( #7516 )
2019-05-10 10:05:29 +02:00
7aedc92a35
REFACTOR: login-controller ( #7514 )
2019-05-10 10:05:11 +02:00
63a3caa516
FIX: Don't display option for users to flag and notify a bot.
2019-05-10 10:05:03 +08:00
0ab6c6e24e
PERF: speed up spec suite, avoid featuring topics
...
Before: 6:05
After: 5:42
Featuring topics for `list/categories` is a very expensive operation that
happened each time we created a topic. This introduces a test only bypass
2019-05-10 11:37:53 +10:00
34684af195
FIX: Show error message if message exists
2019-05-09 22:12:51 +02:00
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
8dfb15a2e5
FIX: Do not show self edits in Post Edits report. ( #7510 )
2019-05-09 20:39:17 +03:00
ea3004ef11
UX: Save scroll position in tags topic list. ( #7511 )
2019-05-09 20:39:03 +03:00
2a45933ff2
FIX: reduce iPad app nav padding
2019-05-09 10:25:22 -04:00
c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. ( #7509 )
2019-05-09 14:08:10 +03:00
4e91839c97
FIX: Remove default val for colors step if a default theme has been set.
...
Running through the wizard after a default theme has been configured
will always revert the default theme to the light theme.
2019-05-09 17:25:09 +08:00
977ffa20f4
FIX: variable is different from key ( #7512 )
2019-05-09 10:03:33 +02:00
427979e7e5
FEATURE: use full screen login by default for social login methods ( #7481 )
2019-05-09 10:03:01 +05:30
8ec1f8cf07
DEV: Correct naming convention for JS file.
2019-05-09 10:18:29 +08:00
8c07c272f2
make rubocop happy.
2019-05-09 05:25:44 +05:30
87cd4701b8
FEATURE: option to skip posts with ignored missing uploads
2019-05-09 05:11:15 +05:30
e6cfc584d0
Revert "FIX: frozen string exception ( #7506 )"
...
This reverts commit c4b7fb2754
2019-05-08 17:27:09 +02:00
497c0ba418
Revert "FIX: frozen string exception ( #7505 )"
...
This reverts commit 2938e3f033
2019-05-08 17:27:03 +02:00
24ca074f3f
FIX: short description title on client side when empty description
...
follow-up 77af097c
2019-05-08 17:07:12 +02:00
e84531a6a6
FIX: Correctly clear theme stylesheet cache when changing color scheme
2019-05-08 16:02:55 +01:00
54c2f24ee9
REFACTOR: composer model ( #7499 )
2019-05-08 16:53:12 +02:00
2938e3f033
FIX: frozen string exception ( #7505 )
...
Initial backtrace:
```
/var/www/discourse/app/mailers/user_notifications.rb:554:in `send_notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:459:in `notification_email'
/var/www/discourse/app/mailers/user_notifications.rb:318:in `user_private_message'
```
* this might fail too
2019-05-08 16:52:38 +02:00
4aaee7ee35
REFACTOR: change-timestamp controller ( #7498 )
2019-05-08 16:26:51 +02:00
c4b7fb2754
FIX: frozen string exception ( #7506 )
...
Initial backtrace:
```
/var/www/discourse/app/models/incoming_domain.rb:29:in `to_url'
/var/www/discourse/app/models/incoming_link.rb:83:in `referer'
/var/www/discourse/app/models/incoming_link.rb:106:in `referer_valid'
```
2019-05-08 16:25:54 +02:00
b409dab77f
Rename `flags_default_topics` to `reviewable_default_topics`
...
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
2019-05-08 10:07:10 -04:00
77af097ce0
FIX: add short description to title on client side
2019-05-08 15:03:33 +02:00
b717e23ceb
FIX: Dynamically adjust scale when rendering wizard canvases
...
This was a typo in fd0de64
2019-05-08 13:14:28 +01:00
861023f0d6
FIX: Skip attachments in click track.
2019-05-08 11:55:31 +03:00
f04518fdf9
DEV: Reduce number of jobs enqueued.
...
Apply code review suggestion from
405ba00c08
2019-05-08 15:58:08 +08:00
405ba00c08
FEATURE: Create notifications on wiki edits for watching users.
...
* Moves creation of notification into background job.
2019-05-08 15:31:10 +08:00
46ea69a73c
UX: Initialize client side category model with right search_priority.
...
This is strictly a UX change since the default value of the column is 0.
2019-05-08 14:16:20 +08:00
5af7c90bab
FEATURE: Hide Reviewable scores, change score filter to Priority
...
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.
You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
626534ad94
FIX: lighten instead of adding transparency to consolidated pageviews ( #7495 )
2019-05-07 18:14:13 +02:00
0a66065774
FIX: Move default options that were in the bufferedRender function. This will fix shortcut navigation for discourse-assign ( #7497 )
2019-05-07 12:25:10 -03:00
e20f13ebb7
fix css of prev and next page links, move them to bottom of page ( #7465 )
...
Thanks 👍
2019-05-07 17:04:27 +02:00
446ec1b44a
Set input and textarea font size to 16px on iOS ( #7480 )
2019-05-07 10:44:43 -04:00
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
ed70595314
UX: add information about the use of permalinks
2019-05-07 17:13:26 +05:30
71fb8a4195
DEV: Fix failing click-track tests.
2019-05-07 13:54:12 +03:00
4bbb34f7cb
REFACTOR: admin-user ( #7475 )
2019-05-07 10:53:21 +02:00
f73ed45429
REFACTOR: color-scheme model ( #7477 )
2019-05-07 10:51:52 +02:00
9507eff927
REFACTOR: resumable-upload ( #7474 )
2019-05-07 10:51:11 +02:00
4ff1195537
FEATURE: Use Beacon API for tracking clicks. ( #7483 )
2019-05-07 16:37:43 +10:00
cf99431c18
Fix like and flag button count alignment ( #7487 )
2019-05-07 16:34:29 +10:00
abbc639e0d
FIX: Only unregister service workers that belongs to Discourse.
2019-05-07 13:08:06 +08:00
03169401ff
UX: correct order of site statistics on /about page
2019-05-07 09:50:41 +05:30
451f7842ff
DEV: More `send` -> `public_send`.
2019-05-07 10:05:58 +08:00
cac80cdc3b
DEV: more send -> public_send changes
...
This is a work in progress commit for more send to public_send conversions
Also adds some comments for cases where we need to keep send
2019-05-07 11:58:06 +10:00
61cc0f8c5f
Follow up to 152238b4cf.
2019-05-07 09:57:27 +08:00
152238b4cf
DEV: Prefer `public_send` over `send`.
2019-05-07 09:33:21 +08:00
9be70a22cd
DEV: introduce new API to look up dynamic site setting
...
This removes all uses of both `send` and `public_send` from consumers of
SiteSetting and instead introduces a `get` helper for dynamic lookup
This leads to much cleaner and safer code long term as we are always explicit
to test that a site setting is really there before sending an arbitrary
string to the class
It also removes a couple of risky stubs from the auth provider test
2019-05-07 11:00:30 +10:00
47995d2d89
FIX: Your own likes were missing on posts
2019-05-06 20:03:50 -04:00
31e100530f
FEATURE: Flag count in post menu
...
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.
We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
2019-05-06 16:13:31 -04:00
5e546ba7d1
Standardize viewport rules for mobile and desktop
...
Also removes`maximum-scale` on non-mobile devices, better for accessibility.
2019-05-06 10:28:29 -04:00
e2e72f4e8e
DEV: rename ReadOnly module to ReadOnlyHeader
2019-05-06 16:07:49 +02:00
33e06dd796
FIX: Make select all and below skip small actions. ( #7425 )
2019-05-06 16:22:11 +03:00
a40dcbde9b
FIX: Do not move hidden post actions. ( #7424 )
...
Hidden (staff-only) post actions are whisper posts with no content, that
are later transformed by the client into post actions (discourse-assign
uses this).
2019-05-06 16:21:42 +03:00
8217d5be78
UX: Switch mobile header back for 5s when notification comes in.
2019-05-06 16:58:25 +08:00
f8eddd40ad
PERF: remove avg_time calculations and regular jobs from posts and topics
...
After careful analysis of large data-sets it became apparent that avg_time
had no impact whatsoever on "best of" topic scoring. Calculating avg_time
was a very costly operation especially on large databases.
We have some longer term plans of introducing other weighting that is read
time based into our scoring for "best of" and "top" topics, but in the
interim to stop a large amount of work that is not achieving any value we
are removing the jobs.
Column removal will follow once we decide on a new replacement metric.
2019-05-06 15:59:01 +10:00
ba3cf7109c
DEV: Remove unused lines of code.
2019-05-06 13:48:51 +08:00
267d129f38
FEATURE: only scroll to bottom for discobot
...
Non discobot replies on PMs triggering scroll cause confusion.
2019-05-06 10:55:58 +10:00
99a2a769d4
FIX: Conflict error (version was already used)
2019-05-03 16:36:37 -04:00
e8fafbc123
List and restore missing post uploads from S3 inventory.
2019-05-04 01:16:20 +05:30
d82da69c2c
FIX: Fail gracefully if username parameter is missing when creating user
2019-05-03 17:17:06 +01:00
15c9b00307
FEATURE: Show edit indicator on review queue
...
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
2019-05-03 11:21:33 -04:00
5f78bbebe9
FIX: forces a reload of emoji list if clicked on more ( #7473 )
...
This is a bit hacky but it's much more simple and reliable than many other solutions and doesnt involve having to manage some variable state.
2019-05-03 16:11:03 +02:00
0d41d58d27
FIX: add ReadOnly hear to /srv/status
2019-05-03 12:21:07 +02:00
16ef060a76
DEV: correct Rails 6 deprecation
...
render template is backwards compatible with Rails 5, code is simpler.
Thanks @jhawthorn, this is our last Rails 6 deprecation
2019-05-03 16:20:18 +10:00
b948d97c8f
FEATURE: Show diff of local changes before updating remote theme ( #7443 )
2019-05-02 21:43:54 -04:00
3dc4ab905c
DEV: annotate models
...
(also looks like renaming of bigint(8) -> bigint in annotate
which seems fine)
2019-05-03 08:34:12 +10:00
3cb0d27d38
DEV: Upgrade our widget handlebars compiler
...
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
2019-05-02 15:47:57 -04:00
e696903c31
FIX: uses translatedTitle to check validity of topic footer btn ( #7472 )
2019-05-02 20:56:27 +02:00
35212036f2
FIX: ensures click on topic link has link for target and not children ( #7471 )
2019-05-02 13:43:02 +02:00
d252dad4f0
FIX: Can't remove user profile uploads.
...
Follow up to 24347ace10
2019-05-02 16:54:10 +08:00
ebca588fd0
DEV: Remove unused line of code.
2019-05-02 16:54:10 +08:00
75591664e7
FIX: better handling of category filter deselection ( #7468 )
2019-05-02 10:03:12 +02:00
d5c9ac7196
PERF: Use cdn when serving site settings upload.
2019-05-02 15:35:07 +08:00
24347ace10
FIX: Properly associate user_profiles background urls via upload id.
...
`Upload#url` is more likely and can change from time to time. When it
does changes, we don't want to have to look through multiple tables to
ensure that the URLs are all up to date. Instead, we simply associate
uploads properly to `UserProfile` so that it does not have to replicate
the URLs in the table.
2019-05-02 14:58:24 +08:00
96360a779f
DEV: add a few frozen string literals
2019-05-02 16:57:12 +10:00
1be01f8dd4
DEV: Add support for Rails 6
...
Minor fixes to add Rails 6 support to Discourse, we now will boot
with RAILS_MASTER=1, all specs pass
Only one tiny deprecation left
Largest change was the way ActiveModel:Errors changed interface a
bit but there is a simple backwards compat way of working it
2019-05-02 16:23:25 +10:00
5a834a05ea
FIX: crawler layout CSS adjustments ( #7469 )
...
* Fix header size to fit the viewport
Setting the header to border-box means that the padding is factored in when calculating its width. If this is not done, the header width would be 100% of the viewport width + any padding when set on it. That causes some parts of the header to be rendered off-screen and causes horizontal scrolling.
* prevent code in posts from causing horizontal overflow
We are currently not wrapping code in posts in the crawler view. This affects both unformatted code and inline code blocks. This commit forces such code to wrap in order to prevent horizontal overflow which the Google bot complains about since it causes some content to be rendered outside of the viewport for the mobile crawler.
2019-05-02 13:00:29 +08:00
157dc5e298
FEATURE: disable native share API on non tablets/phones
...
Native share API works fantastically on phones/tablets but on full desktop
it is confusing.
2019-05-02 13:18:29 +10:00
885f1e7e5f
FIX: Allow category group reviewers to edit queued posts
...
They can edit title, body and tags. Category is disabled for now as it
could lead to some odd security issues.
2019-05-01 14:48:49 -04:00
0f01c9d25f
FIX: Posts in the approval queue were sometimes dropping category
2019-05-01 14:40:38 -04:00
b5ea50a154
FIX: use full screen login for new-topic route ( #7467 )
...
DEV: add javascript tests for new-topic and new-message routes
DEV: fix an existing test that was being skipped
2019-05-01 22:54:29 +05:30
7869a10d18
Revert "FEATURE: Added unlisted topics option to advanced search ( #7447 )"
...
This reverts commit 539723f8ff
2019-05-01 21:06:20 +05:30
ae493f4722
UX: fills picker with emoji autocomplete state on `more` click ( #7466 )
2019-05-01 16:19:45 +02:00
0e303c7f5d
FEATURE: Automatically generate optimized site metadata icons ( #7372 )
...
This change automatically resizes icons for various purposes. Admins can now upload `logo` and `logo_small`, and everything else will be auto-generated. Specific icons can still be uploaded separately if required.
## Core
- Adds an SiteIconManager module which manages automatic resizing and fallback
- Icons are looked up in the OptimizedImage table at runtime, and then cached in Redis. If the resized version is missing for some reason, then most icons will fall back to the original files. Some icons (e.g. PWA Manifest) will return `nil` (because an incorrectly sized icon is worse than a missing icon).
- `SiteSetting.site_large_icon_url` will return the optimized version, including any fallback. `SiteSetting.large_icon` continues to return the upload object. This means that (almost) no changes are required in core/plugins to support this new system.
- Icons are resized whenever a relevant site setting is changed, and during post-deploy migrations
## Wizard
- Allows `requiresRefresh` wizard steps to reload data via AJAX instead of a full page reload
- Add placeholders to the **icons** step of the wizard, which automatically update from the "Square Logo"
- Various copy updates to support the changes
- Remove the "upload-time" resizing for `large_icon`. This is no longer required.
## Site Settings UX
- Move logo/icon settings under a new "Branding" tab
- Various copy changes to support the changes
- Adds placeholder support to the `image-uploader` component
- Automatically reloads site settings after saving. This allows setting placeholders to change based on changes to other settings
- Upload site settings will be assigned a placeholder if SiteIconManager `responds_to?` an icon of the same name
## Dashboard Warnings
- Remove PWA icon and PWA title warnings. Both are now handled automatically.
## Bonus
- Updated the sketch logos to use @awesomerobot's new high-res designs
2019-05-01 14:44:45 +01:00
9c78c18256
Check both site and global setting for s3 enabled value.
2019-05-01 10:49:53 +05:30
c6409fd2cc
FIX: pass correct date arguments to server when exporting CSV
2019-05-01 10:46:30 +05:30
002e1f560a
FIX: initialize empty object if no custom filters are present
2019-05-01 10:27:19 +05:30
539723f8ff
FEATURE: Added unlisted topics option to advanced search ( #7447 )
2019-05-01 12:31:13 +10:00
404b35bd04
FEATURE: Category Reviewable by Group
...
Allow a group to review content in a particular category.
2019-04-30 15:23:06 -04:00
dd29af4475
REFACTOR: `{{avatar}}` and `{{date}}` helpers in vdom templates
...
This is a step towards a nicer flag display under posts.
2019-04-30 15:22:38 -04:00
404666c9e9
DEV: Export the default behaviour of a topic-list-item so it can be reused by the discourse-assign plugin ( #7433 )
2019-04-30 15:36:54 -03:00
812905cbb6
FIX: Recursively delete nested replies
...
Previously we were only deleting top level replies
2019-04-30 12:54:53 -04:00
5edb5c8b03
FIX: Mark invited admins as 'approved' ( #7459 )
...
This prevents invited admins appearing as no-op reviewables in the queue when invite_only or require_approval is enabled.
2019-04-30 17:26:39 +01:00
583226d295
FIX: Linking to `/new-topic` from `/latest`
...
`/new-topic` redirects back to `/latest`, so the ember router considers this to be a 'refresh'. This triggers the `resetParams()` logic, which would cause the transition to abort, and the composer would never open.
This commit fixes the `resetParams()` logic so that it uses the default values, instead of setting everything to `null`. Therefore the transition is no longer aborted, and the composer opens successfully.
Unfortunately I have not been able to reproduce the issue in a QUnit test.
2019-04-30 16:25:25 +01:00
8e68244eea
FIX: prevents google to track certain pages ( #7463 )
2019-04-30 15:57:51 +02:00
726dd0fe37
Revert "FIX: prevents google to track certain pages ( #7455 )"
...
This reverts commit c863e62998
2019-04-30 10:17:12 +02:00
587cfd4545
DEV: Use `frozen_string_literal: true` on `models/theme.rb`.
2019-04-30 16:02:55 +08:00
c863e62998
FIX: prevents google to track certain pages ( #7455 )
2019-04-30 13:59:55 +08:00
1fdeec564b
PERF: Move `where` clause up to speed up CalculateAvgTime daily job ( #7462 )
...
Cuts down affected posts earlier in the query, so the generated plan
deals with less rows, and runs faster.
https://meta.discourse.org/t/post-calculate-avg-time-taking-up-a-long-time/49750/13?u=falco
2019-04-30 13:34:46 +10:00
dca7f8ecf2
FIX: Loading more broken on groups page.
...
Regressed in 1f17d52f55
2019-04-30 10:35:17 +08:00
a00354f11f
Prettier site-settings/group-list.js.es6
2019-04-29 16:26:13 -04:00
1ba72ccab8
DEV: add site setting type group_list for a list of groups
...
Add a js test
2019-04-29 16:15:22 -04:00
526e76ced2
FIX: Use PostgreSQL 'ON CONFLICT' to deal with race condition
...
On busy sites, concurrent requests to insert into post_timings can
occur, which was dealt with using Ruby exceptions.
This moves the handling to PostgreSQL which makes it a bit faster,
and prevents a spam of ERROR in the database logs.
2019-04-29 16:34:42 -03:00
bfadb1fabc
FIX: use more specific target for ".tag-box"
...
This avoids tags named "box" from receiving styling aimed at this specific element on the tag list page.
2019-04-29 13:55:40 -04:00
f8f7091e57
FIX: staff-only tags visible on /tags page when restricted to a category
...
If a tag group is set to only be visible to staff, and is restricted
to a category that is visible by everyone, the tags in the group were
being shown on the /tags page. They weren't visible anywhere else.
This commit fixes it so they don't show on the /tags page.
2019-04-29 12:38:28 -04:00
b75720d911
FIX: skip click-tracking for mentions
2019-04-29 12:05:47 -04:00
876c4f20b3
FIX: Remove duplicate Emoji names from blurb
...
The blurb contained the value of the alt and title attribute of Emojis. Both values are always the same.
2019-04-29 17:26:39 +02:00
71d19f6e1f
FIX: Reduce mentions in blurbs to @username or @groupname
...
The link to the user profile or group is useless and the URL encoded username or group name looks awful for Unicode names
2019-04-29 17:26:39 +02:00
5768011cad
FIX: prevents exception in the composer with regexp flags
2019-04-29 16:58:17 +02:00
629ae7a5b7
FIX: Revert tracking links in quotes
2019-04-29 10:30:04 -04:00
aef35faefc
FIX: Open links in external tabs. ( #7444 )
2019-04-29 10:27:29 -04:00
ca9fd95a08
FIX: Respect "open external links in new window" in quotes and edit history
2019-04-29 10:13:53 -04:00
7a27c93c03
FIX: URL encode username and first letter in avatar URL
...
And it adds specs as a follow-up to aadb7da7
2019-04-29 15:08:14 +02:00
286f2abc65
FIX: prevents exception when clicking directly on site text
2019-04-29 12:07:30 +02:00
ac3dab93f5
DEV: lint the files
2019-04-29 17:40:53 +10:00
45285f1477
DEV: remove update_attributes which is deprecated in Rails 6
...
See: https://github.com/rails/rails/pull/31998
update_attributes is a relic of the past, it should no longer be used.
2019-04-29 17:32:25 +10:00
1b1cfd4507
add no_subcategories query param in url only if its true ( #7439 )
2019-04-29 15:10:59 +08:00
fe86941cb6
FIX: prevents exception when search q params is a hash ( #7437 )
...
* FIX: prevents exception when searh q params is a hash
* raise when invalid format
2019-04-29 15:09:25 +08:00
574f39f9d0
FIX: Fixed uploadPlaceholder regex failing on not escaped characters ( #7442 )
2019-04-29 12:32:48 +10:00
de79313f62
FIX: ensures file extension doesnt have a leading point ( #7449 )
2019-04-27 14:00:51 +02:00
6952510fc4
FIX: restores skipHeader computed property
2019-04-26 23:43:49 +02:00
1486328756
UX: Changed post stream placeholder to animation ( #7434 )
2019-04-26 17:29:48 +01:00
8fc2b0124f
PERF: destroy users in batches of 50 users
...
This speeds up the process as we no longer need to commit a transaction
per user deleted
2019-04-26 22:51:33 +10:00
b8c65cc6cf
PERF: add index on user auth tokens (for user lookups)
...
This speeds up user destroy cause we cascade looking up all the tokens
for a user
2019-04-26 22:38:54 +10:00
378fe1c1cf
PERF: allow looking up incoming email by user_id
...
This speeds up the ability to remove users from the system
2019-04-26 22:33:01 +10:00
26b4dbde41
PERF: use delete_all to remove notifications and topic_users
...
Previously we used destroy here which could be extremely expensive
2019-04-26 22:26:48 +10:00
bcca2b5d73
FEATURE: initial implementation of generic filters for reports
2019-04-26 12:17:10 +02:00
4b455e741e
DEV: Ember 3.8.0
...
Co-Authored-By: majakomel <maja.komel@gmail.com>
2019-04-26 12:16:21 +02:00
c617e512ad
annotate new indexes
2019-04-26 18:23:27 +10:00
c009a6ae36
PERF: speed up user deletion logic
...
Previously any user deletion would scan a very large number of tables
This avoids scans on 6 tables/indexes on delete
2019-04-26 18:11:39 +10:00
be0ae2e487
FIX: plain text table detection should work even if html content not found.
2019-04-26 11:16:41 +05:30
dc2ee78f7a
UX: Only do plain text table detection in outside code if HTML pasting enabled
...
Co-authored-by: Tim Lange <tim.lange@titanhq.de>
PR: https://github.com/discourse/discourse/pull/7436
2019-04-26 09:20:21 +05:30
abecb3aea8
Update annotations.
2019-04-26 10:36:21 +08:00
34b772575e
FIX: Return 'failed' attribute when catching an ajax error and the attribute is present
2019-04-25 14:49:52 -03:00
761e1e25f7
Remove tables incorrectly excluded in `Upload.migrate_to_new_scheme`.
...
Follow up to 4a03b21f80
2019-04-25 20:27:52 +08:00
7cbc4c1e46
FIX: uses no tags label for tag-drop header ( #7438 )
2019-04-25 13:16:06 +02:00
6d77156a94
FIX: Don't try to delete inactive admins
2019-04-25 11:59:50 +02:00
422237391e
FIX: fix notifications for flag PMs and show topics with moderator posts in inbox ( #7331 )
...
Some old moderator posts that were not correctly processed before this change and 993d8f34
2019-04-25 11:15:13 +02:00
996e5e5dfa
FIX: category list order using category featured topics ( #7283 )
2019-04-25 11:07:19 +02:00
e386fa7674
FIX: ensures we have touches when starting pan event ( #7435 )
2019-04-25 10:36:41 +02:00
d8ff94ecaa
FEATURE: Ignoring users from the preferences page in a cleaner way ( #7289 )
...
* FEATURE: Ignoring users from the preferences page in a cleaner way
2019-04-25 09:26:49 +01:00
84cfe30c1f
Use update_all instead of save to select and update particular columns
...
9ec6ef85b6
2019-04-25 11:56:57 +05:30
4a03b21f80
Exclude large tables when remapping in `Upload.migrate_to_new_scheme`.
...
Those tables do not carry any information about uploads.
2019-04-25 11:55:48 +08:00
aadb7da7d3
FIX: Use first grapheme cluster for letter avatar
2019-04-24 23:20:46 +02:00
03f9564804
FIX: Handle missing letter avatar
2019-04-24 23:20:46 +02:00
3aa143a52c
SECURITY: Fix tab nabbing.
2019-04-25 00:11:28 +03:00
505c5addca
Allow signup form width to increase when no external logins are present
2019-04-24 13:08:39 -04:00
6df8c4b8f0
FIX: Fall back to large logo on mobile no_ember pages
2019-04-24 11:39:11 -04:00
e4d8d80cf8
FIX: Make sure we hide the first post in a topic by an ignored user ( #7428 )
2019-04-24 16:00:20 +01:00
1a8c6577e0
FIX: refactor padding when exiting composer
...
Previously, when existing composer, the `#main-outlet` element padding was set to zero. This inline style would override any CSS set for that element, causing issues with the mobile footer nav.
The fix removes the inline padding style instead of setting it to zero. It also uses integers for the set values, and removes a duplicate style.
2019-04-24 10:26:35 -04:00
ad61d87ffb
FIX: Do not replace text of collapsed ignore posts ( #7422 )
2019-04-24 13:54:46 +01:00
a452933071
FIX: disable input zoom on search in iOS
2019-04-24 08:41:20 -04:00
be88ac8b7e
Additional old `Upload#url` format for `Upload.migrate_to_new_scheme`.
2019-04-24 18:19:25 +08:00
9ec6ef85b6
Don't validate post when saving in `Upload.migrate_to_new_scheme`.
2019-04-24 17:17:31 +08:00
3c9495b989
DEV: Put a mutex around `Upload.migrate_to_new_scheme`.
...
This ensures that only one migration is running at any given point in
time across the instances.
2019-04-24 17:07:10 +08:00
55f406bb79
Follow up to 845b68f9ab.
2019-04-24 16:57:45 +08:00
104a9e79f9
UX: User card loading ( #7404 )
2019-04-24 11:55:09 +03:00
7334362b77
FEATURE: generic theme component bbcode wrapper ( #7400 )
...
Usage:
```
[wrap=name foo=bar]
hello world
[/wrap]
```
2019-04-24 10:37:34 +02:00
845b68f9ab
Update possible upload url format for `Upload.migrate_to_new_scheme`.
2019-04-24 16:26:54 +08:00
c811e59898
Avoid hardcoding db name in `Upload.migrate_to_new_scheme`.
2019-04-24 15:25:24 +08:00
Vinoth Kannan
Maja Komel
Joffrey JAFFEUX
Sam Saffron
Neil Lalonde
Gerhard Schlager
Régis Hanol
Arpit Jalan
Robin Ward
David Taylor
Penar Musaraj
Guo Xiang Tan
Bianca Nenciu
Dan Ungureanu
Bianca Nenciu
Blake Erickson
Roman Rizzi
Saurabh Patel
Joe
Tim Lange
Rafael dos Santos Silva
Tim Lange
Tarek Khalil
Kris