Commit Graph

12965 Commits

Author SHA1 Message Date
Guo Xiang Tan 6955c39c68 UX: Fix width on avatar flair. 2016-12-22 14:30:49 +08:00
Guo Xiang Tan 8551d821a0 FEATURE: Add site setting to disable group directory. 2016-12-22 14:14:22 +08:00
Sam c531f4ded5 remove rails-observers
Rails yanked out observers many many years ago, instead the functionality
was yanked out to a gem that is very lightly maintained.

For example: if we want to upgrade to rails 5 there is no published gem

Internally the usage of observers had quite a few problem.

The series of refactors renamed a bunch of classes to give us more clarity
and removed some magic.
2016-12-22 16:46:53 +11:00
Sam 019f1a1d06 UserEmailObserver is now removed
no big surprises here was pretty straightforward

after_commit semantics sure are weird though
2016-12-22 16:46:53 +11:00
Sam 2f6a4cc6de remove UserActionObserver, replace with after_save and service
interestingly there was some left over dead code from when stars
existed in the topic_users table
2016-12-22 16:46:53 +11:00
Guo Xiang Tan 96c70c74a1 Merge pull request #4619 from tgxworld/group_page_design
UX: Redesign group page to follow user page.
2016-12-22 13:42:28 +08:00
Guo Xiang Tan a5fead3857 UX: Redesign group page to follow user page. 2016-12-22 13:08:59 +08:00
Sam 0a78ae739d Remove SearchObserver, aim is to remove all observers
rails-observers gem is mostly unmaintained and is a pain to carry forward
new implementation contains significantly less magic as a bonus
2016-12-22 13:13:14 +11:00
Robin Ward 31cda7b372 FIX: Can't seem to use ES6 in this file 2016-12-21 16:50:57 -05:00
Robin Ward 89bdca9c8c FIX: Backwards compatibility for controller in raw templates 2016-12-21 16:38:57 -05:00
Robin Ward 1463e9ae46 FIX: Couldn't resolve raw customization 2016-12-21 16:19:04 -05:00
Neil Lalonde eb23a8c173 FIX: when changing category, watch for pasted link in title field 2016-12-21 14:57:12 -05:00
Robin Ward e85904b98f FIX: Clamp last read position to height of the widget 2016-12-21 14:24:15 -05:00
Neil Lalonde 783490f763 FIX: with featured links enabled and uncategorized topic not allowed, allow featued links behaviour before choosing a category 2016-12-21 13:40:05 -05:00
Neil Lalonde b5cc6851cf FIX: tag chooser input was navigating to tag pgaes on some mobile browsers 2016-12-21 12:01:53 -05:00
Robin Ward 44ddc113e7 FIX: Couldn't route to the default route with a query param 2016-12-21 11:18:22 -05:00
Robin Ward ca20560d1f FIX: Should use `RAW_TEMPLATES` scope for header customizations 2016-12-21 10:54:23 -05:00
Guo Xiang Tan c897e5599a FIX: Group mobile nav not updating. 2016-12-21 21:16:52 +08:00
Guo Xiang Tan a37a6f57d9 FIX: Automatic groups should be editable via groups page. 2016-12-21 21:11:49 +08:00
Guo Xiang Tan 5e75d5c1bf PERF: N+1 query on groups page. 2016-12-21 20:59:09 +08:00
Guo Xiang Tan 076a08d8e1 FIX: Unactivated users should not be automatically added into groups as well. 2016-12-21 18:15:01 +08:00
Guo Xiang Tan 7228081820 FIX: Automatic group membership should not add staged or unactivated users. 2016-12-21 18:04:26 +08:00
Guo Xiang Tan 13c6191e89 FIX: Don't allow invalid email to be saved. 2016-12-21 17:47:11 +08:00
Guo Xiang Tan 5d7f3223f0 SECURITY: Users can only bookmark posts which they can see. 2016-12-21 12:01:26 +08:00
Robin Ward 1821a0933d FIX: Missing CSS for back button on progress component 2016-12-20 16:01:15 -05:00
Neil Lalonde c75bebdea2 FIX: uncategorized setting to control whether topic featured links are allowed 2016-12-20 15:55:30 -05:00
Robin Ward 1cbe355c5b FIX: Timeline back button was docking too aggressively 2016-12-20 13:32:54 -05:00
Robin Ward f0f5fbf132 FIX: Never show the last read marker within 1 post of the last 2016-12-20 13:22:22 -05:00
Robin Ward 1be800b673 FIX: Prioritize raw template overrides from plugins 2016-12-20 13:07:09 -05:00
Neil Lalonde 158670ca5e FIX: if categories page is default, redirect to Top was never working 2016-12-20 12:06:58 -05:00
Robin Ward da4e27ca7d FIX: Allow resolution of `javascripts` prefixed raw templates 2016-12-20 11:53:43 -05:00
Robin Ward 16b236899c FIX: `custom-html` tag had broken information 2016-12-20 11:49:30 -05:00
Régis Hanol c302ffe08f FIX: buttons in user admin page weren't working 2016-12-20 12:26:53 +01:00
Régis Hanol 3c3008fec3 FIX: clicking 'Show Email' on admin page wasn't working 2016-12-20 11:35:13 +01:00
Régis Hanol bf9e59eda9 FIX: add option for the oneboxer to be synchronous 2016-12-20 11:18:03 +01:00
Guo Xiang Tan 6461021046 FIX: Only show membership status on index page. 2016-12-20 15:50:12 +08:00
Guo Xiang Tan 9db5d5b6a7 FIX: Incorrect serializer for groups page. 2016-12-20 15:44:22 +08:00
Guo Xiang Tan 7c7c233c1c FIX: Can't update `Groups#allow_membership_requests` in admin. 2016-12-20 15:14:35 +08:00
Guo Xiang Tan c15bf62b43 FIX: Display empty message when no groups can be shown. 2016-12-20 14:47:39 +08:00
Guo Xiang Tan 502e114c60 FIX: Incorrect count when loading more groups. 2016-12-20 14:39:44 +08:00
Guo Xiang Tan 193f8301a4 FIX: Do not show automatic groups to normal users. 2016-12-20 14:26:49 +08:00
Guo Xiang Tan 375f3feeb8 FIX: Topic featured links not getting oneboxed immediately. 2016-12-20 10:27:12 +08:00
Régis Hanol 52cd9972bb FIX: prevent DDoS with lots of _oneboxable_ links
FIX: ensure the onebox route is only allowed to logged in users
FIX: only allow 1 outgoing onebox preview per user
FIX: client should only do 1 preview at a time
2016-12-20 00:31:10 +01:00
Sam 6965079108 Merge pull request #4606 from mabras/fix_arabic_pluralization
Fix Arabic Pluralization Rules for Client
2016-12-20 09:17:59 +11:00
Robin Ward 8757ae3b92 FIX: The docked back button didn't work so well on iPad / short topics 2016-12-19 17:16:42 -05:00
Sam 2b808ad9da Merge pull request #4609 from joebuhlig/category-topics-wiki
FEATURE: Category setting to make all topics wikis
2016-12-20 09:15:51 +11:00
Neil Lalonde a65281d5ea FIX: better support for featured link topics in summary emails 2016-12-19 17:05:49 -05:00
Neil Lalonde 3256620d5d FIX: some blank topics and posts in summary email because they're images 2016-12-19 16:21:31 -05:00
Neil Lalonde 74956694e5 If summary email finds no topics, show topics more than 1 day old from new users 2016-12-19 14:54:08 -05:00
Neil Lalonde 923cf73c6e Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox. 2016-12-19 14:54:07 -05:00
Robin Ward 4dcb29acbf UX: Show Back button above mobile progress widget 2016-12-19 14:06:19 -05:00
Robin Ward 36449aa2f2 UX: Docking back button on topic timeline 2016-12-19 13:33:55 -05:00
Robin Ward 05e99a68ce FIX: Refresh header if topic details are updated 2016-12-19 12:25:28 -05:00
Robin Ward e03d5e2140 Reapply Ember 2.10 for good this time!
This reverts commit ddd299f4aa.
2016-12-19 11:19:10 -05:00
Joe Buhlig 87251fded7 FEATURE: Category setting to make all topics wikis
FEATURE: Category setting to make all topics wikis
2016-12-19 06:42:18 -06:00
Guo Xiang Tan 18c8323987 FIX: Incorrect path for redirect. 2016-12-19 18:12:15 +08:00
Sam e0ff57ca75 SECURITY: prevent reuse of password reset 2016-12-19 18:00:22 +11:00
Sam eb2db23b40 FEATURE: remove email_token_grace_period_hours
The site setting email_token_grace_period_hours just causes confusion and
should not be used anyway.

Out of the box, tokens stop working once confirmed, no need to add complexity here
2016-12-19 17:15:20 +11:00
Sam dd383300b1 FEATURE: rate limit by login on password reset 2016-12-19 11:03:07 +11:00
Sam 0599bd0154 FEATURE: add referrer never tag to password reset page 2016-12-19 11:01:58 +11:00
Sam 15b5fddd49 SECURITY: protect upload params, only allow very strict filenames 2016-12-19 10:16:18 +11:00
Sam 30e0154e5d SECURITY: fix reflected XSS with safe_mode param
(only applies to beta and master)
2016-12-19 10:11:51 +11:00
Mohamad Abras e20e765afe Fix Arabic Pluralization Rules for Client 2016-12-17 17:50:35 +02:00
Jeff Atwood 81956cb1d6 Merge pull request #4590 from xfalcox/css-highligth
Use CSS animations for post and topic highlights
2016-12-16 14:22:25 -08:00
Rafael dos Santos Silva e9fa936389 Uses CSS animation for highlight on mobile too 2016-12-16 19:26:49 -02:00
Guo Xiang Tan d8541c589a FIX: Incorrect route for updating username. 2016-12-17 00:23:12 +08:00
Robin Ward ddd299f4aa Revert "Revert "Revert Ember 2.10+ for a short while""
This reverts commit 76bbc481cb.
2016-12-16 10:29:30 -05:00
Robin Ward 76bbc481cb Revert "Revert Ember 2.10+ for a short while"
This reverts commit 21682fd60b.
2016-12-16 09:52:29 -05:00
Guo Xiang Tan e3213f127d FIX: Regression with request membership button after migrating to component. 2016-12-16 16:07:11 +08:00
Sam d4a0508744 FEATURE: outlet prior to Reply button at the bottom of topics 2016-12-16 17:10:32 +11:00
Sam 61eb134181 FEATURE: setting to allow arbitrary redirects from sso origin
if sso_allows_all_return_paths is set to true you can redirect off-site from sso success
2016-12-16 13:37:44 +11:00
Sam 6ff309aa80 SECURITY: don't grant same privileges to user_api and api access
User API is no longer gets bypasses that standard API gets.
Only bypasses are CSRF and XHR requirements.
2016-12-16 12:05:43 +11:00
Robin Ward 21682fd60b Revert Ember 2.10+ for a short while 2016-12-15 16:43:38 -05:00
Neil Lalonde f01f95d62d FEATURE: new settings to customize some colors in emails 2016-12-15 14:43:53 -05:00
Neil Lalonde 62ba5ea33f Name before username in summary email 2016-12-15 14:43:52 -05:00
Robin Ward d0ddceb4e4 UX: Try improving the back button on the timeline 2016-12-15 14:24:58 -05:00
Robin Ward 250ca11416 Add PluginAPI for registering a connector class 2016-12-15 11:54:37 -05:00
Robin Ward 0348f23f6d FIX: Register a test waiter rather than using hidden properties 2016-12-15 11:36:21 -05:00
Robin Ward 40c944cb36 FIX: Was showing two rows for the title always 2016-12-15 10:47:43 -05:00
Robin Ward d69b782737 FIX: Editing tags was double rendering 2016-12-15 10:40:11 -05:00
Robin Ward 2655be512f FIX: Showing raw email and history were broken 2016-12-15 10:28:15 -05:00
Robin Ward ea3db56d1c FIX: Mobile raw templates were not being resolved 2016-12-15 10:28:15 -05:00
Robin Ward 28699e66d8 Revert "REVERT: Ember 2.10 -- it's not building properly"
This reverts commit 600541c623.
2016-12-15 10:28:15 -05:00
Guo Xiang Tan bbe067e735 Fix eslint. 2016-12-15 16:07:56 +08:00
Guo Xiang Tan 7888a16374 FEATURE: Add membership request to groups page. 2016-12-15 14:39:13 +08:00
Sam 162413862c FEATURE: add `staff` class to HTML body for staff 2016-12-15 16:23:03 +11:00
Sam 98f4a2adcb FIX: on 404 from brotli asset path return a correctly encoded doc
old implementation would cache the 404 for 1 year with incorrect encoding

hilarity would ensue
2016-12-15 16:05:20 +11:00
Sam f867af6bf9 bye bye byebug 2016-12-15 15:52:25 +11:00
Guo Xiang Tan 3666575b46 UX: Improve styling for groups page. 2016-12-15 12:19:13 +08:00
Guo Xiang Tan 3999afc279 FIX: Category logo not showing in navigation. 2016-12-15 12:11:21 +08:00
Guo Xiang Tan b005e1ab58 UX: Left align columns on groups page. 2016-12-15 10:00:37 +08:00
Neil Lalonde a26c3fe2b6 FIX: truncate long topic titles in summary email 2016-12-14 12:59:01 -05:00
Neil Lalonde d23da5b641 FIX: digest email preview error in Persian and other languages 2016-12-14 11:10:32 -05:00
Robin Ward 2164d7d21c FIX: User card spacing was off 2016-12-14 10:46:16 -05:00
Guo Xiang Tan 4b940dc8bd FEATURE: Add groups page. 2016-12-14 17:27:47 +08:00
Guo Xiang Tan 0c9499874d FIX: Missing no members message on group page. 2016-12-14 14:01:19 +08:00
Neil Lalonde 66151b416f FIX: home logo href doesn't respect subfolder 2016-12-13 16:30:21 -05:00
Robin Ward 03bc6f70f9 Better error messages when embedding fails 2016-12-13 14:38:05 -05:00
Neil Lalonde 1f0793ac50 Improvements to automatic topic title based on pasted link 2016-12-13 13:11:52 -05:00
Neil Lalonde 67a0a36362 FIX: topic lists on mobile should include featured links 2016-12-13 13:11:52 -05:00
Guo Xiang Tan 2686ee5ab2 FIX: Admin can't add/remove public group users. 2016-12-13 16:39:44 +08:00
Guo Xiang Tan 43ee9f884e FEATURE: Add `Group#full_name`. 2016-12-13 16:16:26 +08:00
Guo Xiang Tan 5a2794a0c7 FIX: `Discourse.ajax` is deprecated. 2016-12-13 15:53:04 +08:00
Guo Xiang Tan fbd3727c7d UX: Improve group edit style for mobile. 2016-12-13 15:26:28 +08:00
Guo Xiang Tan f4af74b7b3 FIX: Incorrect class. 2016-12-13 15:20:59 +08:00
Guo Xiang Tan 0e934a2f2d Make eslint happy. 2016-12-13 15:17:14 +08:00
Guo Xiang Tan 7bfabb029b UX: Move editing group from into an individual tab. 2016-12-13 15:15:20 +08:00
Guo Xiang Tan 5a5aea72b5 Remove icon from group tabs. 2016-12-13 13:12:38 +08:00
Guo Xiang Tan 6dab7f4463 UX: Keep table styles consistent with topic list. 2016-12-13 13:11:34 +08:00
Guo Xiang Tan 69330f8bc2 Add user_updated event to webhooks. 2016-12-13 11:26:26 +08:00
Robin Ward 600541c623 REVERT: Ember 2.10 -- it's not building properly 2016-12-12 16:19:05 -05:00
Robin Ward 749f7071f3 FIX: `Object.assign` isn't available to phantom 2016-12-12 15:23:52 -05:00
Robin Ward c2462e1f2d FIX: Missing plugin outlet 2016-12-12 14:44:29 -05:00
Robin Ward 7b2e4170e9 Safer checkUrl 2016-12-12 14:44:29 -05:00
Robin Ward b6e03116ba Auto discover connector classes. Support a setup method 2016-12-12 14:44:29 -05:00
Robin Ward 9a7998a930 Various fixes for Ember 2.10 2016-12-12 14:44:29 -05:00
Robin Ward 2efe4900cf Plugin Outlets need their arguments to be explicit 2016-12-12 14:44:29 -05:00
Robin Ward a808bcb0b8 Upgrade to Ember 2.10 2016-12-12 14:44:29 -05:00
Robin Ward 765e5e9186 Upgrade to Ember 2.9 2016-12-12 14:44:29 -05:00
Neil Lalonde 239d06b218 add Likes Recieved to possible stats in summary email 2016-12-12 14:20:25 -05:00
Arpit Jalan 70227d37d7 FIX: composing new pre filled topic with tags was broken 2016-12-12 22:27:53 +05:30
Guo Xiang Tan 4a1340b14e Update annotations. 2016-12-12 22:59:40 +08:00
Guo Xiang Tan da7009a968 FEATURE: Add request membership button for allowed groups. 2016-12-12 22:48:08 +08:00
Régis Hanol 664feca199 FIX: don't send emails from muted users in mailing list mode 2016-12-12 15:28:26 +01:00
Guo Xiang Tan 405ffbf5a4 FIX: Don't show logs if user is not an admin or group owner. 2016-12-12 20:30:09 +08:00
Guo Xiang Tan 5db6306218 FIX: Incorrect empty message. 2016-12-12 19:39:58 +08:00
Guo Xiang Tan 9a800107cb FIX: Associate category logo and background to uploads record. 2016-12-12 17:37:28 +08:00
Guo Xiang Tan 05f55dbc10 FEATURE: Group logs. 2016-12-12 17:29:54 +08:00
Guo Xiang Tan 790f1ef9f3 FIX: Permit missing params. 2016-12-12 17:00:30 +08:00
Guo Xiang Tan b5cc5a6fb1 Unify group translations under same key. 2016-12-12 17:00:30 +08:00
Guo Xiang Tan c3b04c3054 Fix: Group avatar flair inputs style. 2016-12-12 17:00:30 +08:00
Guo Xiang Tan be5b5f6bea FEATURE: Public groups. 2016-12-12 17:00:30 +08:00
Guo Xiang Tan 78553151ea Update annotations. 2016-12-12 17:00:30 +08:00
Arpit Jalan 495c8f2794 FIX: bulk invite button was not getting re-enabled after performing upload 2016-12-12 14:08:10 +05:30
Sawood Alam 77ef730f20
RTL direction assigned to Urdu language 2016-12-10 18:57:48 -05:00
Neil Lalonde 17bc42fe85 FIX: box style category badges in emails, and shrink text and some spacing in summary email 2016-12-09 16:59:54 -05:00
Neil Lalonde fb2633366a FIX: featured link topics shouldn't require the same min post length 2016-12-09 15:46:26 -05:00
Neil Lalonde a62b028e16 Remove the open_topic_featured_link_in_external_window setting. Use the user preference. 2016-12-09 13:48:29 -05:00
Neil Lalonde a4c4f13901 Remove the topic_featured_link_onebox setting. We will always try to onebox a link and add it to the body if topic_featured_link_enabled is enabled. 2016-12-09 13:28:12 -05:00
Robin Ward f07443b488 Migrate Discourse Polls to use vdom instead of embedded ember 2016-12-09 10:42:56 -05:00
Sam 02b21a26dd Merge pull request #4585 from ibnesayeed/urdu-support
Add initial Urdu support with RTL direction
2016-12-09 13:01:25 +11:00
Sam 861a91d48a correct styling for tracking button on mobile 2016-12-09 12:20:33 +11:00
Neil Lalonde 03ec8f8089 fix focus after attempting to onebox 2016-12-08 16:27:19 -05:00
Neil Lalonde fbd8e6ed4a FEATURE: pasting a link into the title of the composer can automatically onebox it and update the title 2016-12-08 16:09:46 -05:00
Robin Ward f6f03ac009 FIX: Double clicking full name was broken too 2016-12-08 11:10:10 -05:00
Arpit Jalan 3d4299151c Merge pull request #4596 from techAPJ/composer
FEATURE: show close button instead of maximize in collapsed composer
2016-12-08 21:31:54 +05:30
Arpit Jalan d9459d09ed FEATURE: show close button instead of maximize in collapsed composer 2016-12-08 20:11:58 +05:30
Arpit Jalan 42b14b0d11 SECURITY: escape advanced search term 2016-12-08 14:54:36 +05:30
Sam Saffron b4cafc5e78 UX: add notification level button to mobile 2016-12-08 17:47:57 +11:00
Guo Xiang Tan b9b4b0c175 FIX: Members should be ordered by username. 2016-12-08 14:27:38 +08:00