9a17b19636
FIX: don't hide back button at the bottom of timeline ( #7544 )
2019-05-15 19:02:48 +02:00
fc5bb39096
FIX: Do not send duplicate alerts for the same post ( #7476 )
2019-05-15 18:47:36 +02:00
1299c94a52
FIX: Make serverside and clientside omniauth origin redirects consistent
...
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
2019-05-15 12:40:51 +01:00
1d3375b176
FEATURE: Preserve notifications levels when splitting topics. ( #7494 )
2019-05-15 17:29:29 +10:00
42b10a646d
FIX: return 404 only if upload url also not internal.
2019-05-15 02:06:54 +05:30
e0fe01925e
FIX: make frozen string mutable in incoming_domain
2019-05-14 17:44:53 +02:00
d127119549
REFACTOR: user-selector take 2 ( #7540 )
2019-05-14 09:43:29 +02:00
624184560e
PERF: improve performance of publish_notifications_state
...
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.
On some heavy notification related sites this can be a major CPU user on PG
This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
2019-05-14 16:02:55 +10:00
6f747c6b71
FIX: don't allow username to be changed to same as password
...
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
2019-05-13 16:43:40 -04:00
bbab60fa9b
FIX: Don’t try to delete inactive moderators
...
follow-up to 6d77156a
2019-05-13 21:44:03 +02:00
7707d5db2d
Revert "REFACTOR: user-selector ( #7529 )"
...
This reverts commit 9a56df89f0
2019-05-13 19:39:30 +02:00
a2b1789c3e
FIX: do not log username change if the save process was unsuccessful
2019-05-13 22:20:27 +05:30
fb1da53dff
FIX: Issue with incorrect heights when cloaking plugin content in posts
...
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.
Co-authored-by: nlalonde
Co-authored-by: pmusaraj
2019-05-13 11:29:21 -04:00
7326ddea6d
REFACTOR: tags mixin ( #7533 )
2019-05-13 17:05:21 +02:00
b8db702a02
REFACTOR: admin-user-index route ( #7534 )
2019-05-13 17:04:41 +02:00
717aa764b6
FIX: more efficient topic-footer-button-api ( #7535 )
2019-05-13 17:04:24 +02:00
750c125707
DEV: Include foreign keys in model annotations
2019-05-13 15:53:42 +01:00
607c671003
Fix string literal when switching theme in dev env
2019-05-13 10:25:51 -04:00
f1b0782624
UI: Adjust footer nav bar size in iOS app
2019-05-13 10:25:51 -04:00
1bff81419e
DEV: Update annotations
2019-05-13 15:24:24 +01:00
53d2232731
FIX: Remove trailing slash from topic URL
...
this lead to duplicate slashes in concatenated URLs
2019-05-13 14:51:45 +02:00
df18243827
FIX: prevents exception if report doest define filters ( #7532 )
2019-05-13 13:34:28 +02:00
9a56df89f0
REFACTOR: user-selector ( #7529 )
2019-05-13 13:03:12 +02:00
25b39b86ae
FIX: reload the user record instead of fetching via email
2019-05-13 15:16:53 +05:30
e64ed9dbc1
REFACTOR: edit-category controller ( #7527 )
2019-05-13 11:30:32 +02:00
64c117519e
Fix modifying frozen strings errors take 3.
2019-05-13 16:45:23 +08:00
74989783da
Fix modifying frozen strings error in `OneboxController`.
2019-05-13 16:25:52 +08:00
b584e30902
Fix modifying frozen strings error take 2.
2019-05-13 16:23:45 +08:00
9b75320d63
FIX: track mutations on topic edit category-chooser only on select ( #7528 )
2019-05-13 10:22:28 +02:00
d643294c9d
FIX: delete duplicate invites earlier in the process
...
There was a race condition when 2 invites existed for 1 user where in some
cases data from both invites would be used for the redeem. Depending on DB
ordering.
Fix is to delete duplicate invites earlier in the process prior to
`redeem_from_email` being called.
2019-05-13 17:42:39 +10:00
81c329fbb8
FIX: Customizing missing pluralized translations didn't work
2019-05-13 09:36:05 +02:00
d369b84ced
Fix modifying frozen strings error.
2019-05-13 14:31:20 +08:00
8165ceb320
Make rubocop happy.
2019-05-13 09:55:44 +08:00
30990006a9
DEV: enable frozen string literal on all files
...
This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.
Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
2019-05-13 09:31:32 +08:00
a859ddc77e
Improve theme/component delete modal warning
2019-05-10 14:14:12 -04:00
c093fa0376
PERF: reduces cpu/memory consumption of sk in some cases ( #7525 )
2019-05-10 17:12:10 +02:00
643c75c419
FIX: Don't increment version if the reviewable operation fails
...
In fact, roll back the entire operation in the database.
2019-05-10 09:53:25 -04:00
abbe812a0d
FIX: Correct CSS for instagram video play icon
2019-05-10 10:46:07 +01:00
4096d559b5
REFACTOR: user-stream model ( #7515 )
2019-05-10 10:05:43 +02:00
a85b7feef4
REFACTOR: composer controller ( #7516 )
2019-05-10 10:05:29 +02:00
7aedc92a35
REFACTOR: login-controller ( #7514 )
2019-05-10 10:05:11 +02:00
63a3caa516
FIX: Don't display option for users to flag and notify a bot.
2019-05-10 10:05:03 +08:00
0ab6c6e24e
PERF: speed up spec suite, avoid featuring topics
...
Before: 6:05
After: 5:42
Featuring topics for `list/categories` is a very expensive operation that
happened each time we created a topic. This introduces a test only bypass
2019-05-10 11:37:53 +10:00
34684af195
FIX: Show error message if message exists
2019-05-09 22:12:51 +02:00
b380ed5282
FEATURE: Claim Reviewables by Topic
...
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
2019-05-09 13:40:36 -04:00
8dfb15a2e5
FIX: Do not show self edits in Post Edits report. ( #7510 )
2019-05-09 20:39:17 +03:00
ea3004ef11
UX: Save scroll position in tags topic list. ( #7511 )
2019-05-09 20:39:03 +03:00
2a45933ff2
FIX: reduce iPad app nav padding
2019-05-09 10:25:22 -04:00
c06b00a54e
FIX: Hide Uncategorized in site menu when disabled. ( #7509 )
2019-05-09 14:08:10 +03:00
4e91839c97
FIX: Remove default val for colors step if a default theme has been set.
...
Running through the wizard after a default theme has been configured
will always revert the default theme to the light theme.
2019-05-09 17:25:09 +08:00
Maja Komel
Penar Musaraj
David Taylor
Bianca Nenciu
Vinoth Kannan
Joffrey JAFFEUX
Sam Saffron
Neil Lalonde
Gerhard Schlager
Régis Hanol
Arpit Jalan
Robin Ward
Guo Xiang Tan
Dan Ungureanu