Commit Graph

9608 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 60f62f6f36
FIX: improves report-show mobile UI (#6229) 2018-08-01 19:54:27 -04:00
Joffrey JAFFEUX 8cbe3cbe26
this file shouldn’t have been comitted 2018-08-01 19:01:47 -04:00
Joffrey JAFFEUX 9073e11943
FIX: improves number/percent support in reports 2018-08-01 18:40:59 -04:00
Penar Musaraj 4a872823e7 Improvements to user drafts (#6226)
* drafts in user profile: only show to user herself (not to admins), use avatar replying to (instead of topic OP), add keyboard shortcut for drafts, simplify display labels

* use JSON when testing Draft.stream
2018-08-02 07:41:27 +10:00
Kris f0bea4ae55 Improve PM participant list 2018-08-01 16:20:14 -04:00
Robin Ward 4eef41ea1b FIX: Error with debouncing mentions 2018-08-01 15:57:24 -04:00
Gerhard Schlager 2ec1aec2be FIX: Clicking admin wrench in topic footer didn't hide post select box 2018-08-01 21:29:35 +02:00
Robin Ward d7b463a03d FIX: Remove unused import 2018-08-01 11:54:47 -04:00
Robin Ward 7c950321d1 FIX: Allow non-english usernames in autocomplete
Also add support for username formatters
2018-08-01 11:53:20 -04:00
Vinoth Kannan 8178444382 Make prettier happy 2018-08-01 15:13:54 +05:30
Vinoth Kannan 8556288397 DEV: Export Tag class to modify methods in plugin 2018-08-01 15:10:15 +05:30
Penar Musaraj 1f45215537 FEATURE: Drafts view in user profile
* add drafts.json endpoint, user profile tab with drafts stream

* improve drafts stream display in user profile

* truncate excerpts in drafts list, better handling for resume draft action

* improve draft stream SQL query, add rspec tests

* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)

* cleanup

* linting fixes

* apply prettier styling to modified files

* add client tests for drafts, includes a fixture for drafts.json

* improvements to code following review

* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix

* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed

* prettier, eslint fixes

* use "username_lower" from users table, added error handling for rejected promises

* adds guardian spec for can_see_drafts, adds improvements following code review

* move DraftsController spec to its own file

* fix failing drafts qunit test, use getOwner instead of deprecated this.container

* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Guo Xiang Tan 70ea153dce Fix lint. 2018-08-01 12:23:36 +08:00
Guo Xiang Tan 53adbf70f3 FIX: Nav item missing for plugins that don't include a custom filter. 2018-08-01 11:50:14 +08:00
Guo Xiang Tan 919e8db686 FIX: Check for group name availability should skip reserved usernames. 2018-08-01 11:09:33 +08:00
Joffrey JAFFEUX 2b2a506a7b
FIX: makes dashboard more resilient to errors (#6217)
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX 0715aa18da
UI: uses tiny avatars for reports (#6215) 2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX 37252c1a5e
UI: improves dashboard table reports
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
Robin Ward 4b166cccc1 FIX: Linting error 2018-07-31 14:19:45 -04:00
Robin Ward b6bb8df622 FIX: We loosened username restrictions some time ago
Additionally, remove `Discourse.User` constant
2018-07-31 13:53:31 -04:00
Vinoth Kannan ece3cb73df Rename humburger_menu_categories_count site setting to header_dropdown_category_count 2018-07-31 09:12:30 +05:30
Vinoth Kannan c1e62808ed FIX: Top site categories are displayed in random order 2018-07-31 01:01:03 +05:30
Joffrey JAFFEUX c6fd506a15
fix eslint 2018-07-30 13:10:20 -04:00
Joffrey JAFFEUX 2c90a2e5c2
FIX: prevents mini-tag-chooser to catch unwanted focus 2018-07-30 13:03:40 -04:00
Joffrey JAFFEUX a327393651
fix 1.14.0 prettier offenses 2018-07-30 11:56:48 -04:00
Joffrey JAFFEUX 536f88b95b Revert "DEV: prettier 1.14.0"
This reverts commit 1f899bec21.
2018-07-30 11:52:05 -04:00
Joffrey JAFFEUX 1f899bec21
DEV: prettier 1.14.0 2018-07-30 11:09:08 -04:00
Vinoth Kannan c54b5824d4 REFACTOR: Prioritize unread categories in hamburger menu 2018-07-30 20:20:10 +05:30
David Taylor 6566b2f11a FEATURE: Allow revoke and connect for Instagram logins 2018-07-30 14:38:53 +01:00
Maja Komel 04baddf731 DEV: migrate tests to async/await 2018-07-30 12:21:05 +02:00
Vinoth Kannan 176d8ca78d
FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:39:37 +05:30
Vinoth Kannan 249b16e8e3 FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:37:41 +05:30
Guo Xiang Tan 581cf62bcf UX: Allow emojis to be displayed in nav-item. 2018-07-30 18:02:34 +08:00
Guo Xiang Tan ef78268c01 Give `ExtraNavItem` more control over when it can be displayed. 2018-07-30 17:30:13 +08:00
Arpit Jalan ba64ebbf10 FIX: preserve whitespace between uploads when the process is complete 2018-07-30 14:49:33 +05:30
Vinoth Kannan 78d91b1daf
UX: Changes in top categories of hamburger menu (#6200) 2018-07-30 14:13:00 +05:30
Arpit Jalan fc3b904e1f remove "track external right clicks" feature 2018-07-29 15:01:33 +05:30
Joffrey JAFFEUX a8f1b07686
FIX: prevents exception when loading old dashboard (#6196) 2018-07-27 16:29:30 -04:00
David Taylor 5f1fd0019b FEATURE: Allow revoke and connect for GitHub logins 2018-07-27 17:18:53 +01:00
David Taylor 6296f63804 FEATURE: Revoke and connect for Yahoo logins 2018-07-27 16:20:47 +01:00
Vinoth Kannan a9c959e3e2 Make prettier happy 2018-07-27 20:39:44 +05:30
Vinoth Kannan bc501038cb FIX: Remove null value from categories list 2018-07-27 20:00:39 +05:30
David Taylor 9c72c00206 FEATURE: Revoke and reconnect for Twitter logins 2018-07-27 12:28:51 +01:00
Vinoth Kannan 5b4e13bfcc Make prettier happy 2018-07-27 13:20:21 +05:30
Vinoth Kannan c0f7d95bb8 Include subcategories in hamburger menu top categories 2018-07-27 13:05:18 +05:30
Vinoth Kannan dac29b5ebc
UX: Display only top categories in hamburger menu (#6146) 2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX b7d1864d0a
FIX: simplify filters on admin-report component (#6193) 2018-07-27 01:22:00 -04:00
Joffrey JAFFEUX 262beed1cf
FIX: fixes regression with category filtering (#6190) 2018-07-26 19:08:06 -04:00
Joffrey JAFFEUX 59684adc43
FIX: shows disk usage even if no backups taken (#6189) 2018-07-26 18:38:55 -04:00
Joffrey JAFFEUX 56ae826efb
UI: improves no data notice in reports (#6187) 2018-07-26 15:26:53 -04:00
Joffrey JAFFEUX 330cf78c83
FIX: don’t break browser history on dashboard visit (#6186) 2018-07-26 14:59:28 -04:00
David Taylor 88241f57a3
FEATURE: allow auth plugins to have a site setting for full screen login 2018-07-26 11:11:16 +01:00
David Taylor 63e15aa41a Add missing semicolon 2018-07-26 10:30:10 +01:00
Maja Komel e8d82f48bc add maxlength attribute for 2FA input fields 2018-07-26 10:31:20 +02:00
Kyle Zhao 1ed3a89ac9 UX: clear topic timer text when manually closing/opening (#6123)
* UX: clear topic timer text when manually closing/opening

* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Nick Shearer def2c977ce allow auth plugins to have a site setting for if they should be full screen vs popup window 2018-07-25 19:20:11 -05:00
Kris 0e84024958
Updating style of theme options in wizard (#6177) 2018-07-25 15:32:14 -04:00
Joffrey JAFFEUX ad95c24307
FEATURE: displays a notice if report has no data (#6178) 2018-07-25 14:28:41 -04:00
Joffrey JAFFEUX 6ee1ea96ef
fixes tests (#6176) 2018-07-25 14:02:21 -04:00
Joffrey JAFFEUX 01d1f850e9
FEATURE: uses category-chooser for report filtering (#6174) 2018-07-25 13:16:35 -04:00
Joffrey JAFFEUX fa6b7f6b8c
DEV: adds Object.entries and Object.assign polyfills (#6173) 2018-07-25 11:45:29 -04:00
David Taylor fa399ce1c5 FEATURE: Add revoke and reconnect functionality for google logins 2018-07-25 16:03:14 +01:00
Régis Hanol 637850d867 REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal 2018-07-25 12:38:15 +02:00
Dan Ungureanu 44a5c29d42 Clear old text and URL when showing up the "Insert Hyperink" modal. (#6138) 2018-07-25 17:12:49 +10:00
Dan Ungureanu f540020d1d Add different trigger for the emoji popup of French users. (#6140) 2018-07-25 16:39:06 +10:00
Régis Hanol 8ca25f5aed UX: open the change avatar modal when clicking the profile picture 2018-07-24 15:13:21 +02:00
Joffrey JAFFEUX 7a3c541077
UX: Preview multiple color schemes in wizard (#6151)
It was a dropdown to provide choices of color schemes,
and only one scheme could be shown.
With this commit, multiple color scheme previews can be displayed on
one page at the same time, making admins choose color schemes more
easily.

Theme preview windows are shrinked.

Imported default color schemes.

Co-Authored-By: Misaka 0x4e21 <misaka4e21@gmail.com>
2018-07-24 09:00:20 -04:00
Guo Xiang Tan 5760873580 Fix linting. 2018-07-24 13:43:52 +08:00
Guo Xiang Tan ae8b0a517f PERF: Split skipped email logs into a seperate table. 2018-07-24 13:14:37 +08:00
Sam 95720e3873 lint files 2018-07-24 10:57:16 +10:00
Kyle Zhao c9d4288214 UX: auto fix order when reordering categories (#6149)
* set correct position number when moving up/down

* UX: drop 'fix order' and auto re-order subcategory

- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
2018-07-24 10:25:40 +10:00
Joffrey JAFFEUX 568276fe40
FEATURE: allows tag editing on mobile (#6148) 2018-07-23 14:25:21 -04:00
Joffrey JAFFEUX 73d736c8c3
FIX: popup-menu instantly closing (#6147) 2018-07-23 14:19:36 -04:00
Joffrey JAFFEUX 78419f677d
FIX: multiple select-kit fixes on mobile 2018-07-23 12:19:40 -04:00
David Taylor eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099)
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
Régis Hanol 9b2d6053da UX: don't show the avatar section when overriden by SSO 2018-07-23 12:03:43 +02:00
Dan Ungureanu ba73d91e3b FIX: Display tag related actions only if tagging is enabled. (#6136)
The affected buttons are "Replace Tags" and "Append Tags".
2018-07-23 12:35:08 +10:00
Neil Lalonde 8e5e7c6b43 add links to Top Categories on user summary page 2018-07-22 22:00:41 -04:00
Sam 35bc72ef30 lint file 2018-07-23 10:58:24 +10:00
Dan Ungureanu b14cd2f179 FEATURE: Make the login error message more informative if cookies are disabled 2018-07-23 10:50:41 +10:00
Joffrey JAFFEUX 9ed4071713
fixes dashboard next spec (#6132) 2018-07-21 10:29:58 -04:00
Guo Xiang Tan 5c1bd38d84
Merge pull request #6131 from jjaffeux/lazy-load-reports
FIX: lazy load more reports in dashboard
2018-07-21 17:24:17 +08:00
Guo Xiang Tan 9afc4cf8c1 Revert "add links to Top Categories on user summary page"
This reverts commit 1e37395517.
2018-07-21 15:50:09 +08:00
Joffrey JAFFEUX 1d5096eb46 FIX: lazy load more reports in dashboard 2018-07-20 23:35:53 -04:00
Kris c6fe6a8820 Improving mutli-post select styling 2018-07-20 16:37:43 -04:00
Joffrey JAFFEUX 5e521f8ce6 Revert "FIX: various select-kit corrections on mobile"
This reverts commit 78a2324c89.
2018-07-20 15:28:12 -04:00
Neil Lalonde 1e37395517 add links to Top Categories on user summary page 2018-07-20 15:27:03 -04:00
Joffrey JAFFEUX 78a2324c89
FIX: various select-kit corrections on mobile 2018-07-20 14:46:25 -04:00
Joffrey JAFFEUX 3fdc4f2df1
FIX: do not automatically infere date type (#6127) 2018-07-20 09:35:14 -04:00
Joffrey JAFFEUX 3741dd6b59
removes report logging (#6125) 2018-07-20 08:16:29 -04:00
Arpit Jalan 7d9c97d661 FEATURE: land on specified category page when creating topic via URL 2018-07-20 15:55:05 +05:30
Joffrey JAFFEUX 711df31a9d
FIX: makes top dash titles clickable (#6120) 2018-07-19 19:30:26 -04:00
Joffrey JAFFEUX 64f0cf425b
FIX: removes uncessary reports loading (#6119) 2018-07-19 19:30:13 -04:00
Régis Hanol f83a687551 UX: skip the modal and refresh the app when selecting an avatar 2018-07-20 00:37:57 +02:00
Neil Lalonde dbcf4e2474 FIX: exceptions raised when editing replies were not displaying their error messages 2018-07-19 18:14:08 -04:00
Joffrey JAFFEUX 1a78e12f4e
FEATURE: part 2 of dashboard improvements
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports

Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
Joffrey JAFFEUX a2281fbb19
FEATURE: allows to jump to a date in a topic 2018-07-19 16:00:13 +02:00
OsamaSayegh fa02df9985 FIX: don't suggest groups when inviting to a topic (#6105) 2018-07-19 17:02:34 +08:00
Maja Komel fa38891a98 FEATURE: show modal when user without permissions tries to delete their own topic (#6086) 2018-07-18 23:31:37 +02:00
Maja Komel af1d1db3da UX: use future date input instead of date picker on feature topic modal (#6096) 2018-07-18 23:27:12 +02:00
Régis Hanol c1249d9e1d make linter happy 2018-07-18 23:07:17 +02:00
Régis Hanol facef06d60 UX: reload the page when changing avatar 2018-07-18 22:50:50 +02:00
Neil Lalonde afc94ac9e4 FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity 2018-07-18 16:39:16 -04:00
Régis Hanol f55ac892e4 make code prettier 🎀 2018-07-18 13:09:16 +02:00
Régis Hanol 6d6e026e3c FEATURE: selectable avatars 2018-07-18 12:57:43 +02:00
Sam a24b9981c6 UX: adjust positioning of auto complete vertical
On iPad portrait autocomplete would render off screen
2018-07-18 16:41:31 +10:00
Sam a66d812b92 pick a better icon for auto bump 2018-07-18 11:15:01 +10:00
Robin Ward bec53426c4 Remove pointless method 2018-07-17 12:34:20 -04:00
Philipp Rudloff 79b08b2679 Set result.target for update (matching _saveNew) (#6094)
* Set result.target for update (matching _saveNew)

* Add tests for update result including a target property
2018-07-17 11:56:32 -04:00
Sam 9f1e8d4f58 FIX: inaccurate tracking of current topic
Under some cases we would trigger the "you are replying on a different
topic" when in fact, your were not
2018-07-17 17:24:23 +10:00
Evg b6fba9ecc6 Add plug-in (in search results) (#6090)
* Add to plugin

Add the ability to use the plugin...

* Edit name
2018-07-17 14:44:39 +10:00
Sam 818bc10107 FIX: count subcategories in breadcrumbs 2018-07-17 12:06:48 +10:00
Sam 292e8a3756 FIX: category list should set category on topic 2018-07-17 10:38:42 +10:00
Kris bd51cd52cd Hide edit category tabs with display: none; 2018-07-16 12:37:06 -04:00
Gerhard Schlager d3e04daa95 Add Swahili language 2018-07-16 18:11:38 +02:00
Sam ac0053f491 FEATURE: navigate to first post and auto bump category settings
### navigate_to_first_post_after_read setting for categories

When enabled on categories logged on users will return to OP after
reading the entire category. (useful for documentation categories)

### num_auto_bump_daily

Set a number of topics that will automatically bump daily on a category.

- Every 15 minutes we will check if any category has this setting
- Categories with the setting are shuffled
- We exclude pinned, closed, category description and archived topics
- Maximum of 1 topic for the list of categories is bumped till limit reached per category
- We always try to bump oldest first
- Limit is elastic using a RateLimiter that ensures that we only bump N per day

Also some minor organisation on category settings

Froze strings on category.rb
2018-07-16 18:10:35 +10:00
Leo McArdle 21ebb1cd54 FEATURE: Secondary emails support. 2018-07-16 11:09:49 +08:00
Jeff Wong f3b17b92b7 Fix: delay panning until we can determine direction 2018-07-14 15:57:58 -07:00
Neil Lalonde 7331b0ac07 prettier is offended 2018-07-13 14:57:55 -04:00
Neil Lalonde 8ceed642cb FIX: wrong url for default logos in header on subfolder installs 2018-07-13 14:21:15 -04:00
Guo Xiang Tan b459a589ab FIX: `jumpToPost` no working on megatopics. 2018-07-13 16:16:39 +08:00
Guo Xiang Tan 711371e8c8 FIX: Select+below will ask server for post ids on megatopics. 2018-07-13 15:10:39 +08:00
Kris c2cfb6ebae mobile admin cleanup 2018-07-13 01:43:40 -04:00
Guo Xiang Tan 409a30ce1c FIX: Selecting & moving posts not working on megatopics. 2018-07-13 11:16:43 +08:00
Guo Xiang Tan 18e281606a UX: Clicking admin menu does not hide select posts box. 2018-07-13 10:56:14 +08:00
Kyle Zhao 2901691e87 FEATURE: per-category approval settings (#5778)
- disallow moving topics to a category that requires topic approval
2018-07-13 12:51:08 +10:00
Sam 6bc0f97668 FEATURE: add data-username on user-info blocks
This makes it easier to target in CSS
2018-07-12 18:16:05 +10:00
Sam 1f0bbca87e FIX: on initial load category subcategories were not mapped correctly 2018-07-12 17:59:56 +10:00
Arpit Jalan ea0498ae93 make prettier happy 2018-07-12 12:42:11 +05:30
Sam 67bc972d74 UX: make sure autocomplete does not render off screen 2018-07-12 17:07:25 +10:00
Arpit Jalan bd760e98af FIX: display error message when upload fails in wizard 2018-07-12 12:08:09 +05:30
Sam 87a5cb982c correct action typo 2018-07-12 16:24:28 +10:00
Guo Xiang Tan 7c8cd9cfdd Fix the build. 2018-07-12 14:11:42 +08:00
Sam 29eb9dda59 DEV: add deprecation for currentThemeKey
This ensures that theme components will not explode when attempting to access this
2018-07-12 15:36:38 +10:00
Guo Xiang Tan 258e9e35ca PERF: Make mega topics work without a stream.
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.
2018-07-12 12:46:12 +08:00
Misaka 0x4e21 de4d4747c4 UX: Focus on new topic link that appears on the page via keyboard. (#6081)
- Add an <a> tag to handle keypress events on new topic indicator.
2018-07-12 14:36:19 +10:00
OsamaSayegh decf1f27cf FEATURE: Groundwork for user-selectable theme components
* Phase 0 for user-selectable theme components

- Drops `key` column from the `themes` table
- Drops `theme_key` column from the `user_options` table
- Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column.
- Removes the `default_theme_key` site setting and adds `default_theme_id` instead.
- Replaces `theme_key` cookie with a new one called `theme_ids`
- no longer need Theme.settings_for_client
2018-07-12 14:18:21 +10:00
OsamaSayegh f13a7226db FIX: display tables in posts history diff (#6032) 2018-07-12 14:13:52 +10:00
Joffrey JAFFEUX 1ed4f0ee8a
FIX: datepicker will now default to monday as first day
This will be regardless of the user locale. Many users use english forums even if not from the US and would end up having sunday as the first day of the week in the calendar. This commit follows the international standard.
2018-07-11 23:49:52 +02:00
Neil Lalonde 3b7acbd086 FIX: broken image on password reset page on subfolder installs 2018-07-10 11:10:06 -04:00
Guo Xiang Tan 8f4cb1a742 UX: Timeline lookup on mega topics should use date of current post. 2018-07-10 16:43:20 +08:00
Maja Komel ba7a8db0e8 UX: show custom footer on user activity and preferences pages (#6080) 2018-07-10 16:14:26 +08:00
Sam d9a9682f72 FIX: also count sub categories in hamburger when needed
previously there were cases where we suppress subcategories yet don't count them
this leads to confusion
2018-07-09 16:52:55 +10:00
Guo Xiang Tan 6d0732f7b4 Disable service worker on Apple devices for now.
The service worker is not used for any features
on Apple devices and we've received multiple reports
of service workers causing problems.
2018-07-09 11:34:16 +08:00
Guo Xiang Tan 0ab42e9185 Revert "DEV: Add param that allows service worker to be removed."
This reverts commit cb12f462a2.
2018-07-09 11:29:09 +08:00
Guo Xiang Tan cb12f462a2 DEV: Add param that allows service worker to be removed. 2018-07-09 11:24:06 +08:00
Maja Komel 18f5f646b1 FEATURE: allow selecting a tag when moving posts to a new topic (#6072) 2018-07-06 18:21:32 +02:00
Maja Komel 7cba4cbcc6 FEATURE: allow selecting a tag when moving posts to a new topic (#6074) 2018-07-06 18:21:00 +02:00
Guo Xiang Tan 73e30ff4c2 Revert "Rename s3 vars, change condition when displaying s3 uploads"
The new variables do not reflect that they represent S3 settings.

This reverts commit 24dfa1b657.
2018-07-06 15:53:57 +08:00
Guo Xiang Tan af5cd7e548 Unregister old service workers when `Discourse.ServiceWorkerURL` changes. 2018-07-05 14:57:32 +08:00