9650dbb97c
Refactor topics controller
...
Refactor: 1) TopicsController to reduce code climate complexity.
2) Topic model, addressed comments
fix typo
2013-10-28 11:42:07 +05:30
4929c5db71
FIX: when allow_uncategorized_topics was false, PMs can not be created
2013-10-25 09:33:39 +11:00
666264879c
change it so all topics MUST include a category, we store a special uncategorized category to compensate
...
this cleans up a bunch of internals and removes some settings
2013-10-24 12:08:02 +11:00
1ee49798b2
work in progress wide category list
2013-10-18 11:10:10 +11:00
f8625b5510
Merge pull request #1495 from cored/refactor-topic-invite-by-email
...
Refactor: Topic model
2013-10-17 07:04:12 -07:00
7c03076c2a
Refactored Topic#limit_topics_per_day to reduce code climate complexity
...
Extracted 1) #apply_per_day_rate_limit_for, method as generic
RateLimiter , 2) #limit_first_day_topics_per_day as a separate method,
3) Added User#added_a_day_ago?, 4) Fixed private methods indentation.
2013-10-16 14:58:18 +05:30
ad2ed5fe51
rate limits for topics and posts on first day
...
max_topics_in_first_day and max_replies_in_first_day
2013-10-10 10:32:03 +11:00
3a1e1e046b
Refactor: Topic#invite_by_email
...
Extract Topic#email_already_existas_for? and Topic#grant_permission_to_user
Fix failing spec due to missing variable in extracted method
2013-10-09 13:55:02 -04:00
bccb37b6f3
When creating a topic, don't select a category by default when allow_uncategorized_topics is false. Also, added category validation on the server to enforce allow_uncategorized_topics.
2013-10-08 14:41:20 -04:00
5bf26ec34e
large refactor, ship a few columns from the user table into user_stats
2013-10-07 15:04:59 +11:00
15a973fd45
Improved private message user removal, locale edit
...
replaced array iteration with findProperty (will be renamed and aliased to findBy with Ember 1.1)
added modal dialog to verify
catched nil-error on topic.rb
2013-10-02 19:16:43 +02:00
5caa7a0e4d
improve performance of periodical update job, decrease frequency and shift it by a few minutes
2013-09-30 16:59:16 +10:00
32e3e3f382
update annotations
2013-09-06 17:38:50 +10:00
23d8f5fec7
Replaced delegator methods with Forwardable def_delegator in Topic
2013-08-30 09:29:34 +00:00
bbd79aafd1
Revert "Replaced delegator methods with Forwardable def_delegator in Topic"
...
This reverts commit 3ed037940f
2013-08-29 11:45:27 -04:00
3ed037940f
Replaced delegator methods with Forwardable def_delegator in Topic
2013-08-28 11:25:57 +00:00
b385cdcc34
Extracted featured_users functionality out of Topic.
...
* Created a TopicFeatureUsers model
* Topic#featured_user_ids and Topic#feature_topic_users now delegate to
* a TopicFeatureUsers instance to keep demeter happy.
2013-08-27 09:10:50 +00:00
b13796c35e
Refactoring the feature_topic_users method to improve
...
the code climate score.
2013-08-14 20:42:16 -05:00
652169daf6
Include a list of more new topics in the digest emails at the bottom
2013-08-09 14:43:02 -04:00
f99acebdaa
Rails 4 updates
2013-07-24 21:09:18 +02:00
ea7684fb32
Merge pull request #1226 from stephankaag/rails4_updates
...
Some Rails4 updates
2013-07-22 15:03:37 -07:00
0e3b8fbb24
Remove some calls to `all`. They are not required, and Rails4 raises warnings about them.
2013-07-22 20:44:11 +02:00
b19f631b3a
Some Rails4 updates
2013-07-22 19:01:22 +02:00
31bb08bcdd
added an option to bypass auto tracking of topics on post creation
2013-07-22 15:07:20 +10:00
9e4b0df7ff
69 specs fail in rails 4 now ...not too bad
2013-07-22 15:07:20 +10:00
ecf17cfebb
work in progress, add fidelity to category group permissions (full, create posts, readonly)
2013-07-16 15:46:11 +10:00
b7327942af
Add `deleted_by` to `Trashable` tables
2013-07-09 15:46:36 -04:00
f9d1fcb169
Merge pull request #1140 from stephankaag/code_refactoring
...
Refactor code that raises deprecating warnings in Rails 4
2013-07-09 06:48:48 -07:00
806bd98f99
Update category's topic_count immediately when trashing or recovering a topic; this ensures that a category can be deleted without waiting for the category_stats job to run.
2013-07-08 15:23:20 -04:00
2abfd38aee
Refactor code that raises deprecating warnings in Rails 4
2013-07-08 18:35:11 +02:00
ca7c10df9a
Merge pull request #1139 from stephankaag/correct_image_url_rails4
...
No need to include all ActionView::Helpers in Topic
2013-07-03 23:29:43 -07:00
2c8ed8414c
If an auto-closing topic is manually closed, remove the auto-close countdown
2013-07-03 16:54:41 -04:00
7cc7116680
No need to include all ActionView::Helpers in Topic, we only need the sanitize helper.
...
This also fixes a bug in Rails 4 where image_url gets accidentally overridden.
2013-07-03 21:43:29 +02:00
89b621d31a
Refactor update_all statements in order to prevent deprecation warnings in Rails 4
2013-07-02 18:36:47 +02:00
f6b850e7a4
allow skipping the validations on creation if its an api call AND skip_validations is specified
...
this allows wordpress plugin to post very very short titles or titles that would otherwise be disallowed
2013-07-02 12:23:19 +10:00
7681ba0c32
don't fail this query cause avg_time is 0
2013-06-30 01:30:47 +10:00
799b402778
fix horribly broken invite code, could lead to inviting the wrong person to a conversation
2013-06-19 10:31:19 +10:00
80c42753e1
fix up find as you type for the invite into PM function
...
allow mods to remove users from a PM
2013-06-18 17:17:01 +10:00
3c7eb3a4e8
FIX: null dates crashed the client app. `last_posted_at` was not updating properly on split topic.
2013-06-17 13:02:50 -04:00
e6e81efe85
correct information leak in page not found
2013-06-13 10:27:17 +10:00
77b218a142
FIX: Do not suggest similar topics from secure categories you can't see.
2013-06-12 13:45:11 -04:00
1756f713d6
SECURITY HOLE, upgrade right away if you are using Secure Groups.
2013-06-08 23:52:06 +10:00
169125e96d
Fix a case where a random topic with null slug will be rendered instead of 404
2013-06-07 14:30:26 -04:00
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
2465c9c724
Add min_private_message_title_length site setting so private messages can have short titles
2013-06-04 17:59:23 -04:00
d23ef1d090
FIX: You could update a topic to have a title that's too short if the TextCleaner
...
removed extra characters. Additionally, updating the title will not return an error
message to the client app if the operation fails (rather than failing silently.)
2013-05-31 15:24:13 -04:00
24e32092e7
Refactored two class methods into scopes (to achieve a better 'rails way')
...
Also added some tests to the methods
2013-05-30 21:21:31 +02:00
21a54567ff
Extract TopicStatusUpdate from Topic
2013-05-28 09:01:04 -07:00
54a798eb12
Add Topic#age_in_days for determining age of topic
2013-05-27 18:02:15 -07:00
e1781240a6
Merge branch 'refactoring' of git://github.com/mattvanhorn/discourse
...
Conflicts:
lib/text_sentinel.rb
2013-05-27 10:42:20 -04:00
a15910ad1e
Merge pull request #899 from chrishunt/chrishunt/extract-topic-posters-summary
...
Extract topic posters summary
2013-05-27 06:30:58 -07:00
6024529f81
Extract PostMover from Topic into its own class
2013-05-26 18:42:04 -07:00
b8fbac582e
Add Topic#url for determining url for a Topic
2013-05-25 17:44:32 -07:00
f2b5e20840
Add Topic#max_post_number to find max post number
2013-05-25 17:44:32 -07:00
c1841a6c89
Extract Topic#posters_summary
2013-05-24 15:33:45 -07:00
e5e904aa4e
minor refactorings
2013-05-24 13:36:33 -07:00
d7817cf314
extract TopicNotifier class from topic
2013-05-24 13:36:33 -07:00
ca2dee52db
moved comments to the bottom, they are way less intrusive there
2013-05-24 12:48:32 +10:00
2cd95bc649
lets try out annotations
2013-05-24 12:35:14 +10:00
c4b5821ef8
Revert annotation and non-English I18n changes
2013-05-23 06:44:47 -07:00
7271b90655
annotate topic model
2013-05-22 22:36:01 -07:00
806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
65cd00cf25
moderators now have teeth, more at http://meta.discourse.org/t/moderator-permission-set/6307/5
...
allow pms to be targetted at groups
2013-05-02 15:15:53 +10:00
dc07563c0d
Add unstarred_at column to topic_users so we can permanently track when topics are starred
2013-04-29 11:39:05 -04:00
5cfcdc7ef0
backend for secure categories mostly done (todo pm groups)
2013-04-29 16:33:43 +10:00
dca2fbcefc
add meaningful error message on upload [ fixes #773 ]
2013-04-27 20:26:17 +02:00
81673dcde8
slug memoization in the table
2013-04-24 12:46:43 +10:00
8827dd3e42
speed up tests
2013-04-22 13:48:41 +10:00
5cd6c85e8b
Add bookmarks and favorites to dashboard stats
2013-04-18 14:27:22 -04:00
b24c1a1ad9
better consistency around email case sensitivity
2013-04-15 02:20:33 +02:00
651cfba93f
Add ability to destroy a user with 0 posts
2013-04-12 16:53:00 -04:00
5f30ea7463
Merge pull request #684 from ZogStriP/auto-replace-rules-in-titles
...
auto replace rules in titles
2013-04-10 21:12:20 -07:00
d120a5d139
FIX: setting min_topic_title_length is ignored
2013-04-10 14:54:10 +02:00
c5cf8be864
auto replace rules in titles
2013-04-10 11:00:50 +02:00
bb18b6cb9b
Dashboard: split out private messages from topic and post counts; re-enable report_spec because I think I fixed it...
2013-04-03 13:26:09 -04:00
ac0bc1bb30
Including your avatar if you've posted is confusing. Let's remove it for now.
2013-04-03 11:29:50 -04:00
ee76f1926d
Debugging Tool for Hot Topics
2013-04-02 18:00:53 -04:00
a819a26f34
BUGFIX: New status posts weren't using PostCreator
2013-03-28 16:40:54 -04:00
473a64d39d
Add score, percent_rank to topics. Adds `HotTopic` model and consolidated job to calculate
...
hotness. Note: People on Heroku will have to update their jobs to the new structure
in Heroku.md
2013-03-28 15:39:54 -04:00
96ac0c5569
A site setting for how many similar topics are returned
2013-03-19 13:51:25 -04:00
c1e40f5d19
Convert Post type constants to Enum
2013-03-18 17:55:05 -04:00
ad082cea70
Big commit:
...
- Support for a popup that shows similar topics
- Cleaned up a lot of Javascript
- Cleaned up use of Promises
2013-03-15 14:35:33 -04:00
1103dde5cd
Fix: When you split topics, featured users and like counts were incorrect.
2013-03-12 12:33:42 -04:00
22a4580df5
added profile environment for perftools profiling (1.9.3 only)
2013-03-10 17:21:56 -07:00
22f8100919
requiring is mega expensive, lets not do it every request.
2013-03-10 07:14:52 -07:00
8927432a93
Add stats to the admin dashboard
2013-03-09 15:34:27 -05:00
f8d8272406
Cleaned up TopicUserSpec, introduces clearing of pinned topics
2013-03-07 12:19:25 -05:00
30aae8e793
Topic was not sanitizing <b> and <img> tags from titles
2013-03-06 11:36:42 -05:00
3c1388bbd7
Don't include closed or archived topics in the "new topics" section of the daily digest
2013-03-05 17:22:02 -05:00
239cbd2d58
enforce coding convention
...
replaced every `and` by `&&` and every `or` by `||`
2013-03-05 01:42:44 +01:00
d410f043a9
Merge pull request #290 from alxndr/category-rss
...
RSS for topics in a category
2013-03-01 12:01:26 -08:00
0c99dea153
introduce Enum
2013-03-01 21:16:36 +03:00
fd240c1967
RSS for topics in a category
...
Creates a new route for category RSS
2013-03-01 09:52:59 -08:00
6e5399d544
minor cleanup, using AR querying DSL over raw SQL in some places
2013-02-28 21:54:12 +03:00
12d664a610
refactor Topic
...
* move finding by username/email to User
* make SiteSetting return a range of possible post title lengths
* remove unnecessary conditions
2013-02-26 19:27:59 +03:00
cafc75b238
remove trailing whitespaces ❤️
2013-02-26 07:31:35 +03:00
054a699886
avoid unused variable warning in Topic
2013-02-25 22:13:36 +03:00
65b59f8612
make Topic consume its own scope.
2013-02-21 21:22:02 -06:00
836c3a7379
Support for Fancy topic titles
2013-02-19 16:14:04 -05:00
fac75401ef
category stats shouldn't include deleted topics.
2013-02-16 21:10:18 -06:00
37b0c168bf
Support non-english topic titles
2013-02-14 17:13:03 -05:00
12d3c3b66b
Enforce entropy on flag text
2013-02-08 17:01:43 -05:00
61654ab8f0
Fix all the trailing whitespace
2013-02-07 16:45:24 +01:00
40da901e5d
Introduction of TextSentinel to enforce title and body quality.
2013-02-06 20:53:34 -05:00
2d2b907d2c
Temporary Nuclear option on topic titles - disallow non ascii characters so we
...
can stay on top of the trolls. This is meant to be replaced soon with a more
permissive and safe method of sanitizing.
2013-02-06 15:47:36 -05:00
6f2f7b0589
flagging work, we should be clearing from the mod menu if a topic or post is deleted
2013-02-06 12:13:41 +11:00
21b5628528
Initial release of Discourse
2013-02-05 14:16:51 -05:00
Manoj
Sam
Robin Ward
Rafael George
Neil Lalonde
Claus Strasburger
Einar Jonsson
Ben Hicks
Stephan Kaag
DI2uNk
Chris Hunt
Matt Van Horn
Régis Hanol
Gosha Arinich
Alexander
Dan Neumann
Jakub Arnold