254de64df7
UX: Consistent profile image positioning on desktop and mobile
2019-04-01 22:04:11 -04:00
d8704c11ca
PERF: Better use of index when queueing a topci for search reindex.
...
Also move `Search::INDEX_VERSION` to `SearchIndexer` which is where the
version is actually being used.
2019-04-02 09:53:37 +08:00
9603c906ec
Moving staff counters back to the top of profiles
2019-04-01 21:04:37 -04:00
aa2311a7b0
FIX: Don't reindex posts belonging to a deleted topic for search.
...
Posts belonging to a deleted topic can't be index for search so we need
to avoid loading those post ids.
2019-04-02 07:36:53 +08:00
3fc5dbb045
FIX: Don't attempt to reindex posts that have an empty raw.
...
If the post ids keep loading, we might end up in a situations where
we're always loading the same post ids over and over again without
indexing anything new.
Follow up to daeda80ada
2019-04-02 07:13:33 +08:00
d5a61ab167
FIX: Don't log a second pending action
...
If two people flagged the same post you'd get a "Pending" history event
logged which looked bad.
2019-04-01 17:07:47 -04:00
76669bb5a6
FIX: Don't refer to pending review items as flags
...
They could be queued posts or users, and the notice should reflect that
properly.
2019-04-01 14:46:56 -04:00
6470c85fda
UX: Link directly to the post, not to the topic
2019-04-01 14:29:14 -04:00
fdf4145d4b
FEATURE: Delegated authentication via user api keys ( #7272 )
2019-04-01 13:18:53 -04:00
b375dcb14a
DEV: Introduce parallel rspec testing
...
Adds the parallel_tests gem, and redis/postgres configuration for running rspec tests in parallel. To use:
```
rake parallel:rake[db:create]
rake parallel:rake[db:migrate]
rake parallel:spec
```
This brings the test suite from 12m20s to 3m11s on my macOS machine
2019-04-01 11:06:47 -04:00
13a6a04cad
FIX: ensures popover is hidden when changing route ( #7300 )
2019-04-01 16:23:57 +02:00
4b1b135ede
FIX: handles boolean with popupMenuOption ( #7299 )
...
Handle the case of https://github.com/discourse/DiscoTOC doing this kind of setup:
```
return {
action: "insertDtoc",
icon: "align-left",
label: themePrefix("insert_table_of_contents"),
condition: !composerController.get("model.canCategorize")
};
```
In this case there's no function to call, it's already set.
2019-04-01 16:08:14 +02:00
a6596662dc
FIX: don't enqueue TruncateUserFlagStats job when not needed
2019-04-01 15:53:55 +02:00
6e0e36f790
fix spec ( #7298 )
2019-04-01 14:35:09 +02:00
e986e96227
DEV: removes old dashboard ( #7295 )
2019-04-01 12:39:49 +02:00
3cba10b9ca
DEV: Don't warn when trying to reindex a post with a deleted topic.
2019-04-01 17:04:32 +08:00
541a15e357
UX: user-card adjustments for users with hidden profiles ( #7293 )
...
* adds styles for profile hidden message
* Disable profile links for hidden profiles and add message to indicate the profile is hidden
2019-04-01 10:50:48 +02:00
8794d940d3
Revert `update_columns` -> `update!` when rebaking/post-processing post.
...
`update!` goes through validation which means old posts that doesn't
adhere to the existing validations will raise an error.
2019-04-01 16:29:00 +08:00
2a69ab4a4c
FIX: Keep `alt` and `title` in lightbox when indexing for search.
...
Follow up to cfd507822f
2019-04-01 16:20:33 +08:00
88128f1ced
UX: show which groups are missing permissions for parent category ( #7252 )
2019-04-01 15:34:52 +11:00
cfd507822f
PERF: Improve quality of `PostSearchData#raw_data`. ( #7275 )
...
This commit fixes the follow quality issue with `PostSearchData#raw_data`:
1. URLs are being tokenized and links with similar href and characters
are being duplicated in the raw data.
`Post#cooked`:
```
<p><a href=\"https://meta.discourse.org/some.png \" class=\"onebox\" target=\"_blank\" rel=\"nofollow noopener\">https://meta.discourse.org/some.png </a></p>
```
`PostSearchData#raw_data` Before:
```
This is a test topic 0 Uncategorized https://meta.discourse.org/some.png discourse org/some png https://meta.discourse.org/some.png discourse org/some png
```
`PostSearchData#raw_data` After:
```
This is a test topic 0 Uncategorized https://meta.discourse.org/some.png meta discourse org
```
2. Ligthbox being included in search pollutes the
`PostSearchData#raw_data` unncessarily.
From 28 March 2018 to 28 March 2019, searches for the term `image` on
`meta.discourse.org` had a click through rate of 2.1%. Non-lightboxed images are not included in indexing for search yet we were indexing content within a lightbox. Also, search for terms like `image` was affected we were using `Pasted image` as the filename for
uploads that were pasted.
`Post#cooked`
```
<p>Let me see how I can fix this image<br>\n<div class=\"lightbox-wrapper\"><a class=\"lightbox\" href=\"https://meta.discourse.org/some.png \" title=\"some.png\" rel=\"nofollow noopener\"><img src=\"https://meta.discourse.org/some.png \" width=\"275\" height=\"299\"><div class=\"meta\">\n<svg class=\"fa d-icon d-icon-far-image svg-icon\" aria-hidden=\"true\"><use xlink:href=\"#far-image\"></use></svg><span class=\"filename\">some.png</span><span class=\"informations\">1750×2000</span><svg class=\"fa d-icon d-icon-discourse-expand svg-icon\" aria-hidden=\"true\"><use xlink:href=\"#discourse-expand\"></use></svg>\n</div></a></div></p>
```
`PostSearchData#raw_data` Before:
```
This is a test topic 0 Uncategorized Let me see how I can fix this image some.png png https://meta.discourse.org/some.png discourse org/some png some.png png 1750×2000
```
`PostSearchData#raw_data` After:
```
This is a test topic 0 Uncategorized Let me see how I can fix this image
```
In terms of indexing performance, we now have to parse the given HTML
through nokogiri twice. However performance is not a huge worry here since a string length of 194170 takes only 30ms
to scrub plus the indexing takes place in a background job.
2019-04-01 10:14:29 +08:00
7ac76fe935
DEV: Remove warning.
...
Library has already been loaded in application.rb.
2019-04-01 10:11:08 +08:00
daeda80ada
FIX: Don't index posts with empty `Post#raw` for search. ( #7263 )
...
* DEV: Remove unnecessary join in `Jobs::ReindexSearch`.
* FIX: Don't index posts with empty `Post#raw` for search.
2019-04-01 10:06:27 +08:00
d59abff2d8
UX: Always use relative age for post notices.
2019-03-31 18:07:05 +03:00
8b8d528b88
Hide mobile cards when user scrolls ( #7291 )
2019-03-31 11:16:52 +02:00
9510f3d737
card buttons should truncate if there isn't enough space ( #7290 )
2019-03-31 11:16:40 +02:00
c0780434f8
FIX: Better display if the topic is deleted
2019-03-29 16:59:00 -04:00
a55e7ebe8f
UX: Better display for deleted users in the review queue
2019-03-29 16:52:58 -04:00
86349abfea
FIX: Apply `min_score_default_visibility` to reviewable topics list
2019-03-29 15:42:49 -04:00
4e6d4531e8
UX: Improve ignore button alignment on user profiles
2019-03-29 15:34:48 -04:00
67454c71c9
FIX: Missing translations for agree/disagree details
2019-03-29 14:14:59 -04:00
370355d754
FIX: Allow users with posts to be rejected
2019-03-29 13:53:46 -04:00
814aee343b
UX: Minor profile page restructure
2019-03-29 12:52:42 -04:00
2c4b3c21a9
UX: Unified emoji escape regex
2019-03-29 12:17:11 -04:00
31053f30de
FEATURE: Let users delete their own topics. ( #7267 )
2019-03-29 17:10:05 +01:00
4a3daacb1b
FIX: reset embedding settings when no embeddable host, log host changes ( #7264 )
2019-03-29 17:05:51 +01:00
9b00ca30ed
FIX: check if user is already allowed before adding to topic allowed users ( #7242 )
2019-03-29 17:03:33 +01:00
d26d1b387e
FEATURE: Add ignore duration selection for user notifications preferences page ( #7269 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 13:33:08 +00:00
b1cb95fc23
FEATURE: Introduce ignore duration selection ( #7266 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-29 10:14:53 +00:00
961fb2c70e
DEV: moves each report in its own file ( #7277 )
2019-03-29 10:54:56 +01:00
a6d93f6317
FIX: Avoid error on ajax.abort() when client has not opened the request.
2019-03-29 15:38:38 +08:00
8cfd887f33
Make eslint happy.
2019-03-29 12:59:40 +08:00
2064223fbd
FIX: Safari needs a max-width to prevent modal overflow
2019-03-29 00:38:44 -04:00
1b3165d217
Make rubocop happy.
2019-03-29 12:15:39 +08:00
4fa8fe575b
UX: Use a step size of 1.
...
Follow up to 634a213e6d
2019-03-29 12:14:11 +08:00
634a213e6d
FIX: Admin chart y axis labels being rounded up/down when value is small.
2019-03-29 12:03:41 +08:00
e2ad374e5b
UX: USe bar chart for admin search logs details page.
...
A bar chart is better when comparing the values across the X axis.
2019-03-29 11:54:49 +08:00
f458cba4cb
FIX: Admin search logs should filter by date instead of timestamp.
...
The client side filters by date so it is confusion when the data changes as each second passes.
2019-03-29 11:50:25 +08:00
d8faf5f79e
FIX: `SearcLog.term_details` generating incorrect data because of case.
...
Also match on equality rather than "LIKE ?" which is quite strange.
2019-03-29 11:31:01 +08:00
947495e70d
Follow up to 8c2fa99f78.
...
`/search_logs/term?term` is alittle weird looking but unless we add
proper slug support to term, we're going to have to live with this
first.
2019-03-29 10:39:44 +08:00
c42df7ddd7
UX: Use the same default period for search logs index and term.
...
If the period is different, clicking through to view a term is confusing
because a different period will show a different set of stats.
2019-03-29 09:59:28 +08:00
8c2fa99f78
FIX: Remove `:term` from `admin/search_logs/term/:term` route.
...
Search log terms is a string that can contain characters like `/` which
messes with the route.
2019-03-29 09:48:20 +08:00
c836d67cac
UX: Collapse advanced search on mobile when searching.
...
On smaller mobile devices, the height of the advanced search filters takes up
the whole real estate that it requires the user to scroll down
significantly in order to view the results.
2019-03-29 08:59:02 +08:00
1a403337c9
UX: Prevent mobile nav from collapsing while content loads
2019-03-28 19:23:23 -04:00
d9eed924f5
minor box-shadow adjustment
2019-03-28 15:13:53 -04:00
2b5e16fbec
Minor icon spacing fix for input labels
2019-03-28 15:10:31 -04:00
3660b85614
FIX: Regressions in JS test suite
2019-03-28 14:15:52 -04:00
8c98c18c2b
FIX: Remove old flagging scss, fix more linting
2019-03-28 13:48:35 -04:00
7ec74afc43
FIX: Lint on JS
2019-03-28 13:36:30 -04:00
b58867b6e9
FEATURE: New 'Reviewable' model to make reviewable items generic
...
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.
Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
d43f4206c7
FEATURE: Add Armenian language
2019-03-28 14:24:14 +01:00
d0a1922ad9
FIX: `Upload.migrate_to_new_scheme` undefined error when external image fails to download.
2019-03-28 16:00:13 +08:00
1b0267b077
FIX: Switching composer action shouldn't trigger abandon popup ( #7261 )
2019-03-27 21:55:09 +01:00
4a47ec791f
* FEATURE: change layout of escaped_fragment_ topic page to table one like live discourse ( #7250 )
2019-03-27 21:32:56 +01:00
95d5819218
FIX: Re-download hotlinked optimized images ( #7249 )
...
* FIX: Download local images, even if download remote is disabled
2019-03-27 21:31:12 +01:00
12181599db
FIX: Staff action records now also accepts action_name as filter ( #7256 )
2019-03-27 21:29:15 +01:00
0d3531c2f1
FEATURE: Allow auth providers to define specific icons
...
Previously we relied on the provider name matching the name of the icon. Now icon names are explicitly set. Plugin providers which do not define an icon will get the default "sign-in-alt" icon
2019-03-27 13:25:04 +00:00
a9798f0c47
FEATURE: Add page for all group membership requests. ( #6909 )
2019-03-27 13:30:59 +02:00
ef2362a30f
FEATURE: Introducing new UI for changing User's notification levels ( #7248 )
...
* FEATURE: Introducing new UI for tracking User's ignored or muted states
2019-03-27 09:41:50 +00:00
675d950eab
FIX: corrects link to moderators_activity report ( #7265 )
2019-03-27 10:14:42 +01:00
f177567cee
Clean up style when both oAuth2 and account approval are enabled
2019-03-26 20:47:06 -04:00
095ee6ac96
UX: prevent images and lightboxes from extending outside blockquotes ( #7262 )
2019-03-27 01:51:21 +08:00
4f04ae5692
FIX: Failed to show details about some bounced emails
...
Bounces sent to reply_by_email_address could not be found.
2019-03-26 18:00:27 +01:00
de011b53b5
UX: Hide link to incoming email when there is no bounce key
...
For example, webhooks mark email log entries as bounced without there ever being an incoming email.
2019-03-26 18:00:27 +01:00
02f2ce8b05
target panel children instead of targeting the panel ( #7257 )
2019-03-26 23:54:37 +08:00
b2cacc5b0e
FIX: check can_create_tags on mini-tag-chooser as tag-chooser ( #7260 )
2019-03-26 16:45:38 +01:00
4874cf742b
FIX: better styling with popover ( #7259 )
2019-03-26 16:34:27 +01:00
8fb63b2706
FEATURE: unified popover implementation ( #7244 )
2019-03-26 15:43:27 +01:00
4a1096f14a
IE11 profile fix
2019-03-26 10:13:09 -04:00
3aa32c3170
FIX: send only one post request when changing topic notification level ( #7254 )
2019-03-26 12:04:33 +01:00
e0cb2a434a
Fix regression introduced in dae0bb4c67.
...
Add tests so it doesn't bite me again.
2019-03-26 17:52:37 +08:00
dae0bb4c67
FIX: Post blurb incorrect when search contains a phrase match.
...
If the blurb generated is not around the search term, we will not be
able to highlight it on the client side.
2019-03-26 17:01:52 +08:00
161a3c3870
DEV: Don't optimize image when migrating to new scheme.
...
The image has already been uploaded, the migrate to new scheme job's is
just to correct the scheme and not the content of the upload.
2019-03-26 15:12:10 +08:00
5a8451bf89
PERF: no need to select entire group just to find name
...
Note, this is a very good candidate for some cache longer term to cut
the query out
2019-03-26 17:59:05 +11:00
3cfedc6c71
PERF: no need to select the full theme just to get color scheme
2019-03-26 17:53:18 +11:00
b58c965aad
FIX: Destroy optimized image if attempting to migrate to new scheme fails.
2019-03-26 14:37:34 +08:00
0ac6a58b09
FIX: Skip validation when saving in `Upload#migrate_to_new_scheme`.
2019-03-26 14:28:39 +08:00
b1d707b3bb
FIX: More explicit grid layout
2019-03-25 16:41:38 -04:00
fc81358714
prettier
2019-03-25 14:48:14 -04:00
47a0e4b906
UX: improve mobile search
...
Improves usability of header search icon while user is already in full page search in mobile.
Currently, hitting search icon a second time empties input and does not scroll up to show search form.
This commit scrolls up to show form and sets focus on input.
2019-03-25 14:42:54 -04:00
df279251b7
REFACTOR: More consistent user/group page layouts
2019-03-25 14:40:22 -04:00
60e6070c27
UX: Show spinner during text replacement
2019-03-25 16:47:55 +01:00
8d098df289
UX: Inherit badge icon color
...
Fixes issue with icon color differing from text color in select-kit box category style
2019-03-25 09:29:38 -04:00
ec2123809f
FEATURE: user and group cards on mobile ( #7246 )
2019-03-25 13:37:17 +01:00
f072da1bfe
FEATURE: Add every month / 6 months options to email digest. ( #7247 )
2019-03-25 12:45:01 +02:00
dcd56cf593
FIX: Fixed changing composer mode escaping title ( #7191 )
2019-03-25 13:14:26 +05:30
ac661e856a
FEATURE: Allow categories to be prioritized/deprioritized in search. ( #7209 )
2019-03-25 10:59:55 +08:00
ce75e30bf5
UX: Indent category badges to indicate sub-categories.
2019-03-25 10:36:29 +08:00
b8bd031648
FIX: Always include custom fields in CategorySerializer
...
even if it is empty
2019-03-25 07:59:56 +05:30
40ac895ef7
SECURITY: properly validate return URL for SSO
...
Previously carefully crafted URLs could redirect off site
2019-03-25 09:02:42 +11:00
Kris
Guo Xiang Tan
Robin Ward
Penar Musaraj
David Taylor
Joffrey JAFFEUX
Régis Hanol
Joe
Maja Komel
Guo Xiang Tan
Dan Ungureanu
Tim Lange
Bianca Nenciu
Tarek Khalil
Gerhard Schlager
Saurabh Patel
Sam Saffron
Vinoth Kannan
