dbdb5b9a47
DEV: Use border-box sizing for admin controls
...
Fixes floating issues in admin site settings on screen widths between
768 and 880 pixels. This also cleans up spacing on mobile.
2020-09-17 11:49:41 -04:00
931d8725de
FEATURE: Diffrentiate between group + individual mentions ( #10691 )
...
* FEATURE: Diffrentiate between group + individual mentions
This commit adds the necessary code for Discorse core to differentiate between group + individual mentions in the notification user panel and notification page.
It changes the group mention icon from `at` to `users` as well as adds context as to which group was mentioned in the topic.
2020-09-17 10:23:19 -05:00
04be39ed46
FIX: don't show Tags tab in group management if tags are disabled
2020-09-16 15:43:11 -04:00
28cd1aaf8e
FIX: uses get() on properties of groups/badges which could be POJOs ( #10682 )
2020-09-16 16:45:11 +02:00
02dec8c209
UI: minor size/spacing inconsistencies in search advanced options ( #10681 )
2020-09-16 15:05:19 +02:00
4af48f7998
FIX: attempts to make autofocus more resilient in modals ( #10680 )
...
The current situation could cause a transition on the button to end after/during modal has shown and causing the button to get focus again. Browsers would then refuse to switch focus.
This is a kinda convulted solution, but it's a general purpose solution which doesn't involve changing anything in plugins/themes or core templates.
2020-09-16 11:05:02 +02:00
8c384ae6b8
Create proper shim for xss library - second attempt
2020-09-15 10:42:51 -04:00
273db57d6e
FEATURE: Allow admins to delete user SSO records in the UI ( #10669 )
...
Also displays the user's last payload in the admin UI to help with debugging SSO issues.
2020-09-15 10:00:10 -04:00
6d7b8a71c0
FIX: topic progress wrapper positioning regression
...
Followup to 94ed54a616
2020-09-15 09:38:06 -04:00
02e6f4c5d4
UX: Remove extraneous ellipsis after "loading"
...
The "loading" string already contains an ellipsis: 5990c71c29/config/locales/client.en.yml (L1480)
2020-09-15 15:22:46 +02:00
15b3477145
FIX: img width and height should be in quotes ( #10675 )
2020-09-15 11:39:12 +02:00
53e281a3fd
FIX: simplifies updating searchedTerms from connectors ( #10674 )
2020-09-15 11:21:38 +02:00
324aa3eb61
REFACTOR: reworks all the search-advanced-options panel ( #10661 )
...
* REFACTOR: reworks all the search-advanced-options panel
This commit includes the following changes:
- prevents any mutation of external (to the component) values
- get rid of observers
- uses @action
- minor UI tweaks
- dropped the unecessary debounce
- drops all the legacy code for badges/groups which is not being used
- replaces user-selector by user-chooser and improves multi-select to not show `search` if maximum has been reached
Most importantly this refactor should fix multiple bugs due to _update() being called multiple times if searchTerm was empty and other various bugs where some changes in searchTerm was not applied to the sidebar.
2020-09-15 09:39:12 +02:00
e3b4632f04
Revert "Create proper shim for xss library"
...
This reverts commit 30e9112535
2020-09-15 11:38:40 +08:00
b2f556232f
REFACTOR: improve readability of cacheBuster
2020-09-14 16:46:17 -04:00
30e9112535
Create proper shim for xss library
2020-09-14 15:57:32 -04:00
7699b90f1a
FIX: Wizard does not include `discourse-shims`
...
This allowed tests to pass even when wizard was broken, which is
obviously very bad.
2020-09-14 12:34:16 -04:00
9238a9e427
FIX: adds shims for popper in wizard ( #10658 )
2020-09-14 12:33:14 -04:00
21adc07057
FIX: upload errors were sometimes not displayed properly ( #10605 )
2020-09-14 00:13:38 -07:00
5268568d23
FEATURE: Remove user topic timers and migrate to bookmarks with reminders ( #10474 )
...
This PR removes the user reminder topic timers, because that system has been supplanted and improved by bookmark reminders. The option is removed from the UI and all existing user reminder topic timers are migrated to bookmark reminders.
Migration does this:
* Get all topic_timers with status_type 5 (reminders)
* Gets all bookmarks where the user ID and topic ID match
* Loops through the found topic timers
* If there is no bookmark for the OP of the topic, then we just create a bookmark with a reminder
* If there is a bookmark for the OP of the topic and it does **not** have a reminder set, then just
update it with the topic timer reminder
* If there is a bookmark for the OP of the topic with a reminder then just discard the topic timer
* Cancels all outstanding user reminder topic timers
* **Trashes (not deletes) all user reminder topic timers**
Notes:
* For now I have left the user reminder topic timer job class in place; this is so the jobs can be cancelled in the migration. It and the specs will be deleted in the next PR.
* At a later date I will write a migration to delete all trashed user topic timers. They are not deleted here in case there are data issues and they need to be recovered.
* A future PR will change the UI of the topic timer modal to make it look more like the bookmark modal.
2020-09-14 11:11:55 +10:00
0a4a273ccc
FEATURE: adds support for mobile view on page publishing ( #10662 )
2020-09-13 13:50:23 +02:00
e8053d17f6
FIX: selected diversity was off by one ( #10659 )
2020-09-12 09:44:45 +02:00
24f19e8372
Revert "FIX: Was using a global `Popper` variable"
...
This reverts commit 05831c2b42
2020-09-11 17:30:53 -04:00
7887aaf587
FIX: `isVisible` is no longer allowed even if used properly
...
This changes it to `shouldShow` instead.
2020-09-11 15:05:50 -04:00
05831c2b42
FIX: Was using a global `Popper` variable
2020-09-11 15:02:12 -04:00
ac08dfac45
FIX: Ember has deprecated `isVisible` in newer versions
2020-09-11 14:53:44 -04:00
07d7adb8b4
UX: makes emoji picker case insensitive ( #10655 )
2020-09-11 19:54:19 +02:00
033cebf978
DEV - versions of JS files written to a JS file to be included by loa… ( #10649 )
...
* DEV - versions of JS files written to a JS file to be included by load-script and appended as params to URLs
* Formatting
* Incorporate feedback from PR
* Update filename of public-js-versions
2020-09-11 13:53:56 -04:00
10bdf36a24
FIX: ensures focus is dropped before focus hyperlink input ( #10653 )
2020-09-11 16:45:51 +02:00
d9aa105c8e
FIX: wrap modal onShow inside next ( #10651 )
...
Before this commit, onShow code could be impacted by code happening after the onShow call. This should ensure this code works for example:
```
onShow() {
afterRender(() => {
someInput.focus();
})
}
```
2020-09-11 16:00:31 +02:00
636a3be827
UX: Make the api-keys new and show page a little more responsive ( #10629 )
2020-09-11 10:38:28 -03:00
94ed54a616
DEV: Small refactor of topic progress wrapper positioning ( #10646 )
...
This moves the logic for horizontally placing the topic progress wrapper from the JS component to SCSS. Doing so means it is more easily overridable by themes and plugins.
This also changes the left/right spacing from 1em to 2em for non-mobile screens (it fits better on iPad portrait especially).
2020-09-10 13:29:14 -04:00
296c707f55
FEATURE: show existing tag name on rename modal
...
FIX: tags_filter_regexp was not being applied on tag rename
2020-09-10 21:45:05 +05:30
dee451605b
FEATURE: add user opt to select bookmarks as home ( #10597 )
...
Admins can currently add the bookmarks discovery route link
to the homepage interface, but users can't presently select
that as their default home view. This change facilitates that,
adding the option to the existing Default Home Page dropdown on
the User Preferences Interface page.
2020-09-10 11:13:12 -04:00
5a34c7cc9e
FIX: Adds important declaration to `.hidden` utility/helper class
...
This commit adds the `!important` declaration to `.hidden` utility/helper class. Without the `!important` declaration, it is not applied correctly across the site.
2020-09-10 11:06:50 -04:00
53ffbc8d6e
DEV: add plugin outlet below the categories-only component
2020-09-10 10:39:04 -04:00
81d3c4a7a1
DEV: Remove unused function.
2020-09-10 15:11:35 +08:00
40d5739a80
DEV: Review fixes for bookmark-list ( #10642 )
...
Make removeBookmark return a promise and do not use setProperties for no reason.
More context at https://review.discourse.org/t/fix-add-bookmark-list-component-10451/14450/3
2020-09-10 15:01:53 +10:00
521782fc9c
FIX: Search checkboxes incorrectly being checked on similar prefix.
...
Incorrect search filters like `in:personalasd` will end up checking the
checkbox for `in:personal` because the regexp used was only doing prefix
matching.
2020-09-10 11:49:52 +08:00
097f06b4fa
DEV: Add plugin api for adding to search-advanced-options dropdowns ( #10606 )
2020-09-09 15:17:39 +01:00
38c934e1e1
UX: prevents auto capitalize/correct in the emoji picker ( #10636 )
2020-09-09 15:43:18 +02:00
8413d27cf2
FIX: handles different cases of canInvite/canRemove states in PM ( #10607 )
2020-09-08 16:35:59 +02:00
d21119ee4f
Build(deps): Bump lodash in /app/assets/javascripts/pretty-text
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 10:25:45 -04:00
00e2339e82
Build(deps): Bump lodash in /app/assets/javascripts/discourse-common
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20 )
Signed-off-by: dependabot[bot] <support@github.com>
2020-09-08 10:25:31 -04:00
02495510e8
FIX: workaround constructor name not available after transpilation ( #10623 )
...
This is only reproducible en production build. In this case, constructor.name could be any value like "i" for example.
2020-09-08 10:14:41 +02:00
0b8e7d88fe
FIX: wraps popper call in afterRender and uses createPopper ( #10621 )
...
Before this fix, popper was sometimes not applied.
2020-09-07 13:33:52 +02:00
27751ca69f
Build(deps): Bump websocket-extensions ( #10617 )
...
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node ) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/faye/websocket-extensions-node/releases )
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md )
- [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:02:38 +02:00
b191ea4f59
Build(deps): Bump websocket-extensions ( #10615 )
...
Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node ) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/faye/websocket-extensions-node/releases )
- [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md )
- [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:02:27 +02:00
2cb0f013cc
Build(deps): Bump elliptic in /app/assets/javascripts/pretty-text ( #10611 )
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:02:09 +02:00
6bff8636e2
Build(deps): Bump elliptic in /app/assets/javascripts/discourse-common ( #10612 )
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:01:37 +02:00
9b187b7e11
Build(deps): Bump http-proxy in /app/assets/javascripts/discourse-common ( #10613 )
...
Bumps [http-proxy](https://github.com/http-party/node-http-proxy ) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases )
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md )
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:00:25 +02:00
c119c07fa4
Build(deps): Bump http-proxy in /app/assets/javascripts/pretty-text ( #10614 )
...
Bumps [http-proxy](https://github.com/http-party/node-http-proxy ) from 1.18.0 to 1.18.1.
- [Release notes](https://github.com/http-party/node-http-proxy/releases )
- [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md )
- [Commits](https://github.com/http-party/node-http-proxy/compare/1.18.0...1.18.1 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-07 12:00:10 +02:00
13c9d7e704
UX: Add missing labels to mobile composer buttons
2020-09-04 22:18:29 -04:00
d4471e0316
FIX: Preload bold fonts in wizard
...
The bold fonts are used in previews for topic title.
2020-09-04 19:23:46 +03:00
ed05839dfc
FIX: prevents error when opening a composer from a tag page ( #10596 )
2020-09-04 15:47:22 +02:00
58b97ace23
DEV: Use a special import to declare font faces ( #10583 )
...
Update discourse-fonts to v0.0.3.
Follow-up to 7b7357147e
2020-09-04 16:25:50 +03:00
52672b9eab
DEV: apply new coding standards ( #10592 )
2020-09-04 13:42:47 +02:00
e4ebc303bb
FEATURE: Add below-static plugin outlet
2020-09-03 22:58:58 -04:00
8c0f18794e
FEATURE: Deprecate lodash so we can remove it.
...
It's currently 240k of Javascript we don't need anymore. It's been
replaced by ES6 and a couple helper functions.
2020-09-03 10:03:33 -04:00
3a46e44ed8
Rename `merge` to `deepMerge` so it's more clear what it's doing
2020-09-03 10:03:33 -04:00
f365d4639a
REFACTOR: Remove `_.isEqual`
2020-09-03 10:03:33 -04:00
c4079780be
REFACTOR: Remove `_.merge`
2020-09-03 10:03:33 -04:00
720cd57fb5
FIX: Convert jQuery array to JS array
2020-09-03 10:03:33 -04:00
5e5d5b4f35
REFACTOR: Remove `_.last`
2020-09-03 10:03:33 -04:00
0da953b40e
REFACTOR: Remove `_.compact`
2020-09-03 10:03:33 -04:00
c2cfa62000
REFACTOR: Remove `_.intersection`
2020-09-03 10:03:33 -04:00
0b098566ff
REFACTOR: Remove `_.union`
2020-09-03 10:03:33 -04:00
e60d06d880
REFACTOR: Remove `_.isString`
2020-09-03 10:03:33 -04:00
b4444070b3
REFACTOR: Remove `_.groupBy`
2020-09-03 10:03:33 -04:00
1265a5f7c0
REFACTOR: Remove `_.max`
2020-09-03 10:03:33 -04:00
d06deb0c4f
REFACTOR: Remove `_.chain`
2020-09-03 10:03:33 -04:00
71ddcefffa
REFACTOR: Remove `_.filter`
2020-09-03 10:03:33 -04:00
87b3caf927
REFACTOR: Remove `_.reject`
2020-09-03 10:03:33 -04:00
2a4dfa83b0
REFACTOR: Remove `_.omit`
2020-09-03 10:03:33 -04:00
17bca14c4b
REFACTOR: Remove `_.sortBy`
2020-09-03 10:03:33 -04:00
2353794a30
REFACTOR: Remove `_.findIndex`
2020-09-03 10:03:33 -04:00
e3ec7b72d0
REFACTOR: Remove `_.uniq` and use ember version
2020-09-03 10:03:33 -04:00
66021abe41
REFACTOR: Remove `_.first` from codebase
2020-09-03 10:03:33 -04:00
55c9c54b8b
REFACTOR: Remove `_.range` and use ES6 instead
2020-09-03 10:03:33 -04:00
115b3b6921
REFACTOR: Remove `_.isEmpty` in favor of the existing version
2020-09-03 10:03:33 -04:00
65f6a92129
REFACTOR: Replace `_.extend` with `Object.assign`
2020-09-03 10:03:33 -04:00
2f11457263
REFACTOR: Use `Array.isArray` instead of `_.isArray`
2020-09-03 10:03:33 -04:00
50827684d5
UX: Hide category settings badges checkbox when enable_badges is off
2020-09-02 11:23:59 -04:00
c6e336b519
REFACTOR: simplifies connectors code ( #10579 )
...
- directly uses factoryFor to avoid having to set owner later
- drops jquery usage
- renames view into component as I find it more explicit
2020-09-02 15:53:42 +02:00
879e274dc7
UX: wrap extra long links in GitHub oneboxes instead of overflowing
2020-09-02 21:50:57 +08:00
ec0b4b2acc
FIX: wait for groups before showing empty message
2020-09-01 22:36:00 -04:00
b14098ce28
removed REGEXP_IN_MATCH regex to make it flexible to use with plugins ( #10476 )
...
* dynamic regex generation for 'STATUS' and 'IN' ddropdown
2020-09-01 14:33:05 +02:00
f8062300da
DEV: removes jquery usage from highlight-syntax ( #10564 )
2020-09-01 09:50:49 +02:00
084e15b447
FIX: modify notification after remove auto_watch_category ( #10568 )
...
When a category is removed from `auto_watch_category` we are removing
CategoryUser. However, there are still TopicUser with notification level
set to `watching` which was inherited from Category.
We should move them back to `regular` unless they were modified by a user.
2020-09-01 13:07:41 +10:00
e824385e64
only remove edit button margin when text is hidden
2020-08-31 22:45:43 -04:00
594d919d22
FIX: Focus first button in topic admin menu ( #10562 )
...
When using Shift+A to toggle the admin menu for a topic the first button was not focused, so the menu could not be navigated with tab.
2020-09-01 10:29:35 +10:00
c3560a66f3
DEV: CSS truncation followup
...
After merging this
58fe78bf28 (diff-fed21847d651f6eb2cc76abbd770f5f8)
2020-09-01 02:01:17 +08:00
2550c5bd03
FIX: Ensure disabling 2FA works as expected ( #10485 )
2020-08-31 09:56:57 -07:00
2a3a173e8e
FIX: Disable insert link button when editing a category ( #10549 )
2020-08-31 13:50:40 -03:00
58fe78bf28
UX: don't wrap topic status icons in the header if there's more than one
...
Context: https://meta.discourse.org/t/when-a-topic-is-closed-and-pinned-the-pin-icon-in-header-not-in-correct-place/162473
Flex is causing a bit of a problem here since it makes the `topic-statuses` div in the header wrap when it has more than one icon. Given that we already use grid on the parent and that the icons are aligned properly, I think it's safe to remove it here.
2020-09-01 00:40:42 +08:00
f2e14a3946
FEATURE: Add site setting and wizard step to set base font ( #10250 )
...
Co-authored-by: Neil Lalonde <neillalonde@gmail.com>
2020-08-31 13:14:09 +03:00
b4c5f6631f
FIX: Do not set color_scheme_id in user options when no schemes are marked as selectable
2020-08-30 09:32:40 -04:00
7bba65b6f5
UX: Restyle user menu so user links are findable ( #10554 )
2020-08-28 20:20:59 -04:00
aae97457d2
REFACTOR: Don't use `layoutName` in select-kit ( #10556 )
...
Instead import the templates as modules, the way Ember CLI wants us to.
2020-08-28 15:30:20 -04:00
b7cfc9e861
FEATURE: User selectable color schemes ( #10544 )
2020-08-28 10:36:52 -04:00
Penar Musaraj
Jordan Vidrine
Neil Lalonde
Joffrey JAFFEUX
Robin Ward
Jarek Radosz
Guo Xiang Tan
jbrw
Faizaan Gagan
Martin Brennan
jbrw
Roman Rizzi
Arpit Jalan
Robert
Jordan Vidrine
Ahmed Gagan
dependabot[bot]
awesomerobot
Bianca Nenciu
Bianca Nenciu
Joe
Krzysztof Kotlarek
tshenry