discourse

Commit Graph

Author	SHA1	Message	Date
Alan Guo Xiang Tan	1052ed9c3b	DEV: Fix flaky system test in `system/category_topics_spec.rb` (#22652 ) Why was the test flaky? The test relied on the fact that visiting a topic would marked its post as unread. However, we did not actually stay on the topic long enough in some cases for it to be considered read based on the logic in our client side code. This commit fixes the flakiness by ensuring that the post has actually been read before navigating away.	2023-07-18 07:35:47 +08:00
Alan Guo Xiang Tan	beb91e1707	DEV: Skip two flaky system tests (#22651 ) Why this change? These tests have shown to be flaky and are being skipped for now while we look into it.	2023-07-18 07:26:12 +08:00
Krzysztof Kotlarek	a64cb948ed	FIX: update unread and new count for categories (#22145 ) There is a problem that unread and new count is not updated to reflecting topicTrackingState. It is because discourseComputed on Category is not working properly with topicTrackingState. Moving it to component level is making counter reliable.	2023-06-21 13:42:30 +10:00

Author

SHA1

Message

Date

Alan Guo Xiang Tan

1052ed9c3b

DEV: Fix flaky system test in `system/category_topics_spec.rb` (#22652 )

Why was the test flaky?

The test relied on the fact that visiting a topic would marked its
post as unread. However, we did not actually stay on the topic long
enough in some cases for it to be considered read based on the logic in
our client side code.

This commit fixes the flakiness by ensuring that the post has actually
been read before navigating away.

2023-07-18 07:35:47 +08:00

Alan Guo Xiang Tan

beb91e1707

DEV: Skip two flaky system tests (#22651 )

Why this change?

These tests have shown to be flaky and are being skipped for now while
we look into it.

2023-07-18 07:26:12 +08:00

Krzysztof Kotlarek

a64cb948ed

FIX: update unread and new count for categories (#22145 )

There is a problem that unread and new count is not updated to reflecting topicTrackingState.

It is because discourseComputed on Category is not working properly with topicTrackingState. Moving it to component level is making counter reliable.

2023-06-21 13:42:30 +10:00

3 Commits