fc97f7e0e7
FIX: properly ban non human users from draft system
...
Previously we had a partial fix in place where non human users
were not allowed draft sequences, this left edges around where non
human users asked for drafts yet had none.
For example system could already have a few drafts in place.
This also removes and extensibility point we added that is not in use
2020-05-26 10:07:09 +10:00
d9f915b195
FIX: documentation was using incorrect function ( #9876 )
2020-05-25 21:55:30 +02:00
be16205118
DEV: plugin api should have been bumped for #8825395 ( #9874 )
2020-05-25 21:44:15 +02:00
5fb9271878
DEV: ignore `flair_url` column in group model. ( #9873 )
2020-05-26 00:43:50 +05:30
8825395bdc
DEV: allows to decorate username selector ( #9869 )
...
Usage:
```
api.addUsernameSelectorDecorator(username => {
return iconHTML("calendar-alt");
});
```
2020-05-25 19:09:55 +02:00
fd2d7ca992
FIX: Email Styles were evaluated out of order
...
`yield` puts the content in the template right away unless explicitly
`capture`'d.
2020-05-25 12:47:23 -04:00
e8fb9d4066
FIX: when creating new PM username/groupname should be case-insensitive
...
(take 2)
https://meta.discourse.org/t/case-sensitivity-in-links-to-groupname/147596
https://meta.discourse.org/t/remove-case-sensitive-in-adding-users-to-a-message/151275
2020-05-25 21:34:05 +05:30
302b37c805
Revert "FIX: when creating new PM username/groupname should be case-insensitive"
...
This reverts commit 2be79d94f5
2020-05-25 20:10:14 +05:30
2be79d94f5
FIX: when creating new PM username/groupname should be case-insensitive
...
https://meta.discourse.org/t/case-sensitivity-in-links-to-groupname/147596
https://meta.discourse.org/t/remove-case-sensitive-in-adding-users-to-a-message/151275
2020-05-25 19:04:59 +05:30
631024ae5d
FEATURE: Permalinks for tags
2020-05-25 14:51:01 +02:00
48fb354bce
PERF: avoid traversing DOM in loadScript
...
Once a script is loaded operation should be very fast.
This optimisation avoids a DOM traverse and call to getURL on
every invocation.
2020-05-25 18:19:59 +10:00
505122bb45
FIX: skip onceoff job for groups with invalid flair URL.
2020-05-25 13:11:00 +05:30
c011b817b2
FIX: do not fallback to flair_url column
...
flair_url is not loaded by our query anymore so avoid falling back
to the old value
2020-05-25 16:25:42 +10:00
47c6fe9bfa
Merge branch 'master' of github.com:discourse/discourse
2020-05-25 11:36:18 +05:30
e31adef32d
FIX: Keep composer title and reply when switching to PM ( #9851 )
2020-05-25 15:46:02 +10:00
8e56197728
UX: use "icon-picker" & "image-uploader" fields to set group flair. ( #9779 )
2020-05-25 11:08:47 +05:30
13d5ccedf5
FIX: Destroying a user failed when it had title
...
...because updating the user caused a validation of the primary email and the UserEmail records are already deleted at that time.
2020-05-24 22:14:50 +02:00
6f03d14c23
FEATURE: category setting for default list filter.
2020-05-25 00:04:06 +05:30
058bf56b4c
FIX: group card not showing if user can't see its members.
2020-05-24 23:08:51 +05:30
60a3110113
FIX: call `getURL` method explicitly to prevent `this` context override.
2020-05-24 21:58:03 +05:30
d9a02d1336
Revert "Revert "Merge branch 'master' of https://github.com/discourse/discourse ""
...
This reverts commit 20780a1eeee62a85cf2660c2e203d26cd6
2020-05-23 00:56:13 -04:00
20780a1eee
Revert "Merge branch 'master' of https://github.com/discourse/discourse "
...
This reverts commit e62a85cf6f2660c2e21d
2020-05-22 20:25:56 -07:00
03d26cd6f0
SECURITY: ensure embed_url contains valid http(s) uri
2020-05-22 14:54:56 -06:00
bf8085e436
FIX: Double Button Alignment Mobile ( #9862 )
2020-05-22 13:33:29 -05:00
06e1d430c1
FIX: better cross browser topic footer buttons alignment ( #9860 )
2020-05-22 17:03:22 +02:00
671f882fa3
FIX: We don't create a Post object if the queued post gets rejected. We need to count review items directly. ( #9856 )
2020-05-22 11:50:28 -03:00
f9649c92b5
FIX: Live reloading of css in development ( #9859 )
2020-05-22 16:37:35 +02:00
793085c703
REFACTOR: slightly cleaner topic admin button css ( #9858 )
2020-05-22 15:23:17 +02:00
e71f5e8951
UI: apply margin only if the menu has content ( #9857 )
2020-05-22 15:19:55 +02:00
f9d55b4941
FEATURE: Update the topic excerpt when the OP is rebaked ( #9852 )
...
* We now have a site setting "topic_excerpt_maxlength" that is used when the OP is created or revised to generate a topic excerpt.
* However, posts created before this setting was introduced cannot benefit from this change unless they are revised, and if the topic excerpt length setting is changed that situation is also not covererd.
* This PR makes a change to rebake! to update the topic excerpt IF the post is the OP.
2020-05-22 13:04:15 +10:00
c0779df99d
FIX: Remove access control post FK from uploads ( #9853 )
2020-05-22 11:20:25 +10:00
d11c462104
SECURITY: ERB execution in custom Email Style
2020-05-21 14:48:30 -04:00
5a71c51ddd
FIX: tag input says tags are optional when they're required
2020-05-21 12:40:33 -04:00
1a5bcf2a64
UX: Remove live theme previewing in favor of refresh ( #9798 )
2020-05-21 08:32:50 -05:00
66960563ea
FIX: ensures category chooser is case insensitive ( #9850 )
2020-05-21 11:16:44 +02:00
7b6fbe9af2
FIX: adds missing tags to published page header ( #9835 )
2020-05-21 11:04:23 +02:00
18959ff9da
UX: user name instead username for profile link title
2020-05-21 14:02:12 +05:30
3c9212fd88
UX: add title for user profile link
2020-05-21 13:00:05 +05:30
df68d11c38
FEATURE: Add topic excerpt max length site setting ( #9847 )
...
Adds a new topic_excerpt_maxlength site setting.
* When topic excerpt is requested for a post, use the new topic_excerpt_maxlength site setting to limit the size of the excerpt
* Remove code for getting/setting Post.excerpt_size as it is not used anywhere
2020-05-21 13:19:48 +10:00
68db5deaec
FIX: Badge granter was disabled by default.
2020-05-21 06:55:22 +08:00
62ecb2885f
glob @import desktop and mobile scss
2020-05-20 18:05:27 -04:00
234933c781
FIX: Show staff counters if the rejected posts count is the only value to show ( #9845 )
2020-05-20 19:00:35 -03:00
eef47a26d9
UX: More consistent mobile banner/alert styles, css cleanup
2020-05-20 17:17:47 -04:00
096eca0ee8
FIX: Requests were not being logged correctly
...
`enable` was defaulting to `nil` which is not what we wanted.
2020-05-20 15:09:17 -04:00
ba04bb7552
FIX: Path should be `addon` not `app`
2020-05-20 12:13:15 -04:00
3062036f2f
FIX: Allow deprecation to work with Ember CLI
2020-05-20 12:05:56 -04:00
8851b79472
DEV: less code for Category#url
2020-05-20 18:01:06 +02:00
09ca75d17e
FIX: select-kit was in the wrong place
...
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
2020-05-20 11:51:49 -04:00
8e7efb48ae
FIX: Update default_template.html
2020-05-20 10:39:04 -05:00
6c9c8dfefd
FIX: `guidFor` is not part of `Ember.Object`
2020-05-20 11:31:11 -04:00
bd57ae83f1
DEV: Guardian for hiding about stats ( #9841 )
2020-05-20 10:26:20 -05:00
30631a963f
UX: moves editFirstPost in taggable Pms in dropdown on mobile ( #9840 )
2020-05-20 14:07:00 +02:00
fb15da43da
Remove old web hooks in favor of 'reviewable' web hook ( #9776 )
...
* FIX: Emit web hooks for flags
* FEATURE: Remove 'flag' web hook in favor of 'reviewable' web hook
* FEATURE: Remove 'queued post' web hook in favor of 'reviewable' web hook
* FIX: Do not set a default value for web hooks with no events
2020-05-20 12:07:48 +03:00
f7f436e536
DEV: Install `rails_failover` gem to test our Redis changes.
2020-05-20 15:40:27 +08:00
e97cb20c2a
UX: strip text from PM bookmark and share buttons
...
Also organize priorities in an easier to reason about way and
shift bookmark topic so it is after link. (consistent with posts)
2020-05-20 16:46:49 +10:00
234cd5c3e7
FIX: Switch discobot to pull avatar from gravatar.
2020-05-20 10:20:08 +08:00
6b92c78033
FIX: purge all associated data on user delete
...
This commit reorganises the delete dependencies on users and make sure
all are covered. We forgot some on bookmarks, security keys, anon users
and so on.
2020-05-20 11:27:57 +10:00
a93d0a8fcc
UX: Remove bold from category badge text
2020-05-19 21:11:49 -04:00
52228b1fa6
DEV: These routes don't exist anymore ( #9823 )
2020-05-19 16:09:03 -03:00
a239900522
UI: reduces category row description margin ( #9834 )
2020-05-19 20:44:54 +02:00
05d8091bd3
DEV: adds triggerOnChangeOnTab option to select-kit ( #9833 )
...
Usage:
```
options=(hash triggerOnChangeOnTab=false)
```
This will prevent to select the row when pressing tab.
2020-05-19 20:39:29 +02:00
ab6737c44a
UX: improves topic-notifications-button loading behavior ( #9832 )
2020-05-19 17:13:40 +02:00
f038f8f154
FIX: description for 'uncategorized' category was blank
2020-05-19 18:45:43 +05:30
7c3663ff73
UX: adds visual feedback when changing topic notifications level ( #9831 )
2020-05-19 13:27:57 +02:00
05ca0c908f
FIX: GroupArchivedMessage belongs to Group, not User
2020-05-19 14:13:28 +03:00
725e38f9d7
DEV: Allow plugins to request topic thumbnail sizes ( #9828 )
...
In plugin.rb, you can register new sizes like
```
register_topic_thumbnail_size [512, 512]
```
For more information about thumbnails see 03818e642a
2020-05-19 10:38:58 +01:00
1647ba4624
FIX: applies flex on topic-footer-main-buttons ( #9829 )
2020-05-19 11:29:38 +02:00
3623a395dc
UI: refinements to topic footer buttons ( #9780 )
2020-05-19 09:51:34 +02:00
062cb1e1cb
UX: Remove caret from notifications-button.
2020-05-19 13:41:13 +08:00
864fb45ff0
Improve mobile friendliness of crawler view
2020-05-19 00:24:17 -04:00
6d5e9db883
FIX: Restoring backup didn't clear cached translation overrides
2020-05-18 18:51:51 +02:00
27c611b1d1
FIX: Reverting multiple translation overrides didn't clear cache
2020-05-18 18:51:29 +02:00
cfad38184d
FIX: improves and fixes a regression with category-selector ( #9821 )
2020-05-18 17:44:47 +02:00
96848b7649
UX: Allow secure media URLs to be cached for a short period of time
...
Signed S3 URLs are valid for 15 seconds, so we can safely allow the browser to cache them for 10 seconds. This should help with large numbers of requests when composing a post with many images.
2020-05-18 15:00:41 +01:00
1876b3cc4c
FIX: more resilient/consistent date-picker loading ( #9817 )
2020-05-18 15:29:24 +02:00
48ed1b40cf
REFACTOR: ensures later is correctly canceled ( #9796 )
2020-05-18 14:20:23 +02:00
9482ddff73
UX: show caret only in topic footer buttons dropdown select boxes ( #9816 )
2020-05-18 14:07:40 +02:00
f968155288
FIX: Ensure no image downloads during topic thumbnail serialization
...
If image uploads are missing a width/height, we re-download them to update the width/height in the database. However, this takes significant resources so we don't want to run this logic during topic serialization.
2020-05-18 12:04:29 +01:00
918bd75909
FIX: allows to remove a topic timer with delete_replies as type ( #9800 )
2020-05-18 11:47:08 +02:00
d01c336899
DEV: Clean up some Redis leaks in test env.
2020-05-18 17:27:37 +08:00
320b21ab5b
UX: allows dropdown-select-box to display a caret ( #9803 )
...
```
selectKitOptions: {
showCaret: true // default false
}
```
2020-05-18 10:50:33 +02:00
e5dc843185
FIX: ensures hide is called when card is destroyed ( #9814 )
2020-05-18 10:10:40 +02:00
e81a4048e3
REFACTOR: s/focusAfterOnchange/focusAfterOnChange ( #9801 )
2020-05-16 11:20:37 +02:00
db8e872bda
DEV: Move select kit to an addon ( #9797 )
2020-05-15 16:07:35 -04:00
7f07c513a7
FIX: Switching composer action does not refresh composer actions content ( #9791 )
2020-05-15 13:54:44 -04:00
6b04760572
FIX: Component was still used by data explorer
2020-05-15 13:52:03 -04:00
eee20a9814
FIX: Include plugin CSS assets when previewing themes
2020-05-15 18:12:53 +01:00
7edd312f85
UX: focus category name when editing category ( #9795 )
2020-05-15 18:27:06 +02:00
b07f1bfd93
FIX: displays a title on sk header if no selected name ( #9794 )
...
none has to be defined.
2020-05-15 17:36:00 +02:00
9810ca1dbd
UX: Add copied text upon copy button click ( #9793 )
2020-05-15 17:08:46 +02:00
d1146ccb7b
Revert "FIX: Correct plugin api version bump."
...
This reverts commit 6a96c424b7
2020-05-15 21:22:44 +08:00
6a96c424b7
FIX: Correct plugin api version bump.
...
It doesn't seem to be following semver.
2020-05-15 21:17:50 +08:00
461b4e5cc6
DEV: Add framework for filtered plugin registers ( #9763 )
...
* DEV: Add framework for filtered plugin registers
Plugins often need to add values to a list, and we need to filter those lists at runtime to ignore values from disabled plugins. This commit provides a re-usable way to do that, which should make it easier to add new registers in future, and also reduce repeated code.
Follow-up commits will migrate existing registers to use this new system
* DEV: Migrate user and group custom field APIs to plugin registry
This gives us a consistent system for checking plugin enabled state, so we are repeating less logic. API changes are backwards compatible
2020-05-15 14:04:38 +01:00
0495a748d0
FIX: Use CDN URLs for topic thumbnails
2020-05-15 13:35:20 +01:00
162d125b83
Fix lint.
2020-05-15 20:23:17 +08:00
dada1fc417
UX: Better composer-action icon when creating new topic.
2020-05-15 16:40:49 +08:00
f9a9bd136b
FEATURE: Expose `Composer.serializeToTopic` in client side plugin api.
2020-05-15 16:16:58 +08:00
0cbaa8d813
FEATURE: extend duration allowed for download
...
Previously we would raise a warning in the logs if downloading
a file (from s3) takes longer than 60 seconds.
At scale this happens reasonably frequently.
1. Raised the duration to 3 minutes
2. Pulled the resizing mutex out of the downloading mutex
so we have less and clearer error logs
2020-05-15 12:45:47 +10:00
165fa13c9d
FIX: Always return 0 for non-human user current DraftSequence.
2020-05-15 10:40:36 +08:00
e37ea4a4a1
Revert "FIX: don't compute draft for bots on categories index route"
...
This reverts commit 1b7f23a1bc
2020-05-15 10:40:35 +08:00
Sam Saffron
Joffrey JAFFEUX
Vinoth Kannan
Robin Ward
Arpit Jalan
Gerhard Schlager
Bianca Nenciu
Michael Brown
Jeff Atwood
Blake Erickson
Jordan Vidrine
Roman Rizzi
Mark VanLandingham
Martin Brennan
Neil Lalonde
Guo Xiang Tan
Kris
Régis Hanol
Dan Ungureanu
David Taylor
Justin DiRose