All flags should end up in one of the three dispositions
- Agree
- Disagree
- Defer
In the administration area, the *active* flags section displays 4 buttons
- Agree (hide post + send PM)
- Disagree
- Defer
- Delete
Clicking "Delete" will open a modal that offer to
- Delete Post & Defer Flags
- Delete Post & Agree with Flags
- Delete Spammer (if available)
When the flag has a list associated, the list will now display 1
response and 1 reply and a "show more..." link if there are more in the
conversation. Replying to the conversation will NOT give a disposition.
Moderators must click the buttons that does that.
If someone clicks one buttons, this will add a default moderator message
from that moderator saying what happened.
The *old* flags section now displays the proper dispositions and is
super duper fast (no more N+9999 queries).
FIX: the old list includes deleted topics
FIX: the lists now properly display the topic states (deleted, closed,
archived, hidden, PM)
FIX: flagging a topic that you've already flagged the first post
* the reports mainly followed the same structure but with
different classes, so I took the code and a class as its
parameter
* the method on which reports.data is generated may change
but mostly is count_per_day so made that optional
* grouped the refactored methods to the top, some unrefactored
methods remain but those are a bit harder to refactor, and not
as reusable so I'd like to get this through first
* Overall I believe this patch enhances maintainability :-)
Sam
Erick Guan
Robin Ward
Régis Hanol
Neil Lalonde
Godfrey Chan
Tobias Pfeiffer