Neil Lalonde
4a5907b116
Merge branch 'master' into search_posts_with_images
2017-07-31 10:44:41 -04:00
Guo Xiang Tan
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
Neil Lalonde
ea0e90b2b0
Merge branch 'master' into search_posts_with_images
2017-07-26 10:15:55 -04:00
Sam
627f5ddbd1
Correct specs
2017-07-17 18:00:25 -04:00
Sam Saffron
d0c5205a52
Feature: Change markdown engine to markdown it
...
This commit removes the old evilstreak markdownjs engine.
- Adds specs to WhiteLister and changes it to stop using globals
(Fixes large memory leak)
- Fixes edge cases around bbcode handling
- Removes mdtest which is no longer valid (to be replaced with
CommonMark)
- Updates MiniRacer to correct minor unmanaged memory leak
- Fixes plugin specs
2017-07-17 11:41:34 -04:00
Guo Xiang Tan
13f3de4bf6
Nuke all `SiteSetting.stubs` from our codebase.
2017-07-07 15:09:14 +09:00
Régis Hanol
cdf8baac3b
fix specs due to new default emoji set
2017-06-26 23:36:30 +02:00
Jakub Macina
bf002e0873
Add extraction of image_url for oneboxed images. Fix search by images filter name.
2017-06-19 15:18:02 +02:00
Joffrey JAFFEUX
09d34b7642
emoji images are now v5 not v3
...
TODO: we should not hardcode this
2017-06-05 16:10:36 +02:00
Robin Ward
009e120e13
FIX: Don't raise an error when the img attribute cannot be found
2017-05-08 15:35:31 -04:00
Régis Hanol
02bb7beaaf
FIX: don't put attachments on the CDN when 'prevent anons from downloading files' is enabled
2017-02-07 18:06:44 +01:00
Arpit Jalan
19f7beaa2c
FIX: topic links were getting dropped when post is rebaked
2017-01-30 14:55:53 +05:30
Arpit Jalan
2d0c99636a
do not add rel noreferrer
2016-11-20 18:19:14 +05:30
Arpit Jalan
7cb76f7333
FIX: add rel noopener and noreferrer in addition to nofollow
2016-11-20 17:07:27 +05:30
Arpit Jalan
382803cb05
FEATURE: include post image in OpenGraph image tag
2016-10-31 15:11:33 +05:30
Guo Xiang Tan
7db33cc512
FIX: Videos and audio files were not associated to the post.
2016-10-18 16:13:39 +08:00
Robin Ward
4061725a95
FIX: Don't ever grant badges when they're disabled
2016-08-19 15:16:37 -04:00
Robin Ward
aef954784a
FIX: `nofollow` was being added during post processing when it shouldn't
2016-08-12 15:35:13 -04:00
Guo Xiang Tan
11afb20772
SECURITY: Escape HTML in filename.
2016-08-11 11:27:12 +08:00
Régis Hanol
e55e2aff94
FIX: FirstReplyByEmail badge wasn't granted
...
DEPRECATED: PostProcess badge trigger
2016-08-10 19:24:01 +02:00
Jeff Atwood
1379bd5053
fix all v=2 spec / test errors for emoji
2016-07-25 15:53:48 -07:00
Régis Hanol
caa1aea995
FIX: ensure emojis have absolute URLs and uses CDN
2016-07-15 18:37:51 +02:00
Robin Ward
a546395397
REFACTOR: Migrate markdown functionality in ES6
2016-07-11 12:57:05 -04:00
Arpit Jalan
2facb6190f
FEATURE: new site setting download_remote_images_max_days_old
2016-07-06 19:33:51 +05:30
Guo Xiang Tan
bd07658a37
PERF: Split queries when cleaning uploads.
...
This reduces the number of scans that the db has to do in the query
to fetch orphan uploads. Futheremore, we were not batching our
records which bloats memory.
2016-07-04 16:34:32 +08:00
Régis Hanol
667dd54a23
FEATURE: new 'crop_tall_images' site setting
2016-05-23 16:18:30 +02:00
Neil Lalonde
f62ffce03b
Merge pull request #4053 from xfalcox/patch-5
...
FIX: Image Lightbox on Subfolder Install
2016-04-20 15:16:35 -04:00
Robin Ward
0396b14b70
FEATURE: New "First Onebox" badge
2016-04-12 15:31:14 -04:00
Sam
22b2f5285c
FIX: extract links in post processor
...
when oneboxes are not cached or are refreshed they can introduce new
links, these links must be extracted otherwise you can not follow them
2016-04-12 12:28:18 +10:00
Robin Ward
5059ee04b9
Remove `UserFirst` table and grant Emoji badge directly
2016-04-07 12:31:41 -04:00
Rafael dos Santos Silva
ef1558c98d
Remove unnecessary post fabricator
2016-03-20 08:58:33 -04:00
Rafael dos Santos Silva
c72363ebd7
Adds large image upload on subfolder install spec
2016-03-10 00:48:50 -03:00
Guo Xiang Tan
00078a438b
FIX: `FastImage#size` returns `nil` if it can't fetch the image size.
2016-03-08 11:29:18 +08:00
Régis Hanol
dcd0270d52
FIX: don't use the CDN for attachments when login is required
2016-01-06 21:54:01 +01:00
Andy Waite
3e50313fdc
Prepare for separation of RSpec helper files
...
Since rspec-rails 3, the default installation creates two helper files:
* `spec_helper.rb`
* `rails_helper.rb`
`spec_helper.rb` is intended as a way of running specs that do not
require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's
current `spec_helper.rb` does).
For more information:
https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
In this commit, I've simply replaced all instances of `spec_helper` with
`rails_helper`, and renamed the original `spec_helper.rb`.
This brings the Discourse project closer to the standard usage of RSpec
in a Rails app.
At present, every spec relies on loading Rails, but there are likely
many that don't need to. In a future pull request, I hope to introduce a
separate, minimal `spec_helper.rb` which can be used in tests which
don't rely on Rails.
2015-12-01 20:39:42 +00:00
Robin Ward
d65ec1af2e
Rename `ninja_edit_window` to `editing_grace_period` :'(
2015-11-24 14:28:42 -05:00
Robin Ward
f155ff8270
FIX: Tests would fail if your test db's optimized image ids were high
2015-10-16 17:08:41 -04:00
Régis Hanol
54d6d24cbf
FIX: timing issue with edits and cook post processing
2015-09-29 18:51:26 +02:00
kerryliu
c85835afc3
FIX: rescale image during cooked_post_processor when only img height or width is specified
2015-08-29 15:23:25 -07:00
Régis Hanol
82d743a052
FIX: don't use emojis as topic image
2015-08-05 12:57:31 +02:00
Sam
7a5a195dc0
FIX: properly support HTTPS CDN on HTTP site
...
Previously we changed all CDN links to schemaless.
This is desirable for non HTTPS sites, to ease migration to HTTPS.
It is not desirable for secure sites.
Once site is secure or CDN is secure a rebake should be required
to move it back to non-secure.
2015-07-24 14:08:32 +10:00
Régis Hanol
4f1a72f729
fix build
2015-05-28 01:38:24 +02:00
Régis Hanol
8e7bfd0f29
FIX: automatically growing uploads tree
2015-05-28 01:03:24 +02:00
Régis Hanol
9ded21e4c6
FIX: consistent and future-proof upload storage pattern
2015-05-19 12:31:12 +02:00
Régis Hanol
a737090442
- FEATURE: revamped poll plugin
...
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
Régis Hanol
5d74cadf2f
FIX: picture would be hidden when [details] block was closed in the composer
2015-03-16 18:57:15 +01:00
Luciano Sousa
0fd98b56d8
few components with rspec3 syntax
2015-01-09 13:34:37 -03:00
Régis Hanol
862c8a19a3
FEATURE: use img's title attribute in overlay information when provided
2014-11-03 22:03:06 +01:00
Régis Hanol
31e9cafe0e
FEATURE: use original filename when clicking the download link in the lightbox
2014-10-15 19:20:04 +02:00
Régis Hanol
de76b512c1
fix most deprecations in the specs (still some left)
2014-09-25 17:44:48 +02:00
Régis Hanol
5681338b08
FIX: log a staff action + send a private message when disabling the 'download_remote_images_to_local' site setting
2014-09-23 19:11:43 +02:00
Sam Saffron
330ea82ce4
FIX broken spec
2014-05-27 13:52:39 +10:00
Sam
033cbc61bf
BUGFIX: broken spec
2014-05-27 10:08:03 +10:00
Sam
504cfcff96
Fix specs for avatars
...
Implement avatar picker
Correct avatar related jobs
2014-05-27 10:08:03 +10:00
Régis Hanol
b61abe3107
FEATURE: warn the admin whenever we disable the download_remote_images_to_local site setting
2014-04-23 12:43:10 +02:00
Régis Hanol
2505d18aa9
FEATURE: support email attachments
2014-04-14 22:55:57 +02:00
Régis Hanol
06dd7ffe3c
better revision history
2013-12-12 03:41:34 +01:00
Régis Hanol
5150376e12
add wrapper class for lightboxes
2013-12-02 10:06:48 +01:00
Régis Hanol
298b54c0e7
add download link in lightbox
2013-11-29 20:03:39 +01:00
Régis Hanol
6b6c3d05dd
FIX stretched thumbnails
2013-11-25 18:36:13 +01:00
Régis Hanol
f65cde3cda
do not bump posts when rebaking
2013-11-22 01:52:26 +01:00
Régis Hanol
31fd5b85bc
FIX markdown hotlinked images were not properly pulled
2013-11-20 13:10:08 +01:00
Régis Hanol
8a83f1a88f
add disk space usage failsafe
2013-11-15 16:48:38 +01:00
Régis Hanol
16267e4887
add download_remote_images_to_local site setting
2013-11-15 15:22:18 +01:00
Régis Hanol
3992aa971d
ninja_edit_window is is seconds, not minutes
2013-11-06 11:08:57 +01:00
Régis Hanol
37fd7ab574
pull hotlinked images
2013-11-05 19:07:29 +01:00
Régis Hanol
4536b5fe04
added a job to clean up orphan uploads
2013-10-15 11:15:48 +02:00
Régis Hanol
cd4cda5b4c
allow users to specify thumbnail size
2013-09-27 10:57:31 +02:00
Régis Hanol
32f717420d
add max_image_height site setting
2013-08-26 00:24:24 +02:00
Régis Hanol
c867b67a0b
custom avatar support
2013-08-13 22:08:29 +02:00
Régis Hanol
ed9417fa3b
enable thumbnailing on S3
...
- added url to optimized image model
- refactored s3_store & local_store
2013-07-31 23:26:34 +02:00
Sam
0a7bbb08e1
fix broken build
2013-07-24 17:24:55 +10:00
Régis Hanol
dbf6fb0232
change the pipe into a bullet in the lightbox overlay
2013-07-22 22:41:08 +02:00
Régis Hanol
649ab85740
FIX: thumbnailing wasn't working with CDN enabled
2013-07-22 00:37:23 +02:00
Régis Hanol
3136638b4b
FIX: CDN doesn't work with S3
2013-07-16 22:16:33 +02:00
Régis Hanol
00d7d8b809
ooops, fixed CookedPostProcessor specs
2013-07-15 00:18:17 +02:00
Régis Hanol
3397c2235f
display the size of the attachment in the preview
...
instead of adding it during post processing
2013-07-14 12:28:24 +02:00
Régis Hanol
b94d26d798
update back-end specs
2013-07-10 22:59:54 +02:00
Régis Hanol
ac7253a938
refactor CookedPostProcessor & specs
2013-07-08 01:39:08 +02:00
Régis Hanol
6251935b1e
removed auto_link_images_wider_than setting
2013-07-06 22:19:16 +02:00
Régis Hanol
5a56af03bc
FIX: can no longer paste image in Chrome post editor
2013-07-04 00:39:23 +02:00
Régis Hanol
72745d257d
provide a way to give a default filename to pasted images in the lightbox overlay
2013-06-26 21:54:08 +02:00
Régis Hanol
d3eae56e71
soften the lightbox overlay
2013-06-26 02:44:20 +02:00
Régis Hanol
52b8e6014b
forgot to commit the test
2013-06-24 22:56:03 +02:00
Sam
22d6f6784c
Merge pull request #1075 from ZogStriP/fix-lightboxing-when-using-s3
...
FIX: lightbox wasn't working when using s3 upload
2013-06-23 22:11:45 -07:00
Régis Hanol
361062d53e
do not lightbox oneboxed images
2013-06-24 02:10:21 +02:00
Régis Hanol
08aa23f0ca
FIX: lightbox wasn't working when using s3 upload
2013-06-22 13:38:42 +02:00
Régis Hanol
7bdc616040
keep uploads reverse index up to date
2013-06-17 22:46:48 +02:00
Régis Hanol
510bac4b27
refactored a bit & tested thumbnails creation
2013-06-17 02:49:34 +02:00
Régis Hanol
2c3f757951
moved `has_been_uploaded` and `uploaded_regex` to the `Upload` model
2013-06-17 02:49:34 +02:00
Régis Hanol
c11f4456ae
cleaned up CookedPostProcessor and improved specs
2013-06-17 02:49:34 +02:00
Michael Kessler
d2e45cb8fd
Don't append the base url to absolute image urls without protocol.
2013-05-30 17:17:07 +02:00
Régis Hanol
c2e58b61c9
automatically resizes images
2013-04-15 23:32:26 +02:00
Sam
33e3ad1603
clean up onebox application so it uses a single code path
...
use fragments for oneboxes
strip parent <p> if <div> is in it
clean some tests
2013-04-10 17:52:38 +10:00
Karan Misra
5dfb04e4b3
Convert a lot of :a => b to a: b and bring peace to the world
2013-03-25 05:07:36 +05:30
Robin Ward
b6224b014c
Move a bunch of callbacks into PostCreator
2013-03-18 13:56:26 -04:00
Gosha Arinich
cafc75b238
remove trailing whitespaces ❤️
2013-02-26 07:31:35 +03:00
Sam Saffron
d9531d94d5
basic lightbox support
2013-02-19 17:57:14 +11:00
Jaime Iniesta
6995e75d41
Replace Hpricot with Nokogiri
2013-02-14 11:35:50 +01:00
Robin Ward
21b5628528
Initial release of Discourse
2013-02-05 14:16:51 -05:00