Commit Graph

31747 Commits

Author SHA1 Message Date
Régis Hanol c256121833 FIX: add support for style element in SVGs 2019-02-07 12:09:06 +01:00
David Taylor 0c14f0d0a0 UX: Rename color scheme to color palette in UI
The word 'scheme' was very easy to get confused with 'theme', this provides a better distinction.
2019-02-07 11:04:49 +00:00
Sam 19386ec2ea FIX: old migration was loading up invalid model schema
Generally we should never be touching AR objects in migrations, this is
super risky as we may end up with invalid schema cache.

This code from 2013 did it unconditionally. This change amends it so:

1. We only load up schema if we have no choice
2. We flush the cache before and after

This makes this migration far less risky.
2019-02-07 15:16:28 +11:00
Kris 1cacfddda4 Prevent usercard badge section from overflowing 2019-02-06 22:39:10 -05:00
Kris 984f1d96b0 Add max-width so long badges don't force short badges to truncate 2019-02-06 20:51:54 -05:00
Kris 94f8c4ecac UX: Truncate (don't wrap) badges in user cards if the text is long 2019-02-06 20:18:12 -05:00
Dan Ungureanu 6c2fe7eaec
DEV: Fix lint. 2019-02-06 23:55:05 +02:00
Dan Ungureanu fc4c015bee FEATURE: Shortcut 'g s' goes to first suggested topic 2019-02-07 08:43:07 +11:00
David Taylor b88aa4a592 FIX: Correctly process {{each}} in raw handlebars templates for themes 2019-02-06 21:09:21 +00:00
Kris 56a9f777cb UX: Turn off autocomplete on composer title 2019-02-06 14:37:29 -05:00
Arpit Jalan ab2c2ea605
FIX: validate Invite email against `EmailValidator.email_regex` (#6975) 2019-02-06 22:38:06 +05:30
Robin Ward ca03b2ff30 Move SCSS variables for topic post width
This allows them to be re-used by other components, for example the
upcoming review queue.
2019-02-06 11:37:59 -05:00
Régis Hanol 057d1dc077 UX: disable browser's autocomplete in search menu 2019-02-06 17:06:23 +01:00
David Taylor f3cfce4a93
FEATURE: Calculate sprite-sheet based on currently active themes (#6973)
Previously there was only one sprite sheet, which always included icons from all themes even if they were disabled
2019-02-06 15:51:23 +00:00
Vinoth Kannan ba9cc83d4c FIX: Destination prefix in S3 inventory configuration is incorrect 2019-02-06 20:51:28 +05:30
Arpit Jalan 381793243e FIX: include error message if the "accept invite" process fails 2019-02-06 19:20:25 +05:30
Vinoth Kannan ff12c4b2d4 FIX: Bucket name is missing in S3 inventory data path 2019-02-06 19:16:08 +05:30
Sam 15857b900a DEV: explicitly require Rails components
`rails/all` includes too much stuff per: https://github.com/rails/rails/blob/master/railties/lib/rails/all.rb

This commit makes it explicit what pieces of Rails Discourse depends on.

Previously the LoadError was protecting us and we were excluding components,
using the Gemfile, this method ensures that even if we add `rails` meta gem
as a dependency only the parts of Rails Discourse uses will be used.
2019-02-06 17:45:48 +11:00
Sam fe7c10b409 DEV: fix seed-fu require for rails 6 2019-02-06 17:33:36 +11:00
Sam 4cfc201604 DEV: update logster to stable release
This update logster to the stable 2.0.1 release instead of running a pre
release
2019-02-06 16:54:42 +11:00
Sam 448ea663c3 DEV: remove seed-fu pinning from rails master
This pinning should no longer be needed
2019-02-06 16:54:06 +11:00
Sam 0098b3072e DEV: update rack-mini-profiler
This gem update fixes an issue with upcoming Rails 6

(without this fix mini profiler will not work on rails 6 and simply renders
text)
2019-02-06 16:51:45 +11:00
Kris 1a72242746 line-height adjustment 2019-02-05 21:44:06 -05:00
Kris a52b2c9625 UX: Moving the create theme buttons, adding buttons to theme index 2019-02-05 21:40:17 -05:00
Gerhard Schlager bdbf77dc38 FIX: Unpause Sidekiq before uploading backup to S3
No need to pause Sidekiq longer than really needed. Uploads to S3 can take a long time.
2019-02-05 21:22:25 +01:00
Vinoth Kannan e7821a63e7 FIX: Users should able check the emails for self 2019-02-05 23:31:19 +05:30
Gerhard Schlager ba724d7f25 FIX: S3 endpoint broke bucket creation in non-default region 2019-02-05 18:17:02 +01:00
David Taylor fc999c04b3
Drop facebook_user_infos and twitter_user_infos (#6970)
Data was migrated to user_associated_accounts in 208005f and 160d29b
2019-02-05 15:12:39 +00:00
David Taylor a3b47c1dd1 FEATURE: Allow string theme settings to display with multiple lines
To use, add `textarea: true` to the theme settings.yml. For example:

```
my_setting:
  default: "some string"
  textarea: true
```
2019-02-05 14:14:53 +00:00
David Taylor 7b7bc3db39 FIX: Rescue and display import errors when updating theme via git 2019-02-05 13:49:16 +00:00
Maja Komel d42139dfaa fix typo 2019-02-05 12:59:20 +01:00
Dan Ungureanu 31ffcf989c
UX: Use translatedLabel for aria-label in buttons. 2019-02-05 13:11:07 +02:00
Bianca Nenciu 4f3ee86bbd FIX: in:title should work irrespective of the order. (#6968) 2019-02-05 10:54:52 +01:00
Dan Ungureanu 2c222e16fe FEATURE: Returning falsy value from upload handler stops upload. (#6969) 2019-02-05 10:54:11 +01:00
Joe a342d2f150 UX: reduces white-space in polls (#6956)
* reduces white-space in polls and uses font-size variables
2019-02-05 10:47:22 +01:00
Kris b6e3ef4a90 Minor icon color fix 2019-02-04 22:14:18 -05:00
Sam 1748ec421e DEV: gem updates
Another group of gems updated, better_errors is fairly safe as its for dev
chunky_png fairly safe, used for getting image info from pngs, erubi update
is very safe. Sanitize is used by onebox and should always be on latest.

Long term we should think of making sanitize an optional dependency on onebox
cause we are happy to just provide methods from core to do this and it would
remove nokogumbo and sanitize deps.
2019-02-05 12:35:42 +11:00
Sam 27c8688f02 DEV: update dependencies
This updates some more low risk gems, maxmind, hiredis (c wrapper for
redis), puma, rbtrace and stackprof.
2019-02-05 11:23:21 +11:00
Sam 635bc72ec5 DEV: pin redis to version 4.0.1
Version 4.1.0 returns frozen hashes which conflict with our monkey patch

We will follow up unpinning this later
2019-02-05 09:08:44 +11:00
Kris 8b88c738cf
Updating README images 2019-02-04 16:52:11 -05:00
Penar Musaraj edcdbe1946 DEV: Restore textarea type for site settings
Currenty, no settings in core use this, but textareas will be useful in theme settings and plugins.
2019-02-04 15:41:58 -05:00
Robin Ward e5a81aeb6e REFACTOR: Remove stubbed methods in tests 2019-02-04 15:06:00 -05:00
Sam be24220e95 DEV: update low risk gems
This follows up on 03376224 which reverted the redis update which is not
supported, rest of the gems should be fine.(unicorn / nokogiri / sidekiq /
pg)
2019-02-05 06:54:10 +11:00
Kris 58d5fc3632 UX: Minor button icon color fixes 2019-02-04 12:46:12 -05:00
Jeff Wong 9de906ddab
FIX: Register pan events for touch only
* touch events - only register touch, not pointer events
* immediately request redraw frame, do not wait for after render to fire.
2019-02-04 08:27:40 -08:00
Bianca Nenciu e0e91fad87 FIX: Fix delete button for Tag Groups. (#6965) 2019-02-04 12:46:39 +01:00
Sam 0337622420 Revert "DEV: more low risk gem updates"
This reverts commit 2c53dde918

Turns out redis upgrade breaks our usage of redis, more internal fixes
are required
2019-02-04 18:11:09 +11:00
Sam 2c57b65bfc DEV: update more gems including i18n
This updates a few more lower risk gems, the main goal here is to have
nothing outdated. Avoiding a giant commit is going to make it slightly
easier to partially roll back if something goes wrong
2019-02-04 17:54:39 +11:00
Sam ab23615077 DEV: update rubocop gem to latest
not much to say here, the new version seems compatible with Discourse,
no changes appear to be needed
2019-02-04 17:52:10 +11:00
Sam 2c53dde918 DEV: more low risk gem updates
redis/sidekiq/unicorn/nokogiri and pg all are fairly safe to update
2019-02-04 17:48:31 +11:00