Commit Graph

14990 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 63c63c1bfd Skip wizard tests
awaiting fixes on select-box-kit
2017-10-19 15:18:01 -07:00
Joffrey JAFFEUX d77ef05ee1 Fix broken tests 2017-10-19 14:32:37 -07:00
Robin Ward aad5118aa9 FIX: Post Action Type 6 is not a notify type 2017-10-19 17:13:55 -04:00
Robin Ward 552b66a2ff Add a helper for the `user-select` vendor prefix CSS 2017-10-19 15:54:19 -04:00
Joffrey JAFFEUX ae1743c61f [WIP] select-box-kit refactoring 2017-10-19 12:51:08 -07:00
Robin Ward a9f718fe57 FIX: Custom flags didn't work when flagging a topic 2017-10-19 14:27:38 -04:00
Robin Ward 7cfb8ed5c1 FIX: You can't notify a user on a flag topic 2017-10-19 14:11:31 -04:00
Robin Ward 838568cbc3 Refactor flag types for more customization 2017-10-19 13:55:23 -04:00
Gerhard Schlager 1cae875146 FIX: topic link extraction shouldn't fail when the parsed URL has no path 2017-10-19 15:26:37 +02:00
Gerhard Schlager 3cd73cdf18 FIX: fancy topic title must fit into column 2017-10-19 14:34:30 +02:00
Guo Xiang Tan 22ba70fb01 Merge pull request #5226 from tgxworld/allow_user_to_disable_private_messages
FEATURE: Allow users to disable new PMs.
2017-10-19 16:46:18 +08:00
Guo Xiang Tan 5b9ddaf972 FIX: `Topic#fancy_title` should not write in readonly mode. 2017-10-19 16:07:03 +08:00
Guo Xiang Tan 25c25ae423 FEATURE: Allow user to leave a PM. 2017-10-19 12:32:55 +08:00
Guo Xiang Tan 79de10b212 FEATURE: Allow users to disable new PMs.
https://meta.discourse.org/t/is-it-possible-to-disable-private-messaging-for-a-specific-user/46391
2017-10-19 12:32:55 +08:00
Régis Hanol c838f43a75 let's not generate an error when logging errors... 2017-10-18 23:14:13 +02:00
Arpit Jalan f50d447881 FIX: render secure category topics in RSS if the user can view the topics 2017-10-18 14:23:30 +05:30
Sam 7f9b0f5e60 try moving shortcut to ctrl+alt+f 2017-10-18 12:20:45 +11:00
Robin Ward 69920b7e60 UX: More flag modal improvements. Remove `!important` class 2017-10-17 11:37:30 -04:00
Robin Ward 77652f4387 FIX: Use computed properties instead of manual HTML for buttons
This way they receive the proper classes
2017-10-17 11:23:44 -04:00
Robin Ward 62b260b3f9 UX: Improve markup for flag modal 2017-10-17 10:44:52 -04:00
Guo Xiang Tan b54eb8f53c FIX: Set PG `connect_timeout` to 5 seconds.
* 30 seconds is alittle too long.
2017-10-17 12:32:41 +08:00
Neil Lalonde 2db66072d7 SECURITY: signup without verified email using Google auth 2017-10-16 13:51:41 -04:00
Robin Ward 80d0c6df7c Use a `user-stat` for the read time too 2017-10-16 13:18:52 -04:00
Robin Ward fb2e581b26 FIX: Headings must begin with `heading--` to avoid some griefing 2017-10-16 11:53:47 -04:00
Sam 229a10e142 Missed a whitelist, compensate for strict classes 2017-10-16 10:46:01 +11:00
Sam 7af1bf32d5 UX: switch global search trigger to ctrl+alt+s
Otherwise it conflicts with firefox
2017-10-16 10:01:17 +11:00
Sam 9cb088e3f6 FIX: restrict classes allowed for img tag in Markdown 2017-10-16 09:34:30 +11:00
Joshua Rosenfeld 64e5532b90 Add div to login-required text 2017-10-15 14:45:24 -04:00
Robin Ward 30bb3b4a86 Include category for summary topics 2017-10-13 16:29:56 -04:00
Robin Ward 5572d1d5f7 Refactor user summary page to use more components 2017-10-13 16:05:40 -04:00
Robin Ward f73a3cc0d4 Don't include suspended_at or suspended_till unless suspended 2017-10-13 12:17:54 -04:00
Kris dc2d9f05dc removing scale-color, first pass 2017-10-13 11:57:10 -04:00
Robin Ward c2a8b95e83 FIX: Don't show the up arrow to jump to posts in different topics 2017-10-13 11:56:44 -04:00
Neil Lalonde c53f41f4f2 FIX: don't flag watched words when rebaking posts 2017-10-12 15:34:22 -04:00
Robin Ward c383cf82a7 Pass `hideCategory` through to the plugin outlet 2017-10-12 12:22:41 -04:00
Robin Ward 4d8619f62c Move topic list extensibility to `topic-list` component 2017-10-12 12:03:22 -04:00
Arpit Jalan 97395ebb66 FIX: SSO avatar downloads were broken
cc @tgxworld
2017-10-12 12:12:04 +05:30
Guo Xiang Tan 4e89d3f778 Only refresh site settings once on initialization. 2017-10-12 14:12:18 +08:00
Régis Hanol f7282e4ecd use force_https site setting when adding scheme for downloading schemaless images locally 2017-10-12 00:06:24 +02:00
Régis Hanol 4e78abb537 let's try 3 times to download images locally 2017-10-11 23:11:44 +02:00
Robin Ward c9b5ef9f58 Typo'd name of jump-bottom 2017-10-11 15:47:18 -04:00
Robin Ward d43fa4d584 Extension points for topic list on discovery page 2017-10-11 14:50:17 -04:00
Robin Ward 8a8d3a3a7e Allow `currentUser` to be passed into raw templates automatically 2017-10-11 12:21:24 -04:00
Robin Ward ba5635f3fc UX: `break-all` looks a bit weird. Removing for now. 2017-10-11 11:32:53 -04:00
Gerhard Schlager c0bb97b5cb FIX: delete staged users when the incoming email is rejected 2017-10-11 16:17:01 +02:00
Guo Xiang Tan 9dcb11f553 Fix the build. 2017-10-11 17:45:19 +08:00
Guo Xiang Tan 09721090a3 FIX: Ensure that we revert back to default connection after running jobs. 2017-10-11 17:17:03 +08:00
Robin Ward faa4c4e5f7 FIX: Sort icons were not showing up 2017-10-10 10:54:43 -04:00
Robin Ward 14b1736c74 Include `currentPath` in the `below-site-header` plugin outlet 2017-10-09 13:58:43 -04:00
Arpit Jalan a2183c3f1d SECURITY: verify that inviter can invite new user to a topic 2017-10-09 15:59:41 +05:30
Guo Xiang Tan 59aeb0bc56 FIX: Sidekiq hot reloading wasn't working in dev.
https://meta.discourse.org/t/webhooks-sidekiq-issue-on-dev-instance/71129

* Remove code that is no longer required as well.
2017-10-09 18:23:25 +08:00
Guo Xiang Tan 1d0fadd48c Merge pull request #5227 from majakomel/delete-tag-confirm
UX: Improve Delete Tag Confirm Message
2017-10-09 11:26:12 +08:00
Guo Xiang Tan a6f2533d38 SECURITY: Fix XSS on unsubscribed page. 2017-10-09 09:04:46 +08:00
Guo Xiang Tan 6fe604b93e Revert "SECURITY: Fix XSS on unsubscribed page."
This reverts commit 190558db9d.
2017-10-09 09:03:07 +08:00
Guo Xiang Tan 190558db9d SECURITY: Fix XSS on unsubscribed page. 2017-10-09 08:59:03 +08:00
Sam 4ea87b5ab8 Merge branch 's3_refactor' 2017-10-09 10:27:52 +11:00
Robin Ward 4da4f986ee FIX: Clicking on quote button was tricky 2017-10-06 21:29:16 -04:00
Robin Ward 193244f8c1 Convert quote button to use d-icon 2017-10-06 15:45:43 -04:00
Robin Ward 494ad1e9de Convert quote controls to use `d-icon` 2017-10-06 15:42:24 -04:00
Robin Ward f4decf9193 The `quote-other-topic` class has been removed 2017-10-06 15:16:06 -04:00
Régis Hanol 8d14d55fc5 make rubocop happy 2017-10-06 16:48:11 +02:00
Régis Hanol 3bdd8f57c1 FIX: invited staged users would sometimes not get notified of replies 2017-10-06 16:37:28 +02:00
Maja Komel 5780596c50 use delete_confirm_no_topics instead of nested no_topics 2017-10-06 16:29:29 +02:00
Maja Komel 3c1e005fea missing semicolon 2017-10-06 15:42:53 +02:00
Maja Komel 13cc0fd665 replace zero key with no_topics 2017-10-06 15:35:15 +02:00
Maja Komel 789a354570 UX: Delete Tag Warning Improvement 2017-10-06 12:13:37 +02:00
Sam 70bb2aa426 FEATURE: allow specifying s3 config via globals
This refactors handling of s3 so it can be specified via GlobalSetting

This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3

It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
Guo Xiang Tan 4ba5e678d8 Require dependencies to enable live reload in dev for Sidekiq. 2017-10-06 11:39:00 +08:00
Guo Xiang Tan d67f0b39ae Update annotations. 2017-10-06 11:13:01 +08:00
Guo Xiang Tan 3efde2618d UX: Do not display non-human users on group page.
https://meta.discourse.org/t/members-of-groups-staff/71437
2017-10-06 10:35:40 +08:00
Guo Xiang Tan 8b71a0e49f UX: Restore missing border at the end of topic list. 2017-10-06 08:27:03 +08:00
Robin Ward 5822c64bdc FIX: If you can manage a post you can wiki it 2017-10-05 17:47:52 -04:00
Robin Ward 2ae06e6fd0 More customization for menu items 2017-10-05 17:00:23 -04:00
Robin Ward 0c84352386 Add support for transformations 2017-10-05 16:24:58 -04:00
Robin Ward 7df73c94a0 Add a hook to decorate extra buttons 2017-10-05 14:35:06 -04:00
Guo Xiang Tan 5dc4b469be Remove unused code for Redis Sentinel. 2017-10-05 14:53:03 +08:00
Guo Xiang Tan b0557c6692 UX: Allow users to remove a remind me topic timer. 2017-10-05 11:50:08 +08:00
Neil Lalonde f5a2ed99b0 FIX: deleting category background images sometimes has no effect 2017-10-04 17:04:37 -04:00
Régis Hanol 4771b0a99f FIX: user fields in invite signups were broken 2017-10-04 23:04:24 +02:00
Robin Ward cf4e6e2f5b FIX: `deletePost` action was incorrect called `delete` 2017-10-04 16:12:18 -04:00
Régis Hanol e212435545 FIX: redirect to top wasn't working 2017-10-04 22:08:41 +02:00
Robin Ward 4aa30cba2e Extensibility for Post manage menu 2017-10-04 15:53:06 -04:00
Robin Ward 6d0bf287b5 Allow more extensibility for the post menu buttons 2017-10-04 15:53:06 -04:00
Robin Ward abdb334823 UX: Allow for customization of the heart icon 2017-10-04 11:07:59 -04:00
Guo Xiang Tan 1310181664 FIX: Adding a public topic timer deletes a private topic timer. 2017-10-04 16:31:40 +08:00
Sam ebdf8d6718 remove uneeded code 2017-10-04 15:05:58 +11:00
Sam 14310d2eee UX: title in JS must match title on Server
Corrects title flashing with incorrect value on front page reloads
2017-10-04 15:04:42 +11:00
Kyle Zhao 0342324b47 FEATURE: support regex in rake post:remap (#5201) 2017-10-04 11:47:53 +11:00
Robin Ward 2ce6e0bb07 UX: Perform icon replacements before calling icon renderer 2017-10-03 15:38:59 -04:00
Neil Lalonde 1faae3c765 rename forgot_password_strict to hide_email_address_taken 2017-10-03 15:28:31 -04:00
Neil Lalonde e47f5cedd2 FEATURE: forgot_password_strict setting also prevents reporting that an email address is taken during signup 2017-10-03 15:28:30 -04:00
Robin Ward cc4a102b26 UX: Allow customization on header dropdown sizes 2017-10-03 15:24:18 -04:00
Robin Ward c72ceb1f2d An option to not display categories in the hamburger
This is mostly useful if your site has very few categories.
2017-10-03 14:39:56 -04:00
Robin Ward 4b7256d2e4 FIX: `d-header` in common is `z-index: 1001` 2017-10-03 14:31:25 -04:00
Robin Ward 4fbe4218c4 FIX: Header primary color was too dark in dark mode 2017-10-03 13:01:05 -04:00
Régis Hanol daf1dda700 FIX: username autocomplete in assign modal wasn't working 2017-10-03 12:49:45 +02:00
Guo Xiang Tan a5b7d34fe2 Merge pull request #5199 from xrav3nz/poll-feed-integration-test
TEST ONLY: PollFeed integration test
2017-10-03 14:33:22 +08:00
Guo Xiang Tan a966f2134c Merge pull request #5215 from gschlager/email_templates
Add specs for EmailTemplatesController
2017-10-03 14:30:19 +08:00
Guo Xiang Tan 3e53dbcade UX: Only include tag hashtag postfix when necessary.
https://meta.discourse.org/t/links-to-tags-not-working-in-final-post-unless-autocompleted/69884/6?u=tgxworld
2017-10-03 13:54:50 +08:00
Guo Xiang Tan 81c0092326 Revert "FIX: not serving non brotli cdns from cdn_url"
This reverts commit eaa896d8ee.
2017-10-03 10:52:28 +08:00
Sam eaa896d8ee FIX: not serving non brotli cdns from cdn_url
(this means that access control allow origin could break)
2017-10-03 11:20:08 +11:00
Robin Ward 1022535c2b UX: Add a two week suspension timeframe 2017-10-02 15:23:58 -04:00
Robin Ward 56793d6853 FIX: Better flagging CSS on mobile 2017-10-02 15:14:07 -04:00
Robin Ward f7c967b754 Add forever to the suspension dropdown 2017-10-02 15:04:22 -04:00
Arpit Jalan 469c6776c6 FIX: exporting admin dashboard reports were broken
http://eileencodes.com/posts/actioncontroller-parameters-now-returns-an-object-instead-of-a-hash/
2017-10-02 19:30:23 +05:30
Gerhard Schlager 5bb326a452 Add specs for EmailTemplatesController 2017-10-02 14:53:27 +02:00
Guo Xiang Tan 8140e54675 FIX: More fixes for `Group#mentionable` and `Group#messageable` feature. 2017-10-02 17:45:58 +08:00
Guo Xiang Tan 91c5f928c2 FIX: `Group#mentionable` and `Group#messageable` not fully working. 2017-10-02 16:50:58 +08:00
Guo Xiang Tan 4ae3a4e89e UX: Label should toggle checkbox.
https://meta.discourse.org/t/clicking-label-for-automatically-set-as-primary-group-doesnt-toggle-setting/71086/2
2017-10-02 16:07:53 +08:00
OsamaSayegh 79f3d299a1 Don't allow category definition topics to be converted to PMs (#5216) 2017-10-02 10:04:58 +02:00
Kyle Zhao ac666ddf17 PollFeed: check 'content:encoded' for content first 2017-10-02 01:16:11 -04:00
Guo Xiang Tan 0f2c5f5fc9 FIX: Don't raise error when trying to download avatar from URL. 2017-10-02 12:59:41 +08:00
Guo Xiang Tan 974836962d Fix invalid method call. 2017-10-02 12:50:22 +08:00
Guo Xiang Tan 4e07bbfbbf FIX: Only allow intergers for page params. 2017-10-02 10:45:54 +08:00
Guo Xiang Tan 77ea063751 FIX: Missing attribute. 2017-10-02 10:24:37 +08:00
Eleanor Demis ac04f5e0cc update response error when deleting tags (#5213) 2017-09-30 16:31:32 +02:00
Guo Xiang Tan 4eeb6014f4 Don't raise an error if user has been destroyed. 2017-09-30 09:09:40 +08:00
Neil Lalonde d5d66e969e FIX: js error when logging in using another Discourse site as sso provider 2017-09-29 14:02:45 -04:00
Robin Ward 2c2fe7eee4 FIX: Remove unused mixin 2017-09-29 11:09:25 -04:00
Robin Ward 00b190af75 Revert "A safe way to create class variables in a multisite environment."
The approach taken by this interface was flawed. We need a better
solution.
2017-09-29 11:06:12 -04:00
Guo Xiang Tan a370d7c7fd FIX: Compatibility between Client and Server routing.
mend
2017-09-29 10:34:50 -04:00
Robin Ward c1f174f554 FIX: Okay, try going back to the old way. Too many exceptions. 2017-09-29 10:19:35 -04:00
Robin Ward 0caf6a0f7d Support for HTML values in widget hbs templates 2017-09-29 09:56:14 -04:00
Régis Hanol f6c484881b FIX: wasn't able to save watched/tracked/muted categories/tags 2017-09-29 13:09:48 +02:00
Arpit Jalan 689f949fdb Merge pull request #5209 from techAPJ/has-messages
FIX: update group.has_messages field weekly
2017-09-29 09:12:26 +05:30
Arpit Jalan d64853dfa0 FIX: update group.has_messages field weekly 2017-09-29 08:23:07 +05:30
Sam 05dd97ffe0 correct iPad sizing 2017-09-29 11:49:10 +10:00
Guo Xiang Tan 6baea9948b Revert "fix the build"
This reverts commit 8b74c7d325.
2017-09-29 08:57:06 +08:00
Robin Ward df81d109e5 The ability to attach `attrs` when embedding widgets 2017-09-28 16:08:43 -04:00
Robin Ward 01c6224ca5 Include the `currentRouteName` in the page change event 2017-09-28 14:31:20 -04:00
Robin Ward 954013a45c Use `appEvents` for page tracking so widgets can listen to it easily 2017-09-28 14:20:32 -04:00
Neil Lalonde c7aa354ee8 UX: round instead of ceil for time gaps 2017-09-28 14:11:37 -04:00
Robin Ward 34f98f362f Add a plugin hook to specify a class on the body of the document 2017-09-28 13:17:09 -04:00
Joshua Rosenfeld ca3d6921a0 Add group name css target 2017-09-28 11:43:52 -04:00
Robin Ward 7df349afd6 Allow reopened widgets to use `hbs` templates 2017-09-28 11:13:30 -04:00
Robin Ward 132cbac600 Split out header contents for easier customization 2017-09-28 10:46:07 -04:00
Régis Hanol 8b74c7d325 fix the build 2017-09-28 15:50:01 +02:00
Régis Hanol cd6dff58dd FIX: add user option/profile fields that were not permitted 2017-09-28 14:59:53 +02:00
Sam b2575a8ce3 improve keyboard height detection 2017-09-28 21:25:03 +10:00
Guo Xiang Tan d79fee9ff3 Fix undefined method for Nil class error. 2017-09-28 17:38:53 +08:00
Guo Xiang Tan 5d53eefcab Fix broken test. 2017-09-28 16:09:58 +08:00
Sam cfed431ef2 More height hacks for iPhone 2017-09-28 18:06:00 +10:00
Guo Xiang Tan 30fa5379ce Merge pull request #5195 from henrik/patch-1
100.years.ago -> Time.at(0)
2017-09-28 15:47:06 +08:00
Guo Xiang Tan 5f1c29e424 FIX: Display json response when `Discourse::InvalidAccess` is raised for
non json requests.
2017-09-28 15:31:16 +08:00
Guo Xiang Tan 373fd8990e PERF: N+1 when generating not found page. 2017-09-28 15:31:16 +08:00
Sam d36d5ba8ac Correct iPad fudge factors for keyboard size detection 2017-09-28 17:26:54 +10:00
Sam 8ecf313a81 FIX: correctly raise errors when downloads fail
This corrects an issue where we are hitting Gravatar for 404 over and over

Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
Guo Xiang Tan 4319d8a142 FIX: Missing template error when rendering `topics#show` error message. 2017-09-28 11:06:44 +08:00
Sam b80320da5e no verbose logging for failed downloads of gravatars 2017-09-28 11:32:26 +10:00
Régis Hanol 3a75242c38 add more logs to pull hotlinked images 2017-09-28 01:00:13 +02:00