b0ac98b465
DEV: remove H1 from crawler view header ( #18201 )
2022-09-12 10:46:00 -04:00
dacdec5acc
UX: trigger tooltips on click for touch devices ( #18198 )
2022-09-12 10:04:20 -04:00
761864d4f4
DEV: Add favicon to dev ember proxy ( #18228 )
...
One less console warning in tests
2022-09-12 15:46:50 +02:00
5c0f770f0f
DEV: Refactor self-delete dialog ( #18180 )
...
Also adds missing test
2022-09-12 09:45:53 -04:00
fa58eea64e
DEV: Minor code cleanup ( #18225 )
...
Various small changes made while debugging MessageBus-related tests.
2022-09-12 14:05:21 +02:00
ec32b61319
DEV: Add another missing `await` ( #18226 )
2022-09-12 14:03:39 +02:00
08e63ddab2
DEV: Fix spec file name ( #18227 )
...
Match the impl file name
2022-09-12 14:03:23 +02:00
dfd0ce39f3
Build(deps): Bump mout from 1.2.2 to 1.2.3 in /app/assets/javascripts ( #18224 )
...
Bumps [mout](https://github.com/mout/mout ) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/mout/mout/releases )
- [Changelog](https://github.com/mout/mout/blob/master/CHANGELOG.md )
- [Commits](https://github.com/mout/mout/compare/v1.2.2...v1.2.3 )
---
updated-dependencies:
- dependency-name: mout
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-12 11:40:29 +02:00
584dbb7202
DEV: Update moment.js ( #18207 )
...
Closes #18176
2022-09-12 10:56:39 +02:00
0a49db14a4
Build(deps): Bump ember-exam in /app/assets/javascripts ( #18221 )
...
Bumps [ember-exam](https://github.com/ember-cli/ember-exam ) from 7.0.1 to 8.0.0.
- [Release notes](https://github.com/ember-cli/ember-exam/releases )
- [Changelog](https://github.com/ember-cli/ember-exam/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ember-cli/ember-exam/commits/v8.0.0 )
---
updated-dependencies:
- dependency-name: ember-exam
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-12 10:22:42 +02:00
494a6317d7
DEV: Update dependabot config ( #18218 )
2022-09-12 09:27:10 +02:00
55ee0c8214
Build(deps): Bump oauth from 0.5.10 to 1.1.0 ( #18143 )
...
Bumps [oauth](https://github.com/oauth-xx/oauth-ruby ) from 0.5.10 to 1.1.0.
- [Release notes](https://github.com/oauth-xx/oauth-ruby/releases )
- [Changelog](https://github.com/oauth-xx/oauth-ruby/blob/migrated/CHANGELOG.md )
- [Commits](https://github.com/oauth-xx/oauth-ruby/compare/v0.5.10...v1.1.0 )
---
updated-dependencies:
- dependency-name: oauth
dependency-type: indirect
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 23:25:39 +02:00
327ca5b839
Build(deps): Bump webpack in /app/assets/javascripts ( #18214 )
...
Bumps [webpack](https://github.com/webpack/webpack ) from 5.73.0 to 5.74.0.
- [Release notes](https://github.com/webpack/webpack/releases )
- [Commits](https://github.com/webpack/webpack/compare/v5.73.0...v5.74.0 )
---
updated-dependencies:
- dependency-name: webpack
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 22:35:55 +02:00
aeee7ed03d
UX: Change `posted` notification icon to `discourse-bell-exclamation` ( #18217 )
...
This PR changes the icon for `posted` notification types (these are the notifications that you receive when someone posts in a topic you're watching) from `reply` to `discourse-bell-exclamation`. We're doing this to visually distinguish between the `posted` notifications and `replied` notifications which are the notifications that you receive when someone replies to you directly.
Internal topic: t72835.
2022-09-11 22:57:14 +03:00
725b585a43
Build(deps): Bump ember-cli-htmlbars in /app/assets/javascripts ( #18212 )
2022-09-11 14:53:34 +02:00
da963e88ba
Build(deps): Bump @babel/standalone in /app/assets/javascripts ( #18213 )
2022-09-11 14:53:10 +02:00
e4a79daf24
Build(deps): Bump follow-redirects in /app/assets/javascripts ( #18205 )
...
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects ) from 1.13.3 to 1.15.1.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases )
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.13.3...v1.15.1 )
---
updated-dependencies:
- dependency-name: follow-redirects
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 13:04:45 +02:00
38327ee9d2
Build(deps): Bump sass from 1.53.0 to 1.54.9 in /app/assets/javascripts ( #18197 )
...
Bumps [sass](https://github.com/sass/dart-sass ) from 1.53.0 to 1.54.9.
- [Release notes](https://github.com/sass/dart-sass/releases )
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sass/dart-sass/compare/1.53.0...1.54.9 )
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 13:02:42 +02:00
efa2096155
Build(deps): Bump rubocop from 1.35.1 to 1.36.0 ( #18160 )
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.35.1 to 1.36.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.35.1...v1.36.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 12:13:34 +02:00
0695ebbc72
Build(deps): Bump terser from 4.8.0 to 4.8.1 in /app/assets/javascripts ( #18175 )
...
Bumps [terser](https://github.com/terser/terser ) from 4.8.0 to 4.8.1.
- [Release notes](https://github.com/terser/terser/releases )
- [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/terser/terser/compare/v4.8.0...v4.8.1 )
---
updated-dependencies:
- dependency-name: terser
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 12:09:35 +02:00
f2857cb155
Build(deps): Bump a11y-dialog in /app/assets/javascripts ( #18188 )
...
Bumps [a11y-dialog](https://github.com/KittyGiraudel/a11y-dialog ) from 7.5.0 to 7.5.2.
- [Release notes](https://github.com/KittyGiraudel/a11y-dialog/releases )
- [Commits](https://github.com/KittyGiraudel/a11y-dialog/compare/7.5.0...7.5.2 )
---
updated-dependencies:
- dependency-name: a11y-dialog
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 11:59:51 +02:00
e348ca3ef6
Build(deps): Bump @babel/core in /app/assets/javascripts ( #18189 )
...
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core ) from 7.18.6 to 7.19.0.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.19.0/packages/babel-core )
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 11:59:28 +02:00
83b147aab2
Build(deps): Bump xss from 1.0.13 to 1.0.14 in /app/assets/javascripts ( #18191 )
...
Bumps [xss](https://github.com/leizongmin/js-xss ) from 1.0.13 to 1.0.14.
- [Release notes](https://github.com/leizongmin/js-xss/releases )
- [Changelog](https://github.com/leizongmin/js-xss/blob/master/CHANGELOG.md )
- [Commits](https://github.com/leizongmin/js-xss/compare/v1.0.13...v1.0.14 )
---
updated-dependencies:
- dependency-name: xss
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 11:58:16 +02:00
9112f91f57
Build(deps): Bump @popperjs/core in /app/assets/javascripts ( #18196 )
...
Bumps [@popperjs/core](https://github.com/popperjs/popper-core ) from 2.11.5 to 2.11.6.
- [Release notes](https://github.com/popperjs/popper-core/releases )
- [Commits](https://github.com/popperjs/popper-core/compare/v2.11.5...v2.11.6 )
---
updated-dependencies:
- dependency-name: "@popperjs/core"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 11:57:56 +02:00
c4892e70dd
Build(deps): Bump openssl from 3.0.0 to 3.0.1 ( #18200 )
...
Bumps [openssl](https://github.com/ruby/openssl ) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/ruby/openssl/releases )
- [Changelog](https://github.com/ruby/openssl/blob/master/History.md )
- [Commits](https://github.com/ruby/openssl/compare/v3.0.0...v3.0.1 )
---
updated-dependencies:
- dependency-name: openssl
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-09-11 11:57:17 +02:00
56832adf17
FIX: Ensure loading thumbnails are used in Safari ( #18204 )
...
In Safari, `img.complete` is sometimes true even before the image is loaded. Checking for the presence of `img.naturalHeight` seems to be more reliable. It is very difficult to write a test for this behaviour due to the dependence on network conditions, scroll location, etc.
`img.naturalHeight` is supported by all our target browsers, and I have verified the functionality of this commit in Chrome, Safari and Firefox.
2022-09-10 13:51:57 +02:00
415535d577
FIX: Ensure low-resolution placeholders are used while loading images ( #18194 )
2022-09-07 17:04:42 +02:00
c1887d95ff
FIX: "Exit setup" link should exit the wizard and take user to homepage ( #18182 )
2022-09-05 17:21:41 +05:30
7547878cde
FIX: Regression with admin user delete dialog buttons ( #18179 )
...
This also adds a test to prevent regressions and refactors the very similar delete dialog in the user summary screen.
2022-09-05 09:31:17 +02:00
f4e1d0c546
FIX: Ensure `<script>` handlebars templates are namespaced correctly ( #18178 )
...
This regressed in 7e74dd0afe
2022-09-04 13:01:10 +02:00
d262775c3e
DEV: make `bin/ember-cli -u` terminate unicorn when ember-cli fails ( #18172 )
2022-09-02 22:51:51 +01:00
54b8500881
FIX: raw translation string in user status tooltip ( #18170 )
2022-09-02 23:57:17 +04:00
801a284968
DEV: make ember-cli skip plugin directories without `plugin.rb` ( #18171 )
...
This updates the ember-cli plugin detection logic to match the logic in `Plugin::Instance.find_all`. It will now ignore plugin directories which do not have a `plugin.rb` file.
2022-09-02 19:48:45 +01:00
3501468db7
UX: make user status emoji on post stream smaller ( #18169 )
2022-09-02 21:48:36 +04:00
fd6109a6e1
FIX: Theme components should work with empty locale files ( #18167 )
...
Theme components didn't work with empty locale files (just the locale key without any translations) that are created by translator-bot.
2022-09-02 18:28:18 +02:00
73a2d2e9ac
UX: Fix width of preview pane to fix scroll ( #18166 )
2022-09-02 11:28:11 -05:00
661a903a0b
FEATURE: other notifications tab for redesign user menu ( #18164 )
...
This commit adds to the experimental user menu a new "other notifications" tab that's very similar to the "all notifications" tab, but with the main difference being that it doesn't show notification types that do have dedicated tabs in the menu (e.g. mentions, likes, replies etc.).
The rationale behind this is that the notification types that do have dedicated tabs tend to dominate the "all notifications" tab, leaving very small chances for the user to notice rarer or infrequent notification types. Adding a tab for all the other types gives the user a way to review those infrequent notification types.
Internal ticket: t72978.
Co-authored-by: OsamaSayegh <asooomaasoooma90@gmail.com>
2022-09-02 14:49:49 +03:00
bf6c9e0f28
DEV: Add tags to a topic fixture ( #18162 )
...
It can be useful to have a topic with some predefined tags
2022-09-02 13:48:31 +02:00
1279966f59
FIX: Use plugin's defined name for es6 module path ( #18159 )
...
We were using the directory name rather than the plugin's defined `name`. This was an unintended change in behaviour from the old sprockets implementation. This commit makes the ember-cli naming logic match the old sprockets logic.
2022-09-01 22:15:32 +01:00
a335492d20
FIX: Ensure discovery-categories always clears PreloadStore ( #18157 )
...
If the server is configured to use a view like `categories_and_latest_topics`, it will preload data for the topic list. If the client doesn't actually use it (e.g. on mobile), then that preloaded data would remain cached and be used for the next loaded topic list. This commit ensures it's always removed, and adds a test for the behaviour.
https://meta.discourse.org/t/237126/35
2022-09-01 16:11:13 +01:00
0f70eae7b0
FIX: Create single notification per post and user ( #18091 )
...
A user could receive more than a notification for the same post if they
watched both the categories and tags at different levels. This commit
makes sure that only the watching notification is created.
* Add DiscourseEvent before post notifications are created
2022-09-01 16:07:18 +03:00
a671fb4449
DEV: Add below-login-buttons plugin outlet ( #18154 )
2022-09-01 13:15:40 +01:00
c782125985
UX: Close the revamped user menu when opening modals ( #18148 )
...
When opening the DnD modal and the User Status modal, user menu remained open, this fixes it.
2022-09-01 15:22:41 +04:00
5bc858c676
FIX: do not show "create topics" notice on wizard route ( #18153 )
2022-09-01 16:37:57 +05:30
7e74dd0afe
DEV: Use DiscourseJsProcessor for theme template compilation ( #18135 )
...
Previously we were relying on a highly-customized version of the unmaintained Barber gem for theme template compilation. This commit switches us to use our own DiscourseJsProcessor, which makes use of more modern patterns and will be easier to maintain going forward.
In summary:
- Refactors DiscourseJsProcessor to move multiline JS heredocs into a companion `discourse-js-processor.js` file
- Use MiniRacer's `.call` method to avoid manually escaping JS strings
- Move Theme template AST transformers into DiscourseJsProcessor, and formalise interface for extending RawHandlebars AST transformations
- Update Ember template compilation to use a babel-based approach, just like Ember CLI. This gives each template its own ES6 module rather than directly assigning `Ember.TEMPLATES` values
- Improve testing of template compilation (and move some tests from `theme_javascript_compiler_spec.rb` to `discourse_js_processor_spec.rb`
2022-09-01 11:50:46 +01:00
19ed9dd183
FIX: Keep private theme key secret from user ( #18106 )
...
The generate RSA key and import theme routes worked separate from each
other. The RSA key returned both the public and private key and it was
the frontend which posted the private key back to the server. With this
commit, only the public key is necessary as the server keeps a map of
public and private keys that is used to get the private key back from
a public key.
2022-09-01 13:15:23 +03:00
5092c9804c
FIX: Return next bookmarks page only if it exists ( #18139 )
...
It used to return the next URL anyway which lead to an additional
request. On the frontend, if the result set was empty, it kept retrying
until at least one result was returned. This bug is fixed in this commit
too.
2022-09-01 13:04:00 +03:00
07aa324f61
DEV: Try to kickstart npm updates ( #18152 )
...
Dependabot hasn't picked up the previous config change. Let's see if it picks up this one.
2022-09-01 11:46:02 +02:00
15025ac958
UX: Show information about badge errors when saving
...
`popupAjaxError` is used by the controller to handle errors when saving the badge model. That only works properly when it gets the original exception from the ajax call. This manipulation of the error in the badge model was breaking that behavior.
The admin-badges controller is the only place which saves this model, so this shouldn't cause any issues elsewhere in the app.
2022-09-01 09:59:14 +01:00
240669da3a
FIX: Immediately show sql options when badge query is supplied
...
`buffered` and `model` are EmberObjects, so we need to call `get()` when accessing values to ensure they are autotracked
2022-09-01 09:59:14 +01:00
Kris
Jarek Radosz
Penar Musaraj
dependabot[bot]
Osama Sayegh
David Taylor
Arpit Jalan
Andrei Prigorshnev
Gerhard Schlager
Jordan Vidrine
Krzysztof Kotlarek
jbrw
Bianca Nenciu
Ghassan Maslamani