f60dc7f5b4
FIX: Broken specs
...
`/u/` is no longer in robots.txt, so don't test for it
2020-06-25 14:30:57 -04:00
b52143feff
FIX: Remove paths from robots.txt in favor of noindex header
...
Google no longer supports the use of robots.txt to block indexing.
See https://support.google.com/webmasters/answer/6062608 and
https://support.google.com/webmasters/answer/93710
Previous commits have added the `noindex` header to appropriate pages,
now we need to remove the paths from robots.txt so the pages can be
crawled.
Follow up to:
13f229808ab6765aac4b676be3a85307b728c5e5c94e6a9a66
2020-06-25 13:55:06 -04:00
01b6349a67
DEV: Add skip seed flag ( #10116 )
...
* add a flag to skip seed
* only seed when running post deployment migrations
2020-06-25 10:14:58 -06:00
855d423791
Build(deps-dev): Bump mock_redis from 0.24.0 to 0.25.0 ( #10123 )
...
Bumps [mock_redis](https://github.com/sds/mock_redis ) from 0.24.0 to 0.25.0.
- [Release notes](https://github.com/sds/mock_redis/releases )
- [Changelog](https://github.com/sds/mock_redis/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sds/mock_redis/compare/v0.24.0...v0.25.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-25 10:28:20 -04:00
3c31884b79
FIX: match discobot triggers on cooked version
...
In French, the help trigger has a raw content of "afficher l'aider" which is then cooked into "afficher l’aide" (note the different quote character).
Since we were checking the raw content of the trigger against the cooked version of the post, this trigger never worked in French.
This changes so that we cook the trigger before checking in against the cooked version of the post.
DEV: new 'discobot_username' method that is used everywhere instead of 'discobot_user.username' / 'discobot_user.username_lower'
2020-06-25 13:29:55 +02:00
689568c216
FIX: invalid urls should not break store.has_been_uploaded?
...
Breaking this method has wide ramification including breaking
search indexing.
2020-06-25 15:00:15 +10:00
88459e08c9
FEATURE: allow disabling of extra term injection in search
...
There is a feature in search where we take over from the tokenizer
in postgres and attempt to inject more words into search.
So for example: sam.i.am will inject the words i and am.
This is not ideal cause there are many edge cases and this can
cause extreme index bloat.
This is an opening move commit to make it configurable, over the
next few weeks we will evaluate and decide if we disable this by
default or simply remove.
2020-06-25 13:36:52 +10:00
3cb41d5429
PERF: stop adding more topics to search when not needed
...
The logic of adding additional search results does not seem to be
needed anymore.
It appears to be a relic of an old implementation.
This saves an entire search query for every search made.
2020-06-25 12:31:12 +10:00
42a6c8a85f
DEV: Rescue from ActiveRecord::Readonly error in lograge.
2020-06-25 10:25:28 +08:00
9c7d3b2dc0
FIX: Avoid marking notifications as seen in readonly mode.
2020-06-25 10:14:07 +08:00
b9174c8e8a
Version bump to v2.6.0.beta1
2020-06-24 14:00:19 -04:00
8e07ee7e36
Update translations
...
Carefully because permalink.external_url is untranslated in many
locales due to a recent change in client.en.yml in 516a03be09
2020-06-24 10:47:45 -04:00
7109d94ee7
FIX: properly invalidate inline oneboxes when rebaking
...
When rebaking a post we were invalidating _regular_ oneboxes but not inline oneboxes.
DEV: also renamed 'InlineOneboxer.purge' to 'InlineOneboxer.invalidate' to keep
the API consistent with 'Oneboxer.invalidate'
2020-06-24 11:54:54 +02:00
df1f804400
FIX: ensures moderation history is accessible from topic/post admin menu ( #10118 )
2020-06-24 10:49:47 +02:00
75151f0457
FIX: Use correct URL for unsubscribe ( #10077 )
2020-06-24 09:31:20 +02:00
9ffc022cf4
DEV: improve verbose mode for reindexer
...
This makes the verbose mode provide a bit of progress notification
while reindexing as it can take many hours to do a giant site
2020-06-24 17:29:45 +10:00
2987901043
FIX: skip category notification_level unless scoped
...
#b19dcac2 improved the serializer so it sends default notification
levels to users to work around cases where a category edit would
would result in clients being left with invalid notification state
Unfortunately this did not address the root issue.
When we edit categories we publish state to multiple users this
means that the serializer is executed unscoped with no user.
The client already handles this case per:
dcad720a4c/app/assets/javascripts/discourse/app/models/site.js (L119-L119)
2020-06-24 17:08:12 +10:00
0e2f7ecfd0
DEV: Make component-test `afterEach` async aware ( #10099 )
...
Before this fix, if a test case was async, `afterEach` callback would be executed immediately, without waiting for the test to finish. 😬
2020-06-24 16:03:38 +10:00
843bf0df75
FIX:Add migration to delete tracking state for staged users ( #10083 )
2020-06-24 15:58:14 +10:00
52278ce6fd
FIX: Use Discourse.system_user when we need a placeholder admin ( #9781 )
2020-06-24 15:51:30 +10:00
713298c622
FIX: advanced tutorial errors when all categories are secured ( #10111 )
...
The category hashtag step will fail with an error when all
categories aren't public. Choose a category that the user can see.
2020-06-24 15:45:50 +10:00
42226e12ee
FEATURE: Add after-user-name plugin outlet ( #10113 )
2020-06-24 15:45:11 +10:00
dcad720a4c
DEV: add optional verbose logging to re-index job
...
This verbose logging can be useful when executing the job by hand
for debugging purposes
In general people will not use this
2020-06-24 15:37:08 +10:00
b28d97b64a
FIX: Bump onebox for twitch video and clips embedding fix.
2020-06-24 11:00:30 +08:00
e0cd7ddada
Build(deps): Bump excon from 0.74.0 to 0.75.0
...
Bumps [excon](https://github.com/excon/excon ) from 0.74.0 to 0.75.0.
- [Release notes](https://github.com/excon/excon/releases )
- [Changelog](https://github.com/excon/excon/blob/master/changelog.txt )
- [Commits](https://github.com/excon/excon/compare/v0.74.0...v0.75.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-24 09:35:51 +08:00
f6ad0d3fac
Build(deps): Bump diff-lcs from 1.4 to 1.4.1
...
Bumps [diff-lcs](https://github.com/halostatue/diff-lcs ) from 1.4 to 1.4.1.
- [Release notes](https://github.com/halostatue/diff-lcs/releases )
- [Changelog](https://github.com/halostatue/diff-lcs/blob/master/History.md )
- [Commits](https://github.com/halostatue/diff-lcs/compare/v1.4...v1.4.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-24 09:35:12 +08:00
13087cab54
FIX: Prevent typing "#" when showing "Jump to…"
...
Closes https://meta.discourse.org/t/the-shortcut-behaves-wrong-in-some-browsers/155531
2020-06-24 00:25:54 +02:00
4c543b4a49
UX: Make youtube embeds full width by default ( #10106 )
...
* UX: Make youtube embeds full width by default
* UX: Make youtube embeds fluid by default actually
* Remove double sizes in yt-lazy
2020-06-23 17:21:36 -03:00
4a189f396e
Build(deps): Bump diff-lcs from 1.3 to 1.4 ( #10112 )
...
Bumps [diff-lcs](https://github.com/halostatue/diff-lcs ) from 1.3 to 1.4.
- [Release notes](https://github.com/halostatue/diff-lcs/releases )
- [Changelog](https://github.com/halostatue/diff-lcs/blob/master/History.md )
- [Commits](https://github.com/halostatue/diff-lcs/compare/v1.3...v1.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-23 12:46:46 -04:00
91c89df68a
FIX: onebox local topic when using slug-less URL
...
When linking to a topic in the same Discourse, we try to onebox the link to show the title
and other various information depending on whether it's a "standard" or "inline" onebox.
However, we were not properly detecting links to topics that had no slugs (eg. https://meta.discourse.org/t/1234 ).
2020-06-23 17:18:38 +02:00
50ea3c8743
Build(deps): Bump rails_failover from 0.5.1 to 0.5.2 ( #10107 )
...
Bumps rails_failover from 0.5.1 to 0.5.2.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-23 10:45:15 -04:00
c5078e5dc1
DEV: Remove accidentally committed `puts` statements
2020-06-23 12:41:47 +01:00
368af327fa
DEV: Reduce size of begin-rescue region
...
Follow-up-to: e3e7905d9e
2020-06-23 10:14:09 +01:00
84c12d8f3d
DEV: Allow multisite apps to boot with readonly db.
2020-06-23 16:34:25 +08:00
27b2e335ef
DEV: Retry on distributed mutex timeout error when starting sidekiq.
...
We need Sidekiq to start `mini_scheduler` no matter what. Timeouts
happen when trying to boot an app with Redis in readonly mode.
2020-06-23 15:43:28 +08:00
e92909aa77
FIX: Use ActionDispatch::Http::ContentDisposition for uploads content-disposition ( #10108 )
...
See https://meta.discourse.org/t/broken-pipe-error-when-uploading-to-a-s3-clone-a-pdf-with-a-name-containing-e-i-etc/155414
When setting content-disposition for attachment, use the ContentDisposition class to format it. This handles filenames with weird characters and localization (accented characters) correctly.
2020-06-23 17:10:56 +10:00
97f045d06a
DOCS: remove thin from copyright
...
it is no longer used
2020-06-23 15:43:58 +10:00
1157d2a0ff
DEV: Print proper summary when errors have been reporter in turbo_rspec
2020-06-23 13:34:58 +08:00
add2a9411e
DEV: Remove specs that are no longer relevant.
2020-06-23 12:09:04 +08:00
e3e7905d9e
FIX: `TurboTests::Runner` not failing on errors.
2020-06-23 11:45:18 +08:00
97d12a3a8e
Bump rails_failover to 0.5.2.
2020-06-23 10:07:30 +08:00
d775338d63
FIX: Use a mutex when reseting column information while seeding.
...
`rake multisite:migrate` runs SeedFu concurently in threads so we need
this to be thread safe.
2020-06-23 09:15:47 +08:00
0384b6d910
FIX: `multisite:migrate` failing to properly seed data.
2020-06-23 09:10:02 +08:00
25db91e351
Revert "FIX: These tests are broken"
...
This reverts commit b1114b9a20
2020-06-23 08:41:10 +08:00
b1114b9a20
FIX: These tests are broken
2020-06-22 16:30:46 -04:00
ac9577bcc7
FIX: Don't raise an exception if we can't update the user on demotion
...
This is causing issues when purging old users, if they are set up in the
exact condition where they will be demoted into another group, but also
do not have a primary email.
2020-06-22 15:43:59 -04:00
d473ddd02c
FIX: Use raw content when checking for watched words to flag ( #10104 )
...
This makes flagged watched words match the behavior of censor, requires_approval and blocked watched words.
2020-06-22 19:48:06 +01:00
1617905e03
Build(deps): Bump rubocop from 0.85.1 to 0.86.0 ( #10103 )
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.85.1 to 0.86.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.85.1...v0.86.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-22 12:43:39 -04:00
2ffb6ebd47
Build(deps): Bump parser from 2.7.1.3 to 2.7.1.4 ( #10096 )
...
Bumps [parser](https://github.com/whitequark/parser ) from 2.7.1.3 to 2.7.1.4.
- [Release notes](https://github.com/whitequark/parser/releases )
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md )
- [Commits](https://github.com/whitequark/parser/compare/v2.7.1.3...v2.7.1.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-06-22 12:39:59 -04:00
2e1efbde52
FIX: Pass local scope variable to inner function
2020-06-22 19:23:59 +03:00
Joshua Rosenfeld
Blake Erickson
dependabot-preview[bot]
Régis Hanol
Sam Saffron
Guo Xiang Tan
Neil Lalonde
Joffrey JAFFEUX
Bianca Nenciu
Jarek Radosz
Kane York
Rafael dos Santos Silva
David Taylor
Daniel Waterworth
Martin Brennan
Robin Ward
Dan Ungureanu