Guo Xiang Tan
cb1f909fa4
FIX: Migrate old null override for upload site settings.
...
For some reason, setting a text site setting to empty in the past can
result in either an empty string or null as the value. This migration
is a follow up to 1981add261
.
2019-03-15 13:59:29 +08:00
Tim Lange
37c613dde2
FIX: Outsourced erb part from emoji.js.es6 ( #7168 )
2019-03-15 15:44:49 +11:00
Vinoth Kannan
bec3956f7f
FIX: Topic filters persist when navigating to home page ( #7175 )
...
* FIX: Topic filters persist when navigating to home page
* remove the line which no longer needed
2019-03-15 09:45:17 +05:30
Guo Xiang Tan
1981add261
FIX: Migrate old blank override for upload site settings.
...
If the depercated SiteSetting.logo_url was set to "" previously, it will
not have been migrated by the onceoff job which we added. As such, we
need a migration to migrate the blank override so that the default for
certain upload site settings will not be used.
2019-03-15 11:03:58 +08:00
Sam
819d4facda
FIX: ruby bench script no longer working
...
The library used to generate random text changed, this caused the title
of the topic used for testing to change, which meant the slug changed, so
a hit to the topic was a redirect
This fix gives the topic used for performance testing a static name to avoid
this issue in future
2019-03-15 11:31:08 +11:00
Tarek Khalil
08f626d351
REFACTOR: copy change for ignore users moderator message ( #7174 )
2019-03-15 00:02:15 +00:00
Tarek Khalil
bd6d31c9ec
FEATURE: Add `IgnoredUsersSummary` daily job ( #7144 )
...
* FEATURE: Add `IgnoredUsersSummary` daily job
## Why?
This is part of the [Ability to ignore a user feature](https://meta.discourse.org/t/ability-to-ignore-a-user/110254/8 ).
We want to:
1. Send an automatic group PM that goes out to moderators
2. When {x} users have Ignored the same user, threshold defined by a site setting, default of 5
3. Only send this message every X days which is defined by another site setting
2019-03-14 22:51:43 +00:00
Rafael dos Santos Silva
fb8bcd7469
FEATURE: Enable experimental Badging API ( #7173 )
2019-03-14 18:16:16 -03:00
Arpit Jalan
d6d71de855
FIX: allow banner topic posts to be moved to regular topic (and vice versa)
2019-03-14 23:41:23 +05:30
Robin Ward
1b65469b64
FIX: Backwards compatibility for `SiteSetting.queue_jobs`
...
Some plugin specs use this. Let's deprecate it instead.
2019-03-14 11:39:10 -04:00
Robin Ward
fa5a158683
REFACTOR: Move `queue_jobs` out of `SiteSetting`
...
It is not a setting, and only relevant in specs. The new API is:
```
Jobs.run_later! # jobs will be thrown on the queue
Jobs.run_immediately! # jobs will run right away, avoid the queue
```
2019-03-14 10:47:38 -04:00
Gerhard Schlager
f3c76ad482
FIX: Failed to detect existing category permalink
2019-03-14 13:42:05 +01:00
Gerhard Schlager
c34a6ba674
REFACTOR: Rename site settings to make them less confusing
2019-03-14 13:40:14 +01:00
Tarek Khalil
6f6dea87f3
FIX: optimise querying Post's serializer ignored attribute ( #7169 )
2019-03-14 12:10:53 +00:00
David Taylor
fc0cf3ecd1
FEATURE: Fetch email from auth provider if current user email is invalid ( #7163 )
...
If the existing email address for a user ends in `.invalid`, we should take the email address from an authentication payload, and replace the invalid address. This typically happens when we import users from a system without email addresses.
This commit also adds some extensibility so that plugin authenticators can define `always_update_user_email?`
2019-03-14 11:33:30 +00:00
Guo Xiang Tan
b9ab393d70
Fix favicon not updating on the client side when changed.
...
Regression from 1c6a2262b3
.
Documented the rational for include the url since we can't really test
this properly.
2019-03-14 15:37:43 +08:00
Guo Xiang Tan
40b03e717b
FIX: `Upload#migrate_to_new_scheme` should not migrate system uploads.
2019-03-14 12:45:03 +08:00
Guo Xiang Tan
1bc96177dd
DEV: Improve specs for validating a unique post.
...
Follow up to d2a7f29595
which caused post
edits to fail.
2019-03-14 10:39:51 +08:00
Guo Xiang Tan
d2a7f29595
Revert "REFACTOR: remove unnecessary parentheses attempt 2 (follow-up on 154f503d
)"
...
This reverts commit 7db2dc717e
.
Commit breaks post edits for regular users.
2019-03-14 08:15:40 +08:00
Guo Xiang Tan
1c6a2262b3
FIX: `StaticController#favicon` reads from disk when using local store. ( #7160 )
...
Since uploads site settings are now backed by an actual upload, we don't
have to reach over the network just to fetch the favicon. Instead, we
can just read the upload directly from disk.
2019-03-14 04:17:36 +08:00
Roman Rizzi
4f74210949
Version bump to v2.3.0.beta5
2019-03-13 16:47:23 -03:00
Neil Lalonde
7db2dc717e
REFACTOR: remove unnecessary parentheses attempt 2 (follow-up on 154f503d
)
2019-03-13 15:33:46 -04:00
Dan Ungureanu
81bf4df1a5
DEV: Fix lint.
2019-03-13 21:32:28 +02:00
Roman Rizzi
bd8e46a9c1
SECURITY: Upgrading Rails version to 5.2.2.1
2019-03-13 16:24:54 -03:00
Dan Ungureanu
18ff790e79
FIX: Use prioritize_username_in_ux in post notices.
2019-03-13 21:17:41 +02:00
Roman Rizzi
77931b70c3
Revert "DEV: Upgrade to Ember 3.7.0 ( #6977 )" ( #7165 )
...
This reverts commit 3eebf8be73
.
2019-03-13 15:49:47 -03:00
Kris
4178578e09
UX: Adhere to Facebook & Twitter brand guidelines for share icon colors
2019-03-13 13:42:11 -04:00
Maja Komel
65f3ed0689
UX: make name optional for confirmation user field ( #7149 )
2019-03-13 18:40:43 +01:00
Maja Komel
12c37ada2e
UX: focus on search box when emoji picker is opened ( #7098 )
2019-03-13 17:48:40 +01:00
David Taylor
420c6f8102
FEATURE: Skip sending emails to domains on the `.invalid` TLD ( #7162 )
...
This is a reserved TLD which we use when importing users without an email address. https://tools.ietf.org/html/rfc2606
2019-03-13 16:17:59 +00:00
Joffrey JAFFEUX
9a5f08ee61
DEV: skip discourse-chat-integration tests ( #7164 )
...
Suspected of causing timeout issues in our test suite with Ember 3.7
2019-03-13 16:50:56 +01:00
Dan Ungureanu
91bd0becaa
DEV: Allow topics to register default topic order criteria. ( #7158 )
2019-03-13 16:44:08 +01:00
Vinoth Kannan
c773f82ba1
DEV: Added qunit test functions and did minor refactoring
...
135191d1d1
2019-03-13 18:38:27 +05:30
Joffrey JAFFEUX
d32557ea32
Revert "FIX: Better emoji escaping for topic title"
...
This reverts commit 35426b5ad6
.
2019-03-13 13:02:56 +01:00
Maja Komel
3eebf8be73
DEV: Upgrade to Ember 3.7.0 ( #6977 )
...
* Upgrade to Ember 3.7.0
* use ember source 3.7.0.2
* fix mobile header
* fix navigation
2019-03-13 12:16:06 +01:00
Vinoth Kannan
d4d67386c9
FIX: change to correct bundled version
2019-03-13 16:43:45 +05:30
Vinoth Kannan
1b454c73ae
FIX: 'topic' can have null value
2019-03-13 16:34:47 +05:30
Bianca Nenciu
76a14c47ac
FEATURE: Add site contact group. ( #7152 )
2019-03-13 11:34:47 +01:00
Tim Lange
35426b5ad6
FIX: Better emoji escaping for topic title
...
This commit also puts emojiVersion in its own erb file.
2019-03-13 11:17:59 +01:00
Vinoth Kannan
135191d1d1
DEV: Option to add extra topic status icons in its widget and component
...
and did some refactoring
2019-03-13 15:17:26 +05:30
Guo Xiang Tan
243fb8d9ad
Fix the build.
2019-03-13 17:39:07 +08:00
Guo Xiang Tan
b0c8fdd7da
FIX: Properly support defaults for upload site settings.
2019-03-13 16:36:57 +08:00
Guo Xiang Tan
684eef71c7
REFACTOR: Better variable name.
2019-03-13 15:23:01 +08:00
Erick Guan
bd2edbb243
FIX: a temporary fix when CJK user tries to add a long title ( #7045 )
...
Discourse doesn't analyze the sentence components. So it counts the whole sentence as a word for CJK.
https://meta.discoursecn.org/t/topic/3033
2019-03-13 17:22:46 +11:00
Tim Lange
d1c4981f65
UX: Added tooltips to topic admin menu ( #7146 )
...
* UX: Added tooltips to topic admin menu
* FIX: Prettyfied code
* FIX: Fixed typo
* Update config/locales/client.en.yml
Co-Authored-By: venarius <tim.lange@online.de>
2019-03-13 17:11:36 +11:00
Joffrey JAFFEUX
edc6d87862
FIX: invite-panels regressions on private topics ( #7157 )
2019-03-13 16:34:23 +11:00
Blake Erickson
7ac394f51f
FIX: prevent mixed api auth headers & query params
...
When using the api and you provide an http header based api key any other
auth based information (username, external_id, or user_id) passed in as
query params will not be used and vice versa.
Followup to f03b293e6a
2019-03-12 17:33:21 -06:00
Dan Ungureanu
476d0050ab
FIX: Disable notices for posts by anonymous.
2019-03-13 00:20:19 +02:00
Dan Ungureanu
7310ee3ef1
FEATURE: Add more control over post notices. ( #7148 )
2019-03-13 08:06:28 +11:00
Neil Lalonde
e9ba4c74f7
Revert "REFACTOR: remove unnecessary parentheses"
...
Specs fail
2019-03-12 15:00:58 -04:00