Régis Hanol
b5c8f5f900
SPEC: ensure never remap readonly columns
...
Follow-up to bfcbfd78
2019-05-09 18:01:35 +02:00
Guo Xiang Tan
4e91839c97
FIX: Remove default val for colors step if a default theme has been set.
...
Running through the wizard after a default theme has been configured
will always revert the default theme to the light theme.
2019-05-09 17:25:09 +08:00
Guo Xiang Tan
d110f252bb
DEV: Remove unsued option from spec.
2019-05-09 17:25:09 +08:00
Guo Xiang Tan
867c1a5ac9
DEV: Add request spec for creating an uncategorized category.
2019-05-09 14:53:13 +08:00
Guo Xiang Tan
535c594891
Revert "FIX: Return error if new topic category not found"
...
This reverts commit 9c606dd99a
.
2019-05-09 14:53:13 +08:00
Sam Saffron
88650a1259
PERF: avoid checking for consecutive replies in test
...
This check can issue up to 2 queries per post created, we have specific
tests for it so we can avoid.
This also rolls back #4da6ca4d
2019-05-09 13:28:53 +10:00
Daniel Waterworth
4da6ca4d9f
PERF: Skip post validation by default when fabricating posts ( #7508 )
...
This speeds up tests by 10%
2019-05-09 10:15:38 +10:00
Vinoth Kannan
87cd4701b8
FEATURE: option to skip posts with ignored missing uploads
2019-05-09 05:11:15 +05:30
Blake Erickson
9c606dd99a
FIX: Return error if new topic category not found
...
If creating a topic via the api as an admin and the category you specify
cannot be found an error will now be returned instead of just creating
the topic with no category. This will prevent accidental public topic
creation originally intended for a private category.
2019-05-08 15:02:00 -06:00
David Taylor
e84531a6a6
FIX: Correctly clear theme stylesheet cache when changing color scheme
2019-05-08 16:02:55 +01:00
Penar Musaraj
a4eb523af6
Track Discourse user agent pageviews as crawler
...
Since 5bfe051e
, Discourse user agents are marked as non-crawlers (to avoid accidental blacklisting). This makes sure pageviews for these agents are tracked as crawler hits.
2019-05-08 10:38:55 -04:00
Penar Musaraj
8f2c442435
Fix tests
2019-05-08 09:58:47 -04:00
Daniel Waterworth
ebc5888c95
Prefabricated trust_level_4
2019-05-08 08:57:07 -04:00
Daniel Waterworth
1d0565eca2
Prefabricated admin at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
cef14d81ac
Prefabricated moderator at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
a473a56dc2
Prefabricated user at the top level
2019-05-08 08:57:07 -04:00
Daniel Waterworth
73f25311fa
Prefabricated post by user
2019-05-08 08:54:37 -04:00
Daniel Waterworth
0578809460
Prefabricate trust_level_4
2019-05-08 08:54:37 -04:00
Daniel Waterworth
f984c1740f
Use prefabricated user
2019-05-08 08:54:37 -04:00
Daniel Waterworth
86372a94d5
Prefabricated moderator at the top level
2019-05-08 08:54:37 -04:00
Daniel Waterworth
e3c09c666b
Prefabricated admin
2019-05-08 08:54:37 -04:00
Guo Xiang Tan
f530048973
Fix broken spec in 405ba00
take 2.
2019-05-08 16:07:14 +08:00
Guo Xiang Tan
ba6904bb27
Fix broken spec in 405ba00c08
.
2019-05-08 15:45:25 +08:00
Guo Xiang Tan
405ba00c08
FEATURE: Create notifications on wiki edits for watching users.
...
* Moves creation of notification into background job.
2019-05-08 15:31:10 +08:00
Sam Saffron
77f9fff41e
DEV: correct flaky test
...
Hardcoding the number 1 into a test means that the test may fail if topic_id
1 is somehow seeded
This ensures we are always talking about a topic that does not exist
2019-05-08 09:31:47 +10:00
Robin Ward
5af7c90bab
FEATURE: Hide Reviewable scores, change score filter to Priority
...
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.
You can now filter by minimum priority (low, med, high) instead of
score.
2019-05-07 14:05:23 -04:00
Blake Erickson
5b5b5a5931
FIX: return an error if a user tries to whisper
...
This commit fixes a bug where a user creates a whisper post via the api
but is posted as a regular message because they don't have access to
whisper. Now a 403 unauthorized will be returned instead of the whisper
param just being ignored for regular users. Staff users should not be
affected by this change.
https://meta.discourse.org/t/a-whisper-is-posted-as-a-message-if-the-user-is-not-staff-moderator-admin-when-using-the-api/116601
2019-05-07 11:42:26 -06:00
Joffrey JAFFEUX
1f40258d5c
fix spec ( #7500 )
2019-05-07 19:20:56 +02:00
Daniel Waterworth
c7a0baebc5
DEV: Prefabricate more things in topic_spec.rb ( #7490 )
...
* Moved let to more appropriate scopes
* Refactored tests
It's confusing when let blocks in a parent context depend on other let
blocks from a child context.
* Moved fabrication to top level
* Removed unnecessary user fabrications
* Added a trust level 2 user at the top level
* Factored out category
* Made test use generic user
* Prefabricate topic
* Cut down redundant users
* Prefabricated more things
2019-05-07 17:05:52 +02:00
Bianca Nenciu
98a75906c8
FIX: Close topics deleted by users and ensure topic stubs are destroyed. ( #7430 )
2019-05-07 16:25:52 +03:00
Natalia
1b7be1500f
Time variable used to be created with users timezone, it has to be UTC in order to pass the test
2019-05-07 08:43:38 -04:00
Daniel Waterworth
32e0c4997c
Prefabricated posts
2019-05-07 08:39:45 -04:00
Daniel Waterworth
d3a59a43a1
Prefabricated anonymous
2019-05-07 08:39:45 -04:00
Daniel Waterworth
033d584275
Prefabricated topic
2019-05-07 08:39:45 -04:00
Daniel Waterworth
3e2f7d800a
Replaced create_topic with Fabricate(:topic)
2019-05-07 08:39:45 -04:00
Daniel Waterworth
e79421abb7
Prefabricated users
2019-05-07 08:39:45 -04:00
Daniel Waterworth
c9dedd7d72
Removed unnecessary fab!
2019-05-07 08:38:55 -04:00
Daniel Waterworth
da31661b80
Prefabricate category
2019-05-07 08:38:55 -04:00
Daniel Waterworth
cdf17986aa
Removed unnecessary let
2019-05-07 08:38:55 -04:00
Daniel Waterworth
b95a5330b7
Moved automatic_group fabrication to top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
5af63def61
Prefabricate group at the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
df63080bca
Prefabricate staff_post at the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
db64bee0c4
Use prefabricated user
2019-05-07 08:38:55 -04:00
Daniel Waterworth
30676e8a56
Brought prefabrication of another_user to the top level
2019-05-07 08:38:55 -04:00
Daniel Waterworth
2c7ed7b848
Use prefabricated admin instead of creating new ones
2019-05-07 08:38:55 -04:00
Daniel Waterworth
2f706be43a
Reuse prefabricated moderator instead of creating new ones
2019-05-07 08:38:55 -04:00
Daniel Waterworth
16c7b86c86
Use prefabricated user and moderator
2019-05-07 08:38:55 -04:00
Daniel Waterworth
7472f15368
Prefabricate evil_trout
2019-05-07 08:36:29 -04:00
Daniel Waterworth
d3769fff95
Prefabricate admin
2019-05-07 08:36:29 -04:00
Daniel Waterworth
d0c7e3469d
Prefabricated more things
2019-05-07 08:36:29 -04:00