Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
38,673 Commits 205 Branches 500 Tags 851 MiB
Commit Graph

38673 Commits

Author SHA1 Message Date
Robin Ward 8456252c21 Add deprecation for `Discourse.SiteSettings` in a helper 2020-07-24 09:45:55 -04:00
Robin Ward c4d5c0c91b REFACTOR: Remove `Discourse.SiteSettings` from utilities 
This involves a little refactoring of how our `defaultHomepage()` works.
It previously would check the meta tag / site settings each time it was
called but now it only checks once on application boot.
 2020-07-24 09:45:55 -04:00
Robin Ward 4def5a8339 Remove old redirect rules 2020-07-24 09:45:55 -04:00
Robin Ward 06a3fd0566 This initializer is not used anymore 2020-07-24 09:45:55 -04:00
Robin Ward bad083b3a3 REFACTOR: Remove `Discourse.SiteSettings` from clipboardData 
Also rename method to `clipboardHelpers` to make searching easier since
`clipboardData` refers to browser functionality.
 2020-07-24 09:45:55 -04:00
Robin Ward 0213211068 REFACTOR: Remove `Discourse.SiteSettings` from text helpers 2020-07-24 09:45:55 -04:00
Robin Ward 98fee7aa50 REFACTOR: Remove `Discourse.SiteSettings` from highlightSyntax 2020-07-24 09:45:55 -04:00
Robin Ward 656abe22c7 REFACTOR: Remove `Discourse.SiteSettings` from more lib-like helpers 2020-07-24 09:45:55 -04:00
dependabot-preview[bot] 3d7c81149e Build(deps-dev): Bump parallel_tests from 3.0.0 to 3.1.0 
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Changelog](https://github.com/grosser/parallel_tests/blob/master/CHANGELOG.md)
- [Commits](https://github.com/grosser/parallel_tests/compare/v3.0.0...v3.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-07-24 09:32:39 -04:00
Guo Xiang Tan 244ab48b79
DEV: Improve docs for Sidekiq job assertion helpers. 2020-07-24 17:37:22 +08:00
Guo Xiang Tan c6202af005
Update rubocop to 2.3.1. 2020-07-24 17:19:21 +08:00
Martin Brennan a9905ef7e5
FIX: Add enable_email_sync_demon global variable and disable EmailSync demon by default (#10304) 
Demon::EmailSync is used in conjunction with the SiteSetting.enable_imap to sync N IMAP mailboxes with specific groups. It is a process started in unicorn.conf, and it spawns N threads (one for each multisite connection) and for each database spans another N threads (one for each configured group).

We want this off by default so the process is not started when it does not need to be (e.g. development, test, certain hosting tiers)
 2020-07-24 17:09:29 +10:00
Guo Xiang Tan 1b57276673
Revert "Bump rubocop-discourse to 2.3.0." 
This reverts commit a3ed7c9279.
 2020-07-24 13:18:49 +08:00
Guo Xiang Tan a3ed7c9279
Bump rubocop-discourse to 2.3.0. 2020-07-24 12:49:27 +08:00
Martin Brennan 0e78cd6e3a
FIX: Add strip_secure_urls method to GroupSmtpMailer 
* this mailer needs some more cleanup and specs;
  this commit just adds the missing method so the
  mailer does not error completely in secure media
  environments
 2020-07-24 13:55:07 +10:00
Guo Xiang Tan 80f33b5aaf
DEV: Fix incorrect description in spec. 2020-07-24 10:54:41 +08:00
Guo Xiang Tan 56107dbc3e
DEV: Fix false positive tests. 2020-07-24 10:54:41 +08:00
Guo Xiang Tan 181c4eb760 PERF: Avoid parsing `Post#cooked` with Nokogiri for every search. 2020-07-24 10:43:09 +08:00
Guo Xiang Tan b979579c1b
DEV: Refactor draft attributes for `CategoryList` and `TopicList`. 
Avoid repeating the same logic in a bunch of places which will allow us
to make changes to the draft attributes easier in the future.
 2020-07-24 10:11:30 +08:00
Martin Brennan 1dd3af20c6
FIX: Do not show Email tab for group settings unless IMAP + SMTP enabled (#10301) 
Also hide all the SMTP/IMAP related settings to avoid confusion, as this feature is still not 100% ready to go.
 2020-07-24 12:00:36 +10:00
Guo Xiang Tan b1cc7825c5
DEV: Remove unused fabrication. 2020-07-24 09:54:34 +08:00
Guo Xiang Tan 0cbf86f1e7
DEV: Refactor reindex_search_spec. 
Follow-up 20dc845418
 2020-07-24 09:29:54 +08:00
Mark VanLandingham 20dc845418
FIX: tests for reindex_search_spec pass regardless of seed (#10297) 2020-07-23 13:51:45 -05:00
jbrw 2aec92d0b4
FEATURE - allow Group Moderators to edit category description (#10292) 
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
 2020-07-23 09:50:00 -04:00
David Taylor 61d3640643
DEV: Improve HTML structure for group-reports-nav-item outlet 2020-07-23 12:44:11 +01:00
Guo Xiang Tan 3766122a82
DEV: Allow developmental post search index versions. 2020-07-23 15:19:46 +08:00
Sam Saffron fe71c43c57
DEV: upgrade mini_racer and libv8 
This pushes v8 from Chrome 73 (March 2019) -> 84 (July 14 2020)

Not expecting any user facing changes, but it is super nice to be on latest
v8 :confetti:
 2020-07-23 16:26:53 +10:00
Guo Xiang Tan 609ba50fe8
DEV: Add more granularity to `SearchIndexer` versions. 
Sometimes, we just want to reindex a specific model and not all the
things.
 2020-07-23 14:24:06 +08:00
Krzysztof Kotlarek 4b053462c0
FIX: display correct status on unsubscribe page (#10294) 
There was a bug that even when `email_digest` was set to false but
`digest_after_minutes` was positive, we were not displaying correct
status.

In addition, the message is improved when the user is unsubscribed +
unsubscribe from all is hidden.
 2020-07-23 16:20:10 +10:00
Martin Brennan e027acd367
FIX: Move consts and translations for bookmark auto delete prefs (#10295) 2020-07-23 13:12:28 +10:00
Penar Musaraj 7559758e10
FEATURE: Support converting HEIF images to JPEG (#10079) 2020-07-22 21:40:09 -04:00
Guo Xiang Tan 10a6824e5f
Revert "PERF: Reduce size of search payload by removing unused topic attributes." 
This reverts commit 84de643c04.

Users are using the search endpoint as public API even though it is
meant to be internal. Revert for now while we figure out the path
forward on providing a more stable API to end users.
 2020-07-23 09:25:31 +08:00
Sam Saffron 88dcdf776b
FEATURE: add tracked filter to topic lists 
This adds a special filter to topic lists that will filter to tracked and
watched categories.

To use it you can visit:

`https://sitename/?filter=tracked`
`https://sitename/unread?filter=tracked`

and so on

Note, we do not include explicitly tracked and watched topics **outside** of
the tracked categories and tags.

We can consider a `filter=all_tracked` to cover this edge case.
 2020-07-23 10:30:23 +10:00
dependabot-preview[bot] 21d7b55ec6 Build(deps): Bump bootsnap from 1.4.6 to 1.4.7 
Bumps [bootsnap](https://github.com/Shopify/bootsnap) from 1.4.6 to 1.4.7.
- [Release notes](https://github.com/Shopify/bootsnap/releases)
- [Changelog](https://github.com/Shopify/bootsnap/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Shopify/bootsnap/compare/v1.4.6...v1.4.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-07-22 17:12:36 -04:00
Blake Erickson 395d17e2ac DEV: Show failed to remove members from bulk groups api 
Before this commit if you were bulk removing group members and passed in
a user who wasn't currently a member of that group the whole request
would fail. This change will return a 200 response now listing the users
that were removed and those that were skipped.
 2020-07-22 14:32:31 -06:00
Penar Musaraj 1100b3d185
UX: fix spacing of composer preview on mobile 
Followup to 723d7e3a
 2020-07-22 14:36:05 -04:00
Robin Ward c1bcb78441 REFACTOR: Allow helpers to access site settings 
Since `Discourse.SiteSettings` is removed, helpers can now include and
call `helperContext().siteSettings` to get access to the settings
without using a global variable.
 2020-07-22 14:14:38 -04:00
Robin Ward 939fae3500 REFACTOR: Remove `Discourse.SiteSettimgs` from @setting decorator 2020-07-22 13:27:57 -04:00
Robin Ward 4ecb4439b9 REFACTOR: Remove `Discourse.SiteSettings` from lightbox.js 2020-07-22 13:27:57 -04:00
Robin Ward 94419d0176 REFACTOR: Remove `Discourse.SiteSettings` from static route builder 2020-07-22 13:27:57 -04:00
Robin Ward 0bf28e418f REFACTOR: Remove `Discourse.SiteSettings` from `lib:search` 2020-07-22 13:27:57 -04:00
Robin Ward aa2eea7729 REFACTOR: Remove `Discourse.SiteSettings` from click tracking 2020-07-22 13:27:57 -04:00
Robin Ward bc7dac852f REFACTOR: Remove `Discourse.SiteSettings` from Category model 2020-07-22 13:27:57 -04:00
Robin Ward 217b970e16 REFACTOR: Remove `Discourse.SiteSettings` from desktop notifications 2020-07-22 13:27:57 -04:00
Robin Ward 37f2611d9c REFACTOR: Remove `Discourse.SiteSettings` from topic bulk actions 2020-07-22 13:27:57 -04:00
David Taylor 5b7c016ebc
FIX: Restore navigation-bar on tag topic list 
This was accidentally removed in ac0d5b1d
 2020-07-22 18:26:37 +01:00
David Taylor c09b5807f3
FIX: Include resolved locale in anonymous cache key (#10289) 
This only applies when set_locale_from_accept_language_header is enabled
 2020-07-22 18:00:07 +01:00
David Taylor bcb0e62363
FIX: Make set_locale an around_action to avoid leaking between requests (#10282) 2020-07-22 17:30:26 +01:00
tshenry 723d7e3a61
FEATURE: Submit post from mobile composer preview (#10286) 2020-07-22 09:17:51 -07:00
Bianca Nenciu 22fdd5dfda
FIX: Improve email styling of code blocks (#10248) 
Long numbered code lines were not rendered correctly in some email
clients.
 2020-07-22 18:26:14 +03:00