Commit Graph

398 Commits

Author SHA1 Message Date
Robin Ward 16766a5d62 FIX: `topic.details` is not a plain JS Object 2020-07-15 13:10:05 -04:00
David Taylor 7d300006a1
Revert "PERF: Move highlightjs to a background worker, and add result cache ()"
This caused a CORS error when used with S3 asset storage

This reverts commit d09f283e91.
2020-07-15 13:52:35 +01:00
David Taylor d09f283e91
PERF: Move highlightjs to a background worker, and add result cache ()
Syntax highlighting is a CPU-intensive process which we run a lot while rendering posts and while using the composer preview. Moving it to a background worker releases the main thread to the browser, which makes the UX much smoother.
2020-07-15 12:48:07 +01:00
Kris 706f1a6294
DEV: Remove text-ellipsis component and use CSS line-clamp instead () 2020-07-09 20:51:43 -04:00
Jarek Radosz 32ee9fae40
FIX: Short URL resolution in cook-text ()
Regressed in 3b51e05de2. Thanks to @romanrizzi for reporting!
2020-07-09 14:39:13 +02:00
Kris 66257ca8b6 FEATURE: Add "smallest" option to user text size preferences 2020-07-07 13:08:19 -04:00
Bianca Nenciu 4a90464619
FIX: Do not highlight large code blocks () 2020-07-07 18:51:19 +03:00
Bianca Nenciu dd85d44dda
FIX: Show tag count for existing tags ()
* FIX: Show tag count for existing tags

* Add test
2020-06-11 14:13:48 +03:00
Penar Musaraj 2d880b42a3
UX: Add simple-list setting type () 2020-06-04 10:44:54 -04:00
Joffrey JAFFEUX ae52f5eaf5
DEV: removes brittle test () 2020-06-04 09:21:21 +02:00
Joffrey JAFFEUX 40c4a8e3fc
DEV: skips/tweaks brittle tests () 2020-06-01 11:09:34 +02:00
Joffrey JAFFEUX 7635c18a14
DEV: ensures highlightjs is correctly tested () 2020-05-29 13:05:44 +02:00
Joffrey JAFFEUX 0854785175
FIX: allows to define label/title properties for display instead of name
Usage:

```
const content = [{foo: "FOO", bar: "BAR", value: 1, name: "foo-bar"}];

{{combo-box
  content=content
  value=value
  labelProperty="foo"
  titleProperty="bar"
}}
```
2020-05-28 08:30:31 +02:00
Joffrey JAFFEUX e81a4048e3
REFACTOR: s/focusAfterOnchange/focusAfterOnChange () 2020-05-16 11:20:37 +02:00
Joffrey JAFFEUX b07f1bfd93
FIX: displays a title on sk header if no selected name ()
none has to be defined.
2020-05-15 17:36:00 +02:00
Robin Ward aa2d040526 DEV: Update ESLint to remove I18n global
Also fixes missed imports in core.
2020-05-14 10:18:12 -04:00
Joffrey JAFFEUX 42e5a5bb39
DEV: do not append/prepend if callback returns nothing () 2020-05-14 14:38:03 +02:00
Joffrey JAFFEUX 286b4e535e
DEV: allows buttons to define aria-label () 2020-05-11 22:09:44 +02:00
jjaffeux 0deb05740f Revert "DEV: allows to define an ariaLabel on d-button ()"
This reverts commit 7a95dd4841.
2020-05-11 19:19:13 +02:00
Joffrey JAFFEUX 7a95dd4841
DEV: allows to define an ariaLabel on d-button ()
* DEV: allows to define an ariaLabel on d-button

This topic also adds this function to topic-footer-buttons, simplifies the whole logic of titile/label/arialabel in d-button and adds tests for these properties.

* typo
2020-05-11 18:42:51 +02:00
Joffrey JAFFEUX 9bf11a8c68
DEV: allows select-kit to prevent autofocus of header after onChange () 2020-05-09 10:26:23 +02:00
Joffrey JAFFEUX c99ecba68f
DEV: improves sk api ()
- reduces the API to 3 actions for now: appendContent/prependContent/onChange
- well tested
- removes all previous APIS which were only half supported or too dangerous as they could collide with other plugins or core behaviors
- this plugins also puts every sk test helpers in one file
2020-05-06 17:16:20 +02:00
Joffrey JAFFEUX 3bbd8b1258
UX: rework date time input range () 2020-04-22 22:17:53 +02:00
Joffrey JAFFEUX fe579c918f
DEV: fix failing test relating to sk click propagation
* followup to 62459c84
2020-04-21 12:01:16 -04:00
Joffrey JAFFEUX d984848aa9
FIX: ensures toolbar is updated on composer action change () 2020-04-10 22:39:19 +02:00
Joffrey JAFFEUX 058506bb77
DEV: prevents toolbar callbacks to leak between tests () 2020-04-10 16:47:27 +02:00
Martin Brennan befaf39aca
DEV: Refactor and test plugin addKeyboardShortcut ()
Refactor plugin-api `addKeyboardShortcut` to point to `KeyboardShortcuts`.
* Do not add shortcuts to the default object directly.
* Create an addShortcut function in keyboard-shortcuts to add shortcuts safely and call to bindKey to be able to use opts.
* Refactor controllers/bookmark.js to use new addShortcut func and emove unnecessary addBindings.
* No longer export keyboard shortcut bindings, rename to DEFAULT_BINDINGS and remove export, these do not need to be accessed by anything else.
2020-04-09 10:30:26 +10:00
Robin Ward 4f42bb1fd2
DEV: Support for `onChange` on `{{text-field}}` ()
* DEV: Support for `onChange` on `{{text-field}}`

This will automatically be debounced and only fired when the value
changes.

There is also `onChangeImmediate` which is not debounced in case you
need that, but in almost all cases when observing text in an element you
should debounce.

* Add cancel for timer
2020-04-07 11:41:21 -04:00
Joffrey JAFFEUX 8f4b54fedd
fix d-button tests () 2020-03-30 23:42:21 +02:00
Joffrey JAFFEUX 5b6cdd6fb5
DEV: adds a loading property to d-button ()
Usage:

```
{{d-button icon="times" label="foo.bar" isLoading=true}}
```

Note that  a button loading without an icon will shrink text size to prevent button to jump in size.

A button while loading is disabled.
2020-03-30 23:17:00 +02:00
Robin Ward 60df2ade8d Retry: Rename all test files from JS -> ES6 2020-03-26 12:25:46 -04:00
Robin Ward 4fa580fbd1 Revert "Rename all test files from JS -> ES6"
This reverts commit 2abe85b834.
2020-03-25 16:13:43 -04:00
Robin Ward 2abe85b834 Rename all test files from JS -> ES6 2020-03-25 15:03:21 -04:00
Joffrey JAFFEUX 683cb28099
DEV: enforces ember-template-lint: no-triple-curlies ()
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.

Also introduces an htmlSafe computed macro:

```
import { htmlSafe } from "discourse/lib/computed";

htmlDescription: htmlSafe("description")
```

Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-11 09:23:10 +01:00
romanrizzi f795c1b8e8 Revert "DEV: enforces ember-template-lint: no-triple-curlies ()"
This reverts commit d436b600fb.

Triple curlies are still necessary for some raw templates.
2020-03-10 15:00:12 -03:00
Joffrey JAFFEUX d436b600fb
DEV: enforces ember-template-lint: no-triple-curlies ()
This pr replaces `{{{ }}}` usage by a {{html-safe}} helper. While it doesn't solve the underlying issue, it gives us a path forward without risking breaking too much existing behavior.

Also introduces an htmlSafe computed macro:

```
import { htmlSafe } from "discourse/lib/computed";

htmlDescription: htmlSafe("description")
```

Overtime {{html-safe}} usage should be removed and moved to components properties or specialized components/helpers.
2020-03-10 16:46:57 +01:00
Joffrey JAFFEUX 78a6b76310
FIX: ensures pinned-options header is showing correct state () 2020-03-10 09:56:55 +01:00
Joffrey JAFFEUX 29c9d8a133
FIX: uses only global allow_uncategorized_topics for category drop () 2020-03-06 20:11:21 +01:00
Mark VanLandingham 176aa0ac7d
DEV: Import pretender instead of global server var ()
* DEV: Remove server global test variable

* Delete yarn-error.log

* prettier and some eslint fixes

* add global server variable back for plugins

* rename imported server to pretender

* prettier

* support plugin server. usage

* Export pretender as named

* Prettier

* change default pretender export

* fix bad import

* Use pretender() and original default export

* export new Pretender as default

* fix accidental change

* WIP testing

* add pretend handlers in correct location

* move more stuff into the correct pretender

* Consolidated more pretenders

* comment out another bad test

* fix user acceptance tests

* commented out bad test

* fixed another composer server stub

* fix more tests

* fixed tag test pretender

* Fix admin email test

* removed another draft handler

* add back test

* fix and uncomment another test

* remove test that is not useful

* remove commented out lines

* reapply handlers between every test

* no need to re-stub requests now :)

* cleanup from review

* more cleanup
2020-03-02 14:24:31 -05:00
Joffrey JAFFEUX ed85cfe141
FIX: prevents click on sk header to bubble () 2020-03-02 20:06:02 +01:00
Joffrey JAFFEUX 2db8ada222
FIX: ensures category url of category drop is built using slug and id () 2020-02-28 17:58:22 +01:00
Mark VanLandingham 337b823ec6
Merge pull request from GHSA-vw39-6w7q-gfx5
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2020-02-27 11:47:15 -06:00
Penar Musaraj d6a603cc50
FIX: Translate none-tag and all-tags labels in tag filter ()
* FIX: Translate none-tag and all-tags labels in tag filter
* Add test
2020-02-25 07:57:24 +11:00
Joffrey JAFFEUX f336aeee6f
FIX: ensures scoped search category is searching in all categories () 2020-02-24 19:19:53 +01:00
Joffrey JAFFEUX e807dff6fc
FIX: ensures mini-tag-chooser is respecting max_tags_per_topic () 2020-02-21 12:16:05 +01:00
Penar Musaraj 89d9704194 FIX: value-list choices when removing a value
Fixes an issue where choices were broken when removing an item from the value-list component.

Adds test case for this scenario.
2020-02-14 11:21:06 -05:00
Joffrey JAFFEUX 42bda52486
FIX: ensures select-kit can select a row with 0 as value () 2020-02-13 09:04:32 +01:00
Joffrey JAFFEUX 9d50e1b40f
DEV: introducing user-chooser () 2020-02-11 15:54:56 +01:00
Joffrey JAFFEUX f5f4ce90c1 DEV: adds afterRender decorator () 2020-02-10 08:13:13 +01:00
Mark VanLandingham 499b57a9ed
DEV: Ember linting - disallow Ember.* variable usage () 2020-02-05 10:14:42 -06:00