b96c10a903
DEV: Extract shared external upload routes into controller helper ( #14984 )
...
This commit refactors the direct external upload routes (get presigned
put, complete external, create/abort/complete multipart) into a
helper which is then included in both BackupController and the
UploadController. This is done so UploadController doesn't need
strange backup logic added to it, and so each controller implementing
this helper can do their own validation/error handling nicely.
This is a follow up to e4350bb966
2021-11-18 09:17:23 +10:00
9be69b603c
DEV: Make `screen-track` a regular service ( #14983 )
2021-11-17 20:56:06 +01:00
bf34d3524b
DEV: Fix a `userFields` computed property override ( #14988 )
...
in `preferences/profile` controller
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
2021-11-17 15:02:15 +01:00
439cd68e0d
DEV: updates popper to 2.10.2 ( #14986 )
2021-11-17 13:47:55 +01:00
113ecab7a6
FIX: clear previous errors on second factor form display ( #14987 )
2021-11-17 13:47:38 +01:00
9ce29ad013
FIX: register customOptions as select kit filter ( #14933 )
...
* FIX: register customOptions as select kit filter
We are allowing plugins to define custom filters which are added to CUSTOM_USER_SEARCH_OPTIONS const. However, we need to have static placeholder for custom filters, so those props will be passed, and we can use it later.
* fix
2021-11-17 17:12:19 +11:00
2ff7f105d9
UX: launch full page search on second `Enter` hit ( #14978 )
2021-11-17 16:35:17 +11:00
c61d47e6f4
FEATURE: Show a confirmation modal when "Dismiss all" would dismiss an important notification ( #14935 )
...
* Show a confirmation when dismiss all will dismiss an important notification
2021-11-17 09:44:30 +08:00
bf33d2cd4b
FIX: Include all categories in sortedCategories ( #14979 )
...
Fixes the issue where categories over two levels deep were missing.
2021-11-17 00:12:04 +01:00
7e39910de6
DEV: Refactor uppy s3 mulipart mixin to not use self = this ( #14960 )
...
We no longer use this pattern, so we can replace with function
binding instead.
2021-11-17 09:03:10 +10:00
aa31fbe29a
REFACTOR: Continued topic-list tweaks ( #14977 )
...
* REFACTOR: Prep for topic-list refactor
2021-11-16 14:44:04 -06:00
1b752a5dec
DEV: Export add emoji logic in textarea manipulation mixin ( #14976 )
2021-11-16 13:42:21 -06:00
19fb97bb13
FIX: Adjust topic list header alert ( #14974 )
2021-11-16 11:09:07 -06:00
e306d84c56
FEATURE: display warning when sharing a topic in a restricted category ( #14820 )
...
* FEATURE: display warning when sharing a topic in a restricted category
If a topic belongs to a category that is not readable by everyone, display a text warning of "Only visible to members of groups: [group_a], [group_b]"
* DEV: Adding a new category means we need to bump this value
* DEV: pass category to showModal
2021-11-16 11:49:41 -05:00
b6677fb126
DEV: Use radix 10 in `parseInt()` ( #14973 )
2021-11-16 16:36:44 +01:00
035822d9e0
DEV: sticky avatar was retained during tests ( #14969 )
2021-11-16 14:33:06 +01:00
ff7e685a59
DEV: removes jquery usage from discourse-topic ( #14964 )
2021-11-16 13:17:44 +01:00
0fbeb2e5a2
DEV: removes jquery usage from links-redirect ( #14968 )
2021-11-16 13:16:53 +01:00
f9682f1c69
DEV: removes jquery usage from html-with-links ( #14966 )
2021-11-16 13:16:43 +01:00
32c6c4f417
DEV: Remove unused action ( #14889 )
...
There are no usages in Core and plugins.
2021-11-16 15:49:59 +04:00
370c729160
FIX: Additional fixes for last-visited on topic list ( #14962 )
2021-11-16 12:34:29 +01:00
2167d4d890
FIX: fix regressions introduced in ae16b0a ( #14967 )
...
- ensures arrow up/down doesn’t also apply to textarea while autocomplete is opened
- ensures esc is closing autocomplete and also not closing composer while autocomplete is opened
2021-11-16 12:19:14 +01:00
49f09345c7
FIX: adds missing class for last visit separator ( #14965 )
2021-11-16 11:40:08 +01:00
ae16b0a9d4
DEV: reduces jquery usage and memory leaks in composer ( #14924 )
...
Removes more than 60 jquery function leaks in one `Acceptance: Composer` run.
2021-11-16 10:27:05 +01:00
ef881fdedc
DEV: drops jquery/simplify code/removes leaked event ( #14947 )
2021-11-16 10:26:39 +01:00
c768c2ab3a
DEV: drops jquery usage in stacked chart ( #14946 )
2021-11-16 10:26:26 +01:00
43659a6de2
DEV: jquery removal/listeners/cleanup of permalink form ( #14944 )
...
- Removes jquery
- Removes a not unregistered listener and uses component event
- Removes external-url class as it was only valid in one case of the dropdown
- Uses @action
- Tagless
- Other minor changes
2021-11-16 10:25:54 +01:00
c9a84d8067
DEV: removes unnecessary jquery selector ( #14945 )
2021-11-16 10:25:34 +01:00
88523a6d6a
FIX: Redirect to homepage if no posts exist ( #14951 )
...
After permanently deleting the first post of a topic the user was
sometimes stuck on the page because of an infinite loop. This problem
happened more often in Firefox.
2021-11-16 11:10:07 +02:00
c2be7c65e8
FEATURE: Move sticky avatars into core
...
This patch takes the small component we had for sticky avatars and adds
it into our core code base.
A small refactor has been made to have a `StickyAvatars` dedicated class.
2021-11-16 10:06:25 +01:00
8b5dec4607
UX: mobile topic list fixes follow-up to 0e371d4 ( #14959 )
2021-11-15 21:07:32 -05:00
f61783a218
FIX: Emoji uploader not using data.name on uppy upload ( #14958 )
...
When uploading emoji with the new uppy upload mixin, we were
not sending the name of the emoji in the payload, or more
accurately uppy was already using the file name as the name
value and we were not overriding it from data. This commit
changes the behaviour for single files uploaded via the uppy
upload mixin, by merging the file's meta object with this.data
from the parent component.
2021-11-16 11:14:06 +10:00
f4d1fe18f8
DEV: Don't use `$.isEmptyObject()` ( #14953 )
2021-11-15 23:17:56 +01:00
0e371d4c6d
SYNTAX: Use classes instead of html element targeting ( #14890 )
...
* SYNTAX: Use classes instead of html element targeting
2021-11-15 14:49:45 -06:00
389a3ce389
DEV: Add basic theme support to the mini_profiler badge ( #14952 )
2021-11-15 18:39:11 +00:00
5c43b8a572
DEV: Retry installation of ember exam
...
Let's try installing it by including it in dependencies AND dev
dependencies so it works in every environment.
2021-11-15 10:30:56 -05:00
2bd2d0d474
FIX: A screen-track/appEvents regression in #14929 ( #14943 )
2021-11-15 15:04:49 +01:00
67e38e81f7
DEV: Remove unnecessary test setup calls ( #14940 )
...
`setURLContainer()` and `setDefaultOwner()` are already called in an application initializer at the beginning of each test.
2021-11-15 13:46:09 +01:00
985d079e47
DEV: Clean up `sniff-capabilities` ( #14938 )
...
Drop jQuery, remove unused caps (`canPasteImages` and `highRes`), enable `canVibrate` for Firefox (per the old comment), and other minor changes.
2021-11-15 13:41:55 +01:00
8c4896f660
FIX: composer education message for group mentions were broken ( #14937 )
...
Composer education message for group mentions were broken because the
count parameter is a string instead of a number.
2021-11-15 17:12:06 +05:30
fc3a6e57e3
DEV: Drop support for removing all appEvent listeners ( #14936 )
...
Also removes "appEventsCache". (and reduces the reported test memory usage by ~33%)
There's no longer any need to remove appEvent listeners in application-instance initializers' `teardown`, as app instances are recreated before each test (in both legacy and ember cli envs)
2021-11-15 12:31:05 +01:00
f0d963faad
DEV: Use `@bind` instead of repeated `.bind(this)` ( #14931 )
...
Fixes some cases where event listeners weren't correctly removed. Also fixes a dependency tracking bug in user-private-messages
2021-11-15 10:07:53 +01:00
9c9ad22626
DEV: Fix `qunit/assert-args` ( #14932 )
...
Just a couple of invalid assertions.
2021-11-15 04:30:42 +01:00
b1c72282c9
DEV: Delete an old `appEvents.off` call ( #14930 )
...
There's no `composer:resize` anymore.
2021-11-15 02:38:10 +01:00
a817ee9f7c
DEV: Update `caniuse-lite` ( #14926 )
...
The repeated notices in the console were tiring…
```
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating
```
2021-11-15 01:18:11 +01:00
047432735e
DEV: Don't create AppEvents instance in Eyeline ( #14928 )
...
Use `Evented` from `@ember/object/evented` instead.
2021-11-15 00:44:07 +01:00
25251d4d00
DEV: Don't set appEvents on app, group injections ( #14929 )
2021-11-15 00:42:49 +01:00
9711caf7ea
DEV: Fix a computed property overwrite ( #14927 )
...
There's a `category` computed property that already does what this piece of code did.
2021-11-15 00:39:20 +01:00
2b848213f7
FIX: set `null` to group if `groupAttrs` param is not available. ( #14795 )
...
Because of this bug "all groups" option in the group selector dropdown was not selectable on the user directory page.
2021-11-14 19:53:50 +05:30
4f14e012a7
DEV: Replace `$.extend` with `Object.assign` ( #14921 )
2021-11-14 10:59:22 +01:00
Martin Brennan
Jarek Radosz
Joffrey JAFFEUX
Krzysztof Kotlarek
Penar Musaraj
Natalie Tay
Jordan Vidrine
Mark VanLandingham
jbrw
Andrei Prigorshnev
Bianca Nenciu
Loïc Guitaut
Kris
David Taylor
Robin Ward
Arpit Jalan
Vinoth Kannan