Discource-C
/
discourse
mirror of https://github.com/discourse/discourse.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
37,678 Commits 245 Branches 500 Tags 894 MiB
Commit Graph

22424 Commits

Author SHA1 Message Date
Kris b9d9bbb95f UX: More consistent alignment of topic timer's selected datetimes 2020-05-27 22:19:00 -04:00
Sam Saffron 9841569bba
Revert "DEV: Fix a deprecated `ember` import (#9903)" 
This reverts commit 75f46ca632.

This unfortunately breaks

`RAILS_ENV=production bin/rake assets:precompile`

I don't think discourse-loader.js is transpiled
 2020-05-28 10:06:05 +10:00
Blake Erickson b10e995d9d Revert "DEV: Import `MessageBus` from `message-bus-client` instead of globals" 
This reverts commit 9dddbcc00d.
 2020-05-27 16:14:09 -06:00
Blake Erickson 6548cd1a96 FIX: sending messages to groups with non-lowercase names 
Fixes a regression in

e8fb9d4066

which caused a bug where you couldn't send a message to a group that
contained an Uppercase letter. Added a test case for this.

Bug report: https://meta.discourse.org/t/-/152999
 2020-05-27 14:52:08 -06:00
Jarek Radosz 75f46ca632
DEV: Fix a deprecated `ember` import (#9903) 
See the following for `Ember.testing` and `@ember/debug isTesting`:

* 8cf29959f7/packages/ember/index.js (L372-L376)
* 8cf29959f7/packages/%40ember/debug/lib/testing.ts
 2020-05-27 22:47:46 +02:00
Robin Ward 9dddbcc00d DEV: Import `MessageBus` from `message-bus-client` instead of globals 2020-05-27 16:42:42 -04:00
Robin Ward 0f71d38d3a Revert "DEV: Import `MessageBus` from `message-bus-client` instead of globals (#9902)" 
This reverts commit d3bd482142.
 2020-05-27 16:34:30 -04:00
Robin Ward d3bd482142
DEV: Import `MessageBus` from `message-bus-client` instead of globals (#9902) 2020-05-27 15:56:46 -04:00
Blake Erickson a788427b46
FIX: broken query if upload id is missing (#9900) 
Log warnings if there are any errors trying to upload group flair image
and ensure upload.id exists before trying to use it in a sql query.
 2020-05-27 12:39:30 -06:00
Jeff Wong a9d92f338e
SECURITY: make find topic by slug adhere to SiteSetting.detailed_404 (#9898) 2020-05-27 11:28:38 -07:00
Joffrey JAFFEUX 77801aa9be
FIX: allows to have custom emoji translation without static file (#9893) 2020-05-27 20:11:52 +02:00
Roman Rizzi 207b72ade1
UX: Don't show the suspension date if the user is permantently suspended. (#9895) 
Use the same pattern used in user.hbs
 2020-05-27 14:50:17 -03:00
Dan Ungureanu 570b12a903
FEATURE: Show a detailed 404 page for private topics (#9894) 2020-05-27 20:10:01 +03:00
Penar Musaraj 7bc496070f UX: Keep focus on input after selecting an autocomplete option 
This is particularly helpful on mobile, now tapping on an item from
the autocomplete dropdown keeps the keyboard visible.
 2020-05-27 12:45:03 -04:00
Arpit Jalan 68fdfd76f5 fix the build 2020-05-27 22:06:45 +05:30
Arpit Jalan 8d2908dd9e UX: do not show redundant user count 
UX: add spacing between +member_count and "more"
 2020-05-27 21:53:59 +05:30
Artem Vasiliev 12544c02c1
FIX: add X-Robots-Tag header for check_xhr-covered GET actions, too (#9868) 
* FIX: add X-Robots-Tag header for check_xhr-covered GET actions, too

see https://meta.discourse.org/t/missing-x-robots-tag/152593/3 for context

* test: a spec making sure X-Robots-Tag header is present when needed

/groups path responds to anonymous requests and doesn't skip `check_xhr` method, so we can use it here.
 2020-05-27 11:57:05 -04:00
Roman Rizzi 461df7d050
UX: Rename Priority to score for sorting. (#9846) 2020-05-27 12:50:28 -03:00
Blake Erickson da839e6d26 SECURITY: Use FinalDestination for topic embeds 2020-05-27 09:26:09 -06:00
Régis Hanol 2a4db15544 FIX: don't send digests to users with no primary email 
It might happen that some User records have no associated primary emails.
In which case we don't ever want to send them a digest.

Also added a new "user_email_no_email" skipped email log to ensure these cases
are properly handled and surfaced.
 2020-05-27 17:09:40 +02:00
Arpit Jalan 2152e70e0d DEV: annotate models 2020-05-27 19:05:24 +05:30
Joffrey JAFFEUX f51093dde7
FIX: correctly set values and defaults for group-form-interaction-fields (#9891) 2020-05-27 12:10:27 +02:00
Joffrey JAFFEUX 1d685c22af
REVERT: removes translate_emoji (#9889) 
This API is actually used in some plugins.
 2020-05-27 12:08:24 +02:00
Sam Saffron 1cf2d1f9f2
FIX: when destroying a draft always ensure saving is done 
There was a race condition where drafts could be either saving
or queued to be saved and a user canceled draft leading to destroying
it.

This cancels debounce save and waits for save in the pipeline to
be over prior to firing off a DELETE on the draft
 2020-05-27 18:46:19 +10:00
Sam Saffron f41fcad6c3
FIX: opening cancel draft dialog broke autosave 
cancelComposer would leak a promise that never got resolved if
you aborted cancelling a composer.

This change ensured the promise will always be resolved
 2020-05-27 18:16:48 +10:00
Sam Saffron 5bfb6830c9
SECURITY: missing security check prior to redirect 
In some rare cases, if a user knows the exact title of a topic
they could possibly determine that it really exists in the system
 2020-05-27 10:58:22 +10:00
Martin Brennan 2d534bf2e0
FIX: Pass current_user to TopicQuery in for categories_and_top_topics (#9885) 2020-05-27 10:05:06 +10:00
Krzysztof Kotlarek 34e5f0a9a3
Revert "FEATURE: notify admins about old credentials (#9854)" (#9886) 
This reverts commit 349a67bee6.
 2020-05-27 09:52:53 +10:00
Kris 66ec634cb3 Composer whisper icon missing margin when editing replies 2020-05-26 19:17:09 -04:00
Jordan Vidrine 5f61deff80
FIX: updates variables for HTML to use `em` instead of `px` in font-size (#9883) 2020-05-26 17:48:35 -05:00
Krzysztof Kotlarek 349a67bee6
FEATURE: notify admins about old credentials (#9854) 
* FEATURE: notify admins about old credentials

Security and API keys should be renewed periodically.
This additional notification should help admins keep their Discourse safe and secure.
 2020-05-27 08:13:47 +10:00
Neil Lalonde 2c880b9bf9
FIX: wizard fails to start when default_theme_id is -1 2020-05-26 16:08:35 -04:00
Penar Musaraj b1c726be0d
Remove support for FontAwesome 4.7 icon names (#9871) 2020-05-26 14:53:32 -04:00
Mark VanLandingham 7820686f73
FIX: Wizard previews if color step is excluded (#9881) 2020-05-26 12:56:36 -05:00
Joffrey JAFFEUX 675e9b81c6
FIX: document.activeElement can be null on IE11 (#9880) 2020-05-26 16:51:55 +02:00
Guo Xiang Tan 26c7fa2c29
FIX: `rescue_from` doesn't bubble up. 
See a47e0c19e6/actionpack/lib/action_controller/metal/rescue.rb (L25)
 2020-05-26 22:43:29 +08:00
Joffrey JAFFEUX 253a185769
FIX: makes focust text area after complete more resilient (#9879) 2020-05-26 16:27:02 +02:00
Bianca Nenciu f47400475e
FEATURE: Send a private message when a group membership is accepted (#9822) 
* FEATURE: Send a private message when a group membership is accepted

* DEV: Small code improvements

* FIX: Send PM as group owner

* Copy edits
 2020-05-26 16:28:03 +03:00
Sam Saffron 76c4bc925d
DEV: followup to prev commit 
337bd9a0f7 did not account for optimized image being nil
 2020-05-26 16:19:05 +10:00
Sam Saffron 337bd9a0f7
FIX: concurrency bug when creating topic thumbnails 
We were failing erratically when backfilling topic thumbnails.

This ensures that racing threads/processes will not conflict.
 2020-05-26 16:10:22 +10:00
Osama Sayegh 2211581a85
FIX: Don't responde with error 500 if domain is invalid when adding automatic membership domain (#9655) 2020-05-26 15:40:09 +10:00
Arpit Jalan 5462fe9462
FIX: do not allow tag with name 'none' (#9867) 
https://meta.discourse.org/t/none-tag-is-uneditable/152003
 2020-05-26 08:15:45 +05:30
Guo Xiang Tan 878f06f1fe DEV: Remove custom connection reaper. 
Rails 6 fixed the reaper to use one thread to reap all the connection pools.
 2020-05-26 09:09:46 +08:00
Sam Saffron fc97f7e0e7
FIX: properly ban non human users from draft system 
Previously we had a partial fix in place where non human users
were not allowed draft sequences, this left edges around where non
human users asked for drafts yet had none.

For example system could already have a few drafts in place.

This also removes and extensibility point we added that is not in use
 2020-05-26 10:07:09 +10:00
Joffrey JAFFEUX d9f915b195
FIX: documentation was using incorrect function (#9876) 2020-05-25 21:55:30 +02:00
Joffrey JAFFEUX be16205118
DEV: plugin api should have been bumped for #8825395 (#9874) 2020-05-25 21:44:15 +02:00
Vinoth Kannan 5fb9271878
DEV: ignore `flair_url` column in group model. (#9873) 2020-05-26 00:43:50 +05:30
Joffrey JAFFEUX 8825395bdc
DEV: allows to decorate username selector (#9869) 
Usage:

```
api.addUsernameSelectorDecorator(username => {
  return iconHTML("calendar-alt");
});
```
 2020-05-25 19:09:55 +02:00
Robin Ward fd2d7ca992 FIX: Email Styles were evaluated out of order 
`yield` puts the content in the template right away unless explicitly
`capture`'d.
 2020-05-25 12:47:23 -04:00
Arpit Jalan e8fb9d4066 FIX: when creating new PM username/groupname should be case-insensitive 
(take 2)

https://meta.discourse.org/t/case-sensitivity-in-links-to-groupname/147596
https://meta.discourse.org/t/remove-case-sensitive-in-adding-users-to-a-message/151275
 2020-05-25 21:34:05 +05:30