93ab03966e
FIX: no-follow not handled correctly for sub domains
...
if a.com was whitelisted aa.com would pass through
2015-05-27 14:31:01 +10:00
693b5234da
FIX: nil emails are invalid
2015-05-27 14:12:10 +10:00
a988cd5abe
FIX: redirect to CDN avatar for s3 avatars
2015-05-27 12:02:57 +10:00
32f91301ef
fix deprecation warnings in spec (cc @nlalonde)
2015-05-26 11:42:37 +02:00
147ea002f7
FIX: allow handling for avatars that are not in the set of "resized sizes"
2015-05-26 15:41:50 +10:00
e17f614771
FIX: fallback to local store when uploads are not on S3
2015-05-26 13:08:31 +10:00
eeda367e70
FIX: should be able to serve optimized image from local if its ... local...
2015-05-26 12:32:52 +10:00
90eaad336d
FEATURE: allow users to pick a CDN for s3 assets
2015-05-26 11:13:12 +10:00
b9c7e3b74a
FIX: categories page counts were very wrong for categories with sub-categories
2015-05-25 17:42:16 -04:00
bb0c2813ac
FEATURE: generate (avatar) thumbnails in a background task
...
FIX: keep the "uploading..." indicator until the server replies via the MessageBus
FIX: text was disapearing when uploading an avatar
PERF: always use a region for S3 (defaults to 'us-east-1')
FEATURE: ApplyCDN middleware when using S3
FIX: use the same pattern to store files on S3 and locally
PERF: keep a local cache of uploads when generating thumbnails
FEATURE: migrate_to_s3 rake task
2015-05-25 17:59:00 +02:00
675e2c6e13
remove invalid test since fog is gone
2015-05-25 18:08:59 +10:00
379eb01aab
missing prep in test
2015-05-23 15:39:44 +10:00
bcaed90744
fix missing rtl stylesheets
2015-05-23 15:25:05 +10:00
96dbeb8608
fix stylesheet cache to recover if file is on disk
2015-05-22 11:22:12 +10:00
1c926d22c6
Correctly parse `require_activation` field of SSO
2015-05-21 16:50:54 -05:00
bcd98c8f0f
FIX: API can provide a URL to create an upload
2015-05-20 17:38:06 +02:00
c91634c09a
FIX: support for async uploads of emojis
2015-05-20 16:45:48 +02:00
8d967d9065
FEATURE: move all uploads to a single endpoint + defer upload creation in a background thread
2015-05-20 16:45:48 +02:00
7d23826cee
FIX: Keep around the page when redirecting
2015-05-20 10:16:17 -04:00
7d3b7a5657
fix the build
2015-05-20 15:32:31 +02:00
8be746b285
fix spec
2015-05-20 12:35:22 +10:00
d1d703718a
Merge pull request #3476 from paulkaplan/sso-distrust-email
...
Add SSO setting to not trust emails automatically
2015-05-20 12:07:14 +10:00
4ab9ef3497
FIX: Allow long words if they contain periods
2015-05-19 13:10:25 -04:00
1c34341f31
Replace site setting with a payload attribute
2015-05-19 11:16:02 -05:00
9ded21e4c6
FIX: consistent and future-proof upload storage pattern
2015-05-19 12:31:12 +02:00
dd91d5b02f
FEATURE: disable invites by setting max_invites_per_day to 0
2015-05-19 16:51:21 +10:00
b8a43e153c
Use session controller to prevent inactive SSO users
2015-05-15 12:15:06 -05:00
4c26c4d9bc
Add a SiteSetting to not trust sso emails by default
2015-05-15 12:15:06 -05:00
d40d308e45
Merge pull request #3445 from lukegb/bug/anonymous-emails
...
Don't send emails to anonymous users
2015-05-15 14:28:37 +02:00
d4974b7093
FIX: anonymous mode don't work when names are required
2015-05-15 14:20:15 +02:00
fdbcc31a9c
Merge pull request #3461 from fantasticfears/slug
...
FIX: category custom slug can't be set when generation method is none
2015-05-15 14:59:35 +10:00
e074651fdc
PERF: refactor user search so works more efficiently
...
Stop scanning entire user table
2015-05-14 14:38:47 +10:00
e6f73a1c80
PERF: optimise front page category security lookup query
2015-05-14 12:19:22 +10:00
5fdbc6c4b2
FIX: Replies to PMs should never been enqueued
2015-05-13 12:08:53 -04:00
bb29bff5d8
Merge pull request #3463 from techAPJ/patch-2
...
FIX: match subdomain with email domain blacklist
2015-05-13 17:56:54 +02:00
220b9c5abe
FIX: match subdomain with email domain blacklist
2015-05-13 21:02:02 +05:30
d90e0fe66b
Merge pull request #3460 from techAPJ/patch-3
...
FIX: rate limit topic invitations
2015-05-13 12:55:20 +02:00
4324a157e0
FIX: rate limit topic invitations
2015-05-13 14:44:37 +05:30
4c00eef8b5
FIX: category custom slug can't be set when generation method is none
2015-05-13 16:54:19 +08:00
51d82fc25d
PERF: Active Record #pluck is twice faster
...
PERF: SqlBuilder bypasses AR converters and uses PG directly
2015-05-13 16:46:17 +10:00
406c8bb340
PERF: don't recompile css files that have already been compiled
2015-05-12 16:12:49 -04:00
5ef641126f
remove s3 deprecation warning, we will continue to support it
2015-05-12 08:27:25 +10:00
0b65c88003
Upgrade Notifications to fix deprecations and use store
2015-05-11 11:20:45 -04:00
9f9825bb6b
FIX: don't send emails to anonymous users
...
Also changes behaviour of real to not return anonymous users.
This means user counts will no longer include them, and the
mailing list system will ignore them even if they somehow end up
with the feature turned on.
2015-05-11 00:56:34 +01:00
124ae8ada6
correct spec
2015-05-06 12:01:47 +10:00
0f53fc8328
correct emergency regeneration in the controller
2015-05-06 07:33:32 +10:00
a48dd1cc28
store the slug as the title is, only sanitize the slug
...
and prettify code
2015-05-05 18:33:16 +08:00
b772ff6e13
FEATURE: add slug geneartion options
2015-05-05 18:08:30 +08:00
f58d85edea
FEATURE: move stylesheet cache out of the uploads directory
2015-05-05 15:50:13 +10:00
963ebf5963
FIX: if approving a user when must_approve_users is false, don't send an email
2015-05-04 15:30:25 -04:00
7e3eaf5b02
FIX: Never enqueue private messages
2015-05-04 11:07:46 -04:00
d9ec6888e1
FIX: allow site_name to be present in rejection email subject
2015-05-04 11:22:54 +05:30
803feefd54
MessageBus handles readonly redis now, no need to wrap it
2015-05-04 12:21:00 +10:00
f9069c350f
FIX: Permission issues when editing topics
...
If a user can't create a topic in a category, they should'be be
able to edit topics.
2015-04-30 17:08:12 -04:00
16408cee06
Allow Postgres to trigger readonly mode for the site.
2015-04-29 11:49:58 -04:00
439d0d2e37
Check Rails.version instead of ENV
...
Like that we can have code that works on multiple Rails versions, and we
dont need to mix a new method on Kernel.
Also, this makes easier to have multiple versions.
For instance, before master was 4.2, which is not the case anymore, so
on the code we should check versions and not Environment variables
2015-04-28 22:27:47 -04:00
cf0c2d09d4
Handlers can be added with a priority
2015-04-28 15:06:47 -04:00
6a338afbdd
Merge pull request #3403 from zzakcanncode/rspec_up
...
Rspec 3
2015-04-28 07:50:30 +10:00
729aaa826b
Merge pull request #3404 from techAPJ/patch-1
...
FEATURE: magic login route for admin when SSO is enabled
2015-04-28 07:47:50 +10:00
2932284293
FEATURE: magic login route for admin when SSO is enabled
2015-04-27 22:54:48 +05:30
de42c627c5
Allow plugins to specify a minimum `requires version`
2015-04-27 13:07:12 -04:00
8f0fb511c3
Fix warnings for rspec 3
2015-04-25 21:02:06 -04:00
e0ea68b9ca
Fix tests on site_setting for new rspec
2015-04-25 11:33:26 -04:00
b8cbe51026
Convert specs to RSpec 2.99.2 syntax with Transpec
...
This conversion is done by Transpec 3.1.0 with the following command:
transpec
* 424 conversions
from: obj.should
to: expect(obj).to
* 325 conversions
from: == expected
to: eq(expected)
* 38 conversions
from: obj.should_not
to: expect(obj).not_to
* 15 conversions
from: =~ /pattern/
to: match(/pattern/)
* 9 conversions
from: it { should ... }
to: it { is_expected.to ... }
* 5 conversions
from: lambda { }.should_not
to: expect { }.not_to
* 4 conversions
from: lambda { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should
to: expect { }.to
* 2 conversions
from: -> { }.should_not
to: expect { }.not_to
* 1 conversion
from: === expected
to: be === expected
* 1 conversion
from: =~ [1, 2]
to: match_array([1, 2])
For more details: https://github.com/yujinakayama/transpec#supported-conversions
2015-04-25 11:18:35 -04:00
151b559e4c
FIX: If you delete a user, delete their queued posts as well.
2015-04-24 16:04:44 -04:00
15dbce5886
Show pending posts count in modal when your posts are enqueued
2015-04-24 15:44:59 -04:00
3660fe4f60
FIX: When approving/rejecting a post it should delete the user action
2015-04-24 15:25:47 -04:00
3a6efa25f0
Allow ReadOnly to propogate up to the Ember app via Response Header
2015-04-24 14:37:16 -04:00
5b3f99aa50
Don't blow up if Redis switches to READONLY
2015-04-24 14:37:16 -04:00
923c164d54
workaround: pg app installs a poorly encoded db, so skip CI will catch
2015-04-24 07:23:02 +10:00
a737090442
- FEATURE: revamped poll plugin
...
- add User.staff scope
- inject MessageBus into Ember views (so it can be used by the poll plugin)
- REFACTOR: use more accurate is_first_post? method instead of post_number == 1
- FEATURE: add support for JSON-typed custom fields
- FEATURE: allow plugins to add validation
- FEATURE: add post_custom_fields to PostSerializer
- FEATURE: allow plugins to whitelist post_custom_fields
- FIX: don't bump when post did not save successfully
- FEATURE: polls are supported in any post
- FEATURE: allow for multiple polls in the same post
- FEATURE: multiple choice polls
- FEATURE: rating polls
- FEATURE: new dialect allowing users to preview polls in the composer
2015-04-23 19:33:29 +02:00
2ee033caa5
FIX: validate integer site setting
2015-04-23 18:15:14 +05:30
85320f919b
FEATURE: user list csv includes approved, suspended_at, suspended_till, blocked
2015-04-22 12:40:12 -04:00
5bf8c31af4
Users can see their pending posts
2015-04-21 16:44:47 -04:00
26693c16ac
Don't show the link to "Needs Approval" unless approval is enabled.
...
Note that any plugin that extends the NewPostMananger to support
enqueuing will enable it.
2015-04-21 13:59:57 -04:00
f600ead587
FIX: Don't validate approved posts.
...
A moderator has already validated them. Otherwise we hit things like
rate limits.
2015-04-21 11:59:35 -04:00
2cdd967188
Adds support for invisible approval queues, which we'll need for Akismet
2015-04-20 17:19:05 -04:00
5990ab855b
PERF: Move post alerting into async
2015-04-20 13:34:57 -04:00
296add56e6
correct letter avatar template
2015-04-20 13:07:12 +10:00
9fbc763902
Replace Hash#keys.each with Hash#each_key for some perf boost
2015-04-18 21:53:53 +10:00
51b747346e
PREF: speed up grabbing unread counts
2015-04-17 16:01:20 +10:00
832cb9fdc3
FIX: admin check missing from topic tracking state
...
FIX: handle muted categories correctly
2015-04-17 14:03:08 +10:00
2459f52c71
Merge pull request #3375 from techAPJ/patch-2
...
FEATURE: invite existing users to private topic
2015-04-16 11:13:42 -04:00
94fea09416
Merge pull request #3383 from techAPJ/patch-4
...
FIX: handle error for duplicate email_in address
2015-04-16 11:13:36 -04:00
866d1cd8e3
FIX: handle error for duplicate email_in address
2015-04-16 16:23:22 +05:30
4387e05162
PERF: speed up query
2015-04-16 17:29:37 +10:00
a5b25ad2af
FEATURE: scale up likes per day as users increase trust level
...
tl2 = 1.5 times the likes
tl3 = 2 times the likes
tl4 = 3 times the likes
configurable via tl[234]_additional_likes_per_day_multiplier site setting
2015-04-16 09:44:30 +10:00
d2ed64751e
UX: Show category badge on enqueued posts
2015-04-15 15:29:37 -04:00
d491d4f997
FEATURE: invite existing users to private topic
2015-04-16 00:52:54 +05:30
9ffec28076
Allow posts in any queue to support topic/post attributes
2015-04-15 14:54:37 -04:00
af1571a58f
Site Settings for post approval
2015-04-15 14:54:37 -04:00
0c233e4e25
Interface is wired up for Approving/Rejecting posts
2015-04-15 14:54:37 -04:00
96d2c5069b
Interface for reviewing queued posts
2015-04-15 14:54:37 -04:00
f1ede42569
Add the posts that need to be reviewed to the hamburger
2015-04-15 14:54:37 -04:00
19a9a8b408
`NewPostManager` determines whether to queue a post or not
2015-04-15 14:54:36 -04:00
a5ee45ccbe
`PostEnqueuer` object to handle validation of enqueued posts
2015-04-15 14:54:36 -04:00
8ba6a45cd7
Post Queue model to enqueue creation of posts
2015-04-15 14:54:35 -04:00
499bed69e2
FIX: show error message if user already exist in group
2015-04-15 14:15:58 +05:30
2a3f71a9a1
SECURITY: log off all existing sessions when resetting password
2015-04-15 08:57:43 +10:00
869d8e25ad
Promotion fails if the user account isn't old enough yet.
2015-04-14 12:14:59 -04:00
eaf5d21c41
Don't store post timings that are greater than the account lifetime
2015-04-14 11:49:44 -04:00
c3b461f58d
Add blank alt attribute to avatars.
...
This was giving an ugly border to avatars in the user card as the full size version loaded in Firefox.
2015-04-14 14:39:40 +01:00
db4c04d606
FIX: Moderators shouldn't be able to see secure deleted posts
2015-04-13 11:48:31 -04:00
5650428052
FIX: Sort page views report records
...
Adding a sort ascending by date to the page views report.
2015-04-12 10:46:13 -07:00
e6df97f01d
FIX: add email reply error message for topic not getting created in restricted category
2015-04-10 17:11:52 +05:30
75890aed26
FEATURE: allow admins to choose a group as a primary group
...
FEATURE: allow admins to set a default title for a group
2015-04-10 12:17:28 +10:00
4bfca12b11
FEATURE: anonymous_account_duration_minutes , cycle anon accounts after N minutes from last post
...
fixes it so anon users can not like stuff
2015-04-08 12:30:02 +10:00
f5d89169e2
FEATURE: initial implemenation of anonymous posting mode
2015-04-07 18:05:31 +10:00
5d31290dbc
FIX: cleanup old letter avatars if needed
...
FEATURE: use image magick version as a key for letter avatars
2015-04-07 13:03:43 +10:00
1a3fa52cde
fix broken build (cc @riking)
2015-04-06 12:12:27 +02:00
c6a5081763
FEATURE: reorder participants in topic so always chronological
...
FEATURE: tie breaker for same number of posts is last post date
UX: highlight for latest poster when it is OP
2015-04-06 17:27:05 +10:00
0e1c4a0a44
Merge pull request #3313 from techAPJ/patch-1
...
FEATURE: invite existing user to a topic
2015-04-03 11:41:10 +02:00
8c2d7dcaac
FEATURE: invite existing user to a topic
2015-04-03 15:00:04 +05:30
30b063c08b
FEATURE: make full names a required field of user profiles with the full_name_required setting
2015-04-02 17:08:04 -04:00
682656fa6c
FIX: only redirect to whitelisted hostnames
2015-04-01 22:59:25 +02:00
0f4a4651a9
FIX: youtube preview video title link doesn't work
2015-04-01 18:23:27 +02:00
eec1921ba9
FIX: notifications inconsistencies + never notify system user
2015-04-01 11:55:59 +02:00
14741b5dac
FIX: only ONE user on site could have a list of muted users
2015-03-31 10:16:23 +11:00
28864e74bc
FIX: Don't show the filter title on the default route
2015-03-30 11:40:44 -04:00
48c58601a6
fix spec
2015-03-27 13:14:50 +11:00
58c95f64d2
FIX: stop stripping zero-width-whitespace
...
This char is used for formatting khmer words
2015-03-27 13:03:24 +11:00
05737effef
FIX: stop stripping dots from SSO names
...
This could upset Louis C.K.
2015-03-27 10:25:51 +11:00
0c287d7d6b
ensure usernames do not keep cycling
2015-03-27 10:04:16 +11:00
94fceaf517
Remove non-legit test, we should always change attributes even if external is unchanged
...
Overriding should be all or nothing
2015-03-27 09:57:43 +11:00
4566a1e30a
FIX: sso override code not triggered when attaching to existing user
2015-03-27 09:39:35 +11:00
2cc5858163
Add site setting to disable User Directory, include restricted info
2015-03-26 11:26:19 -04:00
5aa1272f05
clean up first day user definition and object model
2015-03-26 16:48:36 +11:00
9834d11503
Staff and TL2 up are immune to newuser checks and not considered new users
2015-03-26 16:04:46 +11:00
cfa511e35d
FIX: correctly mute likers
...
FEATURE: disallow all muting of staff
2015-03-26 12:08:04 +11:00
fb0e7dc0b2
FIX: do not delete already redeemed invite
2015-03-25 23:30:09 +05:30
90de61ee3d
S3 deprecation warning
2015-03-25 18:34:07 +01:00
2b46b52b64
Merge pull request #3296 from techAPJ/patch-1
...
FIX: delete duplicate invites
2015-03-25 13:25:05 -04:00
4862a93804
FIX: delete duplicate invites
2015-03-25 22:43:41 +05:30
33e35930b0
FIX: Server error when no results on user directory while logged in
2015-03-25 11:18:46 -04:00
92e371f0b3
FEATURE: civilized mute
...
Allow user to mute all notifications generated by specific users
2015-03-24 11:55:22 +11:00
ff3e1e1dd7
FIX: User's topic lists weren't consistent WRT visibility
2015-03-23 18:13:06 -04:00
1601211617
Revert "FEATURE: allow end users to opt out of getting any private messages"
...
This reverts commit 229ecc4f8a
2015-03-23 17:21:58 +11:00
229ecc4f8a
FEATURE: allow end users to opt out of getting any private messages
2015-03-23 15:50:45 +11:00
853c91d7d0
Merge pull request #3289 from fullfatthings/suppress_sso_welcome_emails
...
Add an sso option to suppress welcome emails
2015-03-23 10:36:58 +11:00
6d38005a22
Allow staff to change uneditable user fields
2015-03-20 15:18:43 -04:00
3c0fee1786
Fixes broken spec
2015-03-20 13:24:03 -04:00
e8648350eb
Add an sso option to suppress welcome emails
...
As discussed here: https://meta.discourse.org/t/create-new-sso-users-without-sending-welcome-emails/24894
2015-03-20 17:04:52 +00:00
5084e2bdf1
Merge pull request #3284 from techAPJ/patch-1
...
FEATURE: new site setting min_first_post_length
2015-03-19 19:55:27 +01:00
b706307ac7
FEATURE: new site setting min_first_post_length
2015-03-20 00:20:38 +05:30
7ef306cd3b
A bunch of tweaks to the Users directory
...
- Move user directory from `/directory` to `/users/`
- Defaults to 'weekly' time period
- Don't include deleted topics/posts in the results
- Move heart icon to header instead of on each row
- "Users" instead of "Users found"
2015-03-19 12:29:38 -04:00
3d2d224312
FEATURE: User Directory, with sorting and time period filter
2015-03-18 15:20:34 -04:00
89ea125c73
automatic need only be added once to the hash
2015-03-18 17:47:39 +11:00
4720d0c12b
Merge pull request #3277 from techAPJ/patch-1
...
FIX: return proper error message when replying to a closed or deleted topic
2015-03-17 07:38:00 +11:00
5d74cadf2f
FIX: picture would be hidden when [details] block was closed in the composer
2015-03-16 18:57:15 +01:00
484ae8b6b7
FIX: return proper error message when replying to a closed or deleted topic
2015-03-16 16:43:22 +05:30
Sam
Régis Hanol
Neil Lalonde
Paul Kaplan
Robin Ward
Arpit Jalan
Erick Guan
Luke Granger-Brown
Arthur Neves
Tan Le
Ben Hadley-Evans
Ed Gibbs
Dan Singerman