Joffrey JAFFEUX
666a4be888
UX: prevents mini tag chooser header to wrap ( #8858 )
2020-02-04 23:55:50 +01:00
Joffrey JAFFEUX
7fd5a8db72
UX: adds arrow navigation support to mini-tag-chooser ( #8857 )
2020-02-04 23:54:59 +01:00
Joffrey JAFFEUX
9252bbbd7d
FIX: prevents firefox to generate a click event on space ( #8856 )
2020-02-04 23:41:40 +01:00
dependabot-preview[bot]
0497d64849
Build(deps): Bump aws-partitions from 1.269.0 to 1.270.0 ( #8855 )
...
Bumps [aws-partitions](https://github.com/aws/aws-sdk-ruby ) from 1.269.0 to 1.270.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-partitions/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-04 16:13:31 -05:00
Kris
7ac81a6019
UX: Center titles in docked header when there aren't two rows
2020-02-04 13:40:28 -05:00
Joffrey JAFFEUX
2c2ab474a4
FIX: ensures tags-admin-dropdown is working correctly with sk2 ( #8852 )
2020-02-04 19:23:44 +01:00
Kris
35a1912e2d
FIX: Links in category box descriptions should be clickable
2020-02-04 13:02:55 -05:00
Rafael dos Santos Silva
f88fa99b0b
DEV: Fix web manifest short_title tests
2020-02-04 14:46:33 -03:00
Rafael dos Santos Silva
5ead60677a
FEATURE: Ensure we always fill the short_name in the web manifest
2020-02-04 14:16:00 -03:00
David Taylor
fec1c0f097
DEV: Handle null notification level when generating data attribute ( #8851 )
...
This happens in tests, but handling it properly will make the production code more robust. Followup to ebdebf152d
2020-02-04 17:05:49 +00:00
Penar Musaraj
095e3d8946
DEV: Autofilter combo boxes on 10+ dropdown items by default
2020-02-04 11:23:15 -05:00
Robin Ward
71312d9086
FIX: Labels were switched in the wizard for privacy options
2020-02-04 11:09:52 -05:00
David Taylor
ebdebf152d
DEV: Use a string for category data-notification-level, not an integer
...
This makes writing CSS to target specific notification levels more intuitive. Follow-up to 7640914552
2020-02-04 16:05:45 +00:00
Vinoth Kannan
dabba87954
DEV: introduce `diffLocalChangesUrl` attribute to `theme` model.
2020-02-04 21:33:19 +05:30
Mark VanLandingham
c8a02161dd
FIX: Warn users of overwriting new topic draft ( #8841 )
2020-02-04 09:59:56 -06:00
Mark VanLandingham
91b70f8ffc
FIX: Featured topic title on profile HTML parsed ( #8850 )
2020-02-04 09:33:46 -06:00
dependabot-preview[bot]
14758771c6
Build(deps): Bump msgpack from 1.3.1 to 1.3.2 ( #8843 )
...
Bumps [msgpack](https://github.com/msgpack/msgpack-ruby ) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/msgpack/msgpack-ruby/releases )
- [Changelog](https://github.com/msgpack/msgpack-ruby/blob/master/ChangeLog )
- [Commits](https://github.com/msgpack/msgpack-ruby/compare/v1.3.1...v1.3.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-04 10:29:42 -05:00
Joffrey JAFFEUX
14126e9a38
UX: do not display pinned option description on mobile ( #8846 )
2020-02-04 15:34:56 +01:00
Joffrey JAFFEUX
87e92da085
DEV: makes popper.js part of javascript rake task ( #8847 )
2020-02-04 15:34:46 +01:00
Joffrey JAFFEUX
ca63502ce6
UX: ensures pinned options icon is not on a new line ( #8845 )
2020-02-04 15:34:37 +01:00
Joffrey JAFFEUX
1d54e78311
FIX: prevents exception on /admin/badges page when model is not set ( #8849 )
...
Exception:
TypeError: Cannot read property 'badge_type_id' of null
2020-02-04 15:34:19 +01:00
Joffrey JAFFEUX
5d31f353f4
remove duplicated }} ( #8848 )
2020-02-04 15:02:40 +01:00
Gerhard Schlager
71849242fa
PERF: Speed up moving posts on large databases
...
Old exection plan:
```
Delete on post_replies pr (cost=6.59..20462.62 rows=2254 width=24) (actual time=2.580..2.580 rows=0 loops=1)
-> Nested Loop (cost=6.59..20462.62 rows=2254 width=24) (actual time=0.086..2.557 rows=4 loops=1)
Join Filter: (p.topic_id <> r.topic_id)
Rows Removed by Join Filter: 328
-> Nested Loop (cost=6.16..16845.77 rows=2254 width=26) (actual time=0.020..1.886 rows=332 loops=1)
-> Nested Loop (cost=5.74..13257.09 rows=2254 width=20) (actual time=0.016..1.361 rows=332 loops=1)
-> Seq Scan on moved_posts mp (cost=0.00..19.70 rows=970 width=10) (actual time=0.002..0.028 rows=263 loops=1)
-> Bitmap Heap Scan on post_replies pr (cost=5.74..13.63 rows=2 width=14) (actual time=0.004..0.005 rows=1 loops=263)
Recheck Cond: ((reply_post_id = mp.old_post_id) OR (post_id = mp.old_post_id))
Heap Blocks: exact=278
-> BitmapOr (cost=5.74..5.74 rows=2 width=0) (actual time=0.004..0.004 rows=0 loops=263)
-> Bitmap Index Scan on index_post_replies_on_reply_post_id (cost=0.00..2.87 rows=1 width=0) (actual time=0.001..0.001 rows=1 loops=263)
Index Cond: (reply_post_id = mp.old_post_id)
-> Bitmap Index Scan on index_post_replies_on_post_id_and_reply_post_id (cost=0.00..2.87 rows=1 width=0) (actual time=0.002..0.002 rows=1 loops=263)
Index Cond: (post_id = mp.old_post_id)
-> Index Scan using posts_pkey on posts p (cost=0.42..1.59 rows=1 width=14) (actual time=0.001..0.001 rows=1 loops=332)
Index Cond: (id = pr.post_id)
-> Index Scan using posts_pkey on posts r (cost=0.42..1.59 rows=1 width=14) (actual time=0.001..0.002 rows=1 loops=332)
Index Cond: (id = pr.reply_post_id)
Planning Time: 0.305 ms
Execution Time: 2.600 ms
```
New execution plan:
```
Delete on post_replies pr (cost=15.34..6538275.37 rows=364157 width=12) (actual time=1.961..1.961 rows=0 loops=1)
-> Nested Loop (cost=15.34..6538275.37 rows=364157 width=12) (actual time=0.048..1.827 rows=187 loops=1)
-> Seq Scan on moved_posts mp (cost=0.00..19.70 rows=970 width=10) (actual time=0.004..0.029 rows=188 loops=1)
-> Bitmap Heap Scan on post_replies pr (cost=15.34..6736.72 rows=375 width=14) (actual time=0.009..0.009 rows=1 loops=188)
Recheck Cond: ((reply_post_id = mp.old_post_id) OR (post_id = mp.old_post_id))
Filter: ((SubPlan 1) <> (SubPlan 2))
Heap Blocks: exact=187
-> BitmapOr (cost=15.34..15.34 rows=377 width=0) (actual time=0.003..0.003 rows=0 loops=188)
-> Bitmap Index Scan on index_post_replies_on_reply_post_id (cost=0.00..4.33 rows=1 width=0) (actual time=0.001..0.001 rows=1 loops=188)
Index Cond: (reply_post_id = mp.old_post_id)
-> Bitmap Index Scan on index_post_replies_on_post_id_and_reply_post_id (cost=0.00..10.82 rows=376 width=0) (actual time=0.001..0.001 rows=0 loops=188)
Index Cond: (post_id = mp.old_post_id)
SubPlan 1
-> Index Scan using posts_pkey on posts p (cost=0.43..8.45 rows=1 width=4) (actual time=0.002..0.002 rows=1 loops=187)
Index Cond: (id = pr.post_id)
SubPlan 2
-> Index Scan using posts_pkey on posts r (cost=0.43..8.45 rows=1 width=4) (actual time=0.002..0.003 rows=1 loops=187)
Index Cond: (id = pr.reply_post_id)
Planning Time: 0.136 ms
Execution Time: 1.990 ms
```
2020-02-04 12:30:43 +01:00
Gerhard Schlager
e84d88ddea
FIX: Email attachments with a size of 0 bytes caused error
2020-02-04 12:30:43 +01:00
Jarek Radosz
67d5ce8ed1
FIX: Sort out the route navigation in admin/email-style ( #8837 )
...
Previously it would go to the "html" page when refreshing on the "css" page, and would open an invalid empty-state page when trying to go to the "email style" tab when already on it.
2020-02-04 11:42:43 +01:00
Jarek Radosz
4ab696dd2f
DEV: Add the `@action` decorator ( #8836 )
...
This also enables`@action` use in plugin connectors.
Setting `actions` earlier allows `setupComponents` to use them, for example, when setting up event listeners.
2020-02-04 11:42:25 +01:00
Jarek Radosz
9a52a44d09
DEV: Add outlet args to `editor-preview` outlet ( #8835 )
...
Those are the same arguments that are passed into `after-d-editor` outlet. This will enable plugins that attach to editor preview to be conditionally enabled, usually only for the composer.
Plugins that will use this: discourse-canned-responses, discourse-zoom.
2020-02-04 11:41:45 +01:00
Vinoth Kannan
e4f3244141
DEV: introduce `updateUrl` attribute to `theme-setting-editor` component.
2020-02-04 15:19:17 +05:30
Robin Ward
14ae574bc5
DEV: Improve spec to use the constant length
2020-02-03 15:15:02 -05:00
Robin Ward
ee17138c0f
FIX: Better error messages when name is too long
...
Previously you'd get a server side generic error due to a password check
failing. Now the input element has a maxlength attribute and the server
side will respond with a nicer error message if the value is too long.
2020-02-03 14:14:32 -05:00
David Taylor
31775c996c
DEV: Remove redundant category list spec
...
The behavior has been deliberately changed in 7640914552
2020-02-03 19:01:24 +00:00
Penar Musaraj
375f4c09ce
FIX: Restore up/down icons in period-chooser
2020-02-03 13:56:58 -05:00
Robin Ward
37888d9818
FIX: Never return the same reply more than once via reply_ids
...
If our reply tree somehow ends up with cycles or other odd
structures, we only want to consider a reply once, at the first
level in the tree that it appears.
2020-02-03 13:41:18 -05:00
David Taylor
7640914552
UX: Include muted categories on the category page by default ( #8842 )
...
* DEV: Add data-notification-level attribute to category UI
* Show muted categories on the category page by default
This reverts commit ed9c21e42c
.
* Remove redundant spec - muted categories are now visible by default
2020-02-03 10:40:02 -08:00
Penar Musaraj
6301477b4c
FIX: Make dropdown custom user fields compatible with select-kit 2
2020-02-03 13:19:38 -05:00
Robin Ward
f83362b05b
FIX: Don't return post replies from other topics
...
It seems in some situations replies have been moved to other topics but
the `PostReply` table has not been updated. I will try and fix this in a
follow up PR, but for now this fix ensures that every time we ask a post
for its replies that we restrict it to the same topic.
2020-02-03 13:12:27 -05:00
Matt Marjanović
ad2aa7b52c
FEATURE: Add logout functionality to SSO Provider protocol ( #8816 )
...
This commit adds support for an optional "logout" parameter in the
payload of the /session/sso_provider endpoint. If an SSO Consumer
adds a "logout=true" parameter to the encoded/signed "sso" payload,
then Discourse will treat the request as a logout request instead
of an authentication request. The logout flow works something like
this:
* User requests logout at SSO-Consumer site (e.g., clicks "Log me out!"
on web browser).
* SSO-Consumer site does whatever it does to destroy User's session on
the SSO-Consumer site.
* SSO-Consumer then redirects browser to the Discourse sso_provider
endpoint, with a signed request bearing "logout=true" in addition
to the usual nonce and the "return_sso_url".
* Discourse destroys User's discourse session and redirects browser back
to the "return_sso_url".
* SSO-Consumer site does whatever it does --- notably, it cannot request
SSO credentials from Discourse without the User being prompted to login
again.
2020-02-03 12:53:14 -05:00
Stephen Chung
98e9302c26
Log error when optimized image file fails to store. ( #8840 )
2020-02-03 12:28:45 -05:00
dependabot-preview[bot]
a96eba9714
Build(deps): Bump rubyzip from 2.1.0 to 2.2.0 ( #8833 )
...
Bumps [rubyzip](https://github.com/rubyzip/rubyzip ) from 2.1.0 to 2.2.0.
- [Release notes](https://github.com/rubyzip/rubyzip/releases )
- [Changelog](https://github.com/rubyzip/rubyzip/blob/master/Changelog.md )
- [Commits](https://github.com/rubyzip/rubyzip/compare/v2.1.0...v2.2.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-03 12:11:41 -05:00
dependabot-preview[bot]
302774f0e9
Build(deps): Bump ffi from 1.12.1 to 1.12.2 ( #8831 )
...
Bumps [ffi](https://github.com/ffi/ffi ) from 1.12.1 to 1.12.2.
- [Release notes](https://github.com/ffi/ffi/releases )
- [Changelog](https://github.com/ffi/ffi/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ffi/ffi/compare/1.12.1...1.12.2 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-03 12:10:48 -05:00
dependabot-preview[bot]
335f63f8fd
Build(deps): Bump unicorn from 5.5.2 to 5.5.3 ( #8830 )
...
Bumps [unicorn](https://yhbt.net/unicorn/ ) from 5.5.2 to 5.5.3.
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-03 12:09:29 -05:00
dependabot-preview[bot]
16ae49eb95
Build(deps-dev): Bump parallel_tests from 2.30.1 to 2.31.0 ( #8829 )
...
Bumps [parallel_tests](https://github.com/grosser/parallel_tests ) from 2.30.1 to 2.31.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases )
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.30.1...v2.31.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-02-03 12:08:54 -05:00
Penar Musaraj
231617ff70
DEV: Rename deprecated "warning" icon to "exclamation-triangle"
2020-02-03 10:43:05 -05:00
Daniel Waterworth
7c7098c700
FIX: Off-by-one error setting the distributed mutex key to expire
...
Accounting for fractional seconds, a distributed mutex can be held for
almost a full second longer than its validity.
For example: if we grab the lock at 10.5 seconds passed the epoch with a
validity of 5 seconds, the lock would be released at 16 seconds passed
the epoch. However, in this case assuming that all other processing
takes a negligible amount of time, the key would be expired at 15.5
seconds passed the epoch.
Using expireat, the key is now expired exactly when the lock is released.
2020-02-03 14:54:50 +00:00
Arpit Jalan
e7a511fc7f
Bump onebox version.
...
- remove Douban onebox
- show map icon for Google Map composer preview
2020-02-03 18:57:38 +05:30
Joffrey JAFFEUX
0431942f3d
DEV: select-kit 2 ( #7998 )
...
This new iteration of select-kit focuses on following best principales and disallowing mutations inside select-kit components. A best effort has been made to avoid breaking changes, however if you content was a flat array, eg: ["foo", "bar"] You will need to set valueProperty=null and nameProperty=null on the component.
Also almost every component should have an `onChange` handler now to decide what to do with the updated data. **select-kit will not mutate your data by itself anymore**
2020-02-03 14:22:14 +01:00
Arpit Jalan
0e2cbee339
UX: add icon for Google Map onebox.
2020-02-03 18:12:42 +05:30
Dan Ungureanu
a2f8ac9aac
FIX: Check parameter types
...
/u/is_local_username used to throw a 500 error
2020-02-03 12:36:08 +02:00
Martin Brennan
baca59c1a6
Merge branch 'master' of github.com:discourse/discourse
2020-02-03 15:13:33 +10:00
Martin Brennan
89cb8f769a
Remove redundant spec in TopicConverter
...
* the spec to check if changing the topic between PM and
public to see if the upload security status is changed
is already covered extensively in topic_upload_security_manager_spec.rb
2020-02-03 15:08:11 +10:00