a5a229598d
missed a spot
2013-06-07 09:17:34 +10:00
564d242832
Notify moderators when someone is automatically blocked because of spam flags
2013-06-06 18:49:19 -04:00
11afa0c11b
work in progress migrate to moment
2013-06-07 08:49:22 +10:00
a151bfc7ec
Store when a topic was first set to auto-close and report that amount of time when it closes. And do some refactoring.
2013-06-06 17:04:21 -04:00
62041da7e0
Handle /t/only-the-slug urls by trying to find the topic by slug (second try)
2013-06-06 14:41:37 -04:00
b062b4a98e
Unapproved users should not receive digest emails. Fixes #974
2013-06-06 11:45:18 -04:00
bac03a3369
Merge pull request #975 from jd-erreape/username_refactor
...
[WIP] Refactored user_name suggestion methods into a module
2013-06-06 08:12:29 -07:00
96d23ddd8d
Refactored user_name suggestion methods into a module to reduce the complexity of User model
2013-06-06 16:40:10 +02:00
0d01c33482
Enabled strong_parameters across all models/controllers.
...
All models are now using ActiveModel::ForbiddenAttributesProtection, which shifts the responsibility for parameter whitelisting for mass-assignments from the model to the controller. attr_accessible has been disabled and removed as this functionality replaces that.
The require_parameters method in the ApplicationController has been removed in favor of strong_parameters' #require method.
It is important to note that there is still some refactoring required to get all parameters to pass through #require and #permit so that we can guarantee that parameter values are scalar. Currently strong_parameters, in most cases, is only being utilized to require parameters and to whitelist the few places that do mass-assignments.
2013-06-06 00:30:59 -07:00
a3d62fdf69
Temporarily roll back ember rc5. We identified some things we need to fix.
2013-06-06 01:25:43 -04:00
2ca734c118
Merge pull request #964 from chrishunt/exclusive-club
...
Add 'invite only' site setting
2013-06-05 16:38:47 -07:00
6384518599
Allow images in the daily digest for top scoring posts
2013-06-05 18:55:27 -04:00
0b97ea6345
Better HTML emails, smarter email digests, new email section in admin with digest preview
2013-06-05 17:47:25 -04:00
f030d9b420
Make default_logo_check more smarter
2013-06-05 16:59:19 -04:00
4e8ff74b99
Show dashboard warning when favicon and/or logo urls contain the same filename as the shipped defaults
2013-06-05 16:43:39 -04:00
b55182b983
Use PostDestroyer when deleting all of a user's posts; deleting a post removes its flags and resets its flag counts
2013-06-05 16:05:13 -04:00
dfba2b6e0a
FIX: Strip links from google indexed bios when the users are new.
2013-06-05 15:28:10 -04:00
729e4080a6
Merge pull request #958 from ZogStriP/fix-have-onebox-ignore-internal-links
...
FIX: Have onebox ignore internal links
2013-06-05 12:09:53 -07:00
112d57e899
Merge pull request #960 from iancmyers/strong-parameters
...
Began implementing strong_parameters
2013-06-05 12:03:17 -07:00
01855b70b4
FIX: Have onebox ignore internal links
2013-06-05 20:53:07 +02:00
acf147ef88
Disable OmniAuth account creation if 'invite only'
2013-06-05 11:11:02 -07:00
d432798ff8
Silently fail if user tries to sneak in
...
When 'invite only' is enabled, there's no way for a user to create an
account unless they try and sneak in by POSTing to /users/. We will
silently fail if this happens.
2013-06-05 11:08:21 -07:00
a0bd51862e
Upgrade Ember to RC5. Disabled a deprecation warning that I believe is in error.
2013-06-05 12:07:18 -04:00
41528f5d11
Implemented strong_parameters for Upload/UploadsController.
...
The topic_id param is now required using strong_parameters' #require method. If the parameter is missing ActionController::ParameterMissing will be raised instead of Discourse::InvalidParameters.
2013-06-05 00:55:55 -07:00
f50b648844
Implemented strong_parameters for PostAction/PostActionsController.
...
PostActionsController now uses strong_parameters' #require to require certain parameters. ActionController::ParameterMissing is now thrown when a reqired parameter is missing, rather than Discourse::InvalidParameters.
2013-06-05 00:23:51 -07:00
3b245031a4
Implemented strong_parameters for Invite/InvitesController.
...
The email parameter is now required using strong parameters and will throw ActionController::ParameterMissing if it is missing. If the email address is incorrect or invalid, Discourse::InvalidParameters will still be thrown.
2013-06-05 00:04:03 -07:00
130d837952
Implemented strong_parameters for Category/CategoriesController.
...
Category now requires parameters to be permitted by strong_parameters using #require or #permit for mass-assignment. Missing required parameters now throw a ActionController::ParameterMissing execption instead of the Discourse::InvalidParameters execption.
2013-06-04 23:45:25 -07:00
870e59883b
secure the links on the topic pages, eliminated deleted topics as well.
2013-06-05 16:10:26 +10:00
74502172f3
speed up test
2013-06-05 12:48:34 +10:00
9a57aaaaa9
fix encoding for category excerpt
...
fix missing secure category topics in categories page
2013-06-05 11:22:47 +10:00
21b3359ea4
Merge pull request #957 from chrishunt/chrishunt/lock-down-the-base
...
Add 'login required' site setting
2013-06-04 17:22:08 -07:00
56ee7cdc1f
Merge pull request #956 from ZogStriP/fix-image-upload-to-s3
...
fix image uploads on s3/imgur
2013-06-04 16:34:42 -07:00
5f85aaee1d
correct message bus regression
...
implement automatically updating dates in list
2013-06-05 09:32:44 +10:00
978785720a
Redirect to root after login if no path provided
...
If we do not do this, then people that login from /login will just be
redirected back to the login page. We'd rather have them see the root
path.
2013-06-04 16:10:10 -07:00
92a4828f72
Redirect all controllers to login if required
...
We want to skip the filter for sessions controller so that we can login
and we want to skip the filter for static pages because those should be
visible to visitors.
2013-06-04 16:10:10 -07:00
e3e55d4dad
fix image uploads on s3/imgur
2013-06-05 00:35:42 +02:00
2465c9c724
Add min_private_message_title_length site setting so private messages can have short titles
2013-06-04 17:59:23 -04:00
4392a17b54
Strip out links when displaying a new user's bio
2013-06-04 12:06:25 -04:00
c4904aacc0
Automatically flag someone as a spammer if their posts get at least X spam flags from N users while their trust level is 'new user'. Staff can clear and set this status from the user record in admin.
2013-06-03 16:37:40 -04:00
ef976ba891
fix pending tests
2013-06-03 17:07:44 +10:00
8b69ee26ff
forking in passenger was bust, message bus subscriptions would stop working after fork
2013-06-03 16:50:30 +10:00
da22c0f359
omit single quotes from slug
2013-06-03 09:08:34 +10:00
cab3502c15
Replace PostAnalyser module with a class
...
Encapsulate Post#cooked_document as well
Include specs for PostAnalyzer class
2013-06-01 14:59:27 +02:00
545dbfc07e
New Feature: Staff can choose to "Take Action" when flagging to immediately reach hiding
...
thresholds.
2013-05-31 17:39:32 -04:00
d23ef1d090
FIX: You could update a topic to have a title that's too short if the TextCleaner
...
removed extra characters. Additionally, updating the title will not return an error
message to the client app if the operation fails (rather than failing silently.)
2013-05-31 15:24:13 -04:00
9ba25b2b61
Merge pull request #934 from ZogStriP/fix-upload-specs
...
Fix upload specs
2013-05-31 09:56:45 -07:00
e0dae88885
remove specs for redirect_to_show, i'll figure out how to do this properly later
2013-05-31 12:10:07 -04:00
bf6b846c0b
Fix upload specs
2013-05-31 17:51:22 +02:00
d00ba60ad3
file is uploaded but hash is not matching ... why?
2013-05-31 15:04:01 +10:00
41187a5de1
Merge pull request #931 from ZogStriP/more-file-upload-test-coverage
...
added more file uploads test for better coverage
2013-05-30 21:36:33 -07:00
037cbfd648
Merge pull request #926 from netzpirat/fix-s3-images
...
Don't append the base url to absolute image urls without protocol.
2013-05-30 21:33:37 -07:00
e5f8297670
Merge pull request #928 from jd-erreape/master
...
Refactored some class methods to scopes in order to achieve a better 'Rails way'
2013-05-30 21:31:53 -07:00
d6d3f74405
Merge pull request #901 from xtream/master
...
Refactored AvatarLookup
2013-05-30 21:30:39 -07:00
6cc0f8f2d4
added more file uploads test for better coverage
2013-05-31 03:13:37 +02:00
807f763fb0
Merge remote-tracking branch 'upstream/master'
2013-05-30 21:42:26 +02:00
24e32092e7
Refactored two class methods into scopes (to achieve a better 'rails way')
...
Also added some tests to the methods
2013-05-30 21:21:31 +02:00
b82a5dfd56
Move logic to reject slugs that are just numbers into the slug module
2013-05-30 11:54:02 -04:00
d2e45cb8fd
Don't append the base url to absolute image urls without protocol.
2013-05-30 17:17:07 +02:00
7d5c313456
Don't allow category slugs that are numbers
2013-05-30 11:09:09 -04:00
5d444be72b
Support incomplete topic urls like /t/just-a-slug; fix error when using route /t/:topic_id/:post_number
2013-05-30 10:39:15 -04:00
5d2a6e3994
refactored and tested AvatarLookup
...
less array copying
Avoid N queries
2013-05-30 11:04:05 +02:00
8874c9ea75
Add message format support that can be used on complex localization strings
...
Add message about new and unread topics at the bottom of topics
move localization helper into lib
2013-05-30 16:49:57 +10:00
e93b7a3b20
more progress towards live unread and new counts, unread message implemented, still to implement delete messages
2013-05-30 16:49:57 +10:00
73834370a5
work in progress, live unread and new counts
2013-05-30 16:49:57 +10:00
8182a9d10c
Merge pull request #918 from chrishunt/chrishunt/quiet-tests-please
...
Clean up test output
2013-05-29 12:17:04 -07:00
3d0587d8ce
Refactor: move category slug helper to Category model
2013-05-29 14:18:02 -04:00
6abd9ddd2d
Add warning on admin dashboard if production env is configured to send email through gmail
2013-05-29 14:00:35 -04:00
e94e9b7621
Set UTF-8 charset for plain text email part
2013-05-29 09:54:36 -07:00
46a5066aed
Set SeedFu to quiet mode. No talking please.
2013-05-29 09:36:51 -07:00
46389754d6
Merge pull request #892 from eriko/cas_support
...
Cas support
2013-05-28 16:13:29 -07:00
8d47f92c27
Merge pull request #908 from chrishunt/chrishunt/extract-topic-status-update
...
Extract topic status update
2013-05-28 10:00:49 -07:00
feb966a1cf
Fixed jasmine specs that relied on old Discourse user api.
2013-05-28 12:09:03 -04:00
be234a2bc7
Add test to verify autoclose moderator post
2013-05-27 18:02:15 -07:00
c32399a80b
added test condition that fails with latest AM serializer
2013-05-28 10:42:04 +10:00
197909246c
Weigh staff likes higher when calculating scores. New site setting: `staff_like_weight`
...
can set the factor (default is 3)
2013-05-27 12:46:08 -04:00
e1781240a6
Merge branch 'refactoring' of git://github.com/mattvanhorn/discourse
...
Conflicts:
lib/text_sentinel.rb
2013-05-27 10:42:20 -04:00
a15910ad1e
Merge pull request #899 from chrishunt/chrishunt/extract-topic-posters-summary
...
Extract topic posters summary
2013-05-27 06:30:58 -07:00
bf16b4f381
Merge pull request #903 from chrishunt/chrishunt/extract-post-move
...
Extract post move
2013-05-26 19:10:50 -07:00
661ddbb158
introduce strong_parameters
2013-05-27 11:06:09 +10:00
d84ae80074
Simplify user action make it more idiomatic
2013-05-27 10:22:37 +10:00
13c4266c74
Allow Chinese characters in Topic titles
2013-05-26 13:56:42 -07:00
1ba18318ac
Add test to verify posts are moved in transaction
2013-05-25 17:44:32 -07:00
d5958f8779
Sliding window rate limiting
...
Switched the algorithm to use a circular buffer
based on a redis list
2013-05-25 12:37:28 -07:00
c1841a6c89
Extract Topic#posters_summary
2013-05-24 15:33:45 -07:00
d7817cf314
extract TopicNotifier class from topic
2013-05-24 13:36:33 -07:00
1313c0f094
FIX: When using a search context, *prefer* the context's results, don't restrict to only them.
2013-05-24 16:17:09 -04:00
d1fdc66ca4
FIX: For spam detection, don't count total occurances of links of the same host, but
...
post count including that host.
2013-05-24 15:20:58 -04:00
bd779834e5
Use search context for filtering search results by current category or user
2013-05-24 14:04:26 -04:00
84bc798afa
Merge pull request #891 from GlitchMr/iPhone-casing
...
Thread title fixer should ignore special cases like iLetter
2013-05-24 07:02:34 -07:00
9926b0dbc8
staff styling
2013-05-24 13:32:41 +10:00
ca2dee52db
moved comments to the bottom, they are way less intrusive there
2013-05-24 12:48:32 +10:00
1575ce7b10
add cas support with a few tests
2013-05-23 13:40:50 -07:00
8bc4264c98
Thread title fixer should ignore special cases like iLetter
2013-05-23 21:31:08 +02:00
8e8d9af2bf
Use classes instead of a complicated nested hash for search results
2013-05-23 12:44:47 -04:00
4492d06a9f
Don't send notifications for moderator action posts
2013-05-23 11:42:52 -04:00
0bd61df34c
Merge pull request #884 from mattvanhorn/refactor_topic
...
Refactor topic
2013-05-23 07:26:22 -07:00
24c25895f0
remove unnecessary title quality tests from topic
2013-05-22 22:56:27 -07:00
806255b3c4
refactor Topic validation
...
introduce a couple of custom validators
fix minor discrepancies in tests
copy I18n error message keys to default location
clean up validation invocation
move some responsibilities out of validator into class
2013-05-22 22:31:52 -07:00
fcc7192fd2
User tracking state implementation progress for live unread / new counts
2013-05-23 15:22:06 +10:00
7a31630837
Search Refactor: Remove some manual SQL, make search data tables more idomatic Rails/AR
2013-05-22 16:31:13 -04:00
b9a310f4b1
Search Refactor: Let's use a class to keep track of our state rather
...
than passing params everywhere. Also make the private API private.
2013-05-22 15:22:06 -04:00
872995db57
refactor guardian class for clarity & correctness
...
introduce NullUser to avoid type-checking
DRY up code
reduce number of multiple returns
remove some redundant/impossible logic branches
add pending test for possible bug
add test & fix for ability to flag archived posts
add #secure_category? method to topic class
Fix bug that prevented flagging of archived topics
Rename NullUser to AnonymousUser
DRY up can_<action>? methods
Fix some ownership logic, and a test, for Guardian
2013-05-22 01:09:34 -07:00
96f8d79e83
Merge pull request #876 from chrishunt/chrishunt/observe-changes-for-topic-users
...
Trigger UserActionObserver when updating TopicUser
2013-05-21 23:02:27 -07:00
da6a88634b
improve best filter so it properly excludes all admin messages from count as well
2013-05-22 15:14:47 +10:00
c4d8085fc5
remove moderator status posts from best feed
2013-05-22 15:04:53 +10:00
d0bc8c95d3
Trigger UserActionObserver when tracking visit
2013-05-21 20:45:03 -07:00
685f4960f1
Trigger UserActionObserver when updating TopicUser
2013-05-21 20:43:43 -07:00
c22435562d
fix small typo in search_spec
2013-05-21 05:56:04 -03:00
b5eff93a9d
update message bus to support per client filtering
...
start work on user_tracking_state
fix can_ban? in guardian
expose protected scopes on topic_query we need
move guardian spec to use build as opposed to creating topics / posts / users
start work on user tracking spec
2013-05-21 16:39:51 +10:00
e91ed83586
the private message stream is different to normal streams, improving the ui a bit and collapsing conversations
2013-05-20 16:44:06 +10:00
80fb20816c
get rid of nonsense 404.html
...
correct 404 handling for invalid pages
2013-05-20 10:29:49 +10:00
18b00d01d0
Merge pull request #859 from lengarvey/user_refactoring
...
Light refactoring of the User model
2013-05-19 16:41:20 -07:00
24c997966e
Merge pull request #861 from sanderdatema/post_creator
...
Set created_at manually through PostCreator
2013-05-19 16:34:45 -07:00
fb4e5973db
Fix spelling mistake in spec doc
2013-05-18 13:11:34 -07:00
c2a4f16f24
Show posts for last page when page out of range
2013-05-18 13:11:01 -07:00
286a06bd4e
Set created_at manually through PostCreator
2013-05-18 21:24:29 +02:00
3de632f892
Added a spec for staff? and regular?
2013-05-18 18:07:07 +10:00
f3282e33a3
Add tabs to category create/edit modal. Categories can have a default auto-close setting that applies to all new topics created in the category. Add rspec-given and write some integration tests. Tests for topic auto-close with category default
2013-05-17 11:05:35 -04:00
a80ec535a3
Support for "Select All / Deselect All" while selecting posts to merge / delete.
2013-05-16 16:50:38 -04:00
d554a59102
Support for a new site setting: `newuser_spam_host_threshold`. If a new user posts a link
...
to the same host enough tiles, they will not be able to post the same link again.
Additionally, the site will flag all their previous posts with links as spam and they will
be instantly hidden via the auto hide workflow.
2013-05-16 12:19:50 -04:00
04b8cd5c95
consistency check, need to also ensure delete cleans stuff up, maybe make notifications trashable
2013-05-16 17:50:14 +10:00
eb71e9de24
opening move, don't get rid of green notification till the pm is read
...
TODO a way to list all unread PMs
2013-05-16 16:37:47 +10:00
e9ebadb414
Nuke message_bus_observer move to service class and classes
...
Secure all messages triggered by post creation and all user actions so they don't leak
(meaning, if you have a browser open and secure topics are created you will only get them if you are allowed to see them)
2013-05-16 15:03:16 +10:00
27dfb7a948
FIX: @username mentions when there are multiple code blocks in a post.
...
Meta: [All of my internal users show as coming from 127.0.0.1!](http://meta.discourse.org/t/all-of-my-internal-users-show-as-coming-from-127-0-0-1/6607 )
This fixes the regular expression used to identify @ inside <code> or <pre> blocks in the `postConversion` hook.
2013-05-16 01:59:07 +02:00
dadb7eaa23
fix crash caused by incorrect query in scope
...
setting all categories to be secured led to a blank screen on all pages
use stabby lambda for consistency in class
make the test a little more concise
- move the local assignments into let blocks for
reusability
- remove calls to `to_a`, which aren't needed
- use 'be_empty' instead of '[]' to be consistent
with the other matchers in the test
add a test for the `secured` scope with multiple
secured categories
2013-05-15 22:26:52 +01:00
ef98b60184
disable observers in tests, enable as needed, tests are 20% faster
2013-05-14 11:59:55 +10:00
fff46cf5aa
Can search by URL or ID
2013-05-13 17:07:58 -04:00
be234ce9b9
You can now 'move' the first post of a topic to another topic as a merge. In that
...
case, the first post is cloned instead of being deleted from the original topic.
2013-05-13 14:07:31 -04:00
9828c87525
Topic Auto-Close: admins and mods can set a topic to automatically close after a number of days
2013-05-13 12:53:52 -04:00
b6bf95e741
speed up startup (avoid loading some gems on startup)
...
correct group permission leaks
add Discourse.cache for richer caching support
2013-05-13 18:04:03 +10:00
9b33e826f2
clear flags on reply to notify moderators
2013-05-13 11:48:01 +10:00
98d9f174ae
fix spec
2013-05-13 11:07:22 +10:00
30501e943c
fix search
2013-05-13 11:07:21 +10:00
cf01c98d81
Experimental: Interface to Move Posts to an Existing Topic
2013-05-10 14:55:51 -04:00
297680c28d
FIX: pinned topic excerpt is not properly truncated
2013-05-10 12:28:17 +02:00
942f168ab6
UI still a tad rough, but we have a first pass of secure categories
2013-05-10 16:47:47 +10:00
5280b3a01b
more group progress, UI getting there, controller mostly done
...
changed it so notify moderators goes to the moderators group
allow admins to grant self moderation and revoke self moderation
2013-05-09 17:37:34 +10:00
4f328e3e45
+x on files makes no sense unless they really are executable
...
rails in the script dir makes no sense, use binstubs or bundler instead
2013-05-09 17:35:15 +10:00
0f0fd281a8
group progress, never email banned users
2013-05-09 11:34:58 +10:00
6b536dcde5
work in progress ... groups
2013-05-08 15:20:38 +10:00
7571152d1d
fix issue adding users to groups
2013-05-08 10:32:29 +10:00
6843ba7ed6
Fix regression: default to JSON type on GET requests.
2013-05-07 17:17:21 -04:00
f9a82f3aa0
Add a spec for category list with empty category
2013-05-07 15:52:45 -04:00
8e24a608b0
Show empty categories on categories page to people people who can edit and delete categories
2013-05-07 15:31:56 -04:00
e9fc272db7
remove acts_as_paranoid, use .trash! , .recover! and .with_deleted as needed
...
makes upgrading to rails 4 possible
2013-05-07 14:39:01 +10:00
69be7d0ad1
Change the title Visits to Clicks in referral tables on admin dashboard
2013-05-06 11:56:35 -04:00
be1ab8b275
automatic group infrustructure
2013-05-06 14:49:56 +10:00
392b9696f4
prevent duplicate actions on a post
2013-05-04 02:52:45 +02:00
3eab0be4a8
deleting posts as an admin was bust
2013-05-03 17:56:23 +10:00
5ec52bd2e9
:s/moderator?/staff/g ... our naming was kind of crazy, renamed moderator? to staff
2013-05-02 17:22:27 +10:00
Sam
Neil Lalonde
Robin Ward
Juan de Dios Herrero
Ian Christian Myers
Régis Hanol
Chris Hunt
Navin
DI2uNk
Michael Kessler
Victor Cruz Dueñas
Matt Van Horn
Erik Ordway
Konrad Borowski
Jason Kriss
Sander Datema
Leonard Garvey
Lee Machin