Commit Graph

1567 Commits

Author SHA1 Message Date
Joffrey JAFFEUX edf26a0931
uses emoji version for tests (#6277) 2018-08-16 14:06:56 +02:00
Gerhard Schlager 448e95b97d UX: Show anchor icon instead of text when topic bump is disabled 2018-08-11 21:51:13 +02:00
Gerhard Schlager ef4b9f98c1 FEATURE: Allow admins to reply without topic bump 2018-08-10 10:48:30 +10:00
Neil Lalonde f7b4a2b3ba FIX: ensure URLs include subfolder in admin emails UI 2018-08-08 16:48:03 -04:00
Joffrey JAFFEUX 7f2f3b8b22
FIX: improves reports resilience (#6239)
This commit makes most of the reports now lazy loaded, and making them benefits from graceful failures.
2018-08-06 16:57:40 -04:00
Joffrey JAFFEUX c301111461
FIX: display select kit body if no choices (#6237) 2018-08-06 11:22:48 -04:00
David Taylor 812add18bd REFACTOR: Serve auth provider information in the site serializer.
At the moment core providers are hard-coded in Javascript, and plugin providers get added to the JS payload at compile time. This refactor means that we only ship enabled providers to the client.
2018-08-06 09:25:48 +01:00
Joffrey JAFFEUX 066010db7d
FEATURE: introduces list/compact_list components 2018-08-03 16:41:37 -04:00
Joffrey JAFFEUX 9073e11943
FIX: improves number/percent support in reports 2018-08-01 18:40:59 -04:00
Penar Musaraj 1f45215537 FEATURE: Drafts view in user profile
* add drafts.json endpoint, user profile tab with drafts stream

* improve drafts stream display in user profile

* truncate excerpts in drafts list, better handling for resume draft action

* improve draft stream SQL query, add rspec tests

* if composer is open, quietly close it when user opens another draft from drafts stream; load PM draft only when user is in /u/username/messages (instead of /u/username)

* cleanup

* linting fixes

* apply prettier styling to modified files

* add client tests for drafts, includes a fixture for drafts.json

* improvements to code following review

* refresh drafts route when user deletes a draft open in the composer while being in the drafts route; minor prettier scss fix

* added more spec tests, deleted an acceptance test for removing drafts that was too finicky, formatting and code style fixes, added appEvent for draft:destroyed

* prettier, eslint fixes

* use "username_lower" from users table, added error handling for rejected promises

* adds guardian spec for can_see_drafts, adds improvements following code review

* move DraftsController spec to its own file

* fix failing drafts qunit test, use getOwner instead of deprecated this.container

* limit test fixture for draft.json testing to new_topic request only
2018-08-01 16:34:54 +10:00
Guo Xiang Tan b6939093eb Fix JS tests. 2018-08-01 11:21:46 +08:00
Joffrey JAFFEUX 2b2a506a7b
FIX: makes dashboard more resilient to errors (#6217)
This commit is an attempt to limit cases where the dashboard will generate a full exception page and also make it easier to track the error.
2018-07-31 21:23:28 -04:00
Joffrey JAFFEUX 0715aa18da
UI: uses tiny avatars for reports (#6215) 2018-07-31 18:57:00 -04:00
Joffrey JAFFEUX 37252c1a5e
UI: improves dashboard table reports
- support for avatars
- support for topic/post/user type in reports
- improved totals row UI
- minor css tweaks
2018-07-31 17:35:13 -04:00
Vinoth Kannan ece3cb73df Rename humburger_menu_categories_count site setting to header_dropdown_category_count 2018-07-31 09:12:30 +05:30
Vinoth Kannan b852275ced Test method for site categories random order fix 2018-07-31 01:36:37 +05:30
Vinoth Kannan c54b5824d4 REFACTOR: Prioritize unread categories in hamburger menu 2018-07-30 20:20:10 +05:30
Maja Komel c7c84606d9 fix prettier offense 2018-07-30 12:43:10 +02:00
Maja Komel 04baddf731 DEV: migrate tests to async/await 2018-07-30 12:21:05 +02:00
Vinoth Kannan 249b16e8e3 FIX: Hide muted categories from hamburger menu top categories block 2018-07-30 15:37:41 +05:30
Vinoth Kannan 78d91b1daf
UX: Changes in top categories of hamburger menu (#6200) 2018-07-30 14:13:00 +05:30
Arpit Jalan fc3b904e1f remove "track external right clicks" feature 2018-07-29 15:01:33 +05:30
Vinoth Kannan dac29b5ebc
UX: Display only top categories in hamburger menu (#6146) 2018-07-27 12:11:07 +05:30
Joffrey JAFFEUX 330cf78c83
FIX: don’t break browser history on dashboard visit (#6186) 2018-07-26 14:59:28 -04:00
Maja Komel a89dd51cae DEV: migrate acceptance tests to async/await 2018-07-26 12:51:16 +02:00
Kyle Zhao 1ed3a89ac9 UX: clear topic timer text when manually closing/opening (#6123)
* UX: clear topic timer text when manually closing/opening

* added test for clearing topic timer status text
2018-07-26 11:48:38 +10:00
Joffrey JAFFEUX ad95c24307
FEATURE: displays a notice if report has no data (#6178) 2018-07-25 14:28:41 -04:00
Régis Hanol 637850d867 REFACTOR: new 'show-avatar-select' app event to trigger the avatar selector modal 2018-07-25 12:38:15 +02:00
Dan Ungureanu 44a5c29d42 Clear old text and URL when showing up the "Insert Hyperink" modal. (#6138) 2018-07-25 17:12:49 +10:00
Maja Komel 3a52c2fa64 DEV: migrate widgets tests to async/await 2018-07-24 23:22:03 +02:00
Maja Komel d16a2c776a DEV: migrate components tests to async/await 2018-07-24 22:41:14 +02:00
Sam 95720e3873 lint files 2018-07-24 10:57:16 +10:00
Kyle Zhao c9d4288214 UX: auto fix order when reordering categories (#6149)
* set correct position number when moving up/down

* UX: drop 'fix order' and auto re-order subcategory

- auto "fix position" on save
- place subcategories after parent category and maintain the relative
positions on save
2018-07-24 10:25:40 +10:00
David Taylor eda1462b3b
FEATURE: List, revoke and reconnect associated accounts. Phase 1 (#6099)
Listing connections is supported for all built-in auth providers. Revoke and reconnect is currently only implemented for Facebook.
2018-07-23 16:51:57 +01:00
Joffrey JAFFEUX 9ed4071713
fixes dashboard next spec (#6132) 2018-07-21 10:29:58 -04:00
Guo Xiang Tan 863de8cb76 Make prettier happy. 2018-07-21 18:03:39 +08:00
Guo Xiang Tan 096e8ee21c Disable broken JS test for now. 2018-07-21 17:48:20 +08:00
Arpit Jalan 44e7f63d65 temporarily disable test for new-topic page 2018-07-20 17:49:16 +05:30
Joffrey JAFFEUX 194844fc66
fixes tests 2018-07-19 14:44:42 -04:00
Joffrey JAFFEUX 1a78e12f4e
FEATURE: part 2 of dashboard improvements
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports

Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
Maja Komel 73739060f3
DEV: migrate acceptance tests to async await - plugin, reports, user, topic 2018-07-19 16:40:12 +02:00
Maja Komel 2e96646659 DEV: migrate acceptance tests to async await - invite, login, mobile 2018-07-19 16:38:37 +02:00
Joffrey JAFFEUX a2281fbb19
FEATURE: allows to jump to a date in a topic 2018-07-19 16:00:13 +02:00
Maja Komel 7f7944bc3a DEV: migrate acceptance tests to async await - dashboard, emoji, group 2018-07-19 14:00:03 +02:00
Maja Komel e36d1c72f1 DEV: migrate acceptance tests to async await - badges, category, composer, customHTML 2018-07-19 13:52:48 +02:00
Maja Komel 6aa2eb19d4 DEV: migrate acceptance tests to async await - admin, about, account created (#6111) 2018-07-19 17:35:10 +08:00
Maja Komel fa38891a98 FEATURE: show modal when user without permissions tries to delete their own topic (#6086) 2018-07-18 23:31:37 +02:00
Neil Lalonde afc94ac9e4 FEATURE: add a Top Categories section to the user summary page, showing the categories in which a user has the most activity 2018-07-18 16:39:16 -04:00
Régis Hanol f55ac892e4 make code prettier 🎀 2018-07-18 13:09:16 +02:00
Régis Hanol 6d6e026e3c FEATURE: selectable avatars 2018-07-18 12:57:43 +02:00
Philipp Rudloff 79b08b2679 Set result.target for update (matching _saveNew) (#6094)
* Set result.target for update (matching _saveNew)

* Add tests for update result including a target property
2018-07-17 11:56:32 -04:00
Sam e7102c73fb correct test and move to async 2018-07-17 09:10:55 +10:00
Sam ac0053f491 FEATURE: navigate to first post and auto bump category settings
### navigate_to_first_post_after_read setting for categories

When enabled on categories logged on users will return to OP after
reading the entire category. (useful for documentation categories)

### num_auto_bump_daily

Set a number of topics that will automatically bump daily on a category.

- Every 15 minutes we will check if any category has this setting
- Categories with the setting are shuffled
- We exclude pinned, closed, category description and archived topics
- Maximum of 1 topic for the list of categories is bumped till limit reached per category
- We always try to bump oldest first
- Limit is elastic using a RateLimiter that ensures that we only bump N per day

Also some minor organisation on category settings

Froze strings on category.rb
2018-07-16 18:10:35 +10:00
Guo Xiang Tan 767395449f Make prettier happy. 2018-07-16 11:31:23 +08:00
Leo McArdle 21ebb1cd54 FEATURE: Secondary emails support. 2018-07-16 11:09:49 +08:00
Neil Lalonde 8ceed642cb FIX: wrong url for default logos in header on subfolder installs 2018-07-13 14:21:15 -04:00
Guo Xiang Tan 711371e8c8 FIX: Select+below will ask server for post ids on megatopics. 2018-07-13 15:10:39 +08:00
Guo Xiang Tan 409a30ce1c FIX: Selecting & moving posts not working on megatopics. 2018-07-13 11:16:43 +08:00
Guo Xiang Tan 18e281606a UX: Clicking admin menu does not hide select posts box. 2018-07-13 10:56:14 +08:00
Sam 1f0bbca87e FIX: on initial load category subcategories were not mapped correctly 2018-07-12 17:59:56 +10:00
Guo Xiang Tan 258e9e35ca PERF: Make mega topics work without a stream.
There are tradeoffs that we took here. For the complete
story see
https://meta.discourse.org/t/performance-improvements-on-long-topics/30187/27?u=tgxworld.
2018-07-12 12:46:12 +08:00
OsamaSayegh f13a7226db FIX: display tables in posts history diff (#6032) 2018-07-12 14:13:52 +10:00
Guo Xiang Tan 8f4cb1a742 UX: Timeline lookup on mega topics should use date of current post. 2018-07-10 16:43:20 +08:00
Sam d9a9682f72 FIX: also count sub categories in hamburger when needed
previously there were cases where we suppress subcategories yet don't count them
this leads to confusion
2018-07-09 16:52:55 +10:00
Maja Komel 7cba4cbcc6 FEATURE: allow selecting a tag when moving posts to a new topic (#6074) 2018-07-06 18:21:00 +02:00
Joe 98478d78d7
FIX: update test to match new admin layout 2018-07-03 17:03:43 +08:00
Joe 9834263687
FIX: update test to match admin layout changes 2018-07-03 16:28:57 +08:00
Joffrey JAFFEUX c754ece8f5
FEATURE: drops with-email-link and replaces it by with-email-button 2018-07-02 14:35:50 +02:00
Maja Komel 3ddfc12307 unify user preferences views 2018-07-02 15:38:36 +10:00
Guo Xiang Tan d1c3eb6bfa FIX: Recovering a post does not insert it back into the stream correctly. 2018-06-29 11:41:44 +08:00
Joffrey JAFFEUX 9f4e814dbc
tests for XSS injection in tooltips 2018-06-28 14:24:21 +02:00
Maja Komel ec3e6a81a4 FEATURE: Second factor backup 2018-06-28 10:12:32 +02:00
Jeff Atwood 7dce8290ed copyedit on category drop down 2018-06-26 12:43:45 -07:00
OsamaSayegh d81f8ea378
fix prettier 2018-06-26 15:31:43 +03:00
OsamaSayegh bfe0178270 FIX: use the correct notification levels titles for PMs 2018-06-26 14:01:52 +02:00
Joffrey JAFFEUX eb9b99e519
FIX: makes select-kit match searches with accents (filter and content) 2018-06-26 12:19:14 +02:00
Joffrey JAFFEUX f2dbe66367
FEATURE: adds a /admin/reports route to list all reports 2018-06-18 12:31:56 +02:00
Joffrey JAFFEUX 60ff0e9b8c
missing prettified files 2018-06-15 18:42:20 +02:00
Joffrey JAFFEUX 2268e29c26
fix linting removed by prettier 2018-06-15 18:18:45 +02:00
Joffrey JAFFEUX 03a7d532cf
DEV: introduces prettier for es6 files 2018-06-15 17:03:24 +02:00
OsamaSayegh 629a2fbc2b add JS tests 2018-06-15 14:04:14 +10:00
Joffrey JAFFEUX eddcb07f03 FEATURE: adds plugin sharing api 2018-06-13 13:25:51 +02:00
Joffrey JAFFEUX 3381a0a42a
UX: reworks dashboard problems section to be in line with new style 2018-06-12 12:47:03 +02:00
kleinfreund 4ce1d230c7 Prefer throwing a new Error object instead of just a string expression 2018-06-12 12:56:22 +10:00
Jeff Wong b7d92061e2 FEATURE: add an option to create undismissable modals 2018-06-07 20:49:33 -07:00
Joffrey JAFFEUX 1071aa21ab
FIX: slightly safer rounding 2018-06-07 10:59:17 +02:00
Joffrey JAFFEUX ab089cd68b
FIX: makes format number round the value before using parseInt 2018-06-07 10:44:21 +02:00
Joffrey JAFFEUX 43b1768987
UX: ceil dahsboard values 2018-05-30 16:32:43 +02:00
Joffrey JAFFEUX 82e5727287
UX: -2/+2% change in stats should be no-change in dashboard 2018-05-28 10:55:42 +02:00
Guo Xiang Tan 0b55416742 UX: Don't display `all groups` option if group directory is disabled.a
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
2018-05-28 11:32:55 +08:00
Joffrey JAFFEUX 1be76d066c
FIX: forces boolean when content is only "true" && "false" 2018-05-24 23:41:39 +02:00
Sam 70179290f3 clean up callbacks during acceptance tests 2018-05-24 15:28:54 +10:00
Sam 4194886b62 correct failing test 2018-05-24 13:02:20 +10:00
Joffrey JAFFEUX db91d71bf1
fix category chooser spec 2018-05-23 21:07:39 +02:00
Joffrey JAFFEUX ae004d8b2b
attempts of making composer actions test more resilient 2018-05-23 19:57:12 +02:00
Joffrey JAFFEUX 7232a6e5a9
FIX: do not show composer actions if irrelevant 2018-05-23 18:25:58 +02:00
Joffrey JAFFEUX d2efd338e6
rewrites all composer actions tests using await 2018-05-23 15:52:15 +02:00
Joffrey JAFFEUX dd76ba90b3
FIX: bbcode regex was greedy and preventing quotes 2018-05-23 11:55:02 +02:00
Sam 930ebb5684 skip failing test 2018-05-23 13:26:42 +10:00
Sam 41d37fd498 improve erratic test 2018-05-23 10:16:52 +10:00
Sam 8e9531657a skip erratic test 2018-05-23 08:28:00 +10:00
Joffrey JAFFEUX a0c5b48558
fix failing spec 2018-05-22 10:50:54 +02:00
Sam 9e2131ace8 improve erratic test 2018-05-22 13:58:12 +10:00
Sam 99088f4d77 skip slow erratic test 2018-05-22 13:03:26 +10:00
Jeff Atwood 4329b484e8 minor copyedit on dashboard chart title 2018-05-18 16:04:33 -07:00
Joffrey JAFFEUX af548c23c4
new dashboard quality pass (code, tests and UI) 2018-05-17 22:44:33 +02:00
Sam 17a7bb8e23 use async test 2018-05-17 17:18:22 +10:00
Régis Hanol 674318e127 UX: don't show 'auto delete' option for TL4 2018-05-17 00:42:48 +02:00
Régis Hanol 938934f5e9 FIX: keep '<kbd>' formatting when quoting posts 2018-05-16 17:40:45 +02:00
Joffrey JAFFEUX 9554d9c56a
UX: tooltips and improvements to new dashboard
- tooltips
- revert chart title UI
- reduce period chooser font-size
- localize dates of data points
- fix a bug where multiple reports were loaded at the same time
- fix a bug where % was not showing anymore
- remove spacing at the top
- remove loadingTitle feature (Loading...%report name%) incompatible with new hijack design
2018-05-16 16:45:21 +02:00
Joe Buhlig 3cd4c82c49 Allow parameters for group and username filters on directory (#5815) 2018-05-16 16:20:17 +02:00
Sam f08ff84c5c missing a fixture for acceptance test 2018-05-15 15:34:40 +10:00
Joffrey JAFFEUX e474351ae4
inactive users report is not used anymore 2018-05-14 21:31:14 +02:00
Régis Hanol b004503c62 fix the build 2018-05-14 20:07:00 +02:00
Sam e1d7f3bb94 correct fixture 2018-05-14 15:46:58 +10:00
Sam a6aa986d3b correct spec 2018-05-14 15:41:19 +10:00
Régis Hanol 81f4da7dd2 FIX: remove unneeded escape when building a Quote 2018-05-12 01:16:05 +02:00
Sam 8a783412b7 UX: improvements to new dashboard
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
2018-05-11 13:30:32 +10:00
Régis Hanol deaf3682e9 FIX: clicking a group mention on mobile was 404ing
(cc @featheredtoast)
2018-05-09 17:27:59 +02:00
Régis Hanol 3483c7bc58 FIX: supports user/group mentions and category hashtags when quoting posts 2018-05-09 12:42:12 +02:00
Guo Xiang Tan 32147d4ff9 FIX: Search term scoped to topic should be highlighted in widget dom era.
https://meta.discourse.org/t/highlight-the-search-results/10322/4?u=tgxworld
2018-05-07 15:17:34 +08:00
Neil Lalonde 3a145b7551 fix group-test.js 2018-05-03 16:00:56 -04:00
Joffrey JAFFEUX 980972182f
dashboard next: caching, mobile support and new charts 2018-05-03 15:41:41 +02:00
Joffrey JAFFEUX 37a0ceb4e7
Adds fixture for new contributors 2018-04-26 17:39:00 +02:00
Joffrey JAFFEUX a9c3437d51
dashboard next: adds basic spec 2018-04-25 10:28:41 +02:00
Joffrey JAFFEUX 59d4123316
PERFORMANCE: disables jquery animations during testing 2018-04-24 18:29:26 +02:00
Sam 54d153068a DEV: remove qunit rails fork and add a couple of async tests 2018-04-23 16:42:40 +10:00
Jeff Wong 252dd32895 show card on preview panel.
refactor user and group cards

refactor userLoading to loading

add logic to display cards above mentions for fixed placements
2018-04-20 12:28:24 -07:00
Guo Xiang Tan 6cce839f0a FIX: Missing action to trigger add group members modal for group owners.
https://meta.discourse.org/t/unable-to-add-members-to-a-group-as-group-owner-who-is-not-staff/85346?u=tgxworld
2018-04-16 09:09:47 +08:00
Neil Lalonde 0e2584b841 fix cursor on disabled composer 2018-04-12 11:32:13 -04:00
Guo Xiang Tan a389baeb07 FIX: Group pages should work when group name contains periods.
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658
2018-04-12 17:11:36 +08:00
Guo Xiang Tan c0595ebe99 FIX: Disable save button when new group form is empty.
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/26?u=tgxworld
2018-04-12 10:29:36 +08:00
Guo Xiang Tan 66abd340db Fix randomly failing JS build.
For some reason, the test rack server would block on
a `/letter_avatar_proxy` route causing ajax requests to
stack up.
2018-04-11 22:23:49 +08:00
Neil Lalonde 6e6892c88e FEATURE: when uncategorized topics are not allowed, disable the post input until a category is chosen 2018-04-10 19:31:28 -04:00
Joffrey JAFFEUX d9ac0152e4
fixes search-full-test for revamped search page 2018-04-10 09:59:24 +02:00
Neil Lalonde d7ea6f93e7 FIX: preference page error when badges are disabled 2018-04-09 14:27:00 -04:00
Régis Hanol 1b351a3355 disable full page search acceptance tests (cc @jjaffeux) 2018-04-09 20:14:57 +02:00
Guo Xiang Tan c82b2dcc24 Remove admin group management pages. 2018-04-09 15:14:50 +08:00
Guo Xiang Tan 4319273cf5 UX: Split up group form into smaller sections. 2018-04-09 15:14:50 +08:00
Claas Augner ba905b24ca FIX: differentiate one/other select-kit maximumLabel/minimumLabel 2018-04-09 09:12:01 +02:00
Joffrey JAFFEUX f0fe16d824
FEATURE: implements minimum selection for select-kit 2018-04-05 16:45:19 +02:00
Guo Xiang Tan e36e9de28a Allow admin to view logs of automatic groups. 2018-04-05 16:31:55 +08:00
Robin Ward 895bca5f5b FIX: Broken JS tests 2018-04-02 14:18:10 -04:00
Joffrey JAFFEUX 3287ac77e0
FIX: reverts combobox placeholder and introduces noneLabel
noneLabels works almost like none but instead of actually adding a row in the list, it will only change the text displayed in the header, when there's no selection.
2018-03-29 13:42:00 +02:00
Guo Xiang Tan 52e75eaee9 UX: Tweaks to group pages. 2018-03-29 17:04:48 +08:00
Guo Xiang Tan baa383b7f1 Fix the build. 2018-03-28 09:42:12 +08:00
Joffrey JAFFEUX 15aa712227
fix category-row regressions 2018-03-27 14:11:05 +02:00
Guo Xiang Tan f6b6ddd73c REFACTOR: Extract group form into a component. 2018-03-27 19:26:05 +08:00
Guo Xiang Tan bc4de7b5ec Make eslint happy. 2018-03-27 17:44:04 +08:00
Guo Xiang Tan 7edab1c0b9 UX: Add `groups/custom/new` route for admins to create a new group. 2018-03-27 17:39:05 +08:00