Commit Graph

3063 Commits

Author SHA1 Message Date
Robin Ward adea5b36a0 TESTS: Integration tests for `login_required` 2014-07-31 17:59:52 -04:00
Robin Ward d3cc85c784 TESTS: Use Pretender in test mode for more flexible server responses 2014-07-31 16:49:30 -04:00
Robin Ward c5b5db48cf TESTS: Reset the preload store for testing 2014-07-31 13:25:40 -04:00
Sam 5a8919e87a FIX: we don't need buttons that do nothing
Leading to v1 we don't need UI reminders in our product.
2014-07-31 18:59:18 +10:00
Sam 9926382185 FIX: can't create badges 2014-07-31 09:09:03 +10:00
Robin Ward 87ca49e26e Merge pull request #2609 from BenLubar/benlubar-edit-history-public-2
FIX: save edit_history_public
2014-07-30 13:20:32 -04:00
Ben Lubar 4e80a4d091 FIX: save edit_history_public 2014-07-30 12:03:22 -05:00
riking f9ef715357 Improve email-in category settings UI 2014-07-30 09:58:41 -07:00
Robin Ward a6848bd9e9 FIX: Latest should link to `/latest` since the homepage can be
customized
2014-07-30 11:59:22 -04:00
Régis Hanol 0b648f4b18 FIX: make sure the quote-reply button is never squished on mobile 2014-07-30 17:39:53 +02:00
Régis Hanol 78e33f1931 FIX: link to the flagged post instead of its topic 2014-07-30 11:16:49 +02:00
Sam 662845f8be FIX: don't display category for PMs 2014-07-30 14:56:19 +10:00
Sam e7e70d14da Merge pull request #2591 from BenLubar/benlubar-edit-history-public
add profile option for edit history visibility
2014-07-30 14:09:10 +10:00
Sam f29a761445 FIX: not highlighting stuff a second time 2014-07-30 12:32:14 +10:00
Sam e227b68f8d FEATURE: make # more useful for keyboard users 2014-07-30 12:16:11 +10:00
Sam b143b64511 FIX: searchContext set too early
This was firing before previous route deactivated.
2014-07-30 11:55:38 +10:00
Sam 871f2113e4 BUGFIX: don't move selection when nothing is selected 2014-07-30 11:22:41 +10:00
Sam 5c72297695 FEATURE: clean up badges admin 2014-07-30 08:56:46 +10:00
Sam ebf385aedc FEATURE: allow title overridable 2014-07-30 08:46:59 +10:00
Sam 367d699247 FIX: enter on invite to PM was broken 2014-07-30 08:46:59 +10:00
Régis Hanol b196de0821 TRIVIAL: use class instead of id for the 'topic-list' 2014-07-29 23:38:36 +02:00
Robin Ward 6844edc564 FIX: User email was changing in the HTML when you invited a user 2014-07-29 16:02:30 -04:00
Robin Ward ac4a33a656 FIX: Display proper error message when changing a trust level fails 2014-07-29 15:54:20 -04:00
Robin Ward 55457810ba FIX: Was not filtering correctly on the user's stream 2014-07-29 15:39:01 -04:00
Régis Hanol 86a4a1f220 export the Button class so that we can use it in plugins 2014-07-29 20:56:05 +02:00
Robin Ward 16dfedef8f ES6: Remove dynamically generated static routes. They were causing lots
of confusion and bugs.
2014-07-29 14:24:16 -04:00
Robin Ward df9bd3d666 FIX: Clicking logo when `login_required` threw an error 2014-07-29 13:46:42 -04:00
Robin Ward af36df057c FIX: Show correct login page when `login_required` 2014-07-29 13:38:04 -04:00
Robin Ward 04643898c9 FIX: Typo in SiteSetting 2014-07-29 13:27:01 -04:00
Dung Quang 97507bbd87 Update categories.js.handlebars 2014-07-29 17:24:19 +07:00
Régis Hanol a49a8e8c05 FIX: no primary action on disposition buttons 2014-07-29 09:36:12 +02:00
Régis Hanol 9d864ab28a FIX: show disposition buttons when flagging a topic 2014-07-29 09:34:58 +02:00
Régis Hanol b93deae54b EXPERIMENT: put the quote button at the bottom of the selection on mobile 2014-07-29 09:23:49 +02:00
Jeff Atwood 7bc4ac3e61 Merge pull request #2601 from awesomerobot/master
tiger striping on mobile categories
2014-07-28 23:10:37 -07:00
Kris Aubuchon 467b358659 tiger striping on mobile categories 2014-07-29 02:04:20 -04:00
Sam 7c83823a95 FEATURE: Dismiss unread / new at top if more than 30. 2014-07-29 14:12:41 +10:00
Neil Lalonde e1be478ef4 FIX: admins bypass some post validations. This allows them to edit legal docs even if those docs are longer than max post length, for example. 2014-07-28 16:40:14 -04:00
Robin Ward 380411457a UX: Show the category name even if there's an image. It's too confusing
otherwise for many sites.
2014-07-28 16:03:13 -04:00
Robin Ward 8603f492c7 FIX: Latest link in site map was not working correctly. 2014-07-28 15:53:46 -04:00
Robin Ward d17dbf61a8 Remove all the partials in the Site Map. Those made no sense. 2014-07-28 15:53:46 -04:00
Robin Ward 5cd7e1b387 ES6: Convert more routes over 2014-07-28 13:39:33 -04:00
Régis Hanol bddffa7f9a FEATURE: flag dispositions normalization
All flags should end up in one of the three dispositions
  - Agree
  - Disagree
  - Defer

In the administration area, the *active* flags section displays 4 buttons
  - Agree (hide post + send PM)
  - Disagree
  - Defer
  - Delete

Clicking "Delete" will open a modal that offer to
  - Delete Post & Defer Flags
  - Delete Post & Agree with Flags
  - Delete Spammer (if available)

When the flag has a list associated, the list will now display 1
response and 1 reply and a "show more..." link if there are more in the
conversation. Replying to the conversation will NOT give a disposition.
Moderators must click the buttons that does that.

If someone clicks one buttons, this will add a default moderator message
from that moderator saying what happened.

The *old* flags section now displays the proper dispositions and is
super duper fast (no more N+9999 queries).

FIX: the old list includes deleted topics
FIX: the lists now properly display the topic states (deleted, closed,
archived, hidden, PM)
FIX: flagging a topic that you've already flagged the first post
2014-07-28 19:28:07 +02:00
Robin Ward 717f57c968 Revert "FIX: You couldn't span multiple lines with bold or italics"
This reverts commit 423d37a2b6.

Conflicts:
	test/javascripts/lib/markdown_test.js
2014-07-28 13:17:39 -04:00
Robin Ward 8866141ba2 Merge pull request #2592 from Elberet/fix-parser
Fixes for quirky markdown parser behaviours
2014-07-28 13:12:22 -04:00
Jens Maier 90d14d9ffc add comments and improve variable names 2014-07-28 19:03:34 +02:00
Sam f9162d6add FIX: moderators had no access to admin user page 2014-07-28 11:59:46 +10:00
Sam 32cea9d8cc Feature: Show keyboard shortcuts link on desktop hamburger
(only shows up for desktop, hides "mobile view")

If you really need mobile view add ?mobile_view=1 to end of URL (also fixed)
2014-07-28 11:48:56 +10:00
Ben Lubar ac8c2e1e07 discourse#2591 2014-07-27 12:12:36 -05:00
Jens Maier 479eb64a76 FIX: rewrite replaceBlock logic to better handle mismatched nested quotes. 2014-07-27 16:07:47 +02:00
Sam 1a6aa07611 FEATURE: editable badge groups 2014-07-27 18:22:01 +10:00
Ben Lubar 44dc4b4a17 add profile option for edit history, visible only when edit history is disabled globally. 2014-07-26 23:04:46 -05:00
Shiv Kumar aac9c24639 do not allow password changes if local logins disabled 2014-07-25 14:27:27 -07:00
Robin Ward 227ca5dd23 FIX: Home logo wasn't scrolling to top if on second page of topic
results.
2014-07-25 17:02:46 -04:00
riking 8af4ab2a63 Use settingName in settings_list like the others 2014-07-25 13:19:43 -07:00
Robin Ward 423d37a2b6 FIX: You couldn't span multiple lines with bold or italics 2014-07-25 16:08:00 -04:00
Neil Lalonde 46bdd13491 FIX: too_few_topics_notice check and message should use basic_requires_read_posts site setting 2014-07-25 15:58:22 -04:00
Neil Lalonde 5a33e6f00c Move FAQ, Terms of Service, and Privacy Policy into topics in the Staff category. First post of those topics will be rendered on their respective pages. Site settings and content are not used for these documents anymore. Translations of the default text is moved into the standard YML files. 2014-07-25 14:41:20 -04:00
Robin Ward 15a51c6316 ES6: Patch up a few issues with the admin controllers conversion 2014-07-25 14:17:58 -04:00
Joshua Gorner e242368266 Convert admin section controllers to ES6 modules 2014-07-25 14:17:58 -04:00
Sam 1d1dd43e27 SECURITY: fix XSS using fancy mention hack 2014-07-25 17:26:57 +10:00
Sam ae686e8188 FIX: no new badges could be created 2014-07-25 15:48:43 +10:00
Sam 1297243759 FIX: stop tracking broken links 2014-07-25 15:34:31 +10:00
Sam fbbd4999b6 FIX: remove invalid hack, correct whitelist to use value returned from callback 2014-07-25 12:16:00 +10:00
Robin Ward f2b554be13 FIX: Use placeholder for avatar image size in expansion 2014-07-24 17:17:47 -04:00
Robin Ward b88a8d2416 FIX: Clicking navigation pills a second time should refresh the list
you're looking at.
2014-07-24 14:59:53 -04:00
Jens Maier b19ad15086 FIX: improve list bbcodes: ignore newlines resulting in unnecessary blank lines 2014-07-24 19:39:16 +02:00
Robin Ward f33ebc512b FIX: Link a poster's name to their profile, makes much more sense now
that we're showing the popup to that.
2014-07-24 13:13:24 -04:00
Robin Ward fa25700400 FIX: Direct links to hash URLS were broken. Regression? 2014-07-24 12:52:43 -04:00
Jens Maier 79dc68512f FIX: dialects accept nested inline markup 2014-07-24 17:34:13 +02:00
Robin Ward 5aa411b58c FIX: When we don't have an `uploaded_avatar_id` don't try to show the
avatar. Wait until it's loaded.
2014-07-24 11:31:08 -04:00
Robin Ward 0b368993b7 FIX: If you hit back while a `replaceState` was queued up it would
update the URL even after navigating.
2014-07-24 11:26:53 -04:00
Sam ec03d135fa FEATURE: allow advanced badge options in admin screen
clean up serializer, allow simplistic preview
2014-07-24 18:28:23 +10:00
Sam 469e74316b FIX: don't show broken button 2014-07-24 18:28:23 +10:00
Sam 526da15b9e Improve badge UI add links to badge descriptions 2014-07-24 12:21:24 +10:00
Robin Ward c8a0bf35c5 FIX: Navigating to a user's admin page would not populate
`availableGroups`
2014-07-23 16:54:04 -04:00
Robin Ward 27f786e06a FEATURE: Show user popup when clicking on an @mention in a post. 2014-07-23 16:10:29 -04:00
Robin Ward 04c6733ae7 FIX: If a deprecated view can't be found, look for a component 2014-07-23 16:10:29 -04:00
Robin Ward 06512685ab FEATURE: If there is a category scope and `show_subcategory_list` is set, only
show the local categories in the dropdown instead of all categories.
2014-07-23 13:10:06 -04:00
Robin Ward b29b94046c Merge pull request #2569 from lreeves/group-selector-datasource-finder
Move finder logic out of the group-selector component
2014-07-23 11:28:29 -04:00
Robin Ward 0a0d32efb4 TRIVIAL: Rename `map` to `idMap` because `map` means something for
enumerables.
2014-07-23 11:11:13 -04:00
Robin Ward 1a7eacc70a Merge pull request #2568 from lebek/optimize-category-lookup
Optimize Finding a Category by Id
2014-07-23 11:06:54 -04:00
Jeff Atwood 1b733ff936 missed a spot for more /!\ 2014-07-22 21:34:19 -07:00
Jeff Atwood fc1fa2d104 Caps Lock clearly needs more exclamation sign 2014-07-22 21:15:54 -07:00
Peter Le Bek f63e6e6dab Optimize Category find-by-id by using a hash. 2014-07-22 23:49:49 -04:00
Sam b9a7d945c3 Improve badge grouping UI
Start work on triggers
2014-07-23 11:43:17 +10:00
lreeves 9c2f4b55ac This moves the finder logic out of the component 2014-07-22 20:30:30 -04:00
Neil Lalonde f5cba39c89 FIX: Typo in method name for triggering 2014-07-22 19:56:41 -04:00
Robin Ward 7c0e723464 TWEAK: If `show_subcategory_list` is enabled, hide subcategories from
the site map.
2014-07-22 16:27:33 -04:00
Robin Ward c004ad1d51 Merge pull request #2563 from techAPJ/patch-2
FEATURE: group name is required for private topic invite
2014-07-22 14:44:26 -04:00
Arpit Jalan d0024f738b further optimize computed property 2014-07-23 00:08:54 +05:30
Arpit Jalan e7e823129e FEATURE: group name is required for private topic invite 2014-07-23 00:03:15 +05:30
Neil Lalonde 386b6213a5 FEATURE: warn when caps lock is on during password input 2014-07-22 13:53:58 -04:00
Robin Ward fd3ceae1d6 ES6: Enable compatibility layer for routes 2014-07-22 12:09:29 -04:00
Robin Ward 4d354cff7e FIX: Clicking an avatar in an expanded post should show the user
expansion popup.
2014-07-21 18:05:24 -04:00
Robin Ward 0175ba000f FIX: Limit the `maxLength` of the title text fields to the site setting
for the maximum length.
2014-07-21 14:30:23 -04:00
Robin Ward bddd7f5ea3 FIX: Stop endless loading at the bottom of a user's stream. 2014-07-21 14:13:17 -04:00
Robin Ward d9e5c2317f FIX: If a topic title edit fails, revert to previous title. 2014-07-21 13:39:23 -04:00
Robin Ward 0f23456259 FIX: Instead of patching markdown-js, fix the issue in Discourse. 2014-07-21 13:09:57 -04:00
Robin Ward 90e2f1893c ES6: Start converting routes 2014-07-21 12:00:58 -04:00
Robin Ward 59c3ca7e7b PLUGIN: New API for decorating a post with jQuery 2014-07-21 11:38:38 -04:00
Régis Hanol 9c2a7f0fd1 BUGFIX: cancelling an upload should hide cancel button 2014-07-21 11:14:01 +02:00
Jeff Atwood 23d6fd68e5 simplify mobile category page 2014-07-20 01:02:59 -07:00
Jeff Atwood 391edfd907 missing space in footer on mobile 2014-07-20 00:22:01 -07:00
Jeff Atwood 1c4e3c4a96 mobile category layout fixes 2014-07-19 23:54:57 -07:00
Robin Ward da717c55d7 FEATURE: Like button should act like a toggle and stay there once you've
clicked it.
2014-07-18 17:01:27 -04:00
Robin Ward 75f6b43e62 ES6: Discourse.ContainerView 2014-07-18 12:20:07 -04:00
Robin Ward a73b22b96f ES6: Modals converted 2014-07-18 12:20:07 -04:00
Régis Hanol c7330ed73f BUGFIX: errors when post-processing 'data images' 2014-07-18 17:54:18 +02:00
Sam 8f36d3367f Merge pull request #2556 from riking/topic_error
Don't show Try Again for access errors on topics
2014-07-18 17:18:22 +10:00
Sam c8284170ad FEATURE: badge grouping UI
FIX: not loading more badges on badge show page
2014-07-18 15:46:36 +10:00
riking 349003ee5e Don't show Try Again for access errors on topics 2014-07-17 17:50:37 -07:00
Sam b522f6116f FIX: strip out some more undo/redo stuff 2014-07-18 10:32:55 +10:00
Sam da26aae41e FIX: somehow button is not set 2014-07-18 10:31:02 +10:00
Robin Ward 6d3efc9a58 TRIVIAL: Added "has-logo" and "no-logo" classes for styling categories 2014-07-17 15:57:17 -04:00
Robin Ward 38619b5a31 UX: Improve the interface for selecting a subcategory in a dropdown 2014-07-17 15:51:00 -04:00
Robin Ward 98907c0e81 FIX: Category counts were incorrect when the names were duplicates. 2014-07-17 14:54:04 -04:00
Robin Ward 5ccb656b62 Don't trigger `replaceState` until scrolling stops. 2014-07-17 14:34:56 -04:00
Robin Ward 61fd64c99d ES6: Many modal views 2014-07-17 13:43:22 -04:00
Robin Ward 3265360ff7 Merge pull request #2546 from riking/hide_deleted
Hide deleted posts by default for staff
2014-07-17 13:40:58 -04:00
riking 19b757b058 FEATURE: Hide deleted posts by default for staff 2014-07-17 10:40:15 -07:00
riking 73ceeda1f9 Stop unnecessarily suppressing settings for uncategorized
Fix migration for emailing into uncategorized
2014-07-17 10:25:52 -07:00
Robin Ward f06f8abedd Merge pull request #2537 from ligthyear/group-member-management-on-user
Improved Group Member Management on User Administration
2014-07-17 11:00:05 -04:00
Robin Ward a00cfbc6bf Merge pull request #2553 from techAPJ/patch-1
FIX: refresh invite list after sending invite manually
2014-07-17 10:20:40 -04:00
Sam de7e6a9545 Feature: allow mods to cut pinned topic excerpts 2014-07-17 21:32:37 +10:00
Arpit Jalan 2451779011 FIX: refresh invite list after sending invite manually 2014-07-17 13:53:30 +05:30
Sam 91cd4f2d66 SECURITY: improve escaping protection 2014-07-17 16:11:10 +10:00
Sam c12a131fb4 SECURITY: sanitizer allowing invalid attributes 2014-07-17 16:11:09 +10:00
Sam e8ca1a2469 FEATURE: allow overriding badge names
FEATURE: allow html in badge description
2014-07-17 16:11:09 +10:00
Sam 189b1c729a FEATURE: query param for topic state 2014-07-17 09:29:09 +10:00
Robin Ward 62ef81d895 FIX: Don't scroll to top if there's an anchor present. 2014-07-16 18:14:39 -04:00
Robin Ward d9c2b316b6 FIX: Resolver should try with slashes instead of periods too 2014-07-16 17:38:14 -04:00
Régis Hanol f43293a7bc FEATURE: replace 'deleted by' with the trashcan glyph 2014-07-16 22:38:39 +02:00
Neil Lalonde 5c70d878a7 FEATURE: show a reason why a category can't be deleted 2014-07-16 15:43:51 -04:00
Robin Ward fb8dda7f42 FIX: We should use `category_id` instead of `category_name` to perform
operations, now that the subcategory names are not unique.
2014-07-16 15:40:35 -04:00
Régis Hanol 7dcf2a2c4f FEATURE: show the user's flagged/deleted posts 2014-07-16 21:04:55 +02:00
Robin Ward 71c67c43a1 ES6: User activity views 2014-07-16 13:19:47 -04:00
Neil Lalonde 01a68f8cc7 Emails are case insensitive 2014-07-16 10:22:01 -04:00
Sam 0c8025d513 FIX: post number is just adding noise 2014-07-16 18:23:29 +10:00
Sam e347eea629 FEATURE: show user what badges they have 2014-07-16 17:55:08 +10:00
Neil Lalonde 823061a2cf FIX: handle enter key with a better way on site setting string inputs 2014-07-15 17:32:45 -04:00
Neil Lalonde 82bdef2047 FIX: escape input of forgot password form before rendering it back to you 2014-07-15 17:19:28 -04:00
Robin Ward c6df00a5cc FIX: You shouldn't be able to add a parent to `Uncategorized` 2014-07-15 15:19:39 -04:00
Robin Ward c037371be1 FIX: Don't link to web sites for TL0 2014-07-15 14:46:12 -04:00
Robin Ward 3368e23fe4 ES6: Preferences views 2014-07-15 12:36:57 -04:00
Benjamin Kampmann 67d127ec5c make jshint happy: missing semicolon 2014-07-15 17:12:03 +02:00
Benjamin Kampmann 518207aa90 move ajax into models 2014-07-15 16:11:39 +02:00
Régis Hanol a9342dbf92 SECURITY: fix XSS in link's href 2014-07-15 16:11:37 +02:00
Benjamin Kampmann 5025e97712 move available groups loader into router 2014-07-15 15:48:02 +02:00
Benjamin Kampmann 2435961b58 use computed 2014-07-15 15:43:53 +02:00
Benjamin Kampmann 6710637904 renamed 2014-07-15 15:35:16 +02:00