474c947427
temporarily disable test while debugging
2015-03-03 09:51:10 +11:00
336c15672a
clear cache to fix spec
2015-03-03 08:27:27 +11:00
7c14db44cc
UX: improve message when admin login is blocked because of admin ip address whitelisting
2015-03-02 12:13:22 -05:00
1bf4f34049
FIX: topic and post counts are not updated when ownership of a post is changed
2015-03-02 12:13:21 -05:00
37fefc16de
workaround, something about report spec is messed up
2015-03-02 12:29:56 +11:00
c04b214910
FEATURE: don't allow username and email to be the same
2015-02-27 13:47:43 -05:00
0742f340f9
FEATURE: allow for a localized error when a regex fails in site settings
...
FEATURE: apply string validation to list site settings (so we get regex)
2015-02-27 11:45:56 +11:00
ea40dd08e6
correct tests
2015-02-27 09:41:08 +11:00
7d8dd9d93b
fix some rspec deprecations
2015-02-26 13:05:20 +01:00
83f719fb80
FIX: Cleaned the commit
...
Only changing the code I changed, not other tests.
2015-02-26 01:24:21 +00:00
73068d5fa3
ADD: Spec tests for User Badge triggers
...
NOTE: The DiscourseEvent trigger mechanism is VERY weird.
If there are ANY triggers triggered in the chain, you can't only list the one you're looking for, you have to list all triggers in the order they will come.
Example: line 98-100
:user_created and :user_verified are triggers that are introduced in PR #3237 so if this PR is accepted but not PR #3237 then lines 98-99 need to be removed.
2015-02-26 00:55:17 +00:00
cbe18eb0df
FEATURE: allow view exclusion using custom header
...
Set Discourse-Track-View to either "0" or "false" to exclude request
2015-02-26 11:41:11 +11:00
3e2ba5b30b
FIX: If an IP is blocked, don't allow people to login using it
2015-02-25 16:02:40 -05:00
1a070b16e4
FIX: use the 'post edit time limit' for topics too
2015-02-25 20:53:21 +01:00
005b8bf7c3
FIX: When creating a SSO user via sync, do not user the IP address.
2015-02-25 14:41:23 -05:00
cf81b3f86d
FEATURE: don't allow username and password to be the same
2015-02-25 12:00:13 -05:00
1c545d4c1e
Allow adding and removing members of groups by username or id
...
As discussed here: https://meta.discourse.org/t/discourse-gem-group-add/25668/2 .
2015-02-25 14:52:13 +00:00
9ca61efa97
correct test
2015-02-25 18:09:45 +11:00
b760d22460
PERF: avoid expensive order by random for suggested topics
2015-02-25 17:19:12 +11:00
7b6e85cb6c
remove unused api call
...
correct spec
2015-02-25 14:39:50 +11:00
3658c21fc5
REGRESSION: incorrect ordering when featuring topics
2015-02-25 14:24:25 +11:00
fe578f9944
FEATURE: Allow manual assignment of related post to badge
...
PERF: clean up performance of user badges admin when large number of badges exist
2015-02-25 12:53:01 +11:00
34dc1f9e10
Spec to ensure that SSO respects blocked emails
2015-02-23 17:14:54 -05:00
ca5730018a
FIX: SSO code should respect IP address filters
2015-02-23 16:01:46 -05:00
8186d86f38
FIX: Enforce max length for custom user fields
2015-02-23 13:02:30 -05:00
6960639c58
Merge pull request #3190 from riking/thrown_logging
...
Delete old ErrorLog, use Logster for 500 errors
2015-02-23 14:19:16 +11:00
20c9a312c7
FIX: clicks counter on attachments wasn't always working
2015-02-22 20:47:18 +01:00
17927b2e8b
FIX: don't use flash cause we are not redirecting
...
(we should probably change that though)
2015-02-20 10:28:58 +11:00
e74b9ee5da
FIX: should not count disagreed flags
2015-02-19 18:11:07 +01:00
103d42a9d9
FIX: emoji cache could get corrupt
...
FEATURE: enforce 1 day expiry by default on discourse cache
remove family expiry concept as the implementation was fragile
2015-02-19 16:58:22 +11:00
709ab731c7
don't put missing notifications in the stream for tests.
2015-02-19 13:20:25 +11:00
451788b95d
FIX: allow searching in PMs when "search this topic" is selected
2015-02-19 12:56:49 +11:00
b041b3f67f
FIX: bookmark topic was not working intuitively
...
- explicitly call out "clear bookmarks"
- correct keyboard shortcuts
- properly remove bookmarks when toggeling
2015-02-19 10:58:57 +11:00
f3daae6dec
Improve auto generated email reply error message
2015-02-18 18:58:51 +05:30
395654bf24
Fix regression on editing private messages
...
v1.2.0beta9 has introduced a regression in edit of a private topic
(first post). Previously a check for no change in TopicsController was
made but it has been changed without considering that the topic could
be private.
By simply forcing a conversion of `topic.category_id` to integer, the case
where its value is nil is handled correctly as it was previously.
2015-02-18 00:41:16 +01:00
6e5540c107
FIX: do not show name in email if name on posts are disabled
2015-02-18 01:39:41 +05:30
cdef67667a
PERF: allow background jobs to flush between requests in same thread
2015-02-17 09:58:43 +11:00
3cad4824d7
FEATURE: allow moderators to see flagged private messages
2015-02-16 13:03:04 +01:00
0b45054e2b
FIX: couldn't uncategorize a topic
2015-02-16 10:31:36 +01:00
3ce2077aa8
Migrate unsubscribe keys to the database.
...
This should reduce a lot of the keys in redis.
2015-02-13 14:24:15 -05:00
e207ca36ee
Easier helper for filtering secured categories
2015-02-12 11:52:59 -05:00
276fd702e8
missed a send which caused code to break
2015-02-12 15:01:14 +11:00
c4e427cf73
FEATURE: filter screened IP addresses
2015-02-10 19:38:59 +01:00
8d46de4819
Add a spec for the new plugins controller
2015-02-10 12:35:53 -05:00
acda6ebd60
FIX: view tracking needs to release data earlier
...
retaining data during queuing was causing huge memory spikes
2015-02-10 17:03:33 +11:00
68ccd2d664
FEATURE: All 500 errors now show up in Logster
...
Added Discourse.handle_request_exception()
2015-02-09 12:48:33 -08:00
5657006aca
Rename handle_exception to handle_job_exception
2015-02-09 12:47:46 -08:00
e36272cb68
fix the build
2015-02-09 17:13:22 +01:00
e8323fa534
FIX: removing a group from a user was not removing primary group
2015-02-09 16:03:09 +11:00
7dea65122e
Support a `url` field in plugin metadata
2015-02-06 18:08:57 -05:00
f7d2fc0524
FEATURE: 'reply by email address' validator
...
Prevent infinite email loophole when the 'reply_by_email_address' site setting is the same as the 'notification_email'.
2015-02-06 12:08:37 +01:00
820ce8765e
refactor traffic report
...
split traffic report in 2, page view vs raw traffic
hide raw traffic report by default
improve flushing logic for application reqs
2015-02-06 14:39:16 +11:00
4e64d16a47
FEATURE: Allow plugins to log staff actions
2015-02-05 15:26:34 -05:00
2fcd199f48
FIX: send a PM to moderators when a post has been flagged as sockpuppet
2015-02-05 19:58:49 +01:00
f1403206ca
Merge pull request #3169 from riking/patch-3
...
SECURITY: Don't leak topic title in the redirect
2015-02-05 12:47:58 +01:00
08b790b3c2
improve metrics gathered using in our traffic section
...
this also pulls out the middleware into its own home and inserts in front
2015-02-05 16:08:52 +11:00
eb7a5c251d
freeze time in report spec so it has consistent results
2015-02-05 11:33:13 +11:00
3b68214210
FIX: Clean up after adding events. Fixes random test failures.
2015-02-04 17:33:18 -05:00
25daca8f23
Helpers for plugins to support enabling/disabling
2015-02-04 16:23:56 -05:00
4c8850108a
SECURITY: Don't leak topic title in the redirect
2015-02-04 11:55:39 -08:00
a4b96adfc5
eliminate cross talk in site setting test
2015-02-04 16:57:16 +11:00
c150c55e2d
FEATURE: rudimentary view tracking wired in
2015-02-04 16:15:16 +11:00
e105f0965c
infrustructure for tracking application web requests
2015-02-04 16:15:16 +11:00
aacf2e6f20
Can add `shadowed_by_global` to a site setting to override
...
If a site setting has `shadowed_by_global: true` then, if
a `GlobalSetting` exists with the same name then that value
will be used instead. Additionally, the setting will be hidden.
This is useful in a multisite environment for private settings
such as API keys. You want to set it globally, yet not display
the key to customers.
2015-02-03 16:49:22 -05:00
f15b0d205f
FIX: The "too similar" check happened when trying to make a post a wiki
2015-02-02 12:44:56 -05:00
64c4bd5dbf
Fix force_avatar_update.to_i error as force_avatar_update is a boolean
...
If force_avatar_update is passed in sso attributes it errors on
force_avatar_update.to_i. The SingleSignOn class forces avatar_force_update
to a boolean, so it should be treated as such.
2015-01-30 09:51:38 +00:00
8264dbd971
Merge pull request #3140 from fullfatthings/fix_missing_sso_avatar_bug
...
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
2015-01-30 10:45:25 +11:00
b1f81c0dca
Merge pull request #3080 from riking/misc
...
Miscellaneous fixes from PR#3000
2015-01-30 10:23:17 +11:00
ea7af7a83b
Merge pull request #3135 from longhotsummer/fix-no-user-params
...
FIX: creating a user shouldn't error when optional fields aren't given
2015-01-30 10:12:57 +11:00
85a7b925c7
Miscellaneous fixes from PR#3000
...
FIX: Don't require login to view post raw
FIX: Don't submit read-guidelines for anonymous users (causes
unnecessary 403 errors from ensure_logged_in)
FIX: Don't pass nil to an array serializer
2015-01-29 13:56:32 -08:00
6a68e8c272
FIX: use CDN for user card/profile background and user avatars (for real this time)
2015-01-29 22:53:48 +01:00
6c410ed093
FIX: strip whitespaces from user email
2015-01-30 01:44:24 +05:30
e42e9bd010
Merge pull request #3149 from techAPJ/patch-2
...
FIX: allow developer emails to bypass email blacklist/whitelist restrict...
2015-01-29 13:42:59 -05:00
58f46137d6
FIX: allow developer emails to bypass email blacklist/whitelist restriction
2015-01-30 00:10:03 +05:30
1f40807001
Add extensibility point for whenever a post is created
2015-01-29 12:46:29 -05:00
bdb0b45834
Merge pull request #3148 from techAPJ/patch-1
...
Do not allow TL0 users topics in email digest
2015-01-29 17:50:21 +01:00
6e862e0e59
FIX: Should flush rate limit keys before testing it
2015-01-29 11:45:12 -05:00
21e94859a9
Do not allow TL0 users topics in email digest
2015-01-29 21:10:26 +05:30
e97755ab5d
FIX: remove custom Discourse headers in email
2015-01-29 17:25:50 +05:30
cd2c9edb46
FIX: 🐛 upload on IE9 wasn't working :'(
...
- FIX: make sure we set a default name to a pasted image only on Chrome (the only browser that supports it)
- FIX: use ".json" extension to uploads endpoints since IE9 doesn't pass the correct header
- FIX: pass the CSRF token in a query parameter since IE9 doesn't pass it in the headers
- FIX: display error messages comming from the server when there is one over the default error message
- FIX: HACK around IE9 security issue when clicking a file input via JavaScript (use a label and set `visibility:hidden` on the input)
- FIX: hide the "cancel" upload on IE9 since it's not supported
- FIX: return "text/plain" content-type when uploading a file for IE9 in order to prevent it from displaying the save dialog
- FIX: check the maximum file size on the server 💥
- update jQuery File Upload Plugin to v. 5.42.2
- update JQuery IFram Transport Plugin to v. 1.8.5
- update jQuery UI Widget to v. 1.11.1
2015-01-28 19:43:20 +01:00
d43944b3ed
Extensibility for tracking changes to a topic
2015-01-28 13:37:06 -05:00
dbf2f4efec
Fix bug when sso_overrides_avatar is true but no avatar_url is passed
...
If a user has a current avatar, and sso_overrides_avatar is true, but no avatar_url is
passed in the sso attributes, the current code errors, as it tries to parse a nil
as a URL. It seems to me valid that a third party system may not pass an avatar_url in
some cases (e.g. avatars may not be mandatory, so not all users may have them)
This might warrant a discussion about what should happen in this case; maybe the current
avatar in discourse should be removed? This branch merely stops the login process erroring.
2015-01-28 16:01:39 +00:00
b0369061e2
FIX: always set a default Message ID in email
2015-01-28 14:49:38 +05:30
12c82bed59
Disable digest emails site setting
2015-01-27 22:41:36 +05:30
d99ccf6d27
FIX: creating a user shouldn't error when optional fields aren't provided
...
This fixes a bug where the server would 500 if the only user fields
where optional ones, and the create_user call didn't provide any
values so that params[:user_fields] was nil.
Additionally, don't bother double-checked for required fields, since we
iterate over all fields and will catch any that are required and blank.
2015-01-27 11:48:27 +02:00
5c2ee8ec2a
FEATURE: suppress digest emails for users not seen on the site for more than (n) days.
2015-01-26 22:04:02 +05:30
1ab0d6bd82
FEATURE: Log username changes by staff
...
Also fix the tests for changing username
2015-01-17 02:26:12 -08:00
7a86abd105
Merge pull request #3084 from jmay/group-managers
...
table & model changes for group managers with permission to edit members
2015-01-16 12:02:38 +01:00
4a11bb5227
FIX: on topic page, don't try to render post counts for a deleted user
2015-01-15 15:39:34 -05:00
dc801bb442
Merge pull request #3102 from techAPJ/patch-2
...
Add username and date-time in exported file name
2015-01-15 15:35:06 -05:00
505fa9f1cf
FIX: 🐛 Saving the same custom field array twice would raise an error
2015-01-15 15:31:50 -05:00
c619aed8f9
💄 add username and date-time in exported file name
2015-01-16 01:39:46 +05:30
a2b284a0a4
table & model changes for group managers with permission to edit membership
2015-01-15 11:44:42 -08:00
b4e5937850
FIX: 🐛 ensure emoji are case insensitive
2015-01-15 19:00:55 +01:00
c4da9ce62f
FIX: old csv's were not getting deleted
2015-01-15 00:00:39 +05:30
835835832f
FIX: user list export was failing
2015-01-14 16:24:42 +05:30
b94c7922c5
🐎 gzip csv export files
2015-01-14 13:38:37 +05:30
7771d2fb31
remove enable_email_names setting
2015-01-13 13:35:40 +05:30
1032fa7262
Merge pull request #3089 from lucianosousa/enhacement/controllers-rspec3
...
controllers with rspec3 syntax
2015-01-12 16:25:31 +01:00
5f98be6ec5
Merge pull request #3088 from lucianosousa/enhacement/components-rspec3
...
few components with rspec3 syntax
2015-01-12 16:25:25 +01:00
f7f5e39f75
FIX: Minor Admin bug with a setting when creating a new group
2015-01-23 20:31:48 +01:00
256519dddf
FEATURE: automatic group membership based on email address
2015-01-23 18:25:43 +01:00
b3a2c0c45b
SECURITY: The SSO `return_path` was an open redirect
...
This security fix needs SSO to be configured, and the user has to go
through the entire auth process before being redirected to the wrong host so
it is probably lower priority for most installs.
2015-01-22 12:20:17 -05:00
e300945879
FEATURE: split group admin in 2 tabs (custom & automatic)
...
FIX: clear the user-selector when adding new members
2015-01-21 20:52:48 +01:00
5e751ce90a
FEATURE: 🎁 rate limit invites for non-staff users
2015-01-20 01:12:24 +05:30
bc73238c8f
controllers with rspec3 syntax
2015-01-09 14:04:02 -03:00
0fd98b56d8
few components with rspec3 syntax
2015-01-09 13:34:37 -03:00
16156bdc1d
removing rspec3 warning
2015-01-09 09:55:58 -03:00
0b14cfa2c3
skip failing spec, something is off with timezones
2015-01-09 12:03:08 +11:00
6cec925f26
FIX: all PMs should be flaggable
2015-01-08 16:06:43 +01:00
03388e11ab
oops, migration was flipping
2015-01-08 15:26:15 +11:00
3347a48275
FEATURE: add liked and bookmarked classes to topic list item rows
2015-01-08 14:35:56 +11:00
114cc1c851
FIX: We missed some references to `/category/xyz` in the ruby code base.
2015-01-07 11:47:01 -05:00
ea87f5fd8a
FEATURE: support for filter=bookmarked and filter=liked in topic list
2015-01-07 18:20:10 +11:00
efc717c14a
FEATURE: remove star concept from Discourse
2015-01-07 13:43:27 +11:00
6953923a03
remove |starred| from topnav default options
2015-01-06 16:03:45 -08:00
060cda7772
FIX: proper handling of group memberships
2015-01-05 18:51:45 +01:00
b52f12948a
models with rspec3 syntax
2015-01-05 13:04:23 -03:00
b3d769ff4f
Update rspec syntax to v3
...
update rspec syntax to v3
change syntax to rspec v3
oops. fix typo
mailers classes with rspec3 syntax
helpers with rspec3 syntax
jobs with rspec3 syntax
serializers with rspec3 syntax
views with rspec3 syntax
support to rspec3 syntax
category spec with rspec3 syntax
2015-01-05 11:59:30 -03:00
6f72f265cb
A trigger when a topic is updated, adds a couple of custom field tests
2015-01-02 15:57:08 -05:00
4c166942ad
FEATURE: Invite admin api has an optional param send_email which can prevent sending an email to the invited user. The api will return the password reset url so that the caller can send an email with it instead.
2015-01-02 15:48:54 -05:00
c57a1b393f
clean up 'checked_for_custom_avatars' user history entries
2015-01-02 12:37:17 +01:00
9fcaf090ec
Merge pull request #3068 from fantasticfears/category_slug
...
support setting category slug
2015-01-02 11:55:27 +01:00
bfe95966b4
better filenames for export
2015-01-02 15:30:50 +05:30
35edfb5b91
FIX: Don't truncate groups. @ZogStrIP we need to create a better fix for
...
this in the new year.
2014-12-31 12:58:50 -05:00
3d42c2d515
Merge pull request #3070 from techAPJ/patch-3
...
FIX: rate limit user posts export
2014-12-31 11:37:11 -05:00
78537aad39
FIX: rate limit user posts export
2014-12-31 00:54:23 +05:30
97b3914b70
FIX: use utc time when generate reports; set boundary
2014-12-30 22:43:03 +08:00
a04f44d65a
Merge pull request #3065 from fantasticfears/fix-visits-report
...
FIX: today visits not shown
2014-12-29 21:23:47 +01:00
f7955406cc
As an optimization, don't return suspended users in the query that
...
determines who to send digests to.
2014-12-29 15:16:29 -05:00
1e166d89ff
support setting category slug
2014-12-30 03:14:54 +08:00
fe7f2c6979
FIX: today visits not shown
2014-12-30 03:09:22 +08:00
7ca092da17
Merge pull request #3057 from jaanus/s3-frankfurt-bucket
...
Add eu-central-1 to list of S3 buckets.
2014-12-29 18:02:14 +01:00
f6026ad1d0
Added eu-central-1 S3 bucket.
2014-12-29 18:31:21 +02:00
1055fc0919
Merge pull request #3021 from jmay/custom-category-slug
...
optional custom value for category slug (create and update)
2014-12-29 10:34:23 -05:00
267de04e2d
Merge pull request #3061 from techAPJ/patch-1
...
Rename CsvExportLog to UserExport
2014-12-29 12:39:53 +01:00
bfbc49ef6f
FIX: log only 1 'show email' record
2014-12-29 11:50:36 +01:00
ef62933034
Ruby 2.2 fixes
2014-12-29 13:31:15 +11:00
68e66f3a25
Rename CsvExportLog to UserExport
2014-12-28 22:31:12 +05:30
9932bea7ce
FEATURE: default emoji override
2014-12-25 17:58:15 +01:00
7c7474aa10
create a new table to maintain csv export log
2014-12-24 16:25:36 +05:30
bb152a5b3f
FEATURE: download user posts archive
2014-12-24 15:13:48 +05:30
e23e008682
FIX: buggy unhoisting of escaped \*
2014-12-23 18:25:10 +11:00
5b844f5320
FEATURE: more than 1 site customization can be enabled at once
...
FIX: more robust site customizations
Rewrote site customization to use distributed cache and a much cleaner
css delivery mechanism
2014-12-23 13:03:48 +11:00
45dbdb6896
FEATURE: custom emojis
2014-12-23 01:12:26 +01:00
9bb2ab6265
Merge pull request #3034 from fantasticfears/filter_system_user
...
disable sending email or show presence when forgot system user password
2014-12-19 16:52:01 -05:00
3cb25b019e
FIX: when private messages are disabled in settings, flag modal shouldn't show private message options
2014-12-19 16:47:39 -05:00
ceca85c9eb
use system user helper and constant when it's referred
2014-12-18 18:21:14 +08:00
ae16186100
FEATURE: post chunk size should not be configurable
...
If people need to configure post chunk size use a plugin
Core only supports out of the box settings, if changed can lead to
severe performance issues.
2014-12-15 10:57:34 +11:00
768027f0e3
Merge pull request #3046 from gdpelican/feature/insensitive-group-names
...
Remove group name validation case sensitivity
2014-12-17 10:52:45 -05:00
f5317a519f
Merge pull request #3035 from oblakeerickson/update_username_return_json
...
Update username should return a json response
2014-12-17 11:23:33 +01:00
84bed4f9ce
Remove group name validation case sensitivity
2014-12-17 18:44:30 +13:00
521226f4c9
FIX: registration fails with timeout on gravatar
2014-12-15 22:10:27 +01:00
b2e2a99898
FIX: Don't raise an error when trying to log nothing
2014-12-15 14:14:12 -05:00
2d6b15a34d
Load fewer posts when the android platform is detected
2014-12-12 11:47:39 -05:00
1353557575
FIX: custom flags not possible on very long topic titles
2014-12-11 19:34:52 +01:00
02ade72ceb
Update username should return a json response
...
- Have update username return json response that contains the updated
username and id. I figured this would be better than just return "OK".
- Add test to verify that the new username is returned.
2014-12-10 09:43:16 -07:00
6027073547
FIX: properly unescape HTML entities in excerpts
2014-12-10 12:52:51 +01:00
9937af7ac4
disable sending email or show presence when forgot system user password
2014-12-10 14:17:56 +08:00
663cd93c6d
Move `register_asset` into `PluginRegistry` -- the logic works better
...
there.
2014-12-09 14:20:53 -05:00
1d0eccf710
Have activate user return json
...
- Change activate user from admin controller to return json
- Test that it returns json
- Remove unnessary test from log_out spec
This commit was created so that when you activate a user through the api
it returns a json response.
2014-12-08 11:16:57 -07:00
fdecd69228
Merge pull request #3026 from oblakeerickson/legacy_avatar
...
Remove legacy avatar code
2014-12-08 11:03:55 +11:00
e9e88c9b82
Remove legacy avatar code
...
- Remove method that was only left around because the
[api](https://github.com/discourse/discourse_api/pull/53 ) called it
- Modify test to use new route instead of legacy route
https://meta.discourse.org/t/legacy-route-for-avatars/22838/2
2014-12-07 06:13:14 -07:00
a4ce039c85
demock spec
2014-12-07 18:11:38 +11:00
929ff00741
FIX: use excerpt instead of the summary
2014-12-06 18:48:39 +01:00
dec881ac9d
Merge pull request #3024 from oblakeerickson/avatar_return_json
...
Have pick_avatar return json.
2014-12-06 18:20:42 +01:00
a61519eebf
Have pick_avatar return json.
...
I'm working on writing a test in the discourse_api gem for uploading
avatars and the pick method needs to return a json response.
I also added a test to make sure json is returned.
2014-12-06 09:26:32 -07:00
86c4c947a3
FIX: drastically simplify auto-close topic logic
...
Get rid of this nonsensical maximum-flow algorithm :fired:
2014-12-06 16:29:54 +01:00
cd170ca548
FEATURE: auto-close topics based on community flags
2014-12-05 19:37:43 +01:00
d28515792a
FIX: auto response email replies should not be accepted
2014-12-04 22:39:13 +05:30
4aa0d88c6c
FEATURE: search private messages option
2014-12-04 13:50:36 +11:00
efa872e426
optional custom value for category slug (create and update)
2014-12-03 16:23:59 -08:00
77a775ecd2
Merge pull request #3012 from techAPJ/patch-2
...
Add test for email with inline reply
2014-12-03 15:45:04 +01:00
f84bdfdde3
FIX: if full user name is not provided, username should be present in email From header
2014-12-03 13:12:05 +05:30
ea269ccfb2
rename purge_inactive to purge_unactivated
2014-12-02 21:36:25 -08:00
a8ff5fe97c
Merge pull request #3002 from jmay/group-membership-api
...
use limit & offset for pagination of group members
2014-12-03 11:11:10 +11:00
f226e4efc0
FIX: don't error out when updating a topic with no changes
2014-12-02 02:16:30 +01:00
15c105eba5
Add test for email with inline reply
2014-12-01 23:51:14 +05:30
64b06b360a
Merge pull request #3008 from oblakeerickson/log_out_return_success
...
Have log_out method return json
2014-12-01 14:26:06 +01:00
bdc92eec70
Have log_out method return json.
...
This commit helps improve the discourse_api experience so that we can
check the json response if it was a success or not. This commit also
checks that a 404 is sent instead of a 500 if a bad user_id is passed
in.
2014-12-01 06:03:25 -07:00
529014d56e
FEATURE: switch to GitHub email_reply_parser library and parse plain text email content
2014-12-01 09:00:35 +05:30
cb0e7a5724
For performance reasons, use `delete_all` when removing a user's email logs
2014-11-28 14:20:43 -05:00
5b90ceb71d
FEATURE: rolls up 1.2.*.* IP ranges when number of entries > 10
2014-11-27 19:29:30 +01:00
013f1a6dd0
FEATURE: allow creating admin and moderator accounts via SSO
2014-11-27 12:39:00 +11:00
4e735e8aab
FIX: roll up staff action wasn't working
2014-11-27 01:12:56 +01:00
10b5032188
FIX: auto-closing attribution when a TL4 user auto-closes a topic
2014-11-26 19:51:07 +01:00
27d78332c4
FEATURE: restrict some user fields for TL0 users when viewed by anonymous users
2014-11-26 19:20:03 +01:00
d7ef4f1edd
remove useless 'puts'
2014-11-26 16:40:03 +01:00
c10e3df012
FEATURE: implement SSO provider on Discourse so Auth can be farmed to it
...
FEATURE: pass return_sso_url to SSO endpoints, for easier return
2014-11-26 17:26:27 +11:00
d171d6db19
FEATURE: export sso data if sso is enabled
2014-11-26 09:43:28 +11:00
4c9f55d1e1
FIX: Suspended users should have links stripped from their profiles.
2014-11-25 16:14:39 -05:00
610c2a4d65
checking actual values in the spec, not just counts
2014-11-25 09:12:24 -08:00
0588292dcf
Merge pull request #2999 from riking/fix_top_referrers_topic_count
...
FIX: Topic referrals by user were wrong
2014-11-25 17:46:44 +01:00
728e8a262c
FIX: Admin panel referral stats not counting topics correctly
...
Due to what seems to be a bug in ActiveRecord, the distinct: true option
is not recognized on counts with string column names. This commit fixes
that by moving the DISTINCT into the count string.
For robustness, the integration spec for IncomingLinksReport was
rewritten to be an actual integration spec, running the actual interface
on actual fake data.
2014-11-24 12:16:52 -08:00
adb570fe53
use limit & offset for pagination of group members
2014-11-24 12:12:48 -08:00
7b0ae702e7
FEATURE: log a new staff action when rolling up banned IP addresses
2014-11-24 19:48:54 +01:00
17b6d3a2fe
FIX: Mailing list mode was not checking for user deleted posts
2014-11-24 11:43:40 -05:00
1023191315
FEATURE: roll up function for 123.456.789.* ranges
2014-11-24 17:25:48 +01:00
20044da474
FIX: cleanup commas in email From and Reply-to fields
2014-11-24 19:55:20 +05:30
4d936325e7
test forwarding works as expected
2014-11-24 17:16:11 +11:00
1c498eb491
FEATURE: API endpoint for inviting an admin
2014-11-24 15:42:56 +11:00
6f8119ebb8
Merge branch 'master' into group-admin-incremental
2014-11-21 10:04:05 -08:00
ced35cb3bb
FEATURE: don't limit registration from an IP address if a staff member has that IP address
2014-11-21 00:25:44 +01:00
dd1ebb535b
FIX: Could not download exported data on some sites
2014-11-20 14:02:10 -05:00
b8d806ee07
FEATURE: delete all accounts from this IP in the IP lookup modal
2014-11-20 19:59:20 +01:00
5f4e4de02a
FIX: Make `user_id` uniqueness check pending. It still seems to check
...
but the test fails. cc @SamSaffron
2014-11-20 13:42:37 -05:00
50de22801f
API addition: HTTP PATCH support for /groups/xxx: incremental membership changes
2014-11-20 09:29:56 -08:00
82a6e3aedc
Merge pull request #2988 from cpradio/pr-add-deleted-querystring-rebase
...
FEATURE: Add ?status=deleted querystring
2014-11-20 16:39:36 +01:00
0d6e5470d4
FEATURE: Add ?status=deleted querystring
...
Add tests around the ?status=deleted querystring
2014-11-20 10:32:33 -05:00
a9cda0f947
FEATURE: allow restricting API keys to a particular range
2014-11-20 15:21:49 +11:00
aebf36c356
remove /download from csv file url
2014-11-20 00:34:38 +05:30
c5f9dd4ef3
FEATURE: only limit new registrations from that IP if all the users from that IP are TL1 or TL0
2014-11-17 15:02:10 +01:00
7641d88224
FEATURE: new 'maximum new user accounts per registration IP' site setting
2014-11-17 12:04:29 +01:00
8240a00829
correct spec
2014-11-14 18:10:52 +11:00
6125b675b6
remove broken spec
2014-11-14 18:03:01 +11:00
a2ee213100
correct spec
2014-11-13 20:25:49 +11:00
564fb0b100
FIX: distributed cache leak and potential infinite loop
2014-11-13 18:31:42 +11:00
a8a0be0b34
FIX: change the unlisted/invisible topic state only when unhiding the first post
2014-11-12 16:34:30 +01:00
a036ac7bdc
FIX: users can see the raw email source of their own posts
2014-11-12 14:49:42 +01:00
5fd0841563
correct broken spec
2014-11-12 10:27:34 +11:00
c55fa9d5c8
PERF: distributed cache class to help sync caches between processes
2014-11-12 09:44:44 +11:00
a2ba9a735e
Merge pull request #2943 from fantasticfears/slug
...
Add stringex for Chinese slug generation
2014-11-12 08:57:59 +11:00
667758ff40
Add stringex for Chinese slug generation
2014-11-11 21:12:07 +08:00
4e85fc9dae
PERF: cache all site_text in memory
2014-11-11 16:28:59 +11:00
bddaf8193a
HAX: check the `message` object, not the `MessageDelivery` object
...
See 669bf73 for background. It's probably better to rewrite these test without
using the internal `NullMail` class anyway.
2014-11-10 01:05:47 -08:00
568ed3beaa
HAX: force the lazy `MessageDelivery` object to create the mailer
...
Starting from Rails 4.2, calling MyMailer.some_method no longer result in an
immediate call to MyMailer#some_method. Instead, a "lazy proxy" is returned
(this is changed to support #deliver_later). As a quick hack to fix the test,
calling #message (or anything, really) would force the Mailer object to be
created and the method invoked.
2014-11-10 01:05:46 -08:00
b1a0cd417d
Avoid a deprecation warning by poly-filling #deliver_now and #deliver_now
2014-11-10 01:05:46 -08:00
efc4109902
update specs to remove deprecation warnings
2014-11-07 06:05:44 -08:00
bb2d538194
FEATURE: log impersonations
2014-11-06 10:58:47 +01:00
a5616146eb
FIX: remove meta data from lightbox in both excerpt (html & text)
2014-11-05 20:37:00 +01:00
068d22e9b3
Add API support for querying admin reports by date range
2014-11-05 13:11:37 -05:00
c9eb809dad
FIX: The text to users who signed up when approval was required was
...
misleading.
2014-11-04 15:48:03 -05:00
862c8a19a3
FEATURE: use img's title attribute in overlay information when provided
2014-11-03 22:03:06 +01:00
bdb78ce76a
FEATURE: consider SVG as an image when authorized
2014-11-03 19:54:10 +01:00
fd5677808c
SPEC: make sure digest doesn't pick any topics in categories that are muted
2014-11-03 16:57:50 +01:00
b09ad87098
FIX: add 'show emails' button from moderators in user admin section
2014-11-03 12:46:08 +01:00
bdc7947cd6
rspec expect...to deprecations
2014-10-31 10:44:26 -07:00
2251877332
FIX: "Dismiss Posts" corrupting read state
...
REFACTOR: seen_post_count was a bad name, renamed to highest_seen_post_number
2014-10-31 09:40:35 +11:00
316f1bea04
SECURITY: Don't allow redirects with periods in case you don't control
...
other tlds on the same domain.
2014-10-30 11:31:44 -04:00
6e053942a4
FIX: moderators should be able to search users by email
2014-10-29 22:08:41 +01:00
7e94f9d6f9
FIX: insert different message when auto-closing a topic based on the last post
2014-10-29 21:26:32 +01:00
ada750b384
fixed some more deprecations. 20 to go
2014-10-29 16:06:50 +01:00
865194f409
FIX: cannot show email for pending/inactive users
2014-10-29 01:07:27 +01:00
3a11e5b52e
Merge pull request #2921 from techAPJ/patch-1
...
FIX: email replies should not be accepted for deleted topics
2014-10-28 14:11:33 +11:00
7d6d8bd0a3
FEATURE: admin end point to sync sso /admin/users/sync_sso
...
Must be admin to invoke (api is fine too), uses same sso payload nonce is ignored
2014-10-28 11:25:21 +11:00
e7f251c105
LOTS of changes to properly handle post/topic revisions
...
FIX: history revision can now properly be hidden
FIX: PostRevision serializer is now entirely dynamic to properly handle
hidden revisions
FIX: default history modal to "side by side" view on mobile
FIX: properly hiden which revision has been hidden
UX: inline category/user/wiki/post_type changes with the revision
details
FEATURE: new '/posts/:post_id/revisions/latest' endpoint to retrieve
latest revision
UX: do not show the hide/show revision button on mobile (no room for
them)
UX: remove CSS transitions on the buttons in the history modal
FIX: PostRevisor now handles all the changes that might create new
revisions
FIX: PostRevision.ensure_consistency! was wrong due to off by 1
mistake...
refactored topic's callbacks for better readability
extracted 'PostRevisionGuardian'
2014-10-27 22:06:43 +01:00
370f50250b
FIX: attachment links in mail lacks protocol
2014-10-28 00:08:51 +05:30
b37d845dd3
FIX: email replies should not be accepted for deleted topics
2014-10-27 13:05:33 +05:30
1cc37e32b9
FEATURE: add max_reply_history to limit number of replies
...
that can be expanded, when clicking "in-reply-to"
2014-10-27 09:44:42 +11:00
08dc0e6ee6
FIX: email replies to closed topic should not be accepted
2014-10-25 23:47:13 +05:30
38d901ac91
FIX: Do not show unconfirmed users in search results
2014-10-24 19:20:41 -04:00
a826840540
Moderators can search users by ip address
2014-10-23 23:30:11 +05:30
1035df46bf
FEATURE: search by ip address on admin user list page
2014-10-23 08:02:02 +05:30
e20e6b4524
PERF: stop using jQuery to sanitize strings
2014-10-22 15:48:18 +11:00
7659d491fd
Merge pull request #2897 from techAPJ/patch-1
...
FEATURE: show full user name in emails
2014-10-21 15:47:31 -04:00
8700716fcd
separate site setting for showing full name in emails
2014-10-22 00:50:39 +05:30
83068fab94
FEATURE: show full name in emails
2014-10-21 23:34:44 +05:30
4eb1288dba
FIX: Broken spec from @coding-horror
2014-10-20 17:13:45 -04:00
71f211f0b3
FEATURE: Allow users to select a badge with an image to appear on their
...
user card
2014-10-20 16:35:38 -04:00
1cf4a0d604
Rename "User Expansion" to the much clearer "User Card"
2014-10-20 12:11:59 -04:00
10094a0bcd
FIX: resolve flags as good when deleting a spam user
2014-10-20 16:59:06 +02:00
92b615b503
reorganize site settings a bit
2014-10-19 23:14:50 -07:00
e6cc4cba8b
FEATURE: in:tracking and in:watching search filters
2014-10-18 15:34:05 +11:00
8afd7a7f21
FEATURE: in:likes and in:posted search filters
2014-10-18 15:19:08 +11:00
cbc132eca9
FEATURE: added status:noreplies and status:archived to advanced search
2014-10-18 14:54:11 +11:00
f8237e2ac0
add spec for raw_email action
2014-10-18 22:36:08 +05:30
2131a37811
FEATURE: show raw email for replies/topics created via email
2014-10-17 22:22:19 +05:30
f3a67a48a3
Merge pull request #2874 from cpradio/clear-notifications
...
FEATURE: Mark All as Read button for Notifications page
2014-10-16 15:57:19 -04:00
1f95cfedc3
[patch] When a post is split out to be a new topic
...
the topic's last_post_user_id is set to the user who split out
the post. But, this should really be the user_id of the last post
of the split out posts.
2014-10-16 12:38:26 -07:00
4d465362b5
FEATURE: Allow a user to upload an image for their expansion background.
2014-10-16 15:05:36 -04:00
31e9cafe0e
FEATURE: use original filename when clicking the download link in the lightbox
2014-10-15 19:20:04 +02:00
8f390c979b
FEATURE: Mark All as Read button for Notifications page
...
Added a Mark All as Read button to the top/bottom of the notifications user page
https://meta.discourse.org/t/possibility-to-selectively-or-completely-mark-notifications-as-read/20227
Remove notifications property (no longer used)
2014-10-13 06:31:27 -04:00
366d7e892c
Merge pull request #2867 from techAPJ/patch-1
...
FEATURE: send `set password` instructions after invite redemption
2014-10-14 11:01:07 -04:00
1f42e85e0d
Merge pull request #2873 from mcwumbly/hide-post-revisions
...
FEATURE: ability to hide/show specific post revisions
2014-10-14 16:45:17 +02:00
19d5362c6b
FEATURE: ability to hide or show specific post revisions
2014-10-14 07:19:45 -07:00
24a0db3244
FIX: fix email replies for ms outlook
2014-10-14 16:20:35 +05:30
861f321263
FEATURE: send set password instructions after invite redemption
2014-10-11 14:13:05 +05:30
5754e8dd0f
FEATURE: auto-close topics based on last post
2014-10-10 18:21:44 +02:00
e8637344c3
Merge pull request #2864 from techAPJ/patch-3
...
FIX: invite email should be verified against `email_domains_blacklist`
2014-10-09 11:24:04 -04:00
430967c354
FIX: invite email should be verified against email_domains_blacklist
2014-10-09 20:21:01 +05:30
7e8c4b63f4
FIX: only show agreed abd deferred flags on user's profile
2014-10-09 16:10:16 +02:00
f834a5fe4e
correct spec
2014-10-09 22:27:34 +11:00
47d48b4dd8
FEATURE: add Precedence header
2014-10-09 01:40:48 +05:30
0c739bb5b6
Merge pull request #2860 from techAPJ/patch-2
...
include category in List-Id instead of topic
2014-10-08 15:28:41 -04:00
f9a8f6d6ce
FEATURE: Support for a `required` setting on user fields.
2014-10-08 15:10:19 -04:00
c53f635b2c
include category in List-Id instead of topic
2014-10-09 00:34:27 +05:30
a059da5d39
Merge pull request #2859 from techAPJ/patch-1
...
FIX: handle multiple paragraphs in email reply when parsing html
2014-10-08 13:44:24 -04:00
1f26a79899
FIX: Category latest pages were not preloading properly, causing weird
...
refreshes when clicking the home logo.
2014-10-08 12:45:18 -04:00
b457005b07
FIX: handle multiple paragraphs in email reply when parsing html
2014-10-08 19:45:46 +05:30
0e7be81e60
FIX: badge granted titles were not being revoked when badge was revoked
2014-10-08 10:26:18 +11:00
2fbfc9dffa
FIX: Editing a topic's title should be rate limited too.
2014-10-07 16:46:01 -04:00
a30e70e8f1
FEATURE: trust level 3: likes received must be on min_likes_received/3 different days, and be from min_likes_received/4 different users
2014-10-07 15:52:54 -04:00
1252e7324f
Added easy impersonate route while in development mode
2014-10-07 12:25:50 -04:00
c46b9c0ac3
FIX: allow admins to search users by email
2014-10-07 12:05:38 +02:00
836bc0f935
FIX: incorrect edit notification in user stream
...
FIX: missing edit notifications when post edited by multiple users
2014-10-07 15:57:48 +11:00
e383a8ab01
Merge pull request #2854 from techAPJ/patch-1
...
Feature: resend invites
2014-10-06 17:25:36 -04:00
ad387a1150
FEATURE: posts will be deleted immediately if delete_removed_posts_after is set to 0
2014-10-06 16:30:07 -04:00
78fd99fc40
Feature: resend invites
2014-10-07 01:43:17 +05:30
20c2480eb3
FIX: fix broken test
2014-10-07 01:23:39 +05:30
b1271ed44b
FIX: Remove html entities from text emails
2014-10-06 13:57:38 -04:00
aeba5ca7d9
Merge pull request #2842 from techAPJ/patch-2
...
FEATURE: show topic category in email subject
2014-10-03 12:52:34 -04:00
0ae0552543
FEATURE: show topic category in email subject
2014-10-03 22:08:59 +05:30
0d1b460f1e
Pending spec for Nokogiri fix
2014-10-03 12:37:07 +10:00
090dc80f8a
FIX: work around random encoding errors
...
(symptom is that site is blank see: https://meta.discourse.org/t/actionview-template-error-incompatible-character-encodings-utf-8-and-ascii-8bit/19970 )
2014-10-03 10:41:52 +10:00
381814fd5d
Adds support for a description to user fields.
2014-10-02 15:56:52 -04:00
29bb9eaa89
Merge pull request #2835 from techAPJ/patch-2
...
add user email on account created page
2014-10-02 17:29:26 +10:00
41af2d79b5
add user email on account created page
2014-10-02 12:43:44 +05:30
70884d2436
FEATURE: automatically hide posts made by TL0 users when flagged by a TL3 user
2014-10-01 18:53:17 +02:00
98b6b9821a
FEATURE: log topic/post deletions from staff members
2014-10-01 17:40:13 +02:00
edb34c178a
FEATURE: Show user fields when the user is signing up
2014-09-30 10:45:18 -04:00
4bcd4e05b8
correct spec
2014-09-30 13:16:34 +10:00
e665bfd72a
Fix test failure
2014-09-30 13:16:34 +10:00
a7a1dcadcc
use the right HTTP verb
2014-09-29 22:41:54 +02:00
7e309a21cf
FEATURE: hide emails behind a button for staff members
2014-09-29 22:31:05 +02:00
ff795a267d
Merge pull request #2826 from techAPJ/patch-1
...
FEATURE: add site preference for standard subjects, including support for Re
2014-09-29 15:29:22 -04:00
652cc3efba
FEATURE: new rake task to clean up uploads & thumbnails
2014-09-29 18:31:53 +02:00
330b7ba54a
FEATURE: add site preference for standard subjects, including support for Re
2014-09-29 21:54:29 +05:30
0fc0533134
FEATURE: Admin interface for adding custom fields for users
2014-09-25 16:17:51 -04:00
69400a802f
FEATURE: auto-delete any hidden posts that stay hidden for more than 30 days
2014-09-25 19:51:00 +02:00
de76b512c1
fix most deprecations in the specs (still some left)
2014-09-25 17:44:48 +02:00
dd5872eecb
remove warnings
2014-09-25 17:46:51 +10:00
c248d28c38
FEATURE: display associated accounts in admin user
2014-09-25 16:15:01 +10:00
c43f6455f2
hold back some gems, do fix rspec issue
2014-09-25 11:04:22 +10:00
ffa11bd1d6
remove cruft
2014-09-25 09:50:43 +10:00
bfdbb70b3b
FIX: automatic backup uploads to S3 when using a region
2014-09-24 22:52:09 +02:00
bc53d48bd7
Renaming site contents to site text
2014-09-24 16:08:14 -04:00
d96acdeafa
FEATURE: screened IP address range can be entered like 192.* instead of 192.*.*.*
2014-09-24 12:05:29 -04:00
5681338b08
FIX: log a staff action + send a private message when disabling the 'download_remote_images_to_local' site setting
2014-09-23 19:11:43 +02:00
58eabb03e5
FEATURE: api support for arbitrary unlinked assets
...
admins can set retain periods for assets
2014-09-23 16:50:17 +10:00
d1f6aba71f
fix test
2014-09-23 09:55:30 +10:00
9428ad779f
FIX: send content length with backups
2014-09-23 09:25:53 +10:00
7a4082cbad
FIX: allow API to create users when invite_only is true
2014-09-23 09:06:19 +10:00
223f3eebfc
Merge pull request #2814 from cpradio/add-bulk-archive-option
...
FEATURE: Add Archive Topics to Bulk actions
2014-09-22 15:01:40 -04:00
afdbb2bb96
FEATURE: Add Archive Topics to Bulk actions
...
Add the ability to archive topics in bulk
https://meta.discourse.org/t/archive-topics-via-bulk/20302
2014-09-22 14:56:48 -04:00
0b13f6572f
FEATURE: staff option to unhide a post
2014-09-22 18:55:13 +02:00
8c74255cbb
FIX: 404 if we try to navigate to a non-existant page
2014-09-22 17:08:11 +10:00
5646ebf4c7
fix tests expecting "name said:" to "name:"
2014-09-18 20:39:27 -07:00
d6a562658a
FIX: update user preferences was failing if custom_fields is blank string
2014-09-17 13:09:39 -04:00
19b4364d79
SECURITY: Stripping links could unescape html fragments
2014-09-17 12:08:00 -04:00
c16b8364ab
FIX: Support ember app routing to topics with only slugs
2014-09-17 11:18:59 -04:00
309b67add4
FIX: If a post has been hidden due to flagging, don't use the absolute
...
edit window for edit prevention.
2014-09-16 11:21:14 -04:00
38202d5037
Adds govcloud region to s3 region list
2014-09-15 19:34:12 +01:00
2c6d03f87f
SECURITY: Limit passwords to 200 characters
...
Prevents layer 8 attack.
2014-09-12 12:07:11 -04:00
eb512f07a7
FIX: Spec failures for feeds related to enabling categories as default
...
page for anons when latest is deleted.
2014-09-11 15:30:41 -04:00
e56fcf0c43
FEATURE: add 'rebake post' in post wrench menu
2014-09-11 16:04:40 +02:00
0f585bcdbe
FIX: PM should never be allowed to have a category
...
FIX: TL3 should not be allowed to muck with PM titles
2014-09-11 17:39:34 +10:00
7f3797b635
FEATURE: Nice Topic, Good Topic and Great Topic badges
...
Note we will revoke all old badges post badges that went to post #1
and instead get topic badges
2014-09-11 12:36:37 +10:00
aa21969d99
fix incorrect spec
2014-09-11 11:31:31 +10:00
18f8038015
FEATURE: add new 'convert to staff message' in post wrench menu
2014-09-10 23:08:33 +02:00
8c02f47f23
Merge pull request #2760 from riking/email-on-wrote
...
Add "On DATE, Name wrote:" email trimming trigger
2014-09-10 09:48:30 +10:00
Sam
Neil Lalonde
Régis Hanol
Sigurður Guðbrandsson
Robin Ward
Dan Singerman
Arpit Jalan
Loïc Guitaut
riking
Greg Kempe
Jason W. May
Luciano Sousa
Jeff Atwood
Erick Guan
jaanus
James Kiesel
Blake Erickson
cpradio
Godfrey Chan
David McClure
Michael Verdi
Jonathan Richard Henry Evans (JRHE)