142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
5012d46cbd
Add rubocop to our build. ( #5004 )
2017-07-28 10:20:09 +09:00
b70d4da858
FIX: Only invite admins when automatic backup fails.
2017-06-15 14:04:22 +08:00
f6060bfbf6
Invite admins to automatic backups failure topic.
...
https://meta.discourse.org/t/if-automatic-backup-fails-there-should-be-a-warning/64461
2017-06-14 15:01:11 +09:00
5ce8d7a8c5
Log all errors during clean up as well.
2017-06-14 11:03:50 +09:00
83110a1a81
FIX: allow tar to finish if files change during backup
2017-06-07 13:31:02 -07:00
a4deb0e47d
Fix typo.
2017-03-24 20:59:34 +08:00
e7c972ac89
FIX: Don't use backticks that take in inputs.
2017-03-17 15:33:51 +08:00
f63a797e39
SECUIRTY: Escape input made to system calls.
2016-09-16 11:58:14 +08:00
3e4b02bbd4
FIX: Make sure constant reflects the right backup extenstion.
2016-08-24 10:28:23 +08:00
8539f02b5e
FIX: Backuper should return the full path.
2016-08-08 07:49:37 +08:00
adc8336949
Make sure we track restore/backlog success logs as well.
2016-08-03 16:23:47 +08:00
b860d1b254
FIX: Ensure uploads directory exists.
2016-08-03 16:23:47 +08:00
0a942dbc73
FEATURE: Avoid creating an archive for database only backups.
2016-08-03 16:23:46 +08:00
03aa13b2bb
FEATURE: Work with compressed version of `pg_dump` during backup and restore.
2016-07-26 10:24:01 +08:00
1adfa0a4b5
FEATURE: Add SiteSetting to disable readonly mode during backup.
2016-07-19 17:44:04 +08:00
b981041f6f
Make sure we log failures in `ensure` block.
2016-07-15 11:36:47 +08:00
166d753bd3
FIX: delete PostgreSQL dump before gzipping archive ( #4323 )
2016-07-12 14:23:26 +02:00
ed53a24dbe
FIX: backup was failing on large instances ( #4319 )
2016-07-11 08:36:20 +01:00
8c52508007
warn users it may take a while to un/zip backup
2016-05-23 09:33:29 +02:00
4d8eb25148
let's explicitly use gzip level 5 here
...
see http://tukaani.org/lzma/benchmarks.html
2016-01-11 03:03:14 -08:00
a726f5efea
FIX: ensure we always remove old backups
2015-09-21 10:52:03 +02:00
96c23d51a2
FIX: don't break the message bus when restoring a backup
2015-08-27 20:02:13 +02:00
803feefd54
MessageBus handles readonly redis now, no need to wrap it
2015-05-04 12:21:00 +10:00
5b3f99aa50
Don't blow up if Redis switches to READONLY
2015-04-24 14:37:16 -04:00
cbd1df1963
PERF: gzip --best can be very slow, use standard compression
2015-03-31 15:13:53 +11:00
c0881a6a7d
single quote password in backup command
...
This protects against characters like '&' in passwords. Sometimes you are assigned passwords by idiots or are and idiot that uses pronounceable passwords. Anyways this small change protects against ruby's shell interpreter from background the pg_dump command before it has really started.
2015-03-19 08:39:15 -07:00
c9a007d5fb
FIX: backup logs on Firefox
...
FIX: debounce backup logs in order to prevent Firefox crash
FIX: 'Invalid date' in backup logs in Firefox
2015-02-09 16:53:28 +01:00
49b02287dc
FEATURE: remove any .tar leftovers when backing up
2015-02-04 11:49:11 +01:00
5504622c1b
rename export/import in favor of backup/restore for better consistency
2014-10-10 20:04:07 +02:00
Guo Xiang Tan
Guo Xiang Tan
Jay Pfaffman
Arpit Jalan
Régis Hanol
Jeff Atwood
Sam
Robin Ward
Erik Ordway