Commit Graph

13242 Commits

Author SHA1 Message Date
Neil Lalonde 6e47e02738 FIX: edit category modal throws EmberError when allowed tag groups is set 2017-01-26 15:32:24 -05:00
Rafael dos Santos Silva 60f30aa6ad UX: Remove 'no thanks' from remind tomorrow CTA 2017-01-26 17:47:52 -02:00
Sam 06638c78e7 Merge pull request #4617 from claygriffiths/trailingslash-message-bus
Fix: Forced trailing slash on messageBus.baseUrl
2017-01-26 12:03:06 -05:00
Robin Ward 496682c442 Merge pull request #4662 from tgxworld/fix_localized_group_name_change
Fix localized group name change
2017-01-26 10:50:00 -05:00
Robin Ward a7ba69075b Merge pull request #4667 from joebuhlig/user-nav-plugin-outlet
FEATURE: Add user-main-nav plugin outlet
2017-01-26 10:48:24 -05:00
Régis Hanol 810176be5b Merge branch 'master' into master 2017-01-26 10:56:25 +01:00
Jeff Atwood 43a8a7c812 de-emphasize display mode buttons on revision view 2017-01-26 00:02:19 -08:00
Guo Xiang Tan ee7c7c347a Merge pull request #4673 from tgxworld/edit_post_button_wiki_post_revision
Add edit post button to post revision modal for wiki-ed posts.
2017-01-26 13:33:55 +08:00
Guo Xiang Tan bed11dfa0e FIX: Polls permanently broken if post requires approval. 2017-01-26 13:29:43 +08:00
Arpit Jalan 9dd09e453b FEATURE: add explicit confirmation button to accept the invite 2017-01-25 15:50:30 +05:30
Guo Xiang Tan 06c651f8c9 FIX: Don't skip callbacks when rebaking posts. 2017-01-25 17:47:13 +08:00
Guo Xiang Tan ee396edd9c Add edit post button to post revision modal for wiki-ed posts. 2017-01-25 14:36:00 +08:00
Guo Xiang Tan 781d83a46f FIX: Toggling a post's wiki status should not skip revision. 2017-01-25 13:34:55 +08:00
Guo Xiang Tan efc21366ae FIX: Incorrect parameter being passed to component. 2017-01-25 13:12:38 +08:00
Guo Xiang Tan 0a25df67bc Revert "FIX: Incorrect parameter being passed to component."
This reverts commit d354a6f7a4.
2017-01-25 13:12:24 +08:00
Guo Xiang Tan d354a6f7a4 FIX: Incorrect parameter being passed to component. 2017-01-25 13:09:08 +08:00
Neil Lalonde ff508ed75f UX: red notification of flags or pending approvals opens hamburger menu instead of linking to flags page 2017-01-23 14:34:06 -05:00
Régis Hanol 7e52d29a5b Merge pull request #4643 from LeoMcA/fix-pull-img
FIX: Handle img src starting with "//" in pull_hotlinked_images job
2017-01-23 17:56:53 +01:00
Joe Buhlig 60c2787e64 FEATURE: Add user-main-nav plugin outlet 2017-01-20 07:15:07 -06:00
Guo Xiang Tan 32846aad2a FIX: Toggling post's wiki status should not create a new version. 2017-01-20 15:42:33 +08:00
Neil Lalonde 6b93b09404 FIX: when blocking a user results in hiding their posts, only hide posts made in the last 24 hours 2017-01-19 15:56:22 -05:00
Leo McArdle e4ad88019b add category-navigation plugin outlet 2017-01-19 17:35:22 +00:00
Arpit Jalan 0791c2c966 FIX: sso_overrides_avatar should override previously set avatar 2017-01-19 10:52:24 +05:30
Neil Lalonde 61d4c1203e FEATURE: group avatar flair shows on topic participants list, and participant avatars can have custom styles 2017-01-18 11:38:00 -05:00
Jeff Atwood 095ec9cf63 minor css change to user page 2017-01-18 01:11:49 -08:00
Guo Xiang Tan 706b4f6b9f FEATURE: Remap group mentions when group name has been changed. 2017-01-18 13:39:34 +08:00
Guo Xiang Tan 59dfb51a35 FIX: Don't change automatic group name if localized name has been taken. 2017-01-18 12:20:23 +08:00
Neil Lalonde bfc52a8e6f FIX: long titles need a max-width in composer when replying on desktop view 2017-01-17 15:14:58 -05:00
Robin Ward 0c71e37aab Merge pull request #4660 from ryantm/serversideonly
add more SERVER_SIDE_ONLY routes; use pathname in matching
2017-01-17 13:55:40 -05:00
Ryan Mulligan f641655f1b add more SERVER_SIDE_ONLY routes; use pathname in matching 2017-01-17 09:51:39 -08:00
Robin Ward 11641fb3cd Whitelist the alternative `raw` url 2017-01-17 11:11:27 -05:00
Guo Xiang Tan fc52624aac Fix undefined `attrs`. 2017-01-17 16:31:57 +08:00
Guo Xiang Tan ee58c4cd94 FIX: Don't close search menu on link clicked when context is enabled. 2017-01-17 12:35:48 +08:00
Guo Xiang Tan de6ca4f736 FIX: Pressing enter when searchContext is enabled should just trigger a search. 2017-01-17 11:01:33 +08:00
Guo Xiang Tan c76ee788a7 Merge pull request #4656 from tgxworld/dont_display_an_extra_button_for_wiki_post
UX: Display wiki icon on post edits indicator.
2017-01-17 06:34:43 +08:00
Guo Xiang Tan 17da0bd11f UX: Display wiki icon on post edits indicator. 2017-01-17 06:33:58 +08:00
Neil Lalonde 60a9030d25 UX: don't show search and hamburger menus to anon visitors on login-required sites 2017-01-16 16:33:14 -05:00
James Kiesel 1d8882a1dd oops semicolons 2017-01-17 08:20:57 +13:00
James Kiesel 646b49e5ae Expose reopenWidget through plugin api 2017-01-17 08:19:29 +13:00
Régis Hanol fbf9172db8 FIX: log backups download/destroy staff action
FIX: clean up junk left by the specs
RENAME: 'backup_operation' to 'backup_create' to match other backup log types
2017-01-16 19:53:31 +01:00
Rafael dos Santos Silva 116e74325a FIX: Topic Status should display on categories and topic view 2017-01-16 15:04:33 -02:00
Robin Ward 5f7a33efe5 FIX: [object Object] when hovering over view count 2017-01-16 12:02:32 -05:00
Robin Ward 3db3ee65b7 UX: Make it easier for plugins to add stuff before topics on the list 2017-01-16 11:53:09 -05:00
Robin Ward 86c52c72f6 FIX: Deleting a user was not deleting their directory items 2017-01-16 11:46:52 -05:00
James Kiesel 513f570936 Add reopenWidget method 2017-01-17 00:39:23 +13:00
Leo McArdle b60e9b7330 FIX: Handle img src starting with "//" in pull_hotlinked_images job 2017-01-16 10:50:07 +00:00
Guo Xiang Tan 63954c1b33 FIX: Same user record being saved twice causing validation to fail. 2017-01-16 16:41:03 +08:00
Guo Xiang Tan e3b6f9b8ae FIX: Do not update user stats like counts for private messages. 2017-01-16 11:07:53 +08:00
Guo Xiang Tan ed5fa20b0c Revert "FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level"
This reverts commit 9c40657ba4.

Calling this whenever a user is initialize is hurting us bad
on performance.
2017-01-16 09:44:10 +08:00
Jeff Atwood 56abe065bc tighten header margin on onebox 2017-01-14 22:11:46 -08:00
cpradio d0a3dc10d8 FIX: RSS Language should use a dash/hypen instead of underscore 2017-01-14 14:24:21 -05:00
Robin Ward 5f08630c27 Update topic status to use more ES6 features, clean up 2017-01-13 15:49:31 -05:00
Neil Lalonde e8307ac24c FIX: mailing list mode digest emails included whispers 2017-01-13 13:46:33 -05:00
Robin Ward adb73180f7 FEATURE: Let plugins register themes easily 2017-01-13 11:50:52 -05:00
Guo Xiang Tan 0f574f641e UX: Truncate topic link title/URL on desktop to prevent overflow. 2017-01-12 12:24:39 +08:00
Guo Xiang Tan 515f50e42e FEATURE: Log admin action when readonly mode is changed. 2017-01-12 09:41:02 +08:00
Jeff Atwood 240c4870cf FIX: add noopener to website field in user profile 2017-01-11 15:38:37 -08:00
Régis Hanol 887e9af84f FEATURE: new 'max_image_megapixels' site setting 2017-01-11 23:37:12 +01:00
Robin Ward 6c3426d266 Let's not notify for trust levels on Staff, either 2017-01-11 11:25:04 -05:00
Arpit Jalan e793caf3e3 FIX: only allow CSV file to be uploaded for bulk invite 2017-01-11 16:26:01 +05:30
Guo Xiang Tan d6bf5b0e78 Use `any` orientation for web app manifest. 2017-01-11 17:32:24 +08:00
Guo Xiang Tan 1758af9a1d FIX: Perform emoji unescape for topic titles in quotes. 2017-01-11 17:23:13 +08:00
Guo Xiang Tan cdd550e947 Use a different Redis key when PG failover sets site to readonly mode. 2017-01-11 16:38:49 +08:00
Guo Xiang Tan 77045eb1f1 Merge pull request #4644 from olach/tab-size
Display tabs with smaller widths for code blocks
2017-01-11 14:49:16 +08:00
Neil Lalonde 98bd58df61 Don't show email of deleted users in staff action logs 2017-01-10 17:25:36 -05:00
Neil Lalonde fc0a0a76a4 Add more info in staff action logs for blocking a user, and add logging for lock trust level, activate, and deactive user 2017-01-10 17:25:36 -05:00
Robin Ward 7341b0d03c Don't give notifications to admins for trust level notifications 2017-01-10 12:18:48 -05:00
Ola Christensson 82fab2343f Display tabs with smaller widths for code blocks
The default browser behavior is a tab width of 8 characters. This changes the width to 4 characters.
2017-01-10 10:06:53 +01:00
Robin Ward b60bc47a4c Plugins can register providers for global settings 2017-01-09 17:18:58 -05:00
Neil Lalonde d9146de080 FIX: an image can be shown twice in summary emails 2017-01-09 13:27:43 -05:00
Guo Xiang Tan 3d21ccd4a5 FIX: Add validation to disallow censored words in topic title. 2017-01-09 16:55:41 +08:00
Guo Xiang Tan cbc6aee137 UX: Display large numbers with delimiters. 2017-01-09 15:56:02 +08:00
Guo Xiang Tan aa9ac0d8b2 Make eslint happy. 2017-01-09 13:59:00 +08:00
Guo Xiang Tan fed7218deb UX: Observe changes to plugin to hide/show plugin admin link without refresh. 2017-01-09 13:56:15 +08:00
Guo Xiang Tan e721e31699 FIX: Login modal on mobile does not submit on enter. 2017-01-09 13:20:53 +08:00
Guo Xiang Tan 98df6db0eb FIX: Respect site setting to hide username in mailing list summary. 2017-01-09 12:18:30 +08:00
Guo Xiang Tan 4a7d6ea751 Make eslint happy. 2017-01-09 11:24:55 +08:00
Guo Xiang Tan c260a4e34d FIX: Can't add categories when creating a new web hook. 2017-01-09 11:22:35 +08:00
Arpit Jalan c834d591a3 use Ember.set() to set the `dasherized_name` property 2017-01-06 23:13:31 +05:30
Robin Ward 1b92d44fb2 FIX: A component referenced the controller 2017-01-06 10:45:48 -05:00
Guo Xiang Tan 389e1d0bd5 Add acceptance JS tests for group membership button. 2017-01-06 11:56:10 +08:00
Guo Xiang Tan a4e7657bbf FIX: Missing action to show login modal on group page. 2017-01-06 11:40:32 +08:00
Guo Xiang Tan 68300f515c FIX: Return 404 if id is not valid. 2017-01-06 10:39:44 +08:00
Guo Xiang Tan d10fe51b72 Fix broken specs since all urls will be oneboxed. 2017-01-06 10:05:51 +08:00
Neil Lalonde 685e6bdbab FIX: tags canonical url can raise error or be wrong 2017-01-05 15:17:23 -05:00
Robin Ward 7c8095294d FIX: Raw plugin outlets were broken 2017-01-05 11:38:57 -05:00
Claas Augner bec10ada2a
Remove unused email templates from controller 2017-01-05 15:31:14 +01:00
Arpit Jalan 6d26e348b6 FIX: 'add permalink' feature was broken 2017-01-05 18:50:17 +05:30
Régis Hanol 937ea5e9c3 Merge pull request #4636 from caugner/fix-translate-titles-of-email-templates
FIX: Translate titles of email templates
2017-01-05 09:48:12 +01:00
Régis Hanol caf704068c Merge pull request #4635 from caugner/fix-add-emoji-custom-class
FIX: Add emoji-custom class in custom emojis list.
2017-01-05 09:47:30 +01:00
Régis Hanol 6f396a0881 Merge pull request #4637 from caugner/ux-add-icon-for-bookmarks-report
UX: Add icon for bookmarks report
2017-01-05 09:47:05 +01:00
Arpit Jalan 7a1ff59822 FIX: PM email to suspended member was broken 2017-01-05 13:58:14 +05:30
Claas Augner 9710b04c31
UX: Add icon for bookmarks report 2017-01-05 02:07:38 +01:00
Claas Augner ad86d4a3e3
FIX: Translate titles of email templates 2017-01-05 01:26:38 +01:00
Claas Augner 2c723f8323
FIX: Add emoji-custom class in custom emojis list. 2017-01-04 23:54:03 +01:00
Robin Ward 846cd523b6 FIX: Broken plugin outlet 2017-01-04 11:52:19 -05:00
Régis Hanol cbcb9363f4 fix the build 2017-01-04 14:23:21 +01:00
Guo Xiang Tan 5098baee2f FIX: Undefined variable. 2017-01-04 17:37:23 +08:00
Guo Xiang Tan 43d950f813 FIX CSS for autocomplete. 2017-01-04 12:37:02 +08:00
Guo Xiang Tan 43671b1fda UX: Display group fullname in mention autocomplete. 2017-01-04 11:40:14 +08:00
Jeff Atwood 878af4c8b1 add tiny bit of space to email summary 2017-01-03 15:45:29 -08:00
Jeff Atwood 4e44845714 de-emphasize onebox URL field with color 2017-01-03 14:08:56 -08:00
Jeff Atwood b58a6804c2 reduce font size on mobile prog expansion 2017-01-03 11:17:12 -08:00
Neil Lalonde 9c79bf1865 FIX: .bullet + .topic-header-extra pixel perfect vertical alignment 2017-01-03 14:00:14 -05:00
Rafael dos Santos Silva d3fb724578 Merge pull request #4632 from xfalcox/native-app-banner
FEATURE: Opt-in native Discourse app install banner
2017-01-03 16:32:24 -02:00
Robin Ward 1bf912f3ac FIX: Back button was not working in long topics with many deleted 2017-01-03 13:17:11 -05:00
Rafael dos Santos Silva d7c8c2d5e3 FEATURE: Opt-in native Discourse app install banner on Android/iOS 2017-01-03 15:50:45 -02:00
Robin Ward bee8425055 FIX: Don't reply as new topic when quoting a closed topic 2017-01-03 11:49:20 -05:00
Neil Lalonde b72014423e FIX: summary email wrong background colour above popular posts 2017-01-03 11:05:54 -05:00
Arpit Jalan 615fd2eb87 UX: sane max-height for onebox images 2017-01-03 21:06:49 +05:30
Guo Xiang Tan a9a0e626db FIX: Group page tabs not displaying for normal users. 2017-01-03 17:56:13 +08:00
Guo Xiang Tan ad4a96d387 FIX: Only send membership request to the last 5 active group owners. 2017-01-03 15:33:57 +08:00
Guo Xiang Tan 7ce4bc2e90 UX: Show spinning icon while group members load. 2017-01-03 14:58:14 +08:00
Guo Xiang Tan 3aed15c99e FIX: Group membership button now showing properly. 2017-01-03 14:36:56 +08:00
Guo Xiang Tan 761d524024 Merge pull request #4602 from tgxworld/fix_likes_being_quoted
FIX: Only quote `.cooked` text.
2017-01-03 14:02:21 +08:00
Guo Xiang Tan 8a4e9c1940 Merge pull request #4633 from xfalcox/resize-emoji-full-path
FIX: Use full path for emoji resize job
2017-01-03 14:00:00 +08:00
Guo Xiang Tan 980cea7081 FIX: Add length validation for `User#name`. 2017-01-03 13:42:33 +08:00
Guo Xiang Tan 1cf0401e26 Allow option to not include title on emoji images. 2017-01-03 11:07:55 +08:00
Guo Xiang Tan ecb1078343 FIX: `user-card-post-names` outlet should be a `div`. 2017-01-03 10:39:41 +08:00
Guo Xiang Tan 40deef32e3 UX: Automatic width for fontawesome icons on groups page. 2017-01-03 10:07:59 +08:00
Jeff Atwood bbb3217f6a add opacity to quote button 2017-01-02 14:17:09 -08:00
Rafael dos Santos Silva 9ee67ad89c FIX: Use full path for emoji resize job 2017-01-02 13:34:32 -02:00
Régis Hanol c4552ef8c1 slightly shorter regexp for OptimizedImage.safe_path? 2017-01-02 16:28:14 +01:00
Régis Hanol d8be3e8bb1 UX: ensure we only allow images when uploading an avatar, user card background, etc... 2017-01-02 11:37:56 +01:00
Jeff Atwood 5db57abd7f fix onebox header misalignment issue 2017-01-02 02:22:57 -08:00
Jeff Atwood cd5130258d minor tweaks to mobile progress bar overlay 2017-01-02 02:06:26 -08:00
Neil Lalonde 225e6703ba FIX: summary shows 0 new topics even though it shows some topics 2016-12-30 15:18:13 -05:00
Robin Ward 32301f4620 FIX: Forgot Password route was broken 2016-12-30 12:47:04 -05:00
Robin Ward da76dd3d6b REFACTOR: Cleaner `quoteButton` object, and some bug fixes 2016-12-30 12:14:56 -05:00
Neil Lalonde 477b237e45 FIX: use 'other' instead of 'many' for Ukrainian pluralization until translations are fixed 2016-12-30 11:49:25 -05:00
Guo Xiang Tan c8553315b4 UX: Add `min-width` to `.select2-container`. 2016-12-30 14:38:53 +08:00
Guo Xiang Tan dbd0fcc86d UX: Add border to `.modal-header` on mobile. 2016-12-30 13:58:37 +08:00
Guo Xiang Tan f1beef43a8 Merge pull request #4618 from tgxworld/fix_invalid_emails
FIX: Don't allow invalid email to be saved.
2016-12-30 07:11:48 +08:00
Neil Lalonde 0f484e11fe FIX: Popular Posts heading in summary emails was a different style than other headings 2016-12-29 15:33:53 -05:00
Neil Lalonde 0105a406d4 FIX: spacing and alignment of title, category, tags, and featured links in topic page heading on mobile and desktop 2016-12-29 14:59:30 -05:00
Neil Lalonde 9fad338650 FIX: tags weren't showing on /top 2016-12-29 14:07:33 -05:00
Robin Ward 61584f6c0c UX: Improve composer heights in some resolutions 2016-12-29 12:51:57 -05:00
Arpit Jalan a1f0375f1c FIX: correct route for updating user title 2016-12-29 23:07:57 +05:30
Régis Hanol 1debf98d61 Merge pull request #4629 from caugner/fix-user-index-translate-boolean-values
FIX: Translate all boolean values in user index
2016-12-29 14:46:45 +01:00
Régis Hanol f71040dc23 Merge pull request #4630 from caugner/feature-preserve-cursor-in-editor-upload
FEATURE: Preserve cursor in editor upload
2016-12-29 14:46:10 +01:00
Claas Augner 2e9bbccea9
Move cursor/selection algo to lib/utilities. 2016-12-29 10:16:17 +01:00
Claas Augner 43c1dd82f6
Add cursor tests, fix algorithm and extract method. 2016-12-29 09:54:15 +01:00
Guo Xiang Tan 7d307d6f29 Fix incorrect site setting. 2016-12-29 14:03:47 +08:00
Guo Xiang Tan a481bf048f FIX: Incorrect membership action buttons shown for non logged in users. 2016-12-29 12:51:36 +08:00
Guo Xiang Tan 3c4920d234 FIX: Group admin tabs showing for non logged in users. 2016-12-29 11:52:07 +08:00
Guo Xiang Tan 2165d0241e FIX: Only quote `.cooked` text. 2016-12-29 11:33:36 +08:00
Neil Lalonde 9c40657ba4 FIX: error during signup saying "Password is the same as your current password" due to automatic group membership granting a trust level 2016-12-28 17:36:04 -05:00
Claas Augner ba2db48dbb
Fix refactoring artifacts. 2016-12-28 22:37:07 +01:00
Claas Augner 1a5fcb72d3
FEATURE: Preserve cursor in editor upload 2016-12-28 22:24:52 +01:00
Neil Lalonde 67347432b7 Remove unread counts from last section of summary email, and rename it "New for you" 2016-12-28 14:06:01 -05:00
Neil Lalonde f3b4a889b2 FIX: remove extra space to the right of avatars in summary emails 2016-12-28 13:56:46 -05:00
Neil Lalonde a82182e1e3 FIX: error when trying to create new tag groups 2016-12-28 12:42:51 -05:00
Robin Ward 1ffbd9b4f6 UX: Don't show back button on fullscreen timeline 2016-12-28 12:29:24 -05:00
Robin Ward 471bb5ff61 UX: Back button was no longer centred properly. 2016-12-28 12:24:17 -05:00
Robin Ward 7c32b03364 UX: Try "bouncing" the back button in on progress widget 2016-12-28 11:39:08 -05:00
Robin Ward a297d7598b UX: Better style for back button 2016-12-28 11:22:33 -05:00
Robin Ward 7515f4eec2 Merge pull request #4621 from kgish/master
Toolbar action replaceText
2016-12-28 10:57:13 -05:00
Claas Augner e17bd6174c
Extract helper i18n-yes-no. 2016-12-28 11:45:41 +01:00
Robin Ward 5111611749 UX: Add a down arrow to the back button on the timeline 2016-12-27 17:21:27 -05:00
Robin Ward 889efe48be FIX: Customization templates were not working with Glimmer2 2016-12-27 12:17:30 -05:00
Robin Ward 3786d3679c FIX: Always return the latest API version requested 2016-12-27 11:57:46 -05:00
Robin Ward 98eac4924c FIX: If an audio file is playing, don't cloak it 2016-12-27 11:38:14 -05:00
Robin Ward 732d0ad030 FIX: Find the closest post to jump to if deleted 2016-12-27 10:52:37 -05:00
Robin Ward ee0c41b53a FIX: We can show the back button near the bottom 2016-12-27 10:21:30 -05:00
Claas Augner 8760f13c77
FIX: Translate all boolean values in user index 2016-12-27 11:16:30 +01:00
Arpit Jalan d72cbcb2a4 FEATURE: new setting to validate user website 2016-12-26 21:29:27 +05:30
Robin Ward 27e348c6b4 FIX: if `args` change a connector should update 2016-12-23 12:07:18 -05:00
Kiffin Gish 57284495de Toolbar action replaceText
Should be possible to replace the current contents with some other text.
2016-12-23 12:43:53 +01:00
Angus McLeod 6f0a937fa1 Resolve raw templates in 'javascripts/mobile' and 'javascripts' on mobile 2016-12-22 18:13:26 -05:00
Robin Ward 46f2a11a80 UX: Don't dock back button while dragging 2016-12-22 12:48:02 -05:00
Robin Ward 681f246df8 UX: Show post count in jump to post modal 2016-12-22 12:34:42 -05:00
Robin Ward 962c32edf5 Merge pull request #4597 from ibnesayeed/urdu-support
RTL direction assigned to Urdu language
2016-12-22 11:39:44 -05:00
Robin Ward b9fc9dc9fc FIX: Routing to default homepage with query params was broken 2016-12-22 11:37:17 -05:00
Guo Xiang Tan 5aee2673c7 FIX: Push null fields to last when sorting group members. 2016-12-22 14:55:24 +08:00
Guo Xiang Tan 5605700fa9 UX: Sort groups by name. 2016-12-22 14:46:20 +08:00
Guo Xiang Tan 6955c39c68 UX: Fix width on avatar flair. 2016-12-22 14:30:49 +08:00
Guo Xiang Tan 8551d821a0 FEATURE: Add site setting to disable group directory. 2016-12-22 14:14:22 +08:00
Sam c531f4ded5 remove rails-observers
Rails yanked out observers many many years ago, instead the functionality
was yanked out to a gem that is very lightly maintained.

For example: if we want to upgrade to rails 5 there is no published gem

Internally the usage of observers had quite a few problem.

The series of refactors renamed a bunch of classes to give us more clarity
and removed some magic.
2016-12-22 16:46:53 +11:00
Sam 019f1a1d06 UserEmailObserver is now removed
no big surprises here was pretty straightforward

after_commit semantics sure are weird though
2016-12-22 16:46:53 +11:00
Sam 2f6a4cc6de remove UserActionObserver, replace with after_save and service
interestingly there was some left over dead code from when stars
existed in the topic_users table
2016-12-22 16:46:53 +11:00
Guo Xiang Tan 96c70c74a1 Merge pull request #4619 from tgxworld/group_page_design
UX: Redesign group page to follow user page.
2016-12-22 13:42:28 +08:00
Guo Xiang Tan a5fead3857 UX: Redesign group page to follow user page. 2016-12-22 13:08:59 +08:00
Sam 0a78ae739d Remove SearchObserver, aim is to remove all observers
rails-observers gem is mostly unmaintained and is a pain to carry forward
new implementation contains significantly less magic as a bonus
2016-12-22 13:13:14 +11:00
Robin Ward 31cda7b372 FIX: Can't seem to use ES6 in this file 2016-12-21 16:50:57 -05:00
Robin Ward 89bdca9c8c FIX: Backwards compatibility for controller in raw templates 2016-12-21 16:38:57 -05:00
Robin Ward 1463e9ae46 FIX: Couldn't resolve raw customization 2016-12-21 16:19:04 -05:00
Neil Lalonde eb23a8c173 FIX: when changing category, watch for pasted link in title field 2016-12-21 14:57:12 -05:00
Robin Ward e85904b98f FIX: Clamp last read position to height of the widget 2016-12-21 14:24:15 -05:00
Neil Lalonde 783490f763 FIX: with featured links enabled and uncategorized topic not allowed, allow featued links behaviour before choosing a category 2016-12-21 13:40:05 -05:00
Neil Lalonde b5cc6851cf FIX: tag chooser input was navigating to tag pgaes on some mobile browsers 2016-12-21 12:01:53 -05:00
Robin Ward 44ddc113e7 FIX: Couldn't route to the default route with a query param 2016-12-21 11:18:22 -05:00
Robin Ward ca20560d1f FIX: Should use `RAW_TEMPLATES` scope for header customizations 2016-12-21 10:54:23 -05:00
Guo Xiang Tan c897e5599a FIX: Group mobile nav not updating. 2016-12-21 21:16:52 +08:00
Guo Xiang Tan a37a6f57d9 FIX: Automatic groups should be editable via groups page. 2016-12-21 21:11:49 +08:00
Guo Xiang Tan 5e75d5c1bf PERF: N+1 query on groups page. 2016-12-21 20:59:09 +08:00
Guo Xiang Tan 076a08d8e1 FIX: Unactivated users should not be automatically added into groups as well. 2016-12-21 18:15:01 +08:00
Guo Xiang Tan 7228081820 FIX: Automatic group membership should not add staged or unactivated users. 2016-12-21 18:04:26 +08:00
Guo Xiang Tan 13c6191e89 FIX: Don't allow invalid email to be saved. 2016-12-21 17:47:11 +08:00
Guo Xiang Tan 5d7f3223f0 SECURITY: Users can only bookmark posts which they can see. 2016-12-21 12:01:26 +08:00
Robin Ward 1821a0933d FIX: Missing CSS for back button on progress component 2016-12-20 16:01:15 -05:00
Neil Lalonde c75bebdea2 FIX: uncategorized setting to control whether topic featured links are allowed 2016-12-20 15:55:30 -05:00
Robin Ward 1cbe355c5b FIX: Timeline back button was docking too aggressively 2016-12-20 13:32:54 -05:00
Robin Ward f0f5fbf132 FIX: Never show the last read marker within 1 post of the last 2016-12-20 13:22:22 -05:00
Robin Ward 1be800b673 FIX: Prioritize raw template overrides from plugins 2016-12-20 13:07:09 -05:00
Neil Lalonde 158670ca5e FIX: if categories page is default, redirect to Top was never working 2016-12-20 12:06:58 -05:00
Robin Ward da4e27ca7d FIX: Allow resolution of `javascripts` prefixed raw templates 2016-12-20 11:53:43 -05:00
Robin Ward 16b236899c FIX: `custom-html` tag had broken information 2016-12-20 11:49:30 -05:00
Régis Hanol c302ffe08f FIX: buttons in user admin page weren't working 2016-12-20 12:26:53 +01:00
Régis Hanol 3c3008fec3 FIX: clicking 'Show Email' on admin page wasn't working 2016-12-20 11:35:13 +01:00
Régis Hanol bf9e59eda9 FIX: add option for the oneboxer to be synchronous 2016-12-20 11:18:03 +01:00
Guo Xiang Tan 6461021046 FIX: Only show membership status on index page. 2016-12-20 15:50:12 +08:00
Guo Xiang Tan 9db5d5b6a7 FIX: Incorrect serializer for groups page. 2016-12-20 15:44:22 +08:00
Guo Xiang Tan 7c7c233c1c FIX: Can't update `Groups#allow_membership_requests` in admin. 2016-12-20 15:14:35 +08:00
Guo Xiang Tan c15bf62b43 FIX: Display empty message when no groups can be shown. 2016-12-20 14:47:39 +08:00
Guo Xiang Tan 502e114c60 FIX: Incorrect count when loading more groups. 2016-12-20 14:39:44 +08:00
Guo Xiang Tan 193f8301a4 FIX: Do not show automatic groups to normal users. 2016-12-20 14:26:49 +08:00
Guo Xiang Tan 375f3feeb8 FIX: Topic featured links not getting oneboxed immediately. 2016-12-20 10:27:12 +08:00
Régis Hanol 52cd9972bb FIX: prevent DDoS with lots of _oneboxable_ links
FIX: ensure the onebox route is only allowed to logged in users
FIX: only allow 1 outgoing onebox preview per user
FIX: client should only do 1 preview at a time
2016-12-20 00:31:10 +01:00
Sam 6965079108 Merge pull request #4606 from mabras/fix_arabic_pluralization
Fix Arabic Pluralization Rules for Client
2016-12-20 09:17:59 +11:00
Robin Ward 8757ae3b92 FIX: The docked back button didn't work so well on iPad / short topics 2016-12-19 17:16:42 -05:00
Sam 2b808ad9da Merge pull request #4609 from joebuhlig/category-topics-wiki
FEATURE: Category setting to make all topics wikis
2016-12-20 09:15:51 +11:00
Neil Lalonde a65281d5ea FIX: better support for featured link topics in summary emails 2016-12-19 17:05:49 -05:00
Clay Griffiths d15bfc9880 Forced trailing slash on messageBus.baseUrl 2016-12-19 14:34:19 -07:00
Neil Lalonde 3256620d5d FIX: some blank topics and posts in summary email because they're images 2016-12-19 16:21:31 -05:00
Neil Lalonde 74956694e5 If summary email finds no topics, show topics more than 1 day old from new users 2016-12-19 14:54:08 -05:00
Neil Lalonde 923cf73c6e Topic Featured Links: move data from custom fields to topics and categories tables. Invert behaviour of topic_featured_link_allowed checkbox. Fix a bug with invalid topic records due to changing that category checkbox. 2016-12-19 14:54:07 -05:00
Robin Ward 4dcb29acbf UX: Show Back button above mobile progress widget 2016-12-19 14:06:19 -05:00
Robin Ward 36449aa2f2 UX: Docking back button on topic timeline 2016-12-19 13:33:55 -05:00
Robin Ward 05e99a68ce FIX: Refresh header if topic details are updated 2016-12-19 12:25:28 -05:00
Robin Ward e03d5e2140 Reapply Ember 2.10 for good this time!
This reverts commit ddd299f4aa.
2016-12-19 11:19:10 -05:00
Joe Buhlig 87251fded7 FEATURE: Category setting to make all topics wikis
FEATURE: Category setting to make all topics wikis
2016-12-19 06:42:18 -06:00
Guo Xiang Tan 18c8323987 FIX: Incorrect path for redirect. 2016-12-19 18:12:15 +08:00
Sam e0ff57ca75 SECURITY: prevent reuse of password reset 2016-12-19 18:00:22 +11:00
Sam eb2db23b40 FEATURE: remove email_token_grace_period_hours
The site setting email_token_grace_period_hours just causes confusion and
should not be used anyway.

Out of the box, tokens stop working once confirmed, no need to add complexity here
2016-12-19 17:15:20 +11:00
Sam dd383300b1 FEATURE: rate limit by login on password reset 2016-12-19 11:03:07 +11:00
Sam 0599bd0154 FEATURE: add referrer never tag to password reset page 2016-12-19 11:01:58 +11:00
Sam 15b5fddd49 SECURITY: protect upload params, only allow very strict filenames 2016-12-19 10:16:18 +11:00
Sam 30e0154e5d SECURITY: fix reflected XSS with safe_mode param
(only applies to beta and master)
2016-12-19 10:11:51 +11:00
Mohamad Abras e20e765afe Fix Arabic Pluralization Rules for Client 2016-12-17 17:50:35 +02:00
Jeff Atwood 81956cb1d6 Merge pull request #4590 from xfalcox/css-highligth
Use CSS animations for post and topic highlights
2016-12-16 14:22:25 -08:00
Rafael dos Santos Silva e9fa936389 Uses CSS animation for highlight on mobile too 2016-12-16 19:26:49 -02:00
Guo Xiang Tan d8541c589a FIX: Incorrect route for updating username. 2016-12-17 00:23:12 +08:00
Robin Ward ddd299f4aa Revert "Revert "Revert Ember 2.10+ for a short while""
This reverts commit 76bbc481cb.
2016-12-16 10:29:30 -05:00
Robin Ward 76bbc481cb Revert "Revert Ember 2.10+ for a short while"
This reverts commit 21682fd60b.
2016-12-16 09:52:29 -05:00
Guo Xiang Tan e3213f127d FIX: Regression with request membership button after migrating to component. 2016-12-16 16:07:11 +08:00
Sam d4a0508744 FEATURE: outlet prior to Reply button at the bottom of topics 2016-12-16 17:10:32 +11:00
Sam 61eb134181 FEATURE: setting to allow arbitrary redirects from sso origin
if sso_allows_all_return_paths is set to true you can redirect off-site from sso success
2016-12-16 13:37:44 +11:00
Sam 6ff309aa80 SECURITY: don't grant same privileges to user_api and api access
User API is no longer gets bypasses that standard API gets.
Only bypasses are CSRF and XHR requirements.
2016-12-16 12:05:43 +11:00
Robin Ward 21682fd60b Revert Ember 2.10+ for a short while 2016-12-15 16:43:38 -05:00
Neil Lalonde f01f95d62d FEATURE: new settings to customize some colors in emails 2016-12-15 14:43:53 -05:00