d6b22e6cc1
FIX: whitelist oneboxed iframes
2017-12-23 01:56:33 +01:00
69a90f31fb
FEATURE: Allow Forums to disable the Backups feature
2017-12-21 15:22:04 -05:00
7b58afe677
FIX: ProcessPost job failed for posts that have no user
2017-12-21 14:45:59 +01:00
4b51871f6a
Treat non-ascii URLs in `UrlValidator`.
2017-12-21 14:22:55 +08:00
6ecf37c482
Improve URL validation to check for a valid host.
...
Parsing a URL with `URI` is not sufficient as the following cases
are considered valid:
URI.parse("http://https://google.com ")
=> #<URI::HTTP http://https//google.com >
2017-12-21 13:50:15 +08:00
21e1b05c7e
FIX: Don't disable details when below truncate limit
2017-12-20 15:45:00 -05:00
7f69362d9d
FIX: external links in whisper ended up in a white page
...
FIX: clicking a link in a onebox wasn't properly extracting the post_id
2017-12-20 17:55:15 +01:00
6c4ee9d5b5
FEATURE: Trigger user webhook when a user logs in/out.
...
https://meta.discourse.org/t/how-do-you-learn-how-to-build-these-plugins/57946/10?u=tgxworld
2017-12-20 17:47:30 +08:00
6a2bce1931
FIX: Data loss on update of single user_field.
...
https://meta.discourse.org/t/api-data-loss-caused-by-changed-behaviour-of-custom-user-field-update/74990
2017-12-20 16:33:23 +08:00
7aa56fc9d9
refinement and test for batch mode on feature_topics
2017-12-20 13:58:05 +11:00
eab66065d1
FEATURE: search log term details page ( #5445 )
2017-12-20 13:41:31 +11:00
a0aca83c12
FIX: Broken spec
2017-12-19 17:55:41 -05:00
b3fda0ea86
FIX: details tags broke excerpts
2017-12-19 17:28:55 -05:00
24e89b6b38
FIX: validates 'ThemeField' name when used in a SCSS variable
2017-12-19 16:10:44 +01:00
fc6cb7bbe3
Merge pull request #5444 from tgxworld/remove_phantomjs
...
Switch to chrome headless mode instead of phantomjs.
2017-12-19 19:42:40 +08:00
6a4f391e38
Switch to chrome headless mode instead of phantomjs.
2017-12-19 16:00:43 +08:00
57a1190b07
FIX: correct issue with search omitting words with multiple dots
...
Previously we used to break up words with dots incorrectly leading to
missing search terms
2017-12-19 16:04:24 +11:00
30ddc1f222
Don't swallow errors when failing to create message for post action.
2017-12-19 10:58:26 +08:00
b39d3a863d
FIX: `moderators` group wasn't being updated to be messagable by everyone.
...
https://meta.discourse.org/t/custom-flag-not-showing-text/76244
2017-12-19 10:14:56 +08:00
1abc276451
FIX: properly omit inactive and silenced users from directory
2017-12-19 12:53:59 +11:00
97ceebb570
SECURITY: Don't pass email backup token to sidekiq as a parameter.
...
* This exposes the token in the Sidekiq dashboard which can be
viewed by an admin and defeats the purpose of using a token
in the download backup email ink.
2017-12-18 11:25:22 +08:00
5e90abfaea
FIX: use hijack for emoji uploads
2017-12-18 10:31:19 +11:00
81b3a4a3da
improve spec
2017-12-15 11:42:51 +11:00
b91f83eb7d
Ignore auto-quote/reply when counting replies
2017-12-15 00:38:14 +01:00
092c976d7c
FIX: prevent 💥 when selecting replies to posts quoting themselves
2017-12-15 00:23:51 +01:00
3cbaea81bd
Merge pull request #5428 from discourse/fix-pending-users-count
...
FIX: incorrect pending_users_reminder user count
2017-12-14 14:05:37 -05:00
f2565f6c7e
SECURITY: Any group can be invited into a PM.
2017-12-14 14:57:48 +08:00
96584403cd
SECURITY: prevent staged accounts from changing email
2017-12-14 17:16:49 +11:00
67aecff59c
FEATURE: store twitter supplied email for auditing
2017-12-14 15:54:32 +11:00
11050e5d10
Don't override count value that has been set by query.count
2017-12-13 18:48:46 -08:00
5db3d39b05
FIX: Post.reply_ids should also handle quotes
2017-12-14 00:43:48 +01:00
1b4483c942
FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts
2017-12-13 22:12:06 +01:00
f525d83b53
FIX: empty uploads and blank filenames caused errors during validation
2017-12-13 22:03:31 +01:00
3f1d6a302e
FIX: links with query params to external sites fail to load if ga universal auto link domains is used
2017-12-13 13:58:44 -05:00
7aee1e3083
Remove specs that makes the build very sad.
2017-12-13 17:51:52 +08:00
d5293aeae2
Clean `Topic#slug` when `SiteSetting.slug_generation_method` changes.
...
https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld
2017-12-13 16:11:07 +08:00
b998efdc94
FIX: do not send mailing list emails to unapproved users
2017-12-13 15:13:17 +11:00
a393d3bcbb
FIX: ensure staged accounts are always inactive
...
If for any reason active is stored in the user model, clear it out
prior to creating an account
2017-12-13 14:22:16 +11:00
a7c1b0c81f
FIX: path whitelist for embedded comments didn't work with non-ASCII chars
2017-12-12 20:17:46 +01:00
e30851e45a
Move escape_uri method to a more suitable place
2017-12-12 20:17:46 +01:00
492af81e67
FIX: save registration_ip_address for staged users logging in via social auth
2017-12-12 17:41:16 +05:30
62a5b174e1
FIX: wasn't able to use the same username when taking over a staged account
2017-12-12 11:26:00 +01:00
6ade508f39
FIX: Prevent 'rack.input' missing error.
2017-12-12 16:40:35 +08:00
1d43d7f136
optimize spec
2017-12-12 13:00:53 +05:30
ff6dda85b7
FIX: replace curly quotes to regular quotes in search terms
2017-12-12 11:17:28 +05:30
d21db0f186
add a test case to verify presence of registration_ip_address for staged users
2017-12-11 21:33:00 +05:30
365bd771d9
Fix the build.
2017-12-11 17:03:05 +08:00
4bd5acec47
FIX: `Topic#featured_link` may contain more than a URL.
2017-12-11 16:36:19 +08:00
3c56c9b637
FIX: strip webhook payload_url
2017-12-11 13:48:11 +05:30
63bdc4056d
More log suppressions for rate limit exceeded
2017-12-11 17:52:57 +11:00
4986ebcf24
FEATURE: optional default off global per ip rate limiter
2017-12-11 17:52:57 +11:00
68d3c2c74f
FEATURE: add global rate limiter for admin api 60 per minute
...
Also move configuration of admin and user api rate limiting into global
settings. This is not intended to be configurable per site
2017-12-11 11:07:22 +11:00
74b9828731
FIX: Remove mentions filters from user and groups
...
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
5003f07b2c
FEATURE: new site setting show_inactive_accounts
2017-12-07 19:22:41 +05:30
f0ef307d2d
FIX: topic timer offset applied two times
...
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.
This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1 hour to your timezone offset.
2017-12-07 14:42:58 +01:00
47c44356f8
FIX: load balanced servers do not share monotonic clock
...
This means then when a service is load balanced and you reach rate limits
there was a case where they counting was way off
also remove the stub from clock_gettime cause we need to be super careful with
it, so we should probably just stub by hand when needed
2017-12-07 11:48:11 +11:00
90a55d6f7c
FIX: handle CORS in hijacked requests
2017-12-07 10:31:04 +11:00
16738cfb1b
FEATURE: convert plain text emails to markdown
2017-12-06 01:47:51 +01:00
5f318a5241
FEATURE: Replace SimpleRSS with Ruby RSS module ( #5311 )
...
* SPEC: PollFeedJob parsing atom feed
* add FeedItemAccessor
It is to provide a consistent interface to access a feed item's tag
content.
* add FeedElementInstaller
to install non-standard and non-namespaced feed elements
* FEATURE: replace SimpleRSS with Ruby RSS module
* get FinalDestination and download with Excon
* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
410994b7f5
FEATURE: Show a button to Staff for "Moderation History" on posts/topics
...
When clicked, it pops up a modal showing a history of moderation actions
taken on the post or topic.
2017-12-05 15:20:20 -05:00
6e054b2572
FEATURE: Convert HTML to Markdown while pasting in composer
2017-12-05 12:23:39 -05:00
995bf3c84e
correct spec on Ruby 2.3
2017-12-05 07:04:41 +11:00
5a9622163d
FIX: regression around rate limiter
2017-12-04 21:44:16 +11:00
dd70ef3abf
Revert "Revert "PERF: improve speed of rate limiter""
...
This reverts commit 2373d85239
2017-12-04 21:23:11 +11:00
2373d85239
Revert "PERF: improve speed of rate limiter"
...
This reverts commit a9bcdd7f27
2017-12-04 21:19:28 +11:00
d041377ccf
correct test that does not work with discobot
2017-12-04 18:20:05 +11:00
a9bcdd7f27
PERF: improve speed of rate limiter
...
Also
- adds a global rate limiter option
- cleans up usage in tests
- fixes freeze_time so it handles clock_gettime
2017-12-04 18:17:30 +11:00
af061efcf5
DEV: if plugins are installed do not fail the test
2017-12-04 18:17:30 +11:00
b18cc81609
Make rubocop happy.
2017-12-04 10:55:31 +08:00
22140efa70
Tests are still leaking connection after skipping.
...
* Could be in the setup.
2017-12-04 10:46:30 +08:00
e73fbfe265
FIX: `Topic#featured_link_root_domain` extracts URL before parsing.
2017-12-04 10:00:07 +08:00
4c8402c50f
Skip test that is leaking connections.
2017-12-04 09:26:51 +08:00
496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
...
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
e3925278e2
FEATURE: support search click through tracking for user, category and tags
...
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj
This commit adds following features:
- support for tracking click through to user, tag and category
- new filter for search type (header, full page)
This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
7f2eeaf767
FIX: Password required flag should be cleared whenever clearing the raw password ( #5384 )
2017-12-01 15:19:24 +11:00
c128e421c4
FIX: Don't run job if topic timer has already been deleted.
2017-11-30 15:26:26 +08:00
1c2d1682ae
Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check
...
FIX: Re-enable invalid interpolation keys check and allow default key…
2017-11-30 13:04:54 +08:00
9fbe1436b6
UX: Replace heuristic solution root domain extraction for topic featured link.
2017-11-29 21:52:41 +08:00
b1375ef44e
Ensure that we disconnect connection in test.
2017-11-29 20:57:13 +08:00
8491c5fba5
UX: Replace heuristic solution for extracting root domain.
2017-11-29 16:26:46 +08:00
44ee388070
FEATURE: omit images from og and twitter description tags
2017-11-28 21:34:02 +01:00
1d8b834301
Merge pull request #5369 from vinothkannans/queued
...
FIX: Error if queued post not found while updating
2017-11-28 17:51:05 +08:00
b094894c94
Feature: Add service worker registration method to plugin API
2017-11-28 14:01:41 +08:00
df84e1c358
Correctly track hijacked requests
2017-11-28 16:47:20 +11:00
0caa335ef0
FIX: Handle more cases where HTTP status is not correct
...
HTTP status was not correct with send_file which uses streaming
2017-11-28 11:00:13 +11:00
ca7af7b88f
FIX: displaying wrong avatar and letter avatar
...
correct regression where params and env is reused in production
2017-11-28 09:28:40 +11:00
77f90876d3
REFACTOR: Track manual locked user levels separately from groups
2017-11-27 11:23:44 -05:00
31aa21b5a4
FIX: Error if queued post not found while updating
2017-11-27 19:25:51 +05:30
608207b2e5
FEATURE: avatar proxy happens in background
...
This ensures that even if it is slow to download avatars site will
continue to work
Also simplifies hijack pattern
2017-11-27 17:43:24 +11:00
d5e7691ae9
favicon proxy now uses hijack
2017-11-27 14:51:14 +11:00
5805979e88
FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
...
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
2e04ef97d9
Fix the build.
2017-11-27 10:53:05 +08:00
a7030e80bf
Skip randomly failing test.
2017-11-27 10:51:18 +08:00
eb428ef54d
FEATURE: uploads are processed a faster
...
Also cleans up API to always return 422 on upload error. (previously returned 200)
Uploads are processed using new hijack pattern
2017-11-27 12:43:35 +11:00
71942e4f62
Merge pull request #5352 from tgxworld/method_for_replica_postgres_connection
...
Expose `replica_postgresql_connection` to `ActiveRecord::Base`.
2017-11-27 08:38:10 +08:00
b3094e9954
FIX: incoming and outgoing emails got lost when post was moved
2017-11-24 11:45:36 +01:00
e0e99d4bbd
PERF: hijack onebox requests so they do not use up a unicorn worker
2017-11-24 15:31:40 +11:00
a509f466a0
Expose `replica_postgresql_connection` to `ActiveRecord::Base`.
2017-11-24 09:35:45 +08:00
82222e8d18
Improve specs to test for the right response status.
2017-11-24 09:32:44 +08:00
406ad1a1f2
Merge pull request #5357 from techAPJ/invite-trust-level
...
FIX: invited users were not granted trust level based on their group
2017-11-23 23:42:20 +05:30
ad07e6e172
FEATURE: `group_removes_trust_level` setting
...
By default in Discourse, if a group grants a user a particular trust
level that is locked even if they are removed from the group.
With this new setting, when a user is removed from a group their
trust level is set to either the next highest trust level based on group
membership, or they are unlocked and promoted based on the default
mechanisms.
2017-11-23 13:03:24 -05:00
613f4d737a
FIX: updating topic stats failed silently for invalid topics
2017-11-23 18:47:45 +01:00
3508046e33
FIX: invited users were not granted trust level based on their group
...
https://meta.discourse.org/t/bulk-invites-and-trust-level/73535
If the user enters password when accepting invite they were not granted
trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.
2017-11-23 22:19:28 +05:30
39810e4425
FIX: do not move small post actions
2017-11-23 17:25:53 +01:00
e61629ed84
remove spec containing mock
2017-11-23 17:54:27 +11:00
2b8d4508e5
PERF: stop running background work between requests
...
Use a dedicated thread to run Scheduler::Defer
This avoids blocking of a worker during operations that require waiting.
In particular uploads risked blocking a unicorn.
This also add a queue "length" that discourse prometheus consumes.
2017-11-23 15:48:47 +11:00
628275fc31
FIX: Some badge routes were still working even with badges disabled
2017-11-21 12:22:44 -05:00
f7642e076d
REFACTOR: Avoid duplicated logic on server and client.
2017-11-21 17:10:04 +08:00
2d48caffdf
FIX: be more lenient when deleting a custom emoji
2017-11-20 23:50:23 +01:00
0a9daba627
FIX: Support for long suspension emails
2017-11-20 12:45:46 -05:00
7e841a0495
FIX: stop counting PMs, deleted topics and whispers in directory and user stats
2017-11-20 16:44:09 +11:00
385372e384
Revert "PERF: Reduce number of topics to filter while querying for unread."
...
This reverts commit c06b782cab
2017-11-20 11:49:09 +08:00
41673c322c
dear Rubocop, don't be so pedantic ;-)
2017-11-19 12:45:33 +01:00
92a831bae6
FEATURE: user directory returns staged users during search
2017-11-19 01:17:31 +01:00
546b206da0
replace indentation with non-breaking spaces when cooking emails
2017-11-18 17:16:44 +01:00
87ec11e298
FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats.
2017-11-17 16:08:46 -05:00
d755c9c90f
FIX: Allow regular expressions to specify boundaries
2017-11-17 14:13:44 -05:00
d47fa6653b
do not notify staged users about posts withing mailinglist mirror category
2017-11-17 15:29:14 +01:00
1a3ab7c02e
ignore some site settings for emails sent to mailinglist mirror category
2017-11-17 15:29:14 +01:00
aea161fabd
suppress rejection email when email was sent to mailinglist mirror category
2017-11-17 15:29:14 +01:00
a586738f25
fix randomly failing spec
2017-11-16 18:16:16 +01:00
678e28794a
FIX: properly handle too large & broken images in posts
2017-11-16 15:45:07 +01:00
6f2a3cb026
Remove unwanted triggers to `CookedPostProcessor` ( #5319 )
2017-11-16 15:20:44 +05:30
9c22c68d39
FIX: only save custom fields if they actually change
2017-11-16 15:14:10 +11:00
3ab6318e5f
Disable postgresql adapter tests until we figure out what is leaking
...
connections.
2017-11-16 07:17:22 +08:00
f52111f787
FEATURE: allow plugins to easily detect if running in Rack
...
Usage: Discourse.running_in_rack? to tell if rack was booted
2017-11-16 08:39:29 +11:00
20fbf81505
FEATURE: Allow plugins to easily add defaults to GlobalSetting
...
usage:
GlobalSetting.add_default("plugin_setting_name", "value")
2017-11-16 08:39:29 +11:00
0cdded8079
Merge pull request #5303 from vinothkannans/export-multiple-categories
...
FEATURE: Option to export multiple categories using export_category method
2017-11-15 16:07:21 -05:00
9207dee69a
FEATURE: escape HTML when cooking plaintext emails
2017-11-15 20:22:11 +01:00
fc73de9578
Support for finding new locales in plugins
2017-11-15 11:20:04 -05:00
cbc0afb399
REFACTOR: Instance methods added to 'PluginStore' model for easy access ( #5315 )
2017-11-15 10:10:20 -05:00
648832a643
fix the build
2017-11-15 11:53:14 +01:00
7b494a65c9
NEW: large image placeholder added in cooked html ( #5291 )
2017-11-15 11:30:47 +01:00
89d9ffa884
EXPERIMENTAL: Allow logs to be shipped via different methods.
...
See https://github.com/dwbutler/logstash-logger#uri-configuration for
a list of available methods.
2017-11-15 09:11:33 +08:00
813e21d0e8
FIX: current user serializer consistently returns {} for custom_fields
...
Resolves : #5210
2017-11-15 11:55:37 +11:00
4c4410225e
UX: cap likes 2 ( #5237 )
2017-11-15 11:28:54 +11:00
3831663fea
FEATURE: search logs page ( #5313 )
2017-11-15 11:13:50 +11:00
23baaa5dcc
FIX: don't crop iPhone X screenshots
2017-11-14 20:37:27 +01:00
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
4be8f17e66
FIX: counting invites didn't work
...
PostgreSQL reported the following error:
"for SELECT DISTINCT, ORDER BY expressions must appear in select list"
2017-11-14 11:40:07 +01:00
47e4c9bb46
FIX: import/export theme should work with uploads
2017-11-14 16:30:23 +11:00
075a458489
FIX: child theme component vars not resolved in parent
2017-11-14 15:22:59 +11:00
bf5ba5fbd1
Remove `readonly alert` smoke test.
2017-11-14 11:18:38 +08:00
d3baae5365
removes whitespaces and uses scope
2017-11-13 15:23:24 +01:00
7370adeae3
FIX: don't delete uploads referenced in drafts or queued posts when using the short_url
2017-11-13 15:01:31 +01:00
8a66446849
FEATURE: add overflow-y auto to Markdown tables
2017-11-13 17:52:15 +11:00
4f28c71b50
FIX: error setting tombstone bucket when set to old version
2017-11-13 15:36:45 +11:00
3ac7d041ae
UX: generic onebox treats all square images as avatars and renders them smaller
2017-11-13 11:21:19 +11:00
5210e3e744
FEATURE: accept incoming email with reply_key mismatch when original email was forwarded
2017-11-12 23:44:22 +01:00
fc6de6863b
WIP
2017-11-12 21:12:34 +01:00
4dc4bc70c8
FIX: ignore_by_title should match case-insensitive
2017-11-12 01:43:18 +01:00
d9823f69c6
FEATURE: Option to export multiple categories using export_category method
2017-11-11 19:11:16 +05:30
4270c93666
FIX: Missing yml file
2017-11-10 14:29:36 -05:00
1f14350220
Rename "Blocked" to "Silenced"
2017-11-10 14:10:27 -05:00
9dc9ca4ac0
FIX: be consistent with how first posts in topics are counted. do like DirectoryItem.refresh_period :all
2017-11-10 12:18:25 -05:00
0ccefb0365
make RuboCop happy
2017-11-10 17:57:28 +01:00
31e2385316
FEATURE: do not send notification emails to users who are included in the To and CC header of an incoming email
2017-11-10 17:44:20 +01:00
73aa7edb8b
Temporarily skip multisite spec
2017-11-09 15:38:34 -08:00
16ff2a4715
FIX: topic counts after converting topic to/from public and private
2017-11-09 15:33:44 -05:00
06365023c4
FEATURE: new API to search for a user by email
2017-11-09 17:04:21 +11:00
2d5bf0705a
PERF: exact email match bypass
...
instead of scanning full table when there is an exact email match ONLY
return the actual user.
2017-11-09 16:53:14 +11:00
86e6732f78
FEATURE: update rails multisite
...
always allow /srv/status through even if host does not match
2017-11-09 15:40:56 +11:00
b21d5d3633
FIX: SSO email match should be case insensitive
2017-11-08 20:37:41 +05:30
6090994cdf
FEATURE: Retain the latest 30 days of WebHookEvent records by default.
2017-11-08 14:11:01 +08:00
4bb454d889
FIX: JSON custom fields incorrectly being converted to an array.
...
https://meta.discourse.org/t/custom-fields-simultaneous-save-with-json-becomes-an-array/73647
2017-11-08 11:17:37 +08:00
d7880af0bb
FIX: change password form validation should instruct admins to use min password length for admin accounts
2017-11-07 16:14:56 -05:00
be0c7609f1
FIX: validates attachments against current authorized extensions
2017-11-07 19:17:33 +01:00
8f560f0bf4
Merge pull request #5282 from vinothkannans/local_onebox_slash
...
FIX: Topic links onebox differently if end in /
2017-11-07 17:39:38 +05:30
d9602fe729
Fix incorrect severity field.
2017-11-07 11:24:54 +08:00
c9df21e131
FEATURE: Allow Unicorn logs to be JSON formatted.
2017-11-06 12:46:14 +08:00
230fec68ca
FIX: Topic links onebox differently if end in /
2017-11-06 01:41:36 +05:30
9ebb1412d3
FIX: Brittle, order dependent spec
2017-11-04 09:30:17 -04:00
59529ea54a
generalize spec fixture
2017-11-04 11:47:26 +05:30
2f0c9793f1
FEATURE: Allow multiple html builders to be registered via plugins
2017-11-03 11:32:32 -04:00
93633865d9
Adds primary user group as a class to quote ( #5285 )
...
* Adds primary user group as a class to quote
This feature addition will add the class `group-PRIMARY_USER_GROUP` to
the quote `aside`. `PRIMARY_USER_GROUP` will be the primary user group
of the user being quoted. This is similar to the class that is added to
a `topic-post`.
* Remove trailing whitespace
* Fix avatar in test
* Address PR comments
* Fix trailing whitespace
2017-11-03 09:51:40 -04:00
d320f4840d
FIX: Unable to invite groups that are not public visible into pms.
...
https://meta.discourse.org/t/inviting-groups-broken-in-head/73346/6
2017-11-03 21:40:33 +08:00
56412adad5
FEATURE: custom setting for large square site icon
...
This icon is used for android splash screen
2017-11-03 16:19:31 +11:00
af01860a3d
Clear all active connections after PostgreSQL failover tests.
2017-11-03 09:21:10 +08:00
c7d7cb940c
FIX: dashboard posts report was including posts in daily data, but not in totals
2017-11-02 18:46:28 -04:00
18d65fe7e5
FIX: post counts in user stats when changing post owner
2017-11-02 18:05:23 -04:00
21dd2ccd43
FIX: only count regular posts in user stats when deleting
2017-11-02 18:05:23 -04:00
30689783db
don't decrement post_count for a post in a deleted topic that has already been uncounted
2017-11-02 18:05:23 -04:00
f29290ad11
FIX: don't count whispers in user stats post_count
2017-11-02 18:05:23 -04:00
24af9b7d97
FIX: when a topic is deleted, update the post count stats of all user who replied
2017-11-02 18:05:23 -04:00
64cb8a3ce3
FIX: Normalizer wasn't working with attributes without values
2017-11-02 14:11:20 -04:00
4634935fe6
DEV: suppress puts output while running specs
2017-11-02 15:03:36 +05:30
edf4af608e
FIX: Better match when searching for groups.
2017-11-02 10:20:14 +08:00
ab2a5cef38
FIX: Can't edit membership request template on group page.
2017-11-02 08:51:43 +08:00
7f33f7850a
Merge pull request #5270 from vinothkannans/rake_categories
...
FEATURE: Rake task to export and import category structure
2017-11-01 21:36:03 +05:30
a00af4d85a
FEATURE: Rake task to export and import category structure
2017-11-01 17:17:05 +05:30
880d154381
FIX: deleting staged user of rejected email shouldn't delete incoming email
2017-10-31 15:13:23 +01:00
b3e61ebb38
suppress print output when running specs
2017-10-31 16:06:11 +05:30
1bd9e64a36
FIX: offline controller regression
2017-10-31 15:44:50 +11:00
53cadbdfc5
Skip failing tests on Travis first.
2017-10-28 00:22:41 +08:00
b636e858bb
Fix randomly failing spec on Travis.
2017-10-27 23:53:58 +08:00
401fbdbfe7
FIX: `Topic#title` were being parameterized when encoded slug is
...
enabled.
2017-10-27 11:02:47 +08:00
70aed105a6
FIX: bypass all site setting work for shadowed method
2017-10-27 11:12:44 +11:00
7c3123a2dd
Downcase encoded slug by default and more specs
2017-10-26 16:50:29 +08:00
1c7b4381cc
Improve postgresql failover specs.
2017-10-26 15:54:50 +08:00
f1615c2148
Merge pull request #5263 from tgxworld/improve_pattern
...
REFACTOR: Always validate email by default.
2017-10-26 14:34:09 +08:00
94782152c6
Ensure we clean up state in PostgreSQL failover specs.
2017-10-26 09:22:51 +08:00
a173511681
Merge pull request #5259 from discourse/groups_in_sso_provider
...
Add groups to the SSO provider payload
2017-10-25 23:02:53 -02:00
5d5268a82b
Feature: Group handling
2017-10-25 22:49:17 -02:00
defea6245c
REFACTOR: Always validate email by default.
2017-10-25 13:48:34 +08:00
efbd923f60
Merge pull request #5261 from xrav3nz/fix-rebake-match-rake
...
FIX: `post:rebake_match` rake task
2017-10-25 10:22:56 +05:30
1db4c2d1a0
moving redis to readonly mode destablizes the test suite
2017-10-25 14:39:49 +11:00
0d816302e2
Explicitly avoid all readonly protection and scoping
2017-10-25 13:31:44 +11:00
7ca8853861
don't risk being stuck in readonly
2017-10-25 13:22:50 +11:00
877b7be579
FIX: in readonly mode don't double count pages
2017-10-25 13:19:43 +11:00
82c18f6ca3
fix: undefined variable in `post:rebake_match`
2017-10-24 20:05:58 -04:00
fb5b9b6d06
FIX: don't offer the "Something Else" flag reason to TL0 users since they don't have permission to send private messages
2017-10-24 11:47:42 -04:00
4452d67a23
Revert "FIX: TL0 users' messages to moderators were not being posted when flagging private messages"
2017-10-23 18:17:53 -04:00
821ed23799
Use the CategoryHashtag::SEPARATOR ( #5258 )
...
Use the CategoryHashtag::SEPARATOR like in the previous examples.
2017-10-23 14:59:08 +02:00
54455fa40b
Use MessageBus to get other processes to failover faster.
2017-10-23 17:58:24 +08:00
509ecbe9fb
Fix test not starting with the right state.
2017-10-23 12:20:39 +08:00
19f3b81161
Revert "FIX: always trigger the ':user_updated' event"
...
This reverts commit 519b70ea46https://meta.discourse.org/t/creating-a-topic-or-a-post-sends-the-user-updated-webhook/71643
2017-10-23 11:44:22 +08:00
e91a631978
REFACTOR: DRY up code and add better test coverage.
2017-10-23 11:16:14 +08:00
9586f0bdc9
fix the build - take 2
2017-10-20 21:34:56 +05:30
13b2bf52c9
fix the build
2017-10-20 20:31:49 +05:30
804b4f32f8
better error message when API authentication fails
2017-10-20 20:05:34 +05:30
57d9830bd2
FIX: DistributedCache without namespace mode wasn't working.
2017-10-20 22:32:41 +08:00
fe1e78ddf4
Make PostgreSQL failover work with distributed cache.
2017-10-20 17:15:29 +08:00
4205c1ad2b
FIX: postprocessing ignored cook method
2017-10-20 10:26:45 +02:00
1481462cbf
PERF: Move oneboxing from cook method "email" to postprocessing
2017-10-20 10:26:45 +02:00
057571d173
Raise errors in PostgreSQLFallbackHandler threads.
2017-10-20 12:06:03 +08:00
838568cbc3
Refactor flag types for more customization
2017-10-19 13:55:23 -04:00
1cae875146
FIX: topic link extraction shouldn't fail when the parsed URL has no path
2017-10-19 15:26:37 +02:00
3cd73cdf18
FIX: fancy topic title must fit into column
2017-10-19 14:34:30 +02:00
22ba70fb01
Merge pull request #5226 from tgxworld/allow_user_to_disable_private_messages
...
FEATURE: Allow users to disable new PMs.
2017-10-19 16:46:18 +08:00
38123a4246
Add readonly test to smoke tests.
2017-10-19 16:34:54 +08:00
5b9ddaf972
FIX: `Topic#fancy_title` should not write in readonly mode.
2017-10-19 16:07:03 +08:00
25c25ae423
FEATURE: Allow user to leave a PM.
2017-10-19 12:32:55 +08:00
79de10b212
FEATURE: Allow users to disable new PMs.
...
https://meta.discourse.org/t/is-it-possible-to-disable-private-messaging-for-a-specific-user/46391
2017-10-19 12:32:55 +08:00
814c7ab503
Skip randomly failing tests first.
2017-10-19 12:25:50 +08:00
cbdfc85466
FIX: images aren't lightboxed anymore (partially reverts 646c6eb7cd)
2017-10-18 23:54:36 +02:00
a4c539bade
FEATURE: Allow registration of detailed request logger
...
Detailed request loggers can be used to gather rich timing info
from all requests (which in turn can be forwarded to monitoring solution)
Middleware::RequestTracker.detailed_request_logger(->|env, data| do
# do stuff with env and data
end
2017-10-18 12:10:30 +11:00
1dd2b51059
remove redundent stubs
2017-10-18 12:10:30 +11:00
bdd3713ca4
Allow smoke tests that writes data to be skipped.
2017-10-17 16:20:41 +08:00
1b5ee0ae72
FIX: Couldn't boot Discourse app with a readonly postgres.
2017-10-17 13:44:30 +08:00
8185b8cb06
FEATURE: cache https redirects per hostname
...
If a hostname does an https redirect we cache that so next
lookup does not incur it.
Also, only rate limit per ip once per final destination
Raise final destination protection to 1000 ip lookups an hour
2017-10-17 16:22:54 +11:00
646c6eb7cd
FEATURE: add :before_post_process_cooked hook
...
Also reduce amount of image downloading
2017-10-17 16:22:54 +11:00
2db66072d7
SECURITY: signup without verified email using Google auth
2017-10-16 13:51:41 -04:00
5f76e5062d
Pause Sidekiq when postgres failovers.
2017-10-16 19:48:31 +08:00
229a10e142
Missed a whitelist, compensate for strict classes
2017-10-16 10:46:01 +11:00
f73a3cc0d4
Don't include suspended_at or suspended_till unless suspended
2017-10-13 12:17:54 -04:00
b124e5f19f
FIX: TL0 users' messages to moderators were not being posted when flagging private messages
2017-10-13 11:55:49 -04:00
c53f41f4f2
FIX: don't flag watched words when rebaking posts
2017-10-12 15:34:22 -04:00
c0bb97b5cb
FIX: delete staged users when the incoming email is rejected
2017-10-11 16:17:01 +02:00
9dcb11f553
Fix the build.
2017-10-11 17:45:19 +08:00
09721090a3
FIX: Ensure that we revert back to default connection after running jobs.
2017-10-11 17:17:03 +08:00
a2183c3f1d
SECURITY: verify that inviter can invite new user to a topic
2017-10-09 15:59:41 +05:30
a6f2533d38
SECURITY: Fix XSS on unsubscribed page.
2017-10-09 09:04:46 +08:00
6fe604b93e
Revert "SECURITY: Fix XSS on unsubscribed page."
...
This reverts commit 190558db9d
2017-10-09 09:03:07 +08:00
190558db9d
SECURITY: Fix XSS on unsubscribed page.
2017-10-09 08:59:03 +08:00
4ea87b5ab8
Merge branch 's3_refactor'
2017-10-09 10:27:52 +11:00
3bdd8f57c1
FIX: invited staged users would sometimes not get notified of replies
2017-10-06 16:37:28 +02:00
70bb2aa426
FEATURE: allow specifying s3 config via globals
...
This refactors handling of s3 so it can be specified via GlobalSetting
This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3
It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
3efde2618d
UX: Do not display non-human users on group page.
...
https://meta.discourse.org/t/members-of-groups-staff/71437
2017-10-06 10:35:40 +08:00
beca02c046
FIX: moderators couldn't see flagged topics list
2017-10-05 14:12:07 -04:00
b2127600fb
Remove use of concurrent timer for Redis failover.
...
* Uses the same logic for Postgres failover.
2017-10-05 15:57:08 +08:00
b0557c6692
UX: Allow users to remove a remind me topic timer.
2017-10-05 11:50:08 +08:00
f5a2ed99b0
FIX: deleting category background images sometimes has no effect
2017-10-04 17:04:37 -04:00
e212435545
FIX: redirect to top wasn't working
2017-10-04 22:08:41 +02:00
ddbd1d5ab8
allow regex options on username site settings
2017-10-04 15:08:51 -04:00
c29334cf23
FEATURE: the hide_email_address_taken setting works with the change email address form in user preferences
2017-10-04 11:41:25 -04:00
1310181664
FIX: Adding a public topic timer deletes a private topic timer.
2017-10-04 16:31:40 +08:00
5881355006
remove uneeded assertion
2017-10-04 15:59:16 +11:00
0342324b47
FEATURE: support regex in rake post:remap ( #5201 )
2017-10-04 11:47:53 +11:00
4ee2fcd3d5
correct flaky spec
2017-10-04 10:47:24 +11:00
1faae3c765
rename forgot_password_strict to hide_email_address_taken
2017-10-03 15:28:31 -04:00
e47f5cedd2
FEATURE: forgot_password_strict setting also prevents reporting that an email address is taken during signup
2017-10-03 15:28:30 -04:00
7f50380221
FIX: respect email domain whitelist/blacklist when creating staged users
2017-10-03 16:36:08 +02:00
76706f9144
FIX: don't create staged users when incoming email is rejected
...
FIX: don't send subscription mail to new users
2017-10-03 16:36:08 +02:00
fafe7cc661
remove trailing whitespaces
2017-10-03 13:02:04 +02:00
daf1dda700
FIX: username autocomplete in assign modal wasn't working
2017-10-03 12:49:45 +02:00
a5b7d34fe2
Merge pull request #5199 from xrav3nz/poll-feed-integration-test
...
TEST ONLY: PollFeed integration test
2017-10-03 14:33:22 +08:00
a966f2134c
Merge pull request #5215 from gschlager/email_templates
...
Add specs for EmailTemplatesController
2017-10-03 14:30:19 +08:00
3e53dbcade
UX: Only include tag hashtag postfix when necessary.
...
https://meta.discourse.org/t/links-to-tags-not-working-in-final-post-unless-autocompleted/69884/6?u=tgxworld
2017-10-03 13:54:50 +08:00
85c5bb4ea4
Fix randomly failing spec.
2017-10-03 11:59:26 +08:00
5bb326a452
Add specs for EmailTemplatesController
2017-10-02 14:53:27 +02:00
8140e54675
FIX: More fixes for `Group#mentionable` and `Group#messageable` feature.
2017-10-02 17:45:58 +08:00
79f3d299a1
Don't allow category definition topics to be converted to PMs ( #5216 )
2017-10-02 10:04:58 +02:00
15cd3b78ae
integration test for PollFeed job
2017-10-02 01:16:11 -04:00
b5bbb8ae8a
Fix failing spec.
2017-10-02 13:16:01 +08:00
0f2c5f5fc9
FIX: Don't raise error when trying to download avatar from URL.
2017-10-02 12:59:41 +08:00
c872225762
Improve `MessageBus.track_publish` to allow filter by channel.
2017-10-02 11:34:57 +08:00
b295a39977
Fix randomly failing spec.
2017-10-02 11:24:48 +08:00
049d925213
Remove controller spec that is rewritten as request spec.
2017-10-02 10:47:22 +08:00
4e07bbfbbf
FIX: Only allow intergers for page params.
2017-10-02 10:45:54 +08:00
ac04f5e0cc
update response error when deleting tags ( #5213 )
2017-09-30 16:31:32 +02:00
00b190af75
Revert "A safe way to create class variables in a multisite environment."
...
The approach taken by this interface was flawed. We need a better
solution.
2017-09-29 11:06:12 -04:00
689f949fdb
Merge pull request #5209 from techAPJ/has-messages
...
FIX: update group.has_messages field weekly
2017-09-29 09:12:26 +05:30
0358931b9f
correct erratic spec
2017-09-29 12:58:15 +10:00
d64853dfa0
FIX: update group.has_messages field weekly
2017-09-29 08:23:07 +05:30
f6fdc1ebe8
FEATURE: flexible crawler detection
...
You can use the crawler user agents site setting to amend what user agents
are considered crawlers based on a string match in the user agent
Also improves performance of crawler detection slightly
2017-09-29 12:31:50 +10:00
6baea9948b
Revert "fix the build"
...
This reverts commit 8b74c7d325
2017-09-29 08:57:06 +08:00
8dae98a3f6
Skip randomly failing test on Travis for now.
2017-09-29 08:32:19 +08:00
8b74c7d325
fix the build
2017-09-28 15:50:01 +02:00
07e84a3afa
FIX: Hack our title retriever so that it parses YouTube URLs
2017-09-28 09:30:22 -04:00
ab68379abb
Use `PostDestroyer` to delete topics when performing bulk operation ( #5202 )
...
* Use `PostDestroyer` to delete topics when performing bulk operation
This PR should fix this bug: https://meta.discourse.org/t/bulk-deletion-of-topics-not-logged/50407?u=osama
* failing test
2017-09-28 14:22:49 +02:00
5f1c29e424
FIX: Display json response when `Discourse::InvalidAccess` is raised for
...
non json requests.
2017-09-28 15:31:16 +08:00
8ecf313a81
FIX: correctly raise errors when downloads fail
...
This corrects an issue where we are hitting Gravatar for 404 over and over
Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
426d2178c3
Fix undefined variable in `TopicCreator`.
2017-09-28 12:25:42 +08:00
4319d8a142
FIX: Missing template error when rendering `topics#show` error message.
2017-09-28 11:06:44 +08:00
3e6bf38394
Merge pull request #5207 from tgxworld/try_travis_fix
...
Fix randomly failing test.
2017-09-28 10:56:05 +08:00
d4388f54a2
FIX: Use exact patht to ensure we always redirect with the right format.
2017-09-28 10:29:41 +08:00
4f0fee1ce7
FIX: Test failures
2017-09-27 17:02:36 -04:00
41c3941c4c
FEATURE: Support regular expressions for watched words
2017-09-27 15:48:57 -04:00
fa41913ba5
FIX: Don't count private content in New User of the Month
2017-09-27 15:03:24 -04:00
6a7920ad75
FIX: wasn't able to change default theme
2017-09-27 20:05:31 +02:00
7578d8fc44
Add a `DiscourseEvent` for when a topic is closed
2017-09-27 14:00:53 -04:00
3e13becf33
A safe way to create class variables in a multisite environment.
...
This should allow plugins to set class variables that will not
stomp on other plugins.
2017-09-27 13:00:47 -04:00
5324c01209
FIX: Don't raise an error if reading from URL timeout.
2017-09-27 14:53:22 +08:00
af01e62b14
FIX: wasn't allowed to set a user's title anymore
2017-09-26 20:13:24 +02:00
28c54b42c5
FIX: wasn't able to update user options anymore
2017-09-26 20:00:10 +02:00
367fb1c524
FIX: Onebox fails on encoded URL.
...
https://meta.discourse.org/t/onebox-breaks-if-theres-chinese-text-in-url/67364
2017-09-26 18:34:54 +08:00
c25730935e
FIX: Do not include non-human users on suspected users list.
...
https://meta.discourse.org/t/discobot-is-a-suspect-user/70558
2017-09-26 15:04:08 +08:00
5d37f8673b
PERF: Only send down suggested payload when loading last chunk.
2017-09-26 14:42:27 +08:00
c06b782cab
PERF: Reduce number of topics to filter while querying for unread.
2017-09-26 12:36:52 +08:00
c37598ddbc
Merge pull request #5200 from gschlager/embed
...
FIX: do not escape already escaped chars in URL
2017-09-26 09:07:57 +08:00
383d771265
Fix broken tests
2017-09-25 12:52:45 -04:00
09ed2ed749
Add Suspend User to flags page
2017-09-25 12:28:00 -04:00
6bce3004d9
UX: Nicer selection of suspend duration
2017-09-25 12:28:00 -04:00
677b016387
Send a suspension message via email to a user
2017-09-25 12:26:41 -04:00
561fa7d0cd
FEATURE: Site Setting to hide suspension reason on the public profile
2017-09-25 12:25:14 -04:00
d7c37d9369
Add front end service for staff controls
2017-09-25 12:25:14 -04:00
5e69217793
Add filtering support to flags
2017-09-25 12:25:14 -04:00
b8d9a6f747
Fix randomly failing spec.
2017-09-25 20:50:03 +08:00
4e5e7dc736
FIX: Fix ActiveRecord API that was removed in Rails 5.1.
2017-09-25 16:16:37 +08:00
88555f32cf
Improve specs.
2017-09-25 13:49:00 +08:00
9540b952fd
Fix broken condition in PostgresqlFallbackAdapter.
2017-09-25 13:48:59 +08:00
e542884b00
FIX: Incorrect notification state being published.
2017-09-25 13:48:59 +08:00
77d4c4d8dc
Fix all the errors to get our tests green on Rails 5.1.
2017-09-25 13:48:58 +08:00
6f6b47f096
FIX: do not escape already escaped chars in URL
2017-09-22 17:36:44 +02:00
1a435414d5
FIX: handle URL encoded email addresses
2017-09-22 14:26:06 +02:00
e582e86da3
Merge pull request #5197 from lidimayra/workspace
...
Add spec to cover "Badge Type has many Badges" relation
2017-09-20 11:37:53 +02:00
bfda6884b1
Fix randomly failing spec.
2017-09-20 13:30:15 +08:00
66ed7195d6
Add spec to cover Badge Type has many Badges relation
...
Also: fix filename. `_spec` suffix was missing.
By default, RSpec ignores files in this situation.
Ref: https://github.com/rspec/rspec-core/issues/642
2017-09-20 00:51:32 -03:00
87b4246c14
FIX: notify about whispered reply
2017-09-19 15:51:10 +02:00
8ed318c4fe
display 'similar to' earlier when composing a post
2017-09-16 01:03:29 +02:00
1a9762a9c0
Fixed private group messages being exposed in suggested topics.
...
Revert "Revert "PERF: Avoid unnecessary expensive joins if possible.""
This reverts commit d9714c21c8
2017-09-15 23:40:53 +08:00
797936d2c5
FIX: don't leak whisper count in user card
2017-09-14 20:08:16 +02:00
16fe7aa307
FEATURE: automatically handle flags and posts that have been waiting in a queue for a long time. Flags will be deferred. Posts waiting for approval will be rejected. Control how old the records need to be with the auto_handle_queued_age site setting.
2017-09-14 12:01:06 -04:00
f3d3129113
FIX: Use default locale for edit reason when owner of post gets changed
2017-09-14 17:17:37 +02:00
efef422416
FIX: Use default locale for moderator post when posts are moved
2017-09-14 17:17:37 +02:00
eb61ad0114
fix the build
2017-09-13 18:25:58 +02:00
d9465bac13
add 'staged' column to user export
2017-09-13 18:09:11 +02:00
0096ee40da
FIX: only show participants the user can see
2017-09-13 17:14:03 +02:00
6e9671c2c3
UX: Placeholder images color changed & tootip added
2017-09-13 15:16:38 +05:30
beea5cac48
FIX: send the queued posts reminder as a message to moderators instead of an email to the contact_email
2017-09-12 18:00:51 -04:00
31ecb4fecf
FIX: Handle incoming emails without email address in From header ( #5177 )
2017-09-12 22:35:24 +02:00
6831efe2e9
FIX: no notification was being sent when a post is hidden by community flags
2017-09-12 15:43:44 -04:00
9b3b39d8a2
FIX: Users should be able to activate their emails even if unapproved
...
Note in discourse `active` means "Email is active" - they still can't
login until approved
2017-09-12 15:04:39 -04:00
104d97695d
FIX: don't activate un-confirmed email on omniauth authentication ( #5176 )
2017-09-12 17:36:17 +02:00
171d9e5aed
SECURITY: Prevent users from updating to blacklisted email domains
2017-09-12 10:11:08 -04:00
07bfe3d053
FIX: Use a distrbuted cache for site locale.
2017-09-12 19:36:17 +08:00
d7d9923b8e
FIX: display email validation error messages
2017-09-11 13:22:14 -04:00
5d4221fbe1
PERF: Avoid calling expensive `PostGuardian#can_see_post?` multiple times.
...
Before
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 19
75: 19
90: 21
99: 27
topic:
50: 56
75: 62
90: 64
99: 99
timings:
load_rails: 1262
ruby-version: 2.4.1-p111
rss_kb: 198432
pss_kb: 136612
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_9877: 327892
pss_kb_9877: 263671
rss_kb_9946: 325468
pss_kb_9946: 261671
rss_kb_10153: 326456
pss_kb_10153: 262657
```
After
```
Your Results: (note for timings- percentile is first, duration is second
in millisecs)
---
topic_admin:
50: 18
75: 18
90: 20
99: 28
topic:
50: 41
75: 42
90: 46
99: 49
timings:
load_rails: 1201
ruby-version: 2.4.1-p111
rss_kb: 187936
pss_kb: 123596
virtual: physical
architecture: amd64
operatingsystem: Ubuntu
memorysize: 15.59 GB
kernelversion: 4.10.0
physicalprocessorcount: 1
processor0: Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
rss_kb_26478: 342360
pss_kb_26478: 276696
rss_kb_26547: 340368
pss_kb_26547: 275930
rss_kb_26747: 338964
pss_kb_26747: 274466
```
2017-09-08 14:07:24 +08:00
a0daa7cad0
Oops fix build again.
2017-09-07 18:59:02 +08:00
db929e58fc
FIX: Don't allow staff to approve users with unverified emails
2017-09-04 12:55:39 -04:00
caedefd675
FIX: correctly resets user_themes template
...
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
5c1143cd55
Add missing test case for `PostController#timings`.
2017-09-04 16:36:02 +08:00
4cef3cd762
move fix to top of test
2017-09-01 13:12:47 -04:00
936582b8d1
Correct flaky spec
...
Can fail if the machine running tests has less that 10% free space
2017-09-01 13:10:01 -04:00
0fb7831749
FEATURE: Add placeholders to broken and large image files ( #5113 )
2017-09-01 10:26:13 -04:00
e283e6aea0
FEATURE: allowed_iframes site setting for allowing iframes
...
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
3bdade8970
correct fragile spec
2017-08-31 15:55:56 -04:00
66f2925348
SECURITY: do not include links from whispers in topic summary map
...
https://meta.discourse.org/t/staff-whispers-links-in-whispers-showing-up-publicly-in-topics-summary/69134?u=techapj
2017-08-31 23:44:54 +05:30
04e3526096
Only remove default locale which is the only column we touch
...
see: https://meta.discourse.org/t/failing-tests-in-discourse-dev-due-to-multisite/68720/5
2017-08-29 14:02:24 -04:00
c705159d22
Remove email column from user table
2017-08-29 11:50:56 -04:00
37e5ee858f
REFACTOR: Just pass a block instead of using a lambda.
2017-08-29 08:26:48 +08:00
50203794e6
FIX: staged users should get emails on must_approve_users sites
2017-08-28 17:32:07 -04:00
9f0f086b3e
FEATURE: allow API to mark accounts as approved on creation
2017-08-28 15:36:46 -04:00
6bc74ceb50
Split alias levels in mentionable and messageable levels. ( #5065 )
...
* Split alias levels in mentionable and messageable levels.
* Fixed some tests.
* Set messageable level to everyone by default.
* By defaults, groups are not mentionable or messageable.
* Made staff groups messageable by the system.
2017-08-28 12:32:08 -04:00
bb3a5910d7
Support for sending PMs to email addresses ( #4988 )
...
* Added support for sending PMs to email addresses.
* Made changes after review.
* Added settings validator.
* Fixed tests.
2017-08-28 12:07:30 -04:00
398604ac71
FEATURE: set purge_unactivated_users_grace_period_days to 0 to disable purging unactivated users
2017-08-25 15:20:06 -04:00
2c56f8df7c
FEATURE: show tags in search results
2017-08-25 11:52:59 -04:00
bcbee91f0c
lint
2017-08-24 13:24:52 -04:00
f60a1b0275
correct erratic spec
2017-08-24 13:19:26 -04:00
a4e3e081c9
correct spec
2017-08-24 10:40:14 -04:00
41ca527d7a
Fix Rubocop error.
2017-08-24 15:28:18 +09:00
8779490ce4
Move new controller specs to reqeusts folder.
2017-08-24 12:01:11 +09:00
68b8acbcfa
Make Redis test less brittle.
2017-08-24 10:00:15 +09:00
4b4169c8fd
Merge pull request #5053 from fantasticfears/session-controller
...
Spec for local auth check
2017-08-24 09:42:54 +09:00
d0f5a3d7a4
`Sidekiq::Testing.fake!` is the default mode.
2017-08-24 09:40:19 +09:00
027b999828
Merge pull request #5071 from LeoMcA/remove_duplicated_without_posts
...
FIX: removed the duplicated staged users without posts
2017-08-24 09:23:36 +09:00
f766ea4257
Correct short url decoding for sha1s leading with zero
...
This was picked up cause we had a flaky test!
2017-08-23 11:08:18 -04:00
c7532003f3
add more diagnostics for flaky spec
2017-08-23 10:41:57 -04:00
3986367f3f
update pr based on review
2017-08-23 14:55:34 +01:00
7c15b27a90
Merge pull request #5073 from xrav3nz/extract-github-avatar
...
FEATURE: import Github profile picture
2017-08-23 16:18:46 +09:00
5868508e98
GH#retrieve_avatar: simplify conditional and restructured testing
2017-08-22 23:46:50 -04:00
49f0119c12
FEATURE: import Github profile picture
2017-08-22 20:23:47 -04:00
8dfb1be4d1
FEATURE: unlisted *only* means not listed in topic lists
...
Remove security by obscurity feature that tries for exact slug match
If you need to hide a topic from users either move to a secure category
or convert to a PM
2017-08-22 17:53:54 -04:00
224796a7d4
FIX: wrongs counts on tags with deleted topics
2017-08-22 16:55:05 -04:00
e8cdb1d8a7
correct flaky spec
2017-08-22 16:54:29 -04:00
d7a2584c6e
FEATURE: image uploads now have short urls
...
Shorten all image uploads to use short urls, this is the client
side implementation.
2017-08-22 16:40:08 -04:00
117ce24ac3
Correct a flaky spec
2017-08-22 13:56:38 -04:00
d4c28f6fcb
remove stray puts from spec
2017-08-22 11:46:51 -04:00
bcf7dc38c2
FEATURE: server side support for upload:// markdown
...
This allows uploads to be specified using short sha1 hash instead of full
URL
Client side change is pending
2017-08-22 11:46:23 -04:00
be1df3ba75
FIX: transfer posts by duplicated staged users to original
2017-08-22 09:58:51 +01:00
Régis Hanol
Robin Ward
Gerhard Schlager
Guo Xiang Tan
Philipp Daniels
Sam
Arpit Jalan
Guo Xiang Tan
Neil Lalonde
scossar
Joffrey JAFFEUX
Kyle Zhao
Vinoth Kannan
Jeff Wong
OsamaSayegh
Vinoth Kanan
ckeboss
Erick Guan
Rafael dos Santos Silva
Panayotis Matsinopoulos
Eleanor Demis
Lidiane Taquehara
Leo McArdle
Bianca Nenciu