Commit Graph

15621 Commits

Author SHA1 Message Date
Joffrey JAFFEUX 813df1a3fb
FIX: not permitted theme params when importing theme 2017-12-14 11:25:58 +01:00
Joffrey JAFFEUX 1eda8c50f0
FIX: constant lookup error when exporting theme 2017-12-14 11:25:11 +01:00
Joffrey JAFFEUX 28a63135b8
FIX: set a default color scheme when creating a new one 2017-12-14 08:21:56 +01:00
Guo Xiang Tan f2565f6c7e SECURITY: Any group can be invited into a PM. 2017-12-14 14:57:48 +08:00
Sam 14cfce2827 Merge branch 'master' of github.com:discourse/discourse 2017-12-14 17:17:02 +11:00
Sam 96584403cd SECURITY: prevent staged accounts from changing email 2017-12-14 17:16:49 +11:00
Guo Xiang Tan 34342ad0d8 FIX: `User#user_avatar` may be nil. 2017-12-14 13:23:03 +08:00
scossar 11050e5d10 Don't override count value that has been set by query.count 2017-12-13 18:48:46 -08:00
Maja Komel 52e38e5527 FIX: save whisper drafts (#5417) 2017-12-14 11:35:08 +11:00
Régis Hanol 5db3d39b05 FIX: Post.reply_ids should also handle quotes 2017-12-14 00:43:48 +01:00
Régis Hanol 53bbf08ea1 FIX: wasn't redirected to group inbox 2017-12-13 23:31:20 +01:00
Régis Hanol c63ecd87f2 FIX: ensure we're always changing 1 post ownership 2017-12-13 22:45:14 +01:00
Maja Komel 0f4ed2e070 display language name in user locale selector - make it consistent with admin (#5424) 2017-12-14 08:17:36 +11:00
Régis Hanol 1b4483c942 FEATURE: Added 'select +below' and 'select +all replies' options to selecting posts 2017-12-13 22:12:06 +01:00
Neil Lalonde 712c9fca1b sorry rubocop 2017-12-13 15:47:42 -05:00
Neil Lalonde 3f1d6a302e FIX: links with query params to external sites fail to load if ga universal auto link domains is used 2017-12-13 13:58:44 -05:00
Joffrey JAFFEUX 8001f68c32
FIX: make sure we don’t show scrollbars on toolbar-popup-menu 2017-12-13 19:01:30 +01:00
Joffrey JAFFEUX e42812fcf7
FIX: make sure new badges have a default type 2017-12-13 10:55:16 +01:00
Joffrey JAFFEUX c1c31b99ce
Replaces toolbar popup-menu with select-kit 2017-12-13 10:49:32 +01:00
Guo Xiang Tan d5293aeae2 Clean `Topic#slug` when `SiteSetting.slug_generation_method` changes.
https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld
2017-12-13 16:11:07 +08:00
Sam 9d925f6b26 FIX: correctly count participants when more than 24
Also cuts out one query for the normal case
2017-12-13 17:19:42 +11:00
Sam b998efdc94 FIX: do not send mailing list emails to unapproved users 2017-12-13 15:13:17 +11:00
Sam a393d3bcbb FIX: ensure staged accounts are always inactive
If for any reason active is stored in the user model, clear it out
prior to creating an account
2017-12-13 14:22:16 +11:00
Gerhard Schlager a7c1b0c81f FIX: path whitelist for embedded comments didn't work with non-ASCII chars 2017-12-12 20:17:46 +01:00
Gerhard Schlager e30851e45a Move escape_uri method to a more suitable place 2017-12-12 20:17:46 +01:00
Robin Ward 5fbfe34356 FIX: Moderation History wasn't working from timeline admin button 2017-12-12 12:21:10 -05:00
Kris 1be32bf4cf FIX: text indent on twitter oneboxes 2017-12-12 11:17:09 -05:00
Kris d6a18f72b6 UX: Mobile user profile button adjustment 2017-12-12 10:58:03 -05:00
Kris 55c019f776 UX: Cleaning up staff counters on user profiles 2017-12-12 10:40:16 -05:00
Arpit Jalan 492af81e67 FIX: save registration_ip_address for staged users logging in via social auth 2017-12-12 17:41:16 +05:30
Guo Xiang Tan e2b64257b3 Fix undefined method for `NilClass` error. 2017-12-12 18:54:29 +08:00
Régis Hanol af3c153687 make robocop 🤖 happy 2017-12-12 11:33:35 +01:00
Régis Hanol 62a5b174e1 FIX: wasn't able to use the same username when taking over a staged account 2017-12-12 11:26:00 +01:00
Arpit Jalan b014540fde FIX: view was getting rendered twice for rate limiting error 2017-12-12 14:48:58 +05:30
Kris 920571ae07 UX: Making button on advanced search page match input height 2017-12-11 17:15:08 -05:00
Kris 60cd28d5b9
UX: Cleaning up user profiles on mobile 2017-12-11 15:40:04 -05:00
Vinoth Kannan c17a28f875 Using const instead of var while declaring 2017-12-11 14:26:21 +05:30
Guo Xiang Tan 4bd5acec47 FIX: `Topic#featured_link` may contain more than a URL. 2017-12-11 16:36:19 +08:00
Arpit Jalan 3c56c9b637 FIX: strip webhook payload_url 2017-12-11 13:48:11 +05:30
Arpit Jalan 3c230d8f97 FIX: 'redirect_to :back' is deprecated 2017-12-11 12:18:19 +05:30
Kris edd7cb4f0d UX: Replacing some PX font definitions with EM based units 2017-12-08 17:10:49 -05:00
Robin Ward b3bdc68639 UX: Add link to "Moderation History" to flagging interface 2017-12-08 15:48:32 -05:00
Vinoth Kannan fdef4e58f0 Skip markdown table conversion from rich text feature flag setting 2017-12-08 18:30:38 +05:30
Vinoth Kannan b9c0488687 New site setting to enable or disable rich text pasting 2017-12-08 14:09:39 +05:30
Vinoth Kannan 0a47642003 FIX: Pasted text removing if server unable to parse HTML to Markdown 2017-12-08 13:38:54 +05:30
Sam cff9b8846d FIX: rendering %lt;/div noscript in header 2017-12-08 10:30:00 +11:00
Robin Ward 74b9828731 FIX: Remove mentions filters from user and groups
Additionally return no data if disabled
2017-12-07 16:29:02 -05:00
Joffrey JAFFEUX fd99e1ef56 FEATURE: site setting enable_mentions to turn on/off mentions 2017-12-07 16:27:58 -05:00
Kris 3e4f02a180 UX: Removing staff highlight from .name so it only applies to .user-title 2017-12-07 16:10:54 -05:00
Kris 6d5e5629f6 FIX: Choices input layout bug in IE11 2017-12-07 15:49:54 -05:00
Robin Ward 3cf4886d3e UX: Add a class name to target the embedded post controls 2017-12-07 15:01:34 -05:00
Kris f7c77171b9 UX: Eliminating a "sweet spot" at 870px viewport where the topic-body exceeds 690px wide 2017-12-07 14:32:31 -05:00
Robin Ward aeebcef7e2 FIX: Don't show the email from the suspension on the user profile 2017-12-07 13:27:02 -05:00
Robin Ward 4ae1bbaeba FIX: Only show the full suspension reason on the admin side 2017-12-07 13:27:02 -05:00
Kris ef0d9d631c
UX: New style for staff highlight
Moved highlight to cooked content, also highlighting primary name (with shield) and title (if applicable). 

**Before**:
![image](https://user-images.githubusercontent.com/1681963/33724323-2269e79e-db3d-11e7-8c93-75b9dc9a1ab7.png)


**After**:
<img width="809" alt="screen shot 2017-12-06 at 3 55 31 pm" src="https://user-images.githubusercontent.com/1681963/33724287-09eb66de-db3d-11e7-8e02-0062ed2b8716.png">
2017-12-07 12:40:39 -05:00
Kris 282633bc97 FIX: New topic composer layout in iOS10 2017-12-07 12:04:39 -05:00
Vinoth Kannan be848b8a5c FIX: Image pasted twice when it copied from browser 2017-12-07 21:23:31 +05:30
Vinoth Kannan 5cceb95f92 Improvement in composer HTML pasting 2017-12-07 21:13:09 +05:30
Vinoth Kannan 858cd3a589 Improvement in composer HTML pasting 2017-12-07 21:08:08 +05:30
Arpit Jalan c168c5895f
Merge pull request #5407 from techAPJ/show-inactive-accounts
FEATURE: new site setting show_inactive_accounts
2017-12-07 20:52:37 +05:30
Maja Komel cce077de56 move /tags/ topics list out of footer (#5405) 2017-12-07 15:25:04 +01:00
Arpit Jalan 5003f07b2c FEATURE: new site setting show_inactive_accounts 2017-12-07 19:22:41 +05:30
Joffrey JAFFEUX f0ef307d2d
FIX: topic timer offset applied two times
timezone offset was calculated and sent from browser to server, it would be applied on utc time generated from '2013-11-22 5:00' format for example and then sent back to browser which would display it thinking it's UTC time using `moment(utc time)` when it's in fact an UTC time we have offseted with the initial user timezone.

This is impossible to automatically test in the current app state. Easiest reproduction is in live browser after setting your timezone to `America/New_York`, when setting a topic timer to later_today, after save, the time under the topic should be off to something roughly equal +1/-1  hour to your timezone offset.
2017-12-07 14:42:58 +01:00
Kyle Zhao c52f747031 FEATURE: Catalan Translations (#5404) 2017-12-07 10:36:25 +01:00
Guo Xiang Tan c64774f4f8 Remove debugging code. 2017-12-07 06:48:12 +08:00
Régis Hanol c08d53f2dd keyValueStore isn't available in test 2017-12-06 23:28:28 +01:00
Kris 4d9f26879b FIX: Composer preview-area plugin layout 2017-12-06 16:12:52 -05:00
Régis Hanol ae0acfb1df FEATURE: live reply indicators at the bottom of topic 2017-12-06 21:58:59 +01:00
Régis Hanol ea50f823cb FIX: logging in after an anon ❤️ does not count the ❤️ 2017-12-06 21:58:05 +01:00
Robin Ward cf3ea4f9bd UX: Use the same 404 page for the `unknown` route and exception handler 2017-12-06 15:20:24 -05:00
Robin Ward e8d5d34755 FIX: Don't show trust level if the API didn't return it 2017-12-06 13:13:51 -05:00
ckeboss 7a093ea5d6 Format username for desktop notifications (#5403)
FIX: Desktop notifications weren't formatting the username
2017-12-06 12:52:11 -05:00
Kris f559275b14 FIX: Adjusted the composer preview to avoid odd scroll issue 2017-12-06 11:31:36 -05:00
Vinoth Kannan 7d88cfde0e Skip paste handling if composer textarea lost focus 2017-12-06 19:36:13 +05:30
Guo Xiang Tan 4531563717 Hide new advanced editor and preview sync behind a hidden site settings. 2017-12-06 12:34:58 +08:00
Kris da78e75f6f UX: Mobile post control button color was too specific, overriding solved plugin 2017-12-05 21:07:20 -05:00
Joffrey JAFFEUX 75463e5a91
FIX: correctly print html entity when used in a locale for none 2017-12-05 19:09:12 -05:00
Kyle Zhao 5f318a5241 FEATURE: Replace SimpleRSS with Ruby RSS module (#5311)
* SPEC: PollFeedJob parsing atom feed

* add FeedItemAccessor

It is to provide a consistent interface to access a feed item's tag
content.

* add FeedElementInstaller

to install non-standard and non-namespaced feed elements

* FEATURE: replace SimpleRSS with Ruby RSS module

* get FinalDestination and download with Excon

* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
Robin Ward 410994b7f5 FEATURE: Show a button to Staff for "Moderation History" on posts/topics
When clicked, it pops up a modal showing a history of moderation actions
taken on the post or topic.
2017-12-05 15:20:20 -05:00
Vinoth Kannan 94e9be3b88 Make eslint happy 2017-12-06 01:28:22 +05:30
Vinoth Kannan 8cf7152151 FIX: IE compatability issue in clipboard data types array 2017-12-06 01:02:06 +05:30
Vinoth Kannan 6e054b2572 FEATURE: Convert HTML to Markdown while pasting in composer 2017-12-05 12:23:39 -05:00
Arpit Jalan daeb7694bc update annotations 2017-12-05 21:03:20 +05:30
Vinoth Kannan 37948838be FIX: Global event variable is not compatible with all browsers 2017-12-05 11:27:08 +05:30
Vinoth Kannan 4654f076f5 FIX: Drive spreadsheet table not converting to Markdown table 2017-12-05 11:03:33 +05:30
Kris a1d880a215 FIX: Broken variable 2017-12-04 20:22:04 -05:00
Kris 4af4081c39
UX: Updating the edit post title layout 2017-12-04 15:29:02 -05:00
Neil Lalonde b5a967ab43 lint failure 2017-12-04 14:32:01 -05:00
Neil Lalonde 23ea4b6739 FIX: don't create featured link if title includes more than a url 2017-12-04 14:21:08 -05:00
Neil Lalonde fb08441802 Revert "FIX: don't create featured link if title includes more than a url" 2017-12-04 12:53:12 -05:00
Vinoth Kannan e14281bdf6
Merge pull request #5393 from vinothkannans/clip-master
FEATURE: Paste plain text table as Markdown table
2017-12-04 22:45:07 +05:30
Neil Lalonde cde42c3f69 FIX: don't create featured link if title includes more than a url 2017-12-04 12:03:41 -05:00
Kris b55b7c5356 FIX: Removing horizontal scrollbar in category modal 2017-12-04 12:00:34 -05:00
Kris 8eb7518d2a FIX: Disappearing tag input border on hi-res devices/when scaling 2017-12-04 11:35:02 -05:00
Kris f1b5227aa6 FIX: Mobile composer layout for PMs 2017-12-04 11:15:10 -05:00
Kris 13840942b9 UX: Fixing code highlighting color issue in dark themes 2017-12-04 10:28:32 -05:00
Vinoth Kannan ab4c953d82 FEATURE: Paste plain text table as Markdown table 2017-12-04 20:53:42 +05:30
Arpit Jalan f466791a15 FIX: resolve from URL when using /new-topic route 2017-12-04 17:34:17 +05:30
Arpit Jalan 0e0794dff9 FIX: correct use of invitee vs inviter in email templates 2017-12-04 14:09:48 +05:30
Guo Xiang Tan e73fbfe265 FIX: `Topic#featured_link_root_domain` extracts URL before parsing. 2017-12-04 10:00:07 +08:00
Robin Ward 3e83c34785 FIX: Don't include `null` class when rendering the pinned dropdown 2017-12-03 16:20:35 -05:00
Robin Ward e80caab247 FIX: Reply to tab was not using the username formatter 2017-12-03 15:49:21 -05:00
Robin Ward a0da098e6b UX: Add new classes to make user creation more targetable 2017-12-03 15:03:06 -05:00
Kris c8ad89afd4 UX: Adjustments to composer uploading message 2017-12-01 22:31:40 -05:00
Kris d615a37eba UX: Hiding composer preview reduces width of composer overlay 2017-12-01 22:23:12 -05:00
Jeff Atwood bcd57d72a9
Merge pull request #5389 from vinothkannans/clip-master
FIX: Skip pasting files if plain text available in clipboard
2017-12-01 16:41:39 -08:00
Kris a43c044b1e UX: Removing an old font declaration 2017-12-01 16:17:01 -05:00
Neil Lalonde b35960fc35 FIX: export admin reports to csv would have 0 rows in the csv file 2017-12-01 15:50:36 -05:00
Vinoth Kannan e2c60ea4b2 FIX: Skip pasting files if plain text available in clipboard 2017-12-02 02:05:11 +05:30
Joffrey JAFFEUX dbadebacd1
FIX: allows select-kit to search by null value 2017-12-01 20:02:00 +01:00
Kris 29bdf35977 FIX: Composer not properly centered in IE11 2017-12-01 13:58:04 -05:00
Kris e7725e23ad FIX: Flexbox composer issue in IE11, bad flex-shrink default 2017-12-01 13:12:25 -05:00
Arpit Jalan 54f5b4d4e0 FEATURE: log clicks on full page search 2017-12-01 23:21:16 +05:30
Kris af11913314 FIX: Positining of search spinner in tablet-sized viewports 2017-12-01 11:01:03 -05:00
Joffrey JAFFEUX 966dbb9705
FIX: do not give any element focus when creating topic 2017-12-01 13:16:36 +01:00
Guo Xiang Tan 2e860eddc1 Don't sync scroll when input is not scrollable.
https://meta.discourse.org/t/composer-preview-scroll-not-syncing-with-editor/74975/14?u=tgxworld
2017-12-01 17:08:03 +08:00
Jeff Atwood 3e42dceaae "reply to which topic" needs wider buttons 2017-11-30 23:25:32 -08:00
Arpit Jalan 496cd3b4df
Merge pull request #5385 from techAPJ/search-logs-improvements
FEATURE: support search click through tracking for user, category and tags
2017-12-01 12:08:38 +05:30
Arpit Jalan e3925278e2 FEATURE: support search click through tracking for user, category and tags
https://meta.discourse.org/t/search-logs-page/73281/11?u=techapj

This commit adds following features:

- support for tracking click through to user, tag and category
- new filter for search type (header, full page)

This commit also removes "most viewed topic" field from search logs page because we are now tracking multiple click through entities, so topic is not a special entity anymore. This also improves query perf. The query now takes `20.5ms` to runs, as opposed to `655.9ms` previously.
2017-12-01 12:04:55 +05:30
Vinoth Kannan 7f2eeaf767 FIX: Password required flag should be cleared whenever clearing the raw password (#5384) 2017-12-01 15:19:24 +11:00
Kris 9876f3d0ee FIX: extraneous mobile CSS, flagged badge color in dropdown 2017-11-30 17:29:29 -05:00
Neil Lalonde 3dd67e9c04 replace 'email' with envelope icon on user card for staged users 2017-11-30 16:55:27 -05:00
Neil Lalonde bca90381cf FIX: save drafts of new topics with titles but no body 2017-11-30 15:16:12 -05:00
Robin Ward dfd309c64f FIX: The user summary wasn't using the username formatter 2017-11-30 12:17:03 -05:00
Kris 3f8d0c5c94 FIX: Increasing overridden label contrast in settings 2017-11-30 10:13:09 -05:00
Vinoth Kannan 704dbd7cfc FIX: Unable to remove existing user title (#5386) 2017-11-30 15:54:38 +01:00
Vinoth Kannan 1ee48966ca REVERT: FIX: Password required flag should be cleared whenever clearing the raw password 2017-11-30 16:17:14 +05:30
Vinoth Kannan 1776649b4d FIX: Password required flag should be cleared whenever clearing the raw password 2017-11-30 13:40:18 +05:30
Guo Xiang Tan c128e421c4 FIX: Don't run job if topic timer has already been deleted. 2017-11-30 15:26:26 +08:00
Guo Xiang Tan 853b51b519 Add uniqueness validation for `SingleSignOnRecord#external_id`. 2017-11-30 15:15:52 +08:00
Guo Xiang Tan f7f743970b Just use space to prettify SSO verbose error logging. 2017-11-30 15:10:00 +08:00
Guo Xiang Tan 1c2d1682ae
Merge pull request #5328 from tgxworld/reenable_interpolation_keys_check
FIX: Re-enable invalid interpolation keys check and allow default key…
2017-11-30 13:04:54 +08:00
Sam 05f5df69b1 UX: Add tooltips for messages and notifications in header 2017-11-30 12:56:54 +11:00
Sam 772301bc65 woops 2017-11-30 12:32:50 +11:00
Sam bf1f6c7fe4 UX: better help text for composer collapse / discard
also: warn on collapsed close if you are to discard content
2017-11-30 12:28:00 +11:00
Régis Hanol 0d34caff85 UX: show error message when no gravatar is associated 2017-11-29 18:09:44 +01:00
Régis Hanol 1218ead355 UX: preloaded gravatar was appearing on the right instead of the left 2017-11-29 18:07:09 +01:00
Guo Xiang Tan 9fbe1436b6 UX: Replace heuristic solution root domain extraction for topic featured link. 2017-11-29 21:52:41 +08:00
Guo Xiang Tan 8491c5fba5 UX: Replace heuristic solution for extracting root domain. 2017-11-29 16:26:46 +08:00
Guo Xiang Tan 3e9c3f6f13 Fix JS test.
* `new Array` doesn't seem to be available in phantomJS yet.
2017-11-29 16:03:00 +08:00
Guo Xiang Tan 5b965ab5d0 Sync editor and preview when preview is updated. 2017-11-29 11:19:04 +08:00
Kris 03eb278034
FIX: Increased composer width to match preview, border width fix (#5379) 2017-11-28 21:57:27 -05:00
Guo Xiang Tan ebc31975e8 `Ember.run.schedule` -> `Ember.run.scheduleOnce`. 2017-11-29 10:43:59 +08:00
Guo Xiang Tan de17a8e856 UX: Sync input and preview when user is typing. 2017-11-29 09:56:15 +08:00
Guo Xiang Tan 4816619ba3 FIX: Editor and preview does not sync when scrolled to the bottom. 2017-11-29 08:38:57 +08:00
Guo Xiang Tan bb0b7b61d7 FIX: Don't fail silently when updating a record. 2017-11-29 08:01:13 +08:00
Gerhard Schlager 44ee388070 FEATURE: omit images from og and twitter description tags 2017-11-28 21:34:02 +01:00
Robin Ward 04e8b7dffb UX: Remove another plugin outlet container we don't need 2017-11-28 14:46:17 -05:00
Robin Ward 86df5846c8 Don't use a tag for a couple of topic outlets 2017-11-28 14:42:24 -05:00
Robin Ward 823896d698 FIX: Use parseable date format 2017-11-28 14:16:33 -05:00
Kris fbc4191195 moving inputs outside of label tag 2017-11-28 14:12:01 -05:00
Robin Ward 23ee3047bf FIX: Future date input selector was not respecting timezone 2017-11-28 13:44:24 -05:00
Robin Ward f4b3306bf4 FIX: Link from flagged topics to user was broken 2017-11-28 13:10:30 -05:00
Gerhard Schlager 41e70c410c
FEATURE: replace GUID in image name uploaded from iOS (#5370) 2017-11-28 11:05:34 +01:00
Arpit Jalan f37a1d5976 UX: add tooltip to unique on search logs page 2017-11-28 15:29:35 +05:30
Guo Xiang Tan 1d8b834301
Merge pull request #5369 from vinothkannans/queued
FIX: Error if queued post not found while updating
2017-11-28 17:51:05 +08:00
Angus McLeod 8a0d7bb922 Update wizard import to new select-kit style path (#5375) 2017-11-28 10:06:05 +01:00
Guo Xiang Tan 110dfbf42f Uglify doesn't support ES6 yet. 2017-11-28 16:07:27 +08:00
Guo Xiang Tan 7b8699f3be FIX: Can't load `service-worker.js` in production. 2017-11-28 15:40:57 +08:00
Jeff Wong b094894c94 Feature: Add service worker registration method to plugin API 2017-11-28 14:01:41 +08:00
Sam b3b55e18d1 UX: stop warping tiny onebox images 2017-11-28 12:32:35 +11:00
Sam ceaadf6246 UX: adjustments for topic title editing 2017-11-28 12:00:18 +11:00
Kris 87c83f102d small color fix 2017-11-27 18:30:12 -05:00
Kris d31c8ffa87
small color adjustment (#5374) 2017-11-27 18:20:07 -05:00
Sam 5a715b7d55 lint it up 2017-11-28 07:39:24 +11:00
Kris ada1d6b987
Composer restyle
* composer restyle, some input normalization

* style adjustments: spacing, preview background, colors

* small spacing adjustments, removing default iOS input appearance, fixing merge

* small width adjustment

* fixing mobile link modal for small devices

* FIX: more resilient allowInitiatlValueMutation implementation

* Build scrollMap only on scroll.

* FIX: pick date and time was not reseting state

* FIX: removes auto sizing and touchstart support for now

* Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"

This reverts commit b5ed980235.

* tweak icon-library generation

* FIX: regression preventing to set number of hours before closing

This commit also adds a full test suite for editing topic timer.

* FIX: makes allowInitialValueMutation more restrictive

* FIX: invite-list expects initial value mutation

* fixing tag input spacing

* minor input cleanup

* bump onebox version

* FIX: avoids test failing at some times of the day

* FIX: various issues when editing category permissions

This commit also adds multiple tests
2017-11-27 15:23:18 -05:00
Joffrey JAFFEUX 49b1df40fc
FIX: various issues when editing category permissions
This commit also adds multiple tests
2017-11-27 19:50:04 +01:00
Neil Lalonde c22f202e10 FIX: missing likes count on top topics in user summary 2017-11-27 13:42:16 -05:00
Robin Ward 36d46df8dc New setting to show the reply title on the post menu on mobile 2017-11-27 13:21:53 -05:00
Arpit Jalan 2c16240b60 fix the build 2017-11-27 23:18:08 +05:30
Arpit Jalan bf415f2d40 FIX: youtube playlist videos were not functioning properly in fullscreen 2017-11-27 22:56:44 +05:30
Robin Ward 77f90876d3 REFACTOR: Track manual locked user levels separately from groups 2017-11-27 11:23:44 -05:00
Vinoth Kannan 31aa21b5a4 FIX: Error if queued post not found while updating 2017-11-27 19:25:51 +05:30
Sam 608207b2e5 FEATURE: avatar proxy happens in background
This ensures that even if it is slow to download avatars site will
continue to work

Also simplifies hijack pattern
2017-11-27 17:43:24 +11:00
Sam d5e7691ae9 favicon proxy now uses hijack 2017-11-27 14:51:14 +11:00
Guo Xiang Tan 5805979e88 FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
Sam eb428ef54d FEATURE: uploads are processed a faster
Also cleans up API to always return 422 on upload error. (previously returned 200)

Uploads are processed using new hijack pattern
2017-11-27 12:43:35 +11:00
Sam a74ac90bf5 FIX: quote dropped when replying as new topic 2017-11-27 10:08:55 +11:00
Angus McLeod 4b919cd735 Move queuedForTyping assignment (#5366) 2017-11-27 09:43:41 +11:00
Joffrey JAFFEUX 329343be06
FIX: various sizing issues on select-kit 2017-11-26 17:21:39 +01:00
Arpit Jalan abbb2b28eb bump onebox version 2017-11-25 15:53:18 +05:30
Neil Lalonde 39d7745dc5 UX: show staged users' email addresses to staff without requiring a button press 2017-11-24 16:11:34 -05:00
Neil Lalonde 510a2a1e0f remove ancient unused css 2017-11-24 15:42:50 -05:00
Neil Lalonde 6f8f2c494d FIX: admin strings in plugins should fallback to english when untranslated 2017-11-24 14:11:01 -05:00
Kris c2da25dd5c
Cleaning up the 404 page (#5363) 2017-11-24 12:41:31 -05:00
Guo Xiang Tan f3f051a344 UX: Composer textarea should always start at the top. 2017-11-24 23:24:37 +08:00
Joffrey JAFFEUX f2c7f39066
FIX: invite-list expects initial value mutation 2017-11-24 13:32:24 +01:00
Joffrey JAFFEUX 96cdc4e66e
FIX: makes allowInitialValueMutation more restrictive 2017-11-24 13:15:02 +01:00
Gerhard Schlager b3094e9954 FIX: incoming and outgoing emails got lost when post was moved 2017-11-24 11:45:36 +01:00
Guo Xiang Tan 44333c5de3 REFACTORY: Dry up some composer syncing code. 2017-11-24 14:57:36 +08:00
Sam e0e99d4bbd PERF: hijack onebox requests so they do not use up a unicorn worker 2017-11-24 15:31:40 +11:00
Joffrey JAFFEUX 63307c303a
FIX: regression preventing to set number of hours before closing
This commit also adds a full test suite for editing topic timer.
2017-11-24 02:48:45 +01:00
Neil Lalonde 3f58b18dab FEATURE: user card shows staff if a user is staged and lets them check the email address 2017-11-23 16:38:11 -05:00
Arpit Jalan 406ad1a1f2
Merge pull request #5357 from techAPJ/invite-trust-level
FIX: invited users were not granted trust level based on their group
2017-11-23 23:42:20 +05:30
Robin Ward ad07e6e172 FEATURE: `group_removes_trust_level` setting
By default in Discourse, if a group grants a user a particular trust
level that is locked even if they are removed from the group.

With this new setting, when a user is removed from a group their
trust level is set to either the next highest trust level based on group
membership, or they are unlocked and promoted based on the default
mechanisms.
2017-11-23 13:03:24 -05:00
Joffrey JAFFEUX 9208909b26 tweak icon-library generation 2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX dd5562322b Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"
This reverts commit b5ed980235.
2017-11-23 18:24:26 +01:00
Arpit Jalan 3508046e33 FIX: invited users were not granted trust level based on their group
https://meta.discourse.org/t/bulk-invites-and-trust-level/73535

If the user enters password when accepting invite they were not granted
trust level based on their group privileges. It was because `password_required` was set to true when creating user record and when the user was updated again when granting trust level the password validation was raising error saying that the password is empty. This commit fetches fresh user record after the user is created so that the user record can be updated successfully.
2017-11-23 22:19:28 +05:30
Gerhard Schlager 39810e4425 FIX: do not move small post actions 2017-11-23 17:25:53 +01:00
Joffrey JAFFEUX 616a0dae4e
FIX: removes auto sizing and touchstart support for now 2017-11-23 15:34:52 +01:00
Gerhard Schlager eaa54a5a64 FIX: don't store state of composer's preview in mobile view 2017-11-23 15:22:00 +01:00
Joffrey JAFFEUX 5b3ecffbb2
FIX: pick date and time was not reseting state 2017-11-23 15:18:27 +01:00
Guo Xiang Tan c5745feac6 Build scrollMap only on scroll. 2017-11-23 21:44:09 +08:00
Joffrey JAFFEUX fe94e7c453
FIX: more resilient allowInitiatlValueMutation implementation 2017-11-23 14:39:26 +01:00
Guo Xiang Tan ab839d134b Fix scrollmap included NaN values. 2017-11-23 18:08:43 +08:00
Joffrey JAFFEUX 9f0798682e
FIX: tweak alignment of select-kit in navigation bar 2017-11-23 10:42:39 +01:00
Guo Xiang Tan 486016acea UX: Improve editor and preview scroll syncing. 2017-11-23 17:02:02 +08:00
Sam 49f97d75b7 FIX: make uploads safe for block that can run later 2017-11-23 17:28:18 +11:00
Sam d43a54e83a FIX: use current_user.id in onebox instead of param 2017-11-23 15:32:19 +11:00
Sam 2fe131db9f UX: handle super tall images in onebox respectfully.
Tall images got distorted previously
2017-11-23 14:45:46 +11:00
Neil Lalonde 6c86e0c94a FEATURE: remove the featured link by editing the topic 2017-11-22 14:53:35 -05:00
Joffrey JAFFEUX d32c95b6e8
FIX: avoid touch on select-kit causing instant closing of it 2017-11-22 16:36:50 +01:00
Régis Hanol 8a7cbeef00 UX: hide 'dismiss' in notifications dropdown when there are no unread notifications 2017-11-22 15:56:01 +01:00
Régis Hanol 4addc5e329 Add missing contexts when destroying users 2017-11-22 15:43:54 +01:00
Joffrey JAFFEUX acdfb3ed03
FIX: don’t convert an object using EachProxy to an array 2017-11-22 14:33:04 +01:00
Joffrey JAFFEUX b14d9529b8
FIX: adds support for name changes tracking 2017-11-22 13:49:45 +01:00
Joffrey JAFFEUX 86b8f6b238
FIX: cast integer on truthy value and not only true
allows castInteger="true" to work
2017-11-22 13:40:22 +01:00
Joffrey JAFFEUX 5a992fe5e7
FIX: makes sure keyboard is disabled on mobile 2017-11-22 12:33:07 +01:00
Joffrey JAFFEUX a3b511f4f5
FIX: simplify keyboard handling 2017-11-22 11:29:30 +01:00
Joffrey JAFFEUX b2b565c2fb
select-kit initial plugin api implementation (0.8.13)
```
api.modifySelectKit("identifier-of-the-select-targeted")
  .modifyContent((context, existingContent) => {})
  .appendContent(() => {})
  .prependContent(() => {})
  .onSelect((context, val) => {});
```
2017-11-22 10:34:12 +01:00
Joffrey JAFFEUX f3db3c7e0b
FIX: future-date-input-row lost datetimes 2017-11-22 08:52:00 +01:00
Sam a92f61e926 FIX: allow login required sites access to attachements 2017-11-22 10:50:55 +11:00
Joffrey JAFFEUX 761f4afd85
FIX: tab should select and focus next tabindex 2017-11-21 23:28:48 +01:00
Robin Ward 8d98752b57 Allow sites to bootstrap the error page.
This will display working dropdowns and such even if the page is a 404.
2017-11-21 16:13:09 -05:00
Robin Ward be34b796ea UX: Add targetable class 2017-11-21 14:55:55 -05:00
Neil Lalonde 33feb62673 FIX: times showing as < 1m instead of blank 2017-11-21 14:33:49 -05:00
Neil Lalonde 66e53f449a UX: Auth complete page/modal has a link to continue to the site to accomodate auth methods that can't automatically redirect to Discourse 2017-11-21 13:56:19 -05:00
Joffrey JAFFEUX 12beb77afa
FIX: make sure the element exists before calling `off`
This commit fixes an issue happening only when running tests under `/qunit` and not with `rake qunit:test`
2017-11-21 19:08:59 +01:00
Robin Ward 7533e5b541 UX: Use date picker on full page search 2017-11-21 12:52:23 -05:00
Joffrey JAFFEUX 7669146897
FIX: force focus input only on expand 2017-11-21 18:23:49 +01:00
Robin Ward 628275fc31 FIX: Some badge routes were still working even with badges disabled 2017-11-21 12:22:44 -05:00
Joffrey JAFFEUX 9444c31918
FIX: makes typing indicator visible when possible 2017-11-21 18:07:10 +01:00
Joffrey JAFFEUX 3dfc0777df
FIX: close on click outside 2017-11-21 17:37:13 +01:00
Joffrey JAFFEUX 00e9805e23
FIX: category descriptions should display html 2017-11-21 17:31:26 +01:00
Joffrey JAFFEUX 2087d011df
FIX: fix bugs with keyboard events 2017-11-21 16:59:03 +01:00
Joffrey JAFFEUX b5ed980235
FIX: reflects discourse icons naming scheme s/d-icon-*/d-* 2017-11-21 16:01:15 +01:00
Joffrey JAFFEUX f210e1660d
uses correct path for component connector 2017-11-21 16:00:49 +01:00
Joffrey JAFFEUX b76154ec36
minor refactoring of component-connector 2017-11-21 15:48:56 +01:00
Joffrey JAFFEUX 5dd890eb3d
FIX: displayCategoryDescription was not working correctly 2017-11-21 15:38:30 +01:00
Joffrey JAFFEUX b8c95373be
uses right naming for search-advanced-category-chooser component 2017-11-21 14:47:53 +01:00
Arpit Jalan 753a4fc369 UX: make onebox timestamp consistent with header 2017-11-21 16:39:15 +05:30
Joffrey JAFFEUX 39f3dbd945
Introduces select-kit
* renames `select-box-kit` into `select-kit`
* introduces `single-select` and `multi-select` as base components
* introduces {{search-advanced-category-chooser}} as a better component for selecting category in advanced search
* improves events handling in select-kit
* recreates color selection inputs using {{multi-select}} and a custom {{selected-color}} component
* replaces category-selector by a component using select-kit and based on multi-select
* improves positioning of wrapper
* removes the need for offscreen, and instead use `select-kit-header` as a base focus point for all select-kit based components
* introduces a formal plugin api for select-kit based components
* introduces a formal pattern for loading and updating select-kit based components:

```
computeValue()
computeContent()
mutateValue()
```
2017-11-21 11:53:09 +01:00
Régis Hanol c4d0eb802e FIX: delete upload records when sha is null 2017-11-21 10:20:42 +01:00
Guo Xiang Tan f7642e076d REFACTOR: Avoid duplicated logic on server and client. 2017-11-21 17:10:04 +08:00
Régis Hanol 2d48caffdf FIX: be more lenient when deleting a custom emoji 2017-11-20 23:50:23 +01:00
Neil Lalonde dcd60dcc8f FIX: cap posts_read_count in user_stats to 50 posts per topic_entered 2017-11-20 17:15:05 -05:00
Robin Ward f8164956dd Add quote and mention support for username formatters 2017-11-20 16:28:03 -05:00
Robin Ward c53ed61bd3 UX: There were many places where username formatters were not applied 2017-11-20 15:03:13 -05:00
Robin Ward b9595966d4 FIX: Error applying quotes with blank lines in front 2017-11-20 13:46:19 -05:00
Robin Ward 0a9daba627 FIX: Support for long suspension emails 2017-11-20 12:45:46 -05:00
Neil Lalonde 8496191f0b UX: better tooltip for read time on user cards 2017-11-20 11:55:22 -05:00
Sam 7e841a0495 FIX: stop counting PMs, deleted topics and whispers in directory and user stats 2017-11-20 16:44:09 +11:00
Guo Xiang Tan a27dd760b9 FIX: Incorrect group path. 2017-11-20 09:55:15 +08:00
Sam ff1ce175fc FIX: sometimes quote button did nothing on Firefox 2017-11-20 11:14:44 +11:00
Gerhard Schlager 92a831bae6 FEATURE: user directory returns staged users during search 2017-11-19 01:17:31 +01:00
Neil Lalonde 6dda87c49b FEATURE: show topics viewed on user summary 2017-11-17 17:53:30 -05:00
Neil Lalonde 7c6f991313 REFACTOR: remove AgeWord calls from serializers and do it in javascript 2017-11-17 17:53:30 -05:00
Kris 4daaa3544b mobile topic adjustments 2017-11-17 16:57:25 -05:00
Neil Lalonde 87ec11e298 FIX: more accurate counting of posts read. Skipping to the end of a topic does not count all posts as read in user stats. 2017-11-17 16:08:46 -05:00
Robin Ward 3785429948 FIX: Missing word boundaries when non-regexp 2017-11-17 14:37:31 -05:00
Robin Ward d755c9c90f FIX: Allow regular expressions to specify boundaries 2017-11-17 14:13:44 -05:00
Joffrey JAFFEUX faa597ff90
FIX: avoids view jumping on mobile 2017-11-17 07:31:57 -08:00
Gerhard Schlager d47fa6653b do not notify staged users about posts withing mailinglist mirror category 2017-11-17 15:29:14 +01:00
Gerhard Schlager 8f6d35aa59 FEATURE: category setting for mailinglist mirror 2017-11-17 15:29:14 +01:00
Régis Hanol ddd4ddc020 missing 1px in .posters column when there are 5 posters and OP is most recent poster 2017-11-17 12:42:19 +01:00
Michael Howell c7d024446e Cast the numeric keys of `USER_HOMES` to numbers (#5322)
When converting from hard-coded functions to a map,
the key `1` got converted to `"1"`.
This broke the drop-down menu.
2017-11-17 11:01:18 +11:00
Neil Lalonde b37e40eea9 FEATURE: show read time in last 60 days 2017-11-16 15:46:51 -05:00
Kris 3d145a588f fixing an inconsistency that was cuasing some theme issues (#5320) 2017-11-16 12:44:00 -05:00
Robin Ward 54db283e31 Small code tidy up for user/activity menu 2017-11-16 11:49:14 -05:00
Régis Hanol 678e28794a FIX: properly handle too large & broken images in posts 2017-11-16 15:45:07 +01:00
Sam 174ab2d93a minor, ensure ordering of custom fields is consistent 2017-11-16 15:14:10 +11:00
Sam 9c22c68d39 FIX: only save custom fields if they actually change 2017-11-16 15:14:10 +11:00
Robin Ward c2e70a8cc9 FIX: This class is no longer required and leaves the state as `hidden` 2017-11-15 17:35:24 -05:00
Sam 20fbf81505 FEATURE: Allow plugins to easily add defaults to GlobalSetting
usage:

GlobalSetting.add_default("plugin_setting_name", "value")
2017-11-16 08:39:29 +11:00
Kris fa9efb799c fixing some button issues on mobile posts 2017-11-15 14:52:33 -05:00
Gerhard Schlager 9207dee69a FEATURE: escape HTML when cooking plaintext emails 2017-11-15 20:22:11 +01:00
Robin Ward cef64e8f03 UX: Use `no_ember` styling for omniauth error page 2017-11-15 14:04:26 -05:00
Robin Ward 9e03b5c69a FIX: Don't load other locales in test mode 2017-11-15 12:50:20 -05:00
Robin Ward fc73de9578 Support for finding new locales in plugins 2017-11-15 11:20:04 -05:00
Robin Ward 44081bdf73 FIX: Moderators couldn't delete spammers via flag modal 2017-11-15 10:46:09 -05:00
Vinoth Kannan cbc0afb399 REFACTOR: Instance methods added to 'PluginStore' model for easy access (#5315) 2017-11-15 10:10:20 -05:00
Vinoth Kanan c025fcffa5 UX: Large image placeholder alignment fix 2017-11-15 18:50:16 +05:30
Arpit Jalan 2e7c61681e PERF: n+1 query when fetching search_logs 2017-11-15 16:23:57 +05:30
Vinoth Kannan 7b494a65c9 NEW: large image placeholder added in cooked html (#5291) 2017-11-15 11:30:47 +01:00
Vinoth Kanan 9ed16343fc Remove email column from schema information 2017-11-15 15:45:19 +05:30
Gerhard Schlager 0d8ddaf4ab FIX: notification dropdown was not visible for group archive
was causing empty message list when navigation back from group message
2017-11-15 10:17:42 +01:00
Arpit Jalan ee1f68438e UX: sort search logs results by unique searches 2017-11-15 12:58:40 +05:30
Sam 813e21d0e8 FIX: current user serializer consistently returns {} for custom_fields
Resolves: #5210
2017-11-15 11:55:37 +11:00
OsamaSayegh 4c4410225e UX: cap likes 2 (#5237) 2017-11-15 11:28:54 +11:00
Arpit Jalan 3831663fea FEATURE: search logs page (#5313) 2017-11-15 11:13:50 +11:00
Robin Ward 7ecc15cad1 FIX: Expansion of user posts was broken 2017-11-14 17:07:12 -05:00
Robin Ward d07ebf9d4c UX: Support for custom error pages and headers in plugins 2017-11-14 16:31:44 -05:00
Robin Ward 1c56e1c063 Support for HTML builders on the no-ember view 2017-11-14 16:04:27 -05:00
Robin Ward 0e2b9d3c10 UX: Make flag dropdown actions more clear 2017-11-14 15:44:16 -05:00
Robin Ward 77594ab107 UX: Add class for targeting 2017-11-14 14:42:42 -05:00
Robin Ward 971e302ff2 FEATURE: Support an end date for user silencing 2017-11-14 13:20:19 -05:00
Robin Ward 52480d554a UX: Support for custom 404 pages 2017-11-14 11:57:17 -05:00
Joffrey JAFFEUX 680696fc04
Replaces delete flag modal by a dropdown 2017-11-14 07:55:08 -08:00
Gerhard Schlager 4be8f17e66 FIX: counting invites didn't work
PostgreSQL reported the following error:
"for SELECT DISTINCT, ORDER BY expressions must appear in select list"
2017-11-14 11:40:07 +01:00
Régis Hanol ba2209f7d7 FIX: always clean up uploads with no sha1 2017-11-14 10:56:10 +01:00