Commit Graph

220 Commits

Author SHA1 Message Date
Joe c3560a66f3 DEV: CSS truncation followup
After merging this

58fe78bf28 (diff-fed21847d651f6eb2cc76abbd770f5f8)

I noticed that the code I'm removing in this commit is causing text to be truncated a bit early on desktop. So, I'm removing it for now.
2020-09-01 02:01:17 +08:00
Joe 58fe78bf28 UX: don't wrap topic status icons in the header if there's more than one
Context: https://meta.discourse.org/t/when-a-topic-is-closed-and-pinned-the-pin-icon-in-header-not-in-correct-place/162473

Flex is causing a bit of a problem here since it makes the `topic-statuses` div in the header wrap when it has more than one icon. Given that we already use grid on the parent and that the icons are aligned properly, I think it's safe to remove it here.
2020-09-01 00:40:42 +08:00
Penar Musaraj c937afc75e
FEATURE: automatic dark mode (#10341)
A first step to adding automatic dark mode color scheme switching. Adds a new SCSS file at `color_definitions.scss` that serves to output all SCSS color variables as CSS custom properties. And replaces all SCSS color variables with the new CSS custom properties throughout the stylesheets. 

This is an alpha feature at this point, can only be enabled via console using the `default_dark_mode_color_scheme_id` site setting.
2020-08-03 22:57:10 -04:00
Penar Musaraj 25dcc577ae
DEV: More color transformation refactoring 2020-07-29 12:01:12 -04:00
Kris 074fa5cb18 Follow-up Safari fixes for 89f6ff1 2020-07-27 20:45:29 -04:00
Kris 89f6ff1574 Prevent topic title from clipping some characters due to overflow 2020-07-27 17:26:48 -04:00
Kris ee88666bad
FEATURE: Improve header meta alignment and truncation with css grid (#10238) 2020-07-15 19:30:35 -04:00
Kris 0ee796f66d revert 4afbcb9 2020-05-04 19:40:51 -04:00
Kris 4afbcb9872 Minor header title spacing reduction 2020-04-30 23:19:32 -04:00
Martin Brennan b79ea986ac
FEATURE: High priority bookmark reminder notifications (#9290)
Introduce the concept of "high priority notifications" which include PM and bookmark reminder notifications. Now bookmark reminder notifications act in the same way as PM notifications (float to top of recent list, show in the green bubble) and most instances of unread_private_messages in the UI have been replaced with unread_high_priority_notifications.

The user email digest is changed to just have a section about unread high priority notifications, the unread PM section has been removed.

A high_priority boolean column has been added to the Notification table and relevant indices added to account for it.

unread_private_messages has been kept on the User model purely for backwards compat, but now just returns unread_high_priority_notifications count so this may cause some inconsistencies in the UI.
2020-04-01 09:09:20 +10:00
Dan Ungureanu 5905930c32
FIX: Sync Ember and non-Ember layouts (#9028) 2020-02-25 15:31:04 +02:00
Krzysztof Kotlarek f59647cd55
FIX: move IE specific CSS rules to discourse-internet-explorer plugin (#8567) 2019-12-18 15:25:16 +11:00
Kris b066a4128d Adding a text-overflow: ellipsis; mixin and related cleanup 2019-11-06 14:00:29 -05:00
Joe 5276a827dd
UX: small follow-up to #8047 2019-08-28 16:52:46 +08:00
Joe d14851e552 UX: better alignment for tags in the header (#8047)
* Removes unused styles

This commit only removes unnecessary / duplicate styles. It does not cause any visual changes.

* adds class to `<h1>` tag in header topic info.

This is much better to target than `h1`

* removes unused styles

* header title margin adjustment

* minor header-title margin adjustments

* One more header-title margin adjustment
2019-08-28 18:18:27 +10:00
Arpit Jalan 324e182842
FEATURE: show login and signup button on no-ember layout (#7867) 2019-07-09 04:51:19 +05:30
Robin Ward b58867b6e9 FEATURE: New 'Reviewable' model to make reviewable items generic
Includes support for flags, reviewable users and queued posts, with REST API
backwards compatibility.

Co-Authored-By: romanrizzi <romanalejandro@gmail.com>
Co-Authored-By: jjaffeux <j.jaffeux@gmail.com>
2019-03-28 12:45:10 -04:00
Joe 6d7c0c8f13
REFACTOR: scroll-based mobile header switch
This refactor addresses the following issues:

1- Moves all relevant logic to the discourse-topic component (matches desktop)
2- Fixes the flicker issue discussed here
3- Fixes a rare occurring issue where tags wrap to a third line if a topic has long category names and lots of tags
4- Fixes header icon jitter on iOS
5- Fixes an issue where sliding out user / hamburger menus on Android leaves the user in a mid-state with half a title and the header panel visible - swiping will now open the menus but have no effect on the header.
6- adds min-width to the small-logo to act as placeholder so that the title doesn't shift if the logo takes a while to load.

Other than that, everything should look and act the same.
2019-03-19 18:39:38 +08:00
Kris bbaa3e9166 Header icon focus color fix 2019-01-31 19:31:09 -05:00
Kris 94f16ba931 UX: Make button icons use lighter color instead of opacity 2019-01-31 13:59:49 -05:00
Kris e6e4a073a5 alignment fix due to font-size bump 2019-01-18 16:24:27 -05:00
Kris 9f52306861 Keep avatar image at native size for normal font-size, remove unneeded clearfix 2019-01-17 21:54:22 -05:00
Kris 43bb16de27 Prevent header icons from overflowing with long title present 2019-01-17 16:11:40 -05:00
Kris 7401901939 UX: Badge alignment adjustments 2019-01-17 15:46:55 -05:00
Kris cfb8e157a2 Fixing tag alignment 2019-01-08 16:25:11 -05:00
Joe effb3262a1
UX: no need for margin if participants is first-child 2019-01-06 00:11:53 +08:00
Joe 3a9fea4409
align and truncate header tags and participants 2019-01-05 23:09:44 +08:00
Vinoth Kannan 046e4ab413 FIX: Improve topic small header alignment in mobile
Force topic-header-extra height to 20px
2019-01-05 14:06:06 +05:30
Vinoth Kannan aba18a42a7 UX: Improve PM small header alignment with recipient avatars 2019-01-05 03:51:15 +05:30
Kris a2f1d47506 Slightly better alignment of PM participants in header 2019-01-03 22:47:56 -05:00
Vinoth Kannan 0884cd218d UX: Add group name next to PM recipient avatar
Also changed group icon color and did minor refactoring
2019-01-02 15:26:42 +05:30
Joe 55d745f03b
UX: header needs a bit of padding on narrow screens
A bit of history

https://meta.discourse.org/t/header-on-responsive-window/105204
2018-12-31 14:33:02 +08:00
Vinoth Kannan 021f11b68e FEATURE: Display avatars of PM recepients in small topic header when scrolling down 2018-12-30 20:10:40 +05:30
Kris 3710b01660 Header was 16px too narrow due to border-box and padding 2018-12-18 20:38:43 -05:00
Kris c84b837d50 category badge alignment fix 2018-12-08 22:33:11 -05:00
Kris 050c02228e UX: Globally dim categories slightly 2018-12-07 20:01:38 -05:00
Kris b26d0f20cc Fixing slight misalignment of login/signup buttons 2018-12-07 13:56:54 -05:00
Kris db32d29eaa UX: Refactoring topic statuses for consistent icon sizes & colors 2018-12-06 19:22:04 -05:00
Joe 336436dfb4
UX: better handling of logo size 2018-11-23 22:04:42 +08:00
Joe ee6c0170ce FEATURE: Scroll-based logo on mobile (#6632) 2018-11-21 21:21:49 -05:00
Kris 7a1a1eb4c0 improve header scaling with font size 2018-07-27 16:49:28 -04:00
Joffrey JAFFEUX 174d392e5a
DEV: adds prettier (#5956)
Run `prettier --write "app/assets/stylesheets/**/*.scss" "plugins/**/*.scss"` after making sure you installed it with `yarn`

It's recommended to configure your editor to run prettier on file save.
2018-06-08 11:49:31 +02:00
Kris a4b8813a02 FIX: Header nav should be tabbable and have focus state 2018-04-13 12:53:04 -04:00
Kris 0f07999c11 FIX: Safari flexbox bug in header dropdowns 2018-03-09 15:58:53 -05:00
Kris 62d1ba4fdb Menu fix for iOS 2018-03-05 11:32:43 -05:00
Kris 70acfa47d7 FIX: In some instances expanding hamburger menu broke layout in iOS 2018-03-02 14:13:43 -05:00
Kris b731d5d9b5 Removing unneeded and duplicate styles 2018-02-23 21:43:05 -05:00
Kris ce97bdb472 Flag badge too wide in header panels 2018-02-20 17:31:02 -05:00
Kris 677e126fbf UX: Implementing a box-shadow system, cleaning up existing shadows 2018-02-20 12:18:20 -05:00
Kris a2327b4897 login button alignment fix 2018-02-16 17:13:10 -05:00
Kris 35a49a240a UX: Improving header scalability for large font themes 2018-02-16 15:58:10 -05:00
Kris a9e0c6a685 FIX: Flags notification badge becomes too narrow when menu is open 2018-01-22 14:02:07 -05:00
Robin Ward 8d454156b3 Rename css class to something that makes more sense 2018-01-17 11:38:43 -05:00
Kris 0c01e0b2fe
UX: Implementing a z-index system (#5507) 2018-01-16 19:05:12 -05:00
Kris 674013129a
UX: Type system rebuild (#5492) 2018-01-12 17:27:38 -05:00
Kris 9876f3d0ee FIX: extraneous mobile CSS, flagged badge color in dropdown 2017-11-30 17:29:29 -05:00
Joffrey JAFFEUX dd5562322b Revert "FIX: reflects discourse icons naming scheme s/d-icon-*/d-*"
This reverts commit b5ed980235.
2017-11-23 18:24:26 +01:00
Joffrey JAFFEUX b5ed980235
FIX: reflects discourse icons naming scheme s/d-icon-*/d-* 2017-11-21 16:01:15 +01:00
Kris dc2d9f05dc removing scale-color, first pass 2017-10-13 11:57:10 -04:00
Robin Ward 81e576ae37 FIX: Missing color on queued posts dropdown 2017-09-11 09:47:16 -04:00
Robin Ward 238557883f FIX: queued posts had a red background 2017-09-10 14:26:55 -04:00
Robin Ward f6fb94d31f UX: Flags lost their red color on dropdown 2017-09-07 16:22:31 -04:00
Robin Ward a1957b7723 FIX: Stop moving notifications on large screens 2017-09-06 17:35:35 -04:00
Robin Ward 825452df76 Refactor header CSS for composability 2017-09-06 11:34:10 -04:00
Robin Ward 777f024b8c Clean up weird indentation 2017-09-06 11:34:10 -04:00
Robin Ward 6dfa3625df REFACTOR: Replace `fa-*` in SCSS with `d-icon-*` 2017-07-27 15:09:30 -04:00
awesomerobot c29b7aa65d initial pass at color simplification 2017-07-14 21:43:35 -04:00
Guo Xiang Tan a6b86036ca FIX: Workaround `box-shadow` and `box-radius` bug on safari. 2016-11-16 18:22:59 +08:00
Guo Xiang Tan 5613c5f81a UX: Add "spotlight" on first notification. 2016-11-15 10:57:16 +08:00
Guo Xiang Tan a8b7599d4a FEATURE: Add a radial ping when user's first notification has not been read. 2016-11-08 16:23:12 +08:00
Robin Ward 2cf4107a67
FIX: Safari icon positioning 2016-04-29 11:44:11 -04:00
Robin Ward 6fb46fe217
UX: Notification was in the wrong place. 2016-04-25 17:52:38 -04:00
Robin Ward 514c3976f0
PERF: Migrate header to discourse widgets 2016-04-25 10:48:04 -04:00
Neil Lalonde 7dd89be741 FIX: text title in header should use header primary colour instead of blue 2016-03-21 14:32:00 -04:00
Sam 37ccfbdb2a Revert "FIX: vertical centering of header, using display: table"
This reverts commit 1b4e0f3300.
2016-03-18 14:29:39 +11:00
Neil Lalonde 1b4e0f3300 FIX: vertical centering of header, using display: table 2016-03-17 17:36:20 -04:00
Robin Ward f3748ce0a9 Add new outlet for plugin notifications, plus use right alignment 2015-12-11 16:42:21 -05:00
Jeff Atwood 5d341bef57 remove valign-helper hack, let's go flexbox 2015-10-20 00:46:24 -07:00
Sam c2e9644558 Revert "flexbox for the post header"
This reverts commit bef3084516.
2015-09-02 12:20:35 +10:00
awesomerobot bef3084516 flexbox for the post header 2015-09-01 10:38:37 -04:00
Robin Ward a10e9ed232 FIX: Super sized badge 2015-08-31 16:49:46 -04:00
Robin Ward f34f3a0f44 UX: Move flags to left side of hamburger 2015-08-31 15:33:17 -04:00
Robin Ward e2b7b2f2cf FIX: Don't outline buttons when menu is in slide out 2015-08-31 15:30:51 -04:00
Robin Ward 3ae5a0a2df UX: Merge notifications and user dropdown 2015-08-28 16:11:40 -04:00
Robin Ward d4b987ff32 Migrate search drop down to `menu-panel` component. 2015-08-28 15:44:24 -04:00
Robin Ward c5460b7d3f FEATURE: Full height hamburger menu
- Rename `site-map` to `hamburger-menu`
- Includes acceptance tests
2015-08-25 16:48:43 -04:00
Kane York 5205ec3b1e FIX: Hover highlights in top menus 2015-08-21 12:47:15 -07:00
Jeff Atwood d38c4d5f74 scale-color $lightness must use $secondary for dark themes 2015-08-20 02:42:12 -07:00
Kane York 924e67af9d FIX: Header icons should be header_primray in dark theme 2015-08-18 15:11:49 -07:00
Kane York 13fdd35517 Revert "FIX: Header icons should be header_primary exactly"
This reverts commit 4d0c328404.
2015-08-18 15:11:13 -07:00
Kane York 4d0c328404 FIX: Header icons should be header_primary exactly 2015-08-18 14:37:23 -07:00
Jeff Atwood 2b2ae4bfe7 Revert "adding flexbox to header via mixins (all prefixes)"
This reverts commit 5b229316ee.
2015-08-04 15:56:05 -07:00
awesomerobot 5b229316ee adding flexbox to header via mixins (all prefixes) 2015-08-04 10:46:58 -04:00
Sam 83593fea58 Revert "aligning text-logos and header with flexbox"
This reverts commit 2ad2ab503f.
2015-08-04 14:49:08 +10:00
awesomerobot 2ad2ab503f aligning text-logos and header with flexbox 2015-08-03 21:16:56 -04:00
Sam d647835afe UX: no red hearts in notifications
red hearts there call special attention to likes and emphasize likes over replies
2015-07-23 07:53:15 +10:00
Guo Xiang Tan 876f0b7dc9 UX: Give fa-hearts more love. 2015-07-22 23:52:55 +08:00
Sam 160ee67620 Merge pull request #3571 from tgxworld/fix_header_not_dismissing_on_click
UX: Dropdown not dismissing until next page renders.
2015-07-09 11:49:58 +10:00
Arpit Jalan d07adc9d72 UX: fix login button 2015-07-06 18:12:37 +05:30
Guo Xiang Tan 5c93188bc9 UX: Make category links heading take the entire width. 2015-06-29 22:02:22 +08:00