87537b679c
Drop `reply_key`, `skipped` and `skipped_reason` from `email_logs`.
2018-07-30 11:39:28 +08:00
ccf76d45f2
FIX: Missing variable outside of `begin` block.
2018-07-27 08:19:11 +08:00
796639a797
FIX: makes disk_space computation more resilient ( #6172 )
2018-07-25 11:04:01 -04:00
c3b6811651
PERF: Split loading of posts to speed up user renames
2018-07-24 11:57:04 +02:00
fad9c2b971
PERF: Move `EmailLog#reply_key` into new `post_reply_keys` table.
2018-07-24 13:51:53 +08:00
ae8b0a517f
PERF: Split skipped email logs into a seperate table.
2018-07-24 13:14:37 +08:00
f8e9190617
FEATURE: Retry web hook when it is failed
2018-07-23 10:12:04 +08:00
06323f9c89
FIX: takes old dashboard out of caching job
2018-07-21 12:42:03 -04:00
0972dd2552
FIX: takes dashboard-next out of caching job
2018-07-21 11:13:15 -04:00
1d5096eb46
FIX: lazy load more reports in dashboard
2018-07-20 23:35:53 -04:00
1a78e12f4e
FEATURE: part 2 of dashboard improvements
...
- moderation tab
- sorting/pagination
- improved third party reports support
- trending charts
- better perf
- many fixes
- refactoring
- new reports
Co-Authored-By: Simon Cossar <scossar@users.noreply.github.com>
2018-07-19 14:33:11 -04:00
6d6e026e3c
FEATURE: selectable avatars
2018-07-18 12:57:43 +02:00
91266cdabb
correct auto bump topic logic
2018-07-17 09:33:33 +10:00
ac0053f491
FEATURE: navigate to first post and auto bump category settings
...
### navigate_to_first_post_after_read setting for categories
When enabled on categories logged on users will return to OP after
reading the entire category. (useful for documentation categories)
### num_auto_bump_daily
Set a number of topics that will automatically bump daily on a category.
- Every 15 minutes we will check if any category has this setting
- Categories with the setting are shuffled
- We exclude pinned, closed, category description and archived topics
- Maximum of 1 topic for the list of categories is bumped till limit reached per category
- We always try to bump oldest first
- Limit is elastic using a RateLimiter that ensures that we only bump N per day
Also some minor organisation on category settings
Froze strings on category.rb
2018-07-16 18:10:35 +10:00
4172e1dd52
FIX: Rename `User#usernames` that clashes with `Group#name`. ( #6069 )
2018-07-09 16:54:57 +08:00
f7322c05ad
FIX: Avoid `destroy_all` in `Jobs::CleanUpUploads`.
...
`destroy_all` loads all the relation into memory as once.
See https://github.com/rails/rails/issues/22510
2018-07-02 12:44:36 +08:00
7550e9ff95
FIX: purge unactivated users with a message from non-human users
2018-06-29 13:03:04 +05:30
c5e24da5dd
Update poll_mailbox.rb
2018-06-25 16:18:07 +10:00
cbaf521fc1
correct regression and add integrity spec for onceoffs
2018-06-20 09:09:31 +10:00
5f64fd0a21
DEV: remove exec_sql and replace with mini_sql
...
Introduce new patterns for direct sql that are safe and fast.
MiniSql is not prone to memory bloat that can happen with direct PG usage.
It also has an extremely fast materializer and very a convenient API
- DB.exec(sql, *params) => runs sql returns row count
- DB.query(sql, *params) => runs sql returns usable objects (not a hash)
- DB.query_hash(sql, *params) => runs sql returns an array of hashes
- DB.query_single(sql, *params) => runs sql and returns a flat one dimensional array
- DB.build(sql) => returns a sql builder
See more at: https://github.com/discourse/mini_sql
2018-06-19 16:13:36 +10:00
12fd0b827e
PERF: release results in a couple of cases
2018-06-13 15:11:43 +10:00
2564a8285d
REFACTOR: Run some parts of user anonymizing in background job
2018-06-08 15:50:07 +02:00
ad5082d969
Make rubocop happy again.
2018-06-07 13:28:18 +08:00
d600e71b3d
FIX: Clean up stale `UserExport` records daily.
...
* Add tests for `UserExport.remove_old_exports`
2018-06-05 09:43:40 +08:00
6024fb84cc
make rubocop happy
2018-06-04 19:06:52 +02:00
ab8cdd6b5b
Upload.url can't be NULL
2018-06-04 18:43:00 +02:00
085eaaf18d
FIX: always delete invalid upload records
2018-06-04 18:40:57 +02:00
587a9c82f5
FIX: Use the username formatter when updating cooked usernames
2018-05-25 17:29:06 -04:00
71f66cd679
FIX: ensure PostAlerter is always run in sidekiq
2018-05-24 17:27:43 +02:00
cafd1241b9
FIX: make report data export more resilient to inconsistent date format
...
The DAU/MAU report export was failing because of date being a string
and not a valid Date value
2018-05-24 17:14:08 +05:30
43f7cb05c9
FIX: Broken ping event for web hooks due to missing payload.
2018-05-24 15:16:52 +08:00
95db5f0c8c
FIX: Do not replace wrong avatars when renaming user
2018-05-22 13:41:51 +02:00
24abf38d38
PERF: lower the priority on user emails
...
User emails can wait behind other regular jobs, they are usually somewhat
slower as they involve smtp transactions
2018-05-22 15:20:55 +10:00
bf84037f79
FIX: Payload for webhooks should be current as of the time the event was triggered.
...
https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752
2018-05-21 17:29:58 +08:00
1841dd48dc
FIX: revert utf-8 encode changes
2018-05-20 17:50:36 +05:30
9512796ef6
FIX: check for blank response when polling feed
2018-05-18 17:00:44 +05:30
1ff767559d
Fix incorrect param.
2018-05-18 14:05:45 +08:00
c42b65df5f
`find` raises an error if the record is missing.
2018-05-18 13:37:07 +08:00
238a13643d
FIX: handle missing users when sending push notifications
2018-05-17 12:53:19 +05:30
39aceed63d
FIX: don't purge unactivated users with a message
2018-05-16 18:24:11 +02:00
146f634c8f
FIX: UTF-8 encode feed response body
2018-05-16 12:59:23 +05:30
21e0b7c818
avoid async report pattern and replace with simpler hijack
2018-05-16 16:05:03 +10:00
74c4af279a
Improvements to user renaming
...
* don't update search index if post belongs to deleted topic
* log errors instead of crashing when updating post or revision fails
* update mentions even when the href attribute is missing
* run the background job with low priority
* replace username in all notifications
* update `action_code_who` used by small action posts
2018-05-15 21:05:51 +02:00
2e1b5bc8d3
FIX: Transaction in UserAnonymizer prevented avatar from updating
2018-05-15 20:47:58 +02:00
9947c38e1c
UX: support for multiple datasets in one chart
2018-05-15 20:12:03 +02:00
193b6d5651
UX: improve new dashboard
...
- top referred topics
- limit search logs to 8 results
2018-05-15 15:08:36 +10:00
a28c58feb1
FIX: automatic group membership when using SSO
2018-05-15 01:48:30 +02:00
c67c2dc638
FIX: Username update should ignore revisions without raw
2018-05-14 15:22:42 +02:00
8232aba743
FIX: Update search index after renaming user within posts
2018-05-14 13:20:30 +02:00
02cb84847c
FIX: Update avatar in oneboxed posts when renaming user
2018-05-14 13:20:29 +02:00
6332d5040d
UX: switch dashboard to be the new dashboard
...
Also:
- add pageviews
- add problems and version sections
2018-05-14 13:07:59 +10:00
bc9e0d46af
PERF: use cached reports for dashboard if available
2018-05-14 12:01:44 +10:00
9d97e1244e
correct it so when we have no dates we still return graphs
2018-05-14 11:12:52 +10:00
67054d524d
correct missing day from async reports
2018-05-11 15:06:23 +10:00
8a783412b7
UX: improvements to new dashboard
...
- remove inactive user report and replace with posts
- clean up internals so grouping by week happens on client
- when switching periods old report was not destroyed leading to bugs
- calculate trend based on previous interval ... not previous 30 days
- show percentages for mau/dau
- be more careful about utc date usage
- show uniqu and click through rate on search panel
- publish key of report with report so we only load the correct one
- subscribe earlier in channel in case of concurrency issues
2018-05-11 13:30:32 +10:00
2e67998319
Improvements for user renaming ( #5810 )
...
* FEATURE: Update avatars in posts and revisions when user gets renamed
* FIX: Replace username in deleted posts when user gets renamed
* FEATURE: Replace username in notifications when user gets renamed
FEATURE: Update mentions and quotes when user gets merged
2018-05-08 10:02:43 -04:00
ff6be3c2e3
FEATURE: add profile_background fields into SSO ( #5701 )
...
Add profile_background and card_background fields into Discourse SSO.
2018-05-07 10:03:26 +02:00
91b31860a1
Feature: Push notifications for Android ( #5792 )
...
* Feature: Push notifications for Android
Notification config for desktop and mobile are merged.
Desktop notifications stay as they are for desktop views.
If mobile mode, push notifications are enabled.
Added push notification subscriptions in their own table, rather than through
custom fields.
Notification banner prompts appear for both mobile and desktop when enabled.
2018-05-04 15:31:48 -07:00
980972182f
dashboard next: caching, mobile support and new charts
2018-05-03 15:41:41 +02:00
3be3c50c7e
FEATURE: Rename user in mentions and quotes
...
Co-authored-by: Robin Ward <robin.ward@gmail.com>
2018-05-01 13:49:14 -04:00
4f55fbfefa
FEATURE: include report title in PM subject and filename
2018-04-24 22:25:54 +05:30
a1f0c58f23
FIX: export download link was broken
2018-04-20 01:12:41 +05:30
91bf10bd12
FIX: create upload record for exported csv files
2018-04-20 00:27:49 +05:30
0e414d0890
dashboard next: trending search report
...
This commit also improves how data is loaded sync and async
2018-04-19 18:19:21 +02:00
01c061d20d
dashboard next: perf and UI tweaks
...
* cache CORE reports
* adds backups/uploads section
* few css tweaks
2018-04-18 21:30:41 +02:00
7bf9650e96
Remove comment that is no longer accurate.
2018-04-18 14:22:18 +08:00
a16b616861
FEATURE: webhook for flag events
2018-04-13 07:47:58 +05:30
f5febe5843
FIX: date range was inconsistent for admin dashboard reports
2018-04-08 16:49:41 +05:30
434cbc649f
FEATURE: Webhook for tag events
2018-04-04 17:49:20 +05:30
142571bba0
Remove use of `rescue nil`.
...
* `rescue nil` is a really bad pattern to use in our code base.
We should rescue errors that we expect the code to throw and
not rescue everything because we're unsure of what errors the
code would throw. This would reduce the amount of pain we face
when debugging why something isn't working as expexted. I've
been bitten countless of times by errors being swallowed as a
result during debugging sessions.
2018-04-02 13:52:51 +08:00
efb19dbdaf
Merge pull request #5705 from discourse/new_webhooks
...
FEATURE: Webhook for group and category events
2018-04-02 10:53:21 +05:30
90f91bf017
Fix regression due to ee69d58a59.
2018-03-29 10:01:29 +08:00
dc33f2d071
Add new web hook serializers
2018-03-28 17:40:29 +05:30
ee69d58a59
FIX: Tests could get stucked in infinite loop if it fails to resolve IP of a hostname.
2018-03-28 14:49:05 +08:00
347e4eadbc
Don't retry trying to download a file in test.
2018-03-28 12:54:11 +08:00
7311023a52
Merge pull request #5700 from discourse/crawl-block
...
FEATURE: control web crawlers access with white/blacklist
2018-03-27 15:06:03 -04:00
2f61780a49
Remove file that is no longer used.
2018-03-26 10:27:28 +08:00
ced7e9a691
FEATURE: control which web crawlers can access using a whitelist or blacklist
2018-03-22 15:41:02 -04:00
b9abd7dc9e
FEATURE: Shared Drafts
...
This feature can be enabled by choosing a destination for the
`shared drafts category` site setting.
* Staff members can create shared drafts, choosing a destination
category for the topic when it is published.
* Shared Drafts can be viewed in their category, or above the
topic list for the destination category where it will end up.
* When the shared draft is ready, it can be published to the
appropriate category by clicking a button on the topic view.
* When published, Drafts change their timestamps to the current
time, and any edits to the original post are removed.
2018-03-20 17:15:26 -04:00
486bbe9cc2
FIX: Auto re-opened topics should restore category auto close settings.
...
https://meta.discourse.org/t/topic-closed-temporarily-due-to-community-flags-overwrites-category-auto-close-timer/77421
2018-02-27 15:33:31 +08:00
86d12bd44b
FEATURE: search within title using in:title
...
Also
- Significantly improved search ranking, title is treated most strongly
- Adds tag names to the index
- Run search re-indexer more aggressively
- Re-index topic and all posts on category change
2018-02-20 14:41:21 +11:00
33df2d6a02
FIX: data export should fill missing dates with zero value
2018-02-18 23:52:09 +05:30
991dfadad7
FIX: CategoryTagStat queries need to exclude PMs with tags
2018-02-15 12:13:42 -05:00
fdd8ce9722
empty category_tag_stats table before running init job
2018-02-15 11:28:25 -05:00
d8b4627fc8
we have to define this for tests to pass
2018-02-15 13:30:34 +11:00
b5b866aab3
oops
2018-02-15 13:13:31 +11:00
c89b42c488
PERF: only require the rss library if used
...
Before:
Total allocated: 257909321 bytes (2514134 objects)
Total retained: 39681579 bytes (343387 objects)
allocated memory by gem
-----------------------------------
42875979 rss
retained memory by gem
-----------------------------------
2080188 rss
retained objects by gem
-----------------------------------
13052 rss
After:
Total allocated: 210562047 bytes (2252030 objects)
Total retained: 37433816 bytes (328635 objects)
----
So, 2 less megabytes on boot and 13000 objects stuck in ruby heaps forever.
2018-02-15 13:11:33 +11:00
7d501058d7
FIX: don't grant new user of the month badge to suspended users or based on deleted topics/posts
2018-02-13 17:32:38 +01:00
76c309fe6b
PERF: a faster way to count tags used per category
2018-02-12 15:16:47 -05:00
e700e3e882
FIX: post_destroyed webhook event not fired
2018-02-13 01:36:56 +05:30
d7e90edeb5
PERF: Tl3Promotions job can limit the number of TL3 candidates by using some simple requirements in the query
2018-02-05 17:54:36 -05:00
8fe61c68a1
FIX: process_post job should update baked_at and baked_version if it rebakes the post
2018-02-05 11:47:04 -05:00
130974d58d
FIX: automatically unsilence users
2018-02-05 17:45:47 +01:00
d233ecbe34
push updates to backups list to client
2018-01-31 12:05:06 +01:00
77ac14d475
prevent users with a tiny number of posts to dominate the 'new user of the month' leaderboard
2018-01-29 12:09:17 +01:00
47058b29d3
FEATURE: emit external_id field with user webhook
2018-01-22 10:09:26 +11:00
2493648f9c
PERF: calculate topic_counts for tags in an async job so tag queries that include counts are much faster
2018-01-12 11:03:03 -05:00
bc56d86a63
Support ruby 2.5.0
2018-01-09 16:03:17 +01:00
69a90f31fb
FEATURE: Allow Forums to disable the Backups feature
2017-12-21 15:22:04 -05:00
7b58afe677
FIX: ProcessPost job failed for posts that have no user
2017-12-21 14:45:59 +01:00
88a4ec5f1b
FIX: stop forking regular backup jobs
2017-12-21 09:00:48 +11:00
f5a3be750c
PERF: add option to limit how many categories are processed in one call to CategoryFeaturedTopic.feature_topics ( #5446 )
2017-12-20 13:42:29 +11:00
97ceebb570
SECURITY: Don't pass email backup token to sidekiq as a parameter.
...
* This exposes the token in the Sidekiq dashboard which can be
viewed by an admin and defeats the purpose of using a token
in the download backup email ink.
2017-12-18 11:25:22 +08:00
5489cd14c7
Skip validations when fixing `Topic#featured_link` in onceoff job.
2017-12-15 23:45:07 +08:00
11050e5d10
Don't override count value that has been set by query.count
2017-12-13 18:48:46 -08:00
b998efdc94
FIX: do not send mailing list emails to unapproved users
2017-12-13 15:13:17 +11:00
4bd5acec47
FIX: `Topic#featured_link` may contain more than a URL.
2017-12-11 16:36:19 +08:00
3c56c9b637
FIX: strip webhook payload_url
2017-12-11 13:48:11 +05:30
5f318a5241
FEATURE: Replace SimpleRSS with Ruby RSS module ( #5311 )
...
* SPEC: PollFeedJob parsing atom feed
* add FeedItemAccessor
It is to provide a consistent interface to access a feed item's tag
content.
* add FeedElementInstaller
to install non-standard and non-namespaced feed elements
* FEATURE: replace SimpleRSS with Ruby RSS module
* get FinalDestination and download with Excon
* support namespaced element with FeedElementInstaller
2017-12-06 10:45:09 +11:00
b35960fc35
FIX: export admin reports to csv would have 0 rows in the csv file
2017-12-01 15:50:36 -05:00
c128e421c4
FIX: Don't run job if topic timer has already been deleted.
2017-11-30 15:26:26 +08:00
77f90876d3
REFACTOR: Track manual locked user levels separately from groups
2017-11-27 11:23:44 -05:00
4addc5e329
Add missing contexts when destroying users
2017-11-22 15:43:54 +01:00
c4d0eb802e
FIX: delete upload records when sha is null
2017-11-21 10:20:42 +01:00
2d48caffdf
FIX: be more lenient when deleting a custom emoji
2017-11-20 23:50:23 +01:00
dcd60dcc8f
FIX: cap posts_read_count in user_stats to 50 posts per topic_entered
2017-11-20 17:15:05 -05:00
b37e40eea9
FEATURE: show read time in last 60 days
2017-11-16 15:46:51 -05:00
678e28794a
FIX: properly handle too large & broken images in posts
2017-11-16 15:45:07 +01:00
9c22c68d39
FIX: only save custom fields if they actually change
2017-11-16 15:14:10 +11:00
7b494a65c9
NEW: large image placeholder added in cooked html ( #5291 )
2017-11-15 11:30:47 +01:00
971e302ff2
FEATURE: Support an end date for user silencing
2017-11-14 13:20:19 -05:00
ba2209f7d7
FIX: always clean up uploads with no sha1
2017-11-14 10:56:10 +01:00
7370adeae3
FIX: don't delete uploads referenced in drafts or queued posts when using the short_url
2017-11-13 15:01:31 +01:00
1f14350220
Rename "Blocked" to "Silenced"
2017-11-10 14:10:27 -05:00
6def5a344a
Let's be more aggressive with purging old WebHookEvent records.
2017-11-08 14:15:34 +08:00
6090994cdf
FEATURE: Retain the latest 30 days of WebHookEvent records by default.
2017-11-08 14:11:01 +08:00
7c5a71e929
DEV: allow queue_jobs = false in dev
...
your mileage may vary
2017-10-31 13:50:58 +11:00
0abc5f90cd
FIX: Broken link in new user of the month post.
2017-10-30 13:11:29 +08:00
2c15e9c6fe
FIX: search couldn't find tags from before 2017-08-25
2017-10-24 17:55:05 -04:00
d5e369d6cf
Fix weird Rubocop error.
2017-10-23 12:30:28 +08:00
c838f43a75
let's not generate an error when logging errors...
2017-10-18 23:14:13 +02:00
c53f41f4f2
FIX: don't flag watched words when rebaking posts
2017-10-12 15:34:22 -04:00
97395ebb66
FIX: SSO avatar downloads were broken
...
cc @tgxworld
2017-10-12 12:12:04 +05:30
f7282e4ecd
use force_https site setting when adding scheme for downloading schemaless images locally
2017-10-12 00:06:24 +02:00
4e78abb537
let's try 3 times to download images locally
2017-10-11 23:11:44 +02:00
9dcb11f553
Fix the build.
2017-10-11 17:45:19 +08:00
09721090a3
FIX: Ensure that we revert back to default connection after running jobs.
2017-10-11 17:17:03 +08:00
59aeb0bc56
FIX: Sidekiq hot reloading wasn't working in dev.
...
https://meta.discourse.org/t/webhooks-sidekiq-issue-on-dev-instance/71129
* Remove code that is no longer required as well.
2017-10-09 18:23:25 +08:00
4ea87b5ab8
Merge branch 's3_refactor'
2017-10-09 10:27:52 +11:00
70bb2aa426
FEATURE: allow specifying s3 config via globals
...
This refactors handling of s3 so it can be specified via GlobalSetting
This means that in a multisite environment you can configure s3 uploads
without actual sites knowing credentials in s3
It is a critical setting for situations where assets are mirrored to s3.
2017-10-06 16:20:01 +11:00
4ba5e678d8
Require dependencies to enable live reload in dev for Sidekiq.
2017-10-06 11:39:00 +08:00
e212435545
FIX: redirect to top wasn't working
2017-10-04 22:08:41 +02:00
ac666ddf17
PollFeed: check 'content:encoded' for content first
2017-10-02 01:16:11 -04:00
0f2c5f5fc9
FIX: Don't raise error when trying to download avatar from URL.
2017-10-02 12:59:41 +08:00
974836962d
Fix invalid method call.
2017-10-02 12:50:22 +08:00
77ea063751
FIX: Missing attribute.
2017-10-02 10:24:37 +08:00
4eeb6014f4
Don't raise an error if user has been destroyed.
2017-09-30 09:09:40 +08:00
d79fee9ff3
Fix undefined method for Nil class error.
2017-09-28 17:38:53 +08:00
8ecf313a81
FIX: correctly raise errors when downloads fail
...
This corrects an issue where we are hitting Gravatar for 404 over and over
Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
3a75242c38
add more logs to pull hotlinked images
2017-09-28 01:00:13 +02:00
Guo Xiang Tan
Joffrey JAFFEUX
Gerhard Schlager
Vinoth Kannan
Régis Hanol
Sam
Guo Xiang Tan
Arpit Jalan
Ernesto Serrano
Robin Ward
Misaka 0x4e21
Jeff Wong
Neil Lalonde
Jan Suchal
scossar
Kyle Zhao
Vinoth Kannan